[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks almost good. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { sammccall wrote: >

[PATCH] D83705: [clangd] Config: CompileFlags.Remove

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:126 void compile(Fragment::CompileFlagsBlock &) { +if (!F.Remove.empty()) { + auto Remove =

[clang-tools-extra] 7a514c9 - [clangd] Implement textDocument/foldingRange

Author: Kirill Bobyrev Date: 2020-07-14T09:28:42+02:00 New Revision: 7a514c9bf8f2513b57aee685879dd2c104381d99 URL: https://github.com/llvm/llvm-project/commit/7a514c9bf8f2513b57aee685879dd2c104381d99 DIFF:

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a514c9bf8f2: [clangd] Implement textDocument/foldingRange (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 277683. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove llvm::Optional from character fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

vsavchenko added a comment. I do like this change even apart from the `clang-tidy` integration epic. I strongly believe that decoupling (when done right) makes things easier and this change seems like a good first step. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2148834 , @NoQ wrote: > Looks like a copy-paste error indeed. > > @OikawaKirie do you accidentally have a test case to reproduce the crash, so > that we could add it to our regression test suite? 'Cause traditionally

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added a comment. It would be a good idea to emit notes to help explain the problem code, I'm thinking something along the lines of: warning: exit-handler potentially calls a jump function. Handlers should terminate by returning [cert-env32-c] note: exit-handler declared here

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

vsavchenko added a subscriber: vrnithinkumar. vsavchenko added a comment. In D83660#2148834 , @NoQ wrote: > Looks like a copy-paste error indeed. @vrnithinkumar @NoQ looks like a good opportunity for `SmartPtr` checker and `llvm::Optional`!

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. > do you accidentally have a test case to reproduce the crash @NoQ I am now working with the reporter of this bug to make a simple test case to trigger the crash. > looks like a good opportunity for `SmartPtr` checker and `llvm::Optional`! @vsavchenko It seems not

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. > Might in the future I would spend some time on it - we will see. @steakhal My boss always asks me about how to improve the performance for SMT solver based constraint solving, on both the engine side and the SMT solver side. If there is anything that our research

[PATCH] D83701: [analyzer][tests] Add 5 more projects for testing

Szelethus added a comment. Post-commit LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83701/new/ https://reviews.llvm.org/D83701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83539: [analyzer][tests] Introduce analyzer benchmarking framework

vsavchenko added inline comments. Comment at: clang/utils/analyzer/SATestBenchmark.py:139-140 +import matplotlib +import seaborn as sns +from matplotlib import pyplot as plt + NoQ wrote: > Why shorten? It's not that we're saving a lot of typing, and

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277728. sammccall added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/ https://reviews.llvm.org/D81958 Files: clang-tools-extra/clangd/CompileCommands.cpp

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { hokein wrote: > sammccall wrote: > > hokein wrote: > > > add tests

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. >> Maybe spend a few minutes remeasuring `libsoundio` more carefully, just in >> case? > > Sure, will do! It turns out that **libsoundio** has a problem similar to **re2** and varies a lot in terms of the analysis time (probably we can even try to figure out some

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2149509 , @OikawaKirie wrote: > > Might in the future I would spend some time on it - we will see. > > [...] If there is anything that our research group can do, you are free to > contact us. I would use the official

[PATCH] D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is motivated by: - code completion: nice to do no i/o on the request path - background index:

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. In D83286#2148787 , @NoQ wrote: > Data  Thanks  These tables are already generated by a script and I plan to make it into **a phabricator reporter**, so it is easier to put all the data we need here. > Maybe spend a few

[PATCH] D83539: [analyzer][tests] Introduce analyzer benchmarking framework

This revision was automatically updated to reflect the committed changes. vsavchenko marked an inline comment as done. Closed by commit rG5b4f14356450: [analyzer][tests] Introduce analyzer benchmarking framework (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83701: [analyzer][tests] Add 5 more projects for testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG089a0ad8bc99: [analyzer][tests] Add 5 more projects for testing (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83701/new/

[clang] 5b4f143 - [analyzer][tests] Introduce analyzer benchmarking framework

Author: Valeriy Savchenko Date: 2020-07-14T11:42:46+03:00 New Revision: 5b4f143564502664a9d1197d6909047eab49530e URL: https://github.com/llvm/llvm-project/commit/5b4f143564502664a9d1197d6909047eab49530e DIFF:

[clang] 089a0ad - [analyzer][tests] Add 5 more projects for testing

Author: Valeriy Savchenko Date: 2020-07-14T11:42:46+03:00 New Revision: 089a0ad8bc993923817d7957f08bd67dbecd56af URL: https://github.com/llvm/llvm-project/commit/089a0ad8bc993923817d7957f08bd67dbecd56af DIFF:

Re: [clang] dcd76c0 - [Lexer] Fix missing coverage line after #endif

Nice! On Fri, Jul 10, 2020 at 6:05 PM Zequan Wu via cfe-commits wrote: > > > Author: Zequan Wu > Date: 2020-07-10T09:05:20-07:00 > New Revision: dcd76c0c0716a4417110423718c7cae4b516b4d0 > > URL: > https://github.com/llvm/llvm-project/commit/dcd76c0c0716a4417110423718c7cae4b516b4d0 > DIFF: >

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

hokein accepted this revision. hokein added a comment. still lg. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { sammccall wrote: > hokein wrote: > > sammccall wrote: > > > hokein wrote: > >

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG8eb8c92eb469: [clangd] Add library to semantically strip flags by name. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 8eb8c92 - [clangd] Add library to semantically strip flags by name.

Author: Sam McCall Date: 2020-07-14T15:41:46+02:00 New Revision: 8eb8c92eb46908ee9c64dfc4a2f49501b085f682 URL: https://github.com/llvm/llvm-project/commit/8eb8c92eb46908ee9c64dfc4a2f49501b085f682 DIFF: https://github.com/llvm/llvm-project/commit/8eb8c92eb46908ee9c64dfc4a2f49501b085f682.diff

[PATCH] D83700: Fix test for the hasExternalFormalLinkage matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG8978032a17cd: Fix test for the hasExternalFormalLinkage matcher (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83700/new/

[clang] 8978032 - Fix test for the hasExternalFormalLinkage matcher

Author: Dmitri Gribenko Date: 2020-07-14T15:44:53+02:00 New Revision: 8978032a17cd0f1c3925ecb1752fdf59de7f7967 URL: https://github.com/llvm/llvm-project/commit/8978032a17cd0f1c3925ecb1752fdf59de7f7967 DIFF:

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff created this revision. sepavloff added reviewers: rnk, zturner. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Documentation on CreateProcessW states that maximal size of command line is 32767 characters including ternimation null character. In the

[PATCH] D83702: [AIX]Generate debug info for static init related functions

Xiangling_L updated this revision to Diff 277831. Xiangling_L marked 6 inline comments as done. Xiangling_L added a comment. Simplified the testcase; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702 Files:

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

daltenty added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:15 #include "clang/Tooling/ArgumentsAdjusters.h" +#include "llvm/Option/Option.h" +#include "llvm/Support/Allocator.h" This breaks the powerpc64le bots. Looks like we

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand added a comment. Herald added a subscriber: dang. Is anything still pending here (besides the tests, of course)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[clang] 2c2a297 - [clang][NFC] Add 'override' keyword to virtual function overrides

Author: Logan Smith Date: 2020-07-14T08:59:57-07:00 New Revision: 2c2a297bb6d1ce9752a69c8c18a58eacc6d3f961 URL: https://github.com/llvm/llvm-project/commit/2c2a297bb6d1ce9752a69c8c18a58eacc6d3f961 DIFF: https://github.com/llvm/llvm-project/commit/2c2a297bb6d1ce9752a69c8c18a58eacc6d3f961.diff

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ updated this revision to Diff 277861. NoQ added a comment. Remove the `ShouldDisplayPathNotes` option as it never was an `AnalyzerOption` to begin with and it only makes things worse. F12338321: 488ny6.jpg CHANGES SINCE LAST ACTION

[PATCH] D83723: [OpenMP] Generalize CGOpenMPRuntimeNVPTX as CGOpenMPRuntimeGPU

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:39 + // return constant compile-time target-specific warp size + unsigned WarpSize = CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size); + return Bld.getInt32(WarpSize);

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 277796. gamesh411 added a comment. extend with notes apply minor fixes tests are WIP until I figure out how to properly use file-check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277814. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[clang-tools-extra] 50a5fa8 - [clangd] Add missing link dep after 8eb8c92eb46908e

Author: Sam McCall Date: 2020-07-14T17:03:45+02:00 New Revision: 50a5fa8b9ba4b09433bf46f4228d4e4cae9ac486 URL: https://github.com/llvm/llvm-project/commit/50a5fa8b9ba4b09433bf46f4228d4e4cae9ac486 DIFF: https://github.com/llvm/llvm-project/commit/50a5fa8b9ba4b09433bf46f4228d4e4cae9ac486.diff

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. I've got one major issue (inline below), and I'm confused by some other behaviour: When I run `clang --target=riscv64 -mcpu=?`, the list includes both `generic-rv32` and `generic-rv64`. It doesn't show only the 64-bit cpus. This is not changed by giving a full triple,

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 277853. c-rhodes added a comment. Address @sdesmalen comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83550/new/ https://reviews.llvm.org/D83550 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/Attr.td

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb updated this revision to Diff 277806. krisb edited the summary of this revision. krisb added a comment. Changed MSVC -> WIN32 check and simplified the warning fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb marked an inline comment as done. krisb added inline comments. Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER

[PATCH] D83705: [clangd] Config: CompileFlags.Remove

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c16fbd0ac7b: [clangd] Config: CompileFlags.Remove (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D83705?vs=277510=277819#toc Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 6c16fbd - [clangd] Config: CompileFlags.Remove

Author: Sam McCall Date: 2020-07-14T15:56:44+02:00 New Revision: 6c16fbd0ac7b18110891d0f180a2408d55fe47a8 URL: https://github.com/llvm/llvm-project/commit/6c16fbd0ac7b18110891d0f180a2408d55fe47a8 DIFF: https://github.com/llvm/llvm-project/commit/6c16fbd0ac7b18110891d0f180a2408d55fe47a8.diff

[PATCH] D83768: [clangd] Config: Index.Background

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. let's ship it! Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:196 constexpr static llvm::SourceMgr::DiagKind Error

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus accepted this revision. Szelethus marked 2 inline comments as done. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Very well done! In D67420#2149461 , @vsavchenko wrote: > I strongly believe that decoupling

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 marked 10 inline comments as done. gamesh411 added a comment. Thanks @njames93 :) I have extended the check with notes, but I have to figure out how to appease file-check, so its still WIP until I do. Comment at:

[clang] d083adb - Prohibit use of _ExtInt in atomic intrinsic

Author: Mott, Jeffrey T Date: 2020-07-14T06:11:04-07:00 New Revision: d083adb068e781a2fc35aea8c6b7cccd566a735f URL: https://github.com/llvm/llvm-project/commit/d083adb068e781a2fc35aea8c6b7cccd566a735f DIFF:

[PATCH] D83340: Prohibit use of _ExtInt in atomic intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rGd083adb068e7: Prohibit use of _ExtInt in atomic intrinsic (authored by jtmott-intel, committed by erichkeane). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D83768: [clangd] Config: Index.Background

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We only support Build/Skip for now, but with 'Load' or similar as an option for future (load existing

[clang-tools-extra] ff616f7 - [clangd] Cache config files for 5 seconds, without revalidating with stat.

Author: Sam McCall Date: 2020-07-14T17:00:41+02:00 New Revision: ff616f74c3b45e0890b53d92fcfc6a9d18f4bfdd URL: https://github.com/llvm/llvm-project/commit/ff616f74c3b45e0890b53d92fcfc6a9d18f4bfdd DIFF: https://github.com/llvm/llvm-project/commit/ff616f74c3b45e0890b53d92fcfc6a9d18f4bfdd.diff

[PATCH] D83723: [OpenMP][NFC] Generalize CGOpenMPRuntimeNVPTX as CGOpenMPRuntimeGPU

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. I meant to remove just the new virtual function and its new implementation for AMDGCN, you could keep the new class for AMD GPUs. But I'm fine with this too. Repository: rG LLVM Github

[PATCH] D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat.

This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rGff616f74c3b4: [clangd] Cache config files for 5 seconds, without revalidating with stat. (authored by sammccall). Changed prior to commit:

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert marked an inline comment as done. jdoerfert added a comment. I'll address the nits. Unsure if that is all. I also don't get the one comment. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 -

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:328-329 struct Signature { -const ArgTypes ArgTys; -const QualType RetTy; +ArgTypes ArgTys; +QualType

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko added a comment. Thank you! Will probably land it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 ___ cfe-commits mailing list

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

rzurob accepted this revision. rzurob added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83497/new/ https://reviews.llvm.org/D83497

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

krisb accepted this revision. krisb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dang. Sorry for the delays in response, busy days. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83768: [clangd] Config: Index.Background

sammccall updated this revision to Diff 277844. sammccall marked 5 inline comments as done. sammccall added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83768/new/ https://reviews.llvm.org/D83768 Files:

[PATCH] D83768: [clangd] Config: Index.Background

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:196 constexpr static llvm::SourceMgr::DiagKind Error = llvm::SourceMgr::DK_Error; + constexpr static llvm::SourceMgr::DiagKind Warning = + llvm::SourceMgr::DK_Warning;

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

steakhal added a comment. Unfortunately, I'm not qualified enough to have much to say. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:1 +//===--- Env32CCheck.cpp - clang-tidy -===// +// Env32CCheck.cpp

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

bsaleil updated this revision to Diff 277838. bsaleil added a comment. Re-upload with surrounding context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 Files: clang/include/clang/Driver/Options.td

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

bsaleil updated this revision to Diff 277847. bsaleil added a comment. Add test to check `paired-vector-memops` is supported by the targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 Files:

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

bsaleil updated this revision to Diff 277858. bsaleil added a comment. Add test to check that the `mma` option is supported by the targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81442/new/ https://reviews.llvm.org/D81442 Files:

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

Szelethus added inline comments. Herald added subscribers: ASDenysPetrov, martong. Comment at: clang/include/clang/Analysis/IssueHash.h:35 +/// /// In case a new hash is introduced, the old one should still be maintained for /// a while. One should not introduce a new hash

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. Herald added subscribers: ASDenysPetrov, martong. In D67422#1667079 , @NoQ wrote: > Casually rename > `ClangDiagPathDiagConsumer` to `TextDiagnostics` according to the

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

Szelethus added reviewers: Szelethus, martong, steakhal, dkrupp. Szelethus added a comment. @Eugene.Zelenko Thanks for cleaning up revisions -- same as D69560#1725399 , we are working in the same office and have worked on some forms of static analysis

[PATCH] D83768: [clangd] Config: Index.Background

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:98 + ValidValues.push_back(Name); + if (!Result && *Input == Name) +Result = Value; should we assert on multiple matches of the same name ?

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87 + ` check. + Finds functions registered by ``atexit`` and ``at_quick_exit`` that are calling + exit functions ``_Exit``, ``exit``, ``quick_exit`` or ``longjmp``.

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:15 #include "clang/Tooling/ArgumentsAdjusters.h" +#include "llvm/Option/Option.h" +#include "llvm/Support/Allocator.h" daltenty

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added a comment. In D83494#2148868 , @dokyungs wrote: > Addressed Matt's comments. > > A major change in this round that needs explanation is introduction of > FuzzerPlatform.h. Previously I defined `strstr` and `strcasestr` with `extern >

[clang] bfd6433 - Fix merging of two arity-only pack deductions.

Author: Richard Smith Date: 2020-07-14T10:02:07-07:00 New Revision: bfd643353e6b7ca7b89c0f983ff6a24c36aed276 URL: https://github.com/llvm/llvm-project/commit/bfd643353e6b7ca7b89c0f983ff6a24c36aed276 DIFF: https://github.com/llvm/llvm-project/commit/bfd643353e6b7ca7b89c0f983ff6a24c36aed276.diff

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; sdesmalen wrote: > nit: Can you add a comment saying why these are undocumented (and have no > spellings)

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() {

[clang] 438e95e - [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

Author: Francesco Petrogalli Date: 2020-07-14T17:42:28Z New Revision: 438e95e95bfc038aaf7719ad9dc20f57fa424d22 URL: https://github.com/llvm/llvm-project/commit/438e95e95bfc038aaf7719ad9dc20f57fa424d22 DIFF:

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added a comment. In D83717#2150099 , @gamesh411 wrote: > extend with notes > apply minor fixes > tests are WIP until I figure out how to properly use file-check If you add tests for notes, you will need to use `CHECK-MESSAGES-DAG` and

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

rsmith added a comment. Are we at a point where we can test this now? Perhaps by adding an assert in codegen that we always have an evaluated value for any `constexpr` variable that we emit? Comment at: clang/lib/Sema/SemaDecl.cpp:11883-11885 ExprResult Result =

[PATCH] D81508: [PowerPC] Add __vector_pair and __vector_quad types

ABataev added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:160 + // which is 256 and 512 bytes - way over aligned. + bool IsCPUP10OrNewer = CPU == "pwr10" || CPU == "power10" || CPU == "future"; + if (IsCPUP10OrNewer &&

[clang-tools-extra] f88ce07 - [clangd] Make config::Provider::combine non-owning. NFC

Author: Sam McCall Date: 2020-07-14T20:45:02+02:00 New Revision: f88ce078f778886d8dc0408c4ed6344f3332bdd1 URL: https://github.com/llvm/llvm-project/commit/f88ce078f778886d8dc0408c4ed6344f3332bdd1 DIFF: https://github.com/llvm/llvm-project/commit/f88ce078f778886d8dc0408c4ed6344f3332bdd1.diff

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

This revision was automatically updated to reflect the committed changes. Closed by commit rG6014c46c80ca: Restore [WPD/LowerTypeTests] Delay lowering/removal of type tests until after… (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1538 + let Args = [IntArgument<"NumBits">]; + let Documentation = [Undocumented]; +} No new, undocumented attributes, please. Comment at:

[clang-tools-extra] 00d97b7 - [clangd] Config: on by default

Author: Sam McCall Date: 2020-07-14T21:44:25+02:00 New Revision: 00d97b758e8d3286abb7bd07899e4d3aed6e8165 URL: https://github.com/llvm/llvm-project/commit/00d97b758e8d3286abb7bd07899e4d3aed6e8165 DIFF: https://github.com/llvm/llvm-project/commit/00d97b758e8d3286abb7bd07899e4d3aed6e8165.diff

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83053/new/ https://reviews.llvm.org/D83053

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

logan-5 added a comment. In D83611#2151278 , @dblaikie wrote: > If you add/leave the "Differential Revision: https://reviews.llvm.org/D; > line in the commit message (arc will add this line automatically) Phabricator > will close the review for you

[PATCH] D83616: [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbb30c31fefc: [clang] Add override to virtual function overrides generated by… (authored by logan-5). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fbb30c3 - [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter

Author: Logan Smith Date: 2020-07-14T09:36:43-07:00 New Revision: fbb30c31fefcf992ddb287087e8ca766eeddb59d URL: https://github.com/llvm/llvm-project/commit/fbb30c31fefcf992ddb287087e8ca766eeddb59d DIFF: https://github.com/llvm/llvm-project/commit/fbb30c31fefcf992ddb287087e8ca766eeddb59d.diff

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:242 +bool SanitizerArgs::needsFuzzerInterceptors() const { + return needsFuzzer() && !needsAsanRt() && !needsHwasanRt() && + !needsTsanRt() && !needsMsanRt(); HWASan doesn't

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap updated this revision to Diff 277896. Conanap marked 3 inline comments as done. Conanap added a comment. Added tests, added extra comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338 Files:

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

This revision was automatically updated to reflect the committed changes. Closed by commit rG438e95e95bfc: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap added a comment. Also removed instr def as it will be part of D83516 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277909. zequanwu added a comment. Fix failed test cases with sed to remove comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files:

[PATCH] D83788: Removed unused variable in clang

modocache added a comment. By the way, I tried to accept this diff and leave the following inline comment on `SemaExpr.cpp:15799`: > I guess this assert was never capable of being hit previously, since the > `FixItHint::isNull` would always return true? I wonder if we'll now see some >

[PATCH] D83723: [OpenMP][NFC] Generalize CGOpenMPRuntimeNVPTX as CGOpenMPRuntimeGPU

saiislam added a comment. Thank you. I will hold committing till llvm-11 branching so it doesn't break something in any downstream dependent project at the last moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83723/new/

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh requested review of this revision. lildmh added a comment. I'll update the diff and please check and accept after that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 ___ cfe-commits mailing

[PATCH] D83772: [Windows] Fix limit on command line size

amccarth added a comment. I'm jumping in since rnk is on leave and (I believe) zturner is less focused on these issues than he used to be. Thanks for tracking down the cause of this bug. I have some concerns: - We're trying to cut it right up to the hard limit. That seems an unnecessary

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

JonChesterfield added a comment. Agreed on tests. I like the mechanism - passing a string through to the backend as a way to dispatch between isa properties looks cleanly extensible. We probably do want to emit a warning when the backend claims it doesn't know anything about said string as

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added a comment. Alternatively you could do something like this, though it would be a pain https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/test/clang-tidy/checkers/bugprone-argument-comment-gmock.cpp#L86 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83340: Prohibit use of _ExtInt in atomic intrinsic

keryell added a comment. The idea of this `_ExtInt` is to have some extensions. Since it is an extension, why preventing its use? For example if I want my 18 bit FPGA BRAM to be accessed atomically? Or is there an assumption that atomic access can be enabled back with some other mode, such as

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > sdesmalen wrote: > > nit: Can you add a comment saying why these are undocumented (and have

  1   2   3   >