[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 277909. zequanwu added a comment. Fix failed test cases with sed to remove comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files:

[PATCH] D81508: [PowerPC] Add __vector_pair and __vector_quad types

ABataev added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:160 + // which is 256 and 512 bytes - way over aligned. + bool IsCPUP10OrNewer = CPU == "pwr10" || CPU == "power10" || CPU == "future"; + if (IsCPUP10OrNewer &&

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

amyk added a comment. I think the patterns for the load instructions may have accidentally been deleted. Please add them back to the patch. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk added inline comments. Comment at: clang/lib/Headers/altivec.h:17151 + +/* vector shifts for quadwords */ +/* vs[l | r | raq] */ I think we can remove `/* vector shifts for quadwords */`. Then, we can add a new line after `/* vs[l | r | raq] */` for

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277904. dokyungs marked 5 inline comments as done. dokyungs added a comment. Use one CHECK for two subtests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 Files:

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

rsmith added a comment. Are we at a point where we can test this now? Perhaps by adding an assert in codegen that we always have an evaluated value for any `constexpr` variable that we emit? Comment at: clang/lib/Sema/SemaDecl.cpp:11883-11885 ExprResult Result =

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added a comment. In D83494#2150946 , @dokyungs wrote: > I was misled; the error is actually ambiguating new "declarations", not > definitions. The exact error message goes like: > > error: ambiguating new declaration of ‘char*

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 277901. dokyungs added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 Files: clang/include/clang/Driver/SanitizerArgs.h

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added a comment. Alternatively you could do something like this, though it would be a pain https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/test/clang-tidy/checkers/bugprone-argument-comment-gmock.cpp#L86 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 438e95e - [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

Author: Francesco Petrogalli Date: 2020-07-14T17:42:28Z New Revision: 438e95e95bfc038aaf7719ad9dc20f57fa424d22 URL: https://github.com/llvm/llvm-project/commit/438e95e95bfc038aaf7719ad9dc20f57fa424d22 DIFF:

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added a comment. In D83717#2150099 , @gamesh411 wrote: > extend with notes > apply minor fixes > tests are WIP until I figure out how to properly use file-check If you add tests for notes, you will need to use `CHECK-MESSAGES-DAG` and

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

This revision was automatically updated to reflect the committed changes. Closed by commit rG438e95e95bfc: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap added a comment. Also removed instr def as it will be part of D83516 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap updated this revision to Diff 277896. Conanap marked 3 inline comments as done. Conanap added a comment. Added tests, added extra comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338 Files:

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs added a comment. In D83494#2150643 , @morehouse wrote: > In D83494#2148868 , @dokyungs wrote: > > > Addressed Matt's comments. > > > > A major change in this round that needs explanation is introduction of

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

JonChesterfield added a comment. Agreed on tests. I like the mechanism - passing a string through to the backend as a way to dispatch between isa properties looks cleanly extensible. We probably do want to emit a warning when the backend claims it doesn't know anything about said string as

[PATCH] D83707: [OpenMP][NFC] Emit remarks during GPU state machine optimization

jdoerfert updated this revision to Diff 277889. jdoerfert added a comment. Improve wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83707/new/ https://reviews.llvm.org/D83707 Files:

[PATCH] D83790: [clangd] Config: on by default

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. (Possible to flip back on the branch if this breaks things) Repository: rG LLVM Github Monorepo

[clang-tools-extra] dbf486c - [clangd] Config: Index.Background

Author: Sam McCall Date: 2020-07-14T19:04:11+02:00 New Revision: dbf486c0de92c76df77c1a1f815cf16533ecbb3a URL: https://github.com/llvm/llvm-project/commit/dbf486c0de92c76df77c1a1f815cf16533ecbb3a DIFF: https://github.com/llvm/llvm-project/commit/dbf486c0de92c76df77c1a1f815cf16533ecbb3a.diff

[PATCH] D83768: [clangd] Config: Index.Background

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbf486c0de92: [clangd] Config: Index.Background (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D83768?vs=277844=277885#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] bfd6433 - Fix merging of two arity-only pack deductions.

Author: Richard Smith Date: 2020-07-14T10:02:07-07:00 New Revision: bfd643353e6b7ca7b89c0f983ff6a24c36aed276 URL: https://github.com/llvm/llvm-project/commit/bfd643353e6b7ca7b89c0f983ff6a24c36aed276 DIFF: https://github.com/llvm/llvm-project/commit/bfd643353e6b7ca7b89c0f983ff6a24c36aed276.diff

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:242 +bool SanitizerArgs::needsFuzzerInterceptors() const { + return needsFuzzer() && !needsAsanRt() && !needsHwasanRt() && + !needsTsanRt() && !needsMsanRt(); HWASan doesn't

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

miyuki added a comment. I have reproduced the type 1 failure and I confirm that this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 277879. fpetrogalli added a comment. Removed extra tests that are not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/ https://reviews.llvm.org/D83079 Files:

[PATCH] D83616: [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbb30c31fefc: [clang] Add override to virtual function overrides generated by… (authored by logan-5). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fbb30c3 - [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter

Author: Logan Smith Date: 2020-07-14T09:36:43-07:00 New Revision: fbb30c31fefcf992ddb287087e8ca766eeddb59d URL: https://github.com/llvm/llvm-project/commit/fbb30c31fefcf992ddb287087e8ca766eeddb59d DIFF: https://github.com/llvm/llvm-project/commit/fbb30c31fefcf992ddb287087e8ca766eeddb59d.diff

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added a comment. > I'll address the nits. Thanks :) > Unsure if that is all. depends on the comment about `AllocaBuilder` Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 - Builder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI()); - AllocaInst

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() {

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ updated this revision to Diff 277861. NoQ added a comment. Remove the `ShouldDisplayPathNotes` option as it never was an `AnalyzerOption` to begin with and it only makes things worse. F12338321: 488ny6.jpg CHANGES SINCE LAST ACTION

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

bsaleil updated this revision to Diff 277858. bsaleil added a comment. Add test to check that the `mma` option is supported by the targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81442/new/ https://reviews.llvm.org/D81442 Files:

[clang] 2c2a297 - [clang][NFC] Add 'override' keyword to virtual function overrides

Author: Logan Smith Date: 2020-07-14T08:59:57-07:00 New Revision: 2c2a297bb6d1ce9752a69c8c18a58eacc6d3f961 URL: https://github.com/llvm/llvm-project/commit/2c2a297bb6d1ce9752a69c8c18a58eacc6d3f961 DIFF: https://github.com/llvm/llvm-project/commit/2c2a297bb6d1ce9752a69c8c18a58eacc6d3f961.diff

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added a comment. In D83494#2148868 , @dokyungs wrote: > Addressed Matt's comments. > > A major change in this round that needs explanation is introduction of > FuzzerPlatform.h. Previously I defined `strstr` and `strcasestr` with `extern >

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 277853. c-rhodes added a comment. Address @sdesmalen comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83550/new/ https://reviews.llvm.org/D83550 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/Attr.td

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko added a comment. Thank you! Will probably land it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 ___ cfe-commits mailing list

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

bsaleil updated this revision to Diff 277847. bsaleil added a comment. Add test to check `paired-vector-memops` is supported by the targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 Files:

[PATCH] D83768: [clangd] Config: Index.Background

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. let's ship it! Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:196 constexpr static llvm::SourceMgr::DiagKind Error

[PATCH] D83768: [clangd] Config: Index.Background

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:196 constexpr static llvm::SourceMgr::DiagKind Error = llvm::SourceMgr::DK_Error; + constexpr static llvm::SourceMgr::DiagKind Warning = + llvm::SourceMgr::DK_Warning;

[PATCH] D83768: [clangd] Config: Index.Background

sammccall updated this revision to Diff 277844. sammccall marked 5 inline comments as done. sammccall added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83768/new/ https://reviews.llvm.org/D83768 Files:

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. I've got one major issue (inline below), and I'm confused by some other behaviour: When I run `clang --target=riscv64 -mcpu=?`, the list includes both `generic-rv32` and `generic-rv64`. It doesn't show only the 64-bit cpus. This is not changed by giving a full triple,

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

bsaleil updated this revision to Diff 277838. bsaleil added a comment. Re-upload with surrounding context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 Files: clang/include/clang/Driver/Options.td

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert marked an inline comment as done. jdoerfert added a comment. I'll address the nits. Unsure if that is all. I also don't get the one comment. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 -

[PATCH] D83768: [clangd] Config: Index.Background

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:98 + ValidValues.push_back(Name); + if (!Result && *Input == Name) +Result = Value; should we assert on multiple matches of the same name ?

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand added a comment. Herald added a subscriber: dang. Is anything still pending here (besides the tests, of course)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:15 #include "clang/Tooling/ArgumentsAdjusters.h" +#include "llvm/Option/Option.h" +#include "llvm/Support/Allocator.h" daltenty

[clang-tools-extra] 50a5fa8 - [clangd] Add missing link dep after 8eb8c92eb46908e

Author: Sam McCall Date: 2020-07-14T17:03:45+02:00 New Revision: 50a5fa8b9ba4b09433bf46f4228d4e4cae9ac486 URL: https://github.com/llvm/llvm-project/commit/50a5fa8b9ba4b09433bf46f4228d4e4cae9ac486 DIFF: https://github.com/llvm/llvm-project/commit/50a5fa8b9ba4b09433bf46f4228d4e4cae9ac486.diff

[clang-tools-extra] ff616f7 - [clangd] Cache config files for 5 seconds, without revalidating with stat.

Author: Sam McCall Date: 2020-07-14T17:00:41+02:00 New Revision: ff616f74c3b45e0890b53d92fcfc6a9d18f4bfdd URL: https://github.com/llvm/llvm-project/commit/ff616f74c3b45e0890b53d92fcfc6a9d18f4bfdd DIFF: https://github.com/llvm/llvm-project/commit/ff616f74c3b45e0890b53d92fcfc6a9d18f4bfdd.diff

[PATCH] D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat.

This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rGff616f74c3b4: [clangd] Cache config files for 5 seconds, without revalidating with stat. (authored by sammccall). Changed prior to commit:

[PATCH] D83723: [OpenMP][NFC] Generalize CGOpenMPRuntimeNVPTX as CGOpenMPRuntimeGPU

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. I meant to remove just the new virtual function and its new implementation for AMDGCN, you could keep the new class for AMD GPUs. But I'm fine with this too. Repository: rG LLVM Github

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

daltenty added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:15 #include "clang/Tooling/ArgumentsAdjusters.h" +#include "llvm/Option/Option.h" +#include "llvm/Support/Allocator.h" This breaks the powerpc64le bots. Looks like we

[PATCH] D83702: [AIX]Generate debug info for static init related functions

Xiangling_L updated this revision to Diff 277831. Xiangling_L marked 6 inline comments as done. Xiangling_L added a comment. Simplified the testcase; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83702/new/ https://reviews.llvm.org/D83702 Files:

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff created this revision. sepavloff added reviewers: rnk, zturner. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Documentation on CreateProcessW states that maximal size of command line is 32767 characters including ternimation null character. In the

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

krisb accepted this revision. krisb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dang. Sorry for the delays in response, busy days. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

Szelethus added reviewers: Szelethus, martong, steakhal, dkrupp. Szelethus added a comment. @Eugene.Zelenko Thanks for cleaning up revisions -- same as D69560#1725399 , we are working in the same office and have worked on some forms of static analysis

[clang-tools-extra] 6c16fbd - [clangd] Config: CompileFlags.Remove

Author: Sam McCall Date: 2020-07-14T15:56:44+02:00 New Revision: 6c16fbd0ac7b18110891d0f180a2408d55fe47a8 URL: https://github.com/llvm/llvm-project/commit/6c16fbd0ac7b18110891d0f180a2408d55fe47a8 DIFF: https://github.com/llvm/llvm-project/commit/6c16fbd0ac7b18110891d0f180a2408d55fe47a8.diff

[PATCH] D83705: [clangd] Config: CompileFlags.Remove

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c16fbd0ac7b: [clangd] Config: CompileFlags.Remove (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D83705?vs=277510=277819#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277814. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb marked an inline comment as done. krisb added inline comments. Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87 + ` check. + Finds functions registered by ``atexit`` and ``at_quick_exit`` that are calling + exit functions ``_Exit``, ``exit``, ``quick_exit`` or ``longjmp``.

[PATCH] D83700: Fix test for the hasExternalFormalLinkage matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG8978032a17cd: Fix test for the hasExternalFormalLinkage matcher (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83700/new/

[clang] 8978032 - Fix test for the hasExternalFormalLinkage matcher

Author: Dmitri Gribenko Date: 2020-07-14T15:44:53+02:00 New Revision: 8978032a17cd0f1c3925ecb1752fdf59de7f7967 URL: https://github.com/llvm/llvm-project/commit/8978032a17cd0f1c3925ecb1752fdf59de7f7967 DIFF:

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG8eb8c92eb469: [clangd] Add library to semantically strip flags by name. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 8eb8c92 - [clangd] Add library to semantically strip flags by name.

Author: Sam McCall Date: 2020-07-14T15:41:46+02:00 New Revision: 8eb8c92eb46908ee9c64dfc4a2f49501b085f682 URL: https://github.com/llvm/llvm-project/commit/8eb8c92eb46908ee9c64dfc4a2f49501b085f682 DIFF: https://github.com/llvm/llvm-project/commit/8eb8c92eb46908ee9c64dfc4a2f49501b085f682.diff

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:328-329 struct Signature { -const ArgTypes ArgTys; -const QualType RetTy; +ArgTypes ArgTys; +QualType

[PATCH] D83768: [clangd] Config: Index.Background

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We only support Build/Skip for now, but with 'Load' or similar as an option for future (load existing

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. Herald added subscribers: ASDenysPetrov, martong. In D67422#1667079 , @NoQ wrote: > Casually rename > `ClangDiagPathDiagConsumer` to `TextDiagnostics` according to the

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

Szelethus added inline comments. Herald added subscribers: ASDenysPetrov, martong. Comment at: clang/include/clang/Analysis/IssueHash.h:35 +/// /// In case a new hash is introduced, the old one should still be maintained for /// a while. One should not introduce a new hash

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb updated this revision to Diff 277806. krisb edited the summary of this revision. krisb added a comment. Changed MSVC -> WIN32 check and simplified the warning fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/

[PATCH] D83340: Prohibit use of _ExtInt in atomic intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rGd083adb068e7: Prohibit use of _ExtInt in atomic intrinsic (authored by jtmott-intel, committed by erichkeane). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] d083adb - Prohibit use of _ExtInt in atomic intrinsic

Author: Mott, Jeffrey T Date: 2020-07-14T06:11:04-07:00 New Revision: d083adb068e781a2fc35aea8c6b7cccd566a735f URL: https://github.com/llvm/llvm-project/commit/d083adb068e781a2fc35aea8c6b7cccd566a735f DIFF:

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

hokein accepted this revision. hokein added a comment. still lg. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { sammccall wrote: > hokein wrote: > > sammccall wrote: > > > hokein wrote: > >

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

steakhal added a comment. Unfortunately, I'm not qualified enough to have much to say. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:1 +//===--- Env32CCheck.cpp - clang-tidy -===// +// Env32CCheck.cpp

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

rzurob accepted this revision. rzurob added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83497/new/ https://reviews.llvm.org/D83497

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 marked 10 inline comments as done. gamesh411 added a comment. Thanks @njames93 :) I have extended the check with notes, but I have to figure out how to appease file-check, so its still WIP until I do. Comment at:

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 277796. gamesh411 added a comment. extend with notes apply minor fixes tests are WIP until I figure out how to properly use file-check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus accepted this revision. Szelethus marked 2 inline comments as done. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Very well done! In D67420#2149461 , @vsavchenko wrote: > I strongly believe that decoupling

[PATCH] D83723: [OpenMP] Generalize CGOpenMPRuntimeNVPTX as CGOpenMPRuntimeGPU

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:39 + // return constant compile-time target-specific warp size + unsigned WarpSize = CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size); + return Bld.getInt32(WarpSize);

Re: [clang] dcd76c0 - [Lexer] Fix missing coverage line after #endif

Nice! On Fri, Jul 10, 2020 at 6:05 PM Zequan Wu via cfe-commits wrote: > > > Author: Zequan Wu > Date: 2020-07-10T09:05:20-07:00 > New Revision: dcd76c0c0716a4417110423718c7cae4b516b4d0 > > URL: > https://github.com/llvm/llvm-project/commit/dcd76c0c0716a4417110423718c7cae4b516b4d0 > DIFF: >

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

Szelethus added a comment. Herald added subscribers: ASDenysPetrov, martong. Aren't `StackHint`s basically ancient `NoteTag`s? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67381/new/ https://reviews.llvm.org/D67381

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Since clang will now add `+/-mma` to the TargetFeatures list, please add a test case that specifies `-mattr=+/-mma` to `llc` to show that `llc` accepts it. Other than that, LGTM.

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

xazax.hun added a comment. In D83286#2149912 , @vsavchenko wrote: > @xazax.hun You were interested in performance ⏫ > > These results here compare this patch together with D82445 > against **master**. This is really

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

nemanjai added a comment. Please re-upload this and provide the missing context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 ___ cfe-commits mailing list

[PATCH] D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:24 +// + looks like an unwated artifact Comment at:

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware added a comment. I am trying to measure the amount of extra false positive on real code (not artificial examples) of this option. The modeling of container size may reduce it, of course, but we have no other option to find this bug: even loop-unrolling or loop-widening is

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 277781. djtodoro added a comment. Herald added a subscriber: dang. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

njames93 updated this revision to Diff 28. njames93 added a comment. Removed no longer needed change to ProBoundsConstantArrayIndexCheck Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83053/new/ https://reviews.llvm.org/D83053 Files:

[PATCH] D83226: [analyzer] Add system header simulator a symmetric random access iterator operator+

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83226/new/ https://reviews.llvm.org/D83226

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. @xazax.hun You were interested in performance ⏫ These results here compare this patch together with D82445 against **master**. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

steakhal added a comment. Could you add some tests demonstrating the refined diagnostics of the checker? It would help to validate the quality of the emitted diagnostics. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:88 /// obviously uint32_t

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

nemanjai added a comment. @rzurob This cannot proceed without your approval since you requested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83497/new/ https://reviews.llvm.org/D83497 ___

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

nemanjai accepted this revision. nemanjai added a comment. LGTM aside from a minor nit regarding the description. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:324 // P10 Vector Insert built-ins. -BUILTIN(__builtin_altivec_vinsblx, "V16UcV16UcULLiULLi", "")

[PATCH] D83759: [clangd] Port lit tests to Windows

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Changes: - `background-index.test` Add Windows support. - `dependency-output.test` Split into two tests (Windows and Posix). -

[PATCH] D83723: [OpenMP] Generalize CGOpenMPRuntimeNVPTX as CGOpenMPRuntimeGPU

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:39 + // return constant compile-time target-specific warp size + unsigned WarpSize = CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size); + return Bld.getInt32(WarpSize);

[PATCH] D78189: [analyzer] StdLibraryFunctionsChecker: Add statistics

steakhal marked an inline comment as done. steakhal added a comment. Besides @balazske's comments, looks good to me. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:504-505 -if (NewState && NewState != State) +if (NewState && NewState !=

[PATCH] D83592: [Parser] Add comment to skipped regions

hans added a comment. > The comments in those coverage tests are used for FileCheck, like `//CHECK:`. > So, we can't remove those ones. Oh, I didn't think about that :-) It's a bit unusual and annoying that the test expectations end up affecting the test output. For the comments that are not

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus added a comment. I've seen you resurrecting the thread, I'll just take a bit of time to remember what happened in the previous episodes! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/ https://reviews.llvm.org/D67420

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

dkrupp requested changes to this revision. dkrupp added a comment. This revision now requires changes to proceed. Since the analyzer cannot cannot model the size of the containers just yet (as I believe this is the case now), what we are saying with this checker is to "always check the return

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. >> Maybe spend a few minutes remeasuring `libsoundio` more carefully, just in >> case? > > Sure, will do! It turns out that **libsoundio** has a problem similar to **re2** and varies a lot in terms of the analysis time (probably we can even try to figure out some

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall updated this revision to Diff 277728. sammccall added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81958/new/ https://reviews.llvm.org/D81958 Files: clang-tools-extra/clangd/CompileCommands.cpp

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:197 +} + +TEST(ArgStripperTest, Spellings) { hokein wrote: > sammccall wrote: > > hokein wrote: > > > add tests

[PATCH] D83539: [analyzer][tests] Introduce analyzer benchmarking framework

vsavchenko added inline comments. Comment at: clang/utils/analyzer/SATestBenchmark.py:139-140 +import matplotlib +import seaborn as sns +from matplotlib import pyplot as plt + NoQ wrote: > Why shorten? It's not that we're saving a lot of typing, and

<    1   2   3   >