[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 279032. yaxunl marked 2 inline comments as done. yaxunl added a comment. use llvm::fltSemantics for checking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files:

[clang] 3452a0d - [Driver] -B: don't search for target triple prefixes

Author: Fangrui Song Date: 2020-07-18T20:26:01-07:00 New Revision: 3452a0d8c17f7166f479706b293caf6ac76ffd90 URL: https://github.com/llvm/llvm-project/commit/3452a0d8c17f7166f479706b293caf6ac76ffd90 DIFF: https://github.com/llvm/llvm-project/commit/3452a0d8c17f7166f479706b293caf6ac76ffd90.diff

[clang] b2b39c5 - [Driver] --print-search-dirs: print -B options and COMPILER_PATH

Author: Fangrui Song Date: 2020-07-18T21:01:41-07:00 New Revision: b2b39c5d455b950c6fffcc902924516fe7f8ec9f URL: https://github.com/llvm/llvm-project/commit/b2b39c5d455b950c6fffcc902924516fe7f8ec9f DIFF: https://github.com/llvm/llvm-project/commit/b2b39c5d455b950c6fffcc902924516fe7f8ec9f.diff

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 279051. nridge marked 9 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files:

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:214 } + if (const auto *CE = dyn_cast(E)) { +const auto *CalleeType = resolveDependentExprToType(CE->getCallee()); hokein wrote: > btw, could you try the case below? it

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1418 + /// Whether floating point atomic fetch add/sub is supported. + virtual bool isFPAtomicFetchAddSubSupported() const { return false; } +

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

wanders marked an inline comment as done. wanders added a comment. In D84090#2160411 , @curdeius wrote: > The changes look good to me in general. I share your doubt though about > whether a bool flag is sufficient here. We've seen in the past a few times

[clang] acf3bdc - [clang][NFC] Tests showing the problems with some uses of NamedDecl::getDeclName in diagnostics, SemaOverload.cpp+SemaStmt.cpp part

Author: Bruno Ricci Date: 2020-07-18T20:44:06+01:00 New Revision: acf3bdc283ecf6e2c3a85a391a24becc4814b8b8 URL: https://github.com/llvm/llvm-project/commit/acf3bdc283ecf6e2c3a85a391a24becc4814b8b8 DIFF: https://github.com/llvm/llvm-project/commit/acf3bdc283ecf6e2c3a85a391a24becc4814b8b8.diff

[PATCH] D83681: [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG32db24a7f242: [clang] Provide a more specific diagnostic for a misplaced lambda capture… (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] be8e5fe - [clang][NFC] Tests showing the problems with some uses of NamedDecl::getDeclName in diagnostics, SemaExpr.cpp part

Author: Bruno Ricci Date: 2020-07-18T20:39:16+01:00 New Revision: be8e5fee91b44522056f1e780cdc861427f8738f URL: https://github.com/llvm/llvm-project/commit/be8e5fee91b44522056f1e780cdc861427f8738f DIFF: https://github.com/llvm/llvm-project/commit/be8e5fee91b44522056f1e780cdc861427f8738f.diff

[clang] 32db24a - [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

Author: Bruno Ricci Date: 2020-07-18T20:35:16+01:00 New Revision: 32db24a7f24236d78beaeb5cfd96b115d67a5c21 URL: https://github.com/llvm/llvm-project/commit/32db24a7f24236d78beaeb5cfd96b115d67a5c21 DIFF: https://github.com/llvm/llvm-project/commit/32db24a7f24236d78beaeb5cfd96b115d67a5c21.diff

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

MaskRay added a comment. @dim Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[clang] 5809a32 - [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

Author: Fangrui Song Date: 2020-07-18T15:07:46-07:00 New Revision: 5809a32e7c2d79a9a463eb9c15cde994b42e3002 URL: https://github.com/llvm/llvm-project/commit/5809a32e7c2d79a9a463eb9c15cde994b42e3002 DIFF: https://github.com/llvm/llvm-project/commit/5809a32e7c2d79a9a463eb9c15cde994b42e3002.diff

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

This revision was automatically updated to reflect the committed changes. Closed by commit rG5809a32e7c2d: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jdoerfert added a comment. In D81031#2160281 , @jhuber6 wrote: > In D81031#2159943 , @jdoerfert wrote: > > > In D81031#2159895 , @jhuber6 wrote: > > > > > Fixing errors

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

riccibruno added a comment. In addition to Aaron's suggestion, can you also change the diff's title to something a little bit more informative. Suggestion: "[clang] Handle 128-bits IntegerLiterals in StmtPrinter", and say in the description that this addresses PR35677. Repository: rG LLVM

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

wanders created this revision. wanders added reviewers: MyDeveloperDay, klimek. wanders added a project: clang-format. Herald added a project: clang. This new option allows controlling if there should be spaces around the ':' in a bitfield declaration. Decides if it should be the

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

MyDeveloperDay added a comment. In principle, this looks ok. Comment at: clang/unittests/Format/FormatTest.cpp:12163 "int oneTwoThree : 23 = 0;", Alignment); you are missing a CHECK_PARSE_BOOL test Repository: rG LLVM

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

MyDeveloperDay added a comment. please clang-format Comment at: clang/include/clang/Format/Format.h:2236 + /// \endcode + bool SpaceAroundBitFieldColon; + We need to regenerate the ClangFormatStyleOptions.rst from this change run

[clang] 0b2a922 - [analyzer] scan-build: Fix silencing multiple core checkers.

Author: Artem Dergachev Date: 2020-07-18T10:37:00-07:00 New Revision: 0b2a92224630f6e177d091b8391cfa943764aba5 URL: https://github.com/llvm/llvm-project/commit/0b2a92224630f6e177d091b8391cfa943764aba5 DIFF:

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > c-rhodes wrote: > > aaron.ballman wrote: > > > c-rhodes wrote: > > > > c-rhodes wrote: > > >

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

MyDeveloperDay added a comment. you need to make a full contextdiff git diff -U Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/ https://reviews.llvm.org/D84090 ___ cfe-commits

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand closed this revision. guiand added a comment. Merged in https://reviews.llvm.org/rG780528d9da707b15849d6c9711cc3ab19f6c7f00 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

jdoerfert resigned from this revision. jdoerfert added a comment. This revision is now accepted and ready to land. My concerns have been addressed. I am not the right one to look at the clang changes but what we merged into LLVM was really useful, thanks again for working on this! Repository:

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand reopened this revision. guiand added a comment. This revision is now accepted and ready to land. Sorry, closed this mistakenly! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. I hope you don't mind if I bring up a point you mentioned during a daily meeting. > The error checking shouldn't be present on one of execution, but rather on > all of them. I think your recent comment highlights why that wouldn't be sufficient, unfortunately.

[PATCH] D84103: [clang-format] Make sure rst documentation matches comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d7ec54170f9: [clang-format] Make sure rst documentation matches comments (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84103/new/

[clang] 6d7ec54 - [clang-format] Make sure rst documentation matches comments

Author: Anders Waldenborg Date: 2020-07-18T18:02:14+02:00 New Revision: 6d7ec54170f9ef68710f484299caa1a6dd42ff48 URL: https://github.com/llvm/llvm-project/commit/6d7ec54170f9ef68710f484299caa1a6dd42ff48 DIFF:

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

curdeius added a comment. The changes look good to me in general. I share your doubt though about whether a book flag is sufficient here. We've seen in the past a few times that at some time a false/true flag is not enough. I'd rather go for a Before/After/Both/None flag (or similar, naming

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jhuber6 added a comment. In D81031#2159943 , @jdoerfert wrote: > In D81031#2159895 , @jhuber6 wrote: > > > Fixing errors caused by unused attribute sets. Adding missing attributes to > > barrier_codegen.cpp. > > >

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 279000. yaxunl added a comment. Herald added subscribers: llvm-commits, dang, hiraditya. Herald added a project: LLVM. rebase and added more checks. The documentation work is still under development. CHANGES SINCE LAST ACTION

[PATCH] D84103: [clang-format] Make sure rst documentation matches comments

wanders created this revision. wanders added reviewers: MyDeveloperDay, JakeMerdichAMD. wanders added a project: clang-format. Herald added a project: clang. clang/docs/tools/dump_format_style.py is used to read the comments from clang/include/clang/Format/Format.h and update the contents of

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

wanders updated this revision to Diff 279010. wanders added a comment. - Regenerated rst - Fixed clang format errors - Added release note - Added bool parsing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/

[clang] 3bbbe4c - [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

Author: Joseph Huber Date: 2020-07-18T12:55:50-04:00 New Revision: 3bbbe4c4b6c8e20538a388df164da6f8d935e0cc URL: https://github.com/llvm/llvm-project/commit/3bbbe4c4b6c8e20538a388df164da6f8d935e0cc DIFF: https://github.com/llvm/llvm-project/commit/3bbbe4c4b6c8e20538a388df164da6f8d935e0cc.diff