[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. In D79279#2168533 , @jfb wrote: > In D79279#2168479 , @rjmccall wrote: > > > Is there a need for an atomic memcpy at all? Why is it useful to allow > > this operation to take on "atomic"

[clang] 65fd651 - [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

Author: Balázs Kéri Date: 2020-07-23T11:53:25+02:00 New Revision: 65fd651980a8ad965363807cc334c513e4c8ffe4 URL: https://github.com/llvm/llvm-project/commit/65fd651980a8ad965363807cc334c513e4c8ffe4 DIFF: https://github.com/llvm/llvm-project/commit/65fd651980a8ad965363807cc334c513e4c8ffe4.diff

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

This revision was automatically updated to reflect the committed changes. Closed by commit rG65fd651980a8: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5612-5613 llvm::VectorType *VTy = GetNeonType(this, Type, HasLegalHalfType, false, AllowBFloatArgsAndRet); llvm::Type *Ty = VTy; Is there a

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatToken.h:177 /// Indicates that this is the first token of the file. - bool IsFirst = false; + unsigned IsFirst : 1; educate me, why ``` unsigned IsFirst : 1; ``` here and not ```

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. I'm generally in agreement but I think we should let some others comment Comment at: clang/lib/Format/ContinuationIndenter.cpp:652 + (Current.isNot(TT_LineComment) || +

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL +

[PATCH] D84387: [AST][RecoveryExpr] Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2695 + (DestType->isDependentType() || SrcExpr.get()->isTypeDependent() || + SrcExpr.get()->isValueDependent())) { +assert((DestType->containsErrors() ||

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 279949. guiand added a comment. Adds additional constraints on `noundef`: Not a `nullptr_t`, not a member pointer, and not coerced to a type of larger size. Disabled emitting in return position for non-C++ languages (or inside extern "C"). @rsmith, I just

[PATCH] D83912: [llvm-readobj] Update tests because of changes at llvm-readobj behavior

Elvina added a comment. In D83912#2161524 , @jhenderson wrote: > Hi @Elvina, > > Just to let you know that I had to fix up three clang tests that were using > the old behaviour too, prior to committing. I also noticed that you've got > the stack the

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand added a comment. Just saw your comment about tests as well. The idea was to have all tests ported over as part of a separate commit (I linked it in the main patch description) and then only to push either commit once both are ready to land. To make it easier to be sure this specific

[PATCH] D81728: [InstCombine] Add target-specific inst combining

davezarzycki added a comment. I have a multi-stage, auto-git-bisecting bot that has identifying this commit as the source of a regression on Fedora 32 (x86-64). This commit broke my first stage test (release, no asserts). Might a quick fix happen or do we need to revert this? FAIL: Clang ::

[PATCH] D81728: [InstCombine] Add target-specific inst combining

Flakebi added a comment. Thanks for the notification @davezarzycki, an auto-bisecting bot is cool! This failure should be fixed in b99898c1e9c5d8bade1d898e84604d3241b0087c . Repository: rG LLVM Github

[PATCH] D84387: [AST][RecoveryExpr] Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84387 Files: clang/lib/Sema/SemaCast.cpp clang/test/Sema/error-dependence.c Index: clang/test/Sema/error-dependence.c

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

sepavloff updated this revision to Diff 280040. sepavloff added a comment. Extended test with PCH read Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84343/new/ https://reviews.llvm.org/D84343 Files: clang/include/clang/AST/Expr.h

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos updated this revision to Diff 280072. vhscampos added a comment. 1. Add comment explaining the MVE-Integer detail. 2. Add another test to check the disabled features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82948/new/

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp marked an inline comment as done. tetsuo-cpp added a comment. @aaron.ballman Thanks! I took your suggestion and I think this looks cleaner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 280086. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane updated this revision to Diff 280101. erichkeane marked 9 inline comments as done. erichkeane added a comment. Fix all the things that @rsmith suggested. Thanks for the feedback, it is looking much better! I ended up using a MapVector instead of std::map for the

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal added a comment. In D84316#2168462 , @NoQ wrote: > Shared accessors look amazing. > > [...] you're splitting up the part which performs boring bookkeeping for the > state trait from the part which models `strlen()` and other various functions.

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss updated this revision to Diff 280048. danielkiss added a comment. fix review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 Files: llvm/include/llvm/CodeGen/ISDOpcodes.h llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar updated this revision to Diff 280104. tstellar added a comment. Remove stray comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM, Please add tests for BE in llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll prior to committing. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2 +; NOTE:

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14166 + + SDValue LoadOps[] = {LD->getChain(), LD->getBasePtr(), DAG.getIntPtrConstant(MemoryType.getScalarSizeInBits(), dl)}; + nit: indentation. Comment at:

[clang] 7bf9e22 - Update make_cxx_dr_status and cxx_dr_status.html for the new release.

Author: Erich Keane Date: 2020-07-23T05:50:10-07:00 New Revision: 7bf9e2204960f70e89df3dd0dc768457ddc40498 URL: https://github.com/llvm/llvm-project/commit/7bf9e2204960f70e89df3dd0dc768457ddc40498 DIFF: https://github.com/llvm/llvm-project/commit/7bf9e2204960f70e89df3dd0dc768457ddc40498.diff

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

hans added a comment. > In that case, I've enabled it again using `add_compile_options` instead of > `add_definitions`. I've got my finger hovering over the button to revert. (For reference, the re-commit is 77e0e9e .) Looks

[PATCH] D84197: [PowerPC][Power10] 128-bit Vector String Isolate instruction definitions and MC Tests

lei added a comment. Why are you removing MC tests for here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84197/new/ https://reviews.llvm.org/D84197 ___ cfe-commits mailing list

[PATCH] D84382: [PowerPC][Power10] Cleanup p10vector clang test

amyk accepted this revision. amyk added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84382/new/ https://reviews.llvm.org/D84382 ___ cfe-commits mailing list

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao requested changes to this revision. hliao added a comment. This revision now requires changes to proceed. I don't that's proper way to support file-scope static device variables. As we discuss APIs like cudaMemcpyToSymol, that's a runtime API instead of driver API. The later needs to

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

aaron.ballman added a comment. I reviewed the changes in the patch and they seem reasonable, but this patch is hard to have high confidence in because you need to audit all the places where the default behavior silently changed and no changes were made in the patch. I'm assuming that the code

[PATCH] D84382: [PowerPC][Power10] Cleanup p10vector clang test

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84382/new/ https://reviews.llvm.org/D84382 ___

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp updated this revision to Diff 280082. tetsuo-cpp added a comment. Cleanup check conditional. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

Szelethus marked an inline comment as done. Szelethus added a comment. Yay! This checker has become a major headache as the analyzer grew. Not on a RetainCount scale, but on a MallocChecker one. Cheap shots, I know :) The patch looks great! I have some miscellaneous comments, but nothing

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar created this revision. tstellar added reviewers: vsk, efriedma. Herald added a project: clang. Add a special case for handling __builtin_mul_overflow with unsigned inputs and a signed output to avoid emitting the __muloti4 library call on x86_64. __muloti4 is not implemented in libgcc,

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

kcc added a comment. Yep, cool. LGTM from me, but please get another pair if eyes (Vitaly?) Comment at: clang/docs/DataFlowSanitizer.rst:182 +less CPU and code size overhead. To use fast16labels instrumentation, you'll +need to specify `-fsanitize=dataflow -mllvm

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

morehouse updated this revision to Diff 280304. morehouse added a comment. - Fix libfuzzer dataflow tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84371/new/ https://reviews.llvm.org/D84371 Files: clang/docs/DataFlowSanitizer.rst

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 280305. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[PATCH] D84482: [Fuchsia] Use -z dead-reloc-in-nonalloc=*=0 for Fuchsia targets

mcgrathr created this revision. mcgrathr added reviewers: phosek, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84482 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp Index:

[PATCH] D84409: [libTooling] Add an `EditGenerator` that applies a rule throughout a bound node.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. The new combinator, `rewriteDescendants`, applies a rewrite rule to all descendants of a specified bound node. That rewrite rule can refer to nodes bound by the parent, both in the matcher and in

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl added a comment. In D80858#2169295 , @hliao wrote: > I don't that's proper way to support file-scope static device variables. As > we discuss APIs like cudaMemcpyToSymol, that's a runtime API instead of > driver API. The later needs to specify

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny created this revision. jdenny added reviewers: grokos, ABataev, jdoerfert. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1, guansong, yaxunl. Herald added projects: clang, OpenMP, LLVM. Without this patch, the following example fails but shouldn't according

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro updated this revision to Diff 280108. ro added a reviewer: MaskRay. ro added a comment. Rebased after D83015 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84029/new/ https://reviews.llvm.org/D84029 Files:

[PATCH] D84414: [RISCV] Support Shadow Call Stack

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/shadowcallstack-attr.c:8 +// RUN: %clang_cc1 -triple riscv32-linux-gnu -emit-llvm -o - %s -fsanitize=shadow-call-stack | FileCheck -check-prefix=UNBLACKLISTED %s + Now might be a good

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert updated this revision to Diff 280148. jdoerfert marked 6 inline comments as done. jdoerfert added a comment. Addressed @ABataev comments, thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281

[clang] 831ae45 - Recommit "[libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked."

Author: Dokyung Song Date: 2020-07-23T15:59:07Z New Revision: 831ae45e3dc609e43ba561af07670a8fe47461ef URL: https://github.com/llvm/llvm-project/commit/831ae45e3dc609e43ba561af07670a8fe47461ef DIFF: https://github.com/llvm/llvm-project/commit/831ae45e3dc609e43ba561af07670a8fe47461ef.diff LOG:

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

This revision was automatically updated to reflect the committed changes. dokyungs marked an inline comment as done. Closed by commit rG831ae45e3dc6: Recommit [libFuzzer] Link libFuzzers own interceptors when other compiler… (authored by dokyungs). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83997: [os_log] Improve the way we extend the lifetime of objects passed to __builtin_os_log_format

ahatanak added a comment. The use case for this is a macro in which the call to `__builtin_os_log_format` that writes to the buffer and the call that uses the buffer appear in two different statements. For example: __builtin_os_log_format(buf, "%@", getObj()); ... use_buffer(buf); The

[PATCH] D83325: [Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion.

svenvh added a comment. Wondering if stripping the sugar is the right thing to do here, because it means we don't have any sugar on the resulting type if it has gone through the SCS and pointer type reconstruction? > I'm unsure if this is currently broken upstream without other patches to >

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong created this revision. martong added reviewers: Szelethus, gamesh411, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project:

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7599 + /// (which accept anything) and (later) extensions. + StringRef RawString{}; }; No need for the default initializer here Comment at:

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske updated this revision to Diff 280149. balazske added a comment. Change column in malloc-plist test because code was reformatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83961/new/ https://reviews.llvm.org/D83961 Files:

[PATCH] D84414: [RISCV] Support Shadow Call Stack

apazos added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:95 + .addReg(RISCV::X18) + .addImm(0); +} There are thee things to observe here and other reviewers might have some additional comments: - RISC-V does not have a

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng created this revision. zzheng added reviewers: apazos, lenary, asb. Herald added subscribers: cfe-commits, aaron.ballman, evandro, luismarques, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, MaskRay,

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

riccibruno marked 3 inline comments as done. riccibruno added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:652 + (Current.isNot(TT_LineComment) || + Previous.getBlockKind() == BK_BracedInit)) { State.Stack.back().Indent = State.Column +

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 280136. jfb added a comment. Re-update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Builtins.def

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 280135. jfb added a comment. Improve documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/docs/LanguageExtensions.rst Index:

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

yaxunl updated this revision to Diff 280144. yaxunl added a comment. update the lit test for SFINAE. make sure substitution failure does not incur error msg if there is valid substitution. Since template is not allowed in local class, there is no need for test SFINAE inside host device

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7663 + const FunctionDecl *CurrentFunctionDecl); + ~TargetOMPContext() = default; + `virtual` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

logan-5 added a comment. In D84244#2169142 , @hans wrote: > Looks good to me so far. We haven't tried doing any full builds yet, but I > checked for the specific problem I hit yesterday (building > ClangApplyReplacementsTests) and that's working fine

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

ro created this revision. ro added a reviewer: clang. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. `ninja check-all` currently fails on Illumos: [84/716] Generating default/Asan-i386-inline-Test FAILED:

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:1-3 +; RUN: llc -verify-machineinstrs -o - %s -mtriple=riscv32-linux-gnu -mattr=+reserve-x18 |

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2168649 , @rjmccall wrote: > In D79279#2168533 , @jfb wrote: > > > In D79279#2168479 , @rjmccall > > wrote: > > > > > Is there a need for an

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 added a comment. Is there a reason for choosing X18? On AArch64 that's either a temporary or saved register depending on ABI, but determined to be the "platform register". Picking X18 on RISC-V because that's the same index as AArch64 seems a little arbitrary, but maybe it happens to

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl added a comment. Another reason is that we need to support it in rdc mode, where different TU can have static var with the same name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80858/new/ https://reviews.llvm.org/D80858 ___

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau marked an inline comment as done. ctetreau added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5612-5613 llvm::VectorType *VTy = GetNeonType(this, Type, HasLegalHalfType, false, AllowBFloatArgsAndRet);

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert updated this revision to Diff 280151. jdoerfert marked an inline comment as done. jdoerfert added a comment. Add virtual Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 Files:

[PATCH] D84310: [libTooling] Add assorted `EditGenerator` combinators.

asoffer accepted this revision. asoffer added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:125 +/// not bound, then no edits are produced. +inline EditGenerator ifBound(std::string ID, ASTEdit

[PATCH] D84310: [libTooling] Add assorted `EditGenerator` combinators.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:125 +/// not bound, then no edits are produced. +inline EditGenerator ifBound(std::string ID, ASTEdit TrueEdit) { + return

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. In D79279#2170187 , @jfb wrote: > In D79279#2170157 , @rjmccall wrote: > > > I think the argument is treated as if it were 1 if not given. That's all > > that ordinary memcpy formally

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

grokos added a comment. What confuses me about this interpretation of the standard is the inconsistency at `data exit`. So if we have an explicit `omp target exit data map(present...)` then we should respect the "present" semantics, whereas when we have a scoped data exit: #pragma omp

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2169399 , @yaxunl wrote: > In D80858#2169295 , @hliao wrote: > > > I don't that's proper way to support file-scope static device variables. As > > we discuss APIs like

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr, dcoughlin, delcypher, yln, kubamracek, vsavchenko. Herald added subscribers: martong, mgehre, Charusso, xazax.hun. It's failing on macOS under AddressSanitizer for no obvious reason - i.e., no report is produced, just the code

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 280210. zzheng marked 3 inline comments as done. zzheng edited the summary of this revision. zzheng added a comment. Using 'BLOCKED' now. clang-formated RISCVFrameLowering.cpp updated style of test/CodeGen/RISCV/shadowcallstack.ll Repository: rG LLVM

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. > My point is that this has nothing to do with the ordinary semantics of > `_Atomic`. You're basically just looking at the word "atomic" and saying > that, hey, a minimum access size is sortof related to atomicity. > > If you want this to be able to control the minimum

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

vsk added a comment. How were you able to show that the specialized IRGen is equivalent to the generic kind? I tried doing this with direct inspection (https://godbolt.org/z/o5WEn3), but wasn't able to convince myself. In the past I used a test driver to compare the before/after compiler

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar added a comment. In D84405#2170110 , @vsk wrote: > How were you able to show that the specialized IRGen is equivalent to the > generic kind? I tried doing this with direct inspection > (https://godbolt.org/z/o5WEn3), but wasn't able to convince

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2170157 , @rjmccall wrote: > I think the argument is treated as if it were 1 if not given. That's all > that ordinary memcpy formally guarantees, which seems to work fine > (semantically, if not performance-wise) for

[PATCH] D84356: [AIX] remove -u from the clang when invoke aix as assembler

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84356/new/ https://reviews.llvm.org/D84356

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2169534 , @yaxunl wrote: > Another reason is that we need to support it in rdc mode, where different TU > can have static var with the same name. That's an issue of our current RDC support through LLVM IR instead of

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM, thanks for taking care of this! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84453/new/ https://reviews.llvm.org/D84453

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. In D79279#2169522 , @jfb wrote: > In D79279#2168649 , @rjmccall wrote: > > > In D79279#2168533 , @jfb wrote: > > > > > In D79279#2168479

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 ___ cfe-commits mailing list

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. I don't think any of these should allow _Atomic unless we're going to give it some sort of consistent atomic semantics (which is hard to imagine being useful), and I think you should just take an extra argument of the minimum access width on all of them uniformly if

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2170095 , @rjmccall wrote: > I don't think any of these should allow _Atomic unless we're going to give it > some sort of consistent atomic semantics (which is hard to imagine being > useful), and I think you should just

LLVM buildmaster is back to normal work

Hello everyone, LLVM buildmaster is back to normal work, sorry for inconvenience. Last night updates caused some distortions unfortunately. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

tra added a comment. I'm going to try the patch on our CUDA code and see how it fares. Stay tuned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84364/new/ https://reviews.llvm.org/D84364 ___ cfe-commits mailing list

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. >>> Do you think it'd be useful to have different guarantees for different >>> operands? I guess it could come up, but it'd be a whole lot of extra >>> complexity that I can't imagine we'd ever support. >> >> You mean, if `element_size` is passed then you get different

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:95 + .addReg(RISCV::X18) + .addImm(0); +} apazos wrote: > There are thee things to observe here and other reviewers might have some > additional comments: > > -

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280216. eduucaldas added a comment. Update API to new nested-name-specifier grammar rule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files:

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm added a comment. In D79744#2165929 , @rjmccall wrote: > Arguably we should add this attribute to all indirect arguments. I can > understand not wanting to update all the test cases, but you could probably > avoid adding a new IndirectByRef kind

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes marked an inline comment as done. c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:152 + Align, Name, + /*ArraySize=*/nullptr, Alloca); efriedma wrote: > Do we need to bitcast the result of CreateTempAlloca to a

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

MaskRay added a comment. Can you add a test to `test/Driver/solaris-ld.c`? > However, if someone forgets this, it depends on the user's PATH whether or > not clang finds the correct linker, which doesn't make for a good user > experience. Not very sure about this. The last resort of

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. I think the argument is treated as if it were 1 if not given. That's all that ordinary memcpy formally guarantees, which seems to work fine (semantically, if not performance-wise) for pretty much everything today. I don't think you need any restrictions on element

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal marked 4 inline comments as done. steakhal added a comment. In D84316#2169195 , @Szelethus wrote: > [...] you really cant make CStringChecker work without CStringModeling How should I fuse the `CStringModeling` and the `CStringChecker` together

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

Szelethus added a comment. You could do it in the code, but if the modeling wouldn't be present from CStringModeling, CStringChecker wouldn't work properly. So you should make it a strong dependency, just as you did in this patch. My comment was mainly a response to @NoQ :)

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84343/new/ https://reviews.llvm.org/D84343

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

rjmccall added a comment. I agree, that can be done separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82999/new/ https://reviews.llvm.org/D82999 ___ cfe-commits mailing list

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

tra added a comment. In D80858#2170781 , @hliao wrote: > The problem is not whether we have solution to tell them but when we need to > add that. Not all `static` device variables need to be visible to the host > side. `Externalizing` them adds the

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:152 + Align, Name, + /*ArraySize=*/nullptr, Alloca); c-rhodes wrote: > efriedma wrote: > > Do we need to bitcast the result of CreateTempAlloca to a pointer to the > > array

  1   2   >