hans added a comment.

> In that case, I've enabled it again using `add_compile_options` instead of 
> `add_definitions`. I've got my finger hovering over the button to revert.

(For reference, the re-commit is 77e0e9e 
<https://reviews.llvm.org/rG77e0e9e17daf0865620abcd41f692ab0642367c4>.)

Looks good to me so far. We haven't tried doing any full builds yet, but I 
checked for the specific problem I hit yesterday (building 
ClangApplyReplacementsTests) and that's working fine now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84244/new/

https://reviews.llvm.org/D84244



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to