[PATCH] D86591: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b75f65e6ba4: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp` (authored by eduucaldas). Repository: rG LLVM Github Monorepo

[clang] 3b75f65 - [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp`

Author: Eduardo Caldas Date: 2020-08-26T07:19:49Z New Revision: 3b75f65e6ba4862977fd193ddb4918c4fc380fa5 URL: https://github.com/llvm/llvm-project/commit/3b75f65e6ba4862977fd193ddb4918c4fc380fa5 DIFF: https://github.com/llvm/llvm-project/commit/3b75f65e6ba4862977fd193ddb4918c4fc380fa5.diff

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas updated this revision to Diff 287842. eduucaldas marked 8 inline comments as done. eduucaldas added a comment. Answer code review, squash commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86544/new/ https://reviews.llvm.org/D86544

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1070 +Builder.markChildToken( +std::next(Builder.findToken(S->getCallee()->getEndLoc())), +syntax::NodeRole::OpenParen); gribozavr2 wrote: > Could you add an

[PATCH] D86544: [SyntaxTree] Add support for call expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2de2ca348dfa: [SyntaxTree] Add support for `CallExpression` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2de2ca3 - [SyntaxTree] Add support for `CallExpression`

Author: Eduardo Caldas Date: 2020-08-26T07:03:49Z New Revision: 2de2ca348dfa09963eb33ddf71c9cbb59612c16a URL: https://github.com/llvm/llvm-project/commit/2de2ca348dfa09963eb33ddf71c9cbb59612c16a DIFF: https://github.com/llvm/llvm-project/commit/2de2ca348dfa09963eb33ddf71c9cbb59612c16a.diff

[PATCH] D86591: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86591 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index:

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov added a comment. @NoQ > That's completely different checker logic. I think, I got the message. The real recursive logic can be caught here: std::recursive_mutex rm; void recur1() { recur2(); } void recur2() { rm.lock(); recur1(); // here we can ignore the meet

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson updated this revision to Diff 287832. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85948/new/ https://reviews.llvm.org/D85948 Files:

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson marked 18 inline comments as done. tejohnson added a comment. I think I've addressed all the comments. Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:48 +// Size of memory mapped to a single shadow location. +static const uint64_t

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 287835. zequanwu added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files: clang/include/clang/Basic/DiagnosticGroups.td

[clang] 20676ca - [analyzer] Add modeling of assignment operator in smart ptr

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-08-26T11:22:55+02:00 New Revision: 20676cab1168c2c60982af85f42725955cbcd7b5 URL: https://github.com/llvm/llvm-project/commit/20676cab1168c2c60982af85f42725955cbcd7b5 DIFF:

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

This revision was automatically updated to reflect the committed changes. Closed by commit rG20676cab1168: [analyzer] Add modeling of assignment operator in smart ptr (authored by vrnithinkumar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

steakhal added a comment. In D81254#2218196 , @ASDenysPetrov wrote: >> We know where it points to (aka. the pointer's value is conjured), but we >> don't know what the value if there. > > Absolutely right. I looked at this patch after a while and don't

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 287889. eduucaldas added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. One more ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:851 + } getPointerTy(ACtx); + class { + public: Why has this class different layout than `GetPointerTy` and `GetRestrictTy` (beneath that here is no

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. Here are some benchmarking results. In docker: F12777445: tiny.png F12777444: small.png Natively on my Mac (no memory measurements due to this issue

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:441 + const SymbolMetadata *getMetadataSymbol(const MemRegion *R, QualType T,

[PATCH] D86597: [Tooling][Format] Treat compound extensions (foo.bar.cc) as matching foo.h

sammccall created this revision. sammccall added reviewers: krasimir, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. Motivating use case is ".cu.cc" extensions used in some bazel projects. Alternative is to work

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:110 + iterator end() const { return Impl->end(); } + size_t size() const { return Impl->size(); } + steakhal wrote: > I think it

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0aaa2acc4ca0: [clangd] Compute the inactive code range for semantic highlighting. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[clang-tools-extra] 0aaa2ac - [clangd] Compute the inactive code range for semantic highlighting.

Author: Haojian Wu Date: 2020-08-26T10:50:31+02:00 New Revision: 0aaa2acc4ca0389a79a46bca3dc5b9365c641d77 URL: https://github.com/llvm/llvm-project/commit/0aaa2acc4ca0389a79a46bca3dc5b9365c641d77 DIFF: https://github.com/llvm/llvm-project/commit/0aaa2acc4ca0389a79a46bca3dc5b9365c641d77.diff

[clang] f22d276 - [NFC] Fix some spelling errors in clang Driver Options.td

Author: Yang Zhihui Date: 2020-08-26T04:58:38-04:00 New Revision: f22d27624b6532a5542b283de9ce586c72c6b846 URL: https://github.com/llvm/llvm-project/commit/f22d27624b6532a5542b283de9ce586c72c6b846 DIFF: https://github.com/llvm/llvm-project/commit/f22d27624b6532a5542b283de9ce586c72c6b846.diff

[PATCH] D86427: Fix some spelling errors

plotfi added a comment. @YangZhihui landed at https://github.com/llvm/llvm-project/commit/f22d27624b6532a5542b283de9ce586c72c6b846 Thanks! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86427/new/ https://reviews.llvm.org/D86427

[PATCH] D86602: [clangd] Enable recovery-ast-type by default.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D86427: Fix some spelling errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22d27624b65: [NFC] Fix some spelling errors in clang Driver Options.td (authored by YangZhihui, committed by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

vsavchenko added a comment. In D86533#2236009 , @Szelethus wrote: > @vsavchenko I just realized a significant portion of your work for this > release is the following list: > > git log llvmorg-11-init..llvmorg-11.0.0-rc2 --oneline -- >

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582

[PATCH] D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z

uabelho added a comment. We've run with changes like this for a long time to make the routines work for our out of tree target where int is also 16 bits so thumbs up from me even if I'm not sure I can formally LGTM it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86604: [clangd] Use string[] for allCommitCharacters

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. As per LSP

[PATCH] D86604: [clangd] Use string[] for allCommitCharacters

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oops, nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86604/new/ https://reviews.llvm.org/D86604

[libunwind] e524daa - [libunwind] Convert x86, x86_64, arm64 register restore functions to C calling convention and name mangling

Author: Martin Storsjö Date: 2020-08-26T14:32:32+03:00 New Revision: e524daa7e8719f4b43e6ebcf25fd4e7d74c5d1c4 URL: https://github.com/llvm/llvm-project/commit/e524daa7e8719f4b43e6ebcf25fd4e7d74c5d1c4 DIFF:

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

martong added a comment. In D86465#2238379 , @vsavchenko wrote: > Here are some benchmarking results. > In docker: > F12777445: tiny.png > F12777444: small.png > Natively on my Mac

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev updated this revision to Diff 287906. ABataev added a comment. Added default(firstprivate) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus requested changes to this revision. Szelethus added a subscriber: bruntib. Szelethus added a comment. This revision now requires changes to proceed. I debated this

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

gribozavr2 added a comment. Could you add some tests with variadic parameter lists & variadic function templates? If we don't handle them correctly, please leave a FIXME in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:851 + } getPointerTy(ACtx); + class { + public: balazske wrote: > Why has this class different layout than

[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

sdesmalen updated this revision to Diff 287911. sdesmalen added a comment. - Choose unsigned char element type for svbool_t bitpattern. - Added LLVM test to ensure debug info for the vector type is correctly codegenerated when DISubrange has upper bound instead of count. CHANGES SINCE LAST

[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:734 + if (Info.ElementType == CGM.getContext().BoolTy) +NumElemsPerVG /= 8; + efriedma wrote: > I guess NumElemsPerVG of a bool vector is always divisible by 8 because we

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

gribozavr2 added a comment. I think we also need to update `List::getTerminationKind()` and other similar List methods to handle this list kind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus updated this revision to Diff 287930. Szelethus marked 14 inline comments as done. Szelethus added a comment. Fixes according to reviewer comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86533/new/ https://reviews.llvm.org/D86533 Files: clang/docs/ReleaseNotes.rst

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:471 + +- Improve the pre- and post condition modeling of several hundred more standard + C functions. whisperity wrote: > martong wrote: > > Umm, this is still an alpha command line

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! (At least those changes that involved me, perhaps it is better to wait for more LGs.) Comment at: clang/docs/ReleaseNotes.rst:471 + +- Improve the pre- and post

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

steakhal added inline comments. Comment at: clang/docs/ReleaseNotes.rst:487 +- While still in alpha, ``alpha.unix.PthreadLock``, the iterator and container + modeling infrastructure, ``alpha.unix.Stream``, and taint analysis were + improved greatly. An ongoing, currently

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 287947. eduucaldas added a comment. answer code-review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG087047144210: Add clang-cl vctoolsdir option to specify the location of the msvc toolchain (authored by zahen, committed by hans). Changed prior to commit:

[clang] 0870471 - Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

Author: Zachary Henkel Date: 2020-08-26T15:09:18+02:00 New Revision: 08704714421086e775a297339fc60963cc07eec9 URL: https://github.com/llvm/llvm-project/commit/08704714421086e775a297339fc60963cc07eec9 DIFF:

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:537 + // When running in integrated-cc1 mode, the CrashRecoveryContext returns + // the same code as if the program crashed. On Unix, that is codes >128. + IsCrash |= CommandRes > 128;

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

whisperity added inline comments. Comment at: clang/docs/ReleaseNotes.rst:509 + The currently beta-version tool is found in + (llvm-project repository)/clang/utils/analyzer/SATest.py. Let's put this into monospace font too. Otherwise LGTM from a readability

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:118-123 +/// Create a new set with all ranges from both LHS and RHS. +/// Possible intersections are not checked here. +/// +///

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. In D81083#2237284 , @rsmith wrote: > Thanks for dropping by! > Have you considered using the `ext_vector_type` attribute instead of > `vector_size` for this? That would have a couple of advantages: > > - It's not a GCC

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

aganea updated this revision to Diff 287952. aganea marked 2 inline comments as done. aganea added a comment. Address comments. Added a CrashRecoveryTest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70378/new/ https://reviews.llvm.org/D70378

[PATCH] D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328

dylanmckay created this revision. dylanmckay added a reviewer: aykevl. Herald added a subscriber: Jim. Herald added a project: clang. dylanmckay requested review of this revision. This patch modifies the Clang AVR toolchain so that it always passes the '-Tdata=0x800100' to the linker for

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov updated this revision to Diff 287997. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Added support of: - std::timed_mutex - std::recursive_timed_mutex - std::shared_mutex - std::shared_timed_mutex CHANGES SINCE LAST ACTION

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 288010. eduucaldas added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov abandoned this revision. ASDenysPetrov added a comment. Guys! I've moved my work to PthreadLockChecker https://reviews.llvm.org/D85984. You are welcome to look at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85431/new/ https://reviews.llvm.org/D85431

[PATCH] D83472: [SystemZ/ZOS] Add header file to encapsulate use of

This revision was automatically updated to reflect the committed changes. Closed by commit rGed07e1fe0ffd: [SystemZ/ZOS] Add header file to encapsulate use of sysexits.h (authored by Kai). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] ed07e1f - [SystemZ/ZOS] Add header file to encapsulate use of

Author: Kai Nacke Date: 2020-08-26T12:44:30-04:00 New Revision: ed07e1fe0ffdb2c1dbff26ff4cf7558e0c419737 URL: https://github.com/llvm/llvm-project/commit/ed07e1fe0ffdb2c1dbff26ff4cf7558e0c419737 DIFF: https://github.com/llvm/llvm-project/commit/ed07e1fe0ffdb2c1dbff26ff4cf7558e0c419737.diff

[PATCH] D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

craig.topper added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:395 CHECK_TARGET_OPT(CPU, "target CPU"); +CHECK_TARGET_OPT(TuneCPU, "tune CPU"); + } erichkeane wrote: > What does this string do? Does there have to be a test for

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:267 -... +- Added `cl_khr_extended_subgroup` to clang and the internal header. + cl_khr_extended_subgroups (ends with -s)? But isn't it supposed to be `cl_khr_subgroup_extensions`? I am

[PATCH] D86622: Fix failing tests after VCTOOLSDIR change

aganea added a comment. I've pushed one more fix: rG33ce275fc156c8b015acfad918937028b2cc235c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86622/new/

[PATCH] D86376: [HIP] Improve kernel launching latency

yaxunl added a comment. In D86376#2236704 , @tra wrote: > > It's still suspiciously high. AFAICT, config/push/pull is just an std::vector > push/pop. It should not take *that* long. Few function calls should not lead > to microseconds of overhead,

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher updated this revision to Diff 288013. Saldivarcher added a comment. Added some more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

andwar updated this revision to Diff 288018. andwar added a comment. - Canonicalised FLANG_BUILD_NEW_DRIVER in flang/test/CMakeLists.txt and updated the LIT config scripts accordingly - Implemented proper handling of `-emit-obj` (via diagnostics) in CompilerInvocation.cpp - Removed members from

[clang-tools-extra] 667867e - [clangd] Enable recovery-ast-type by default.

Author: Haojian Wu Date: 2020-08-26T16:47:04+02:00 New Revision: 667867e0df26e45ed2c86e192fee69dd484167c7 URL: https://github.com/llvm/llvm-project/commit/667867e0df26e45ed2c86e192fee69dd484167c7 DIFF: https://github.com/llvm/llvm-project/commit/667867e0df26e45ed2c86e192fee69dd484167c7.diff

[PATCH] D86624: [clang] Exclude invalid destructors from lookups.

adamcz created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. adamcz requested review of this revision. This fixes a crash when declaring a destructor with a wrong name, then writing result to pch file and loading it again. The PCH storage uses

[PATCH] D86602: [clangd] Enable recovery-ast-type by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG667867e0df26: [clangd] Enable recovery-ast-type by default. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86602/new/

[PATCH] D85150: [OpenMP] Ensure testing for versions 4.5 and default - Part 2

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85150/new/ https://reviews.llvm.org/D85150 ___

[PATCH] D86631: [Fixed Point] Add fixed-point to floating point cast types and consteval.

ebevhan created this revision. ebevhan added reviewers: leonardchan, rjmccall. Herald added subscribers: bjope, martong. Herald added a project: clang. ebevhan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86631 Files:

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2237037 , @Mordante wrote: > In D86559#2236931 , @Quuxplusone > wrote: > >> It seems like this patch would basically "copy" the `[[likely]]` attribute >> from line C up to

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

Anastasia updated this revision to Diff 287984. Anastasia added a comment. - Addressed comments from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86626/new/ https://reviews.llvm.org/D86626 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7436 "use of dynamic_cast requires -frtti">; +def warn_no_dynamic_cast_with_RTTI_disabled: Warning< + "dynamic_cast will not work since RTTI data is disabled by " The

[clang] 33ce275 - [Clang] Fix tests following rG087047144210

Author: Alexandre Ganea Date: 2020-08-26T11:32:46-04:00 New Revision: 33ce275fc156c8b015acfad918937028b2cc235c URL: https://github.com/llvm/llvm-project/commit/33ce275fc156c8b015acfad918937028b2cc235c DIFF:

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644 if (!LDat) { - Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(), - LK_Shared, Loc); +

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @CarolineConcatto - thank you for working on this! @all, thank you for your reviews, this is much appreciated! While Carol is away, I'll try my best to address all the outstanding comments. I will also update the patch accordingly. I've identified a few small issues

[PATCH] D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

erichkeane added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:395 CHECK_TARGET_OPT(CPU, "target CPU"); +CHECK_TARGET_OPT(TuneCPU, "tune CPU"); + } What does this string do? Does there have to be a test for it? CHANGES SINCE

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

aaron.ballman added a comment. In D86169#2236457 , @jonathan.protzenko wrote: > Thanks for the review! > > Regarding Declarator: I briefly mentioned something related in the details > section... actually maybe you can tell me what's the best approach

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 288062. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address cmments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files:

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu added inline comments. Comment at: clang/test/SemaCXX/ms_no_dynamic_cast.cpp:1 +// RUN: %clang_cl %s /GR- -fsyntax-only 2>&1 | FileCheck %s + hans wrote: > When using %clang_cl, the source file should always come after a "--", > otherwise if for

[clang] 677e3db - [clang][NFC] Properly fix a GCC warning in ASTImporterTest.cpp

Author: Raphael Isemann Date: 2020-08-26T17:10:13+02:00 New Revision: 677e3db5806af9c6bbe9e76c135f801e8b06a8ed URL: https://github.com/llvm/llvm-project/commit/677e3db5806af9c6bbe9e76c135f801e8b06a8ed DIFF:

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

Anastasia updated this revision to Diff 287985. Anastasia added a comment. Fixed extra space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86626/new/ https://reviews.llvm.org/D86626 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

hans added a comment. >> but we can merge this right away (IMHO) > > It is up to Hans if he has some time. But I think I covered almost all new > features (+ complex for NVPTX), so after the update it can be merged with > 11.x release. It's fine by me if you want to wait a day or two for more

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/include/clang/AST/Type.h:3228 +SveFixedLengthDataVector, +/// is AArch64 SVE fixed-length predicate

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher added a comment. MyDeveloperDay, I added your tests. Sorry to step on your toes, I didn't know there was a patch open for this already :(. Yeah, JakeMerdichAMD, it's kinda tough to handle those types of cases without some sort of parsing. I'm glad you're working on that, and my

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @andwar is my Phabricator alter-ego. Apologies for the confusion - I had my Arcanist misconfigured. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar updated this revision to Diff 288048. vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. - Removing unnecessary notetags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86027/new/

[PATCH] D86622: Fix failing tests after VCTOOLSDIR change

zahen added a comment. Sorry again about the break! As with the initial patch, I'll need you to land this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86622/new/ https://reviews.llvm.org/D86622

[PATCH] D86581: [clang-format] Handle shifts within conditions

JakeMerdichAMD added a comment. Agreed that this is a very nice solution for this case. LGTM too assuming it passes @MyDeveloperDay's tests. Minor heads up: there are still some cases I can dream up where we'd currently spit out invalid code from splitting a right shift even after this fix.

[PATCH] D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85214/new/ https://reviews.llvm.org/D85214 ___

[PATCH] D86626: [OpenCL][Docs] 10.x release notes

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86626/new/ https://reviews.llvm.org/D86626 ___ cfe-commits mailing list

[PATCH] D86624: [clang] Exclude invalid destructors from lookups.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/DeclBase.cpp:1489 return true; + if (isa(D) && D->isInvalidDecl()) +return true; split into separate block,

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2239136 , @hans wrote: >>> but we can merge this right away (IMHO) >> >> It is up to Hans if he has some time. But I think I covered almost all new >> features (+ complex for NVPTX), so after the update it can be merged

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan created this revision. ebevhan added reviewers: leonardchan, rjmccall. Herald added subscribers: llvm-commits, cfe-commits, bjope. Herald added projects: clang, LLVM. ebevhan requested review of this revision. The patch adds the required methods to FixedPointBuilder for converting between

[PATCH] D77219: UBSan ␇ runtime

jfb abandoned this revision. jfb added a comment. Herald added a subscriber: dang. I don't think the world is ready for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77219/new/ https://reviews.llvm.org/D77219

[PATCH] D85485: Fix quiet mode in git-clang-format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG294e1900f281: Fix quiet mode in git-clang-format (authored by Gvald, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo

[clang] 294e190 - Fix quiet mode in git-clang-format

Author: Gi Vald Date: 2020-08-26T18:15:52+02:00 New Revision: 294e1900f281f35aff0362232225e85c2e551e55 URL: https://github.com/llvm/llvm-project/commit/294e1900f281f35aff0362232225e85c2e551e55 DIFF: https://github.com/llvm/llvm-project/commit/294e1900f281f35aff0362232225e85c2e551e55.diff LOG:

[PATCH] D86636: [SyntaxTree] Refactor `NodeRole`s

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:156 // Roles specific to particular node kinds. - OperatorExpression_operatorToken, -

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante marked 4 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1726 + } + }]; +} aaron.ballman wrote: > Something else we should document is what our behavior is when the attribute > is not

  1   2   >