[PATCH] D85032: [builtins] Make divXf3 handle denormal results

atrosinenko updated this revision to Diff 288851. atrosinenko added a comment. Herald added a subscriber: danielkiss. Re-upload after amending parent diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85032/new/ https://reviews.llvm.org/D85032

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. As Hungarian notation enforces prefixes as well as casing styles it would be wise to warn on cases where the style is Hungarian but a prefix has also been set. Another issue is this current set up will let you define any decls style as hungarian, this doesn't make

[PATCH] D86400: [NFC][compiler-rt] Factor out __div[sdt]i3 and __mod[dt]i3 implementations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11cf6346fd49: [NFC][compiler-rt] Factor out __div[sdt]i3 and __mod[dt]i3 implementations (authored by atrosinenko). Repository: rG LLVM Github

[PATCH] D86780: Copy blocks in variadic methods

sunbohong updated this revision to Diff 288853. sunbohong added a comment. Herald added a subscriber: danielkiss. Update copy blocks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86780/new/ https://reviews.llvm.org/D86780 Files:

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko updated this revision to Diff 288850. atrosinenko added a comment. Herald added a subscriber: danielkiss. Add more clarifications, fix explanation for "why it is enough to adjust only once in case of overflow". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rjmccall added a comment. I'd still like @rsmith to sign off here as code owner. Comment at: clang/include/clang/Basic/IdentifierTable.h:231 return ObjCOrBuiltinID == tok::NUM_OBJC_KEYWORDS; } Do we need to support reverting builtins anymore?

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

jdoerfert added a comment. Can you add the test that exposed this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 ___ cfe-commits mailing list

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge updated this revision to Diff 21. nridge marked 4 inline comments as done. nridge added a comment. Herald added a subscriber: danielkiss. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86424/new/

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. FYI: PR45410, which this fixes, has been marked as a release blocker for 11.0.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

craig.topper added inline comments. Comment at: clang/lib/Headers/mmintrin.h:367 { -return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2); +return (__m64)(((__v8qi)__m1) + ((__v8qi)__m2)); } I think you we should use __v8qu to match what we do

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge updated this revision to Diff 22. nridge added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86424/new/ https://reviews.llvm.org/D86424 Files: clang/lib/Index/IndexTypeSourceInfo.cpp

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

nullptr.cpp created this revision. nullptr.cpp added a reviewer: ABataev. Herald added subscribers: cfe-commits, danielkiss, guansong, yaxunl. Herald added a project: clang. nullptr.cpp requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1.

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2246570 , @njames93 wrote: > As Hungarian notation enforces prefixes as well as casing styles it would be > wise to warn on cases where the style is Hungarian but a prefix has also been > set. > > Another issue is

[PATCH] D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM modulo the minor fix Comment at: clang/lib/CodeGen/CGDecl.cpp:2107 +// FIXME: When popping normal cleanups, we need to keep this EH cleanup +// around in

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

jyknight created this revision. jyknight added reviewers: craig.topper, spatel, RKSimon. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. jyknight requested review of this revision. Preliminary patch, posted to go along with discussion on llvm-dev. 3DNow!

[PATCH] D86853: [modules] Repro for pure virtual base class method crash

andrewjcg created this revision. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. andrewjcg requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86853 Files: clang/lib/Serialization/ASTReaderDecl.cpp

[PATCH] D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context

erik.pilkington created this revision. erik.pilkington added reviewers: ahatanak, rjmccall. Herald added subscribers: danielkiss, ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. Previously, clang was crashing on the attached test because the EH cleanup for the