[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

tra added a comment. > Currently CUDA/HIP toolchain uses "unknown" as bound arch > for offload action for fat binary. This causes -mcpu or -march > with "unknown" added in HIPToolChain::TranslateArgs or > CUDAToolChain::TranslateArgs. It would appear that the problem is actually where we check

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:168 +nline.join(class_members), +nline.join([" float EvaluateTree%d() const;" % tree_num +for tree_num in range(num_trees)]),

[PATCH] D88296: [clang-format] De-duplicate includes with leading or trailing whitespace.

curdeius added a comment. Thanks for the review. I agree with you that a clang-format user should not expect a perfectly formatted code after a single iteration. Maybe it's actually a documentation issue and we should be clear about it? Just a guarantee of 1) stability of formatting and 2)

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

This revision was automatically updated to reflect the committed changes. Closed by commit rGce5379f0f067: [NPM] Add target specific hook to add passes for New Pass Manager (authored by aeubanks). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] ce5379f - [NPM] Add target specific hook to add passes for New Pass Manager

Author: Arthur Eubanks Date: 2020-09-30T13:29:43-07:00 New Revision: ce5379f0f0675592fd10a522009fd5b1561ca72b URL: https://github.com/llvm/llvm-project/commit/ce5379f0f0675592fd10a522009fd5b1561ca72b DIFF:

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

steakhal added a comment. In D88019#2303078 , @martong wrote: > I like the second approach, i.e. to have a debug checker. But I don't see, > how would this checker validate all constraints at the moment when they are > added to the State.

[PATCH] D88590: [clangd] Add bencmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295338. usaxena95 added a comment. Minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tools-extra/clangd/benchmarks/CMakeLists.txt

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:168 +nline.join(class_members), +nline.join([" float EvaluateTree%d() const;" % tree_num +for tree_num in range(num_trees)]),

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

yaxunl added a comment. In D88524#2304173 , @tra wrote: >> Currently CUDA/HIP toolchain uses "unknown" as bound arch >> for offload action for fat binary. This causes -mcpu or -march >> with "unknown" added in HIPToolChain::TranslateArgs or >>

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. In D88477#2303376 , @steakhal wrote: > In the Summary's example, at location `#2` the value of `**p` is > `{SymRegion{reg_$0},0 S64b,unsigned char}` - which is > exactly what we stored at line `#1`. > > void test(int *a, char

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

tra added a comment. In D88524#2304224 , @yaxunl wrote: > This translates to "unknown" in string form, which feels arbitrary. What if a > target has a valid cpu name which "unknown"? Isn't a nullptr (empty string in > string form) a more generic format

[PATCH] D88393: [cfe][M68K] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 295468. myhsu added a comment. Fix formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D88394: [Driver][M68K] (Patch 8/8) Add driver support for M68K

myhsu updated this revision to Diff 295469. myhsu added a reviewer: aaron.ballman. myhsu added a comment. Fix formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +LoopMustProgress = true; aqjune wrote: > A

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2290 + // rounding mode. + if (VD->isFileVarDecl() || VD->isConstexpr() || + (!getLangOpts().CPlusPlus && VD->isStaticLocal())) { sepavloff wrote: > rsmith

[PATCH] D88546: [ARM] Update NEON testcase with missing target string in

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88546/new/ https://reviews.llvm.org/D88546

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl updated this revision to Diff 295297. yaxunl edited the summary of this revision. yaxunl added a comment. Add test and fix multiple -m[no-]wavefrontsize64 issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88370/new/ https://reviews.llvm.org/D88370 Files:

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:394-395 + // Get the last argument of -mwavefrontsize64 or -mno-wavefrontsize64. + for (auto WaveArg : Args.filtered_reverse(options::OPT_mwavefrontsize64, +

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:394-395 + // Get the last argument of -mwavefrontsize64 or -mno-wavefrontsize64. + for (auto WaveArg : Args.filtered_reverse(options::OPT_mwavefrontsize64, +

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:394-395 + // Get the last argument of -mwavefrontsize64 or -mno-wavefrontsize64. + for (auto WaveArg : Args.filtered_reverse(options::OPT_mwavefrontsize64, +

[PATCH] D88260: [NFC][FE] Replace TypeSize with StorageUnitSize

This revision was automatically updated to reflect the committed changes. Closed by commit rG944691f0b7fa: [NFC][FE] Replace TypeSize with StorageUnitSize (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88260/new/

[clang] 944691f - [NFC][FE] Replace TypeSize with StorageUnitSize

Author: Xiangling Liao Date: 2020-09-30T10:32:53-04:00 New Revision: 944691f0b7fa8d99790a4544545e55f014c37295 URL: https://github.com/llvm/llvm-project/commit/944691f0b7fa8d99790a4544545e55f014c37295 DIFF:

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Should we also have another test for SymbolCollector, to ensure we don't regress this somehow in the future? Comment at:

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG216af81c39d1: [clangd] Fix invalid UTF8 when extracting doc comments. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D88567?vs=295265=295266#toc Repository: rG LLVM

[clang-tools-extra] 216af81 - [clangd] Fix invalid UTF8 when extracting doc comments.

Author: Sam McCall Date: 2020-09-30T16:05:12+02:00 New Revision: 216af81c39d1cc4e90af7b991d517c4c7acc912e URL: https://github.com/llvm/llvm-project/commit/216af81c39d1cc4e90af7b991d517c4c7acc912e DIFF: https://github.com/llvm/llvm-project/commit/216af81c39d1cc4e90af7b991d517c4c7acc912e.diff

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

sammccall added a comment. In D88567#2303332 , @kadircet wrote: > thanks, LGTM! > > Should we also have another test for SymbolCollector, to ensure we don't > regress this somehow in the future? We had a SymbolCollector test for the boost case so I

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

steakhal added a comment. In D88477#2301641 , @NoQ wrote: > A load from a region of type `T` should always yield a value of type `T` > because that's what a load is. > > I'd rather have it as an assertion: if the region is typed, the type > shouldn't be

[clang] 3a7487f - [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Author: Xiangling Liao Date: 2020-09-30T10:48:28-04:00 New Revision: 3a7487f903e2a6be29de39058eee2372e30798d5 URL: https://github.com/llvm/llvm-project/commit/3a7487f903e2a6be29de39058eee2372e30798d5 DIFF:

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

usaxena95 updated this revision to Diff 295284. usaxena95 added a comment. Minor formatting fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88536/new/ https://reviews.llvm.org/D88536 Files:

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a7487f903e2: [FE] Use preferred alignment instead of ABI alignment for complete object when… (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall updated this revision to Diff 295290. sammccall marked 6 inline comments as done. sammccall added a comment. address (some of) comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88338/new/ https://reviews.llvm.org/D88338 Files:

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:87 +auto Mangler = CommandMangler::detect(); +// Check for missing resource dir? +if (Opts.ResourceDir) kadircet wrote: > i agree, this would help identifying the

<    1   2