[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

arphaman created this revision. arphaman added reviewers: thakis, dexonsmith. Herald added subscribers: Sanitizers, ributzka, dmgreen, jkorous. Herald added projects: clang, Sanitizers. arphaman requested review of this revision. The __isPlatformVersionAtLeast routine is an implementation of `if

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

arphaman added a comment. This warrants a revert since it's breaking ABI compatibility for our libclang's users. @Anastasia will you be able to take a look at this soon? I plan on reverting this patch in a couple of weeks if the issue is still unresolved. Repository: rG LLVM Github Monorepo

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

xazax.hun added a comment. I know that the current situation is a mess, but there is an alternative version of scan-build-py on Github, which is also distributed on pypi. Could you check if that version is also susceptible to this problem and open a pull request for the author in case it is?

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:337 + +Config.assign((*Text)->getBuffer()); + } DmitryPolukhin wrote: > I suggest creating new local variable with text of the config from `Config` > or

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:51 +return llvm::StringRef(); + return Path; +} not that if Path == FragmentDir you're going to return "" which means "not under". I don't think this can happen yet,

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 301564. jansvoboda11 added a comment. Herald added a subscriber: mgrang. Integrated code review suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files:

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

njames93 added a comment. It's also be nice if --config-file would also support being passed a directory. If a directory was passed it would append ".clang-tidy" to the path and load that file, WDYT? Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kbobyrev added a comment. LGTM, thanks! Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h sammccall wrote: > kbobyrev wrote: > > On line 89

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362 ___

[PATCH] D90291: [clangd] Add lit tests for remote index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:1 +# RUN: rm -rf %/t +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex nit: `/` shouldn't be needed here. the difference between %t and

[PATCH] D90291: [clangd] Add lit tests for remote index

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex +# RUN: python %/S/pipeline_helper.py --input-file-name=%s --server-address=0.0.0.0:50051

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thanks for the feedback Duncan. I don't think this patch introduces any changes the parser. We only change the way how `CodeGenOpts` and `LangOpts` get populated when using `DefaultAnyOf<[...]>`. I've added a test of `CompilerInvocation` that checks just that.

[clang-tools-extra] 1d773a4 - [CMake] Support inter-proto dependencies in generate_protos.

Author: Sam McCall Date: 2020-10-29T10:04:20+01:00 New Revision: 1d773a4ff05d0dcfab112719b82b2bd5d0c93ff5 URL: https://github.com/llvm/llvm-project/commit/1d773a4ff05d0dcfab112719b82b2bd5d0c93ff5 DIFF: https://github.com/llvm/llvm-project/commit/1d773a4ff05d0dcfab112719b82b2bd5d0c93ff5.diff

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d773a4ff05d: [CMake] Support inter-proto dependencies in generate_protos. (authored by sammccall). Changed prior to commit:

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h kbobyrev wrote: > sammccall wrote: > > kbobyrev wrote: > >

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:162 return false; +llvm::StringRef Path = P.Path; +// Ignore the file if it is not nested under Fragment and strip the sammccall wrote:

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:337 + +Config.assign((*Text)->getBuffer()); + } DmitryPolukhin wrote: > DmitryPolukhin wrote: > > I suggest creating new local variable with text of the config

[PATCH] D89126: [clangd] Support CodeActionParams.only

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Sorry, it seems I forgot about this one :( LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89126/new/ https://reviews.llvm.org/D89126

[clang-tools-extra] 5627ae6 - [clangd] Support CodeActionParams.only

Author: Sam McCall Date: 2020-10-29T09:44:08+01:00 New Revision: 5627ae6c507d62ef52d30fe80a0120f2ee033123 URL: https://github.com/llvm/llvm-project/commit/5627ae6c507d62ef52d30fe80a0120f2ee033123 DIFF: https://github.com/llvm/llvm-project/commit/5627ae6c507d62ef52d30fe80a0120f2ee033123.diff

[PATCH] D89126: [clangd] Support CodeActionParams.only

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5627ae6c507d: [clangd] Support CodeActionParams.only (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will allow us to track metrics of the

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf00267f1fdb: clang-format: Add a consumer to diagnostics engine (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] df00267 - clang-format: Add a consumer to diagnostics engine

Author: Krasimir Georgiev Date: 2020-10-29T11:28:27+01:00 New Revision: df00267f1fdb0b098dc42f1caa8a59b29c8e0e5f URL: https://github.com/llvm/llvm-project/commit/df00267f1fdb0b098dc42f1caa8a59b29c8e0e5f DIFF:

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp updated this revision to Diff 301810. nullptr.cpp added a comment. make test more clearly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 Files: clang/lib/Sema/SemaStmt.cpp

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

rupprecht added a comment. In D84604#2363445 , @aaronpuchert wrote: > Pushed a fix in rGbbed8cfe80cd27d3a47d877c7608d9be4e487d97 > . For > now we just consider all static members as

[clang] edd6ed3 - [NFC] Don't run clang/bindings/python/tests with msan

Author: Vitaly Buka Date: 2020-10-29T22:29:25-07:00 New Revision: edd6ed364151adf3f0eede3d6d22db1018bfd601 URL: https://github.com/llvm/llvm-project/commit/edd6ed364151adf3f0eede3d6d22db1018bfd601 DIFF: https://github.com/llvm/llvm-project/commit/edd6ed364151adf3f0eede3d6d22db1018bfd601.diff

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

bryanpkc added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64SchedTSV110.td:9 +// +// This file defines the machine model for ARM Huawei TSV110 to support +// instruction scheduling and other instruction cost heuristics. I suggest deleting the word

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. In D88295#2358845 , @aaronpuchert wrote: > Could you perhaps integrate this into the existing test > `clang/test/CXX/special/class.copy/implicit-move.cpp` instead? > Whenever you have something that closely corresponds to

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

SjoerdMeijer added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:298 +// RUN: %clang -target aarch64 -mcpu=tsv110 -### -c %s 2>&1 | FileCheck -check-prefix=TSV110 %s +// RUN: %clang -target aarch64 -mlittle-endian -mcpu=tsv110 -### -c %s 2>&1 | FileCheck

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

ilya-golovenko added a comment. I don't have commit access could you please commit it on my behalf? Ilya Golovenko Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90384/new/ https://reviews.llvm.org/D90384

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

awarzynski added a comment. Hi All, I've just noticed this patch and realised that it takes `DiagnosticBuilder` in the direction tangential to what we proposed in [1]. I've just restarted our efforts with regard to refactoring these APIs and feel that it would be good to coordinate any future

[PATCH] D80499: Remove obsolete ignore*() matcher uses

steveire added a comment. > ! In D80499#2353187 , @alexfh wrote: > You should be ready for back and forth with this change, if users hit > widespread issues not caught by tests. Maybe splitting it into separate > pieces and involving check authors where

[PATCH] D90396: [VE] Change to use integrated assembly by defualt

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Great work! Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90396/new/ https://reviews.llvm.org/D90396

[PATCH] D90397: [clangd] Value initialize SymbolIDs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolID.h:57 + bool isValid() const { return HashValue != std::array{}; } + I'm not a big fan of LLVM's habit of calling the sentinel value "invalid". Consider SourceLocation - one

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. IIUC, this is handling the case where `Ptr.reset(new int)` which is different to `Ptr.reset(new int())` because the former doesn't initialise the int while the latter

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall added a comment. It sounds like what you want is a diagnostic library that's almost completely abstracted over the kinds of entities that can be stored in a diagnostic, including the definition of a source location. I don't think that's incompatible with this patch; there's no need

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82278/new/ https://reviews.llvm.org/D82278 ___ cfe-commits mailing list

[clang] 08bb5d9 - [FPEnv] Tests for rounding properties of constant evalution

Author: Serge Pavlov Date: 2020-10-29T13:53:13+07:00 New Revision: 08bb5d9196b3fed9a530d28a8a0f06438ab7a8ee URL: https://github.com/llvm/llvm-project/commit/08bb5d9196b3fed9a530d28a8a0f06438ab7a8ee DIFF: https://github.com/llvm/llvm-project/commit/08bb5d9196b3fed9a530d28a8a0f06438ab7a8ee.diff

[PATCH] D90026: [FPEnv] Tests for rounding properties of constant evalution

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08bb5d9196b3: [FPEnv] Tests for rounding properties of constant evalution (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @krasimir Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89670: [clangd] Store the containing symbol for refs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:91 RefKind Kind = RefKind::Unknown; + SymbolID Container; }; i am afraid we are going to have an indeterminate value here if for whatever reason `Container` detection fails.

[clang-tools-extra] 7df80a1 - [clangd] Add support for multiple DecisionForest model experiments.

Author: Utkarsh Saxena Date: 2020-10-29T19:49:40+01:00 New Revision: 7df80a1204f0dc91fb8bba7635e2354adf08989f URL: https://github.com/llvm/llvm-project/commit/7df80a1204f0dc91fb8bba7635e2354adf08989f DIFF:

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2362327 , @lebedev.ri wrote: > In D90392#2362308 , @ckennelly wrote: > >> In D90392#2362118 , @njames93 wrote: >> >>> IIUC, this is

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

efriedma added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723 + bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() || + Ty->isAggregateType(); bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64;

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1013 CXXMethodDecl *getLambdaStaticInvoker() const; + CXXMethodDecl *getLambdaStaticInvoker(CallingConv CC) const; + Probably worth clarifying in the comment which invoker is

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

fodinabor created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. fodinabor requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. This is very similar to 7f1e6fcff942

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

mibintc updated this revision to Diff 301708. mibintc added a comment. respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90316/new/ https://reviews.llvm.org/D90316 Files:

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2967 +PP.Diag(Tok.getLocation(), diag::warn_pragma_fp_ignored) +<< PragmaName.getIdentifierInfo()->getName(); +return;

[PATCH] D90397: [clangd] Value initialize SymbolIDs

kadircet updated this revision to Diff 301678. kadircet marked an inline comment as done. kadircet added a comment. - change invalid -> null. - add an implicit bool conversion operator. - update apis returning optionals. Note that all the functional changes are in SymbolID.h, rest is api

[clang] be6f507 - [WebAssembly] Implement SIMD signselect instructions

Author: Thomas Lively Date: 2020-10-29T11:06:20-07:00 New Revision: be6f50798e79336cdfd8fe464f37d41ac135640d URL: https://github.com/llvm/llvm-project/commit/be6f50798e79336cdfd8fe464f37d41ac135640d DIFF: https://github.com/llvm/llvm-project/commit/be6f50798e79336cdfd8fe464f37d41ac135640d.diff

[PATCH] D90357: [WebAssembly] Implement SIMD signselect instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe6f50798e79: [WebAssembly] Implement SIMD signselect instructions (authored by tlively). Herald added a subscriber: wingo. Repository: rG LLVM

[clang] 5d1eae7 - Add support of the next Ubuntu (Ubuntu 21.04 - Hirsute Hippo)

Author: Sylvestre Ledru Date: 2020-10-29T19:11:32+01:00 New Revision: 5d1eae7d23e3477d6044cf9d60a90ce9719f17e6 URL: https://github.com/llvm/llvm-project/commit/5d1eae7d23e3477d6044cf9d60a90ce9719f17e6 DIFF:

[PATCH] D90014: [clangd] Add support for multiple DecisionForest model experiments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7df80a1204f0: [clangd] Add support for multiple DecisionForest model experiments. (authored by usaxena95). Repository: rG LLVM Github Monorepo

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

aaron.ballman added a comment. In D90109#2360538 , @dsanders11 wrote: >> What issues did you run into regarding testing, because I feel like the >> patch should have test coverage (esp given that color vs ANSI escape codes >> are a bit of an oddity to

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. Specify only one.\n"; +

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added a comment. I've put up https://reviews.llvm.org/D90385 as a fix for this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 ___ cfe-commits

[PATCH] D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

mantognini created this revision. mantognini added reviewers: arphaman, akyrtzi, rsmith, Anastasia. Herald added a project: clang. Herald added a subscriber: cfe-commits. mantognini updated this revision to Diff 301579. mantognini added a comment. mantognini published this revision for review.

[clang] 637c77f - Revert "clang-format: Add a consumer to diagnostics engine"

Author: Nico Weber Date: 2020-10-29T10:29:53-04:00 New Revision: 637c77fda64a9b4c021be9c2f89fe8995613c7ed URL: https://github.com/llvm/llvm-project/commit/637c77fda64a9b4c021be9c2f89fe8995613c7ed DIFF: https://github.com/llvm/llvm-project/commit/637c77fda64a9b4c021be9c2f89fe8995613c7ed.diff

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis reopened this revision. thakis added a comment. This revision is now accepted and ready to land. This doe snot lgtm. clang-format should not depend on clangFrontend, see the lengthy discussion in https://reviews.llvm.org/D68554 . Let's try to find another fix here (and include a test for

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex +# RUN: python %/S/pipeline_helper.py --input-file-name=%s --server-address=0.0.0.0:50051

Re: [clang] 552c6c2 - PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

Hi Richard, this fires on thakis@thakis:~/src/llvm-project$ cat foo.m static const int gSignals[] = { 0, 1, 2, 3, 4 }; static const int kNumSignals = sizeof(gSignals) / sizeof(gSignals[0]); static int gPreviousSignalHandlers[kNumSignals]; thakis@thakis:~/src/llvm-project$ out/gn/bin/clang -c

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ilya-golovenko requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Google test matcher DeclKind uses

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor updated this revision to Diff 301577. teemperor added a comment. - Respect forced deserialisation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80878/new/ https://reviews.llvm.org/D80878 Files: clang/include/clang/AST/TextNodeDumper.h clang/lib/AST/ASTDumper.cpp

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. Specify only one.\n"; +

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

hans added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + akyrtzi wrote: > Hi Anastasia, apologies for not catching this earlier, but libclang is > intended to keep a stable ABI and changing the

[libunwind] 05598e3 - [libunwind] Fix linker flag handling in the tests.

Author: Daniel Kiss Date: 2020-10-29T14:02:44+01:00 New Revision: 05598e3d3047cf028cc3e61f3268ff7d999e5f26 URL: https://github.com/llvm/llvm-project/commit/05598e3d3047cf028cc3e61f3268ff7d999e5f26 DIFF: https://github.com/llvm/llvm-project/commit/05598e3d3047cf028cc3e61f3268ff7d999e5f26.diff

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Great! Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90384/new/ https://reviews.llvm.org/D90384

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly created this revision. ckennelly added reviewers: EricWF, ymandel. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ckennelly requested review of this revision. This extends the check for default initialization in arrays added in 547f89d6070 to include

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301619. kbobyrev marked an inline comment as done. kbobyrev added a comment. Rebase on top of master, don't force forward slashes in project root, format Python helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90366: [ThinLTO] Strenghten the test for .llvmcmd embedding

tejohnson added a comment. The motivation and effects of the change are unclear to me. Does this mean that the .llvmcmd section is always emitted? Or always emitted whenever any bitcode embedding is requested? Comment at: clang/test/CodeGen/thinlto_embed_bitcode.ll:28 ;

[PATCH] D90397: [clangd] Value initialize SymbolIDs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. We were default initializing SymbolIDs

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov added a comment. Who can confirm if this is correct or somewhere it needs fixes? Here is a generated result of `evalCast` from the origin branch(before the patch): void foo(int* x, // {reg_$0} int** y, // {reg_$0} int***z) // {reg_$0} { (void*)x;

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/new/ https://reviews.llvm.org/D89559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

c-rhodes marked 2 inline comments as done. c-rhodes added a comment. In D88233#2359022 , @fpetrogalli wrote: > Hi @c-rhodes, Peter asked me to take a look at this. LGTM, I only have minor > stuff. > > In the commit message: > >> Arm C Language Extensions

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @thakis There's a simple option of moving `TextDiagnosticPrinter` into `libBasic` thus eliminating neccessety to depend on `libFrontend`. How does that sound? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

Elvina added a comment. Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89972/new/ https://reviews.llvm.org/D89972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90389: Test commit, please ignore

goncharov created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. goncharov requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90389 Files: clang-tools-extra/docs/new_file.txt Index:

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + hans wrote: > akyrtzi wrote: > > Hi Anastasia, apologies for not catching this earlier, but libclang is > > intended to keep a

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

c-rhodes updated this revision to Diff 301603. c-rhodes edited the summary of this revision. c-rhodes added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88233/new/ https://reviews.llvm.org/D88233 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301607. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/CMakeLists.txt

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301606. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files:

[PATCH] D90396: [VE] Change to use integrated assembly by defualt

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added a project: clang. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. We've implemented integrated assembler. Now, we change to use integrated assembler

[PATCH] D90291: [clangd] Add lit tests for remote index

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %S/Inputs/Source.cpp > %t.idx +# RUN: %python %S/pipeline_helper.py --input-file-name=%s --project-root=%/S --index-file=%t.idx | FileCheck %s +#

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. In D89936#2361580 , @njames93 wrote: > It's also be nice if --config-file would also support being passed a > directory. If a directory was passed it would append ".clang-tidy" to the > path and load that file, WDYT? It

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. Specify only one.\n"; + return

[PATCH] D90364: [AMDGPU] Update AMD GPU documentation

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90364/new/ https://reviews.llvm.org/D90364

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:135 + New->getAllocatedType(), *Result.Context); + if

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

krasimir added a comment. In D90121#2361985 , @thakis wrote: > This doe snot lgtm. clang-format should not depend on clangFrontend, see the > lengthy discussion in https://reviews.llvm.org/D68554 . Let's try to find > another fix here (and include a

[PATCH] D90366: [ThinLTO] Strenghten the test for .llvmcmd embedding

mtrofin added a comment. In D90366#2362052 , @tejohnson wrote: > The motivation and effects of the change are unclear to me. Does this mean > that the .llvmcmd section is always emitted? Or always emitted whenever any > bitcode embedding is requested?

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1013 CXXMethodDecl *getLambdaStaticInvoker() const; + CXXMethodDecl *getLambdaStaticInvoker(CallingConv CC) const; + erichkeane wrote: > rjmccall wrote: > > Probably worth

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

fodinabor updated this revision to Diff 301726. fodinabor edited the summary of this revision. fodinabor added a comment. Add missing macro definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90415/new/ https://reviews.llvm.org/D90415

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

pcc created this revision. pcc added reviewers: eugenis, hctim. Herald added subscribers: Sanitizers, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, Sanitizers, LLVM. pcc requested review of this revision. >From a code size perspective it turns out to be better

[PATCH] D90424: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

pcc created this revision. pcc added reviewers: eugenis, hctim. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pcc requested review of this revision. In a kernel (or in general in environments where bit 55 of the address is set)

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, LGTM. Comment at: clang/include/clang/AST/DeclCXX.h:1013 CXXMethodDecl *getLambdaStaticInvoker() const; + CXXMethodDecl *getLambdaStaticInvoker(CallingConv

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4280 "candidate %sub{select_ovl_candidate_kind}0,1,2 not viable: " -"expects an l-value for " +

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman added a comment. In D89743#2360258 , @sammccall wrote: > (while this is useful to you, let's keep discussing, but I'm also happy to > stop and land this with your preferred API/semantics - just LMK if changes > are needed) Let's hold off

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

aeubanks added a comment. Looking at BackendUtil.cpp in Clang as well as the Rust code, I'm back to thinking that we should provide a way to to all callbacks. Then in the case of passes added via TargetMachine, we should extend `TargetMachine::registerPassBuilderCallbacks` to also take a

[PATCH] D90419: [AMDGPU] Add gfx90c target

tpr created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm, jholewinski. Herald added a reviewer: jhenderson. Herald added projects: clang, LLVM. tpr requested review of

[PATCH] D90054: Added remotely ran compiler-rt tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aaafa06b2af: Added remotely ran compiler-rt tests. (authored by aorlov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8aaafa0 - Added remotely ran compiler-rt tests.

Author: Alex Orlov Date: 2020-10-30T00:11:16+04:00 New Revision: 8aaafa06b2afce8d0c7ac062708fd91aae01909f URL: https://github.com/llvm/llvm-project/commit/8aaafa06b2afce8d0c7ac062708fd91aae01909f DIFF: https://github.com/llvm/llvm-project/commit/8aaafa06b2afce8d0c7ac062708fd91aae01909f.diff

  1   2   >