[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:79 auto IncomingLevel2 = incomingCalls(IncomingLevel1[0].from, Index.get()); -

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b6f47595bab: [clangd] Sort results of incomingCalls request by container name (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 5b6f475 - [clangd] Sort results of incomingCalls request by container name

Author: Nathan Ridge Date: 2020-11-24T03:29:02-05:00 New Revision: 5b6f47595bab686c6c3351fc1bd1f564add80dbf URL: https://github.com/llvm/llvm-project/commit/5b6f47595bab686c6c3351fc1bd1f564add80dbf DIFF: https://github.com/llvm/llvm-project/commit/5b6f47595bab686c6c3351fc1bd1f564add80dbf.diff

[PATCH] D91428: Add support for multiple program address spaces

pmatos added a comment. Thanks, @arichardson and @jrtc27 for your comments. I am definitely surprised to find that if you explicitly mark the call with the address space, this patch is not required. At first look, this RFC is not required any more but I need sometime to investigate further. If

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 307298. LuoYuanke retitled this revision from "[X86] Add x86_amx type for intel AMX. " to "[X86] Add x86_amx type for intel AMX.". LuoYuanke added a comment. Address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83698: Port Target option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgrang. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. In some cases system includes extractions is not enough, we

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

psmith added a comment. Radio silence so far; I think no news is good news applies in this case. I'm happy to say no objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91760/new/ https://reviews.llvm.org/D91760

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307308. jansvoboda11 added a comment. Undo moving of options (NFC) & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698 Files:

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. NVM, found the summary https://github.com/clangd/clangd/issues/162#issuecomment-653981038 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. i remember discussing this in the past, and having "negative" feelings about it. I couldn't find the discussion on the issues page tho, could you toss me the link if you can find it? (it might've been an offline discussion as well, sorry if that's the case for not

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a project: clang. Herald added a subscriber: cfe-commits. sdmitriev requested review of this revision. Use a different container that preserves existing elements on modification for storing temporary file names.

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX added reviewers: sammccall, kadircet. ArcsinX added a comment. I'm not sure if this solution is elegant enough. I will be happy to hear advices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92012/new/ https://reviews.llvm.org/D92012

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, nridge

[PATCH] D91859: [clangd] Fix shared-lib builds

kadircet updated this revision to Diff 307281. kadircet added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Link protobuf and grpc++ publicly to generated targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 307306. fpetrogalli added a comment. Rebase on top of D92020 . NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 Files:

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

nridge updated this revision to Diff 307262. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92009/new/ https://reviews.llvm.org/D92009 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

hokein added a comment. I assume this fixes https://github.com/clangd/clangd/issues/582? can you check the static members in template classes etc? I think the AST is different. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:131 +// Clang AST does not store

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 307300. LuoYuanke added a comment. Address Craig's comments. Change dyn_cast to cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files:

[PATCH] D91859: [clangd] Fix shared-lib builds

This revision was automatically updated to reflect the committed changes. Closed by commit rGf726101b6240: [clangd] Fix shared-lib builds (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91859/new/

[clang-tools-extra] f726101 - [clangd] Fix shared-lib builds

Author: Kadir Cetinkaya Date: 2020-11-24T13:05:20+01:00 New Revision: f726101b6240a6740b3c0926af759da5e7336f8a URL: https://github.com/llvm/llvm-project/commit/f726101b6240a6740b3c0926af759da5e7336f8a DIFF:

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, the order of elements in `IncomingLevel2` is

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, kadircet

[PATCH] D92000: [clangd] Collect main file refs by default

nridge added a comment. Note, the call hierarchy feature is pretty significantly impaired without this. See the example of `Selection::createEach()` discussed in this comment . Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

wmi accepted this revision. wmi added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return

[PATCH] D92051: [clangd] PopulateSwitch: disable on dependent enums.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. If the enum is a dependent type, we would crash somewhere in

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

adamcz updated this revision to Diff 307429. adamcz added a comment. typo in description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92053/new/ https://reviews.llvm.org/D92053 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp

[PATCH] D92012: [clangd][query-driver] Extract target

kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:212 + if (!Target.empty()) { +Cmd.CommandLine.push_back("-target"); +Cmd.CommandLine.push_back(Target); sammccall wrote: > `clang -target foo test.cc` seems to

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov updated this revision to Diff 307436. azabaznov marked 24 inline comments as done. azabaznov added a comment. Addressed almost all technical and cosmetic concerns concerns. Except putting reference of `OpenCLOptions` in `Sema` due to const of `TargetInfo`. I think I'll think about

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:72 LLVMContext = Builder.getContext(); - Type *Ty = LD->getType(); - EVT VT = EVT::getEVT(Ty); - EVT HalfVT = VT.getHalfNumVectorElementsVT(Ctx); - Type *HalfTy =

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

MaskRay created this revision. MaskRay added reviewers: PowerPC, Bdragon28, nemanjai. Herald added subscribers: cfe-commits, steven.zhang, kbarton, krytarowski, arichardson, emaste. Herald added a project: clang. MaskRay requested review of this revision. GCC made the switch in 2018-04-10

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 7 inline comments as done. ZarkoCA added inline comments. Comment at: clang/test/CodeGen/altivec.c:7 + +// RUN: %clang -S -emit-llvm -maltivec -mabi=vec-extabi -target powerpc-unknown-aix %s -o - | FileCheck %s +// RUN: not %clang -S -emit-llvm -mabi=vec-default

[clang-tools-extra] 1e82121 - [clangd] Add more trace spans for rename, NFC.

Author: Haojian Wu Date: 2020-11-24T19:57:05+01:00 New Revision: 1e821217cb3619449d536978bae7c9f05bdf0fa5 URL: https://github.com/llvm/llvm-project/commit/1e821217cb3619449d536978bae7c9f05bdf0fa5 DIFF: https://github.com/llvm/llvm-project/commit/1e821217cb3619449d536978bae7c9f05bdf0fa5.diff

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307416. njames93 marked 5 inline comments as done. njames93 added a comment. Address (most of the) comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files:

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 marked 12 inline comments as done and an inline comment as not done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:241 +/// Empty clang tidy provider, using this as a provider will disable clang-tidy. +static void

[clang] 8f8bbf9 - [test] Clean up ppc-features.cpp and improve tests

Author: Fangrui Song Date: 2020-11-24T11:59:15-08:00 New Revision: 8f8bbf98dae1c513b70614a9640b861e6e240b5f URL: https://github.com/llvm/llvm-project/commit/8f8bbf98dae1c513b70614a9640b861e6e240b5f DIFF: https://github.com/llvm/llvm-project/commit/8f8bbf98dae1c513b70614a9640b861e6e240b5f.diff

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

airlied added a comment. In D92004#2413560 , @Anastasia wrote: > Btw how about making some checks simpler. We could always define feature > macros `__opencl_c_atomic_scope_device`, `__opencl_c_generic_address_space` > for OpenCL 2.0 or C++ for OpenCL .

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[clang] 0768b05 - Avoid redundant work when computing vtable vcall visibility

Author: Teresa Johnson Date: 2020-11-24T12:06:24-08:00 New Revision: 0768b0576a938b6a4832884384fcb02cd2f74e09 URL: https://github.com/llvm/llvm-project/commit/0768b0576a938b6a4832884384fcb02cd2f74e09 DIFF:

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG0768b0576a93: Avoid redundant work when computing vtable vcall visibility (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91676/new/

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 307408. vsavchenko added a comment. Fix tests and a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files:

[PATCH] D92048: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: fanbo-meng, Kai, uweigand, Jonathan.Crowther, muiez. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. abhina.sreeskantharajan requested review of this revision. This patch moves all

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. When type/function is defined in the middle of the file, previuosly we

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D50979: Eliminate instances of `EmitScalarExpr(E->getArg(n))` in EmitX86BuiltinExpr().

rnk added inline comments. Herald added a subscriber: pengfei. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10471 case X86::BI_InterlockedIncrement64: return EmitMSVCBuiltinExpr(MSVCIntrin::_InterlockedIncrement, E); case X86::BI_InterlockedCompareExchange128: {

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4624 + + if (Triple.isOSAIX()) { +if (Args.hasArg(options::OPT_maltivec) && line 4624 to line 4635 can be simplified to : ``` if (Triple.isOSAIX() &&

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:158 + +if (MustInsertAfterLoc.isValid() && +

[PATCH] D92053: [clangd] Addusing tweak: find insertion point after definition

adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:201 + for (const auto : TLDs) { +if (MustInsertAfterLoc.isValid() && +SM.isBeforeInTranslationUnit(TLD->getBeginLoc(), MustInsertAfterLoc)) kadircet

[clang] 3823665 - [docs] Try to make this bullet list in ThinLTO.rst actually be a bullet list

Author: Hans Wennborg Date: 2020-11-24T14:08:42+01:00 New Revision: 38236656ab4a4bea5e582f709929003abfa1ddcd URL: https://github.com/llvm/llvm-project/commit/38236656ab4a4bea5e582f709929003abfa1ddcd DIFF: https://github.com/llvm/llvm-project/commit/38236656ab4a4bea5e582f709929003abfa1ddcd.diff

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl marked 2 inline comments as done. yaxunl added a comment. ping Comment at: clang/lib/Sema/SemaExpr.cpp:357 + if (LangOpts.CUDAIsDevice) { +auto *FD = dyn_cast_or_null(CurContext); tra wrote: > This could use a comment about why we only check

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

azabaznov added a comment. Hi! Great to see the interest in OpenCL C 3.0! I'm being working already at a proper feature macros definition to unify both clang and header OpenCL C 3.0 related changes, here is the change:  https://reviews.llvm.org/D89869. So as this patch will be merged then the

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

spatel added a comment. In D88712#2412874 , @venkataramanan.kumar.llvm wrote: > In D88712#2412366 , @MaskRay wrote: > >> In D88712#2411841 , >> @venkataramanan.kumar.llvm

[PATCH] D91310: [AMDGPU] Add -mcode-object-version=n

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91310/new/ https://reviews.llvm.org/D91310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

svenvh added a comment. In D92004#2413603 , @Anastasia wrote: > @svenvh I imagine the testing functionality between the two headers will be > identical? Mostly, assuming you intend to test in the conventional way of feeding a .cl file to Clang.

[clang-tools-extra] 9e83d0b - [clangd] Mention when CXXThis is implicit in exposed AST.

Author: Sam McCall Date: 2020-11-24T16:57:56+01:00 New Revision: 9e83d0bcdfe86fd13f2817c9f40c5ca0b08f1443 URL: https://github.com/llvm/llvm-project/commit/9e83d0bcdfe86fd13f2817c9f40c5ca0b08f1443 DIFF: https://github.com/llvm/llvm-project/commit/9e83d0bcdfe86fd13f2817c9f40c5ca0b08f1443.diff

[PATCH] D91868: [clangd] Mention when CXXThis is implicit in exposed AST.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG9e83d0bcdfe8: [clangd] Mention when CXXThis is implicit in exposed AST. (authored by sammccall). Changed prior to commit:

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/ToolChain.h:334 /// LLD's supported flags, error output, etc. - std::string GetLinkerPath(bool *LinkerIsLLD = nullptr) const; +

[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0ca81a6c35: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC] (authored by sdmitriev). Repository: rG LLVM Github

[clang] 1b0ca81 - [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

Author: Sergey Dmitriev Date: 2020-11-24T08:07:31-08:00 New Revision: 1b0ca81a6c358d2d52d4f84b7f42e620ead1ed26 URL: https://github.com/llvm/llvm-project/commit/1b0ca81a6c358d2d52d4f84b7f42e620ead1ed26 DIFF:

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson added a comment. Adding another reviewer - @wmi can you take a look? This is a straightforward compile time fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91676/new/ https://reviews.llvm.org/D91676

[PATCH] D91966: [clangd] AddUsing: Used spelled text instead of type name.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:268 + SpelledTokens->back()); +

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay added a comment. In D91760#2413294 , @psmith wrote: > Radio silence so far; I think no news is good news applies in this case. I'm > happy to say no objections. Thanks. I'll commit then. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

Quuxplusone added a comment. Probably irrelevant comment from the C++ world: If I needed this concept in C++, I'd probably piggyback on the existing semantic analysis of `std::move`: I'd design a `class OnceCallable` with an `operator() &&` that both called and nulled-out its object parameter,

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

njames93 added a comment. In D88172#2414249 , @sammccall wrote: > @kbobyrev ping... I think we do actually want to land this, for use with > `.clang-tidy` files after D91029 Yes, I was looking at copying the config

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 307405. ZarkoCA added a comment. Went back to old option selection logic as updated version did not emit an error when selecting 'maltivec` but not `mabi=vec-extabi`. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. New MachO LLD doesn't implement the old -macos_version_min (etc) flags, but it understands the modern platform_version flag. So make the clang driver pass that when using new MachO LLD. Also,

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

Bigcheese accepted this revision. Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added a comment. OK this looks really great, thanks so much for persisting with this. Comments are mostly simple nits/simplifications, with the exception of `Order` which is a... slightly trickier simplification, but seems worth doing. Tomorrow I'll adapt our internal clang-tidy

[clang] 9a8386d - clang: Pass -platform-version to new MachO LLD

Author: Nico Weber Date: 2020-11-24T11:16:03-05:00 New Revision: 9a8386dba889b038c23bfc89dd0ff3cf55bbf86a URL: https://github.com/llvm/llvm-project/commit/9a8386dba889b038c23bfc89dd0ff3cf55bbf86a DIFF: https://github.com/llvm/llvm-project/commit/9a8386dba889b038c23bfc89dd0ff3cf55bbf86a.diff

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a8386dba889: clang: Pass -platform-version to new MachO LLD (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D92037?vs=307365=307369#toc

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[clang] 44174b3 - [NFC][tests] Replace non-portable grep with FileCheck

Author: Hubert Tong Date: 2020-11-24T12:15:07-05:00 New Revision: 44174b3d518ed70482ff5df2879523a4e26f92cc URL: https://github.com/llvm/llvm-project/commit/44174b3d518ed70482ff5df2879523a4e26f92cc DIFF: https://github.com/llvm/llvm-project/commit/44174b3d518ed70482ff5df2879523a4e26f92cc.diff

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall added a comment. @kbobyrev ping... I think we do actually want to land this, for use with `.clang-tidy` files after D91029 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88172/new/

[clang] 6e4c1cf - [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends

Author: Teresa Johnson Date: 2020-11-24T09:35:07-08:00 New Revision: 6e4c1cf2938842ceefc2712f0007843369dd16ca URL: https://github.com/llvm/llvm-project/commit/6e4c1cf2938842ceefc2712f0007843369dd16ca DIFF:

[PATCH] D91812: [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e4c1cf29388: [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends (authored by tejohnson). Repository: rG LLVM Github Monorepo

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

wmi added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return llvm::GlobalObject::VCallVisibilityTranslationUnit; +

[clang-tools-extra] f6e5929 - [clangd] AddUsing: Used spelled text instead of type name.

Author: Adam Czachorowski Date: 2020-11-24T18:59:09+01:00 New Revision: f6e59294b63e1fd0b25720f24111cd17865004be URL: https://github.com/llvm/llvm-project/commit/f6e59294b63e1fd0b25720f24111cd17865004be DIFF:

[PATCH] D91966: [clangd] AddUsing: Used spelled text instead of type name.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6e59294b63e: [clangd] AddUsing: Used spelled text instead of type name. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91966/new/

[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

ldionne updated this revision to Diff 307402. ldionne added a comment. Herald added a project: libc++abi. Herald added a reviewer: libc++abi. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. This looks close to an OpenMP 5.0 implementation. I left comments inlined. We need tests that show how non-selected alternatives *do not* impact the program. As an example, a template instantiation inside of a non-selected alternative is not actually performed. We

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return llvm::GlobalObject::VCallVisibilityTranslationUnit; +

[PATCH] D92012: [clangd][query-driver] Extract target

sammccall added a comment. Thanks, this seems really useful! Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:59 -std::vector parseDriverOutput(llvm::StringRef Output) { +std::pair, std::string> +parseDriverOutput(llvm::StringRef Output) { define

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added a comment. In D92039#2414314 , @Quuxplusone wrote: > Probably irrelevant comment from the C++ world: If I needed this concept in > C++, I'd probably piggyback on the existing semantic analysis of `std::move`: > I'd design a `class

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

thakis marked an inline comment as done. thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92037/new/ https://reviews.llvm.org/D92037 ___ cfe-commits mailing list

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko created this revision. vsavchenko added reviewers: aaron.ballman, dexonsmith, rsmith, Bigcheese, rjmccall, NoQ, doug.gregor, ravikandhadai, dcoughlin. Herald added subscribers: cfe-commits, Charusso, mgorny. Herald added a project: clang. vsavchenko requested review of this revision.

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

spatel added a comment. In D88712#2413877 , @venkataramanan.kumar.llvm wrote: > In D88712#2413688 , @spatel wrote: > >> In D88712#2412874 , >> @venkataramanan.kumar.llvm

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698

[PATCH] D92041: Add hover info for `this` expr

kadircet added a comment. Thanks, this sounds like a sensible idea. I got a few suggestions for the implementation though. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

Quuxplusone added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:1223 +// We consider '(void)parameter' as a manual no-op escape. +// It should be used to explicitly tell the analysis that this paramater +// is intentionally not called on this

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson updated this revision to Diff 307404. tejohnson added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91676/new/ https://reviews.llvm.org/D91676 Files: clang/lib/CodeGen/CGVTables.cpp

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob marked 5 inline comments as done. dougpuob added a comment. Hi @aaron.ballman and @Eugene.Zelenko, thank you for your suggestions. I will improve them and upload my diff later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/

[PATCH] D92041: Add hover info for `this` expr

xndcn created this revision. xndcn added reviewers: sammccall, kadircet. xndcn added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. xndcn requested review of this revision. How about add hover information for `this` expr?

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1301-1302 + // has no effect on the min visibility computed below by the recursive caller. + if (!Visited.insert(RD).second) +return llvm::GlobalObject::VCallVisibilityTranslationUnit; +

[clang] f96fef8 - [Driver] Default Generic_GCC aarch64 to -fasynchronous-unwind-tables

Author: Fangrui Song Date: 2020-11-24T09:51:32-08:00 New Revision: f96fef89b5eca29f2dc41e97829c20bf742cdcd9 URL: https://github.com/llvm/llvm-project/commit/f96fef89b5eca29f2dc41e97829c20bf742cdcd9 DIFF: https://github.com/llvm/llvm-project/commit/f96fef89b5eca29f2dc41e97829c20bf742cdcd9.diff

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf96fef89b5ec: [Driver] Default Generic_GCC aarch64 to -fasynchronous-unwind-tables (authored by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D43159: Modernize: Use nullptr more.

ldionne updated this revision to Diff 307398. ldionne added a comment. Herald added a project: libc++. Herald added a reviewer: libc++. Rebase onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159

  1   2   >