[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:41 +const char *getLanguage(const clang::LangOptions ) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) +return "C"; sammccall wrote: > Testing for specific C versions

[PATCH] D92704: [clangd] Publish config file errors over LSP

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The pre-merging bot seems to be failed on windows: https://reviews.llvm.org/harbormaster/unit/view/215879/. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:833 +

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM as it seems the missing part. Please also fix the error message if with Power8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf29dbb1541: [PowerPC] [Clang] Enable float128 feature on P9 by default (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko added a comment. This option was created to have an option of removing this break, because without my patch it breaks before ASM colon in long lines. That's why I saved the behavior of BreakBeforeInlineASMColon=true as it was initially. Therefore, I'm asking you is this a

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

This revision was automatically updated to reflect the committed changes. Closed by commit rG275592e71413: Provide default location of sysroot for Baremetal toolchain. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

hokein accepted this revision. hokein added a comment. thanks, I think this patch is good, feel free to land it (and sorry for the delay). As @lebedev.ri commented, would be nice to mention the motivation of the change (`make_shared_for_overwrite`?) in the description. Repository: rG LLVM

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 updated this revision to Diff 309853. psionic12 marked 2 inline comments as done. psionic12 added a comment. Use a vector to collect arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006

[clang-tools-extra] f135726 - [clangd] Temporarily test that uncovered broken behavior on windows

Author: Sam McCall Date: 2020-12-07T12:34:17+01:00 New Revision: f1357264b8e3070bef5bb4ff35ececa4d6c76108 URL: https://github.com/llvm/llvm-project/commit/f1357264b8e3070bef5bb4ff35ececa4d6c76108 DIFF: https://github.com/llvm/llvm-project/commit/f1357264b8e3070bef5bb4ff35ececa4d6c76108.diff

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

njames93 added a comment. Should this be controlled on a case by case basis, maybe control indentation using a regex over the pragma arguments, WDYT? Comment at: clang/docs/ClangFormatStyleOptions.rst:1923-1924 + + When ``false``, pragmas are flushed left or follow

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added a comment. I think my expectation would be that if you are going to have an option `BreakBeforeInlineASMColon` then it should do it for all case long and short, otherwise its not going to be clear. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1cb9cbf5c49: Add ability to load a FixedCompilationDatabase from a buffer. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay updated this revision to Diff 309869. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92753/new/ https://reviews.llvm.org/D92753 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[clang] a1cb9cb - Add ability to load a FixedCompilationDatabase from a buffer.

Author: Sam McCall Date: 2020-12-07T13:07:10+01:00 New Revision: a1cb9cbf5c4939e78a6c3b3677cf8e3dbdf51932 URL: https://github.com/llvm/llvm-project/commit/a1cb9cbf5c4939e78a6c3b3677cf8e3dbdf51932 DIFF: https://github.com/llvm/llvm-project/commit/a1cb9cbf5c4939e78a6c3b3677cf8e3dbdf51932.diff

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein updated this revision to Diff 309817. hokein marked 2 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://reviews.llvm.org/D92157 Files:

[clang] 275592e - Provide default location of sysroot for Baremetal toolchain.

Author: Hafiz Abid Qadeer Date: 2020-12-07T09:19:52Z New Revision: 275592e714130345a481a5cb889c89b73a98614f URL: https://github.com/llvm/llvm-project/commit/275592e714130345a481a5cb889c89b73a98614f DIFF: https://github.com/llvm/llvm-project/commit/275592e714130345a481a5cb889c89b73a98614f.diff

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:44 +return; + const char *LanguageLabel = Lang.CPlusPlus ? "C++" : Lang.ObjC ? "ObjC" : "C"; static constexpr trace::Metric SelectionUsedRecovery( sammccall wrote: > This

[clang] 6bf29db - [PowerPC] [Clang] Enable float128 feature on P9 by default

Author: Qiu Chaofan Date: 2020-12-07T18:31:00+08:00 New Revision: 6bf29dbb1541aff717e52b5c5fb12b84f5b38f21 URL: https://github.com/llvm/llvm-project/commit/6bf29dbb1541aff717e52b5c5fb12b84f5b38f21 DIFF: https://github.com/llvm/llvm-project/commit/6bf29dbb1541aff717e52b5c5fb12b84f5b38f21.diff

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

This revision was automatically updated to reflect the committed changes. Closed by commit rG980618145bf0: [clang-tidy][docs] Update check options with boolean values instead of non… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:44 +return; + const char *LanguageLabel = Lang.CPlusPlus ? "C++" : Lang.ObjC ? "ObjC" : "C"; static

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:81 +D->addAttr(AnnotateAttr::Create(S.Context, "example", , +Attr.getNumArgs(), Attr.getRange())); return AttributeApplied; psionic12

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 marked 4 inline comments as done. psionic12 added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:81 +D->addAttr(AnnotateAttr::Create(S.Context, "example", , +Attr.getNumArgs(), Attr.getRange())); return

[PATCH] D92704: [clangd] Publish config file errors over LSP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGfed9af29c2b5: [clangd] Publish config file errors over LSP (authored by sammccall). Changed prior to

[clang-tools-extra] fed9af2 - [clangd] Publish config file errors over LSP

Author: Sam McCall Date: 2020-12-07T11:07:32+01:00 New Revision: fed9af29c2b5f289744254390c7372e8871e45e5 URL: https://github.com/llvm/llvm-project/commit/fed9af29c2b5f289744254390c7372e8871e45e5 DIFF: https://github.com/llvm/llvm-project/commit/fed9af29c2b5f289744254390c7372e8871e45e5.diff

[PATCH] D49890: Clang-Tidy Export Problem

jwillemsen added a comment. I am trying to use run-clang-tidy on ACE/TAO (see https://github.com/DOCGroup/ACE_TAO) but it doesn't work, also the error reported here. When only running modernize-use-override I get a yaml file of 110167 lines but that can't also be applied using

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

njames93 added a comment. How does this handle Dependent base classes (including CRTP). Can tests be added to demonstrate that behaviour if its supported. Comment at: clang-tools-extra/clangd/XRefs.cpp:1200 + } +if (const auto *D = dyn_cast(ND)) { +

[PATCH] D92704: [clangd] Publish config file errors over LSP

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/29315/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92704/new/ https://reviews.llvm.org/D92704 ___

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, JakeMerdichAMD, krasimir. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. A quick search

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. This needs rebasing against main. Can't be applied cleanly in its current state. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:398-404 + std::string OptionVal = StrMap.lookup(OptionKey); + llvm::transform(OptionVal,

Re: [PATCH] D92704: [clangd] Publish config file errors over LSP

Yep, thanks. This uncovered an existing error, so rather than reverting the whole thing I've disabled the assert on windows while I fix it. f1357264b8e3070bef5bb4ff35ececa4d6c76108 On Mon, Dec 7, 2020 at 12:22 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a

[clang-tools-extra] 2542ef8 - [clangd] Fix windows slashes in project config diagnostics

Author: Sam McCall Date: 2020-12-07T12:54:38+01:00 New Revision: 2542ef83ed7c5a10f8b394ec8e7764558dc71d32 URL: https://github.com/llvm/llvm-project/commit/2542ef83ed7c5a10f8b394ec8e7764558dc71d32 DIFF: https://github.com/llvm/llvm-project/commit/2542ef83ed7c5a10f8b394ec8e7764558dc71d32.diff

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

qiucf added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90213/new/ https://reviews.llvm.org/D90213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:724 + ReturnStmtVisitor V; + for (const auto *RootStmt : ExtZone.RootStmts) { +V.TraverseStmt(const_cast(RootStmt)); nit: s/auto/Stmt

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1df0677e6ac6: [clangd] Add language metrics for recovery AST usage. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/

[clang-tools-extra] 1df0677 - [clangd] Add language metrics for recovery AST usage.

Author: Haojian Wu Date: 2020-12-07T10:52:05+01:00 New Revision: 1df0677e6ac65e18da54b1dd5c391bf17a4c2737 URL: https://github.com/llvm/llvm-project/commit/1df0677e6ac65e18da54b1dd5c391bf17a4c2737 DIFF: https://github.com/llvm/llvm-project/commit/1df0677e6ac65e18da54b1dd5c391bf17a4c2737.diff

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:712 + // - .clang_format and .clang-tidy + // - compile_commands.json } Any reason for re-specifying compile_commands.json here? Comment at:

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

liaolucy added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92751: Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby created this revision. Herald added a subscriber: kristof.beyls. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC on WoA64 includes isCXX14Aggregate in its definition. This is de-facto specification on that

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay marked 7 inline comments as done. MyDeveloperDay added a comment. > Should this be controlled on a case by case basis, maybe control indentation > using a regex over the pragma arguments, WDYT? Most uses of pragmas seem to be at the 0'th level of scrope `#pragma once` etc Most

[clang-tools-extra] 9806181 - [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

Author: Nathan James Date: 2020-12-07T12:13:57Z New Revision: 980618145bf00a8e212cf3c6db46fb0a83081d69 URL: https://github.com/llvm/llvm-project/commit/980618145bf00a8e212cf3c6db46fb0a83081d69 DIFF: https://github.com/llvm/llvm-project/commit/980618145bf00a8e212cf3c6db46fb0a83081d69.diff LOG:

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 309873. nullptr.cpp added a comment. Herald added a subscriber: lxfind. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files:

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4626 CES_AllowExceptionVariables = 4, -CES_FormerDefault = (CES_AllowParameters), -CES_Default = (CES_AllowParameters | CES_AllowDifferentTypes), -CES_AsIfByStdMove =

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

flx added a comment. Could someone take a first pass at this change? It would be great progress on this as this is the last currently known case that generates false positives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91893/new/

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay added a comment. In D92753#2436852 , @curdeius wrote: > You've added `messUp` parameter to `verifyFormat`, because, IIUC, pragmas > wouldn't be at the desired scope level indentation otherwise. messUp was pull the line below onto the

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay updated this revision to Diff 309896. MyDeveloperDay added a comment. Add for(...) test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92753/new/ https://reviews.llvm.org/D92753 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

joechrisellis created this revision. joechrisellis added reviewers: peterwaller-arm, DavidTruby. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92755 Repository: rG

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added inline comments. Comment at: clang/lib/Format/Format.cpp:893 /*BeforeLambdaBody=*/false, + /*BeforeStructInitialization=*/false, /*BeforeWhile=*/false,

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. I tend to agree with @krasimir I don't see where you really use Maximum to mean anything, the nested configuration seems perhaps unnecessarily confusing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

curdeius added a comment. This LGTM in general. I just have a doubt. You've added `messUp` parameter to `verifyFormat`, because, IIUC, pragmas wouldn't be at the desired scope level indentation otherwise. Shouldn't clang-format find out what the correct indentation level for pragmas should be

[PATCH] D92742: [clang] Add support for attribute 'swift_async'

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor nit. Comment at: clang/include/clang/Basic/AttrDocs.td:4367 +``actuallyAsync:callThisAsync`` wouldn't have been imported as ``async`` if not +for ``swift_async`` because it doesn't

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

aqjune added a comment. Hello all, What is the status of this patch? Do we need someone who look into the lit change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4626 CES_AllowExceptionVariables = 4, -CES_FormerDefault = (CES_AllowParameters), -CES_Default = (CES_AllowParameters | CES_AllowDifferentTypes), -CES_AsIfByStdMove =

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc planned changes to this revision. mibintc added a comment. I'm going to make further changes to this patch, it's not working as desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.org/D92721

[clang-tools-extra] 8625f5b - [clang-tidy][NFC] Streamline CheckOptions error reporting.

Author: Nathan James Date: 2020-12-07T14:05:49Z New Revision: 8625f5bc799f4ee1c85126bd007166fe6dff14a1 URL: https://github.com/llvm/llvm-project/commit/8625f5bc799f4ee1c85126bd007166fe6dff14a1 DIFF: https://github.com/llvm/llvm-project/commit/8625f5bc799f4ee1c85126bd007166fe6dff14a1.diff LOG:

[PATCH] D51650: Implement target_clones multiversioning

erichkeane added a comment. In D51650#2418749 , @lebedev.ri wrote: > In D51650#1305509 , @erichkeane > wrote: > >> Fix @rsmith s comments, rebase on the big CPUDispatch refactor. > > Ping. What's the status here?

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

joechrisellis created this revision. joechrisellis added reviewers: peterwaller-arm, DavidTruby. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:893 /*BeforeLambdaBody=*/false, + /*BeforeStructInitialization=*/false, /*BeforeWhile=*/false,

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

kpn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2992 // floating point environment in the loop. +//XXX true? llvm::BasicBlock *startBB = Builder.GetInsertBlock(); mibintc wrote: > did you mean to leave this here? (blame shows

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 309934. ckennelly added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

This revision was automatically updated to reflect the committed changes. Closed by commit rGb49b8f096c03: [PowerPC][Clang] Remove QPX support (authored by jsji). Changed prior to commit: https://reviews.llvm.org/D92329?vs=308405=309908#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

curdeius added a comment. Maybe it would be judicious to add a FIXME to `test::messUp` for the pragmas? Or fix it in this patch? Comment at: clang/unittests/Format/FormatTest.cpp:17641-17651 + verifyFormat("void foo() {\n" + " #pragma omp simd\n" +

[clang] e6bc4a7 - [libTooling] Add `describe` combinator for formatting AST nodes for diagnostics.

Author: Yitzhak Mandelbaum Date: 2020-12-07T16:08:05Z New Revision: e6bc4a71e3450d7230205683f63d6e22fbf9bf05 URL: https://github.com/llvm/llvm-project/commit/e6bc4a71e3450d7230205683f63d6e22fbf9bf05 DIFF: https://github.com/llvm/llvm-project/commit/e6bc4a71e3450d7230205683f63d6e22fbf9bf05.diff

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

kpn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3006 + CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, OpInfo.FPFeatures); SourceLocation Loc = E->getExprLoc(); mibintc wrote: > kpn wrote: > > mibintc wrote: > > > What's the rule

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc updated this revision to Diff 309932. mibintc added a comment. ready for review, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.org/D92721 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added inline comments. Comment at: openmp/libomptarget/src/omptarget.cpp:233 MapperComponents -.Components[target_data_function == targetDataEnd ? I : E - I - 1]; +.Components[target_data_function == targetDataEnd ? E - I - 1 : I];

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 309936. ckennelly edited the summary of this revision. ckennelly added a comment. updating commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files:

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2436639 , @hokein wrote: > thanks, I think this patch is good, feel free to land it (and sorry for the > delay). > > As @lebedev.ri commented, would be nice to mention the motivation of the > change

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong

[clang] b49b8f0 - [PowerPC][Clang] Remove QPX support

Author: Jinsong Ji Date: 2020-12-07T10:15:39-05:00 New Revision: b49b8f096c0382da17d3203dfaa3f54d04a47d27 URL: https://github.com/llvm/llvm-project/commit/b49b8f096c0382da17d3203dfaa3f54d04a47d27 DIFF: https://github.com/llvm/llvm-project/commit/b49b8f096c0382da17d3203dfaa3f54d04a47d27.diff

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

steakhal added a comment. LGTM besides my inline comment. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1737 .ArgConstraint( ArgumentCondition(4, WithinRange, Range(0, IntMax; `mmap` should

[PATCH] D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92727/new/ https://reviews.llvm.org/D92727

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay updated this revision to Diff 309926. MyDeveloperDay added a comment. Allow the tests to messUp() the code, turns out its some sort of interaction ONLY with the BeforeHash case (last test) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92753/new/

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc added a comment. In D92721#2436917 , @mibintc wrote: > I'm going to make further changes to this patch, it's not working as desired. that was a false alarm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1b734c6 - [Parse] Delete unused declarations

Author: Fangrui Song Date: 2020-12-07T08:46:17-08:00 New Revision: 1b734c662bd92c5ae065667fee7e11cff1e1f190 URL: https://github.com/llvm/llvm-project/commit/1b734c662bd92c5ae065667fee7e11cff1e1f190 DIFF: https://github.com/llvm/llvm-project/commit/1b734c662bd92c5ae065667fee7e11cff1e1f190.diff

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3006 + CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, OpInfo.FPFeatures); SourceLocation Loc = E->getExprLoc(); kpn wrote: > mibintc wrote: > > What's the rule to follow about

[PATCH] D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6bc4a71e345: [libTooling] Add `describe` combinator for formatting AST nodes for diagnostics. (authored by ymandel). Changed prior to commit:

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembersgetFieldOffset(layoutStartOffset) for current calleds is expected topoint to the first trivial field or the one which follows non-trivial

morehouse added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1742 + Context.toCharUnitsFromBits(Layout.getFieldOffset(layoutStartOffset) + + Context.getCharWidth() - 1); + llvm::ConstantInt *OffsetSizePtr =

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. Thanks for the additional info @kpn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92596/new/ https://reviews.llvm.org/D92596

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

martong updated this revision to Diff 309931. martong marked an inline comment as done. martong added a comment. - Use -1 for mmap too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92764/new/ https://reviews.llvm.org/D92764 Files:

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1737 .ArgConstraint( ArgumentCondition(4, WithinRange, Range(0, IntMax; steakhal wrote: > `mmap` should have the same

[PATCH] D68410: [AttrDocs] document always_inline

aaron.ballman added a comment. LGTM aside from the minor wording nit from @ojeda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410 ___ cfe-commits mailing list

[PATCH] D91270: [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct

luismarques updated this revision to Diff 309981. luismarques added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91270/new/ https://reviews.llvm.org/D91270 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

nickdesaulniers added a comment. In D90271#2436080 , @SolarAquarion wrote: > You missed a change https://bugs.llvm.org/show_bug.cgi?id=48413 Discussed off thread; Arch Linux has patches on top of their distribution of LLVM. Repository: rG LLVM

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309983. dgoldman added a comment. Swap to isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

njames93 updated this revision to Diff 309985. njames93 added a comment. Refactored based on changes to parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/ https://reviews.llvm.org/D92756 Files:

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309987. dgoldman added a comment. Add protocol test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D92782: [CodeGen][AMDGPU] Fix ICE for static initializer IR generation

bader created this revision. bader added reviewers: rjmccall, yaxunl. Herald added subscribers: ebevhan, t-tye, tpr, dstuttard, kzhuravl. bader requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] dc361d5 - [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

Author: Nathan James Date: 2020-12-07T20:20:08Z New Revision: dc361d5c2a2dd34839ff4cd48844cf1bf9a87c62 URL: https://github.com/llvm/llvm-project/commit/dc361d5c2a2dd34839ff4cd48844cf1bf9a87c62 DIFF: https://github.com/llvm/llvm-project/commit/dc361d5c2a2dd34839ff4cd48844cf1bf9a87c62.diff LOG:

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc361d5c2a2d: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D92480?vs=309730=309989#toc Repository: rG LLVM

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I messed around with qualified name changes - lots of things internally rely upon the qualified names so that will be best for a separate change. I could potentially handle `DocumentSymbol` fixes in here though - LMK if you think it makes sense to move some of this

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

luismarques updated this revision to Diff 309991. luismarques added a comment. Add float Complex case, for regression test completeness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91278/new/ https://reviews.llvm.org/D91278 Files:

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

Quuxplusone added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:172 + + // TODO. This can produce wrong detection in case of a later class + // declaration. Example: I don't know the purpose of this code, but this //seems// like a super

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

cchen added a comment. Just tried this patch and found that below test abort inside `generateInfoCapture`. #include #define LEN 100 int buf[LEN]; int main() { int i; int *p = buf; for (i = 0; i < LEN; i++) { p[i] = 0; } #pragma omp target

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2437676 , @cchen wrote: > Just tried this patch and found that below test abort inside > `generateInfoCapture`. > > #include > #define LEN 100 > int buf[LEN]; > > int main() > { > int i; > int

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. @njames93: Any additional comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

aaron.ballman added a comment. Is there a way to add test coverage for this to demonstrate that we handle what YAML considers a Boolean and that we don't allow oddities? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/

[clang] 3ce78f5 - [analyzer] Ignore annotations if func is inlined.

Author: Yu Shan Date: 2020-12-07T11:28:11-08:00 New Revision: 3ce78f54edcfc881377a9e567715caf2f0be2abc URL: https://github.com/llvm/llvm-project/commit/3ce78f54edcfc881377a9e567715caf2f0be2abc DIFF: https://github.com/llvm/llvm-project/commit/3ce78f54edcfc881377a9e567715caf2f0be2abc.diff LOG:

  1   2   3   >