[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

aaron.ballman added a comment. In D84924#2465745 , @njames93 wrote: > In D84924#2446075 , @aaron.ballman > wrote: > >> In D84924#2184132 , @njames93 wrote: >> >>> This is

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon updated this revision to Diff 313038. RKSimon added a comment. I've added the static_assert constexpr methods - this requires C++14 so I've left the existing constexpr wrapper tests with C++11 coverage as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87587: [clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2463 +**MaxUnwrappedLinesForShortNamespace** (``unsigned``) + The maximal number of unwrapped lines that a short namespace spans. MyDeveloperDay wrote: > This is quite a

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

aaron.ballman added a comment. In D92006#2466114 , @DavidSpickett wrote: > The last update didn't update the expected errors. I have done so in > 9a93f95fce91fb4616cee0f307b564b253789282 >

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. In D93586#2464841 , @spatel wrote: > Besides changing IRBuilder and shufflevector's definition, I think we'll also > need updates in the vectorizers, InstSimplify, and other places in > InstCombine that use UndefValue for

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. In D93586#2466284 , @aqjune wrote: > The transition will be swiftly done (if there's no other issue hopefully) by > the next weekend. Oops, I meant this weekend hopefully. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

JVApen added a comment. In D93490#2463068 , @MyDeveloperDay wrote: > Maybe @JVApen can help as they logged > https://bugs.llvm.org/show_bug.cgi?id=48539 > > I'm not a Qt developer so I can't really comment beyond fixing what was in > the bug rpeort We

[PATCH] D93637: [libTooling] Add support for smart pointers to releveant Transformer `Stencil`s.

ymandel created this revision. ymandel added reviewers: tdl-g, sbenza. ymandel requested review of this revision. Herald added a project: clang. Stencils `maybeDeref` and `maybeAddressOf` are designed to handle nodes that may be pointers. Currently, they only handle native pointers. This patch

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov updated this revision to Diff 313114. ASDenysPetrov added a comment. @steakhal I've precisely inspected your reports and find the bug. I've fixed it. I also verified all the rest and find some other vulnerabilities and fixed them as well. Thank you for your testing, and I would

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added a comment. Beyond the enabling of the compilation with `` on Windows, I really have the concern on the current approach supporting `` compilation in the device compilation. The device compilation should not relies on the host STL implementation. That results in inconsistent

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. Disclaimer: I request changes because of the next sentence, other than that I have no objection but also cannot review this. All `cuda_wrapper` headers say something about

[clang] 9a93f95 - [clang] Fix expected errors in plugin attribute example

Author: David Spickett Date: 2020-12-21T16:47:23Z New Revision: 9a93f95fce91fb4616cee0f307b564b253789282 URL: https://github.com/llvm/llvm-project/commit/9a93f95fce91fb4616cee0f307b564b253789282 DIFF: https://github.com/llvm/llvm-project/commit/9a93f95fce91fb4616cee0f307b564b253789282.diff

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

DavidSpickett added a comment. The last update didn't update the expected errors. I have done so in 9a93f95fce91fb4616cee0f307b564b253789282 and it's now passing. (I think it missed the bots since they don't build examples)

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Hi, community. I kindly ask you to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman updated this revision to Diff 313108. FarisRehman edited the summary of this revision. FarisRehman added a comment. Address review comments Address comments with the following changes: - Add a dedicated method to adding preprocessing options in Flang.cpp - Change preprocessorOpts to

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman marked an inline comment as done. FarisRehman added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:228 + // Note: GCC drops anything following an end-of-line character. + llvm::StringRef::size_type End =

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao created this revision. hliao added reviewers: tra, yaxunl. hliao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - MSVC has different `` implementation which calls into functions declared in ``. Instead of through builtins or inline

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman marked 2 inline comments as done. FarisRehman added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:205 +/// Collect the macro definitions provided by the given preprocessor +/// options into the parser options. +void collectMacroDefinitions(

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 313112. abhina.sreeskantharajan added a comment. Thanks for your patience, I've addressed some more comments. Here is the summary of the changes in this patch: - add translation for UCN strings, update testcase - fix helptext for

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 11 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Driver/Options.td:3583-3584 +def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">, + HelpText<"Set the execution for

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3356 EnumArgument<"State", "LoopHintState", - ["enable", "disable", "numeric", "assume_safety", "full"], - ["Enable", "Disable",

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 313116. hliao added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files: clang/lib/Headers/__clang_hip_runtime_wrapper.h

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1322-1323 + TranslationState = translationState; + if (Kind == tok::wide_string_literal) +TranslationState = TranslateToSystemCharset; + else if (isUTFLiteral(Kind))

<    1   2