[PATCH] D93938: Fixed AfterEnum handling

atirit created this revision. atirit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93938 Files: clang/lib/Format/UnwrappedLineParser.cpp Index:

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Addressed comments by @njames93. Including adding warning message for unsupported options in config file, refining code in getFileStyleFromOptions(), and for consistent reason to use llvm::yaml::parseBool() function instead of checking On/Off string. Repository:

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 314093. segoon retitled this revision from "Add a check for blocking types and functions." to "[clang-tidy] Add a check for blocking types and functions.". segoon added a comment. Herald added a reviewer: jfb. Herald added subscribers: xazax.hun, mgorny.

[PATCH] D92792: [clang] - Also look for devtoolset-10

stephan.dollberg added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92792/new/ https://reviews.llvm.org/D92792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp:35 +/* C++ std */ +"std::mutex", // +"std::timed_mutex", // njames93 wrote: > Is it wise to fully qualify these? >

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-blocking.rst:7 +Checks for some synchronous functions and types that volunteerly preempt system +thread. Volunteer preemption of a system thread in asynchronous code

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/concurrency-async-blocking.cpp:450 + +// TODO: remove CHECKT-MESSAGES njames93 wrote: > Whats this for? WIP tests for not yet ready atomic::is_always_lock_free check CHANGES

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 314141. Xiangling_L marked 6 inline comments as done. Xiangling_L added a comment. - used memcpy to burn AlignPackInfo into uint32_t and vice versa; - named XL on AIX stack effect and related options after "xl" instead of "aix" - adjusted natural align

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. Looks good, only a few typos and minor comments. Comment at: clang/docs/OpenCLSupport.rst:69

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg updated this revision to Diff 314129. thezbyg marked 3 inline comments as done. thezbyg added a comment. Added missing full stop. Executed clang/doc/tools/dump_style.py to update ClangFormatStyleOptions.rst. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 314136. segoon marked 19 inline comments as done. segoon added a comment. review fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 Files: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added a comment. In D90159#2466599 , @MaskRay wrote: > Should this have some tests? Even if guarded by `REQUIRES:` if some feature > is needed. Test coverage for the DDG functionality has been added under LIT and unittests. I've opened

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp:1 +//===--- AsyncBlockingCheck.cpp - clang-tidy ===// +// Please make length same as end of comment.

[PATCH] D93817: Update transformations to use poison for new insertelement's placeholder value

aqjune updated this revision to Diff 314123. aqjune added a comment. Herald added subscribers: cfe-commits, pengfei, aheejin, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Rebase, update transformations with shufflevector involved too Repository: rG LLVM Github Monorepo

[PATCH] D93817: Update transformations to use poison for insertelement/shufflevector's placeholder value

aqjune added a comment. I'll share the result after checking the validity of this patch using alive2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93817/new/ https://reviews.llvm.org/D93817 ___

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

MaskRay added a comment. D93944 fixed an llvm-c-test issue. Note, adding new enum members usually requires `check-all` (at least `check-llvm`, but Clang may use these enum as well). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93940: Add a check for blocking types and functions.

segoon created this revision. Herald added a subscriber: jfb. segoon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The preemptive functions/types can be separated into the following categories: - explicit sleep(3)-like functions -

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov, mantognini, yaxunl. Herald added subscribers: ebevhan, jfb. Anastasia requested review of this revision. Update UsersManual and OpenCLSupport pages to reflect recent functionality i.e. SPIR-V generation, C++ for

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

njames93 added a comment. Few stylistic nits, Also Theres lots of cases where single stmt if statements have braces, typically we elide those braces. Is it worth flagging methods with Thread safety analysis attributes. These are only used

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks added inline comments. Comment at: llvm/tools/opt/NewPMDriver.cpp:136-138 +static cl::opt PseudoProbeForProfiling( +"new-pm-pseudo-probe-for-profiling", cl::init(false), cl::Hidden, +cl::desc("Emit pseudo probes to enable PGO profile generation."));

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

MyDeveloperDay updated this revision to Diff 314089. MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93839/new/ https://reviews.llvm.org/D93839 Files:

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93839/new/ https://reviews.llvm.org/D93839 ___ cfe-commits mailing

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

njames93 added inline comments. Comment at: clang/lib/Format/Format.cpp:2962 +llvm::sys::path::filename(FileName)); +if (auto OuterStyle = getStyle(DefaultFormatStyle, FileForLanguage, +

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

LuoYuanke updated this revision to Diff 314087. LuoYuanke added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92837/new/ https://reviews.llvm.org/D92837 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[clang] 420d046 - clang-format, address warnings

Author: Juneyoung Lee Date: 2020-12-30T23:05:07+09:00 New Revision: 420d046d6bdd8d950dad389a97e31f841052efb2 URL: https://github.com/llvm/llvm-project/commit/420d046d6bdd8d950dad389a97e31f841052efb2 DIFF: https://github.com/llvm/llvm-project/commit/420d046d6bdd8d950dad389a97e31f841052efb2.diff

[PATCH] D93923: Use unary CreateShuffleVector if possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b29610228c8: Use unary CreateShuffleVector if possible (authored by aqjune). Changed prior to commit:

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314111. Anastasia added a comment. Fixed some build warning/formating issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index:

[PATCH] D93938: Fixed AfterEnum handling

HazardyKnusperkeks added a comment. You should add tests to prove what you are doing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 ___ cfe-commits mailing

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1351 + /// If true, the empty line is inserted before access modifiers + /// \code The full stop will go here then regenerate. CHANGES SINCE LAST ACTION

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Please add and fix tests. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2485 - if (!Style.AllowShortEnumsOnASingleLine) -addUnwrappedLine();

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 314103. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. NFC, rebased, added test with multiplication of `short`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new/

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

lebedev.ri added inline comments. Comment at: clang/test/Sema/implicit-widening-of-pointer-offset-in-array-subscript-expression.c:24 +void t1(char *base, int a, int b) { + // FIXME: test `[a * b]base` pattern? +} dblaikie wrote: > lebedev.ri wrote: > >

[PATCH] D93923: Use unary CreateShuffleVector if possible

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. See inline comments to avoid bot failures - otherwise, LGTM. Thanks for the cleanup! Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3193

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:235 +Converter->convert(std::string(1, ByteChar), ResultCharConv); +memcpy((void *), ResultCharConv.data(),

[PATCH] D93940: Add a check for blocking types and functions.

segoon updated this revision to Diff 314092. segoon added a comment. up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 Files: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp Index:

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 314115. abhina.sreeskantharajan added a comment. This patch replaces the memcpy in CharLiteralParser with an assignment. I've added an assertion for cases where the character size increases after translation. Repository: rG LLVM Github

[PATCH] D93923: Use unary CreateShuffleVector if possible

aqjune added a comment. Thanks! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93923/new/ https://reviews.llvm.org/D93923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93923: Use unary CreateShuffleVector if possible

aqjune updated this revision to Diff 314108. aqjune added a comment. - clang-format, address warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93923/new/ https://reviews.llvm.org/D93923 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

uabelho added inline comments. Comment at: llvm/include/llvm/IR/Type.h:68 X86_MMXTyID, ///< MMX vectors (64 bits, X86 specific) +X86_AMXTyID, ///< AMX vectors (8192 bits, X86 specific) TokenTyID, ///< Tokens This addition causes a

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

pengfei added inline comments. Comment at: llvm/include/llvm/IR/Type.h:68 X86_MMXTyID, ///< MMX vectors (64 bits, X86 specific) +X86_AMXTyID, ///< AMX vectors (8192 bits, X86 specific) TokenTyID, ///< Tokens uabelho wrote: > This addition

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

uabelho added inline comments. Comment at: llvm/include/llvm/IR/Type.h:68 X86_MMXTyID, ///< MMX vectors (64 bits, X86 specific) +X86_AMXTyID, ///< AMX vectors (8192 bits, X86 specific) TokenTyID, ///< Tokens pengfei wrote: > uabelho wrote:

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1593-1597 + ConversionState State = TranslationState; + if (Kind == tok::wide_string_literal) +State = TranslateToSystemCharset; + else if (isUTFLiteral(Kind)) +State =

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

LuoYuanke updated this revision to Diff 314157. LuoYuanke added a comment. Add avx512f in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92837/new/ https://reviews.llvm.org/D92837 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. The `FormatTestJS.EnumDeclarations` test in fact isn't broken, but `FormatTest.ShortEnums` and `FormatTestCSharp.CSharpKeyWordEscaping` are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

dblaikie added inline comments. Comment at: clang/test/Sema/implicit-widening-of-pointer-offset-in-array-subscript-expression.c:24 +void t1(char *base, int a, int b) { + // FIXME: test `[a * b]base` pattern? +} lebedev.ri wrote: > dblaikie wrote: > >

[clang] 6f1503d - [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

Author: Atmn Patel Date: 2020-12-30T21:43:01-05:00 New Revision: 6f1503d59854b331f1f970d39839619b0a26bbc7 URL: https://github.com/llvm/llvm-project/commit/6f1503d59854b331f1f970d39839619b0a26bbc7 DIFF: https://github.com/llvm/llvm-project/commit/6f1503d59854b331f1f970d39839619b0a26bbc7.diff

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f1503d59854: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops (authored by atmnpatel, committed by adpatel6). Changed prior to commit:

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); qiucf wrote: >

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 314149. atirit added a comment. Fixed the FormatTest.ShortEnums unit test and fixed compatibility with `FormatTestCSharp.CSharpKeyWordEscaping` and `FormatTestJS.EnumDeclarations` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93873: [clangd] Cache preambles of closed files

qchateau updated this revision to Diff 314152. qchateau added a comment. - Fix keep preamble command line option - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93873/new/ https://reviews.llvm.org/D93873 Files:

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added inline comments. Comment at: llvm/tools/opt/NewPMDriver.cpp:136-138 +static cl::opt PseudoProbeForProfiling( +"new-pm-pseudo-probe-for-profiling", cl::init(false), cl::Hidden, +cl::desc("Emit pseudo probes to enable PGO profile generation."));

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. From what I can tell the unit tests are broken. Take `FormatTest.ShortEnums` for example. It passes the following code: enum { A, B, C } ShortEnum1, ShortEnum2; And expects no changes to be made. However, format unit tests use the `BreakBeforeBraces:

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncBlockingCheck.cpp:319 +assert(L); +const auto *EV = L->ensureEvaluatedStmt(); +if (EV && EV->Evaluated.getKind() == APValue::ValueKind::None) { Please

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added a comment. Thank @pengfei and @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 314162. atirit added a comment. Changed commit username and email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D93952: [Clang][Misc] Fix fragile test

atmnpatel created this revision. atmnpatel added a reviewer: MaskRay. Herald added a subscriber: pengfei. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-with-thin-lto-ubuntu, clang-with-lto-ubuntu,

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92837/new/ https://reviews.llvm.org/D92837

[PATCH] D93952: [Clang][Misc] Fix fragile test

MaskRay added a comment. You can check the CMake configurations of these bots. https://github.com/llvm/llvm-zorg `buildbot/osuosl/master/config/builders.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93952/new/ https://reviews.llvm.org/D93952

[clang] 809a1e0 - [CodeGenModule] Set dso_local for Mach-O GlobalValue

Author: Fangrui Song Date: 2020-12-30T20:52:01-08:00 New Revision: 809a1e0ffd7af40ee27270ff8ba2ffc927330e71 URL: https://github.com/llvm/llvm-project/commit/809a1e0ffd7af40ee27270ff8ba2ffc927330e71 DIFF: https://github.com/llvm/llvm-project/commit/809a1e0ffd7af40ee27270ff8ba2ffc927330e71.diff

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

LuoYuanke updated this revision to Diff 314170. LuoYuanke added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92837/new/ https://reviews.llvm.org/D92837 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[clang] 08665b1 - Support tilezero intrinsic and c interface for AMX.

Author: Luo, Yuanke Date: 2020-12-31T13:24:57+08:00 New Revision: 08665b180568c82a1b2b8bd38a1e5769a862c2a9 URL: https://github.com/llvm/llvm-project/commit/08665b180568c82a1b2b8bd38a1e5769a862c2a9 DIFF: https://github.com/llvm/llvm-project/commit/08665b180568c82a1b2b8bd38a1e5769a862c2a9.diff

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08665b180568: Support tilezero intrinsic and c interface for AMX. (authored by LuoYuanke). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

xbolva00 added a comment. Do you plan to implement gcc’s option in Clang as followup? -ffinite-loops / -fno-finite-loops Assume that a loop with an exit will eventually take the exit and not loop indefinitely. This allows the compiler to remove loops that otherwise have no side-effects, not

[PATCH] D93952: [Clang][Misc] Fix fragile test

MaskRay added a comment. Do you know why some bots don't emit `entry:`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93952/new/ https://reviews.llvm.org/D93952 ___ cfe-commits mailing list

[PATCH] D93952: [Clang][Misc] Fix fragile test

atmnpatel added a comment. I can't say that I know with any certainty, I'm too inexperienced. This failure was missed by me locally, the pre-merge bot, and by most of the buildbots other than the ones I mentioned above. I have no idea under what configuration of CMake options will clang not