[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD added a comment. @kromanenkov I guess it won't work then. Thanks for the idea! Now that I think about it removing duplicates is probably not the right thing to do. The problem arises because the call PTMD->getCXXBaseList() should ideally return the list of previous casts, but instead

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader commandeered this revision. bader edited reviewers, added: Fznamznon; removed: bader. bader added inline comments. Comment at: clang/test/CodeGenSYCL/device-functions.cpp:2 +// RUN: %clang_cc1 -triple spir64 -fsycl-is-device -S -emit-llvm %s -o - | FileCheck %s +

[PATCH] D95634: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM as long as the nits are addressed on the commit. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8611 Subtarget.hasPrefixInstrs()) { -if

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. ctetreau requested review of this revision. Herald

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. One more ping. Please, pay attention to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

JDevlieghere added a comment. > However, the project claims to require 3.6 or greater, and 3.6 features are > being used. Can you link to where it says that? I'm not opposed to making 3.6 minimally required version, but at least for LLDB we don't have that requirement and we have

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

yln added a comment. In D95635#2528851 , @JDevlieghere wrote: >> However, the project claims to require 3.6 or greater, and 3.6 features are >> being used. > > Can you link to where it says that? I'm not opposed to making 3.6 the > minimally required

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319936. thakis edited the summary of this revision. thakis added a comment. Seems like there are no strong opinions, so now with actual code. I went with "VC/Tools/MSVC/XXX" and "Windows Kits/10" since that seems like the obvious thing. CHANGES SINCE LAST

[PATCH] D93095: Introduce -Wreserved-identifier

rsmith added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2421-2428 +// Perform a lookup at TUScope. If it succeeds, we're at global scope and a +// single '_' is enough to be reserved. +LookupResult IdentifierLookup(*this, II, SourceLocation(), +

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2527437 , @vitalybuka wrote: > Our Android build bot is broken after this patch > http://lab.llvm.org:8011/#/builders/77/builds/3234 Shouldn't that build be using lld? In D95166#2526839

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 319951. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

rsmith added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2063-2065 + if (const auto *MD = dyn_cast(D)) { +if (const CXXRecordDecl *RD = MD->getParent()) { + if (RD->isLambda()) { This is incorrectly skipping the bodies of

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan updated this revision to Diff 319873. abhina.sreeskantharajan retitled this revision from "[SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued" to "[test] Use host platform specific error message substitution in lit tests ".

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

jansvoboda11 added a comment. In D95514#2526064 , @dexonsmith wrote: > Well, the compiler developers are the users, since `-cc1` isn't for > end-users. I acknowledge it's a tradeoff. IMO, without actually seeing it in > practice, it seems a bit nicer to

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

Bigcheese added a comment. In D95514#2528324 , @jansvoboda11 wrote: > In D95514#2526064 , @dexonsmith > wrote: > >> Well, the compiler developers are the users, since `-cc1` isn't for >> end-users. I acknowledge

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in the Itanium C++ ABI. unsigned ManglingNumber : 31; +/// The device side mangling number. +

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

yln added a comment. LGTM, thanks! (I got bitten by this.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___ cfe-commits mailing list

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

dexonsmith added a comment. In D95514#2528407 , @Bigcheese wrote: > In D95514#2528324 , @jansvoboda11 > wrote: > >> I've looked through all option classes in `CompilerInvocation`, and >> `AnalyzerOptions::Config`

[clang] 3c79734 - [ASTMatchers] Add invocation matcher

Author: Stephen Kelly Date: 2021-01-28T20:47:09Z New Revision: 3c79734f29284d6b54f1867a03428a3d9fd338d9 URL: https://github.com/llvm/llvm-project/commit/3c79734f29284d6b54f1867a03428a3d9fd338d9 DIFF: https://github.com/llvm/llvm-project/commit/3c79734f29284d6b54f1867a03428a3d9fd338d9.diff

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c79734f2928: [ASTMatchers] Add invocation matcher (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94865?vs=319672=319943#toc Repository: rG LLVM Github Monorepo

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. @aaron.ballman Please review this again as I've merged some more needed changes into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880

[PATCH] D95629: [clang][analyzer] Own string keys in AnalyzerOptions::ConfigTable

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. > This patch replaces StringMap<...> with std::map in > AnalyzerOptions::ConfigTable. It seems to be the only non-owning reference to > command line arguments in the whole

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso updated this revision to Diff 319940. Charusso marked 6 inline comments as done. Charusso added a comment. - Fix everything. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/ https://reviews.llvm.org/D69726 Files: clang/docs/analyzer/developer-docs/DebugChecks.rst

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso added a reviewer: vsavchenko. Charusso added a comment. Hey, I am back. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize.h:41-44 +/// Set the dynamic size of a CXXNewExpr \p NE by its region \p MR. +ProgramStateRef

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:75 + for (llvm::sys::fs::directory_iterator DirIt(Directory, EC), DirEnd; + DirIt != DirEnd && !EC; DirIt.increment(EC)) { +if (!llvm::sys::fs::is_directory(DirIt->path()))

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2421-2428 +// Perform a lookup at TUScope. If it succeeds, we're at global scope and a +// single '_' is enough to be reserved. +

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Herald added a reviewer: jansvoboda11. Hi, John, sorry for the delay. I'm still in the middle of something. will context-switch a little bit latter. thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. This is getting close! A few more comments inline. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:584-589 +static bool Equal(const ArgStringList ,

[PATCH] D95634: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Conanap marked 4 inline comments as done. Closed by commit rG2e470e03b49f: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases (authored by

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319938. thakis added a comment. add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D95534 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a subscriber: lattner. vabridgers added a comment. Gentle and polite ping :) Could someone have a look at this? @rsmith , or @lattner ? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:822 + static bool ParseAnalyzerArgs(AnalyzerOptions , ArgList ,

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f0df3cddb3e: [ASTMatchers] Avoid pathological traversal over nested lambdas (authored by stephenkelly). Changed prior to commit:

[clang] 6f0df3c - [ASTMatchers] Avoid pathological traversal over nested lambdas

Author: Stephen Kelly Date: 2021-01-28T20:45:45Z New Revision: 6f0df3cddb3e3f38df1baa7aa4d743a74bb46688 URL: https://github.com/llvm/llvm-project/commit/6f0df3cddb3e3f38df1baa7aa4d743a74bb46688 DIFF: https://github.com/llvm/llvm-project/commit/6f0df3cddb3e3f38df1baa7aa4d743a74bb46688.diff

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:75 + for (llvm::sys::fs::directory_iterator DirIt(Directory, EC), DirEnd; + DirIt != DirEnd && !EC; DirIt.increment(EC)) { +if (!llvm::sys::fs::is_directory(DirIt->path()))

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319949. thakis marked an inline comment as done. thakis added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D95534 Files: clang/include/clang/Driver/Options.td

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3093 + +static bool ParsePreprocessorArgs(PreprocessorOptions , ArgList ,

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 319929. serge-sans-paille added a comment. Back to the previous version, as suggested by @rsmith . I made a few updates to `NamedDecl::isReserved` which get me close to the expected result, without too much overhead. CHANGES SINCE LAST ACTION

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau added a comment. In D95635#2528851 , @JDevlieghere wrote: >> However, the project claims to require 3.6 or greater, and 3.6 features are >> being used. > > Can you link to where it says that? I'm not opposed to making 3.6 the > minimally

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! there are also some comments on `ASTWorker::PublishMu` talking about semantic highlights publishing. Comment at:

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319784. kentsommer added a comment. Turn SortIncludes into an enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

sammccall marked an inline comment as done. sammccall added a comment. In D95576#2527407 , @kadircet wrote: > oh also in addition to `This should not land until the new protocol has > feature parity, see D77702.`, it might be better to hold on to it a

[PATCH] D95166: Disable rosegment for old Android versions.

vitalybuka added a comment. Out Android build bot is broken after this patch http://lab.llvm.org:8011/#/builders/77/builds/3234 Run Build Command(s):/usr/bin/ninja cmTC_578f8 && [1/2] Building C object CMakeFiles/cmTC_578f8.dir/testCCompiler.c.o [2/2] Linking C executable cmTC_578f8

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

awarzynski added a comment. @arnamoy10 , could you also add tests that show that `-J/-module-dir` is taken into account when deciding where to put module files? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95448/new/

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319780. tbaeder added a comment. Answered one of my questions by adding a new function directly to `Sema`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/include/clang/Sema/Sema.h

[PATCH] D95571: [clangd] Remove some obsolete options that are now always on

sammccall updated this revision to Diff 319776. sammccall added a comment. group retired flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95571/new/ https://reviews.llvm.org/D95571 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

jhenderson added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:74 +// RUN: not clang-offload-bundler -type=i -targets=host-%itanium_abi_triple,openmp-powerpc64le-ibm-linux-gnu,openmp-x86_64-pc-linux-gnu -inputs=%t.i,%t.tgt1,%t.tgt2.notexist

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

kadircet added a comment. oh also in addition to `This should not land until the new protocol has feature parity, see D77702.`, it might be better to hold on to it a little bit longer, since it is touching lots of pieces and might make cherry-picking some fixes that touch the same files harder

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

sammccall updated this revision to Diff 319779. sammccall added a comment. Remove some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95576/new/ https://reviews.llvm.org/D95576 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[clang] 01b9e61 - [Clang][Codegen] Truncate initializers of union bitfield members

Author: Tomas Matheson Date: 2021-01-28T09:19:19Z New Revision: 01b9e613c28b833327ab4de93d0638a5c8d3514f URL: https://github.com/llvm/llvm-project/commit/01b9e613c28b833327ab4de93d0638a5c8d3514f DIFF: https://github.com/llvm/llvm-project/commit/01b9e613c28b833327ab4de93d0638a5c8d3514f.diff

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01b9e613c28b: [Clang][Codegen] Truncate initializers of union bitfield members (authored by tmatheson). Repository: rG LLVM Github Monorepo

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:399 +IO.enumCase(Value, "false", FormatStyle::SI_Never); +IO.enumCase(Value, "", FormatStyle::SI_CaseInsensitive); +IO.enumCase(Value, "true", FormatStyle::SI_CaseInsensitive);

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. kentsommer wrote: > HazardyKnusperkeks wrote:

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

curdeius added a comment. I see little value in not checking FallbackStyle (even if it's not used). However, I do see value in an early warning (error) on an incorrect style that can pop up later if not caught soon enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

curdeius added a comment. I return the question, are there any workflows that would benefit from the proposed behaviour? Apart from those that have already a faulty config? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95538/new/

[clang] 2393b03 - Revert "[clang][cli] Use variadic macros for parsing/generating"

Author: Jan Svoboda Date: 2021-01-28T10:48:43+01:00 New Revision: 2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7 URL: https://github.com/llvm/llvm-project/commit/2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7 DIFF: https://github.com/llvm/llvm-project/commit/2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7.diff

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

kadircet added a comment. > I see little value in not checking FallbackStyle (even if it's not used). note that this patch doesn't disable fallbackstyle checking, it is still checked, but not eagerly. > However, I do see value in an early warning (error) on an incorrect style > that can pop

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 319797. yubing added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix some bugs in lowerTileDPBSSD, lowerTileStore, lowerTileLoad Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer added a comment. In D93585#2526774 , @ilinpv wrote: > Clang driver tests for outline atomics were added. Thanks! Is there a way we can test `-rtlib=libgcc`? Comment at: clang/lib/Driver/ToolChains/Linux.cpp:855 +

[PATCH] D95562: [ASTMatchers] Fix traversal below range-for elements

steveire updated this revision to Diff 319809. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95562/new/ https://reviews.llvm.org/D95562 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp

[clang] 01b9e61 - [Clang][Codegen] Truncate initializers of union bitfield members

Author: Tomas Matheson Date: 2021-01-28T09:19:19Z New Revision: 01b9e613c28b833327ab4de93d0638a5c8d3514f URL: https://github.com/llvm/llvm-project/commit/01b9e613c28b833327ab4de93d0638a5c8d3514f DIFF: https://github.com/llvm/llvm-project/commit/01b9e613c28b833327ab4de93d0638a5c8d3514f.diff

[PATCH] D95532: [clang][cli] Use variadic macros for parsing/generating

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG374862d71c1a: [clang][cli] Use variadic macros for parsing/generating (authored by jansvoboda11). Changed prior to commit:

[clang] 374862d - [clang][cli] Use variadic macros for parsing/generating

Author: Jan Svoboda Date: 2021-01-28T10:35:02+01:00 New Revision: 374862d71c1a2f63557a27f1555b37ff0f75117e URL: https://github.com/llvm/llvm-project/commit/374862d71c1a2f63557a27f1555b37ff0f75117e DIFF: https://github.com/llvm/llvm-project/commit/374862d71c1a2f63557a27f1555b37ff0f75117e.diff

[clang] 374862d - [clang][cli] Use variadic macros for parsing/generating

Author: Jan Svoboda Date: 2021-01-28T10:35:02+01:00 New Revision: 374862d71c1a2f63557a27f1555b37ff0f75117e URL: https://github.com/llvm/llvm-project/commit/374862d71c1a2f63557a27f1555b37ff0f75117e DIFF: https://github.com/llvm/llvm-project/commit/374862d71c1a2f63557a27f1555b37ff0f75117e.diff

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319806. kentsommer added a comment. Fixed release notes typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst

[clang] 526c42e - [OpenCL] Hide sampler-less read_image builtins before CL1.2

Author: Sven van Haastregt Date: 2021-01-28T11:14:19Z New Revision: 526c42e76c12d9cfe83dfa5957fe1715ab8d1faf URL: https://github.com/llvm/llvm-project/commit/526c42e76c12d9cfe83dfa5957fe1715ab8d1faf DIFF: https://github.com/llvm/llvm-project/commit/526c42e76c12d9cfe83dfa5957fe1715ab8d1faf.diff

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319819. kentsommer added a comment. NFC Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319786. kentsommer added a comment. Remove improper enum mapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:399 +IO.enumCase(Value, "false", FormatStyle::SI_Never); +IO.enumCase(Value, "", FormatStyle::SI_CaseInsensitive); +IO.enumCase(Value, "true", FormatStyle::SI_CaseInsensitive);

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added a comment. Concerning the `--sort-includes` command-line flag. I'd rather keep it as is and, if need be, work on accepting an **optional** string argument. Please update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added a comment. I was thinking of https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst#clang-format. Look at the history to see how it was written before. Also, you may change the revision title if you want (it will become the commit message). Repository: rG

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319804. kentsommer added a comment. Added release notes, updated commit message and summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files:

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319820. tbaeder added a comment. Fixed the Lambda oddity as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer marked an inline comment as done. kentsommer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion.

[clang] 2393b03 - Revert "[clang][cli] Use variadic macros for parsing/generating"

Author: Jan Svoboda Date: 2021-01-28T10:48:43+01:00 New Revision: 2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7 URL: https://github.com/llvm/llvm-project/commit/2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7 DIFF: https://github.com/llvm/llvm-project/commit/2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7.diff

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. In D95017#2527512 , @curdeius wrote: > Concerning the `--sort-includes` command-line flag. I'd rather keep it as is > and, if need be, work on accepting an **optional** string argument. > Please update release notes.

[PATCH] D95557: [WebAssembly] Prototype i8x16 to i32x4 widening instructions

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. This does not yet have i64x2 version of the instructions in https://github.com/WebAssembly/simd/pull/395 yet, right? Comment at:

[PATCH] D94827: [SimplifyCFG] If provided, preserve Dominator Tree

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cfa963463d0: [SimplifyCFG] If provided, preserve Dominator Tree (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 526c42e - [OpenCL] Hide sampler-less read_image builtins before CL1.2

Author: Sven van Haastregt Date: 2021-01-28T11:14:19Z New Revision: 526c42e76c12d9cfe83dfa5957fe1715ab8d1faf URL: https://github.com/llvm/llvm-project/commit/526c42e76c12d9cfe83dfa5957fe1715ab8d1faf DIFF: https://github.com/llvm/llvm-project/commit/526c42e76c12d9cfe83dfa5957fe1715ab8d1faf.diff

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

steveire added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2065 if (const CXXRecordDecl *RD = MD->getParent()) { - if (RD->isLambda()) { + if (RD->isLambda() && RD->getLambdaCallOperator() == MD) { VisitBody = VisitBody &&

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd73564c51003: [DebugInfo][CodeView] Use lambda_n as the display name for lambdas. (authored by akhuang). Changed prior to commit:

[clang] d73564c - [DebugInfo][CodeView] Use as the display name for lambdas.

Author: Amy Huang Date: 2021-01-28T16:30:38-08:00 New Revision: d73564c510036b2d4f5858effdcd23fe54fc1063 URL: https://github.com/llvm/llvm-project/commit/d73564c510036b2d4f5858effdcd23fe54fc1063 DIFF: https://github.com/llvm/llvm-project/commit/d73564c510036b2d4f5858effdcd23fe54fc1063.diff

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

steveire updated this revision to Diff 319992. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95644/new/ https://reviews.llvm.org/D95644 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Herald added a subscriber: shchenz. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer.cpp:6 +//of

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Apologies again for the long delay. A diff with full context would still be appreciated. Please read https://llvm.org/docs/Phabricator.html for instructions. The

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2529412 , @dmajor wrote: > It does feel kind of awkward to me that _this_ is the patch that ends up > breaking the builds, versus something at the cmake level that says "you are > explicitly unsupported". If you're

[PATCH] D95655: Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, pbarrio. Herald added subscribers: hiraditya, kristof.beyls. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This adds SM3

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5f5deee9ee9: Reland [DebugInfo][CodeView] Use lambda_n as the display name for lambdas (authored by akhuang). Repository: rG LLVM Github

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

NoQ added inline comments. Comment at: clang/include/clang/Basic/Features.def:256 EXTENSION(pragma_clang_attribute_external_declaration, true) +EXTENSION(statement_attributes_with_gnu_syntax, true) EXTENSION(gnu_asm, LangOpts.GNUAsm) People seem to

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

rsmith added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2065 if (const CXXRecordDecl *RD = MD->getParent()) { - if (RD->isLambda()) { + if (RD->isLambda() && RD->getLambdaCallOperator() == MD) { VisitBody = VisitBody &&

Re: [clang] 9b21d4b - Revert "[DebugInfo][CodeView] Use as the display name for lambdas."

On Thu, 28 Jan 2021 at 16:41, Amy Huang via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Amy Huang > Date: 2021-01-28T16:41:26-08:00 > New Revision: 9b21d4b9434d2d4796b0d60d64f6ded9bac95441 > > URL: >

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

gulfem marked 9 inline comments as done. gulfem added inline comments. Comment at: clang/test/CodeGen/switch-to-lookup-table.c:2 +// Check switch to lookup optimization in fPIC and fno-PIC mode +// RUN: %clang_cc1 %s -triple=aarch64-unknown-fuchsia -O2 -fno-PIC -S -emit-llvm -o

[PATCH] D95658: Make the profile-filter.c test compatible with 32-bit systems

phosek created this revision. phosek added reviewers: mgorny, davidxl, vsk. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses PR48930. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95658 Files:

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

mtrofin created this revision. Herald added subscribers: kerbowa, mstorsjo, nhaehnle, jvesely. mtrofin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95660 Files:

[clang] 078f30e - [clang-format] Add option to control the spaces in a line comment

Author: Björn Schäpers Date: 2021-01-29T07:00:08+01:00 New Revision: 078f30e04d1fcb5a05d8e340f3178f3478075541 URL: https://github.com/llvm/llvm-project/commit/078f30e04d1fcb5a05d8e340f3178f3478075541 DIFF:

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

This revision was automatically updated to reflect the committed changes. Closed by commit rG078f30e04d1f: [clang-format] Add option to control the spaces in a line comment (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D92257?vs=317294=320046#toc

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

steveire created this revision. steveire added a reviewer: rsmith. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95644 Files:

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

steveire added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2063-2065 + if (const auto *MD = dyn_cast(D)) { +if (const CXXRecordDecl *RD = MD->getParent()) { + if (RD->isLambda()) { rsmith wrote: > This is incorrectly

[PATCH] D95166: Disable rosegment for old Android versions.

glandium added a comment. Firefox CI is using a custom clang, but uses a NDK otherwise (an old-ish one, clearly older than r22 which is the first that defaults to lld). And we do pass -fuse-ld=bfd at the moment for $reasons. If clang _really_ wants to assume lld as the linker for android, then

[PATCH] D95017: [clang-format] Add case aware include sorting.

kentsommer updated this revision to Diff 320007. kentsommer added a comment. NFC rebase to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst

  1   2   >