[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing created this revision. Herald added subscribers: pengfei, hiraditya. yubing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96110 Files:

[PATCH] D96102: [clangd] Fix missing __syncthreads.

jdoerfert added a comment. I doubt this compiles: https://godbolt.org/z/c51v5d even with adjusted type, this fails because `__syncthreads` is a builtin (right now): https://godbolt.org/z/jP7e6h (and `__nvvm_bar_sync` requires an argument). CHANGES SINCE LAST ACTION

[PATCH] D96105: [CUDA][HIP] Pass -fgpu-rdc to host clang -cc1

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently -fgpu-rdc is not passed to host clang -cc1. This causes issue because -fgpu-rdc affects shadow variable linkage in host compilation. https://reviews.llvm.org/D96105 Files:

[PATCH] D96102: [clangd] Fix missing __syncthreads.

oToToT updated this revision to Diff 321652. oToToT added a comment. I guess __nvvm_bar_sync is the right instruction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96102/new/ https://reviews.llvm.org/D96102 Files: clang/lib/Headers/__clang_cuda_device_functions.h Index:

[PATCH] D96102: [clangd] Fix missing __syncthreads.

oToToT created this revision. oToToT added reviewers: tra, chandlerc, jdoerfert, gtbercea, emankov, JDevlieghere. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

sbc100 added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.cpp:260 + if (!HasAtomics) { +Opts.POSIXThreads = false; +Opts.setThreadModel(LangOptions::ThreadModelKind::Single); POSIXThreads already defaults to false I think. It gets

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95da64da23ac: [WebAssembly] Use single-threaded mode when -matomics isnt enabled. (authored by sunfish). Repository: rG LLVM Github Monorepo

[clang] 95da64d - [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

Author: Dan Gohman Date: 2021-02-04T18:16:48-08:00 New Revision: 95da64da23ac3a5855a8934a738b0fa10aa1323c URL: https://github.com/llvm/llvm-project/commit/95da64da23ac3a5855a8934a738b0fa10aa1323c DIFF: https://github.com/llvm/llvm-project/commit/95da64da23ac3a5855a8934a738b0fa10aa1323c.diff

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > rsmith wrote: > > rjmccall wrote: > > >

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

Eugene.Zelenko added a comment. New check must be mentioned in Release Notes. Comment at: clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp:1 +//===--- UselessReturnValueCheck.cpp - clang-tidy +//---===// Please

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96fb49c3ff8e: [AST] Update LVal before evaluating lambda decl fields. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 96fb49c - [AST] Update LVal before evaluating lambda decl fields.

Author: Zequan Wu Date: 2021-02-04T17:01:09-08:00 New Revision: 96fb49c3ff8e08680127ddd4ec45a0e6c199243b URL: https://github.com/llvm/llvm-project/commit/96fb49c3ff8e08680127ddd4ec45a0e6c199243b DIFF: https://github.com/llvm/llvm-project/commit/96fb49c3ff8e08680127ddd4ec45a0e6c199243b.diff

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033 + +// FIXME: Diagnostics here should point to the end of the initializer +// list, not the start. +if (!HandleLValueMember(Info, E, Subobject, Field, )) rsmith

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu updated this revision to Diff 321617. zequanwu marked an inline comment as done. zequanwu added a comment. Remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96092/new/ https://reviews.llvm.org/D96092 Files:

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033 + +// FIXME: Diagnostics here should point to the end of the initializer +// list, not the start. +if

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma marked 5 inline comments as done. tiagoma added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17996 +format(ForSourceLong, Style)); +} + njames93 wrote: > MyDeveloperDay wrote: > > MyDeveloperDay wrote: > > >

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96091/new/ https://reviews.llvm.org/D96091

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu created this revision. zequanwu added reviewers: rsmith, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR48582 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96092 Files:

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma updated this revision to Diff 321611. tiagoma added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. Herald added a subscriber: nullptr.cpp. HTML sample looks fine! But there is the same problem as in D92639 . IE doesn't draw arrows. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:166 +

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

sunfish created this revision. sunfish added a reviewer: tlively. Herald added subscribers: ecnelises, jfb, jgravelle-google, sbc100, dschuff. sunfish requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. When the -matomics feature is

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rsmith wrote: > rjmccall wrote: > > Quuxplusone wrote:

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, steakhal, xazax.hun. ASDenysPetrov added a project: clang. Herald added subscribers: nullptr.cpp, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

ASDenysPetrov updated this revision to Diff 321585. ASDenysPetrov added a comment. Updated. Moved comments as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel updated this revision to Diff 321580. LukasHanel edited projects, added clang-tools-extra; removed clang. LukasHanel added a comment. Herald added a project: clang. Add the real changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel created this revision. Herald added subscribers: nullptr.cpp, xazax.hun, mgorny. LukasHanel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96082 Files:

[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGe355110040d1: [CUDA][HIP] Fix checking dependent initalizer (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] e355110 - [CUDA][HIP] Fix checking dependent initalizer

Author: Yaxun (Sam) Liu Date: 2021-02-04T18:04:54-05:00 New Revision: e355110040d17dcbf0fcfcba386c4d96fe6fe7ec URL: https://github.com/llvm/llvm-project/commit/e355110040d17dcbf0fcfcba386c4d96fe6fe7ec DIFF:

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > Quuxplusone wrote: > > aaron.ballman

[PATCH] D96080: format

LukasHanel created this revision. Herald added a subscriber: nullptr.cpp. LukasHanel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96080 Files:

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tstellar added a comment. The goal here is for distributions to be able to build libc++ one way and then have it work with clang without requiring that users add additional linker flags besides -static or -stdlib=libc++. Is there a combination of CMake arguments we can use when building

[PATCH] D95745: Support unwinding from inline assembly

rnk added a comment. Basically, this seems totally reasonable and I think this is the right direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. It is difficult for clang driver to make the decision because libc++ has multiple C++ ABI implementations as @mstorsjo said. Persoanlly I use: `clang++ -stdlib=libc++

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

joerg added a comment. The NetBSD part is most definitely not acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96070/new/ https://reviews.llvm.org/D96070 ___ cfe-commits mailing list

[PATCH] D96027: [clangd] Trace queue state for each TUScheduler action.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1054 Requests.push_back({std::move(Task), std::string(Name), steady_clock::now(), -std::move(Ctx), Update, Invalidation, -

[clang] 0211877 - [HIP] Add __managed__ macro to header

Author: Yaxun (Sam) Liu Date: 2021-02-04T16:22:42-05:00 New Revision: 0211877a0754c06e3aeaba690a1c860c6edf6288 URL: https://github.com/llvm/llvm-project/commit/0211877a0754c06e3aeaba690a1c860c6edf6288 DIFF:

[PATCH] D96058: [CodeComplete] Guess type for designated initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb4ab3358cd4: [CodeComplete] Guess type for designated initializers (authored by sammccall). Changed prior to commit:

[clang] eb4ab33 - [CodeComplete] Guess type for designated initializers

Author: Sam McCall Date: 2021-02-04T22:14:49+01:00 New Revision: eb4ab3358cd4dc834a761191b5531b38114f7b13 URL: https://github.com/llvm/llvm-project/commit/eb4ab3358cd4dc834a761191b5531b38114f7b13 DIFF: https://github.com/llvm/llvm-project/commit/eb4ab3358cd4dc834a761191b5531b38114f7b13.diff

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre added inline comments. Comment at: clang/test/CodeGen/aarch64-strictfp-builtins.c:1 +// RUN: %clang_cc1 %s -emit-llvm -ffp-exception-behavior=maytrap -fexperimental-strict-floating-point -o - -triple arm64-none-linux-gnu | FileCheck %s + AArch64 is not

[PATCH] D96058: [CodeComplete] Guess type for designated initializers

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Parse/ParseInit.cpp:163 +DesignatorCompletionInfo DesignatorCompletion) { + if (!getPreprocessor().isCodeCompletionEnabled()) +DesignatorCompletion.PreferredBaseType =

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre updated this revision to Diff 321554. thopre added a comment. Add AArch64 testcase and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/ https://reviews.llvm.org/D95948 Files: clang/lib/CodeGen/CGBuiltin.cpp

[clang] fcb90cb - Fix miscomputation of dependence for elaborated types that are

Author: Richard Smith Date: 2021-02-04T13:14:15-08:00 New Revision: fcb90cbd3b4ae3934bdd05d538647d37ce899962 URL: https://github.com/llvm/llvm-project/commit/fcb90cbd3b4ae3934bdd05d538647d37ce899962 DIFF: https://github.com/llvm/llvm-project/commit/fcb90cbd3b4ae3934bdd05d538647d37ce899962.diff

[clang] cd2f65b - Correct some confused diagnostic terminology

Author: Aaron Ballman Date: 2021-02-04T15:52:07-05:00 New Revision: cd2f65b71a4239dcb5a4bcfe25da32a9ac9620cb URL: https://github.com/llvm/llvm-project/commit/cd2f65b71a4239dcb5a4bcfe25da32a9ac9620cb DIFF: https://github.com/llvm/llvm-project/commit/cd2f65b71a4239dcb5a4bcfe25da32a9ac9620cb.diff

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

mstorsjo added a comment. I'm not convinced that this is the right way of handling it. Libc++ can be used on top of a number of C++ ABI libraries (both libsupc++/libstdc++ and libcxxabi), and how they are linked varies with how a toolchain is assembled. In particular, if libcxx is built with

[PATCH] D96009: [clangd] Improve name conflict detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a2b7c91563: [clangd] Improve name conflict detection (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] e8a2b7c - [clangd] Improve name conflict detection

Author: Kirill Bobyrev Date: 2021-02-04T21:37:41+01:00 New Revision: e8a2b7c91563169b68d2a878c65deecc85ced466 URL: https://github.com/llvm/llvm-project/commit/e8a2b7c91563169b68d2a878c65deecc85ced466 DIFF:

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev updated this revision to Diff 321545. kbobyrev added a comment. Can't instantiate DynTypedNode with FunctionProtoTypeLoc, has to be just TypeLoc :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96009/new/ https://reviews.llvm.org/D96009

[PATCH] D96027: [clangd] Trace queue state for each TUScheduler action.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:511 llvm::Optional> LatestPreamble; - std::queue PreambleRequests; /* GUARDED_BY(Mutex) */ + std::deque PreambleRequests; /* GUARDED_BY(Mutex) */ /// Signaled whenever LatestPreamble

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @teemperor, thanks for the hints. Comment at: clang/include/clang/Interpreter/Transaction.h:1 +//===--- Transaction.h - Incremental Compilation and Execution---*- C++ -*-===// +// teemperor wrote: > Could this whole file just be

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 321544. v.g.vassilev marked 6 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files:

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4409 + calls to other ``swiftasynccall`` functions must be in tail position + (in all language modes). In particular: + - For C, this implies that ``return async_f();`` (``async_f`` is another

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tbaeder created this revision. tbaeder added reviewers: rsmith, EricWF, ldionne, tstellar, hfinkel. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, currently the following fails: clang++ -stdlib=libc++ -static ./test.cpp

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; Quuxplusone wrote: > aaron.ballman wrote: > > rjmccall

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

stefanp added a comment. Just nits this time around. Comment at: lld/ELF/Driver.cpp:765 +// instructions in stubs. +static bool getP10StubOpt(opt::InputArgList ) { + Conanap wrote: > For this function here, I realize we can inline all the ifs into a giant >

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

MaskRay added subscribers: pengfei, RKSimon. MaskRay added a comment. @nikic D95849 has already changed `llvm/test/` to default to `--allow-unused-prefixes`. I updated a few directories to be `--allow-unused-prefixes` clean (this uncovered improvement to many

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

kpn added a comment. In D95948#2542884 , @mibintc wrote: > Should we add tests for mlong-double-64, -80, -128? Assuming Ty->getScalarSizeInBits() returns 64, 80, or 128 in those cases, I think it's good enough to just add an AArch64 (or some other

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

MaskRay updated this revision to Diff 321524. MaskRay edited the summary of this revision. MaskRay added a comment. Rebase to re-cycle bots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95849/new/ https://reviews.llvm.org/D95849 Files:

[PATCH] D96058: [CodeComplete] Guess type for designated initializers

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! LG with a small concern around possible effects on member completions for uninstantiated templates. Comment at: clang/lib/Parse/ParseInit.cpp:163 +

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

mibintc added a comment. Should we add tests for mlong-double-64, -80, -128? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/ https://reviews.llvm.org/D95948 ___ cfe-commits mailing list

[PATCH] D96000: Don't emit coverage mapping for excluded functions

vsk added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:27 +// EXCLUDE: @__covrec_{{[0-9A-F]+}}u = linkonce_odr hidden constant <{ i64, i32, i64, i64, [{{.*}} x i8] }> <{ {{.*}} }>, section "__llvm_covfun" +// EXCLUDE-NOT: @__covrec_{{[0-9A-F]+}}u =

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

kpn added a comment. This looks like a definite step forward. Thank you! Can you do an AArch64 test case showing long double? Right now there's no 128-bit test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

fhahn added a comment. In D94367#2542809 , @atmnpatel wrote: > Wait actually, we're gonna need D94366 > anyways, I'll get address @xbolva00's comments by eod. FWIW I think we should sort this one (D94367

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel added a comment. Wait actually, we're gonna need D94366 anyways, I'll get address @xbolva00's comments by eod. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel added a comment. @fhahn Sorry for the hold up, I don't think I'll get to this relatively soon, I'll abandon this one and D94366 to sweep the board. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

fhahn added a comment. Herald added a reviewer: jansvoboda11. @atmnpatel reverse ping. Just curious if you think you'll have time to follow up on this patch soonish? Otherwise I'm probably going to add at least the `-fno-finite-loops` option, because we have users which code breaks due to the

[PATCH] D95691: Implement P2173 for attributes on lambdas

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; aaron.ballman wrote: > rjmccall wrote: > > Uh, I

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > Uh, I think we're a couple

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; Uh, I think we're a couple standard releases past the

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 321501. varungandhi-apple added a comment. 1. Update whitespace and add documentation for swiftasynccall. 2. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/

[PATCH] D96058: [CodeComplete] Guess type for designated initializers

sammccall created this revision. sammccall added a reviewer: kadircet. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables: - completion in { .x.^ } - completion in { .x = { .^ } } - type-based ranking of candidates for

[PATCH] D96056: [clang][cli] Generate and round-trip CodeGen options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements generation of

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. @vsavchenko, after some experimentation, I found out that handling reinterpret_cast will be a real pain. Consider the following: struct Base { int field; }; struct Derived : public Base {}; struct DoubleDerived : public Derived {}; struct

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 321479. cynecx added a comment. clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/lib/Basic/TargetInfo.cpp

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321476. RedDocMD added a comment. Updated to use new function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 Files:

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman marked an inline comment as not done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + <<

[PATCH] D96054: Support unwinding from inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96054 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp

[PATCH] D96049: [Timer] On macOS count number of executed instructions

ahoppen updated this revision to Diff 321467. ahoppen added a comment. Fixed an issue caused by me using an old revions as the commit's base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96049/new/ https://reviews.llvm.org/D96049 Files:

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added a comment. In D95691#2540667 , @rjmccall wrote: > In D95691#2540619 , @rsmith wrote: > >> In D95691#2540450 , @rjmccall wrote: >> >>> The warning is a

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman updated this revision to Diff 321465. aaron.ballman set the repository for this revision to rG LLVM Github Monorepo. aaron.ballman added a comment. Herald added a project: clang. Updating based on review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation

Bigcheese added inline comments. Comment at: clang/docs/InternalsManual.rst:711 +required for parsing or generating the command line argument. + +**Positive Flag** You should create a separate section here for listing the classes. Comment at:

[PATCH] D96053: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96053 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp

[PATCH] D96036: [clang][codegen] Remember string used to create llvm::Regex for optimization remarks

dexonsmith accepted this revision. dexonsmith added a comment. LGTM! I also have a couple of optional suggestions to consider. Comment at: clang/include/clang/Basic/CodeGenOptions.h:286 + +bool isEnabled() const { return Regex != nullptr; } + This could

[PATCH] D96052: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96052 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add enum and typedef argument support to `-fdeclare-opencl-builtins`, which was

[PATCH] D96050: [OpenCL] Do not enforce ASTContext for OCL2Qual

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Do not enforce that the expression to obtain the `QualType` for an OpenCL type

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. A more general comment: You have to `std::move` your `llvm::Error` variables when the result is `llvm::Expected` (otherwise this won't compile). Comment at: clang/include/clang/Interpreter/Transaction.h:1 +//===--- Transaction.h - Incremental

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:169-177 + mutable bool isCXXStdlibTypeCached; + mutable CXXStdlibType cxxStdlibType; + + mutable bool isRuntimeLibTypeCached; + mutable RuntimeLibType runtimeLibType; + + mutable bool

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 321451. poelmanc added a comment. Herald added a subscriber: nullptr.cpp. Change loop end condition in `findLineEnd` and add several `assert` statements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.org/D68682

[PATCH] D96049: [Timer] On macOS count number of executed instructions

ahoppen created this revision. Herald added subscribers: dexonsmith, hiraditya, mgorny. ahoppen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In addition to wall time etc. this should allow us to get less noisy values

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rG1d51c699b9e2: [clang][Arm] Fix handling of -Wa,-march= (authored by DavidSpickett). Repository:

[clang] 1d51c69 - [clang][Arm] Fix handling of -Wa,-march=

Author: David Spickett Date: 2021-02-04T16:36:15Z New Revision: 1d51c699b9e2ebc5bcfdbe85c74cc871426333d4 URL: https://github.com/llvm/llvm-project/commit/1d51c699b9e2ebc5bcfdbe85c74cc871426333d4 DIFF: https://github.com/llvm/llvm-project/commit/1d51c699b9e2ebc5bcfdbe85c74cc871426333d4.diff

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

This revision was automatically updated to reflect the committed changes. Closed by commit rG985a42fdf8ae: [flang][driver] Add support for `-J/-module-dir` (authored by arnamoy10, committed by awarzynski). Changed prior to commit: https://reviews.llvm.org/D95448?vs=320617=321448#toc

[clang] 985a42f - [flang][driver] Add support for `-J/-module-dir`

Author: Arnamoy Bhattacharyya Date: 2021-02-04T16:31:40Z New Revision: 985a42fdf8ae3117442ea129b684569fa6942a71 URL: https://github.com/llvm/llvm-project/commit/985a42fdf8ae3117442ea129b684569fa6942a71 DIFF:

[clang] a83475d - [Hexagon] Add -mv68 option to driver

Author: Krzysztof Parzyszek Date: 2021-02-04T10:29:34-06:00 New Revision: a83475d34b4550ff5bd40430d6537e630eb761f1 URL: https://github.com/llvm/llvm-project/commit/a83475d34b4550ff5bd40430d6537e630eb761f1 DIFF:

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

jdoerfert added a comment. Test still missing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX marked 3 inline comments as done. ArcsinX added a comment. Thank you for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94952/new/ https://reviews.llvm.org/D94952 ___ cfe-commits mailing

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX updated this revision to Diff 321442. ArcsinX added a comment. - Remove default value of `IdxContents` in `FileSymbols` constructor. - Fix index contents for the preamble index (Symbols => Symbols|Relations). - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96044: DebugInfo: Emit "LocalToUnit" flag on local member function decls.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added a subscriber: inglorion. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the definition was so-marked, but the declaration was not. This

[PATCH] D96043: Treat opencl_unroll_hint subject errors as semantic rather than parse errors

aaron.ballman created this revision. aaron.ballman added a reviewer: Anastasia. Herald added subscribers: zzheng, yaxunl. aaron.ballman requested review of this revision. Herald added a project: clang. While working on a downstream project, I noticed some issues with the `opencl_unroll_hint`

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

yaxunl added a comment. LGTM. It also avoid redundant check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >