[PATCH] D98237: Option for empty lines after an access modifier.

Max_S created this revision. Max_S requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current logic for access modifiers in classes ignores the option 'MaxEmptyLinesToKeep=1'. It is therefore impossible to have a coding style that

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks for implementing this and apologies for the review delay (was a tough week for me & my team). The code is very easy to follow now and the only suggestions are stylistic nits.

[PATCH] D98156: [clang/mac] Accept -why_load and make -whyload an alias for it

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm nit in the change description > So -why_load is the spelling preferred by the linker and -whyload and old second "and" -> "an" CHANGES SINCE LAST ACTION

[PATCH] D88668: [CUDA] Add support for 11.1

kiwixz abandoned this revision. kiwixz added a comment. Fixed in a much proper way in D89832 . Thanks @tra! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88668/new/ https://reviews.llvm.org/D88668

[PATCH] D97116: Reduce the number of attributes attached to each function

lebedev.ri added a comment. In D97116#2610652 , @crownyanguan wrote: > In D97116#2596409 , @xbolva00 wrote: > >> In D97116#2596275 , @crownyanguan >> wrote: >> >>>

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

abidh added a comment. In D98113#2609027 , @jrtc27 wrote: > One thing that is currently rather ugly about BareMetal is that it ignores > the AddArch argument. Once you have a sysroot, the architecture suffix is > rather unnecessary, and given

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 328967. njames93 marked 6 inline comments as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/ https://reviews.llvm.org/D96975 Files:

[PATCH] D97930: [OpenCL] Fix builtins that require multiple extensions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:188 + // expected-error@-2{{no matching function for call to 'write_imagef'}} + //

[PATCH] D98164: [clangd] Drop explicit specifier on define out-of-line

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Explicit specifier can only be mentioned on

[PATCH] D97116: Reduce the number of attributes attached to each function

crownyanguan added a comment. In D97116#2596409 , @xbolva00 wrote: > In D97116#2596275 , @crownyanguan > wrote: > >> However, this commit will cause performance regression. > > More details? This commit will

[PATCH] D97935: [clangd] Add config support for ResourceDir

hokein added a comment. The code looks good, but I don't have a very strong opinion of making the resource-dir as a config option. Do we have a motivation (e.g. user request?) now? Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:381 } // namespace

[PATCH] D97688: clang-format: use `pb` as a canonical raw string delimiter for google style

krasimir added a comment. In D97688#2610657 , @sammccall wrote: >> Also fixes a bug where the canonical delimiter was not applied for raw >> strings with empty delimiters detected via well-known enclosing functions >> that expect a text proto. > > Are

[PATCH] D98029: [clangd] Introduce a CommandLineConfigProvider

kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:555 +}; +if (Sync) { + IndexLoadTask(); sammccall wrote: > (This seems a little weird, get passed in a task runner and maybe ignore it. > Seems like the

[clang] 63851a7 - [Matrix] Implement += and -= for MatrixType.

Author: Saurabh Jha Date: 2021-03-08T09:32:11Z New Revision: 63851a701eac1918777535c8e1df2e97c7a01966 URL: https://github.com/llvm/llvm-project/commit/63851a701eac1918777535c8e1df2e97c7a01966 DIFF: https://github.com/llvm/llvm-project/commit/63851a701eac1918777535c8e1df2e97c7a01966.diff LOG:

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

This revision was automatically updated to reflect the committed changes. Closed by commit rG63851a701eac: [Matrix] Implement += and -= for MatrixType. (authored by SaurabhJha, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98039: [OpenCL] Set calling convention for -fdeclare-opencl-builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98039/new/ https://reviews.llvm.org/D98039

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

curdeius added a comment. I hadn't had another look, because the CI still shows the test `AfterEnum` to be failing. Ping me when it's green please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938

[PATCH] D98165: [clangd] Make ProjectAwareIndex optionally sync

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D98029

[PATCH] D97688: clang-format: use `pb` as a canonical raw string delimiter for google style

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. > Also fixes a bug where the canonical delimiter was not applied for raw > strings with empty delimiters detected via well-known enclosing functions > that expect a text proto. Are you

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

probinson added a comment. In D97411#2598625 , @akhuang wrote: > I started looking into some diffs of debug info in libc++ tests, but it's > pretty hard to tell what's different - as far as I can see, there are just a > bunch of `__hash_value_type`s and

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 329008. ggeorgakoudis added a comment. Change regex to avoid failing windows test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files:

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacce401068e7: [PowerPC] Change target data layout for 16-byte stack alignment (authored by saghir). Changed prior to commit:

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 328998. DiggerLin marked an inline comment as done. DiggerLin added a comment. added extra comment back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files:

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

martong accepted this revision. martong added a comment. Thanks for the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96586/new/ https://reviews.llvm.org/D96586 ___ cfe-commits mailing list

[PATCH] D98143: [HIP] Diagnose aggregate args containing half types

yaxunl updated this revision to Diff 328979. yaxunl added a comment. fix test and clang-tidy warnings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98143/new/ https://reviews.llvm.org/D98143 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[clang] 203731d - [clang/mac] Accept -why_load and make -whyload an alias for it

Author: Nico Weber Date: 2021-03-08T09:11:01-05:00 New Revision: 203731d2c82bc1ba0cfaeb8f3d38e696158ca2cd URL: https://github.com/llvm/llvm-project/commit/203731d2c82bc1ba0cfaeb8f3d38e696158ca2cd DIFF: https://github.com/llvm/llvm-project/commit/203731d2c82bc1ba0cfaeb8f3d38e696158ca2cd.diff

[PATCH] D98156: [clang/mac] Accept -why_load and make -whyload an alias for it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG203731d2c82b: [clang/mac] Accept -why_load and make -whyload an alias for it (authored by thakis). Herald added a project: clang. Repository: rG

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/ https://reviews.llvm.org/D97068

[clang] 60d4c73 - Run non-filechecked commands in update_cc_test_checks.py

Author: Giorgis Georgakoudis Date: 2021-03-08T07:18:01-08:00 New Revision: 60d4c73b30a0e324c6ae314722eb036f70f4b03a URL: https://github.com/llvm/llvm-project/commit/60d4c73b30a0e324c6ae314722eb036f70f4b03a DIFF:

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60d4c73b30a0: Run non-filechecked commands in update_cc_test_checks.py (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97930: [OpenCL] Fix builtins that require multiple extensions

Anastasia added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97930/new/ https://reviews.llvm.org/D97930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17453 +} +return T.isPODType(Sema.getASTContext()); + }(); sammccall wrote: > POD is rarely precisely the right concept (and deprecated for that reason). > Is

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

awarzynski updated this revision to Diff 328970. awarzynski added a comment. Generalise the test so that it's not architecture specific I've just realised that the test was failing in Phabricator's CI. It turns out it's an X86-only failure (i.e. the test works fine on my AArch64 dev machine).

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme added a comment. First of all, sorry for submitting this change prematurely. I don't contribute to LLVM/Clang regularly and forgot that reviews should be kept open for a while after a reviewer has approved them to give others a chance to chime in. I jumped the gun here -- apologies.

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

sammccall added a comment. Nice fixes! A few drive-by comments from me, up to you though. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7459-7460 "capture-default specified">; + def note_lambda_variable_capture_fixit : Note< +"capture variable %0 by

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17457 + SmallString<32> FixBuffer; + StringRef Separator = LSI->NumExplicitCaptures > 0 ? ", " : ""; + if (Var->getDeclName().isIdentifier() && !Var->getName().empty()) { sammccall wrote:

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17447 + if (RD->hasUserDeclaredCopyConstructor()) +for (CXXConstructorDecl *Ctor : RD->ctors()) { + if (Ctor->isCopyConstructor()) (braces are not needed here, too)

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added a comment. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3630 + // no -fvisibility=* option. + if (T.isOSAIX() && (Args.hasArg(OPT_mignore_xcoff_visibility) || +

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2610775 , @abidh wrote: > In D98113#2609027 , @jrtc27 wrote: > >> One thing that is currently rather ugly about BareMetal is that it ignores >> the AddArch argument. Once you have

[PATCH] D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Note that the original spelling in `f18` is

[PATCH] D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`

arnamoy10 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98191/new/ https://reviews.llvm.org/D98191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. In D97068#2611269 , @thakis wrote: > Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt > > Please take a look, and revert for now if it takes a while to fix. Hey @thakis, it should be an easy

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 329011. njames93 marked 8 inline comments as done. njames93 added a comment. Address more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/ https://reviews.llvm.org/D96975 Files:

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske updated this revision to Diff 329017. balazske added a comment. Adding test of notes. Tests are re-arranged significantly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://reviews.llvm.org/D97960 Files:

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17444 +if (CXXRecordDecl *RD = T->getAsCXXRecordDecl()) { + if (RD->hasSimpleCopyConstructor()) +return true; sammccall wrote: > I suspect you need to handle the case where

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

alanphipps added a comment. We also encounter a build failure on the Mac related to above but in a different file: clang/lib/CodeGen/CGStmtOpenMP.cpp:1916:3: error: too few template arguments for class template 'SmallVector' SmallVector EffectiveArgs; ^ clang/include/clang/Basic/LLVM.h:35:42:

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

sfertile accepted this revision. sfertile added a subscriber: Xiangling_L. sfertile added a comment. > discussed with sean offline, the we do not call the > emitGlobalDtorWithCXAAtExit() in AIX. so we do not have the problem for the > "__dso_handle" I initially had concerns with the places

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

Eugene.Zelenko added a comment. I think call stack may be useful for other checks too. May be code should be moved to utilities? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://reviews.llvm.org/D97960

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97831/new/ https://reviews.llvm.org/D97831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 329066. njames93 added a comment. Update to not offer Default capture fix if other variables are also captured. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/ https://reviews.llvm.org/D96975 Files:

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap updated this revision to Diff 329015. Conanap marked 3 inline comments as done. Conanap added a comment. Updated some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95458/new/ https://reviews.llvm.org/D95458 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp

[clang] c454200 - AArch64/MacOS: switch default CPU to apple-a13.

Author: Tim Northover Date: 2021-03-08T15:47:05Z New Revision: c4542005dae203dc4cb4e4be22628d4e24b4d5b6 URL: https://github.com/llvm/llvm-project/commit/c4542005dae203dc4cb4e4be22628d4e24b4d5b6 DIFF: https://github.com/llvm/llvm-project/commit/c4542005dae203dc4cb4e4be22628d4e24b4d5b6.diff

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, LG! Comment at: clang-tools-extra/clangd/ClangdServer.h:389 + + class DirtyFS : public ThreadsafeFS { + public: njames93 wrote: > Probably

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

yaxunl added a comment. In D91281#2609766 , @yaxunl wrote: > In D91281#2607082 , @yaxunl wrote: > >> @tra I got some issue with this patch. There are cases that an expression >> using a host variable is

[PATCH] D98030: [IR] Add vscale_range IR function attribute

peterwaller-arm added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:570 +Result += utostr(MinValue); +Result += ','; +Result += utostr(MaxValue); Nit: The only other precedent I can see for this is `allocsize`. Grepping the code I found

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. https://reviews.llvm.org/D98193 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCUDA/device-use-host-var.cu Index: clang/test/SemaCUDA/device-use-host-var.cu

[PATCH] D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`

tskeith added a comment. `-fget-symbols-sources` is not a debug option, it's intended for integrating with IDEs like vscode. So I think the original name is better. Unlike the "dump" options it actually is an action and not something that is intended to produce debug output on the way to doing

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

sammccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17489 + : false; +// We can't use default capture by copy if any captures already specified +// capture by copy. njames93 wrote: > sammccall wrote:

[PATCH] D97198: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc41ae246ac67: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[clang] c41ae24 - [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM

Author: Shilei Tian Date: 2021-03-08T12:03:04-05:00 New Revision: c41ae246ac673e97ec1abdc2b9cbe1989f8682fe URL: https://github.com/llvm/llvm-project/commit/c41ae246ac673e97ec1abdc2b9cbe1989f8682fe DIFF: https://github.com/llvm/llvm-project/commit/c41ae246ac673e97ec1abdc2b9cbe1989f8682fe.diff

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

teemperor added a comment. It seems we already hit this issue before and decided to add a workaround: https://reviews.llvm.org/D86823 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97850/new/ https://reviews.llvm.org/D97850

[PATCH] D98142: [clang] Don't set CLANG_DEFAULT_UNWINDLIB to none if rtlib is set to compiler-rt

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. The merit is less CMake magic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98142/new/ https://reviews.llvm.org/D98142

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. Herald added subscribers: jansvoboda11, dexonsmith. I got a bug report about this patch, see https://bugs.llvm.org/show_bug.cgi?id=49479. I put a patch to fix it here, https://reviews.llvm.org/D98211 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5509748 - [cfe][driver][M68k](8/8) Clang driver support

Author: Min-Yih Hsu Date: 2021-03-08T12:30:57-08:00 New Revision: 5509748f2ce5e06bda7da754297d09a0e68a1f30 URL: https://github.com/llvm/llvm-project/commit/5509748f2ce5e06bda7da754297d09a0e68a1f30 DIFF: https://github.com/llvm/llvm-project/commit/5509748f2ce5e06bda7da754297d09a0e68a1f30.diff

[PATCH] D98055: [ExtVectorType] Support conditional select operator for C++.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/Sema/SemaExprCXX.cpp:6172-6174 + if (IsVectorConditional) { +return CheckVectorConditionalTypes(Cond, LHS, RHS, QuestionLoc); + } Repository: rG LLVM

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5446 // Build a new, canonical decltype(expr) type. Canon = new (*this, TypeAlignment) DependentDecltypeType(*this, e); DependentDecltypeTypes.InsertNode(Canon, InsertPos);

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 329070. njames93 marked 2 inline comments as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files:

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

lei added a comment. Instead of waiting a day or two, can you please directly ping reviewers who had concerns related to the round-trip-args behaviour to get feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/

[PATCH] D98095: [clang] Fix ICE on invalid type parameters for concepts

rsmith added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1644-1661 +TemplateIdAnnotation *TemplateId = DS.getRepAsTemplateId(); +ConceptDecl *TypeConstraintConcept = nullptr; +llvm::SmallVector TemplateArgs; if (DS.isConstrainedAuto()) { -

[PATCH] D98068: Remove asserts for LocalInstantiationScope

tra added a comment. Godbolt appears to be OK with the code for both gcc and clang: https://godbolt.org/z/enec44 Debug build does assert here: clang++: /work/llvm/repo/clang/lib/Sema/SemaTemplateInstantiate.cpp:3630: void clang::LocalInstantiationScope::InstantiatedLocal(const clang::Decl

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 329075. njames93 added a comment. Prevent explicit 'this' capture fix-it if default capture mode is '=' and not in c++20 mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eb7a5814a5c: [cfe][M68k](7/8) Clang basic support (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5509748f2ce5: [cfe][driver][M68k](8/8) Clang driver support (authored by myhsu). Changed prior to commit:

[clang] 5eb7a58 - [cfe][M68k](7/8) Clang basic support

Author: Min-Yih Hsu Date: 2021-03-08T12:30:57-08:00 New Revision: 5eb7a5814a5c629378ba2a4a45fc65cd7f183c9c URL: https://github.com/llvm/llvm-project/commit/5eb7a5814a5c629378ba2a4a45fc65cd7f183c9c DIFF: https://github.com/llvm/llvm-project/commit/5eb7a5814a5c629378ba2a4a45fc65cd7f183c9c.diff

[PATCH] D97990: [clang] Always provide relevant subobject for 'no viable comparison'

rsmith added a comment. I don't think this change is right: for struct A { int bool operator==(const A&) const = default; }; we should warn about the reference member (as we do), but for struct A { int bool operator<(const A&) const = default; }; ... we shouldn't

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 marked 11 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:389 + + class DirtyFS : public ThreadsafeFS { + public: sammccall wrote: > njames93 wrote: > > Probably needs moving to its own

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

tra added inline comments. Comment at: clang/test/SemaCUDA/device-use-host-var.cu:41 *out = global_const_var; + *out = global_const_struct_var.x; I do not think it should be allowed. We end up instantiating the variable on device, even though the variable

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 329082. ffrankies marked 6 inline comments as done. ffrankies added a comment. Rebased with the latest main branch to fix patch application errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files:

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 3 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Lex/LiteralTranslator.h:30-31 + +class LiteralTranslator { +public: + llvm::StringRef InternalCharset; tahonermann wrote: >

[PATCH] D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

mibintc added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3419 // delayed attributes. SourceLocation SavedPrevTokLocation = PrevTokLocation; I remember worrying about this issue when I wrote the initial patch but I can't remember

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

eandrews added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11206-11207 +} else if (FT->getCallConv() != CC_X86StdCall) { + // Default calling convention for WinMain, wWinMain and DllMain is + // __stdcall + FT = Context.adjustFunctionType(

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, nikola. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Breaking a

[PATCH] D98142: [clang] Don't set CLANG_DEFAULT_UNWINDLIB to none if rtlib is set to compiler-rt

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98142/new/ https://reviews.llvm.org/D98142 ___ cfe-commits mailing list

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin added a comment. Gentle ping . @jansvoboda11 . Do you have any comment on it the last update on "added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility" ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

mibintc created this revision. mibintc added reviewers: kpn, erichkeane, rjmccall. mibintc requested review of this revision. Herald added a project: clang. Currently, the CurFPFeatures state is set to command line settings before semantic analysis of the nested member functions and

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 updated this revision to Diff 329100. arnamoy10 added a comment. Rebasing on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

eandrews updated this revision to Diff 329099. eandrews edited the summary of this revision. eandrews added a comment. Implemented review comment to restrict __stdcall default calling convention (for WinMain, wWinMain, and DllMain) to 32 bit Windows. CHANGES SINCE LAST ACTION

[clang] e81d813 - [clang] Don't set CLANG_DEFAULT_UNWINDLIB to none if rtlib is set to compiler-rt

Author: Martin Storsjö Date: 2021-03-08T22:29:54+02:00 New Revision: e81d813717b2ef227c5b995057153d2cca027afb URL: https://github.com/llvm/llvm-project/commit/e81d813717b2ef227c5b995057153d2cca027afb DIFF:

[PATCH] D98142: [clang] Don't set CLANG_DEFAULT_UNWINDLIB to none if rtlib is set to compiler-rt

This revision was automatically updated to reflect the committed changes. Closed by commit rGe81d813717b2: [clang] Dont set CLANG_DEFAULT_UNWINDLIB to none if rtlib is set to compiler-rt (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97941/new/ https://reviews.llvm.org/D97941 ___ cfe-commits mailing list

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 329124. mizvekov added a comment. Addressing Arthur's concerns: - Changed `getBaseDecltypeForExpr` to `getDecltypeForParenthesizedExpr`. - Changed `ImplicitParens` to `Parenthesized`. - Clarified comment. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5446 // Build a new, canonical decltype(expr) type. Canon = new (*this, TypeAlignment) DependentDecltypeType(*this, e); DependentDecltypeTypes.InsertNode(Canon, InsertPos);

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

arichardson added a comment. IMO this should also handle the %t substitution and create a temporary directory. Otherwise we end up writing files to whatever the current cwd is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 329131. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Add a lit feature to check if llvm has jit support to selectively run tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/

[clang] dca5737 - Move ObjCARCUtil.h back to llvm/Analysis

Author: Akira Hatanaka Date: 2021-03-08T16:35:24-08:00 New Revision: dca5737945b9a52d0c66c7ec0cbaa2e15ada69cf URL: https://github.com/llvm/llvm-project/commit/dca5737945b9a52d0c66c7ec0cbaa2e15ada69cf DIFF:

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

njames93 updated this revision to Diff 329126. njames93 added a comment. Rebase and remove an addressed FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95043/new/ https://reviews.llvm.org/D95043 Files:

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

dblaikie added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:490 if (Type *Ty = getValueAsType()) { - raw_string_ostream OS(Result); + // FIXME: This should never be null Result += '('; arsenm wrote: > dblaikie wrote: > > Is it?

[PATCH] D98095: [clang] Fix ICE on invalid type parameters for concepts

mizvekov updated this revision to Diff 329149. mizvekov added a comment. Addressed rsmith's concerns. Fixed test type name to avoid picking up suggestions from other tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98095/new/

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1207 * ``__is_union`` (C++, GNU, Microsoft, Embarcadero) * ``__is_unsigned`` (C++, Embarcadero) + Returns false for enumeration types. Note, before Clang 13, returned true for Please

  1   2   >