[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

LevyHsu updated this revision to Diff 333219. LevyHsu added a comment. in clang/test/Headers/rvintrin.c RUN: -target-feature +experimental-zbr %s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99008/new/ https://reviews.llvm.org/D99008 Files:

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

jmorse added a comment. FTR, the patch LGTM. I haven't really been following the development of debugify in detail so I have no feeling for whether this is good from a high level; if you're confident the mailing list discussion finished with this being the right direction, I'd say this is

[PATCH] D99319: [RISCV] [2/2] Add intrinsic for Zbr extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, jrtc27, kito-cheng. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, usaxena95, s.egerton, Jim, benna, psnobl, kadircet, jocewei, PkmX, arphaman,

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added a comment. In D99037#2649065 , @SaurabhJha wrote: > Hey @fhahn , > > I realise, as you pointed out before, that we need to do some changes in > CodeGen too. I think its going to be more involved so before starting on > that, it would be

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 333247. bader added a comment. [NFC] Align address space map names with AMDGPU target. Rename SPIRAddrSpaceMap and SYCLAddrSpaceMap to SPIRDefIsPrivMap and SPIRDefIsGenMap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99319: [RISCV] [2/2] Add intrinsic for Zbb extension

craig.topper added inline comments. Comment at: clang/lib/Headers/riscv_zbb_intrin.h:18 +// Zbb +static __inline__ int_xlen_t __DEFAULT_FN_ATTRS _rv_orc_b(int_xlen_t rs1) { + return __builtin_riscv_orc_b(rs1); craig.topper wrote: > I think rather than

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz marked an inline comment as done. glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

frasercrmck added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:715-732 +if (Subtarget.is64Bit()) { + addTypeForP(MVT::v8i8, MVT::i64); + addTypeForP(MVT::v4i16, MVT::i64); + addTypeForP(MVT::v2i32, MVT::i64); +} else { +

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added a comment. Thx! @aprantl The motivation of the patch came from the crash of tag name mismatching when using DBX under AIX. And modifying the debugger doesn't seem to make sense? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99250/new/

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

Jim added a comment. In D99158#2645796 , @craig.topper wrote: > What are we gaining from making the intrinsics use vector types if no vector > operations are supported other than the intrinsics? Why can't we just use an > xlen integer type? It can

[PATCH] D99319: [RISCV] [2/2] Add intrinsic for Zbb extension

craig.topper added inline comments. Comment at: clang/lib/Headers/riscv_zbb_intrin.h:18 +// Zbb +static __inline__ int_xlen_t __DEFAULT_FN_ATTRS _rv_orc_b(int_xlen_t rs1) { + return __builtin_riscv_orc_b(rs1); I think rather than int_xlen_t we want an int32_t

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

phosek added a comment. @leonardchan would it be possible to break up this patch into multiple changes: - Clang driver - Cache file - `hwasan_new_delete.cpp` - `HWAddressSanitizer.cpp` - `sanitizer_platform_limits_fuchsia.h` - `sanitizer_symbolizer_markup.cpp` - the rest Repository: rG LLVM

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +//

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder updated this revision to Diff 333226. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99278/new/ https://reviews.llvm.org/D99278 Files: clang/lib/Parse/ParseDeclCXX.cpp Index: clang/lib/Parse/ParseDeclCXX.cpp ===

[PATCH] D99321: [clang] Always execute multi-stage install steps

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99321/new/ https://reviews.llvm.org/D99321 ___

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, with nit. Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, +

[PATCH] D99319: [RISCV] [2/2] Add intrinsic for Zbb extension

kito-cheng added inline comments. Comment at: clang/lib/Headers/riscv_zbb_intrin.h:18 +// Zbb +static __inline__ int_xlen_t __DEFAULT_FN_ATTRS _rv_orc_b(int_xlen_t rs1) { + return __builtin_riscv_orc_b(rs1); craig.topper wrote: > craig.topper wrote: > > I think

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

ruiling added a comment. >> Sounds we still need a long way to get there? Do we think the patch >> acceptable as a short-term solution? > > Guess it's a tradeoff. Doesn't look like a load of code/complexity. - but > equally, does it provide much value? Or is it enough to know it can >

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, jrtc27, kito-cheng. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D99321: [clang] Always execute multi-stage install steps

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar. Herald added a subscriber: mgorny. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want installs to be executed even if binaries haven't changed,

[PATCH] D99322: [clang] Pass option directly to command. NFC

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar. Herald added a subscriber: mgorny. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This code was written back when LLVM's minimum required CMake

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

craig.topper added a comment. Please upload the patch using arcanist or using -U99 when generating the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99320/new/ https://reviews.llvm.org/D99320

[clang] d9abcdd - [clang-format] Fix ObjC method indent after f7f9f94b

Author: Krasimir Georgiev Date: 2021-03-25T10:52:08+01:00 New Revision: d9abcdd9f471ab0d986197e94498a5cf90aa12ef URL: https://github.com/llvm/llvm-project/commit/d9abcdd9f471ab0d986197e94498a5cf90aa12ef DIFF:

[PATCH] D99063: [clang-format] Fix ObjC method indent after f7f9f94b

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9abcdd9f471: [clang-format] Fix ObjC method indent after f7f9f94b (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99063/new/

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz marked an inline comment as done. glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +

[clang] 06411ed - [PowerPC][NFC] Provide legacy names for VSX loads and stores

Author: Nemanja Ivanovic Date: 2021-03-25T06:32:40-05:00 New Revision: 06411edb9fca4a292634511fc7384ffb12651472 URL: https://github.com/llvm/llvm-project/commit/06411edb9fca4a292634511fc7384ffb12651472 DIFF:

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 333266. abhina.sreeskantharajan added a comment. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99182/new/ https://reviews.llvm.org/D99182 Files:

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, + /*RequiresNullTerminator=*/false,

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked 2 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:87 + const ProgramStateRef BugState; + llvm::SmallPtrSet DoneExprs; + steakhal wrote: > I'm not sure if we should

[clang] 8420a53 - [Debugify] Expose original debug info preservation check as CC1 option

Author: Djordje Todorovic Date: 2021-03-25T05:29:42-07:00 New Revision: 8420a5332486c682c1aaddbcb58a571869d19832 URL: https://github.com/llvm/llvm-project/commit/8420a5332486c682c1aaddbcb58a571869d19832 DIFF:

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8420a5332486: [Debugify] Expose original debug info preservation check as CC1 option (authored by djtodoro). Repository:

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82880/new/ https://reviews.llvm.org/D82880

[PATCH] D99337: Don't pass -mllvm to gcc

jethrogb created this revision. jethrogb added reviewers: jyknight, MaskRay. jethrogb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When forwarding command line options to GCC, don't forward -mllvm. Repository: rG LLVM Github

[PATCH] D99337: Don't pass -mllvm to gcc

jethrogb added inline comments. Comment at: clang/test/Driver/gcc_forward.c:9 // RUN: -march=x86-64 \ +// RUN: -mllvm -x86-experimental-lvi-inline-asm-hardening \ // RUN: -mlinker-version=10 -### 2> %t This is just something I happen to know you can pass

[PATCH] D96363: Mark output as text if it is really text

aganea added a comment. Hello! This patch breaks compilation when using `-frewrite-includes` on Windows. It adds an extra line with CRLF, which causes compilation failures with macros line-breaks: $ cat -A hello.cpp int foo();^M$ int bar();^M$ #define HELLO \^M$ foo(); \^M$

[PATCH] D99338: [clang][parser] Allow GNU-style attributes in enum specifiers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We are parsing both C++11 and GNU-style attributes here, but the previous `ProhibitAttributes()` call

[PATCH] D99301: [HIP] add __builtin_get_device_side_mangled_name

yaxunl added inline comments. Comment at: clang/include/clang/Basic/Builtins.h:39 OMP_LANG = 0x80,// builtin requires OpenMP. + HIP_LANG = 0x100, // builtin requires HIP. ALL_LANGUAGES = C_LANG | CXX_LANG | OBJC_LANG, // builtin for all languages.

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

kiranchandramohan added a comment. minor comments. Comment at: flang/lib/Frontend/FrontendAction.cpp:73 + // Include standard macro predefinitions (use the file + // extension if the user didn't express any prefernce) + if ((invoc.preprocessorOpts().predefs_ ==

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Weekly Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:106-109 +if (const auto *DS = llvm::dyn_cast(S)) { + for (const Decl *D : DS->getDeclGroup()) { +if (const VarDecl *VD = llvm::dyn_cast(D)) { + const Expr

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

nikic added a comment. In D99121#2650146 , @nlopes wrote: > Given that it gives a decent speedup for some important workload, and > provided it doesn't regress others [...] I think that second point is going to need some evidence (at least in the form

[clang] c83cd8f - [NFC] Reordering parameters in getFile and getFileOrSTDIN

Author: Abhina Sreeskantharajan Date: 2021-03-25T09:47:49-04:00 New Revision: c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6 URL: https://github.com/llvm/llvm-project/commit/c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6 DIFF:

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc83cd8feef7e: [NFC] Reordering parameters in getFile and getFileOrSTDIN (authored by abhina.sreeskantharajan). Repository: rG LLVM Github

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2650460 , @aganea wrote: > Hello! This patch breaks compilation when using `-frewrite-includes` on > Windows. It adds an extra line with CRLF, which causes compilation failures > with macros

[PATCH] D99344: [Analyzer] Track RValue expressions

martong created this revision. martong added reviewers: steakhal, NoQ, vsavchenko, Szelethus. Herald added subscribers: ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of

[PATCH] D99322: [clang] Pass option directly to command. NFC

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Woo! Thanks for cleaning up one of my old messes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99322/new/ https://reviews.llvm.org/D99322

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a comment. In D97183#2640559 , @RedDocMD wrote: > @NoQ, why does the following trigger a null-dereference warning? > (https://godbolt.org/z/Kxox8qd16) > > void g(std::unique_ptr a) { > A *aptr = a.get(); > if (!aptr) {} >

[PATCH] D99291: [AIX] Support init priority attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:574 + std::string PrioritySuffix = llvm::utostr(Priority); + // Priority is always <= 65535 (enforced by sema). + PrioritySuffix = std::string(6 - PrioritySuffix.size(), '0') + PrioritySuffix;

[clang-tools-extra] 0becc4d - fix readability-braces-around-statements Stmt type dependency

Author: Alexander Lanin Date: 2021-03-25T09:44:41-04:00 New Revision: 0becc4d721d0036e2e38d581bc487e27f78eb8a9 URL: https://github.com/llvm/llvm-project/commit/0becc4d721d0036e2e38d581bc487e27f78eb8a9 DIFF:

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

nlopes added a comment. Given that it gives a decent speedup for some important workload, and provided it doesn't regress others, I think this should go in then. It's easy to revert this once opaque pointers arrive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

paulwalker-arm accepted this revision. paulwalker-arm added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:30 +/// Reports a diagnostic message to indicate a invalid size request has been +/// done on a scalable vector. This function may not return.

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333279. bader marked 16 inline comments as done. bader added a comment. Apply most of the comments from Ronan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files:

[clang] ea61708 - [SystemZ][z/OS] csv files should be text files

Author: Abhina Sreeskantharajan Date: 2021-03-25T09:19:15-04:00 New Revision: ea61708c6d07846e13590b14c4dac2b7d543fef9 URL: https://github.com/llvm/llvm-project/commit/ea61708c6d07846e13590b14c4dac2b7d543fef9 DIFF:

[PATCH] D99285: [SystemZ][z/OS] csv files should be text files

This revision was automatically updated to reflect the committed changes. Closed by commit rGea61708c6d07: [SystemZ][z/OS] csv files should be text files (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99285/new/

[PATCH] D99301: [HIP] add __builtin_get_device_side_mangled_name

yaxunl updated this revision to Diff 333296. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99301/new/ https://reviews.llvm.org/D99301 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen updated this revision to Diff 333298. khchen marked an inline comment as done. khchen added a comment. Emit riscv_vector_overloaded.h into riscv_vector.h Remove riscv_vector_overloaded.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99330: [clang-tidy] [test] Tweak a regex pattern to accommodate for quirks in MSYS based grep

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a subscriber: xazax.hun. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. Currently on Windows, 'not' is a regular win32 executable, which parses command line parameters according to

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. > Having multiple maps is not something new to the clang community. Similar > approach AMDGPU target applies to customize address space mapping for OpenCL > language > (https://github.com/llvm/llvm-project/blob/main/clang/lib/Basic/Targets/AMDGPU.cpp#L354). > > I

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rG02d7ef3181dd: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process (authored by njames93). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 02d7ef3 - [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

Author: Nathan James Date: 2021-03-25T14:38:37Z New Revision: 02d7ef3181dd6a043a8ad16d747353dd02cbb5ef URL: https://github.com/llvm/llvm-project/commit/02d7ef3181dd6a043a8ad16d747353dd02cbb5ef DIFF: https://github.com/llvm/llvm-project/commit/02d7ef3181dd6a043a8ad16d747353dd02cbb5ef.diff LOG:

[clang] 8fbfc92 - Reuse `os` variable in AllocateTarget; NFC

Author: Sven van Haastregt Date: 2021-03-25T14:38:02Z New Revision: 8fbfc92a5cef5e709ca47742e7bf11035607abcc URL: https://github.com/llvm/llvm-project/commit/8fbfc92a5cef5e709ca47742e7bf11035607abcc DIFF: https://github.com/llvm/llvm-project/commit/8fbfc92a5cef5e709ca47742e7bf11035607abcc.diff

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

martong added inline comments. Comment at: clang/test/Analysis/zero-operands.c:43 + +void test_0_divisible(int x, int y) { + int a = x < 0; // Eagerly bifurcate. Note, this is the test that fails without this fix. The preceding tests are here to demonstrate

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked 3 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:106-109 +if (const auto *DS = llvm::dyn_cast(S)) { + for (const Decl *D : DS->getDeclGroup()) { +if (const VarDecl *VD =

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaronpuchert added a comment. In D98747#2648943 , @aaronpuchert wrote: > We could probably address all false negatives by introducing a `FactEntry` > for "managed locks that might be held", which we introduce on discrepancies > at join points. We

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 11. arnamoy10 added a comment. Updating test case to add `-fsyntax-only` to share with `f18 ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz added a comment. In D99250#2650561 , @probinson wrote: > In D99250#2649507 , @Esme wrote: > >> Thx! @aprantl The motivation of the patch came from the crash of tag name >> mismatching when using DBX under

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

steakhal added a comment. I recommend splitting this into two. I would happily accept the part about `std::data()`. IMO `std::addressof()` should be modelled via `evalCall` as a pure function, instead of hacking it into the `InnerPtrChecker`. It is overloaded to accept `const T&` as well, so

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. Let's take a look at compilation output for the following program: c++ void foo(int *p) {} OpenCL compiler produces following LLVM IR for SPIR target: LLVM define dso_local spir_func void @_Z3fooPU3AS4i(i32 addrspace(4)* nocapture %0) local_unnamed_addr #0 {

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader added a comment. @keryell, thanks for the feedback. I applied your suggestions with two exceptions: 1. I'm not sure if other back-ends need special processing for kernel function parameters we apply for SPIR kernels. 2. I'm looking for suggestions on "OpenCL extensions" clarification.

[PATCH] D99337: Don't pass -mllvm to gcc

jethrogb abandoned this revision. jethrogb added a comment. Actually I think this is fixed in main (was developing against 11.x). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99337/new/ https://reviews.llvm.org/D99337

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

probinson added a comment. In D99250#2649507 , @Esme wrote: > Thx! @aprantl The motivation of the patch came from the crash of tag name > mismatching when using DBX under AIX. And modifying the debugger doesn't seem > to make sense? A consumer should

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

martong created this revision. martong added reviewers: steakhal, NoQ, vsavchenko, Szelethus. Herald added subscribers: ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Looks great! Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:655 return makeSymExprValNN(op, InputLHS, InputRHS, resultTy); + case

[PATCH] D99344: [Analyzer] Track RValue expressions

vsavchenko added a comment. From the first glance, everything is looking good! Thanks for addressing this! But I still need to have a deeper look. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1932-1933 +bool

[PATCH] D99344: [Analyzer] Track RValue expressions

steakhal added a comment. I really like it. Looks good. I'm letting someone else accept this as I've not really touched the trackExpression parts. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:119-124 +/// Attempts to add visitors to

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

probinson added a comment. I think there are degrees of compatibility with regard to DWARF, which is inherently supposed to be extensible if the extension can be safely ignored by a consumer. This is the "permissive" rule in the standard. - A new FORM must *never* be used, because that makes

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. In D97785#2650824 , @yroux wrote: > Hi Abhina, > > I think this patch broke Windows on ARM bots, the first failure observed 6 > days ago in this build: > > https://lab.llvm.org/buildbot/#/builders/65/builds/1245 >

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

lxfind updated this revision to Diff 38. lxfind added a comment. Address comments, and fix all tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99227/new/ https://reviews.llvm.org/D99227 Files: clang/lib/CodeGen/CGCoroutine.cpp

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

amccarth added a comment. When changing an IO stream's mode from binary to text breaks only Windows, it's likely due to the fact that Windows uses CR+LF as the newline indicator. Not only are the CRs sometimes unexpected, they can also throw off code that tries to seek to a computed file

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. usaxena95 marked an inline comment as done. Closed by commit rGaa979084dffb: [clang][Syntax] Optimize expandedTokens for token ranges. (authored by usaxena95).

[clang] aa97908 - [clang][Syntax] Optimize expandedTokens for token ranges.

Author: Utkarsh Saxena Date: 2021-03-25T18:54:15+01:00 New Revision: aa979084dffba86a3e170826b4e89d90820bb78b URL: https://github.com/llvm/llvm-project/commit/aa979084dffba86a3e170826b4e89d90820bb78b DIFF:

[PATCH] D99291: [AIX] Support init priority attribute

Xiangling_L updated this revision to Diff 58. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Add assertion to make sure we have correct priority value in range; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99291/new/ https://reviews.llvm.org/D99291

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind added a comment. In D98135#2650940 , @ABataev wrote: > In D98135#2650914 , @lxfind wrote: > >> @ABataev, wondering if you have a timeline on this? >> Missing counters from OMP functions sometimes cause

[PATCH] D99361: [clang][driver] Support HWASan in the Fuchsia toolchain

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: clang. leonardchan requested review of this revision. These contain clang driver changes for supporting HWASan on Fuchsia. This includes hwasan multilibs and the dylib path change.

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 78. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360 Files: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp llvm/include/llvm/BinaryFormat/ELF.h llvm/tools/llvm-readobj/ELFDumper.cpp

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

rnk requested changes to this revision. rnk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/Rewrite/FrontendActions.cpp:190 + std::unique_ptr OS = CI.createDefaultOutputFile( +

[clang] 4c7ebf7 - [flang][driver] Add options for -std=f2018

Author: Arnamoy Bhattacharyya Date: 2021-03-25T13:03:16-04:00 New Revision: 4c7ebf79e923072e8d298134e6ca04618fe4eba9 URL: https://github.com/llvm/llvm-project/commit/4c7ebf79e923072e8d298134e6ca04618fe4eba9 DIFF:

[PATCH] D97119: [flang][driver] Add options for -std=f2018

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c7ebf79e923: [flang][driver] Add options for -std=f2018 (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. In D98135#2650914 , @lxfind wrote: > @ABataev, wondering if you have a timeline on this? > Missing counters from OMP functions sometimes cause llvm-cov to crash because > of data inconsistency. Cannot answer right now. It would

[PATCH] D98638: [RFC][Coroutine] Force stack allocation after await_suspend() call

lxfind abandoned this revision. lxfind added a comment. Abandoning in favor of D99227 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98638/new/ https://reviews.llvm.org/D98638

[clang] 015c398 - [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

Author: Gabor Marton Date: 2021-03-25T18:25:06+01:00 New Revision: 015c39882ebc1771713a7523ae76903ebae83288 URL: https://github.com/llvm/llvm-project/commit/015c39882ebc1771713a7523ae76903ebae83288 DIFF: https://github.com/llvm/llvm-project/commit/015c39882ebc1771713a7523ae76903ebae83288.diff

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

martong marked an inline comment as done. martong added a comment. Thanks for the review! Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:655 return makeSymExprValNN(op, InputLHS, InputRHS, resultTy); + case BO_Div: case BO_Rem:

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG015c39882ebc: [Analyzer] Infer 0 value when the divisible is 0 (bug fix) (authored by martong). Changed prior to commit:

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

vsavchenko added a comment. Awesome! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99343/new/ https://reviews.llvm.org/D99343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 44. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99086/new/ https://reviews.llvm.org/D99086 Files:

[PATCH] D99344: [Analyzer] Track RValue expressions

martong updated this revision to Diff 46. martong added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99344/new/ https://reviews.llvm.org/D99344 Files:

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

aaron.ballman added a comment. Do you need me to commit on your behalf? If so, which email address would you like me to use for attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82880/new/ https://reviews.llvm.org/D82880

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. In D97785#2651008 , @amccarth wrote: > When changing an IO stream's mode from binary to text breaks only Windows, > it's likely due to the fact that Windows uses CR+LF as the newline indicator. > Not only are

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a subscriber: protze.joachim. awarzynski added a comment. I've not had a chance to add tests yet. I will add them shortly. @protze.joachim , hopefully this addresses the issues that you raised in https://reviews.llvm.org/D95460. Please, could you verify before I update this? I

  1   2   >