[PATCH] D100468: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee570e215353: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ee570e2 - [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

Author: Martin Storsjö Date: 2021-04-15T11:02:14+03:00 New Revision: ee570e215353625a867fcbfd8c3089e9e0f8660d URL: https://github.com/llvm/llvm-project/commit/ee570e215353625a867fcbfd8c3089e9e0f8660d DIFF:

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 337640. pdhaliwal added a comment. Rebase and review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files:

[PATCH] D100484: add test case for ignoring -flto=auto and -flto=jobserver

fhahn accepted this revision. fhahn added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100484/new/ https://reviews.llvm.org/D100484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99501: ignore -flto= options recognized by GCC

fhahn added a comment. In D99501#2689090 , @tejohnson wrote: > Just approved the test case patch. Sorry I missed the lack of test on this! Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

khchen added a comment. > The fact that we're running the optimization pipeline in these tests might be > to blame. Might also be that riscv_vector.h is currently about 71000 lines > which probably isn't quick to parse. I found removing all overloaded api definition functions in

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

rogfer01 added a comment. I've left a PoC of my approach here https://reviews.llvm.org/D100529 in case we can use that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99741/new/ https://reviews.llvm.org/D99741

[PATCH] D100530: [AST][Introspection] Add a check to detect if introspection is supported.

njames93 created this revision. njames93 added a reviewer: steveire. Herald added a subscriber: mgorny. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This could probably be made into a compile time constant, but that would

[PATCH] D100531: [clang][deps] Simplify function discovering .pcm and .modulemap files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch simplifies (and renames) the `appendCommonModuleArguments` function. It no

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 337654. AMDChirag added a comment. Herald added a subscriber: jfb. Fixed cancel construct and applied updates to its test cases The test cases are updated so that the IR generated with and without IRBuilder are considered as they are different. The

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

rogfer01 added a comment. In D99741#2690156 , @craig.topper wrote: > In D99741#2690124 , @thakis wrote: > >> One of the ten commits that landed here >>

[PATCH] D100533: [clang][deps] Always generate full command lines

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes the `-full-command-line` option from `clang-scan-deps`. It's only

[PATCH] D100536: [clang][deps] NFC: Remove unused FullDependencies member

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes the `FullDependencies::AdditionalNonPathCommandLine` member, as it's

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ImplementAbstract.cpp:1 +//===--- ImplementAbstract.cpp ---*- C++-*-===// +// sammccall wrote: > I'd consider calling this OverrideVirtual.cpp.

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

svenvh added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8673 +// reference if an implementation supports them in kernel parameters. +if (!PointeeType->isAtomicType() && !PointeeType->isVoidType() && +!PointeeType->isStandardLayoutType())

[PATCH] D100534: [clang][deps] Generate the full command-line for modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch uses the new `CompilerInvocation::generateCC1CommandLine` to generate the

[clang] 06eff02 - [clang][deps] NFC: Improve documentation

Author: Jan Svoboda Date: 2021-04-15T10:31:09+02:00 New Revision: 06eff02ba18b02bff3a8d5759cc4a5ee043e4112 URL: https://github.com/llvm/llvm-project/commit/06eff02ba18b02bff3a8d5759cc4a5ee043e4112 DIFF: https://github.com/llvm/llvm-project/commit/06eff02ba18b02bff3a8d5759cc4a5ee043e4112.diff

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:9 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS /opt/rocm) +if (NOT ${hsa-runtime64_FOUND}) gregrodgers wrote: > What happens when

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

DavidSpickett added a comment. What's your logic for these being Arm only? I looked up the ones that were added: vadd_p8 vadd_p16 vadd_p64 vaddq_p8 vaddq_p16 vaddq_p64 vaddq_p128 E.g.

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. Thank you for the answer. It did not know that I have to land it myself. Now I read up on https://llvm.org/docs/Phabricator.html Tried to land via 'arc land' but I do not have the access rights. So: Can someone please land the change for me. :) Repository: rG LLVM

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. Thank you for landing it. The information should be ok. But anyway: Max Sagebaum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 ___

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. Just wanted to ask if there is something missing for the merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 ___ cfe-commits mailing

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

dongAxis1944 added a comment. @jmorse I am not familiar with CHECK-DAG. And @probinson 's suggestion might be useful, any ideas? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100298/new/ https://reviews.llvm.org/D100298

[PATCH] D100548: [AST] Fix location call storage with common last-invocation

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also fix the formatter to use the front element of a chained call instead of the back element. Repository: rG

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri updated this revision to Diff 337679. lebedev.ri marked 10 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100388/new/ https://reviews.llvm.org/D100388 Files: clang/include/clang/AST/VTableBuilder.h

[clang] 56cb214 - add test case for ignoring -flto=auto and -flto=jobserver

Author: Matthias Klose Date: 2021-04-15T12:19:14+02:00 New Revision: 56cb214b38a70c0fc824ab096e500d78c72b44ef URL: https://github.com/llvm/llvm-project/commit/56cb214b38a70c0fc824ab096e500d78c72b44ef DIFF:

[PATCH] D100484: add test case for ignoring -flto=auto and -flto=jobserver

This revision was automatically updated to reflect the committed changes. Closed by commit rG56cb214b38a7: add test case for ignoring -flto=auto and -flto=jobserver (authored by doko, committed by sylvestre.ledru). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. No remarks from me. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99503/new/ https://reviews.llvm.org/D99503

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100488/new/ https://reviews.llvm.org/D100488 ___ cfe-commits

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

gregrodgers added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:9 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS /opt/rocm) +if (NOT ${hsa-runtime64_FOUND}) What happens when /opt/rocm is not available?

[PATCH] D100514: [OpenMP] Added codegen for masked directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3853-3855 + if (const auto *FilterClause = S.getSingleClause()) { +Filter = FilterClause->getThreadID(); + } No need for braces here Comment at:

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:54 +// Extension associated to a type. +class TypeExtension : AbstractExtension<_Ext>; + Anastasia wrote: > svenvh wrote: > > Anastasia wrote: > > > I am trying to understand why would we

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield accepted this revision. JonChesterfield added a comment. I've built this, checked it behaves as expected, checked clang does something reasonable when the executable is missing. All looks good to me, explicitly accepting. We may need an internal call with Greg to work out how

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

curdeius added a comment. I think you can land it. The issues seem indeed unrelated. You might want to rebase and retest before landing to be sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

vhscampos updated this revision to Diff 337723. vhscampos added a comment. Add a clarifying comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100372/new/ https://reviews.llvm.org/D100372 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D100552: [HIP] Diagnose compiling kernel without offload arch

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, tpr, nhaehnle, jvesely. Herald added a reviewer: aaron.ballman. yaxunl requested review of this revision. AMDGPU does not have a common processor (GPU arch). A HIP kernel must be compiled with a

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

Max_S updated this revision to Diff 337665. Max_S added a comment. Moved the test to their own section and fixed the formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99503/new/ https://reviews.llvm.org/D99503 Files:

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri abandoned this revision. lebedev.ri added a comment. You know, somehow i don't think me wasting 30 more hours on this to experimentally find a working permutation is productive. Comment at: clang/include/clang/Basic/Thunk.h:157 + + /// Holds a pointer to the

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

Max_S added a comment. I do not have the access rights to the llvm git repo. Can you please land it for me. Thanks and thank you for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99503/new/ https://reviews.llvm.org/D99503

Re: [clang] 5ad15f4 - Require commas between double square bracket attributes.

On Thu, Apr 15, 2021 at 12:15 AM wrote: > > Hi Aaron, > > Your change is causing the compiler to go into an infinite loop in one of our > internal tests. I have put details up in PR49966, can you please take a look? Absolutely, thank you for the report! ~Aaron > > Douglas Yung > >

[PATCH] D100509: Support GCC's -fstack-usage flag

jansvoboda11 added a comment. I left a couple of comments inline on the command-line parsing aspect of the patch. For more info, check https://clang.llvm.org/docs/InternalsManual.html#adding-new-command-line-option. Comment at: clang/include/clang/Driver/Options.td:2658 +

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire updated this revision to Diff 337720. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100516/new/ https://reviews.llvm.org/D100516 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D100415: [Coroutines] Split coroutine during CoroEarly into an init and ramp function

ChuanqiXu added a comment. It looks like this code may trigger assertion in `CoroInstr.h` for `CoroIdInst::setCoroutineSelf`. Also, since this patch would enlarge the coroutine frame, it may affect the performance naturally. I **believe** it wouldn't really matter. I just find that we need

[PATCH] D100423: [AST] Add a print method to Introspection LocationCall

njames93 updated this revision to Diff 337724. njames93 added a comment. Tweak implementaion to make the print a static method of FormatterCpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100423/new/ https://reviews.llvm.org/D100423 Files:

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:296-298 +def warn_anyx86_interrupt_regsave : Warning< + "interrupt service routine should only call a function" " with attribute 'no_caller_saved_registers'">;

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc updated this revision to Diff 337789. mibintc marked an inline comment as done. mibintc added a comment. I added the InGroup rule for the new warning diagnostic like Aaron requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/

[PATCH] D100467: [clang] [AArch64] Fix handling of HFAs passed to Windows variadic functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, micro readability suggestion Comment at: clang/lib/CodeGen/TargetInfo.cpp:5691 + // no special handling of HFAs/HVAs. + if (isHomogeneousAggregate(Ty, Base, Members) &&

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

This revision was automatically updated to reflect the committed changes. Closed by commit rG938b863bb53f: [clang][patch] Modify diagnostic level from err to warn… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/

[clang] 938b863 - [clang][patch] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

Author: Melanie Blower Date: 2021-04-15T13:11:33-04:00 New Revision: 938b863bb53f033c916d4e8d9a18cbd063656011 URL: https://github.com/llvm/llvm-project/commit/938b863bb53f033c916d4e8d9a18cbd063656011 DIFF:

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

svenvh updated this revision to Diff 337663. svenvh added a comment. Adding some more comments / explanation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100209/new/ https://reviews.llvm.org/D100209 Files: clang/lib/Sema/OpenCLBuiltins.td clang/lib/Sema/SemaLookup.cpp

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

Max_S updated this revision to Diff 337691. Max_S edited the summary of this revision. Max_S added a comment. Added changelog entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99503/new/ https://reviews.llvm.org/D99503 Files:

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

curdeius added a comment. I'll land it for you. Could you please provide "Name Surname " for commit attribution unless the info associated with your phabricator user is okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 337778. pzheng added a comment. Address @jansvoboda11's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files:

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added a comment. The corresponding clang patch is here: https://reviews.llvm.org/D100567 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/ https://reviews.llvm.org/D100567 ___

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/ https://reviews.llvm.org/D100511

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 337802. pzheng added a comment. Mention the flag in release notes based on @xbolva00's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files:

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. >> :: gcc also supports "bounded" - do you plan to somehow handle it? (https://gcc.gnu.org/onlinedocs/gcc/Developer-Options.html#Developer-Options), eg: parser.c:918:5:parse_statement 48 dynamic,bounded Comment at:

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne added a comment. In D45639#2383754 , @smeenai wrote: > Just following up on this, cos I'm curious :) I have 12.1 now, and I still > only see the C++ headers in the toolchain and not in any of the SDKs. Look in Xcode 12.5 beta 3, you should see

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song created this revision. yonghong-song added a reviewer: dblaikie. yonghong-song added projects: debug-info, clang. yonghong-song requested review of this revision. Herald added a subscriber: cfe-commits. Commit e3d8ee35e4ad

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 3 inline comments as done. pzheng added a comment. Thanks for your feedback, @jansvoboda11! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 ___

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. It would be great to also update release notes for clang to inform users about this new feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:9 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS /opt/rocm) +if (NOT ${hsa-runtime64_FOUND}) t-tye wrote: > JonChesterfield wrote: > >

[clang] c8f0a7c - [NewPM] Cleanup IR printing instrumentation

Author: Arthur Eubanks Date: 2021-04-15T09:50:55-07:00 New Revision: c8f0a7c215ab4c08ed2f5ac53f080adbb54714ab URL: https://github.com/llvm/llvm-project/commit/c8f0a7c215ab4c08ed2f5ac53f080adbb54714ab DIFF:

[PATCH] D100231: [NewPM] Cleanup IR printing instrumentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8f0a7c215ab: [NewPM] Cleanup IR printing instrumentation (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100514: [OpenMP] Added codegen for masked directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. Makes sense to me. Only BPF target will notice this difference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

t-tye added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:9 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS /opt/rocm) +if (NOT ${hsa-runtime64_FOUND}) JonChesterfield wrote: > JonChesterfield wrote: > >

[PATCH] D100552: [HIP] Diagnose compiling kernel without offload arch

aaron.ballman added a comment. Drive-by comment on the diagnostic wording. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8260 +def err_hip_kern_without_gpu : Error< + "compile HIP kernel without specifying offload arch is not allowed">, + DefaultFatal;

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

olestrohm added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8673 +// reference if an implementation supports them in kernel parameters. +if (!PointeeType->isAtomicType() && !PointeeType->isVoidType() && +!PointeeType->isStandardLayoutType())

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

jmorse updated this revision to Diff 337793. jmorse added a comment. Right you are -- another thing I didn't clock was that this test was running all of the LLVM passes (generating many instances of the coroutine function). Latest revision disables those passes so that there are only

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. In D100509#2692127 , @xbolva00 wrote: >>> :: > > gcc also supports "bounded" - do you plan to somehow handle it? > (https://gcc.gnu.org/onlinedocs/gcc/Developer-Options.html#Developer-Options), > eg:

[PATCH] D100187: [OPENMP]Fix PR49115: Incorrect results for scan directive.

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. The change looks good to me. I am new to this. You may want to give more time for others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen updated this revision to Diff 337797. cchen added a comment. Update test and fix code format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[clang] 99eca1b - [Driver] Enable kernel address and memory sanitizers on FreeBSD

Author: Mark Johnston Date: 2021-04-15T17:49:00+01:00 New Revision: 99eca1bd9c7ac8de4caba0733c3079ff93b65deb URL: https://github.com/llvm/llvm-project/commit/99eca1bd9c7ac8de4caba0733c3079ff93b65deb DIFF: https://github.com/llvm/llvm-project/commit/99eca1bd9c7ac8de4caba0733c3079ff93b65deb.diff

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99eca1bd9c7a: [Driver] Enable kernel address and memory sanitizers on FreeBSD (authored by markj, committed by arichardson). Repository: rG LLVM

[PATCH] D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode

yln added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:444-447 +// Prior to c++17, "the failure argument shall be no stronger than the +// success argument". This condition has been lifted and the only +// precondition is 31.7.2.18. Effectively treat

[PATCH] D100558: [flang][driver] Add support for `-fget-definition`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds `-fget-definition` to `flang-new`. The semantics

[PATCH] D100558: [flang][driver] Add support for `-fget-definition`

awarzynski updated this revision to Diff 337747. awarzynski added a comment. Rebase on top of D100556 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100558/new/ https://reviews.llvm.org/D100558 Files:

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100209/new/ https://reviews.llvm.org/D100209 ___ cfe-commits mailing

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

Anastasia added a comment. LGTM from my side. I will leave final approval to Sven. Comment at: clang/lib/Sema/SemaDecl.cpp:8673 +// reference if an implementation supports them in kernel parameters. +if (!PointeeType->isAtomicType() && !PointeeType->isVoidType() && +

[PATCH] D100423: [AST] Add a print method to Introspection LocationCall

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100423/new/ https://reviews.llvm.org/D100423

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

Jonathan.Crowther updated this revision to Diff 337764. Jonathan.Crowther added a comment. No updates, just want to kick off the CI again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100488/new/ https://reviews.llvm.org/D100488 Files:

[clang] ad2d6bb - Fix potential infinite loop with malformed attribute syntax

Author: Aaron Ballman Date: 2021-04-15T10:47:32-04:00 New Revision: ad2d6bbb1435cef0a048c9aed3dcf9617640f222 URL: https://github.com/llvm/llvm-project/commit/ad2d6bbb1435cef0a048c9aed3dcf9617640f222 DIFF: https://github.com/llvm/llvm-project/commit/ad2d6bbb1435cef0a048c9aed3dcf9617640f222.diff

[clang-tools-extra] ecf93a7 - [clangd] Only allow remote index to be enabled from user config.

Author: Sam McCall Date: 2021-04-15T14:51:23+02:00 New Revision: ecf93a716c9ecf2e38898547df90323e239a623c URL: https://github.com/llvm/llvm-project/commit/ecf93a716c9ecf2e38898547df90323e239a623c DIFF: https://github.com/llvm/llvm-project/commit/ecf93a716c9ecf2e38898547df90323e239a623c.diff

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis added a comment. Hi @Meinersbur (got word you are a windows user), @jdoerfert, could I ask your help in detecting why the clang tests on windows are failing? There are two failures I'm spotting, one is that calls to llvm.nvvm intrinsics seem transposed

[PATCH] D100507: [Clang][Docs] Claim the atomic compare

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100507/new/ https://reviews.llvm.org/D100507

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc updated this revision to Diff 337731. mibintc added a comment. I removed the diagnostic from InGroup, that's the only change from previous revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/ https://reviews.llvm.org/D100511

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:9 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS /opt/rocm) +if (NOT ${hsa-runtime64_FOUND}) JonChesterfield wrote: > gregrodgers wrote: > >

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

gregrodgers accepted this revision. gregrodgers added a comment. This revision is now accepted and ready to land. I am removing my objection with the understanding that we will either replace or enhance amdgpu-arch with the cross-architecture tool offload-arch as described in my comments above.

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov added a comment. My main idea was to provide an interface which will not make users to specify `-cl-ext=+__opencl_c_fp64,+cl_khr_fp64`/ `-cl-ext=-__opencl_c_fp64,-cl_khr_fp64` if they need to enable/disable functionality in OpenCL C 3.0 because I believe that is not a right thing to

[PATCH] D100231: [NewPM] Cleanup IR printing instrumentation

jamieschmeiser accepted this revision. jamieschmeiser added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100231/new/ https://reviews.llvm.org/D100231

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:299 + " with attribute 'no_caller_saved_registers'">, + InGroup; def warn_arm_interrupt_calling_convention : Warning< rsmith

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Great! And thanks for fixing misprint :) Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:507 +if (VersionIDs[I] >= MinVersion && VersionIDs[I] <

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:507 +if (VersionIDs[I] >= MinVersion && VersionIDs[I] < MaxVersion) { + Encoded |= 1 << I; +} azabaznov wrote: > nit: Encoded |=

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatability

saghir updated this revision to Diff 337765. saghir added a comment. Fixed spelling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100482/new/ https://reviews.llvm.org/D100482 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D100415: [Coroutines] Split coroutine during CoroEarly into an init and ramp function

lxfind added a comment. @ChuanqiXu Thank you for the detailed review! Really appreciate it. I agree we should create a coroutine benchmark at some point, ideally some realistic production-code driven benchmark. We can work on that in the future. For this patch, it's probably not worth it to

[clang] 2a95cb5 - [Clang][Docs] Claim the atomic compare

Author: Shilei Tian Date: 2021-04-15T11:10:15-04:00 New Revision: 2a95cb5858f8bc0fed3956f72bd51bf6a948e660 URL: https://github.com/llvm/llvm-project/commit/2a95cb5858f8bc0fed3956f72bd51bf6a948e660 DIFF: https://github.com/llvm/llvm-project/commit/2a95cb5858f8bc0fed3956f72bd51bf6a948e660.diff

[PATCH] D100507: [Clang][Docs] Claim the atomic compare

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a95cb5858f8: [Clang][Docs] Claim the atomic compare (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100507/new/

[clang] e0c2125 - [OpenMP] Added codegen for masked directive

Author: cchen Date: 2021-04-15T12:55:07-05:00 New Revision: e0c2125d1d1e72039b8e071d468d9f740c7dbfbd URL: https://github.com/llvm/llvm-project/commit/e0c2125d1d1e72039b8e071d468d9f740c7dbfbd DIFF: https://github.com/llvm/llvm-project/commit/e0c2125d1d1e72039b8e071d468d9f740c7dbfbd.diff LOG:

[PATCH] D100514: [OpenMP] Added codegen for masked directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c2125d1d1e: [OpenMP] Added codegen for masked directive (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >