[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann added a comment. Friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100742: [clangd] Parameter hints for dependent calls

nridge updated this revision to Diff 340439. nridge added a comment. Herald added a subscriber: cfe-commits. Add some more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100742/new/ https://reviews.llvm.org/D100742 Files:

[PATCH] D100742: [clangd] Parameter hints for dependent calls

nridge added a reviewer: sammccall. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:264 +// FIXME: This one does not work yet. +A::static_member($par3[[t]]); } This is an interesting case.

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:163-165 + ProgramStateManager = N->getState()->getStateManager(); + MemRegionManager = StateMgr.getRegionManager(); + return MRMgr.getVarRegion(VD,

[PATCH] D100822: [RISCV] Implement the vfabs.v/vfneg.v builtin.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb3fca7e110: [RISCV] Implement the vfabs.v/vfneg.v builtin. (authored by HsiangKai). Changed prior to commit:

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

This revision was automatically updated to reflect the committed changes. Closed by commit rG645c5f27a84d: [RISCV] Implement the pseudo compare builtin. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D100823?vs=339879=340444#toc Repository: rG LLVM Github

[clang] bfb3fca - [RISCV] Implement the vfabs.v/vfneg.v builtin.

Author: Hsiangkai Wang Date: 2021-04-26T15:38:31+08:00 New Revision: bfb3fca7e110a367c9589495575913d83bea7095 URL: https://github.com/llvm/llvm-project/commit/bfb3fca7e110a367c9589495575913d83bea7095 DIFF:

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b2434172cc1: [RISCV] Implement the vmmv.m/vmnot.m builtin. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D100821?vs=339875=340442#toc Repository: rG LLVM Github

[clang] 4b24341 - [RISCV] Implement the vmmv.m/vmnot.m builtin.

Author: Hsiangkai Wang Date: 2021-04-26T15:38:31+08:00 New Revision: 4b2434172cc15ccd32c5c9110a3a4df18b8fba5e URL: https://github.com/llvm/llvm-project/commit/4b2434172cc15ccd32c5c9110a3a4df18b8fba5e DIFF:

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

hokein added a comment. Thanks for tracking it down, and sorry for the delay. I thought the crash was fix in https://reviews.llvm.org/D99145. Thinking more about it, this is a recovery-expr crash, see my comment below. Comment at: clang/lib/Sema/SemaChecking.cpp:4543 //

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2715097 , @OikawaKirie wrote: > In D83660#2675064 , @mikhail.ramalho > wrote: > >> Indeed it looks like a copy & paste error, I'm surprised no one found it >> earlier. >> >>

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:967-968 + + // While looking for the last var bindings, we can still find + // `AllocFirstBinding` to be one of them. In situations like this, + // it

[clang] 18772de - [OpenCL] Add inc/dec/cmpxchg C++ legacy atomics with generic

Author: Sven van Haastregt Date: 2021-04-26T09:46:11+01:00 New Revision: 18772de1ecb1a23b483e29987ae708ab641b1134 URL: https://github.com/llvm/llvm-project/commit/18772de1ecb1a23b483e29987ae708ab641b1134 DIFF:

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. In D100739#2713579 , @ychen wrote: > In D100739#2711698 , @ChuanqiXu > wrote: > >>> This is an alternative to D97915 which >>> missed proper

[PATCH] D100852: [analyzer] Track leaking object through stores

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:636 if (isa(R)) - Result.push_back(R); + Result.emplace_back(R,

[PATCH] D101051: [clang][deps] Only generate absolute paths when asked to

jansvoboda11 updated this revision to Diff 340449. jansvoboda11 retitled this revision from "[clang][deps] Only generate modules-related paths when asked to" to "[clang][deps] Only generate absolute paths when asked to". jansvoboda11 edited the summary of this revision. jansvoboda11 added a

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

NoQ added a comment. In D98726#2714215 , @RedDocMD wrote: > I think something is wrong about the way we are investigating this or I don't > understand the `MallocChecker`. > The following doesn't yield a bug report! => https://godbolt.org/z/Y57G7zE5j

[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1482 Bind.method("textDocument/semanticTokens/full/delta", this, ::onSemanticTokensDelta); -

[clang] 0f7d410 - [clang][deps] Only generate absolute paths when asked to

Author: Jan Svoboda Date: 2021-04-26T10:53:41+02:00 New Revision: 0f7d4105c60b5b4ee80fd32225658a4d8261c120 URL: https://github.com/llvm/llvm-project/commit/0f7d4105c60b5b4ee80fd32225658a4d8261c120 DIFF: https://github.com/llvm/llvm-project/commit/0f7d4105c60b5b4ee80fd32225658a4d8261c120.diff

[PATCH] D101051: [clang][deps] Only generate absolute paths when asked to

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f7d4105c60b: [clang][deps] Only generate absolute paths when asked to (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9ab4eab - [clang][deps] NFC: Fix typo

Author: Jan Svoboda Date: 2021-04-26T10:55:24+02:00 New Revision: 9ab4eab570f7d11c375993d59b1a7ec2c32a72fc URL: https://github.com/llvm/llvm-project/commit/9ab4eab570f7d11c375993d59b1a7ec2c32a72fc DIFF: https://github.com/llvm/llvm-project/commit/9ab4eab570f7d11c375993d59b1a7ec2c32a72fc.diff

[clang] 5987d7c - [clang-format] fix indent in alignChainedConditionals

Author: Krasimir Georgiev Date: 2021-04-26T11:06:29+02:00 New Revision: 5987d7c59da5a7611036c2952f5a1f501d17ad48 URL: https://github.com/llvm/llvm-project/commit/5987d7c59da5a7611036c2952f5a1f501d17ad48 DIFF:

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

martong added a comment. To provide unit tests that mimic the LLDB setup, a good starting point could be an existing test case: struct LLDBLookupTest : ASTImporterOptionSpecificTestBase { You can create a similar descendant class, but with the MinimalImport flag set to true. Then you could

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 340482. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updates based on review feedback. Added tests for the source minimizer changes, thanks @dexonsmith! CHANGES SINCE LAST ACTION

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

aaron.ballman accepted this revision. aaron.ballman added a comment. Just one drive-by nit from me. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4119-4123 + if (LangOpts.SYCLIsDevice) { +if (!D || D->getType().getAddressSpace() == LangAS::Default) { + return

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil planned changes to this revision. jankratochvil added a comment. In D101236#2716286 , @teemperor wrote: > Not sure what the backtrace is for the `clang::FieldDecl::isZeroSize` crash > but what might relevant: That happens only with half

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

teemperor added a comment. Not sure what the backtrace is for the `clang::FieldDecl::isZeroSize` crash but what might relevant: 1. The ASTImporter test isn't using the 'Minimal' import mode that LLDB is using. In the tests we are importing all declarations directly. In LLDB we use the

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:5621 + // FIXME: NameAsWritten + ModMap.setUmbrellaHeader(CurrentModule, *Umbrella, Blob, ""); else if (CurrentModule->getUmbrellaHeader().Entry != *Umbrella) {

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

steakhal added a comment. This is an improvement! Good job. I had no time reviewing this, but I think it's already in a pretty good shape. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ https://reviews.llvm.org/D101041

[PATCH] D101168: [C++4OpenCL] Add clang extension for unsafe kernel parameters

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1804 +``__cl_clang_allow_unsafe_kernel_parameters`` +- How about `__cl_clang_unsafe_kernel_parameters` to match the other extension

[clang] 16dc9af - [RISCV] Add REQUIRES: riscv-registered-target for RISC-V test cases.

Author: Hsiangkai Wang Date: 2021-04-26T17:02:27+08:00 New Revision: 16dc9afa097d2577eff640f0fe9d388960c62cb9 URL: https://github.com/llvm/llvm-project/commit/16dc9afa097d2577eff640f0fe9d388960c62cb9 DIFF:

[PATCH] D101033: [clang-format] fix indent in alignChainedConditionals

This revision was automatically updated to reflect the committed changes. Closed by commit rG5987d7c59da5: [clang-format] fix indent in alignChainedConditionals (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101033/new/

[clang] 3c9bcf0 - [Clang][Coroutine][DebugInfo] Relax test ordering requirement

Author: Jeremy Morse Date: 2021-04-26T10:07:22+01:00 New Revision: 3c9bcf0e3549d89b31e19e67a5a16babdee2c72d URL: https://github.com/llvm/llvm-project/commit/3c9bcf0e3549d89b31e19e67a5a16babdee2c72d DIFF: https://github.com/llvm/llvm-project/commit/3c9bcf0e3549d89b31e19e67a5a16babdee2c72d.diff

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c9bcf0e3549: [Clang][Coroutine][DebugInfo] Relax test ordering requirement (authored by jmorse). Changed prior to commit:

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko updated this revision to Diff 340469. vsavchenko added a comment. Add one more testg covering the situation when we can't pick up that one region to associate with the value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko updated this revision to Diff 340473. vsavchenko added a comment. Refactor the way we get Region for variable declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ https://reviews.llvm.org/D101041 Files:

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. I have made a minor suggestion to testing that could be addressed in the final commit. Comment at: clang/test/Misc/nvptx.unsupported_core.cl:1 +// RUN:

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko updated this revision to Diff 340456. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 ___ cfe-commits mailing list

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; penagos wrote: > krasimir wrote: > >

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko updated this revision to Diff 340499. vsavchenko marked an inline comment as done. vsavchenko added a comment. Limit the number of cases where the new note refinement takes place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. We have discussed testing of headers within OpenCL developer community and wider: https://lists.llvm.org/pipermail/cfe-dev/2021-April/068040.html and the conclusions I have drawn are as follows: - There seem to be no big interest in improving upstream testing of

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 340461. jansvoboda11 added a comment. Rebase on top of D101051 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files:

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

DavidSpickett added a comment. I'd merge https://reviews.llvm.org/D100499 into this given that it's only one line. Comment at: clang/include/clang/Basic/arm_neon.td:712 + +// Crypto +// TODO:

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko marked 4 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1532 + // Telling the user that the value of 'a' is assigned to 'c', while + // correct, can be confusing. +

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2712534 , @azabaznov wrote: >> We could of course keep it just for this particular case of doubles, but >> even half is allowed in certain circumstances without the pragma and it is >> still an extension.

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. For me it looks good now. The changes, however, seem to be unrelated to retain count checker. Do you think it would make sense to upstream this patch independently from the other 3 patches

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 340478. jansvoboda11 added a comment. Fix clang-tidy warnings, add fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files:

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:909 If, // if/ifdef/ifndef Else // elif,else }; dexonsmith wrote: > Please add the two new cases to this comment as well. Good catch,

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic added a comment. The option was added in D19658 and D13979 , but I'm not sure how it is supposed to work for SystemV ABI. GCC emits an error if long double type is used with -mno-x87: "test.c:37:1: error: x87 register

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

Anastasia added a comment. In D99488#2716768 , @bader wrote: > Rebased patch to unblock commit. > > This patch had a dependency on D99190 , > which adds SYCLSupport.rst document. > To unblock commit of D99488

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

jdoerfert added a comment. In D100673#2716916 , @ABataev wrote: > In D100673#2714087 , @jdoerfert > wrote: > >> I think this broke GridMini >> (https://github.com/meifeng/GridMini/tree/openmp) :( > > Hmm, this

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov added a comment. @vsavchenko I make some tests and fixes. Please, consider. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:458 } if (event.key == "S") { var checked = document.getElementsByName("showCounterexample")[0].checked;

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic abandoned this revision. rsanthir.quic added a comment. Merging with https://reviews.llvm.org/D100772 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100499/new/ https://reviews.llvm.org/D100499 ___ cfe-commits mailing list

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

rsanthir.quic marked an inline comment as done. rsanthir.quic added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:712 + +// Crypto +// TODO: poly128_t not implemented on aarch32

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. I can land this for you, but could you update the description to be a bit more descriptive? Explaining what the warnings do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

fhahn added a comment. Probably would be good to split this up in separate LLVM/Clang parts. Do we need to auto-upgrade calls to `llvm.powi`? Comment at: llvm/docs/LangRef.rst:13280 +floating-point or vector of floating-point type. The type of the exponent +should typically

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope added a comment. Ping! (This patch is now 1 month old, has a number of reviewers and 41 subscribers, but not a single comment yet. I believe that if you aren't comfortable with reviewing, then it is perfectly OK to remove yourself as reveiwer to let the author know that the original set

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

xbolva00 added a comment. I think 16 bit int is same story as non 8-bit byte. There are places where we check for 32. Hard to say how many, what is the real scope of thiw change. if we allow 16bit int in upstream LLVM, we will just open door for non 8-bit byte.. Repository: rG LLVM Github

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

vsavchenko updated this revision to Diff 340544. vsavchenko added a comment. Add test for the case when there are no good alternatives Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100839/new/ https://reviews.llvm.org/D100839 Files:

[clang] e7b6c0f - [clang][XCore] Define __xcore__ for XCore target.

Author: Nigel Perks Date: 2021-04-26T15:06:04+01:00 New Revision: e7b6c0f398ee5975bf9f39e629713ae446e8fe01 URL: https://github.com/llvm/llvm-project/commit/e7b6c0f398ee5975bf9f39e629713ae446e8fe01 DIFF: https://github.com/llvm/llvm-project/commit/e7b6c0f398ee5975bf9f39e629713ae446e8fe01.diff

[PATCH] D100591: [Clang][AArch64] Disable rounding of return values for AArch64

asavonic updated this revision to Diff 340517. asavonic added a comment. Keep rounding of return values for big-endian targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100591/new/ https://reviews.llvm.org/D100591 Files:

[PATCH] D100591: [Clang][AArch64] Disable rounding of return values for AArch64

asavonic added a comment. In D100591#2711433 , @t.p.northover wrote: > On big-endian targets the rounding up to 64-bits (specified in the AAPCS) is > significant; it means that structs get passed in the high bits of `x0` rather > than low. E.g.

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 340528. bader added a comment. Rebase on ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files: clang/include/clang/AST/Type.h

[clang] 91db11c - XFAIL thinlto testcases on AIX

Author: Wael Yehia Date: 2021-04-26T17:02:06Z New Revision: 91db11c98db5de3e6079bddc0aba896ec3d3d0ad URL: https://github.com/llvm/llvm-project/commit/91db11c98db5de3e6079bddc0aba896ec3d3d0ad DIFF: https://github.com/llvm/llvm-project/commit/91db11c98db5de3e6079bddc0aba896ec3d3d0ad.diff LOG:

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4543 // getTypeAlignInChars requires complete types - if (ParamTy->isIncompleteType() || ArgTy->isIncompleteType() || - ParamTy->isUndeducedType() || ArgTy->isUndeducedType()) + auto CheckTypeOK

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 340527. adamcz added a comment. Added a fix in CreateRecoveryExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2716929 , @jdoerfert wrote: > In D100673#2716916 , @ABataev wrote: > >> In D100673#2714087 , @jdoerfert >> wrote: >> >>> I think this

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

rsanthir.quic updated this revision to Diff 340567. rsanthir.quic marked an inline comment as done. rsanthir.quic added a comment. minor fixes and merged https://reviews.llvm.org/D100499 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100772/new/ https://reviews.llvm.org/D100772 Files:

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 340526. bader added a comment. Rebased patch to unblock commit. This patch had a dependency on D99190 , which adds SYCLSupport.rst document. To unblock commit of D99488 , I switched the order

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb52e69c42681: [SYCL][Doc] Add design document for SYCL mode (authored by bader). Changed prior to commit:

[clang] b52e69c - [SYCL][Doc] Add design document for SYCL mode

Author: Alexey Bader Date: 2021-04-26T15:39:43+03:00 New Revision: b52e69c4268181d8143fe49aee0ea85395c8737d URL: https://github.com/llvm/llvm-project/commit/b52e69c4268181d8143fe49aee0ea85395c8737d DIFF: https://github.com/llvm/llvm-project/commit/b52e69c4268181d8143fe49aee0ea85395c8737d.diff

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. Please give the other reviewers time to chime in about this patch before merging. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99079/new/ https://reviews.llvm.org/D99079

[clang] b2bb13a - [Doc] Add SYCLSupport.rst to index toctree.

Author: Alexey Bader Date: 2021-04-26T16:16:10+03:00 New Revision: b2bb13a761644f675ec9f2d0b4371c51a05ab51c URL: https://github.com/llvm/llvm-project/commit/b2bb13a761644f675ec9f2d0b4371c51a05ab51c DIFF: https://github.com/llvm/llvm-project/commit/b2bb13a761644f675ec9f2d0b4371c51a05ab51c.diff

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2716973 , @ASDenysPetrov wrote: > @vsavchenko > I make some tests and fixes. Please, consider. OMG, that's so awesome! Thank you so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. I'm responding here after a ping on Bugzilla. The short version is I've stopped working on this patch. While I like the revised design that involves storing a list of tokens to make plugins even more powerful, this turned out to be a much bigger

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. bader marked an inline comment as done. Closed by commit rG7818906ca134: [SYCL] Implement SYCL address space attributes handling (authored by bader). Changed prior to

[clang] 7818906 - [SYCL] Implement SYCL address space attributes handling

Author: Alexey Bader Date: 2021-04-26T13:44:10+03:00 New Revision: 7818906ca134775edffb77857f436359d3a50b90 URL: https://github.com/llvm/llvm-project/commit/7818906ca134775edffb77857f436359d3a50b90 DIFF: https://github.com/llvm/llvm-project/commit/7818906ca134775edffb77857f436359d3a50b90.diff

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2714087 , @jdoerfert wrote: > I think this broke GridMini (https://github.com/meifeng/GridMini/tree/openmp) > :( Hmm, this app does not use mappers. Are you sure that this commit is the actual cause of the problem?

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. @NoQ, @steakhal, @vsavchenko I think we have met all the conditions with previous patchs to make this patch acceptable. If you think it's OK, could you, please, approve it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89055/new/

[PATCH] D101192: Add support for #elifdef and #elifndef

mibintc added a comment. Wow thanks for doing this! I worked on it a couple days a while ago but I abandoned the effort and went back to my day job. It seems like preprocessing ought to be something like a "state machine" but I couldn't figure out the mechanism. Would it make sense to add

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

rjmccall added a comment. Yes, if you can dynamically choose to use an aligned allocator, that's clearly just much better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100739/new/ https://reviews.llvm.org/D100739

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2717227 , @rjmccall wrote: > Yes, if you can dynamically choose to use an aligned allocator, that's > clearly just much better. Right now: Intrinsic::coro_size_aligned : overaligned frame: over-allocate, adjust

[clang] 50b523c - [AST] Fix DeclarationNameInfo introspection

Author: Stephen Kelly Date: 2021-04-26T18:49:13+01:00 New Revision: 50b523cb2ceee4ca7279b4ce22ddb0d0b05df313 URL: https://github.com/llvm/llvm-project/commit/50b523cb2ceee4ca7279b4ce22ddb0d0b05df313 DIFF: https://github.com/llvm/llvm-project/commit/50b523cb2ceee4ca7279b4ce22ddb0d0b05df313.diff

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. There's a lot going on here, but I don't see anything wrong. Thanks for the completeness of the tests and the comments, as that helps a lot in understanding what's going on here.

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 340598. mibintc added a reviewer: aaron.ballman. mibintc added a comment. Herald added subscribers: jansvoboda11, dexonsmith, lxfind, dang, kerbowa, kbarton, aheejin, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. I think this patch is

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope added inline comments. Comment at: llvm/test/Transforms/InstCombine/pow_fp_int16.ll:1 -; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple unknown -instcombine -S < %s | FileCheck %s +; RUN: opt -mtriple msp430 -instcombine -S <

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope added inline comments. Comment at: llvm/docs/LangRef.rst:13280 +floating-point or vector of floating-point type. The type of the exponent +should typically match the size of ``int``, at least when the intrinsic maps +to one of the ``__powi*`` functions in compiler-rt. Not

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added subscribers: jyknight, echristo. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion)

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song updated this revision to Diff 340650. yonghong-song added a comment. - use stripPointerCasts() to remove the cast of DeclRefExpr pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/ https://reviews.llvm.org/D100567

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340653. dgoldman marked 2 inline comments as done. dgoldman added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files:

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) nickdesaulniers wrote: > nickdesaulniers

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340652. nickdesaulniers added a comment. This revision is now accepted and ready to land. - add support for NPOT and negative offsets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; krasimir wrote: > penagos wrote: > >

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

dblaikie added a comment. (ah, sorry, failed to submit comment) Comment at: clang/lib/CodeGen/CGExpr.cpp:2843-2844 + CGDebugInfo *DI = CGM.getModuleDebugInfo(); + auto *Fn = dyn_cast(LV.getPointer(*this)); + if (DI && Fn && !Fn->getSubprogram()) +

[PATCH] D101317: hurd: Fix i386 research path

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. f26341840253 ("[Driver] Gnu.cpp: remove obsoleted i386 triple detection from

[PATCH] D94355: [Passes] Add relative lookup table converter pass

nathanchance added a comment. This patch breaks a two stage build with LTO: $ git bisect log # bad: [f0bc2782f281ca05221d2f1735bbaff6c4b81ebb] [TTI] NFC: Remove unused 'OptSize' parameter from shouldMaximizeVectorBandwidth # good: [9829f5e6b1bca9b61efc629770d28bb9014dec45] [CVP]

[PATCH] D99386: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

This revision was automatically updated to reflect the committed changes. Closed by commit rGa786f2badc41: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2844 + auto *Fn = + dyn_cast(LV.getPointer(*this)->stripPointerCasts()); + if (DI && !Fn->getSubprogram()) Oh, please change this to cast, rather than dyn_cast before

  1   2   3   >