[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

rsmith reopened this revision. rsmith added a comment. (Reopening, earlier commit was accidental.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101968/new/ https://reviews.llvm.org/D101968 ___

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101968/new/ https://reviews.llvm.org/D101968

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl updated this revision to Diff 344629. yaxunl edited the summary of this revision. yaxunl added a comment. fix lint warning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102270/new/ https://reviews.llvm.org/D102270 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D102303: [ASTMatchers] Fix formatting around forFunction().

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, xazax.hun, vsavchenko. Herald added subscribers: martong, rnkovacs. NoQ requested review of this revision. Isolated from D102213 . No functional change intended. Repository:

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO:

[PATCH] D102306: Add gfx1034

aakanksha555 created this revision. aakanksha555 added reviewers: msearles, kzhuravl, rampitec. Herald added subscribers: dexonsmith, kerbowa, rupprecht, hiraditya, nhaehnle, jvesely, arsenm, jholewinski. Herald added a reviewer: jhenderson. aakanksha555 requested review of this revision. Herald

[clang] bb72638 - Revert "Fix bad mangling of for a closure in the initializer of a variable at global namespace scope."

Author: Richard Smith Date: 2021-05-11T17:46:18-07:00 New Revision: bb726383ac7554857c62edd2d19e83dc713165ee URL: https://github.com/llvm/llvm-project/commit/bb726383ac7554857c62edd2d19e83dc713165ee DIFF: https://github.com/llvm/llvm-project/commit/bb726383ac7554857c62edd2d19e83dc713165ee.diff

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 344646. NoQ added a comment. Address comments. Yay, diff is no longer confused! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344666. smeenai added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D100919: [AArch64] Support customizing stack protector guard

dmgreen added a comment. I don't know a huge amount about stack protectors. It's worth adding -verify-machineinstrs to the tests, to check the code passes the internal checks. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1917 +.addDef(Reg) +

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 344269. shchenz marked an inline comment as done. shchenz added a comment. 1: address @dblaikie comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files:

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2748899 , @dblaikie wrote: > Does this cause duplicate DW_TAG_reference_types in the output, if the input > IR Has both DW_TAG_reference_type and DW_TAG_rvalue_reference_types? Yes, it will cause such issue in

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

dblaikie added a comment. In D100630#2749550 , @shchenz wrote: > In D100630#2748899 , @dblaikie > wrote: > >> Does this cause duplicate DW_TAG_reference_types in the output, if the input >> IR Has both

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

dblaikie added a comment. In D100630#2749625 , @shchenz wrote: > In D100630#2749594 , @dblaikie > wrote: > >> In D100630#2749550 , @shchenz >> wrote: >> >>> In

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2749594 , @dblaikie wrote: > In D100630#2749550 , @shchenz wrote: > >> In D100630#2748899 , @dblaikie >> wrote: >> >>> Does this

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 344300. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp llvm/test/DebugInfo/PowerPC/strict-dwarf-tags.ll Index:

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:398-399 + +// Assertion for other cases. +assert(true && "Tag is generated not following strict DWARF!"); + } dblaikie wrote: > side note: Not sure what this assertion

Re: [clang] e994e74 - [OpenCL] Add clang extension for non-portable kernel parameters.

Hi Tom, Thanks for letting me know. It has been fixed by https://github.com/llvm/llvm-project/commit/7d20f709ea6da8442a153beda7ecdda07440f046. And sorry for disruption. Anastasia From: Tom Stellard Sent: 11 May 2021 06:15 To: Anastasia Stulova ; Anastasia

[PATCH] D100919: [AArch64] Support customizing stack protector guard

DavidSpickett requested changes to this revision. DavidSpickett added a comment. This revision now requires changes to proceed. This is probably not showing up in review queues as it got accepted accidentally at some point. I'm going to "Request Changes" then I think you'll need to refresh the

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 344323. wingo added a comment. Update in response to parent commit changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files:

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7086af2143d: [WebAssembly] Support for WebAssembly globals in LLVM IR (authored by pmatos, committed by wingo). Repository: rG LLVM Github

[clang] d7086af - [WebAssembly] Support for WebAssembly globals in LLVM IR

Author: Paulo Matos Date: 2021-05-11T11:19:29+02:00 New Revision: d7086af2143d58a6535e0837c4d8789c69c6985f URL: https://github.com/llvm/llvm-project/commit/d7086af2143d58a6535e0837c4d8789c69c6985f DIFF: https://github.com/llvm/llvm-project/commit/d7086af2143d58a6535e0837c4d8789c69c6985f.diff

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

steveire added a comment. I'm not certain what strong opinions I've voiced on the mailing list about that. Was it just that I think `hasDescendant` can lead to unexpected matches and a more-specific matcher should always be used when available (such as `hasArgument`)? I do think `has`,

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires %2 support">; +def ext_opencl_double_without_pragma : Extension< + "Clang permits use of type 'double' regardless pragma if

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 344320. wingo added a comment. Rename "managed" address space to "wasm vars" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files:

[clang] 7d20f70 - [OpenCL] [NFC] Fixed underline being too short in rst

Author: Ole Strohm Date: 2021-05-11T09:45:28+01:00 New Revision: 7d20f709ea6da8442a153beda7ecdda07440f046 URL: https://github.com/llvm/llvm-project/commit/7d20f709ea6da8442a153beda7ecdda07440f046 DIFF: https://github.com/llvm/llvm-project/commit/7d20f709ea6da8442a153beda7ecdda07440f046.diff

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. In D102213#2750050 , @steveire wrote: > I'm not certain what strong opinions I've voiced on the mailing list about > that. Was it just that I think `hasDescendant` can lead to unexpected matches > and a more-specific matcher should

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

kadircet updated this revision to Diff 344289. kadircet marked an inline comment as done. kadircet added a comment. - Change logs to mention original limits. - Add the test i forgot first time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:152 +if (HasMore) + log("[public] Limiting result size for Lookup request."); LookupReply LastMessage; kbobyrev wrote: > nit (here and elsewhere):

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay marked an inline comment as done. MaskRay added a comment. In D102090#2749473 , @rnk wrote: > +1 to the idea, but I have no idea if this is the right cmake spot > > If we've decided to actually care about the shared library build, should we >

[PATCH] D102216: JSONLinkDatabase

Glebuska updated this revision to Diff 344301. Glebuska edited the summary of this revision. Glebuska added a comment. Updating D102216 : JSONLinkDatabase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102216/new/

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

jansvoboda11 added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101667/new/ https://reviews.llvm.org/D101667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101915: [clangd][remote-client] Set HasMore to true for failure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG888307ee625b: [clangd][remote-client] Set HasMore to true for failure (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 888307e - [clangd][remote-client] Set HasMore to true for failure

Author: Kadir Cetinkaya Date: 2021-05-11T08:22:24+02:00 New Revision: 888307ee625b50b060317e2100fb16e0be2626b7 URL: https://github.com/llvm/llvm-project/commit/888307ee625b50b060317e2100fb16e0be2626b7 DIFF:

[clang-tools-extra] daf3cb3 - [clangd][index-sever] Limit results in repsonse

Author: Kadir Cetinkaya Date: 2021-05-11T08:22:23+02:00 New Revision: daf3cb3b8a5868d9089a69025c556b564615b844 URL: https://github.com/llvm/llvm-project/commit/daf3cb3b8a5868d9089a69025c556b564615b844 DIFF:

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaf3cb3b8a58: [clangd][index-sever] Limit results in repsonse (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai marked 3 inline comments as done. smeenai added inline comments. Comment at: llvm/cmake/modules/LLVMDistributionSupport.cmake:39 +# default (unnamed) distribution. +set_property(GLOBAL PROPERTY LLVM_DISTRIBUTION_FOR_${target} " ") + endforeach()

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344299. smeenai added a comment. Uppercase variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D102216: JSONLinkDatabase

Glebuska created this revision. Glebuska requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102216 Files: clang/docs/JSONLinkDatabase.rst Index:

[clang] dfc1e31 - Produce warning for performing pointer arithmetic on a null pointer.

Author: Jamie Schmeiser Date: 2021-05-11T11:29:50-04:00 New Revision: dfc1e31d49fe1380c9bab43373995df5fed15e6d URL: https://github.com/llvm/llvm-project/commit/dfc1e31d49fe1380c9bab43373995df5fed15e6d DIFF:

[PATCH] D102244: [llvm][AsmPrinter] Restore source location to register clobber warning

DavidSpickett created this revision. Herald added a subscriber: hiraditya. DavidSpickett requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Since 5de2d189e6ad466a1f0616195e8c524a4eb3cbc0

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors

olestrohm updated this revision to Diff 344408. olestrohm added a comment. I tried to add a special case for 3 and 4 element vectors, but that caused issues in codgen, so I've left it as a FIXME for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101519/new/

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

JonChesterfield added a comment. I'm not so sure about that. With the other stuff in flight, it would let us build openmp apps from the clang build directory. That's useful for quicker build/debug cycles, as well as for lit tests that can be run by copying into a shell. At zero runtime cost

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100991/new/ https://reviews.llvm.org/D100991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

steakhal added a comment. Dam, we will be always haunted by these. Looks good btw. The test looks somewhat artificial - like a raw `creduce` result. Do you think It worth the effort to make it look like it was written by a human? I also somewhy prefer function parameters to globals for this

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

ABataev added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2082-2083 /// Otherwise, or if the condition is value-dependent, returns None. Optional getNondiscardedCase(const ASTContext ) const; + Optional getNondiscardedCase(const ASTContext );

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2750930 , @Everybody0523 wrote: > Minor nitpick, but is there a term that encompasses both the Z Vector syntax > and altivec? Since the test checks both Z and PPC it's a little odd that the > test's filename only

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

MaskRay added a comment. Agreed. This feels like a workaround. Can the offending projects be fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86881/new/ https://reviews.llvm.org/D86881 ___

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102251/new/ https://reviews.llvm.org/D102251

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

uweigand added a comment. In D102064#2751089 , @ZarkoCA wrote: > In D102064#2751001 , @uweigand > wrote: > >> This means the implementation now deviates from the documented vector >> extension syntax, right?

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman created this revision. aaron.ballman added reviewers: bader, erichkeane, jansvoboda11. Herald added subscribers: Naghasan, dexonsmith, dang, Anastasia, ebevhan, yaxunl. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, we have support for

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfc1e31d49fe: Produce warning for performing pointer arithmetic on a null pointer. (authored by jamieschmeiser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane created this revision. erichkeane added reviewers: yaxunl, bader, ABataev, aaron.ballman. erichkeane requested review of this revision. Herald added a project: clang. It doesn't really make sense to emit language specific diagnostics in a discarded statement, and suppressing these

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2082-2083 /// Otherwise, or if the condition is value-dependent, returns None. Optional getNondiscardedCase(const ASTContext ) const; + Optional getNondiscardedCase(const ASTContext );

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + aaron.ballman wrote: > dblaikie wrote: > > aaron.ballman wrote: > > > dblaikie wrote: > > > > hoy

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 added a comment. In D102134#2747649 , @aaron.ballman wrote: > Minor wordsmithing on the documentation changes, but more importantly: why is > the correct fix to the documentation as opposed to changing the default max > working group size?

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with few nits. Comment at: clang/lib/Sema/SemaExpr.cpp:17145 }; -if (Var && Var->hasGlobalStorage() && !IsEmittedOnDeviceSide(Var)) { - SemaRef.targetDiag(Loc,

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

tra accepted this revision. tra added a comment. LGTM for CUDA. This matches the intent of deferred diags -- we only emit them if we get to generate the code for the sources that triggered them, so they should not show up for the false constexpr branches. Repository: rG LLVM Github Monorepo

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:579 + defvar halfconst = !ne(half, "b"); + defvar halfconst = !if(!eq(half, "b"), 0, 1); craig.topper wrote: > Did you intend to leave the old lines commented

[PATCH] D101479: [Driver] Support libc++ in MSVC

amccarth added a comment. In D101479#2748475 , @mstorsjo wrote: > In D101479#2748189 , @amccarth > wrote: > >> In D101479#2733354 , @mstorsjo >> wrote: >> >>> Not sure

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2750765 , @amccarth wrote: > Ah, thanks for explaining that! In the VC++ stack, `/MD` and `/MT` make the > DLL/static choice for the CRT, the C++ standard library, and the compiler > runtime.[1] It never occurred

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

simon_tatham added a comment. For example, that's how I tested the refactoring in D72690 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Everybody0523 added a comment. Minor nitpick, but is there a term that encompasses both the Z Vector syntax and altivec? Since the test checks both Z and PPC it's a little odd that the test's filename only references altivec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Hi @njames93: Could you do me a favor? Because it is my first patch, something I'm not sure. I'm confused about can I land this patch now? I read the "LLVM Code-Review Policy and Practices" document, it said patches can be landed if received a LGTM, but seems you are

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 34. ASDenysPetrov added a comment. Minor performance improvement. Add more comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files:

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2751001 , @uweigand wrote: > This means the implementation now deviates from the documented vector > extension syntax, right? I guess it's strictly an extension of the > documented syntax, but that may still lead

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added a comment. In D102064#2751160 , @uweigand wrote: > In D102064#2751089 , @ZarkoCA wrote: > >> In D102064#2751001 , @uweigand >> wrote: >> >>> This means the

[clang] 0fd0a01 - [git-clang-format] Do not apply clang-format to symlinks

Author: Pirama Arumuga Nainar Date: 2021-05-11T10:34:40-07:00 New Revision: 0fd0a010a1ed2ce761d20bfc6378e5bbaa75c8de URL: https://github.com/llvm/llvm-project/commit/0fd0a010a1ed2ce761d20bfc6378e5bbaa75c8de DIFF:

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fd0a010a1ed: [git-clang-format] Do not apply clang-format to symlinks (authored by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/

[PATCH] D102244: [llvm][AsmPrinter] Restore source location to register clobber warning

DavidSpickett added a reviewer: ychen. DavidSpickett added a comment. This works as expected, let me know if this is the intended use relative to the changes you made. The existing test in llvm `llvm/test/CodeGen/AArch64/inline-asm-clobber.ll` never reported the location in the .ll file so I

[PATCH] D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. This fixes the implicit initialization that uses

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 344426. ZarkoCA edited the summary of this revision. ZarkoCA added reviewers: uweigand, neumannh. ZarkoCA added a comment. - clean up code per comments - Add test case for Z targets since that target is also affected Repository: rG LLVM Github Monorepo

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

uweigand added a comment. This means the implementation now deviates from the documented vector extension syntax, right? I guess it's strictly an extension of the documented syntax, but that may still lead to incompatibilities with other compilers for the platform. If we want to make such a

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

sanwou01 added subscribers: dmgreen, sanwou01. sanwou01 added a comment. Hi, we've got a ~6% regression in SPEC INT 2006 462.libquantum on AArch64 (both -flto and -Ofast) that comes back to this change. See here for a reproducer https://godbolt.org/z/dq98Gqqxn (-fno-vectorize is not strictly

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

nikic added a comment. In D101191#2751002 , @sanwou01 wrote: > Hi, we've got a ~6% regression in SPEC INT 2006 462.libquantum on AArch64 > (both -flto and -Ofast) that comes back to this change. See here for a > reproducer

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Everybody0523 added a comment. xlc on z/OS will compile vector _Bool char bc; on any language level high enough to recognize _Bool as a valid keyword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

ABataev added a comment. In D102251#2751226 , @erichkeane wrote: > In D102251#2751101 , @ABataev wrote: > >> LG > > Thanks! I'm going to give @yaxunl a day to take a look that this, > particularly since the

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane added a comment. In D102251#2751101 , @ABataev wrote: > LG Thanks! I'm going to give @yaxunl a day to take a look that this, particularly since the only test I could come up with was CUDA based. Repository: rG LLVM Github Monorepo

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

craig.topper added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:579 + defvar halfconst = !ne(half, "b"); + defvar halfconst = !if(!eq(half, "b"), 0, 1); Did you intend to leave the old lines commented out? Repository: rG LLVM

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

SilensAngelusNex updated this revision to Diff 344486. SilensAngelusNex added a comment. `T->` => `Loc.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102185/new/ https://reviews.llvm.org/D102185 Files:

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13ea238b1e1d: [OpenCL] Allow use of double type without extension pragma. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a

[clang] 13ea238 - [OpenCL] Allow use of double type without extension pragma.

Author: Anastasia Stulova Date: 2021-05-11T12:54:38+01:00 New Revision: 13ea238b1e1db96ef5fd409e869d9a8ebeef1332 URL: https://github.com/llvm/llvm-project/commit/13ea238b1e1db96ef5fd409e869d9a8ebeef1332 DIFF:

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

fhahn added a subscriber: effective-light. fhahn added a comment. Just FYI, `#pragma clang fp` support for matrix operations has been added in be2277fbf233 by @effective-light in the meantime. Repository: rG LLVM Github

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7563 + llvm::SmallVector Stack(Parents.begin(), Parents.end()); + while (!Stack.empty()) { +const auto = Stack.back(); The formatting changes are good, but

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > aaron.ballman wrote: > > dblaikie wrote: > > > hoy wrote: > > > > dblaikie

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan updated this revision to Diff 344396. urnathan edited the summary of this revision. urnathan edited reviewers, added: davrec; removed: Quuxplusone. urnathan added a comment. This update relies upon D101777 & D102239

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

tianshilei1992 requested changes to this revision. tianshilei1992 added a comment. This revision now requires changes to proceed. From my perspective, this is not a good direction. No need to bother Clang driver for one case of testing. `LIBRARY_PATH` needs to be set correctly by lit instead of

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:7331-7332 } -if (Next.getIdentifierInfo() == Ident_bool) { +if ((Next.getIdentifierInfo() == Ident_bool) || +Next.getIdentifierInfo() == Ident_Bool) {

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

JonChesterfield added a comment. More compelling than the testing case is that openmp is presently unusable without setting ld_library_path. This is part of fixing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101935/new/

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

tianshilei1992 added a comment. Unlike others, such as `/usr/local/lib` or `/usr/local/cuda`, it is not a standard place. It doesn't make too much sense to hardcode it in the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101935/new/

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

dmgreen added a reviewer: simon_tatham. dmgreen added a comment. Testing the inc files sounds good to me. There are also tests in places like clang/test/CodeGen/arm-mve-intrinsics that will test this, which seem to all be passing? Anything that does `#include ` Repository: rG LLVM Github

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

DavidSpickett added a comment. @ychen Since this change the warning emitted in `AsmPrinterInlineAsm.cpp` about reserved registers no longer has location information for the file that the inline asm is in. Here's an example: void bar(void) { __asm__ __volatile__ ( "nop" : : : "sp");

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently non-ODR-use of static device variable by host code causes static device variable to be emitted and registered, which should not. This patch fixes that.

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

pdhaliwal added a comment. This is not working as expected. And has resulted in broken libomptarget tests. Reverting this until I find a different fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102065/new/ https://reviews.llvm.org/D102065

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

DavidSpickett added a comment. Can you guide me on how I might correct this? Actually, now I see that MCContext has reportWarning/reportError and just needs a reportNote. I'll have something for you to review shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 344393. bader added a comment. Apply code review suggestions and rebase on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files: clang/docs/SYCLSupport.rst

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice, thanks! In D102185#2749279 , @steveire wrote: > Adding Yitzhak as a reviewer. I notice that at least the name of a > cxxBaseSpecifier is not

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

aaron.ballman added a comment. In D101790#2748474 , @NoQ wrote: > I completely agree with that as well, these are 100% true positives, which is > why I left them as fixmes. The reason why I think we can't have them is that > we don't have an

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, jansvoboda11, craig.topper, dblaikie. Herald added subscribers: dmgreen, kristof.beyls. Paul-C-Anagnostopoulos requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/test/SemaSYCL/address-space-conversions.cpp:74 + GLOB = GLOB_DEVICE; + GLOB_DEVICE = GLOB; // expected-error {{assigning '__global int *' to '__global_device int *' changes address space of

  1   2   >