[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a comment. Thanks! The last remaining question to me is whether this should be a target-specific option or whether it makes sense to allow it as an option for any target. Comment at: clang/include/clang/Basic/LangOptions.def:418-419

[PATCH] D101986: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ed7db0d206b: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains (authored by joechrisellis). Repository: rG LLVM Github

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

aaron.ballman added a comment. In general, I think this makes sense, but I'd like to hear from @delesley as well. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2198 +// For managed capabilities, the destructor should unlock in the right mode +// anyway. For asserted

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

vsavchenko added a comment. In D102240#2750976 , @steakhal wrote: > Dam, we will be always haunted by these. Yep, it was one place where we didn't expect a null state, but after one of the later patches, it became possible. 爛it's the final one. >

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

Szelethus closed this revision. Szelethus added a comment. Pushed this to the 12.0.0 release branch, just forgot to close it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 ___ cfe-commits mailing

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

Mordante added a comment. I tried to build the libc++ benchmarks locally and the benchmark with target `to_chars_libcxx` fails to properly execute. Bi-section let to this commit. Can the change in the linker flags affect libc++? I also see the scheduled builds of libc++ fail at Buildkite

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 345154. mibintc added a comment. I responded to most all @aaron.ballman 's review comments, may need a little more wordsmithing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/

[clang] 6a67e05 - [HIP] Add __builtin_amdgcn_groupstaticsize

Author: Aaron En Ye Shi Date: 2021-05-13T15:50:08Z New Revision: 6a67e05a26eb5f58665bd6d063b9f389e7dd28a7 URL: https://github.com/llvm/llvm-project/commit/6a67e05a26eb5f58665bd6d063b9f389e7dd28a7 DIFF: https://github.com/llvm/llvm-project/commit/6a67e05a26eb5f58665bd6d063b9f389e7dd28a7.diff

[PATCH] D102403: [HIP] Add __builtin_amdgcn_groupstaticsize

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a67e05a26eb: [HIP] Add __builtin_amdgcn_groupstaticsize (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 2ed7db0 - [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains

Author: Joe Ellis Date: 2021-05-13T16:09:50Z New Revision: 2ed7db0d206b6af2fffa4cb2704264b76ca61266 URL: https://github.com/llvm/llvm-project/commit/2ed7db0d206b6af2fffa4cb2704264b76ca61266 DIFF: https://github.com/llvm/llvm-project/commit/2ed7db0d206b6af2fffa4cb2704264b76ca61266.diff LOG:

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

Rin created this revision. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. Rin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

dmgreen added a comment. Sounds good. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:4134 -defm RBIT : SIMDTwoVectorB<1, 0b01, 0b00101, "rbit", int_aarch64_neon_rbit>; +//defm RBIT : SIMDTwoVectorB<1, 0b01, 0b00101, "rbit", int_aarch64_neon_rbit>; +defm RBIT

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

saudi updated this revision to Diff 344947. saudi added a comment. Updated for comments from @rnk, except for the canonicalization part. Are you suggesting that the `DependencyCollector` should be called with the already canonicalized paths? There are a few code paths leading to the

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2754542 , @njames93 wrote: > In D86671#2750957 , @dougpuob wrote: > >> Hi @njames93: >> Could you do me a favor? Because it is my first patch, something I'm not >> sure. I'm

[PATCH] D102406: [ARM][AArch64] Correct __ARM_FEATURE_CRYPTO macro and crypto feature

dcandler created this revision. dcandler added reviewers: t.p.northover, lenary. Herald added subscribers: danielkiss, kristof.beyls. dcandler requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch contains a couple of minor

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D102240#2756967 , @vsavchenko wrote: > I couldn't transform `c == b` into a condition, so it crashes. Well, that's interesting. It might

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2757179 , @v.g.vassilev wrote: > In D96033#2757107 , @v.g.vassilev > wrote: > >> In D96033#2757077 , >>

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/extend-arg-64.c:19 + +int vararg(int, ...); + mibintc wrote: > aaron.ballman wrote: > > Can you also add a test for K C functions? e.g., `int knr();` `sum = > > knr(sum, u32, s32, u16, s16, u8,

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

ostannard added a comment. There is also a test failure on the aarch64 2-stage bot (https://lab.llvm.org/buildbot/#/builders/7/builds/2720) which I've bisected to this change, so I'll revert it for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 92260d7 - Revert "[CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions"

Author: Oliver Stannard Date: 2021-05-13T14:31:17+01:00 New Revision: 92260d7a186425510e96b7036b467a6889d08d97 URL: https://github.com/llvm/llvm-project/commit/92260d7a186425510e96b7036b467a6889d08d97 DIFF:

[clang] 395607a - Reapply [ConstantFold] Fold more operations to poison

Author: Juneyoung Lee Date: 2021-05-13T16:04:12+02:00 New Revision: 395607af3cb80f25ee05420ea5ae0ad0be948533 URL: https://github.com/llvm/llvm-project/commit/395607af3cb80f25ee05420ea5ae0ad0be948533 DIFF: https://github.com/llvm/llvm-project/commit/395607af3cb80f25ee05420ea5ae0ad0be948533.diff

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2199 +// Take the exclusive capability to reduce further warnings. +return B.kind() == LK_Exclusive; + } else { aaron.ballman wrote: > The old code was looking at

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

vsavchenko updated this revision to Diff 345145. vsavchenko added a comment. Modify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102240/new/ https://reviews.llvm.org/D102240 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov updated this revision to Diff 345173. AndreyChurbanov added a comment. Fixed one more codegen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085 Files:

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Not blocking, but I'd add foo4 example from the description as a test case (with a link to the bug maybe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8fa168f - Parse vector bool when stdbool.h and altivec.h are included

Author: Zarko Todorovski Date: 2021-05-13T11:48:32-04:00 New Revision: 8fa168fc50ba4f63b79773c947ef5b3e43d5c02f URL: https://github.com/llvm/llvm-project/commit/8fa168fc50ba4f63b79773c947ef5b3e43d5c02f DIFF:

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa168fc50ba: Parse vector bool when stdbool.h and altivec.h are included (authored by ZarkoCA). Changed prior to commit:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2757077 , @hubert.reinterpretcast wrote: > @v.g.vassilev, the test does not appear to be appropriately set up for builds > that default to a non-native target: >

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2757107 , @v.g.vassilev wrote: > In D96033#2757077 , > @hubert.reinterpretcast wrote: > >> @v.g.vassilev, the test does not appear to be appropriately set up for >> builds

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. In D101640#2757039 , @aaron.ballman wrote: > Thanks! The last remaining question to me is whether this should be a > target-specific option or whether it makes sense to allow it as an option for > any target. I thought the

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

aaronpuchert added a comment. Ping @aaron.ballman, also for the parent change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102026/new/ https://reviews.llvm.org/D102026 ___ cfe-commits mailing list

[PATCH] D102191: [PowerPC] Add clang option -m[no-]prefixed

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102191/new/ https://reviews.llvm.org/D102191

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

aganea added a comment. In D102339#2755867 , @thakis wrote: > We share obj files built on linux and on windows. So that's a goal for us. Hello @thakis, I believe you don't use this codepath to generate the cache key, do you? I thought you had a custom

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I second that ColumnLimit breaking test case. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102392/new/ https://reviews.llvm.org/D102392

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Everybody0523 added a comment. Expected Z behavior LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2199 +// Take the exclusive capability to reduce further warnings. +return B.kind() == LK_Exclusive; + } else { The old code was looking at `LDat1.kind() !=

[PATCH] D102337: [clang-tidy] Fix test that requires Windows platofrm

This revision was automatically updated to reflect the committed changes. Closed by commit rGe07753c8814d: [clang-tidy] Fix test that requires Windows platofrm (authored by jubnzv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102337/new/

[clang-tools-extra] e07753c - [clang-tidy] Fix test that requires Windows platofrm

Author: Georgy Komarov Date: 2021-05-13T15:51:53+03:00 New Revision: e07753c8814dba100dcae44e2b47947b340ad0e8 URL: https://github.com/llvm/llvm-project/commit/e07753c8814dba100dcae44e2b47947b340ad0e8 DIFF:

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Analysis/ThreadSafety.cpp:2199 +// Take the exclusive capability to reduce further warnings. +return B.kind() ==

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

thakis added a comment. In D102339#2756726 , @aganea wrote: > In D102339#2755867 , @thakis wrote: > >> We share obj files built on linux and on windows. So that's a goal for us. > > Hello @thakis, I believe you

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. @v.g.vassilev, the test does not appear to be appropriately set up for builds that default to a non-native target: https://lab.llvm.org/staging/#/builders/126/builds/371/steps/5/logs/FAIL__Clang__execute_cpp Can you fix or revert until there is a fix?

[PATCH] D102418: [clangd] Always default to raw pch format

kadircet created this revision. kadircet added a reviewer: adamcz. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Clang would emit a fatal error

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added a subscriber: marco-c. MaskRay added a comment. In D102090#2756605 , @Mordante wrote: > I tried to build the libc++ benchmarks locally and the benchmark with target > `to_chars_libcxx` fails to properly execute. Bi-section let to this

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 345220. NoQ added a comment. Make examples for `forCallable()` more relatable given that the original matcher is now deprecated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files:

[clang] 8ec9fd4 - Support unwinding from inline assembly

Author: cynecx Date: 2021-05-13T19:13:03+01:00 New Revision: 8ec9fd483949ca3b23053effcac226dcc56e7a95 URL: https://github.com/llvm/llvm-project/commit/8ec9fd483949ca3b23053effcac226dcc56e7a95 DIFF: https://github.com/llvm/llvm-project/commit/8ec9fd483949ca3b23053effcac226dcc56e7a95.diff LOG:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith accepted this revision. asmith added a comment. Thanks everyone for the great feedback! We'll move forward with landing this first patch and start the review of the next one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/

[PATCH] D102431: [clangd][QueryDriver] Dont check for existence of driver

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Execute implementations already

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Something unrelated might be wrong with the test because I can reproduce the MachineVerifier issue (liveins + non-entry/landingpad) on llvm-stable (11.1) and even without the inline-asm call (replaced by a normal invoke to the target). Repository: rG LLVM Github

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. https://reviews.llvm.org/D102433 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. In D102213#2756254 , @vsavchenko wrote: >> Additionally, forCallable(functionDecl()) is not equivalent to forFunction() >> (the former silently matches less stuff). > > I'm not sure I understand this one. Can you please show an

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a comment. In D101640#2757178 , @mibintc wrote: > In D101640#2757039 , @aaron.ballman > wrote: > >> Thanks! The last remaining question to me is whether this should be a >> target-specific

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

aaron.ballman added a comment. In D102213#2755064 , @NoQ wrote: > I'm also mildly worried that Function is not the technically correct term. > Maybe we should mark the old matcher as deprecated instead? Thank you for the explanations as to why there's

[clang] 45212de - [analyzer][solver] Prevent use of a null state

Author: Valeriy Savchenko Date: 2021-05-13T20:16:29+03:00 New Revision: 45212dec01b9be90596d8d6fa7586ce8c84e2622 URL: https://github.com/llvm/llvm-project/commit/45212dec01b9be90596d8d6fa7586ce8c84e2622 DIFF:

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. I would be great if someone with commit rights could push this through since I don't have commit rights :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745

[PATCH] D95745: Support unwinding from inline assembly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ec9fd483949: Support unwinding from inline assembly (authored by cynecx, committed by Amanieu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:581 RTLIB::POWI_F128, RTLIB::POWI_PPCF128); if (!TLI.getLibcallName(LC)) { bjope wrote: >

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

MaskRay updated this revision to Diff 345264. MaskRay retitled this revision from "[CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions" to "[CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions". MaskRay edited the summary of this revision. MaskRay added a

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a comment. > I took another look. I think the divergence comes from > getAs vs hasPrototype. The debug data generation uses > hasPrototype while getAs is used as overloadable attribute > processing as long as unique linkage name processing before this change. More >

[PATCH] D88220: [C++20] P1825R0: More implicit moves

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3226-3227 +CopyElisionSemanticsKind CESK = CES_Strict; +if (getLangOpts().CPlusPlus20) { + CESK = CES_ImplicitlyMovableCXX20; +} else if (getLangOpts().CPlusPlus11) { P1825

[clang] a624cec - [Clang][Codegen] Do not annotate thunk's this/return types with align/deref/nonnull attrs

Author: Roman Lebedev Date: 2021-05-13T20:33:08+03:00 New Revision: a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4 URL: https://github.com/llvm/llvm-project/commit/a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4 DIFF: https://github.com/llvm/llvm-project/commit/a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4.diff

[clang] 70aa462 - [NFC][Clang][Codegen] Add tests with wrong attributes on this/return of thunks

Author: Roman Lebedev Date: 2021-05-13T20:32:40+03:00 New Revision: 70aa4623de9fe2f609eab8969d7ef76b4c80084b URL: https://github.com/llvm/llvm-project/commit/70aa4623de9fe2f609eab8969d7ef76b4c80084b DIFF: https://github.com/llvm/llvm-project/commit/70aa4623de9fe2f609eab8969d7ef76b4c80084b.diff

[PATCH] D102306: Add gfx1034

aakanksha555 updated this revision to Diff 345226. Herald added a subscriber: emaste. Herald added a reviewer: MaskRay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102306/new/ https://reviews.llvm.org/D102306 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp

[clang] 9d3eb78 - [NFC] Try to fix CodeGenCXX/thunk-wrong-this.cpp test

Author: Roman Lebedev Date: 2021-05-13T21:10:14+03:00 New Revision: 9d3eb7885d916b22bc673334f71a10e3b2835174 URL: https://github.com/llvm/llvm-project/commit/9d3eb7885d916b22bc673334f71a10e3b2835174 DIFF: https://github.com/llvm/llvm-project/commit/9d3eb7885d916b22bc673334f71a10e3b2835174.diff

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

leonardchan added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3293 +static bool SupportsRelativeCXXVTables(const llvm::Triple ) { + return T.isOSFuchsia(); +} phosek wrote: > Could we instead enable it inside `FuchsiaCXXABI`? So we

[clang] 464e4dc - [AMDGPU] Add gfx1034 target

Author: Aakanksha Patil Date: 2021-05-13T14:25:18-04:00 New Revision: 464e4dc50f4e6e058e12a7020385d5bf29fd1df6 URL: https://github.com/llvm/llvm-project/commit/464e4dc50f4e6e058e12a7020385d5bf29fd1df6 DIFF:

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a079dfdc992: [ASTMatchers] Add forCallable(), a generalization of forFunction(). (authored by dergachev.a). Herald added a project: clang.

[PATCH] D102214: [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46c6c08c9428: [clang-tidy] bugprone-infinite-loop: forFunction() - forCallable(). (authored by dergachev.a). Repository: rG LLVM Github Monorepo

[PATCH] D102306: Add gfx1034

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG464e4dc50f4e: [AMDGPU] Add gfx1034 target (authored by aakanksha555). Herald added a project: OpenMP. Herald added a subscriber: openmp-commits.

[clang] dd98ea5 - [ASTMatchers] NFC: Fix formatting around forFunction().

Author: Artem Dergachev Date: 2021-05-13T11:25:00-07:00 New Revision: dd98ea528c0c23f5fee6d3dbafc261b81cca9f0d URL: https://github.com/llvm/llvm-project/commit/dd98ea528c0c23f5fee6d3dbafc261b81cca9f0d DIFF:

[clang] 6a079df - [ASTMatchers] Add forCallable(), a generalization of forFunction().

Author: Artem Dergachev Date: 2021-05-13T11:25:00-07:00 New Revision: 6a079dfdc992706408f2bde84c48bf76e52c4311 URL: https://github.com/llvm/llvm-project/commit/6a079dfdc992706408f2bde84c48bf76e52c4311 DIFF:

[PATCH] D102303: [ASTMatchers] Fix formatting around forFunction().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd98ea528c0c: [ASTMatchers] NFC: Fix formatting around forFunction(). (authored by dergachev.a). Herald added a project: clang. Repository: rG

[clang-tools-extra] 46c6c08 - [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

Author: Artem Dergachev Date: 2021-05-13T11:25:01-07:00 New Revision: 46c6c08c9428a36bdf88f51b1a14164aa4cbb93e URL: https://github.com/llvm/llvm-project/commit/46c6c08c9428a36bdf88f51b1a14164aa4cbb93e DIFF:

[clang-tools-extra] 5ad2eee - [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages.

Author: Artem Dergachev Date: 2021-05-13T11:25:02-07:00 New Revision: 5ad2eeeadaf15856332f66ed7c244d52a86b0be7 URL: https://github.com/llvm/llvm-project/commit/5ad2eeeadaf15856332f66ed7c244d52a86b0be7 DIFF:

[PATCH] D102294: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages in condition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad2eeeadaf1: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages. (authored by dergachev.a). Changed prior to commit:

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 345273. mibintc added a comment. Corrected the failing lit test and applied the clang-format patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 Files:

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:313 + Builder.defineMacro("__UINT16_TYPE__", "unsigned int"); + Builder.defineMacro("__INT16_TYPE__", "int"); Redefining `__INT16_TYPE__` like this is unusual. The macro is normally

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

tra added a comment. In D100124#2757251 , @steffenlarsen wrote: > @tra Thanks a ton for the review! This is my first LLVM patch so I only know > as much as the Code Review documentation tells me. Is there a process for > chasing up additional reviews?

[PATCH] D101672: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c57a9bd7d4c: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC (authored by dexonsmith). Repository: rG LLVM Github

[clang] 7c57a9b - Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:39:40-07:00 New Revision: 7c57a9bd7d4c976b7a824472c427433359200e02 URL: https://github.com/llvm/llvm-project/commit/7c57a9bd7d4c976b7a824472c427433359200e02 DIFF:

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

NoQ added a comment. Thx for the fix! In D102240#2757223 , @steakhal wrote: > In D102240#2756967 , @vsavchenko > wrote: > >> I couldn't transform `c == b` into a condition, so it crashes. > > Well, that's

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Hmm, there is build-failure when buildbot is running extended tests (MachineVerifier): https://lab.llvm.org/buildbot/#/builders/16/builds/10825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

eugenis added inline comments. Comment at: clang/include/clang/Driver/Options.td:4172 +// on x86_64 and is subject to change in the future. For example, we may want +// to distinguish between LAM48 and LAM57 at some point. +def mlam : Flag<["-"], "mlam">, Group;

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added a comment. In D98799#2757959 , @dblaikie wrote: >> I took another look. I think the divergence comes from >> getAs vs hasPrototype. The debug data generation uses >> hasPrototype while getAs is used as overloadable >> attribute processing as

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

lhames added a comment. In D96033#2757222 , @hubert.reinterpretcast wrote: > ... > I have a local build I can apply a patch to. Hi Hubert, Could you apply the following patch and let me know the output from the failing test? I'm trying to work out

[clang] 23e9146 - Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:22:40-07:00 New Revision: 23e9146fba298d38142337b615e17067fb8ccb91 URL: https://github.com/llvm/llvm-project/commit/23e9146fba298d38142337b615e17067fb8ccb91 DIFF:

[PATCH] D101670: Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23e9146fba29: Modules: Rename ModuleBuildFailed = DisableGeneratingGlobalModuleIndex, NFC (authored by dexonsmith). Repository: rG LLVM Github

[PATCH] D102214: [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Now, when we are done with `forCallable`, let's get to this one. It looks great to me, thanks for fixing it! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D102306: Add gfx1034

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102306/new/ https://reviews.llvm.org/D102306 ___ cfe-commits mailing list

[clang] 0d8f91d - [NFC] Delete two newly-added test cases

Author: Roman Lebedev Date: 2021-05-13T21:23:01+03:00 New Revision: 0d8f91d2a9994619bb62c548a81eb605f0e768f7 URL: https://github.com/llvm/llvm-project/commit/0d8f91d2a9994619bb62c548a81eb605f0e768f7 DIFF: https://github.com/llvm/llvm-project/commit/0d8f91d2a9994619bb62c548a81eb605f0e768f7.diff

[clang] a249ffa - [HIP] Clean up llvm intrinsics using __asm

Author: Aaron En Ye Shi Date: 2021-05-13T18:55:51Z New Revision: a249ffa42137431d44d7db1d04f122300bc51533 URL: https://github.com/llvm/llvm-project/commit/a249ffa42137431d44d7db1d04f122300bc51533 DIFF: https://github.com/llvm/llvm-project/commit/a249ffa42137431d44d7db1d04f122300bc51533.diff

[PATCH] D102427: [HIP] Clean up llvm intrinsics using __asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa249ffa42137: [HIP] Clean up llvm intrinsics using __asm (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. In D101640#2757316 , @aaron.ballman wrote: > In D101640#2757178 , @mibintc wrote: > >> In D101640#2757039 , >> @aaron.ballman wrote: >> >>>

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In D101640#2757815 , @mibintc wrote: > In D101640#2757316 , @aaron.ballman > wrote: > >> In D101640#2757178

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay reopened this revision. MaskRay added a comment. This revision is now accepted and ready to land. I'll go simple - just drop -fno-semantic-interposition from this patch, as I cannot figure out how to make -fno-semantic-interposition specific to llvm/ and clang/. -Bsymbolic-functions

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3226-3227 +CopyElisionSemanticsKind CESK = CES_Strict; +if (getLangOpts().CPlusPlus20) { + CESK = CES_ImplicitlyMovableCXX20; +} else if (getLangOpts().CPlusPlus11) {

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen added a comment. In D100124#2757306 , @tra wrote: > Do you have ability to commit to LLVM? If not, I can land the patch on your > behalf. Not to my knowledge, so please do. Thanks again! https://reviews.llvm.org/D100394 is from my

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

This revision was automatically updated to reflect the committed changes. Closed by commit rG45212dec01b9: [analyzer][solver] Prevent use of a null state (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102240/new/

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 345208. NoQ marked 2 inline comments as done. NoQ added a comment. Address review comments. Add a deprecation notice to `forFunction()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files:

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7597 +/// but does not match 'int y = 2'. +AST_MATCHER_P(Stmt, forCallable, internal::Matcher, InnerMatcher) { + const auto = Finder->getASTContext().getParents(Node);

  1   2   >