[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. Thanks, the build is also passing now so I will land this in a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 ___ cfe-commits

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. In D93525#2838535 , @yaxunl wrote: > LGTM. Thanks! Pls make sure it passes internal CI (ePSDB) before committing. Sure, I will take care of it. Thanks! Any comments @jdoerfert ? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! Pls make sure it passes internal CI (ePSDB) before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM,thanks. Comment at: clang/docs/LanguageExtensions.rst:546 + +The matrix type extension supports compound assignments for addition, subtraction, and multiplication

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 ___ cfe-commits mailing list

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2838468 , @thopre wrote: > Are you planning to do this for the other FP test builtin (isinf, isfinite, > isinf_sign, isnormal)? Yes, they have similar problems. If someone would like to implement them it would be

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. In D104616#2835061 , @xazax.hun wrote: > In D104616#2835030 , @RedDocMD > wrote: > >> Looks like I have wasted a good deal of effort. :( > > Sorry about that! :( If we learned anything

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Are you planning to do this for the other FP test builtin (isinf, isfinite, isinf_sign, isnormal)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854

[PATCH] D97204: [RFC] Clang 64-bit source locations

simon_tatham added a comment. Hmmm. Two people have pointed out to me that my strategy of having a 32-bit `SourceLocations::LowBits` and an 0- or 32-bit `SourceLocations::OptionalHighBits` doesn't actually work, because an empty struct still takes at least 1 byte. So this version of the patch

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff created this revision. sepavloff added reviewers: efriedma, kpn, thopre, jonpa, cameron.mcinally, RKSimon, craig.topper. Herald added subscribers: jdoerfert, pengfei, hiraditya. sepavloff requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 354232. SaurabhJha added a comment. Rebase with latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst Index:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 354231. SaurabhJha added a comment. Address round 2 comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst Index:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. In D104198#2838416 , @SaurabhJha wrote: > Somehow the builds are failing even though this patch contains no code > changes. There a few reasons as to why the tests may fail unrelated to the patch (flaky tests, infrastructure

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. Somehow the builds are failing even though this patch contains no code changes. Comment at: clang/docs/LanguageExtensions.rst:526 +The matrix type extension also supports operations between a matrix and a scalar. + fhahn wrote: >

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 354229. whisperity added a comment. **NC** Rebase and buildbot trigger. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97297/new/ https://reviews.llvm.org/D97297 Files:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. Thanks for the latest changes! Comment at: clang/docs/LanguageExtensions.rst:526 +The matrix type extension also supports operations between a matrix and a scalar. + I'm not a native speaker, but I am not sure if `between` is the best

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov updated this revision to Diff 354225. ASDenysPetrov added a comment. Added assertions. Added two helper functions for `castTo` method. Moved some distinct code to them. Fixed clang-tidy complaints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/AST/ASTContext.cpp:2570-2571 +getSubobjectSizeInBits(const FieldDecl *Field, const ASTContext ) { + if (Field->getType()->isRecordType()) { +const RecordDecl *RD =

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 354218. whisperity added a comment. **NC** Rebase & more buildbot shenanigans so we can get a pass! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78652/new/ https://reviews.llvm.org/D78652 Files:

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

MyDeveloperDay added a comment. @HazardyKnusperkek Its probably my "bad" I should said "LGTM but maybe wait for the others to comment", but I'm fundamentally ok I think with the change. (we'll just revert if it breaks stuff! ;-)) We are free to add review comments after the fact, @owenpan has

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 354210. whisperity added a comment. **NC** Rebase, buildbots, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75041/new/ https://reviews.llvm.org/D75041 Files:

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

steffenlarsen created this revision. steffenlarsen added a reviewer: tra. Herald added subscribers: hiraditya, yaxunl, jholewinski. steffenlarsen requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Adds NVPTX

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay updated this revision to Diff 354205. MyDeveloperDay added a comment. Fix `parseBracedList()` to do what `parseStructuralElement()` does (with regard to breaking `AfterFunction`, I'm not completely convinced `AfterFunction` should have been reused for that but might be too late

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + I don't like the idea of duplicating it into every `assume` method.

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo updated this revision to Diff 354178. mstorsjo added a comment. Reduced this patch only to updating of the StringRef class itself and its unit test, removing the mechanical changes. Removed superfluous method name duplication in doxygen comments. Repository: rG LLVM Github Monorepo

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo added a comment. In D104819#2837421 , @dexonsmith wrote: > Given how large this is, would it be reasonable to split this up a bit more? > > What I might do if this were my patch: get a review of the API change + the > manual changes in one

[PATCH] D104804: [AMDGPU] Add gfx1035 target

foad added inline comments. Comment at: clang/test/Driver/amdgpu-mcpu.cl:138 // GFX1034: "-target-cpu" "gfx1034" +// GFX1034: "-target-cpu" "gfx1035" Typo in check prefix. Why didn't this make the test fail? Comment at:

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

MaskRay added inline comments. Comment at: llvm/include/llvm/ADT/StringRef.h:192 -/// equals_lower - Check for string equality, ignoring case. +/// equals_insensitive - Check for string equality, ignoring case. LLVM_NODISCARD

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2837136 , @mstorsjo wrote: > In D104556#2837104 , @rnk wrote: > >> Swift wanted the same thing, so I think the answer is yes, we should ask. > > What would the benefit of that

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

dexonsmith added a comment. Given how large this is, would it be reasonable to split this up a bit more? What I might do if this were my patch: get a review of the API change + the manual changes in one patch (assuming there aren't many manual changes), then land the remaining mechanical

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

aaron.ballman added a comment. In D104777#2837794 , @dblaikie wrote: > In D104777#2837347 , @brunodefraine > wrote: > >> In D104777#2836669 , @dblaikie >> wrote: >> >>>

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity updated this revision to Diff 354203. whisperity added a comment. **NC** Fix lint mishap that occurred during previous rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96355/new/ https://reviews.llvm.org/D96355 Files:

[PATCH] D90399: [clang-tidy] non-portable-integer-constant check

whisperity added inline comments. Herald added a subscriber: cfe-commits. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:38 #include "NoEscapeCheck.h" +#include "NonportableintegerconstantCheck.h" #include "NotNullTerminatedResultCheck.h"

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 354197. saiislam added a comment. Generalized padding of Triple fields of Bundle Entry ID while generating command for clang-offload-bundler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/

[clang] c5028f3 - [Clang] XFAIL sanitize-coverage-old-pm.c on 32bit Armv8l

Author: Muhammad Omair Javaid Date: 2021-06-24T15:48:13+05:00 New Revision: c5028f3473ed50a7433fe278984cd1a755b338b9 URL: https://github.com/llvm/llvm-project/commit/c5028f3473ed50a7433fe278984cd1a755b338b9 DIFF:

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 354193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseTemplate.cpp

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity updated this revision to Diff 354192. whisperity added a comment. **NC!** Recreate diff to try and get the buildbots running... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96355/new/ https://reviews.llvm.org/D96355 Files:

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

whisperity added a comment. //Gentle boop.// Bugzilla is offline for me right now (and rumour has it that it will be completely shut down in the near future), so it would be good to know what is the status of this patch and how it related to the mentioned (and //right now// unavailable) bug

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); vsavchenko wrote: >

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. In D103314#2838065 , @martong wrote: > In D103314#2837907 , @uabelho wrote: > >> Hi, >> >> Another failed assertion that started appearing with this patch: >> >> clang --analyze

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong created this revision. martong added reviewers: vsavchenko, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

whisperity updated this revision to Diff 354183. whisperity added a comment. **NFC** Fix lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736 Files:

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 354180. whisperity added a comment. (Uploaded the prerequisite, wrong patch here by accident.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75041/new/ https://reviews.llvm.org/D75041 Files:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); manas wrote: >

[PATCH] D104843: [clangd] Introduce a log-prefix flag to remote-index-server

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko added a comment. In D103314#2838065 , @martong wrote: > In D103314#2837907 , @uabelho wrote: > >> Hi, >> >> Another failed assertion that started appearing with this patch: >> >> clang --analyze

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Just a ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. In D103314#2837907 , @uabelho wrote: > Hi, > > Another failed assertion that started appearing with this patch: > > clang --analyze bbi-57589.c > > which results in: > > clang: ../lib/Support/APInt.cpp:284: int

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); vsavchenko wrote: >

[PATCH] D104381: [analyzer] Added a test case for PR46264

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe76c008c906a: [analyzer] Added a test case for PR46264 (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] e76c008 - [analyzer] Added a test case for PR46264

Author: Denys Petrov Date: 2021-06-24T12:24:26+03:00 New Revision: e76c008c906af3dc093dd5c3ceaea577359b5432 URL: https://github.com/llvm/llvm-project/commit/e76c008c906af3dc093dd5c3ceaea577359b5432 DIFF: https://github.com/llvm/llvm-project/commit/e76c008c906af3dc093dd5c3ceaea577359b5432.diff

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); manas wrote: >

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas marked an inline comment as not done. manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(),

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); manas wrote: >

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 354167. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 354166. whisperity added a comment. Attempt to fix build failure on Windows buildbot (`operator new` was taking `unsigned long` instead of `size_t` in a test which resulted in hard error). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

frasercrmck added a comment. What's supposed to happen if the provided index is invalid? I'm suspecting we'd currently get a IR verification error on the insert/extract indices. I'm wondering if we can/should catch that earlier? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2835147 , @ychen wrote: > In D97915#2832667 , @ChuanqiXu wrote: > >> In D97915#2832446 , @ychen wrote: >> >>> In D97915#2829581

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

uabelho added a comment. Hi, Another failed assertion that started appearing with this patch: clang --analyze bbi-57589.c which results in: clang: ../lib/Support/APInt.cpp:284: int llvm::APInt::compareSigned(const llvm::APInt &) const: Assertion `BitWidth == RHS.BitWidth && "Bit widths

[PATCH] D104841: [clangd] Call malloc_trim in clangd-index-server periodically

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

<    1   2