[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, manas, NoQ, vsavchenko. Herald added subscribers: gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer:

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

steakhal added a comment. Please mark both of them `LLVM_DUMP_METHOD`s. This way they will be stripped from release builds according to their documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110911/new/

[PATCH] D110398: [clang][ASTImporter] Import ConstructorUsingShadowDecl correctly.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcad9ff531c71: [clang][ASTImporter] Import ConstructorUsingShadowDecl correctly. (authored by balazske). Repository: rG LLVM Github Monorepo

[clang] cad9ff5 - [clang][ASTImporter] Import ConstructorUsingShadowDecl correctly.

Author: Balázs Kéri Date: 2021-10-01T11:41:08+02:00 New Revision: cad9ff531c71e7c28d7bd5a64a26f9b214156b59 URL: https://github.com/llvm/llvm-project/commit/cad9ff531c71e7c28d7bd5a64a26f9b214156b59 DIFF: https://github.com/llvm/llvm-project/commit/cad9ff531c71e7c28d7bd5a64a26f9b214156b59.diff

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers added a comment. I moved the test cases from ptr-arith.cpp to ptr-arith - using to typedef, and created an extra test case that uses const. I believe this may address all concerns discussed thus far? Please let me know if we need anything more and I'll get it done. Best!

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376453. vabridgers added a comment. add const test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cpp

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376452. vabridgers added a comment. move test case from cpp file to c file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files:

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376450. vabridgers added a comment. added typedef case to C file for comparison, discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files:

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

ASDenysPetrov added a comment. In D110625#3035616 , @steakhal wrote: > 'using' is the same as 'typedef' AFAIK. > So, you could simply use only typedefs and implement the test in the c test > file. Seeing all the tests close together would aid

[PATCH] D110911: [analyzer][NFC] Add RangeSet::dump

martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, manas, NoQ, vabridgers. Herald added subscribers: gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer:

[PATCH] D110395: [clang][ASTImporter] Import InheritedConstructor and ConstructorUsingShadowDecl.

steakhal added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5880 +AST_MATCHER(CXXConstructorDecl, isInheritingConstructor) { + return Node.isInheritingConstructor(); We need to add doc comments as well. Please address this.

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

martong created this revision. martong added reviewers: ASDenysPetrov, steakhal, manas, vsavchenko, NoQ. Herald added subscribers: gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer:

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

steakhal added a subscriber: aaron.ballman. steakhal added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8530-8531 + // Get the result of the previous import attempt (can be used only once). + llvm::Expected getResult() { +if (Err) If it can

[PATCH] D110825: [clangd] Handle members of anon structs in SelectionTree

kadircet updated this revision to Diff 376445. kadircet marked 2 inline comments as done. kadircet added a comment. - update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110825/new/ https://reviews.llvm.org/D110825 Files:

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

balazske updated this revision to Diff 376443. balazske marked an inline comment as done. balazske added a comment. Update the code comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110810/new/ https://reviews.llvm.org/D110810 Files:

Re: [llvm-dev] Phabricator Creator Pulling the Plug

+1 to the review experience in Github being far worse than Phabricator, with basically all my specific concerns already being covered in this thread. I just wanted to add that our downstream LLVM port is based in a local Github Enterprise instance, and I find it far harder to review and respond to

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

balazske updated this revision to Diff 376441. balazske added a comment. AttrImporter owns now the result of import (until it is read), instead of referenced error and returned pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110810/new/

[PATCH] D110395: [clang][ASTImporter] Import InheritedConstructor and ConstructorUsingShadowDecl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a0b066264f: [clang][ASTImporter] Import InheritedConstructor and ConstructorUsingShadowDecl. (authored by martong, committed by balazske).

[clang] a3a0b06 - [clang][ASTImporter] Import InheritedConstructor and ConstructorUsingShadowDecl.

Author: Gabor Marton Date: 2021-10-01T10:16:11+02:00 New Revision: a3a0b066264fd132a2014edf2aef53072a1fe53a URL: https://github.com/llvm/llvm-project/commit/a3a0b066264fd132a2014edf2aef53072a1fe53a DIFF: https://github.com/llvm/llvm-project/commit/a3a0b066264fd132a2014edf2aef53072a1fe53a.diff

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376431. kbobyrev added a comment. Tiny refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376430. kbobyrev added a comment. Fix the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

steakhal added a comment. 'using' is the same as 'typedef' AFAIK. So, you could simply use only typedefs and implement the test in the c test file. Seeing all the tests close together would aid readability IMO. WDYT Denys? Btw does the SVval::getType return a canonical type in all cases?

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal accepted this revision. steakhal added a comment. Good work. Land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 ___ cfe-commits mailing list

[PATCH] D110889: [clang][Fuchsia] Add -DSCUDO_DISABLE_TBI to test flags

phosek added a comment. Is this needed even with D110888 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110889/new/ https://reviews.llvm.org/D110889 ___ cfe-commits

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376425. kbobyrev added a comment. Rebase on top of main. Now ready for a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files:

<    1   2