[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall updated this revision to Diff 398991. sammccall added a comment. Revert hover changes, only use for code complete Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116387/new/ https://reviews.llvm.org/D116387 Files:

[PATCH] D117035: [analyzer] Added more tests for scalars, enums and records for StrictAliasingChecker

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, xazax.hun, martong, NoQ. Herald added subscribers: manas, jeroen.dobbelaere, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. ASDenysPetrov requested review of this

[PATCH] D117033: [analyzer] Added more tests for scalars and enums for StrictAliasingChecker

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, martong, steakhal, xazax.hun. ASDenysPetrov added a project: clang. Herald added subscribers: manas, jeroen.dobbelaere, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov updated this revision to Diff 398986. ASDenysPetrov added a comment. Improved the checker. Reworked tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114718/new/ https://reviews.llvm.org/D114718 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D116882: [docs] [clang] Small documentation change for compilation databases

croepha marked an inline comment as done. croepha added a comment. Hey, @joerg I don't have commit access, would you mind landing this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116882/new/ https://reviews.llvm.org/D116882

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5529 +def warn_call_function_without_prototype : Warning< + "calling function %0 with arguments when function has no prototype">, InGroup< +

[PATCH] D116663: [clang-format] Fix SeparateDefinitionBlocks issues

This revision was automatically updated to reflect the committed changes. Closed by commit rGee25a327aac0: [clang-format] Fix SeparateDefinitionBlocks issues (authored by ksyx). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] ee25a32 - [clang-format] Fix SeparateDefinitionBlocks issues

Author: ksyx Date: 2022-01-11T12:25:39-05:00 New Revision: ee25a327aac0eeae28f468a741b58ec7689de5f2 URL: https://github.com/llvm/llvm-project/commit/ee25a327aac0eeae28f468a741b58ec7689de5f2 DIFF: https://github.com/llvm/llvm-project/commit/ee25a327aac0eeae28f468a741b58ec7689de5f2.diff LOG:

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. In D112913#3233699 , @upsuper wrote: > I'd like to clarify that what I think is correct now is the algorithm to > detect unclosed explicit formatting scopes in a given string. Thanks for confirming. This check only

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei added a comment. A gentle reminder for reviewers. -- This patch will fix the bug reported here: https://bugs.llvm.org/show_bug.cgi?id=52565 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114564/new/ https://reviews.llvm.org/D114564

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

aganea added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:71 +// SPLINK: {{llvm-spirv.*"}} [[BC]] "-o" [[SPV2:".*o"]] +// SPLINK: {{"spirv-link.*"}} [[SPV1]] [[SPV2]] "-o" "a.out" svenvh wrote: > aganea wrote: > > Hello @Anastasia, this line

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

svenvh added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:71 +// SPLINK: {{llvm-spirv.*"}} [[BC]] "-o" [[SPV2:".*o"]] +// SPLINK: {{"spirv-link.*"}} [[SPV1]] [[SPV2]] "-o" "a.out" aganea wrote: > Hello @Anastasia, this line fails on my

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. In D116935#3233751 , @fhahn wrote: > Another rebase. I am planning to land this later today, unless there are > additional concerns with respect to the fold in Clang after my latest > response. Thanks, Florian. I have no

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

aganea added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:71 +// SPLINK: {{llvm-spirv.*"}} [[BC]] "-o" [[SPV2:".*o"]] +// SPLINK: {{"spirv-link.*"}} [[SPV1]] [[SPV2]] "-o" "a.out" Hello @Anastasia, this line fails on my machine. It works

[clang] 4b14fc6 - [SPIR-V] Drop double quote from test pattern

Author: Sven van Haastregt Date: 2022-01-11T16:58:08Z New Revision: 4b14fc6fe5a7d01fb42a3cdede77c59f03b867af URL: https://github.com/llvm/llvm-project/commit/4b14fc6fe5a7d01fb42a3cdede77c59f03b867af DIFF: https://github.com/llvm/llvm-project/commit/4b14fc6fe5a7d01fb42a3cdede77c59f03b867af.diff

[PATCH] D117024: [clang] Move `ApplyHeaderSearchOptions` from Frontend to Lex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf77d115cc136: [clang] Move `ApplyHeaderSearchOptions` from Frontend to Lex (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] f77d115 - [clang] Move `ApplyHeaderSearchOptions` from Frontend to Lex

Author: Jan Svoboda Date: 2022-01-11T17:57:40+01:00 New Revision: f77d115cc136585f39d30a78c741eb296f9e804d URL: https://github.com/llvm/llvm-project/commit/f77d115cc136585f39d30a78c741eb296f9e804d DIFF: https://github.com/llvm/llvm-project/commit/f77d115cc136585f39d30a78c741eb296f9e804d.diff

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

zero9178 updated this revision to Diff 398962. zero9178 added a comment. Addressed reviewer nits: - Used proper naming conventions - Adjusted tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116775/new/ https://reviews.llvm.org/D116775 Files: clang/lib/Sema/SemaLookup.cpp

[PATCH] D117024: [clang] Move `ApplyHeaderSearchOptions` from Frontend to Lex

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. That was easy :) Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117024/new/ https://reviews.llvm.org/D117024

[PATCH] D117024: [clang] Move `ApplyHeaderSearchOptions` from Frontend to Lex

jansvoboda11 updated this revision to Diff 398957. jansvoboda11 added a comment. Re-run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117024/new/ https://reviews.llvm.org/D117024 Files: clang/include/clang/Frontend/Utils.h

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

aaron.ballman added a comment. First off, thank you so much for your patience while I took the time to think about this. I know it can be frustrating to not hear review feedback in a timely manner, so I'm sorry for that. I've been sitting on this for a while because type attributes are a

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

ahatanak updated this revision to Diff 398948. ahatanak marked 3 inline comments as done. ahatanak added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116948/new/ https://reviews.llvm.org/D116948 Files:

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks for the adjustment. Hope you are happy with the result. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/

[PATCH] D116670: [ASan] Driver changes to always link-in asan_static library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3b9edf8b8c3: [ASan] Driver changes to always link-in asan_static library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES

[clang] a3b9edf - [ASan] Driver changes to always link-in asan_static library.

Author: Kirill Stoimenov Date: 2022-01-11T15:31:41Z New Revision: a3b9edf8b8c3815c1a2c200f9bc00882e1244827 URL: https://github.com/llvm/llvm-project/commit/a3b9edf8b8c3815c1a2c200f9bc00882e1244827 DIFF: https://github.com/llvm/llvm-project/commit/a3b9edf8b8c3815c1a2c200f9bc00882e1244827.diff

[PATCH] D117024: [clang] Move `ApplyHeaderSearchOptions` from Frontend to Lex

jansvoboda11 created this revision. jansvoboda11 added a reviewer: thakis. Herald added a subscriber: mgorny. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D116750 , the `clangFrontend`

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

thakis added a comment. > That's referring to the fact that once we allocate new `DirectoryLookup` with > `SpecificBumpPtrAllocator`, address of that object won't change (unlike with > `std::vector`). This means that we can take the address and use it without > worrying about invalidation.

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. @efriedma I know it has been a long time, but are you still able to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/ https://reviews.llvm.org/D27800 ___

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Fixes https://github.com/llvm/llvm-project/issues/30390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/ https://reviews.llvm.org/D27800 ___ cfe-commits mailing list

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Fixes https://github.com/llvm/llvm-project/issues/30390 Comment at: test/SemaCXX/pr31042.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free %s + efriedma wrote: > Oh, this testcase doesn't actually

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 398935. pmatos added a comment. Herald added a subscriber: wingo. Herald added a project: clang. After a long hiatus on this bug, this is still failing on HEAD so lets get it fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 added a comment. In D116750#3234261 , @thakis wrote: > 1. `which is stable thanks to the bump-ptr-allocation strategy.` I don't > understand this. In each slab, that's true, but why is it true between > objects allocated in different

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews marked 2 inline comments as done. eandrews added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11496 + .getProgramAddressSpace() + : getTargetAddressSpace(T.getQualifiers()); +} rjmccall wrote: > Oh, I'm sorry I

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

Quuxplusone added a comment. LGTM % comments, but I'll take one more look. Comment at: clang/test/SemaCXX/typo-correction.cpp:772-782 +namespace B { +int pr47272(); // expected-note{{'B::pr47272' declared here}} +} + +namespace [[deprecated]] A { +using B::pr47272; +}

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

thakis added a comment. 1. `which is stable thanks to the bump-ptr-allocation strategy.` I don't understand this. In each slab, that's true, but why is it true between objects allocated in different slabs? 2. This increases numbers of TUs compiled for LexTests by over 10%. Is there no way

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some nits, though please wait for @Quuxplusone to respond before landing. Comment at: clang/lib/Sema/SemaLookup.cpp:4310-4311 if (NamedDecl *NewND = Correction.getCorrectionDecl()) { -

[PATCH] D116967: [HIP] Fix device malloc/free

yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:80 +#if HIP_VERSION_MAJOR > 4 || (HIP_VERSION_MAJOR == 4 && HIP_VERSION_MINOR >= 5) +extern "C" __device__ unsigned long long __ockl_dm_alloc(unsigned long long __size);

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:57-60 if (const auto *FuncDecl = CExpr->getDirectCallee()) { if (FuncDecl->getDeclName().isIdentifier() && - FuncDecl->getName() ==

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rG8503c688d555: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date (authored by

[clang] 8503c68 - [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

Author: Jan Svoboda Date: 2022-01-11T15:24:46+01:00 New Revision: 8503c688d555014b88849e933bf096035a351586 URL: https://github.com/llvm/llvm-project/commit/8503c688d555014b88849e933bf096035a351586 DIFF: https://github.com/llvm/llvm-project/commit/8503c688d555014b88849e933bf096035a351586.diff

[PATCH] D116190: Comment parsing: Don't recognize commands in single-line double quotation

aaronpuchert added a comment. Ping @gribozavr2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116190/new/ https://reviews.llvm.org/D116190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia added a comment. Fix is committed to remove unused variable: https://github.com/llvm/llvm-project/commit/0eef65028e8a2f3417fb19e2eb5b0cbf50600c7e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116266/new/ https://reviews.llvm.org/D116266

[clang] 0eef650 - [SPIR-V] Remove unused variable

Author: Anastasia Stulova Date: 2022-01-11T13:45:59Z New Revision: 0eef65028e8a2f3417fb19e2eb5b0cbf50600c7e URL: https://github.com/llvm/llvm-project/commit/0eef65028e8a2f3417fb19e2eb5b0cbf50600c7e DIFF: https://github.com/llvm/llvm-project/commit/0eef65028e8a2f3417fb19e2eb5b0cbf50600c7e.diff

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 marked 4 inline comments as done. jansvoboda11 added a comment. Thanks for the feedback! Comment at: clang/unittests/Lex/HeaderSearchTest.cpp:276 +std::vector ExpectedSearchDirUsageAfterM2{false, true, false}; +EXPECT_EQ(Search.getSearchDirUsage(),

[PATCH] D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/RedundantVoidArgCheck.cpp:51 this); - Finder->addMatcher(typedefNameDecl().bind(TypedefId), this); +

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 updated this revision to Diff 398917. jansvoboda11 added a comment. Update documentation, inline variables in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116750/new/ https://reviews.llvm.org/D116750 Files:

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbb8d086377b: [SPIR-V] Add linking using spirv-link. (authored by Anastasia). Herald added a project: clang. Changed prior to commit:

[clang] dbb8d08 - [SPIR-V] Add linking using spirv-link.

Author: Anastasia Stulova Date: 2022-01-11T13:11:38Z New Revision: dbb8d086377ba3a81e44c471840bdbd982c00a35 URL: https://github.com/llvm/llvm-project/commit/dbb8d086377ba3a81e44c471840bdbd982c00a35 DIFF: https://github.com/llvm/llvm-project/commit/dbb8d086377ba3a81e44c471840bdbd982c00a35.diff

[PATCH] D116814: [clang-tidy] Accept string literal decay in conditional operator

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116814/new/ https://reviews.llvm.org/D116814

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

aaron.ballman added a subscriber: ymandel. aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5435-5442 +/// Matches two consecutive statements within a compound statement. +/// +/// Given +/// \code +/// { if (x > 0) return true;

[clang] 0c7f515 - Revert "[Clang][AArch64][ARM] PMUv3.4 Option Added"

Author: David Green Date: 2022-01-11T12:33:53Z New Revision: 0c7f515f88fca39458f3b3fd9db188e48db0a7e4 URL: https://github.com/llvm/llvm-project/commit/0c7f515f88fca39458f3b3fd9db188e48db0a7e4 DIFF: https://github.com/llvm/llvm-project/commit/0c7f515f88fca39458f3b3fd9db188e48db0a7e4.diff LOG:

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

aaron.ballman added a comment. Thanks for the fix! Can you be sure to add test coverage for both clang-tidy and Clang to demonstrate the behavior change? Comment at: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp:35 Finder->addMatcher(

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda47db8ee1d: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties (authored by egorzhdan). Repository: rG LLVM Github Monorepo

[clang] fda47db - [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

Author: Egor Zhdan Date: 2022-01-11T12:10:18Z New Revision: fda47db8ee1d3eca8c42819cf1b65ab0ef7df7b8 URL: https://github.com/llvm/llvm-project/commit/fda47db8ee1d3eca8c42819cf1b65ab0ef7df7b8 DIFF: https://github.com/llvm/llvm-project/commit/fda47db8ee1d3eca8c42819cf1b65ab0ef7df7b8.diff LOG:

[PATCH] D117012: [clang][dataflow] Add transfer functions data members and this pointers

sgatev updated this revision to Diff 398907. sgatev added a comment. Add missing include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117012/new/ https://reviews.llvm.org/D117012 Files:

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf updated this revision to Diff 398906. qiucf marked 2 inline comments as done. qiucf edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 Files:

[PATCH] D117012: [clang][dataflow] Add transfer functions data members and this pointers

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

RKSimon added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1534 } else if (StoreInst *SI = dyn_cast(I)) { -if (!ClInstrumentWrites || ignoreAccess(SI->getPointerOperand())) +if (!ClInstrumentWrites || ignoreAccess(LI,

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 398901. amilendra added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Refactor the check conditions to a single function (isArmT32) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] acc3987 - [CodeGen] Avoid deprecated Address constructor

Author: Nikita Popov Date: 2022-01-11T13:07:02+01:00 New Revision: acc39873b70eae53a0c32ca5073f08ea55bbab1c URL: https://github.com/llvm/llvm-project/commit/acc39873b70eae53a0c32ca5073f08ea55bbab1c DIFF: https://github.com/llvm/llvm-project/commit/acc39873b70eae53a0c32ca5073f08ea55bbab1c.diff

[PATCH] D117009: [AST] Fix the incorrect auto-keyword loc for constrained auto type loc.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: carlosgalvezp. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. E.g. `Concept auto Func();` The nameLoc for the constained auto type loc pointed to the concept

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398897. saiislam added a comment. 1. Used a common diagnostic warning `warn_unknown_declare_variant_isa_trait` for ParseOpenMP and SemaOpenMP for decalre variant and metadirectives. 2. Split lit codegen tests into two files, one requiring amdgpu-registered

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Don't forget to reformat. It's a pity though that we cannot use `MightBeFunctionDecl`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116920/new/

[clang] fba8ad2 - [SemaTemplateInstantiate] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-11T11:29:38Z New Revision: fba8ad2b719c14e971dfe16458b3d18c08e0e40d URL: https://github.com/llvm/llvm-project/commit/fba8ad2b719c14e971dfe16458b3d18c08e0e40d DIFF: https://github.com/llvm/llvm-project/commit/fba8ad2b719c14e971dfe16458b3d18c08e0e40d.diff

[clang-tools-extra] 41fbdfa - Reland "[AST] Add RParen loc for decltype AutoTypeloc."

Author: Haojian Wu Date: 2022-01-11T12:06:18+01:00 New Revision: 41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3 URL: https://github.com/llvm/llvm-project/commit/41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3 DIFF: https://github.com/llvm/llvm-project/commit/41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3.diff

[clang] 0b48d0f - [ADT] Add an in-place version of toHex()

Author: Hans Wennborg Date: 2022-01-11T11:51:04+01:00 New Revision: 0b48d0fe1292929f0cd61a2ca8114d794e245daa URL: https://github.com/llvm/llvm-project/commit/0b48d0fe1292929f0cd61a2ca8114d794e245daa DIFF: https://github.com/llvm/llvm-project/commit/0b48d0fe1292929f0cd61a2ca8114d794e245daa.diff

[PATCH] D112718: Add intrinsics and builtins for PTX atomics with semantic orders

Naghasan added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:1057 + +BUILTIN(__nvvm_atom_xchg_global_i, "iiD*i", "n") +TARGET_BUILTIN(__nvvm_atom_cta_xchg_global_i, "iiD*i", "n", SM_60) tra wrote: > t4c1 wrote: > > tra wrote: > > >

[PATCH] D116748: [AArch64][ARM][Clang] PerfMon Extension Added

dmgreen added a comment. Hmm. This appears to be mapping pmuv3p4 to "perfmon". But "perfmon" has been around a long time, not a new feature related to the pmuv3p4 update. It seems on the AArch64 side to control access to PMCCNTR, i.e. access to the base FEAT_PMUv3. On the Arm side this is

[PATCH] D116960: [ADT] Add an in-place version of toHex()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hans marked 2 inline comments as done. Closed by commit rG83797c03d2ee: [ADT] Use a lookup table in hexdigit() and call that from toHex() (authored by hans). Changed

[PATCH] D116960: [ADT] Add an in-place version of toHex()

hans marked 2 inline comments as done. hans added a comment. In D116960#3232461 , @dexonsmith wrote: > Mostly LGTM, just a couple of comments on the drive-by changes to > `hexdigit()` (I might split that (and the new call in toHex()) into a > separate

[clang] 2e52f76 - [SemaOverload] compareConversionFunctions - use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-11T10:31:26Z New Revision: 2e52f76a722aa3ae5d655e0f15972b4f73db0150 URL: https://github.com/llvm/llvm-project/commit/2e52f76a722aa3ae5d655e0f15972b4f73db0150 DIFF: https://github.com/llvm/llvm-project/commit/2e52f76a722aa3ae5d655e0f15972b4f73db0150.diff

[clang] c61299e - [SemaOverload] Use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-11T10:31:25Z New Revision: c61299e2b30627f327f5a9a198ad030092534496 URL: https://github.com/llvm/llvm-project/commit/c61299e2b30627f327f5a9a198ad030092534496 DIFF: https://github.com/llvm/llvm-project/commit/c61299e2b30627f327f5a9a198ad030092534496.diff

[clang] 18b2385 - [clang] [test] Fix clang-cl unused argument tests on paths that start with /U

Author: Martin Storsjö Date: 2022-01-11T12:28:23+02:00 New Revision: 18b2385f2b09453b5e9d26459ec9e806f5ee7f86 URL: https://github.com/llvm/llvm-project/commit/18b2385f2b09453b5e9d26459ec9e806f5ee7f86 DIFF:

[PATCH] D116978: [clangd] Selection: Prune gtest TEST()s earlier

sammccall updated this revision to Diff 398876. sammccall added a comment. Rebase (offsetInSelFile) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116978/new/ https://reviews.llvm.org/D116978 Files: clang-tools-extra/clangd/Selection.cpp

[PATCH] D112913: Misleading bidirectional detection

upsuper added a comment. I'd like to clarify that what I think is correct now is the algorithm to detect unclosed explicit formatting scopes in a given string. I haven't been following very closely with the whole spoofing issue, so I can't say that there is no other ways to construct a spoof

[clang-tools-extra] 1e9b837 - [clangd] Save more getFileID in Selection

Author: Sam McCall Date: 2022-01-11T11:01:54+01:00 New Revision: 1e9b837585cc0c8713e00d4f9c3512c867d598de URL: https://github.com/llvm/llvm-project/commit/1e9b837585cc0c8713e00d4f9c3512c867d598de DIFF: https://github.com/llvm/llvm-project/commit/1e9b837585cc0c8713e00d4f9c3512c867d598de.diff

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. @MaskRay any blocker on that new version now that it recieved a green light from @upsuper? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing

[PATCH] D115521: [Templight] Don't display empty strings for names of unnamed template parameters

Szelethus added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:501 + +if (const auto *Decl = dyn_cast(NamedTemplate)) { + if (const auto *R = dyn_cast(Decl)) { Szelethus wrote: > martong wrote: > > martong wrote: > > > Should this

[clang-tools-extra] 22ac067 - [clangd] Small optimization in SelectionTree

Author: Sam McCall Date: 2022-01-11T10:18:44+01:00 New Revision: 22ac067b2dce8c90db0bbeecb6ec926f526399df URL: https://github.com/llvm/llvm-project/commit/22ac067b2dce8c90db0bbeecb6ec926f526399df DIFF: https://github.com/llvm/llvm-project/commit/22ac067b2dce8c90db0bbeecb6ec926f526399df.diff

[clang] e26bbae - [clang] [test] Remove newly added tests that fail on Darwin

Author: Martin Storsjö Date: 2022-01-11T11:06:29+02:00 New Revision: e26bbae30218a35d76a79fe90b0e41dd0f71b779 URL: https://github.com/llvm/llvm-project/commit/e26bbae30218a35d76a79fe90b0e41dd0f71b779 DIFF:

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

fhahn added a comment. In D116935#3232763 , @craig.topper wrote: > Do the programs in compile-time tracker make much use of bitfields? I'd expect some bitfields, but nothing excessive/pathological. > Is there any indication in rdar://7362516 what

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

MyDeveloperDay updated this revision to Diff 398864. MyDeveloperDay added a comment. remove additional space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116920/new/ https://reviews.llvm.org/D116920 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

MyDeveloperDay updated this revision to Diff 398863. MyDeveloperDay added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116920/new/ https://reviews.llvm.org/D116920 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D116219: [CodeGen] Make element type in emitArrayDestroy() predictable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d1b55ebea88: [CodeGen] Make element type in emitArrayDestroy() predictable (authored by nikic). Herald added a project: clang. Herald added a

[clang] 2d1b55e - [CodeGen] Make element type in emitArrayDestroy() predictable

Author: Nikita Popov Date: 2022-01-11T09:25:29+01:00 New Revision: 2d1b55ebea88547d153fcd980b88c946cffc5ca5 URL: https://github.com/llvm/llvm-project/commit/2d1b55ebea88547d153fcd980b88c946cffc5ca5 DIFF: https://github.com/llvm/llvm-project/commit/2d1b55ebea88547d153fcd980b88c946cffc5ca5.diff

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

MyDeveloperDay updated this revision to Diff 398861. MyDeveloperDay added a comment. Line.MightBeFunctionDecl is not true in this case Added new tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116920/new/ https://reviews.llvm.org/D116920 Files:

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan updated this revision to Diff 398860. owenpan added a comment. This revision is now accepted and ready to land. - Removed unnecessary code and cleaned up. - Tested on `clang` and `check-clang` again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/

[PATCH] D116994: [RISCV] Add bfp and bfpw intrinsic in zbf extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:36 +// zbf extension +TARGET_BUILTIN(__builtin_riscv_bfp, "LiLiLi", "nc", "experimental-zbf") Capital Z Comment at:

<    1   2