[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: clang/lib/CodeGen/CGCoroutine.cpp:650 - if (Stmt *Ret = S.getReturnStmt()) + if (Stmt *Ret = S.getReturnStmt()) { +// Since we

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

rpenacob added a comment. To test that this change does not break anything we built clang trunk with the patch. Our stage one looks like this. -DCMAKE_INSTALL_PREFIX=/path/to/stage-one -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS=clang

[clang] c6f8704 - [clang][deps] Disable global module index

Author: Jan Svoboda Date: 2022-02-15T09:51:23+01:00 New Revision: c6f8704053ba364cf8cc9a0a966617efeda079f7 URL: https://github.com/llvm/llvm-project/commit/c6f8704053ba364cf8cc9a0a966617efeda079f7 DIFF: https://github.com/llvm/llvm-project/commit/c6f8704053ba364cf8cc9a0a966617efeda079f7.diff

[PATCH] D118890: [clang][deps] Disable global module index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6f8704053ba: [clang][deps] Disable global module index (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119814: [clang-format] Honour PointerAlignment in statements with initializers.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53843. Repository: rG

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

HazardyKnusperkeks added a comment. In D119682#3321975 , @MyDeveloperDay wrote: > I understand what you are saying re 'IndentRequiresClause' but this leaves us > with people with "IndentRequires" in their .clang-format without any > understanding of

[clang] 074451b - [OpenCL] opencl-c.h: fix atomic_fetch_max with addrspace

Author: Sven van Haastregt Date: 2022-02-15T12:12:03Z New Revision: 074451bd3352e022d015545e9091002d052daaa3 URL: https://github.com/llvm/llvm-project/commit/074451bd3352e022d015545e9091002d052daaa3 DIFF: https://github.com/llvm/llvm-project/commit/074451bd3352e022d015545e9091002d052daaa3.diff

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:710 + CacheLookup.HitIt = HitIt; + noteLookupUsage(&*HitIt - &*search_dir_begin(), Loc); } jansvoboda11 wrote: > ahoppen wrote: > > I haven’t looked into this in total details but

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5171 (!TargetDecl || !isa(TargetDecl))) { +assert((CGM.getCodeGenOpts().CodeModel == "default" || +CGM.getCodeGenOpts().CodeModel == "small") && pcc wrote: > What

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. In D91605#3321554 , @MaskRay wrote: > `GetTls` is about the static TLS block size. It consists of the main > executable's TLS, and initially loaded shared objects' TLS, `struct pthread`, > and padding. > Solaris should be able to

[PATCH] D119825: [clang][lex] Introduce `SearchDirIndex` to usage tracking code

jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. Herald added a subscriber: arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces new `SearchDirIndex`

[clang-tools-extra] 7a124f4 - [clang][lex] Remove `PPCallbacks::FileNotFound()`

Author: Jan Svoboda Date: 2022-02-15T09:48:25+01:00 New Revision: 7a124f4859d5c4093467abc2e734f8ab15e78cc6 URL: https://github.com/llvm/llvm-project/commit/7a124f4859d5c4093467abc2e734f8ab15e78cc6 DIFF: https://github.com/llvm/llvm-project/commit/7a124f4859d5c4093467abc2e734f8ab15e78cc6.diff

[clang] edd09bb - [clang][lex] Remove `Preprocessor::GetCurDirLookup()`

Author: Jan Svoboda Date: 2022-02-15T09:48:25+01:00 New Revision: edd09bb5a49c6a5dac29714af661d1ddffe50a72 URL: https://github.com/llvm/llvm-project/commit/edd09bb5a49c6a5dac29714af661d1ddffe50a72 DIFF: https://github.com/llvm/llvm-project/commit/edd09bb5a49c6a5dac29714af661d1ddffe50a72.diff

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a124f4859d5: [clang][lex] Remove `PPCallbacks::FileNotFound()` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119708/new/

[PATCH] D119714: [clang][lex] Remove `Preprocessor::GetCurDirLookup()`

This revision was automatically updated to reflect the committed changes. Closed by commit rGedd09bb5a49c: [clang][lex] Remove `Preprocessor::GetCurDirLookup()` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119714/new/

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen updated this revision to Diff 408752. ychen added a comment. Herald added subscribers: jdoerfert, pengfei. - check code model in driver - document `func_sanitizer` in Langref - add a codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

This revision was automatically updated to reflect the committed changes. Closed by commit rGa081a0654f35: [clang][lex] NFC: De-duplicate some #include_next logic (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119716/new/

[clang] a081a06 - [clang][lex] NFC: De-duplicate some #include_next logic

Author: Jan Svoboda Date: 2022-02-15T09:52:39+01:00 New Revision: a081a0654f35c12ddc2afc072110098404434b6c URL: https://github.com/llvm/llvm-project/commit/a081a0654f35c12ddc2afc072110098404434b6c DIFF: https://github.com/llvm/llvm-project/commit/a081a0654f35c12ddc2afc072110098404434b6c.diff

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:470 +ShouldMerge = Style.AllowShortEnumsOnASingleLine; + } else if (TheLine->Last->isOneOf(TT_ClassLBrace, TT_StructLBrace)) { +// NOTE: We use AfterClass (whereas

[PATCH] D119826: [clang] Remove a duplicate action kind table entry.

iains created this revision. iains added a reviewer: jansvoboda11. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. probably trivial - but, in case there's some subtlety I missed... We have two entries for

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

Anastasia updated this revision to Diff 408806. Anastasia retitled this revision from "[Docs][OpenCL] Update OpenCL 3.0 status on release 14" to "[Docs][OpenCL] Update OpenCL 3.0 status". Anastasia edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

Anastasia updated this revision to Diff 408810. Anastasia added a comment. - Fixed review comments - Updated OpenCL 3 state after backports CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119710/new/ https://reviews.llvm.org/D119710 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D119748: [clang][NFC] Remove IgnoreLinkageSpecDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG02093906fa0f: [clang][NFC] Remove IgnoreLinkageSpecDecls (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] 0209390 - [clang][NFC] Remove IgnoreLinkageSpecDecls

Author: Nathan Sidwell Date: 2022-02-15T04:28:45-08:00 New Revision: 02093906fa0fd5bacc61b2189ea643c78cd02509 URL: https://github.com/llvm/llvm-project/commit/02093906fa0fd5bacc61b2189ea643c78cd02509 DIFF:

[clang] fd2dff1 - [clang][lex][minimizer] Ensure whitespace between squashed lines

Author: Jan Svoboda Date: 2022-02-15T09:49:03+01:00 New Revision: fd2dff17c53dbfd89789989bedd949c496e7b6b7 URL: https://github.com/llvm/llvm-project/commit/fd2dff17c53dbfd89789989bedd949c496e7b6b7 DIFF: https://github.com/llvm/llvm-project/commit/fd2dff17c53dbfd89789989bedd949c496e7b6b7.diff

[PATCH] D119231: [clang][lex][minimizer] Ensure whitespace between squashed lines

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd2dff17c53d: [clang][lex][minimizer] Ensure whitespace between squashed lines (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d8298f0 - [clang][lex][minimizer] Avoid treating path separators as comments

Author: Jan Svoboda Date: 2022-02-15T09:49:19+01:00 New Revision: d8298f04a9681fcbb16d7fc4872690b5504a0d52 URL: https://github.com/llvm/llvm-project/commit/d8298f04a9681fcbb16d7fc4872690b5504a0d52 DIFF: https://github.com/llvm/llvm-project/commit/d8298f04a9681fcbb16d7fc4872690b5504a0d52.diff

[PATCH] D119226: [clang][lex][minimizer] Avoid treating path separators as comments

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8298f04a968: [clang][lex][minimizer] Avoid treating path separators as comments (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 created this revision. Herald added subscribers: ormris, dexonsmith, jdoerfert, steven_wu, hiraditya. ztong0001 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adding __attribute__((no_sanitize("bounds"))) is

[PATCH] D119814: [clang-format] Honour PointerAlignment in statements with initializers.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Creating your own bug and fixing it within 10 minutes. Nice. ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119814/new/ https://reviews.llvm.org/D119814

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu updated this revision to Diff 408761. ChuanqiXu added a comment. Update test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117087/new/ https://reviews.llvm.org/D117087 Files: clang/include/clang/AST/StmtCXX.h clang/lib/AST/StmtCXX.cpp clang/lib/CodeGen/CGCoroutine.cpp

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:650 - if (Stmt *Ret = S.getReturnStmt()) + if (Stmt *Ret = S.getReturnStmt()) { +// Since we already emitted the return value above, so we shouldn't junparser wrote: > can we

[clang] e7dcf09 - [clang][lex] Use `SearchDirIterator` types in for loops

Author: Jan Svoboda Date: 2022-02-15T11:02:26+01:00 New Revision: e7dcf09fc321010fb012afd270afdef20378dee7 URL: https://github.com/llvm/llvm-project/commit/e7dcf09fc321010fb012afd270afdef20378dee7 DIFF: https://github.com/llvm/llvm-project/commit/e7dcf09fc321010fb012afd270afdef20378dee7.diff

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17c9fcd6f6fc: [clang][lex] Use `ConstSearchDirIterator` in lookup cache (authored by jansvoboda11). Changed prior to commit:

[PATCH] D119722: [clang][lex] Use `SearchDirIterator` types in for loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7dcf09fc321: [clang][lex] Use `SearchDirIterator` types in for loops (authored by jansvoboda11). Changed prior to commit:

[clang] 17c9fcd - [clang][lex] Use `ConstSearchDirIterator` in lookup cache

Author: Jan Svoboda Date: 2022-02-15T10:39:05+01:00 New Revision: 17c9fcd6f6fc0926c1096242a2ddced9b523decd URL: https://github.com/llvm/llvm-project/commit/17c9fcd6f6fc0926c1096242a2ddced9b523decd DIFF: https://github.com/llvm/llvm-project/commit/17c9fcd6f6fc0926c1096242a2ddced9b523decd.diff

[PATCH] D119826: [clang] Remove a duplicate action kind table entry.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, must've been a mistake. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119826/new/ https://reviews.llvm.org/D119826

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, I really like the approach of us annotating more like this, it makes the token much easier to reason about when there is ambiguity. nice one! Comment

[clang] ef378d7 - [clang][lex] Remove misleading comment

Author: Jan Svoboda Date: 2022-02-15T12:39:43+01:00 New Revision: ef378d76b46091abfa548e698e5d7e03571bd5c1 URL: https://github.com/llvm/llvm-project/commit/ef378d76b46091abfa548e698e5d7e03571bd5c1 DIFF: https://github.com/llvm/llvm-project/commit/ef378d76b46091abfa548e698e5d7e03571bd5c1.diff

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

Anastasia added a comment. Can this be committed now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:710 + CacheLookup.HitIt = HitIt; + noteLookupUsage(&*HitIt - &*search_dir_begin(), Loc); } ahoppen wrote: > I haven’t looked into this in total details but `&*` looks a little

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

MyDeveloperDay added a comment. I understand what you are saying re 'IndentRequiresClause' but this leaves us with people with "IndentRequires" in their .clang-format without any understanding of what it means? i.e. what about the 14.0 people? if we've renamed an option then the documentation

[clang] 2370977 - [clang] Remove a duplicate action kind table entry.

Author: iains Date: 2022-02-15T11:19:09Z New Revision: 2370977bdd0254d9d5424713513aeee233c647e4 URL: https://github.com/llvm/llvm-project/commit/2370977bdd0254d9d5424713513aeee233c647e4 DIFF: https://github.com/llvm/llvm-project/commit/2370977bdd0254d9d5424713513aeee233c647e4.diff LOG:

[PATCH] D119826: [clang] Remove a duplicate action kind table entry.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2370977bdd02: [clang] Remove a duplicate action kind table entry. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

junparser added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:654 +cast(Ret)->setRetValue(nullptr); EmitStmt(Ret); + } I mean, remove the if statements here since the retuen expr is null. CHANGES SINCE LAST ACTION

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. ro requested review of this revision. This is the driver part of D91605 , a workaround to allow direct calls to `__tls_get_addr`

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. In D91605#3321556 , @MaskRay wrote: > The Clang driver change should be in a separate patch with clang/test/Driver > tests. Done now: D119829 . Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 updated this revision to Diff 408733. jansvoboda11 added a comment. Use `std::next` and `ConstSearchDirIterator::Idx`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119721/new/ https://reviews.llvm.org/D119721 Files:

[clang] 7631c36 - [clang][lex] Introduce `ConstSearchDirIterator`

Author: Jan Svoboda Date: 2022-02-15T10:36:54+01:00 New Revision: 7631c366c8589dda488cb7ff1df26cc134002208 URL: https://github.com/llvm/llvm-project/commit/7631c366c8589dda488cb7ff1df26cc134002208 DIFF: https://github.com/llvm/llvm-project/commit/7631c366c8589dda488cb7ff1df26cc134002208.diff

[PATCH] D117566: [clang][lex] Introduce `ConstSearchDirIterator`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7631c366c858: [clang][lex] Introduce `ConstSearchDirIterator` (authored by jansvoboda11). Changed prior to commit:

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status on release 14

azabaznov added inline comments. Comment at: clang/docs/OpenCLSupport.rst:395

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:718 if (Line.Last->is(tok::l_brace)) { FormatToken *Tok = I[1]->First; @MyDeveloperDay, probably we'll need to check `LastNonComment` similarly to what I did

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119560/new/ https://reviews.llvm.org/D119560

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

Anastasia added a comment. > also makes the header no longer "claim" the identifiers "success", > "failure", "desired", "value" (such that you can compile with -Dvalue=... > when including the header for example, which currently breaks parsing > of the header). I don't get what you mean by

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

MyDeveloperDay accepted this revision. MyDeveloperDay added a subscriber: HazardyKnusperkeks. MyDeveloperDay added a comment. This revision is now accepted and ready to land. @HazardyKnusperkeks could you validate the `IndentRequiresClause` I know I added `IndentRequires` in 13 but is this the

[PATCH] D119722: [clang][lex] Use `SearchDirIterator` types in for loops

ahoppen accepted this revision. ahoppen added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/HeaderSearch.cpp:1450 Optional HeaderSearch::searchDirIdx(const DirectoryLookup ) const { - for (unsigned I = 0; I < SearchDirs.size();

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:2207 + const FileEntry *) const; + /// Install the standard preprocessor pragmas: ahoppen wrote: > I there a reason why this uses an out parameter

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

t.p.northover added a comment. Sorry, that was an old xnu version, the newest one is https://opensource.apple.com/source/xnu/xnu-7195.81.3/osfmk/mach/machine.h.auto.html which has | `CPUFAMILY_ARM_CYCLONE`| 0x37a09642 | `apple-a7` | | `CPUFAMILY_ARM_TYPHOON`

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

iains created this revision. iains added reviewers: dblaikie, aprantl, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is useful to be able to visualise the C++20 modules content of a PCM file both for

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

urnathan added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

haonanya added a comment. Hi, @Anastasia. Please help to land it, thanks very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 ___ cfe-commits mailing

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

jansvoboda11 updated this revision to Diff 408730. jansvoboda11 added a comment. Return `std::pair` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119716/new/ https://reviews.llvm.org/D119716 Files: clang/include/clang/Lex/Preprocessor.h

[clang] 86bde99 - Insert a blurb about the -fzero-call-used-regs feature

Author: Bill Wendling Date: 2022-02-15T00:06:58-08:00 New Revision: 86bde99a9027f875383e38bfd3a863abae3d0e75 URL: https://github.com/llvm/llvm-project/commit/86bde99a9027f875383e38bfd3a863abae3d0e75 DIFF: https://github.com/llvm/llvm-project/commit/86bde99a9027f875383e38bfd3a863abae3d0e75.diff

[PATCH] D119592: Insert a blurb about the -fzero-call-used-regs feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG86bde99a9027: Insert a blurb about the -fzero-call-used-regs feature (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119592/new/

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:470 +ShouldMerge = Style.AllowShortEnumsOnASingleLine; + } else if (TheLine->Last->isOneOf(TT_ClassLBrace, TT_StructLBrace))

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

t.p.northover added a comment. Things have moved on since the ARM and (especially) PPC variants of that function were written. That field (despite the name) is now more of an ABI tag and not going to be updated with each CPU. I think the modern replacement for it is `hw.cpufamily` obtained

[PATCH] D119726: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 408780. glider added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119726/new/ https://reviews.llvm.org/D119726 Files: clang/docs/AddressSanitizer.rst

[PATCH] D119726: [asan] Add support for disable_sanitizer_instrumentation attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd145f953db3: [asan] Add support for disable_sanitizer_instrumentation attribute (authored by glider). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] dd145f9 - [asan] Add support for disable_sanitizer_instrumentation attribute

Author: Alexander Potapenko Date: 2022-02-15T14:06:12+01:00 New Revision: dd145f953db3dafbc019f1d3783bb4f09a28af92 URL: https://github.com/llvm/llvm-project/commit/dd145f953db3dafbc019f1d3783bb4f09a28af92 DIFF:

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

urnathan added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:817-824 +#if 0 + case Module::ModuleHeaderUnit: +return "Header Unit"; + case Module::ModulePartitionInterface: +return "Partition Interface"; + case

[PATCH] D119838: Revert "[asan] Add support for disable_sanitizer_instrumentation attribute"

glider created this revision. glider added reviewers: melver, eugenis. Herald added a subscriber: hiraditya. glider requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a

[PATCH] D118587: [C++20][Modules] Handle generation of partition implementation CMIs.

iains created this revision. iains updated this revision to Diff 405593. iains added a comment. iains updated this revision to Diff 408762. iains updated this revision to Diff 408862. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:186 void VisitCallExpr(const CallExpr *E) { FoundCallExpr = true; } + void VisitAsmStmt(const AsmStmt *S) { FoundCallExpr = true; } xbolva00 wrote: > pengfei wrote: > >

[PATCH] D119825: [clang][lex] Introduce `SearchDirIndex` to usage tracking code

jansvoboda11 updated this revision to Diff 408876. jansvoboda11 added a comment. Move `SearchDirIdx::get()` to `HeaderSearch` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119825/new/ https://reviews.llvm.org/D119825 Files:

[PATCH] D119615: [CUDA][HIP] Do not promote constexpr var with non-constant initializer

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:148-150 + if ((Var->isConstexpr() || Var->getType().isConstQualified()) && + Var->hasAttr() && !hasExplicitAttr(Var)) tra wrote: > So the

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

Trass3r added a comment. Is it intentional that the resolved type is not shown in the variable hover: param payload Type: const auto & // In subscribe::(anonymous class)::operator() const auto& payload Only when hovering over `auto`? type-alias auto struct Foo Repository: rG

[PATCH] D118598: [C++20][Modules] Find the primary interface name for a module.

iains created this revision. Herald added a subscriber: dexonsmith. iains updated this revision to Diff 405600. iains added a comment. iains updated this revision to Diff 408765. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project:

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jhuber6 updated this revision to Diff 408904. jhuber6 added a comment. Add test for the arguments passed to the linker wrapper when doing host offloading. It will be more difficult to do a unit test for the internal operation of the linker wrapper because it is reactive to the data contained in

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

svenvh added a comment. In D119560#3322531 , @Anastasia wrote: >> also makes the header no longer "claim" the identifiers "success", >> "failure", "desired", "value" (such that you can compile with -Dvalue=... >> when including the header for example,

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118753/new/ https://reviews.llvm.org/D118753

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

iains created this revision. Herald added a subscriber: dexonsmith. iains updated this revision to Diff 404447. iains added a comment. iains retitled this revision from "[modules] Add enumerations for partition modules and stream them." to "[C++20][Modules] Add enumerations for partition modules

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl created this revision. aprantl added reviewers: dexonsmith, arphaman. aprantl requested review of this revision. This patch adds a new Darwin clang driver environment variable in the spirit of RC_DEBUG_OPTIONS, called RC_DEBUG_PREFIX_MAP, which allows a meta build tool to add one

[PATCH] D119814: [clang-format] Honour PointerAlignment in statements with initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe21db15be812: [clang-format] Honour PointerAlignment in statements with initializers. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e21db15 - [clang-format] Honour PointerAlignment in statements with initializers.

Author: Marek Kurdej Date: 2022-02-15T18:06:32+01:00 New Revision: e21db15be8126004304b813e5ff87c7ecbed06bf URL: https://github.com/llvm/llvm-project/commit/e21db15be8126004304b813e5ff87c7ecbed06bf DIFF: https://github.com/llvm/llvm-project/commit/e21db15be8126004304b813e5ff87c7ecbed06bf.diff

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

egorzhdan added a comment. Thank you @dgoldman, this approach looks good to me. I don't have anything to add other than what @sammccall has already commented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/

[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

Anastasia added a comment. In D119560#3322582 , @svenvh wrote: > In D119560#3322531 , @Anastasia > wrote: > >>> also makes the header no longer "claim" the identifiers "success", >>> "failure", "desired",

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

Anastasia added a comment. In D119398#3322547 , @haonanya wrote: > Hi, @Anastasia. Please help to land it, thanks very much. Sure, I will kindly ask @svenvh since he has some related patches to land too. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:186 void VisitCallExpr(const CallExpr *E) { FoundCallExpr = true; } + void VisitAsmStmt(const AsmStmt *S) { FoundCallExpr = true; } aaron.ballman wrote: > xbolva00 wrote: > >

[PATCH] D119825: [clang][lex] Introduce `SearchDirIndex` to usage tracking code

jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:185 + /// Get search directory stored at the index. + DirectoryLookup (HeaderSearch ) const; +}; ahoppen wrote: > I would have expected these to be methods on

[PATCH] D119842: [clangd] NFC: Cleanup IncludeCleaner API

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Make a further

[PATCH] D118599: [C++20][Modules] Amend module visibility rules for partitions.

iains created this revision. iains updated this revision to Diff 405601. iains added a comment. iains updated this revision to Diff 408766. iains updated this revision to Diff 408866. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains updated this revision to Diff 408892. iains published

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119713/new/ https://reviews.llvm.org/D119713 ___ cfe-commits mailing list

[PATCH] D119727: [RISCV] Add the policy operand for nomask vector Multiply-Add IR intrinsics.

khchen updated this revision to Diff 408840. khchen added a comment. Rebase and refine code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119727/new/ https://reviews.llvm.org/D119727 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua updated this revision to Diff 408847. li.zhe.hua added a comment. Remove old constructor Not sure how to resolve the ambiguous constructor issue on MSVC. This is probably SFINAE-able, but not sure how to repro locally to iterate. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e3235f604d: [libTooling] Change Tranformers consumer to take multiple changes (authored by li.zhe.hua, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d1e3235 - [libTooling] Change Tranformer's consumer to take multiple changes

Author: Eric Li Date: 2022-02-15T16:34:36Z New Revision: d1e3235f604d65a62d25842305f54e43bd36681f URL: https://github.com/llvm/llvm-project/commit/d1e3235f604d65a62d25842305f54e43bd36681f DIFF: https://github.com/llvm/llvm-project/commit/d1e3235f604d65a62d25842305f54e43bd36681f.diff LOG:

[PATCH] D119095: [clang] Fix redundant functional cast in ConstantExpr

kimgr added a comment. Thanks for the heads-up! I'm a little busy this week, but I need to think about potential interference between these two changes. Off the top of my head it looks like they should get along fine, but there may be subtleties. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:686 +return; + if (!StringRef(GlobalRemapEntry).contains('=')) +D.Diag(diag::err_drv_invalid_argument_to_option) Suggestion: It might be good to factor out the code that

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added a subscriber: NoQ. steakhal added a comment. Thank you @OikawaKirie for the thorough investigation and explanation, even annotations and examples. I really appreciate it. However, you already surpassed my knowledge regarding the frontend, cc1, and other driver magic

  1   2   3   >