[PATCH] D118586: [C++20][Modules] Initial handling for module partitions.

iains updated this revision to Diff 409201. iains added a comment. Update to rebase on changes to parent patches and formatting checks. while doing this made a check for module partitions more efficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. thanks for indexing the subject lines! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114714/new/ https://reviews.llvm.org/D114714

[PATCH] D118587: [C++20][Modules] Handle generation of partition implementation CMIs.

iains updated this revision to Diff 409202. iains added a comment. rebased onto changes in parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118587/new/ https://reviews.llvm.org/D118587 Files: clang/include/clang/Sema/Sema.h

[PATCH] D118588: [C++20][Modules] Diagnose wrong import/export for partition CMIs.

iains updated this revision to Diff 409203. iains added a comment. rebased onto changes in parent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118588/new/ https://reviews.llvm.org/D118588 Files:

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

iains updated this revision to Diff 409187. iains added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114714/new/ https://reviews.llvm.org/D114714 Files: clang/include/clang/Basic/Module.h

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

MattDevereau created this revision. MattDevereau added reviewers: georges, peterwaller-arm, paulwalker-arm, DavidTruby, bsmith, teemperor, rjmccall, qiucf. Herald added a subscriber: kristof.beyls. MattDevereau requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

iains marked 4 inline comments as done. iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:109 -/// This is a C++ Modules TS module interface unit. +/// This is a C++ Modules TS or C++20 module interface unit. ModuleInterfaceUnit,

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

paulwalker-arm added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1117 CanQualType BFloat16Ty; - CanQualType Float16Ty; // C11 extension ISO/IEC TS 18661-3 + CanQualType Float16Ty, Float16ComplexTy; // C11 extension ISO/IEC TS 18661-3 CanQualType

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

peterwaller-arm added a comment. Some comments. Comment at: clang/include/clang/AST/ASTContext.h:1117 CanQualType BFloat16Ty; - CanQualType Float16Ty; // C11 extension ISO/IEC TS 18661-3 + CanQualType Float16Ty, Float16ComplexTy; // C11 extension ISO/IEC TS 18661-3

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

fhahn added a reviewer: aaron.ballman. fhahn added inline comments. Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:1 +// RUN: %clang_cc1 %s -O1 -emit-llvm -triple aarch64-unknown-unknown -ffast-math -o - | FileCheck %s --check-prefix=AARCH64 +

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Izaron created this revision. Izaron added reviewers: mizvekov, Quuxplusone, sammccall, rsmith, doug.gregor. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a preliminary patch ahead of D119792

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added a comment. This review will wait for D119927 to be merged, as it adds more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119792/new/ https://reviews.llvm.org/D119792

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks updated this revision to Diff 409195. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a reviewer: Quuxplusone. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 Files:

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

hokein added a comment. Thanks, this looks good in general. I only reviewed the token part, but don't want to block the review. I think it might be nice to split out the preprocessor part from this patch, this would make the scope clearer and review efficient (sorry, quite busy with other

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

lebedev.ri added subscribers: cfe-commits, lebedev.ri. lebedev.ri added a comment. Looks like the lists weren't subscribed for the review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___

[libunwind] 2d2ef38 - [libunwind] Only include cet.h if __CET__ defined

Author: Nikita Popov Date: 2022-02-16T09:45:54+01:00 New Revision: 2d2ef384b2f6e723edb793d08f52e7f4dc94ba3a URL: https://github.com/llvm/llvm-project/commit/2d2ef384b2f6e723edb793d08f52e7f4dc94ba3a DIFF: https://github.com/llvm/llvm-project/commit/2d2ef384b2f6e723edb793d08f52e7f4dc94ba3a.diff

[PATCH] D119923: [clang-format][NFC] Return early in ContinuationIndenter::mustBreak

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay updated this revision to Diff 409171. MaskRay edited the summary of this revision. MaskRay added a comment. Detect both unnormalized and normalized paths for compatibility. hack when default -DLLVM_DEFAULT_TARGET_TRIPLE is x86_64-unknown-linux-gnu on Debian.

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

labath added a comment. Not my usual wheelhouse, but since I'm here, here are some of my thoughts: - reusing the existing solution/code seems like a good idea -- no need to reinvent the wheel - how does that work, actually? How does it differentiate between "my" code and "code that happens to

[clang] 4642c64 - [analyzer] Remove breaking RUN line in the test case

Author: Balazs Benics Date: 2022-02-16T10:56:18+01:00 New Revision: 4642c640f4ef76b7e98420c98b7391f069293838 URL: https://github.com/llvm/llvm-project/commit/4642c640f4ef76b7e98420c98b7391f069293838 DIFF: https://github.com/llvm/llvm-project/commit/4642c640f4ef76b7e98420c98b7391f069293838.diff

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

This revision was automatically updated to reflect the committed changes. Closed by commit rG4642c640f4ef: [analyzer] Remove breaking RUN line in the test case (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D118690?vs=406845=409175#toc Repository: rG LLVM Github

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains marked 5 inline comments as done. iains added a comment. also reformatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 ___ cfe-commits mailing list

[PATCH] D119923: [clang-format][NFC] Return early in ContinuationIndenter::mustBreak

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. CI is happy, I'm happy :). LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119923/new/ https://reviews.llvm.org/D119923

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 409167. qiucf edited the summary of this revision. qiucf added a comment. Rebase the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files:

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

iains added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + ChuanqiXu wrote: > According to [[ > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html | > P1857R3 ]], it might not be good to add

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3324970 , @phosek wrote: > In D110663#3271084 , @MaskRay wrote: > >> No worries! Thanks for the reply. >> >> I use Debian and want it to work well and support the >>

[clang] b3c0014 - Revert "Revert "[analyzer] Prevent misuses of -analyze-function""

Author: Balazs Benics Date: 2022-02-16T10:33:21+01:00 New Revision: b3c0014e5a7530645f502d8b19ef1df313cc85b9 URL: https://github.com/llvm/llvm-project/commit/b3c0014e5a7530645f502d8b19ef1df313cc85b9 DIFF: https://github.com/llvm/llvm-project/commit/b3c0014e5a7530645f502d8b19ef1df313cc85b9.diff

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

rovka added a comment. Is this going to break for everyone that still passes TARGET_TRIPLE to cmake? If so, we should probably have a period where we support both. In particular, this might break some of our buildbots

[PATCH] D118893: [C++20][Modules] Track valid import state.

iains updated this revision to Diff 409178. iains marked 2 inline comments as not done. iains added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 Files:

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

steakhal added a comment. I've decided to remove the offending RUN lines. It's less than ideal, but TBH I think it doesn't really matter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added a reviewer: keith. steakhal added a subscriber: keith. steakhal added a comment. Hi @keith, I've seen you commented on a clang driver-related issue: "Why does march=native not work on Apple M1?" You

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

ChuanqiXu added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + iains wrote: > ChuanqiXu wrote: > > According to [[ > > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html | > > P1857R3 ]], it

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 409173. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

khchen added a comment. In D70401#3325419 , @zixuan-wu wrote: > It's difficult to run llvm-test-suite in ilp32e abi in Linux. Because there > are no workable environment such as runtime and kernel for ilp32e in GNU > series tools. > And we can not run

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

azabaznov accepted this revision. azabaznov added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119719/new/ https://reviews.llvm.org/D119719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 477bc8e - [OpenCL] Guard atomic_double with cl_khr_int64_*

Author: Sven van Haastregt Date: 2022-02-16T10:07:35Z New Revision: 477bc8e8b9311fdac4c360b1fe7d29d0d10aac6c URL: https://github.com/llvm/llvm-project/commit/477bc8e8b9311fdac4c360b1fe7d29d0d10aac6c DIFF: https://github.com/llvm/llvm-project/commit/477bc8e8b9311fdac4c360b1fe7d29d0d10aac6c.diff

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rG477bc8e8b931: [OpenCL] Guard atomic_double with cl_khr_int64_* (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D119398?vs=407506=409179#toc Repository: rG LLVM Github

[clang] 082f328 - [clang] Itanium mangler constructors

Author: Nathan Sidwell Date: 2022-02-16T04:30:47-08:00 New Revision: 082f328899be9ed8a38b04a4e52be936f4875495 URL: https://github.com/llvm/llvm-project/commit/082f328899be9ed8a38b04a4e52be936f4875495 DIFF:

[PATCH] D119550: [clang] Itanium mangler constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG082f328899be: [clang] Itanium mangler constructors (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. Actually, based on the build bot pre-merge checks, it looks like something during self-build has hit your assert!

[clang] fe3407a - [CGBuilder] Assert that CreateAddrSpaceCast does not change element type

Author: Nikita Popov Date: 2022-02-16T15:17:08+01:00 New Revision: fe3407a91b6dcc1100c0b30187aa8c9587c73cad URL: https://github.com/llvm/llvm-project/commit/fe3407a91b6dcc1100c0b30187aa8c9587c73cad DIFF: https://github.com/llvm/llvm-project/commit/fe3407a91b6dcc1100c0b30187aa8c9587c73cad.diff

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Relanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. > Oh, I added a NFC fix previously in > https://github.com/llvm/llvm-project/commit/25cdf87b13eb990eb84d31211280f4b0d5d470b3. > I think it should be reverted too? I am going to revert it. I did that in 5d110ed4cd4

[PATCH] D119837: [RISCV] Fix the include search path order between sysroot and resource folder

abidh added a comment. In D119837#3326179 , @asb wrote: > Thanks Kito. This LGTM, but I'd appreciate someone else reviewing and > approving as well. Looks ok to me too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

hokein added a comment. comments on preprocessor part. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Preprocess.h:49 +/// | `printf("hello, "); +/// |-+ Conditional -+ Directive #ifndef NDEBUG +/// | |-+ Code

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

iains added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + urnathan wrote: > urnathan wrote: > > ChuanqiXu wrote: > > > iains wrote: > > > > ChuanqiXu wrote: > > > > > According to [[ > > > > >

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone added a comment. I'll update with the `CodeSynthesisContext` approach in a little bit. But meanwhile there's a problem with both the current patch //and// (I think even more) with the new approach. @rsmith any help?: When I try my latest patch with the libc++ tests, with

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

sgatev updated this revision to Diff 409296. sgatev added a comment. Remove unnecessary IgnoreParens calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119953/new/ https://reviews.llvm.org/D119953 Files:

[PATCH] D118589: [C++20][Modules] Record direct module imports.

iains updated this revision to Diff 409205. iains added a comment. rebased onto changes in parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 Files: clang/include/clang/Sema/Sema.h

[PATCH] D119713: [Docs] Release 14 notes for SPIR-V in clang

Anastasia closed this revision. Anastasia added a comment. Committed https://github.com/llvm/llvm-project/commit/b54c95790b8a410b8eab1cbaae306cdc56a8e82a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119713/new/ https://reviews.llvm.org/D119713

[PATCH] D119710: [Docs][OpenCL] Release 14 notes

Anastasia closed this revision. Anastasia added a comment. Committed https://github.com/llvm/llvm-project/commit/e8712accba1150b94168d8ace6c7dd7b9612e174 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119710/new/ https://reviews.llvm.org/D119710

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

curdeius accepted this revision. curdeius added a comment. LGTM. Maybe you can add a minimal test in `FormatTest.cpp` though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 ___ cfe-commits mailing

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8205 +if (llvm::find(LibraryArgs, "m") == LibraryArgs.end() && !D.CCCIsCXX()) + continue; + JonChesterfield wrote: > jdoerfert wrote: > > JonChesterfield wrote: > > >

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

asb added a comment. I think all my comments have been addressed. @craig.topper - are you happy your RegInfo question is addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298

[clang] 572e2cd - Reverting ce420820c815e806bab9c5f17cb3b829a616548a because it fails expensive checks

Author: Rashmi Mudduluru Date: 2022-02-16T09:25:53-08:00 New Revision: 572e2cd56a43429bdbc88c886e260b5facff9048 URL: https://github.com/llvm/llvm-project/commit/572e2cd56a43429bdbc88c886e260b5facff9048 DIFF:

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman added a comment. Continues to LGTM, though I had a recommendation for the release note. Feel free to land when you'd like. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` +

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1117 CanQualType BFloat16Ty; - CanQualType Float16Ty; // C11 extension ISO/IEC TS 18661-3 + CanQualType Float16Ty, Float16ComplexTy; // C11 extension ISO/IEC TS 18661-3 CanQualType

[libunwind] 641a141 - [runtimes] Deprecate FOO_SYSROOT & friends

Author: Louis Dionne Date: 2022-02-16T09:44:08-05:00 New Revision: 641a141da1f22de319e891bdfd61e614632b39f0 URL: https://github.com/llvm/llvm-project/commit/641a141da1f22de319e891bdfd61e614632b39f0 DIFF: https://github.com/llvm/llvm-project/commit/641a141da1f22de319e891bdfd61e614632b39f0.diff

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8195 + // Get the AMDGPU math libraries. + // FIXME: This method is bad, remove once AMDGPU has a proper math library. + for (auto : llvm::make_range(OpenMPTCRange.first, OpenMPTCRange.second)) {

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

urnathan added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + ChuanqiXu wrote: > iains wrote: > > ChuanqiXu wrote: > > > According to [[ > > > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html |

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks updated this revision to Diff 409237. HazardyKnusperkeks added a comment. Formatting Test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893 Files: clang/lib/Format/UnwrappedLineParser.cpp

[clang] 6690b7d - [OpenCL] Ensure atomic_init is guarded with extension

Author: Sven van Haastregt Date: 2022-02-16T15:12:23Z New Revision: 6690b7d3ac9ab6410b7909207552ce4edbe2147b URL: https://github.com/llvm/llvm-project/commit/6690b7d3ac9ab6410b7909207552ce4edbe2147b DIFF: https://github.com/llvm/llvm-project/commit/6690b7d3ac9ab6410b7909207552ce4edbe2147b.diff

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

thakis added a comment. (I wish there was a flag that said "clang, never ever read any env vars please". Some people think that builds should be deterministic and not depend on random env vars people might have set (and then not do correct incremental rebuilds when the value of such env var

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 409241. vtjnash added a comment. add one more missing case to check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl added a comment. In D119850#3326266 , @thakis wrote: > (I wish there was a flag that said "clang, never ever read any env vars > please". Some people think that builds should be deterministic and not depend > on random env vars people might

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

JonChesterfield added a comment. This is asserting somewhere in clang-linker-wrapper, e.g. https://lab.llvm.org/buildbot/#/builders/193/builds/6939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.org/D119841

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

ronlieb added a comment. Hi Joseph, seems to have broken amdgpu buildbit, please revert and fix ? https://lab.llvm.org/buildbot/#/builders/193/builds/6939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.org/D119841

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:523-524 + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); +if (pos == std::string::npos) + return Name; urnathan wrote: >

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

shchenz added a comment. > hiding the semantics from the optimizer is sometimes a good thing and > sometimes a bad thing). Agree. Imagining a case when the neg and fma (from fnmsub) can both be CSE-ed with another neg and fma, so we can totally eliminate the fnmsub. But after we convert it to

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

urnathan added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[clang] 5781839 - Revert "[OpenMP] Pass AMDGPU math libraries into the linker wrapper"

Author: Joseph Huber Date: 2022-02-16T11:54:44-05:00 New Revision: 5781839f7a348d4f942e6c7ee5d720e93517022a URL: https://github.com/llvm/llvm-project/commit/5781839f7a348d4f942e6c7ee5d720e93517022a DIFF: https://github.com/llvm/llvm-project/commit/5781839f7a348d4f942e6c7ee5d720e93517022a.diff

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC]

[clang] fdee512 - [clang-format] Add test for SpacesInLineCommentPrefix. NFC.

Author: Marek Kurdej Date: 2022-02-16T13:54:55+01:00 New Revision: fdee51204848dce5e0c39db332a7c488dc5b333f URL: https://github.com/llvm/llvm-project/commit/fdee51204848dce5e0c39db332a7c488dc5b333f DIFF: https://github.com/llvm/llvm-project/commit/fdee51204848dce5e0c39db332a7c488dc5b333f.diff

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

urnathan added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2989 /// \param ImportLoc The location of the 'import' keyword. - /// \param Path The module access path. + /// \param NamePath The module toplevel name as an access path. + /// \param Partition

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

urnathan added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2654-2656 +if (!C.hasSameType(DefaultArgumentX->getType(), + DefaultArgumentY->getType())) + return false; Can this ever trigger and the below expression

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

urnathan added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + urnathan wrote: > ChuanqiXu wrote: > > iains wrote: > > > ChuanqiXu wrote: > > > > According to [[ > > > >

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. with the assert fixed Comment at: clang/lib/Sema/SemaModule.cpp:119 +default: + assert(0 && "how did we get a partition type set?"); +}

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

curdeius accepted this revision. curdeius added a comment. In D119893#3326247 , @HazardyKnusperkeks wrote: > Formatting Test added. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119893/new/ https://reviews.llvm.org/D119893

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added a comment. In D119841#3326638 , @JonChesterfield wrote: > This is asserting somewhere in clang-linker-wrapper, e.g. > https://lab.llvm.org/buildbot/#/builders/193/builds/6939 Yes, must be when we try to sort the device files. I'll revert

[PATCH] D118599: [C++20][Modules] Amend module visibility rules for partitions.

iains updated this revision to Diff 409211. iains added a comment. rebased onto changes in parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118599/new/ https://reviews.llvm.org/D118599 Files: clang/lib/Sema/SemaLookup.cpp

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8205 +if (llvm::find(LibraryArgs, "m") == LibraryArgs.end() && !D.CCCIsCXX()) + continue; + jdoerfert wrote: > JonChesterfield wrote: > > jhuber6 wrote: > > >

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis updated this revision to Diff 409243. thakis added a comment. undo no_deduplicate bit again for now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-ld-lto.c

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis updated this revision to Diff 409254. thakis added a comment. Pass `-B` with `-fuse-ld=lld` since the latter flag only has an effect if ld64.lld exists on disk, and clang/test doesn't depend on lld (and shouldn't). Also move object_path_lto to its own file since it can run fine on

[clang] 597f2bc - [clang] [test] [NFC] Eliminate some hard tabs in tests

Author: Arthur O'Dwyer Date: 2022-02-16T10:42:58-05:00 New Revision: 597f2bcee895c1a9cc18067b85d6846137c11816 URL: https://github.com/llvm/llvm-project/commit/597f2bcee895c1a9cc18067b85d6846137c11816 DIFF:

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire created this revision. junaire added reviewers: aaron.ballman, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. junaire requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The ElaboratedType can have no

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:522 + + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); Is it possible to return a StringRef rather than a copy? Repository:

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG61fb260d9d8c: [OpenMP] Pass AMDGPU math libraries into the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/

[clang] 61fb260 - [OpenMP] Pass AMDGPU math libraries into the linker wrapper

Author: Joseph Huber Date: 2022-02-16T11:39:11-05:00 New Revision: 61fb260d9d8c26a61a8dfd64e94d51f2c9a06830 URL: https://github.com/llvm/llvm-project/commit/61fb260d9d8c26a61a8dfd64e94d51f2c9a06830 DIFF: https://github.com/llvm/llvm-project/commit/61fb260d9d8c26a61a8dfd64e94d51f2c9a06830.diff

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d59cfc67ead: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also (authored by vtjnash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/

[clang] 9d59cfc - clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

Author: Jameson Nash Date: 2022-02-16T11:59:09-05:00 New Revision: 9d59cfc67eadbe4b4088d70f8bbc61c96568d2f1 URL: https://github.com/llvm/llvm-project/commit/9d59cfc67eadbe4b4088d70f8bbc61c96568d2f1 DIFF: https://github.com/llvm/llvm-project/commit/9d59cfc67eadbe4b4088d70f8bbc61c96568d2f1.diff

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash added a comment. Okay, this should work now for those cases! Sorry, I kept thinking it was clang/examples that was broken, and missed that it was clang/test that was failing, so I failed to see what I needed to fix there too, so that we were not trying to build the tests in

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM this time. Thanks very much for the rework! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:523-524 + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); +if (pos == std::string::npos) + return Name; iains wrote: >

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Quuxplusone added a comment. Excellent! Comment at: clang/test/CodeGenCXX/nrvo.cpp:622 + if (b) +return x; + else Similar to what you did in `test5`, I think it'd be helpful to comment //on the return line itself// whether NRVO is

[PATCH] D118598: [C++20][Modules] Find the primary interface name for a module.

iains updated this revision to Diff 409209. iains added a comment. rebased onto changes in parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/clang/Basic/Module.h

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdd615d4f91f: [Docs][OpenCL] Update OpenCL 3.0 status in docs. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project:

[clang] fdd615d - [Docs][OpenCL] Update OpenCL 3.0 status in docs.

Author: Anastasia Stulova Date: 2022-02-16T12:32:20Z New Revision: fdd615d4f91f7bbbf83e4ea6ca45dafb7abc2fa7 URL: https://github.com/llvm/llvm-project/commit/fdd615d4f91f7bbbf83e4ea6ca45dafb7abc2fa7 DIFF: https://github.com/llvm/llvm-project/commit/fdd615d4f91f7bbbf83e4ea6ca45dafb7abc2fa7.diff

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

MattDevereau updated this revision to Diff 409236. MattDevereau added a comment. Removed -O1 and -ffast-math flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119926/new/ https://reviews.llvm.org/D119926 Files: clang/lib/AST/ASTContext.cpp

  1   2   >