[PATCH] D121873: [clang][extract-api] Add enum support

zixuw updated this revision to Diff 417424. zixuw added a comment. Rebase on main with changed and merged refactoring in D122160 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121873/new/

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 created this revision. xbolva00 added reviewers: efriedma, yonghong-song. Herald added a project: All. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang fails to diagnose: void test() { int j = 0; for

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417435. yihanaa added a reviewer: xbolva00. yihanaa added a comment. Remove code formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 Files:

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3400408 , @xbolva00 wrote: >>> the remaining changes are code formatting > > Please remove code formatting changes. Okay, i have removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417439. yihanaa added a comment. Remove useless comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:176-188 const char IncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; +R"(^[\t\ ]*[@#][\t\ ]*(import|include)([^"]*("[^"]+")|[^<]*(<[^>]+>)|[\t\

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417461. rZhBoYao retitled this revision from "[clang] Fix PR28101" to "[Clang] Fix PR28101". rZhBoYao edited the summary of this revision. rZhBoYao added a reviewer: cor3ntin. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___ cfe-commits mailing list

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu updated this revision to Diff 417479. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 Files: clang/lib/AST/Decl.cpp clang/unittests/AST/DeclTest.cpp Index:

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added a comment. In D121951#3393928 , @sameerds wrote: > In D121951#3392470 , @scott.linder > wrote: > >> In D121951#3391472 , @sameerds >> wrote: >> >>>

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. This is okay with me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141

[clang] 3210360 - [Inline-asm] Add diagnosts for unsupported inline assembly arguments

Author: Phoebe Wang Date: 2022-03-23T11:25:19+08:00 New Revision: 32103608fc073700f04238872d8b22655ddec3fb URL: https://github.com/llvm/llvm-project/commit/32103608fc073700f04238872d8b22655ddec3fb DIFF: https://github.com/llvm/llvm-project/commit/32103608fc073700f04238872d8b22655ddec3fb.diff

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32103608fc07: [Inline-asm] Add diagnosts for unsupported inline assembly arguments (authored by pengfei). Repository: rG LLVM Github Monorepo

[clang] b62d402 - [NFC][clang][extract-api] Use proper name string for Objective-C language

Author: Zixu Wang Date: 2022-03-22T14:18:26-07:00 New Revision: b62d40216f4742d46b1d2942617cf567e74272c4 URL: https://github.com/llvm/llvm-project/commit/b62d40216f4742d46b1d2942617cf567e74272c4 DIFF: https://github.com/llvm/llvm-project/commit/b62d40216f4742d46b1d2942617cf567e74272c4.diff

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

hvdijk added a comment. In D118935#3399095 , @Fznamznon wrote: > I was under impression that the change is small and therefore easy to > understand. Would some comment like "SYCL re-uses OpenCL mode diagnostics to > emit errors in case the cast happens

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852 +int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx); + +EmitStmt(StaticWhenClauses[BestIdx]->getDirective()); This approach is valid for static

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

wenlei added a comment. The linter warning seems legit, otherwise looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 ___ cfe-commits mailing list

[PATCH] D122202: [clang][extract-api] Add struct support

zixuw updated this revision to Diff 417438. zixuw marked 3 inline comments as done. zixuw added a comment. Address review issues: fix Symbol Graph struct kind identifiers and display names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122202/new/

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2570 + State, TotalSize.castAs(), + svalBuilder.makeIntValWithPtrWidth(Arg1->getType(), 0)); NoQ wrote: >

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

sammccall added a subscriber: rsmith. sammccall added a comment. In D121824#3400720 , @hokein wrote: > Sorry, I thought this crash is fixed as a bonus effort by improving the AST > for reference-type var-decl. > > Beyond the crash cased by the

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:2692-2695 + for (int i = Matches.size() - 1; i > 0; i--) { +if (!Matches[i].empty()) + return Matches[i]; + } I think you missed `Matches[0]`. Comment at:

[clang] 6edfe45 - [AVR] Add more devices

Author: Ben Shi Date: 2022-03-23T02:00:15Z New Revision: 6edfe45a63125a8938a5bea13534a118b0e31023 URL: https://github.com/llvm/llvm-project/commit/6edfe45a63125a8938a5bea13534a118b0e31023 DIFF: https://github.com/llvm/llvm-project/commit/6edfe45a63125a8938a5bea13534a118b0e31023.diff LOG:

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. @shafik, can you please check the patch? Or maybe recommend somebody who worked both on ASTStructuralEquivalence and Objective-C part of clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu added a comment. @iains ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

hokein added a comment. Sorry, I thought this crash is fixed as a bonus effort by improving the AST for reference-type var-decl. Beyond the crash cased by the dependent-type `RecoveryExpr` built in `Sema::BuildDeclarationNameExpr`, I think there is another issue which is worth fixing: whether

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. @tonic, can you please have another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 ___ cfe-commits mailing list

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

ributzka added inline comments. Comment at: clang/include/clang/SymbolGraph/FrontendActions.h:35 + /// This is called before executing the action on any inputs. This merges all + /// the provided headers into a single header for processing. + bool

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

ChuanqiXu added a comment. In D122119#3400032 , @urnathan wrote: > In D122119#3398949 , @ChuanqiXu > wrote: > >> > > > >> The first feeling I saw the change is that not every C++ programmer knows >> about

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417475. rZhBoYao added a comment. Don't break template declarations. re-clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added a comment. Thanks @jyu2 ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ created this revision. NoQ added reviewers: t-rasmud, Szelethus, martong, steakhal, ASDenysPetrov, balazske, gamesh411. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. NoQ requested

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 417502. pengfei added a comment. clang-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 Files: clang/include/clang/CodeGen/CGFunctionInfo.h

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#3398808 , @JonChesterfield wrote: > It lets applications run with the libomp and libomptarget built with the > toolchain. For users, they don't have to be root. For compiler devs, we test > our work instead of

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:41 // -// The following standard C functions are currently supported: -// This comment has been out of date for years and I don't think it makes sense to

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! I agree that this assertion doesn't make much sense. Judging by the name, the function should be able to handle all symbols. Comment at:

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

yonghong-song added a comment. LGTM. Maybe @efriedma can look at this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122271/new/ https://reviews.llvm.org/D122271 ___ cfe-commits mailing list

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske added inline comments. Herald added a project: All. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:153 +diag(HandlerLambda->getBeginLoc(), + "lambda function is not allowed as signal handler (until C++17)") +<<

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos planned changes to this revision. pmatos added a comment. Test `wasm-funcref.c` still fails as type attribute `funcref` semantics are not yet implemented. Not ready to land yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good! please update the description of the patch accordingly (saying we invalidate the vardecl) Comment at: clang/test/SemaCXX/arrow-operator.cpp:79 +void

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

ChuanqiXu added a comment. In D122119#3398823 , @iains wrote: > So the adjustment to the error message is something I am 50/50 about (IMO it > makes some messages more useful, but maybe not needed in others). > > Without the change we get > "cannot

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains marked 2 inline comments as done. iains added a comment. In D122119#3398949 , @ChuanqiXu wrote: > In D122119#3398823 , @iains wrote: > >> So the adjustment to the error message is something I am 50/50 about

[clang] 9ab18cc - [RISCV] Add policy operand for masked vid and viota IR intrinsics.

Author: Zakk Chen Date: 2022-03-22T02:32:31-07:00 New Revision: 9ab18cc535379c3442bf52e21fbe21c92eb0fd60 URL: https://github.com/llvm/llvm-project/commit/9ab18cc535379c3442bf52e21fbe21c92eb0fd60 DIFF: https://github.com/llvm/llvm-project/commit/9ab18cc535379c3442bf52e21fbe21c92eb0fd60.diff

[PATCH] D120227: [RISCV] Add policy operand for masked vid and viota IR intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab18cc53537: [RISCV] Add policy operand for masked vid and viota IR intrinsics. (authored by khchen). Herald added subscribers: s, StephenFan,

[PATCH] D122139: [pseudo] Introduce parse forest.

hokein updated this revision to Diff 417225. hokein marked 7 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122139/new/ https://reviews.llvm.org/D122139 Files:

[clang] 767ec88 - [CodeGen] Avoid deprecated Address ctor in EmitLoadOfPointer()

Author: Nikita Popov Date: 2022-03-22T09:42:31+01:00 New Revision: 767ec883e37510a247ea5695921876ef67cf5b3f URL: https://github.com/llvm/llvm-project/commit/767ec883e37510a247ea5695921876ef67cf5b3f DIFF: https://github.com/llvm/llvm-project/commit/767ec883e37510a247ea5695921876ef67cf5b3f.diff

[clang] b8f0e12 - [CodeGen] Remove some uses of deprecated Address constructor

Author: Nikita Popov Date: 2022-03-22T10:02:35+01:00 New Revision: b8f0e12847f5df0792c816c995bc67759aea669e URL: https://github.com/llvm/llvm-project/commit/b8f0e12847f5df0792c816c995bc67759aea669e DIFF: https://github.com/llvm/llvm-project/commit/b8f0e12847f5df0792c816c995bc67759aea669e.diff

[PATCH] D121756: [clang-format] Clean up code looking for if statements

MyDeveloperDay added a comment. > It turned out this patch does change behavior. i.e. now your function is considering more things, the formatted code is different, do you think the new formatting is more correct? (I mean it feels like it should be right? assuming we want to consider whiles in

[clang] abe997b - [CMake][Fuchsia] Switch to lld on Apple platforms

Author: Petr Hosek Date: 2022-03-22T01:06:30-07:00 New Revision: abe997bb2dd61188784954ae866352740629985d URL: https://github.com/llvm/llvm-project/commit/abe997bb2dd61188784954ae866352740629985d DIFF: https://github.com/llvm/llvm-project/commit/abe997bb2dd61188784954ae866352740629985d.diff

[PATCH] D122047: [CMake][Fuchsia] Switch to lld on Apple platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rGabe997bb2dd6: [CMake][Fuchsia] Switch to lld on Apple platforms (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122047/new/

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. It lets applications run with the libomp and libomptarget built with the toolchain. For users, they don't have to be root. For compiler devs, we test our work instead of whatever the distro had installed. There's no info at that link. What's 'broken rpath'? If

[clang] 2ddd57a - [clang][dataflow] Model the behavior of optional and std swap

Author: Stanislav Gatev Date: 2022-03-22T08:35:34Z New Revision: 2ddd57ae1ec42c4aad8e70645cff82c877a94e3f URL: https://github.com/llvm/llvm-project/commit/2ddd57ae1ec42c4aad8e70645cff82c877a94e3f DIFF: https://github.com/llvm/llvm-project/commit/2ddd57ae1ec42c4aad8e70645cff82c877a94e3f.diff

[PATCH] D122129: [clang][dataflow] Model the behavior of optional and std swap

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ddd57ae1ec4: [clang][dataflow] Model the behavior of optional and std swap (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122129/new/

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos created this revision. pmatos added reviewers: tlively, asb. Herald added subscribers: StephenFan, wingo, dexonsmith, ecnelises, arphaman, martong, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a reviewer: shafik. Herald added a reviewer: aaron.ballman. Herald added a

[clang-tools-extra] 3e7a8aa - [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

Author: Martin Storsjö Date: 2022-03-22T11:08:32+02:00 New Revision: 3e7a8aab759a9bdf90f35a60ea6e96ec64e36cb9 URL: https://github.com/llvm/llvm-project/commit/3e7a8aab759a9bdf90f35a60ea6e96ec64e36cb9 DIFF:

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e7a8aab759a: [clang-tidy] Dont try to build CTTestTidyModule for Windows with dylibs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk added a comment. @MyDeveloperDay can you please have another look now that the patch has additional tests and most comments that still apply have been addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/

[PATCH] D121756: [clang-format] Clean up code looking for if statements

MyDeveloperDay added a comment. FWIW I'm not a fan of the `while( \n` case, so assuming this fix, fixes that then that would be good I think. - while ( - FormatTok->isOneOf(tok::identifier, tok::kw_requires, tok::coloncolon)) { + while (FormatTok->isOneOf(tok::identifier,

[clang-tools-extra] 1579090 - Reland "[pseudo] Split greatergreater token."

Author: Haojian Wu Date: 2022-03-22T10:27:52+01:00 New Revision: 1579090141c5cc061f3a0b62cd92bd93802ddcf7 URL: https://github.com/llvm/llvm-project/commit/1579090141c5cc061f3a0b62cd92bd93802ddcf7 DIFF: https://github.com/llvm/llvm-project/commit/1579090141c5cc061f3a0b62cd92bd93802ddcf7.diff

[PATCH] D121756: [clang-format] Clean up code looking for if statements

MyDeveloperDay added a comment. In D121756#3398165 , @sstwcw wrote: > It turned out this patch does change behavior. > > - while ( > - FormatTok->isOneOf(tok::identifier, tok::kw_requires, > tok::coloncolon)) { > + while

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains marked 2 inline comments as done. iains added subscribers: vsapsai, dblaikie. iains added a comment. So the adjustment to the error message is something I am 50/50 about (IMO it makes some messages more useful, but maybe not needed in others). Without the change we get "cannot export

[clang] a9656bd - [CodeGen][OpenMP] Make EmitLoadOfPointer() type consistent

Author: Nikita Popov Date: 2022-03-22T09:37:48+01:00 New Revision: a9656bd1bc3792b81ad5a7277bdf7d8159b3b924 URL: https://github.com/llvm/llvm-project/commit/a9656bd1bc3792b81ad5a7277bdf7d8159b3b924 DIFF: https://github.com/llvm/llvm-project/commit/a9656bd1bc3792b81ad5a7277bdf7d8159b3b924.diff

[PATCH] D122199: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in TargetInfo.cpp

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122199/new/ https://reviews.llvm.org/D122199 ___

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a subscriber: estewart08. JonChesterfield added a comment. @estewart08 Fedora are rejecting some uses of rpath (and probably runpath). I can't find a corresponding page for redhat. This may become a problem for our aomp/rocm builds. Repository: rG LLVM Github Monorepo

[clang] f42b195 - [CodeGen][RISCV] Avoid deprecated address constructor

Author: Nikita Popov Date: 2022-03-22T10:15:19+01:00 New Revision: f42b1954a0e85fadd421d5e345cb8343c410b34d URL: https://github.com/llvm/llvm-project/commit/f42b1954a0e85fadd421d5e345cb8343c410b34d DIFF: https://github.com/llvm/llvm-project/commit/f42b1954a0e85fadd421d5e345cb8343c410b34d.diff

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske added reviewers: martong, steakhal, NoQ. balazske added a comment. Herald added a subscriber: rnkovacs. This checker is made to add a partial support for CERT rule ERR30-C . One part of the rule is "check errno

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

NoQ accepted this revision. NoQ added a comment. All clear now. Amazing, thank you for your detailed response, I've corrected my understanding of address spaces so I'll be able to understand future patches better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 51ba13b - [CGStmtOpenMP] Remove uses of deprecated Address constructor

Author: Nikita Popov Date: 2022-03-22T11:00:08+01:00 New Revision: 51ba13b1aea3d6e04310b80b6bcfc641049b9890 URL: https://github.com/llvm/llvm-project/commit/51ba13b1aea3d6e04310b80b6bcfc641049b9890 DIFF: https://github.com/llvm/llvm-project/commit/51ba13b1aea3d6e04310b80b6bcfc641049b9890.diff

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM once the last few bits of feedback I left are considered. Comment at: clang/include/clang/ExtractAPI/API.h:139 + /// Create and add a global variable record into the API

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 417235. tbaeder marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

asb added inline comments. Comment at: clang/test/CodeGen/WebAssembly/wasm-externref.c:1 +// RUN: %clang_cc1 -triple wasm32-unknown-unknown -target-feature +reference-types -o - -emit-llvm %s | FileCheck %s + It might be worth using update_cc_test_checks.py for

[PATCH] D115622: [Debugify] Optimize debugify original mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73777b4c35a3: [Debugify] Optimize debugify original mode (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9858884 - [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

Author: Vince Bridgers Date: 2022-03-22T07:35:13-05:00 New Revision: 985888411da9c62aea7b0b41f93eb75ad31587a6 URL: https://github.com/llvm/llvm-project/commit/985888411da9c62aea7b0b41f93eb75ad31587a6 DIFF:

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG985888411da9: [analyzer] Refactor makeNull to makeNullWithWidth (NFC) (authored by vabridgers, committed by einvbri vince.a.bridg...@ericsson.com). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:31 +struct UncheckedOptionalAccessModelOptions { + /// Ignore optionals

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

keryell added a comment. Yes, your comment idea looks good and helpful to me. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118935/new/ https://reviews.llvm.org/D118935 ___ cfe-commits mailing

[PATCH] D121873: [clang][extract-api] Add enum support

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:33 +namespace { + I still think this belongs in `APISet`. It belongs there because it defines unique pointers that are specifically tied to the lifetime of `APISet`. Any other thing

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

sammccall added a comment. I reduced something very similar recently as https://github.com/clangd/clangd/issues/1073 This patch does not fix it, but looks closely related, want to take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121756: [clang-format] Clean up code looking for if statements

owenpan requested changes to this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:749 + if (Current.isNot(tok::comment) && + Previous.isConditionLParen(/*IncludeSpecial=*/true)) { // Treat the condition inside an if as if

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

balazske added a comment. Ping I had a question about if the lit-test is needed with the new unit tests (that contain essentially similar code). But if there is no answer I will commit it with all tests, more test is always better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2516-2521 + void takeAttributes(ParsedAttributes ) { Attrs.takeAllFrom(attrs); -if (!lastLoc.isInvalid()) - SetRangeEnd(lastLoc); +if (attrs.Range.getEnd().isValid()) +

[clang] 73777b4 - [Debugify] Optimize debugify original mode

Author: Djordje Todorovic Date: 2022-03-22T12:14:00+01:00 New Revision: 73777b4c35a390617cce0f6b4516e98fe5a88df1 URL: https://github.com/llvm/llvm-project/commit/73777b4c35a390617cce0f6b4516e98fe5a88df1 DIFF:

[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:31 +struct UncheckedOptionalAccessModelOptions { + /// Ignore optionals reachable by derefencing a smart

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Fznamznon added a comment. > I misread what was done with addrspace_cast, that new operator only allows > conversions that are otherwise also allowed. Based on that, this change does > actually align with what was done for OpenCL mode, it does not restrict > anything that is allowed in OpenCL

[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

ymandel updated this revision to Diff 417243. ymandel marked an inline comment as done. ymandel added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122143/new/ https://reviews.llvm.org/D122143 Files:

[PATCH] D122008: [flang][driver] Add support for generating executables

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius added a comment. In D121451#3395801 , @krasimir wrote: > This makes me think that we should really consider not adding indent if the > first character is punctuation WAI, with rationale: That was the case before this patch. > - comments

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. > So I'd rather keep the old behaviour for # in Proto but not in C-like > languages. Is that acceptable? Sounds good. I'll work on a patch doing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121451/new/

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:748 +TEST(DiagnosticsTest, PreambleWithPragmaAssumeNonnull) { + Annotations Header(R"cpp( This test seems to have a lot of extraneous elements. The following

[PATCH] D122227: Fix _BitInt suffix width calculation

aaron.ballman created this revision. aaron.ballman added reviewers: mgehre-amd, erichkeane. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. @mgehre-amd pointed out the following post-commit review feedback on the changes in

[PATCH] D122227: Fix _BitInt suffix width calculation

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the quick reviews, and thanks for catching the issue @mgehre-amd! I've committed in 9cf8f81ca45de198013f29442a7de6600b226d70 . Repository: rG

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:127-129 +def warn_eval_method_setting_is_meaningless_in_value_unsafe_context :

[PATCH] D122230: [clang-format] don't break up #-style comment sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb35e0ecbe0a: [clang-format] dont break up #-style comment sections (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:69 +def note_constexpr_static_local : Note< + "control flows through the declaration of a %select{static|thread_local}0 variable">; def note_constexpr_subobject_declared_here : Note<

[clang] 5856f30 - [LTO] Add configuartion option to use default optimization pipeline

Author: Joseph Huber Date: 2022-03-22T09:28:45-04:00 New Revision: 5856f30b5ae06153ff4a7d3db73ff8d9a05b4144 URL: https://github.com/llvm/llvm-project/commit/5856f30b5ae06153ff4a7d3db73ff8d9a05b4144 DIFF: https://github.com/llvm/llvm-project/commit/5856f30b5ae06153ff4a7d3db73ff8d9a05b4144.diff

[PATCH] D122133: [LTO] Add configuartion option to use default optimization pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5856f30b5ae0: [LTO] Add configuartion option to use default optimization pipeline (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

curdeius added a comment. If nobody is against this patch. I'll land it soon, probably tomorrow. Comment at: clang/docs/tools/dump_format_help.py:29 +def get_help_output(): +args = ["clang-format", "--help"] +cmd = subprocess.Popen(args, stdout=subprocess.PIPE,

[PATCH] D121450: [clang-format] Handle attributes before case label.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1826 + if (Style.isJavaScript() && Line->MustBeDeclaration) +// 'case: string' field declaration. +break; HazardyKnusperkeks wrote: > Here's the loop. In

[PATCH] D121450: [clang-format] Handle attributes before case label.

curdeius added a comment. In D121450#3397861 , @jgorbe wrote: > Hi, > > We've observed that this patch introduces infinite loops in some cases. > Here's a reduced test case: > > export class Foo extends Bar { > get case(): Case { > return (

[PATCH] D122227: Fix _BitInt suffix width calculation

mgehre-amd accepted this revision. mgehre-amd added a comment. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17/new/ https://reviews.llvm.org/D17 ___ cfe-commits mailing list

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds limited modeling of the `value_or` method.

<    1   2   3   >