[PATCH] D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the member of `FrameworkCacheEntry` from

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

kito-cheng added a comment. > Thank you for the explanation. I still don't think this is really "Support" > material, but I'm also struggling to think of a better place to put it in an > existing directory in Clang aside from Basic, but that would still be a bit > of a layering violation it

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe0905a333d6: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement (authored by junaire). Repository: rG LLVM Github Monorepo

[clang] be0905a - [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

Author: Jun Zhang Date: 2022-04-15T21:54:39+08:00 New Revision: be0905a333d6f7c4d7f5c70c18211463e53473cd URL: https://github.com/llvm/llvm-project/commit/be0905a333d6f7c4d7f5c70c18211463e53473cd DIFF: https://github.com/llvm/llvm-project/commit/be0905a333d6f7c4d7f5c70c18211463e53473cd.diff

[PATCH] D123853: [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423086. junaire marked an inline comment as done. junaire added a comment. Update release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files:

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/docs/ReleaseNotes.rst:122 This fixes Issue `Issue 54817 `_. +- No longer produce a wrong redefinition error if variables are defined

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:123 +- Clang should no longer incorrectly diagnose a variable declaration inside of + a lambda expression inside the scope of a if/while/for/switch init statement + as a redeclaration.

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423085. junaire added a comment. Fix bad wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files: clang/docs/ReleaseNotes.rst

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 updated this revision to Diff 423084. jansvoboda11 marked 5 inline comments as done. jansvoboda11 added a comment. Rebase, address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123771/new/

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

erichkeane added a comment. >> I will add these helpers as a NFC patch after this one, that won't need a >> release note or review right? I found that awkward as well, and almost requested that you fix this, but decided against it. I'm ok with this being an NFC patch. It would be nice to

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. I also find the code below really awkward: S->getParent()->getFlags() & Scope::ControlScope I find that we have helpers like `Scope::isBlockScope()` `Scope::isisTryScope()` and etc, but no `Scope::isControlScope` and `Scope::isFnTryCatchScope` I will add these

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

aaron.ballman added a comment. In D109239#3453770 , @glandium wrote: > Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by > default after this change? Can you give a bit more details about what you're seeing? "not set at all"

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov updated this revision to Diff 423080. ASDenysPetrov added a comment. Updated according to suggestions. @martong thank you for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files:

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. In D123840#3453903 , @erichkeane wrote: > Ah, right, we SHOULD have a release note, please add one and I'll help review > the wording. Commit message is fine for a commit message, particularly with > a good release note.

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423079. junaire added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files: clang/docs/ReleaseNotes.rst

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 marked 5 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:339 // Search for a module map file in this directory. -if (loadModuleMapFile(Dir.getDir(), IsSystem, +if

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

erichkeane added a comment. Ah, right, we SHOULD have a release note, please add one and I'll help review the wording. Commit message is fine for a commit message, particularly with a good release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. Hi @erichkeane , thanks for accepting this! But do you think we need to add a release note about it? (I'm a totally beginner so sometimes I'm confused about when we should do it.) Also, Do you have any concerns about the wording? In fact, I am pretty embarrassed by

[clang] 57a4f9b - Fix failing test case found by bots:

Author: Aaron Ballman Date: 2022-04-15T09:20:16-04:00 New Revision: 57a4f9bd493bca0dc78b16951c7d3f3fadfbc2f2 URL: https://github.com/llvm/llvm-project/commit/57a4f9bd493bca0dc78b16951c7d3f3fadfbc2f2 DIFF: https://github.com/llvm/llvm-project/commit/57a4f9bd493bca0dc78b16951c7d3f3fadfbc2f2.diff

[PATCH] D123772: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b09b5d44837: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry() (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D123770: [clang] NFCI: Use FileEntryRef in FileManagerTest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG713e716cdaef: [clang] NFCI: Use FileEntryRef in FileManagerTest (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123769: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99b4874a53cf: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123768: [clang][CodeGen] NFCI: Use FileEntryRef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d98f58959b1: [clang][CodeGen] NFCI: Use FileEntryRef (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0b09b5d - [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry()

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: 0b09b5d44837ea71c6bf017607b33f283c4417c6 URL: https://github.com/llvm/llvm-project/commit/0b09b5d44837ea71c6bf017607b33f283c4417c6 DIFF: https://github.com/llvm/llvm-project/commit/0b09b5d44837ea71c6bf017607b33f283c4417c6.diff

[clang] 713e716 - [clang] NFCI: Use FileEntryRef in FileManagerTest

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: 713e716cdaef1ee069f27bb71fd232a782565e0a URL: https://github.com/llvm/llvm-project/commit/713e716cdaef1ee069f27bb71fd232a782565e0a DIFF: https://github.com/llvm/llvm-project/commit/713e716cdaef1ee069f27bb71fd232a782565e0a.diff

[PATCH] D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf263dac4465c: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport() (authored by jansvoboda11). Repository: rG LLVM Github

[clang] 99b4874 - [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: 99b4874a53cf4cd39a164a63b5505baace825d7c URL: https://github.com/llvm/llvm-project/commit/99b4874a53cf4cd39a164a63b5505baace825d7c DIFF: https://github.com/llvm/llvm-project/commit/99b4874a53cf4cd39a164a63b5505baace825d7c.diff

[clang] 9d98f58 - [clang][CodeGen] NFCI: Use FileEntryRef

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: 9d98f58959b12b6ddab5ac10453e1464bb830e96 URL: https://github.com/llvm/llvm-project/commit/9d98f58959b12b6ddab5ac10453e1464bb830e96 DIFF: https://github.com/llvm/llvm-project/commit/9d98f58959b12b6ddab5ac10453e1464bb830e96.diff

[clang] f263dac - [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: f263dac4465c251e37af9787baf5e9f56138e369 URL: https://github.com/llvm/llvm-project/commit/f263dac4465c251e37af9787baf5e9f56138e369 DIFF: https://github.com/llvm/llvm-project/commit/f263dac4465c251e37af9787baf5e9f56138e369.diff

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:358 + assert(!isEmpty()); + return begin()->From().isUnsigned(); +} martong wrote: > Probably it is unrelated to this patch, but > Could it happen that

[clang] 33d3fc4 - [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

Author: Aaron Ballman Date: 2022-04-15T09:08:54-04:00 New Revision: 33d3fc4466479285121cbb1a62db249454da0bda URL: https://github.com/llvm/llvm-project/commit/33d3fc4466479285121cbb1a62db249454da0bda DIFF: https://github.com/llvm/llvm-project/commit/33d3fc4466479285121cbb1a62db249454da0bda.diff

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Couple nits, otherwise LGTM. Comment at: clang/lib/AST/Decl.cpp:2731 +return false; + auto *List = dyn_cast(getInit()->IgnoreParens()); + if (!List)

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3452994 , @rsmith wrote: > In D122983#3451920 , @erichkeane > wrote: > >> I think Aaron's approach provides a proper 'depreciation' period in our >> compiler, as best

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D123345#3452933 , @rsmith wrote: > In D123345#3452496 , @aaron.ballman > wrote: > >> Do

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by default after this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239

[PATCH] D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1

cor3ntin added a comment. @tstellar I wasn't sure what the procedure was for backporting fixes, so I made a PR. I think your suggestion of keeping the old signature works well. This also modifies the serialized AST, is that an issue for backports? (If it is, I'm not sure i see a way to move

[PATCH] D123850: [Clang] Fix Unevaluated Lambdas Backport to Clang 14.0.1

cor3ntin created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unlike other types, when lambdas are instanciated,

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. @rsmith Thanks for your valuable input! Comment at: clang/lib/Sema/SemaLookup.cpp:2000-2004 + // Class and enumeration member names can be found by name lookup in any + // context in which a definition of the type is reachable. + if (auto *ECD =

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 423044. ChuanqiXu marked 18 inline comments as done. ChuanqiXu added a comment. Herald added a subscriber: MaskRay. Address @rsmith's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

bowang added a comment. > Hi, this patch is just part-1 of Windows SEH feature support. Part-2 work > had been sitting in https://reviews.llvm.org/D102817/new/ since last May > 2021. It's been reviewed, and feedbacks had been addressed. but nobody has > approved it. To handle Hardware

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5206c2c167ed: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault… (authored by brad). Repository: rG LLVM Github

[clang] 5206c2c - [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

Author: Brad Smith Date: 2022-04-15T03:55:59-04:00 New Revision: 5206c2c167ed8826bf233d0e424a87c5e11bc807 URL: https://github.com/llvm/llvm-project/commit/5206c2c167ed8826bf233d0e424a87c5e11bc807 DIFF: https://github.com/llvm/llvm-project/commit/5206c2c167ed8826bf233d0e424a87c5e11bc807.diff

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu updated this revision to Diff 423030. ChuanqiXu added a comment. Fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 Files: clang/include/clang/Basic/Module.h clang/lib/Sema/SemaLookup.cpp

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

MaskRay added inline comments. Comment at: clang/test/Sema/init-randomized-struct.c:30 +} __attribute__((randomize_layout)); + +struct other_test t5 = { .a = foo, .b[0] = foo }; // Okay Perhaps test an empty struct with randomize_layout and a struct with one

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire created this revision. junaire added reviewers: aaron.ballman, rsmith, erichkeane, dblaikie, rjmccall. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because lambda will create its own scope,

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:65 + // Matches framework include patterns + const llvm::Regex Rule("/(.+)\\.framework/(.+)?Headers/(.+)"); + StringRef WorkingDir = CI.getFileSystemOpts().WorkingDir; This

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

jpienaar accepted this revision. jpienaar added a comment. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123836/new/ https://reviews.llvm.org/D123836 ___ cfe-commits mailing list

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123836/new/ https://reviews.llvm.org/D123836

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, rsmith, clang-language-wg. ChuanqiXu added a project: clang. Herald added a subscriber: dexonsmith. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Now the

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Move enabling of IAS back to Generic_GCC::IsIntegratedAssemblerDefault(). Repository: rG LLVM

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

sighingnow added a comment. /cc @arphaman @jdoerfert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

sighingnow added a comment. Ping~ Could anyone take a look at this trivial patch and get it landed? Thanks in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409

<    1   2