[PATCH] D112367: [Clang][AST] Temporarily undefine IBAction/IBOutlet ObjC macros in attribute headers

gAlfonso-bit abandoned this revision. gAlfonso-bit added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This change is no longer necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112367/new/

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:31 + -std=c++(98|11|14|17|20)[-or-later]: +This flag will cause multiple runs within the same check_clang_tidy +execution. Make sure you don't have shared state across

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal updated this revision to Diff 431141. steakhal marked an inline comment as done. steakhal added a comment. Make the note more precise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/ https://reviews.llvm.org/D125771 Files:

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/NsdateformatterCheck.cpp:12 +#include "clang/ASTMatchers/ASTMatchFinder.h" +# include + `cctype`? See `modernize-deprecated-headers`. Comment at:

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

njames93 added a comment. In D126097#3528787 , @NoQ wrote: > Looks awesome! > >> add_new_check.py > > I'm surprised it wasn't executable already, do we want to keep it? It keeps getting reset, likely due to Windows users committing changes. It should

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

akyrtzi updated this revision to Diff 431151. akyrtzi added a comment. Update due to source change in the previous patch (https://reviews.llvm.org/D125487) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125488/new/ https://reviews.llvm.org/D125488

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

steakhal created this revision. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal requested review of this revision.

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

steakhal updated this revision to Diff 431155. steakhal added a comment. `arc` used the HEAD^ as base, so I'm setting the parent patches now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126123/new/ https://reviews.llvm.org/D126123 Files:

[clang] df46fb4 - Test C DR conformance (part one of many)

Author: Aaron Ballman Date: 2022-05-21T15:02:46-04:00 New Revision: df46fb40557a14807dd508af32251ceb1cab8b86 URL: https://github.com/llvm/llvm-project/commit/df46fb40557a14807dd508af32251ceb1cab8b86 DIFF: https://github.com/llvm/llvm-project/commit/df46fb40557a14807dd508af32251ceb1cab8b86.diff

[PATCH] D126127: [analyzer][NFC] Relocate unary transfer functions

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D126125: [analyzer][NFC] Inline ExprEngine::evalMinus

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D126126: [analyzer][NFC] Inline and simplify nonloc::ConcreteInt functions

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D126130: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

steakhal updated this revision to Diff 431164. steakhal added a comment. Well, my first use of `arc` went a bit sideways, so I'm falling back to posting this NFC patch batch manually. We will see how using `arc` works out next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126130: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[clang] 36fde81 - Fix failing test bots from df46fb40557a14807dd508af32251ceb1cab8b86

Author: Aaron Ballman Date: 2022-05-21T16:10:37-04:00 New Revision: 36fde81f93606cfa6357e6463571c0222e7e6e28 URL: https://github.com/llvm/llvm-project/commit/36fde81f93606cfa6357e6463571c0222e7e6e28 DIFF: https://github.com/llvm/llvm-project/commit/36fde81f93606cfa6357e6463571c0222e7e6e28.diff

[PATCH] D124751: [HLSL] Support -E option for HLSL.

MaskRay added a comment. In D124751#3513513 , @python3kgae wrote: > In D124751#3513283 , @MaskRay wrote: > >> Is there a specification or reference implementation stating that -E is used? >> >>> Option<["--",

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae added a comment. In D124751#3529652 , @MaskRay wrote: > In D124751#3513513 , @python3kgae > wrote: > >> In D124751#3513283 , @MaskRay >> wrote: >> >>> Is

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

maryammo added a comment. In D124093#3528639 , @amyk wrote: > I was wondering where are the test cases in this patch. Did they get missed > when updating the revision? The test case's modification were not needed as part of addressing Nemanja's

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal added a comment. Thanks for the review, sorry about the mistakes I made on this trivial change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/ https://reviews.llvm.org/D125771 ___

[clang-tools-extra] ecf5924 - [clang-tidy] Add a useful note about -std=c++11-or-later

Author: Balazs Benics Date: 2022-05-21T22:16:55+02:00 New Revision: ecf5924eb4c4111bbab62425aca85866bb94b679 URL: https://github.com/llvm/llvm-project/commit/ecf5924eb4c4111bbab62425aca85866bb94b679 DIFF: https://github.com/llvm/llvm-project/commit/ecf5924eb4c4111bbab62425aca85866bb94b679.diff

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

This revision was automatically updated to reflect the committed changes. Closed by commit rGecf5924eb4c4: [clang-tidy] Add a useful note about -std=c++11-or-later (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

Amir added a comment. Hi @void, The msvc build is still broken. https://lab.llvm.org/buildbot/#/builders/222/builds/532 In D124836#3528529 , @void wrote: > In D124836#3528521 , @vvereschaka > wrote: > >> got

[clang] f4d52ca - [clang-format] Fix a bug in "AfterControlStatement: MultiLine"

Author: owenca Date: 2022-05-21T15:10:21-07:00 New Revision: f4d52cad671380d9fa6c1637e1c82b7296fd7da0 URL: https://github.com/llvm/llvm-project/commit/f4d52cad671380d9fa6c1637e1c82b7296fd7da0 DIFF: https://github.com/llvm/llvm-project/commit/f4d52cad671380d9fa6c1637e1c82b7296fd7da0.diff LOG:

[PATCH] D125959: [clang-format] Fix a bug in "AfterControlStatement: MultiLine"

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d52cad6713: [clang-format] Fix a bug in AfterControlStatement: MultiLine (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D125959?vs=430622=431182#toc Repository: rG LLVM

[clang] 8bfccb9 - [clang-format] Fix an infinite loop in parseJavaEnumBody()

Author: owenca Date: 2022-05-21T10:33:59-07:00 New Revision: 8bfccb963b3519393c0266b452a115a4bb46d207 URL: https://github.com/llvm/llvm-project/commit/8bfccb963b3519393c0266b452a115a4bb46d207 DIFF: https://github.com/llvm/llvm-project/commit/8bfccb963b3519393c0266b452a115a4bb46d207.diff LOG:

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi updated this revision to Diff 431150. akyrtzi added a comment. Remove `DependencyScanningFilesystem::disableDirectivesScanning()` function. Unlike source minimization which changes the source contents size and needed to be disabled in certain situations, directive lexing keeps the same

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MaskRay added inline comments. Comment at: lld/ELF/Options.td:633 HelpText<"Alias for --lto-obj-path=">; +def: J<"plugin-opt=-opaque-pointers">, + Alias, The convention is `=opaque-pointers` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/unittests/Lex/DependencyDirectivesScannerTest.cpp:175 "#define MACRO con tent ", Out)); - EXPECT_STREQ("#define MACRO con tent\n", Out.data()); + EXPECT_STREQ("#define MACRO

[PATCH] D126124: [analyzer][NFC] Inline ExprEngine::evalComplement

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

dexonsmith added inline comments. Comment at: clang/unittests/Lex/DependencyDirectivesScannerTest.cpp:175 "#define MACRO con tent ", Out)); - EXPECT_STREQ("#define MACRO con tent\n", Out.data()); + EXPECT_STREQ("#define MACRO con tent\n", Out.data());

[PATCH] D126128: [analyzer][NFC] Inline loc::ConcreteInt::evalBinOp

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

dexonsmith added inline comments. Comment at: clang/unittests/Lex/DependencyDirectivesScannerTest.cpp:175 "#define MACRO con tent ", Out)); - EXPECT_STREQ("#define MACRO con tent\n", Out.data()); + EXPECT_STREQ("#define MACRO con tent\n", Out.data());

[PATCH] D126129: [analyzer][NFC] Remove unused nonloc::ConcreteInt::evalBinOp

steakhal created this revision. steakhal added reviewers: martong, NoQ. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

steakhal updated this revision to Diff 431168. steakhal added reviewers: NoQ, martong. steakhal added a comment. Herald added a subscriber: rnkovacs. Well, my first use of arc went a bit sideways, so I'm falling back to posting this NFC patch batch manually. We will see how using arc works out

[PATCH] D125959: [clang-format] Fix a bug in "AfterControlStatement: MultiLine"

curdeius accepted this revision. curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3213 Style.BraceWrapping.AfterFunction = true; - Style.BraceWrapping.AfterControlStatement = FormatStyle::BWACS_MultiLine;

[clang] 1443dba - [clang-format] Handle "complex" conditionals in RemoveBracesLLVM

Author: owenca Date: 2022-05-21T14:46:38-07:00 New Revision: 1443dbaba6f0e57be066995db9164f89fb57b413 URL: https://github.com/llvm/llvm-project/commit/1443dbaba6f0e57be066995db9164f89fb57b413 DIFF: https://github.com/llvm/llvm-project/commit/1443dbaba6f0e57be066995db9164f89fb57b413.diff LOG:

[PATCH] D126052: [clang-format] Handle "complex" conditionals in RemoveBracesLLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rG1443dbaba6f0: [clang-format] Handle complex conditionals in RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125959: [clang-format] Fix a bug in "AfterControlStatement: MultiLine"

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3213 Style.BraceWrapping.AfterFunction = true; - Style.BraceWrapping.AfterControlStatement = FormatStyle::BWACS_MultiLine; Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All;

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems OK Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1040-1041 // Retrieve the compile unit. - return getCompileUnitForOffset(CUOffset); +

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei created this revision. pengfei added reviewers: nickdesaulniers, craig.topper, LuoYuanke. Herald added subscribers: StephenFan, hiraditya, kristof.beyls. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay.

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz added a comment. F23151067: Capture.png This screenshot shows the code snippet from the GitHub issue, and Clang-Tidy's behaviour before and after this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz updated this revision to Diff 431213. salman-javed-nz edited the summary of this revision. salman-javed-nz added a comment. Renamed test case to better explain what it is that it's testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Brilliant thank you, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126096/new/ https://reviews.llvm.org/D126096

[PATCH] D125604: [FileCheck] Catch missspelled directives.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: bzcheeseman. LGTM. Thanks for pinging the relevant folks on individual tests. You can push the fixes yourself before landing this patch. Repository: rG LLVM

[clang] 130a9cc - [clang-format] Fix a crash on lambda trailing return type

Author: owenca Date: 2022-05-21T15:50:50-07:00 New Revision: 130a9cc0a5e25e3be8ff3738518e86ae3ae0b5ba URL: https://github.com/llvm/llvm-project/commit/130a9cc0a5e25e3be8ff3738518e86ae3ae0b5ba DIFF: https://github.com/llvm/llvm-project/commit/130a9cc0a5e25e3be8ff3738518e86ae3ae0b5ba.diff LOG:

[clang] 554efc2 - [clang-format] Format unit tests with InsertBraces/RemoveBracesLLVM

Author: owenca Date: 2022-05-21T16:13:35-07:00 New Revision: 554efc225217272df755a962d841d57056af83f4 URL: https://github.com/llvm/llvm-project/commit/554efc225217272df755a962d841d57056af83f4 DIFF: https://github.com/llvm/llvm-project/commit/554efc225217272df755a962d841d57056af83f4.diff LOG:

[PATCH] D126134: [clang-tidy] Improve add_new_check.py to recognize more checks

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, njames93, alexfh. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision.

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie added a comment. Might be worth a note in the Release Notes given that it's at least caused issues with one DWARF consumer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:341 + MCInst TmpInst; + TmpInst.setOpcode(X86::INT3); + AsmPrinter::emitBasicBlockEnd(MBB); craig.topper wrote: > Why is TmpInst created unconditionally and not in the if? Good

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei updated this revision to Diff 431193. pengfei added a comment. Address Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/ https://reviews.llvm.org/D126137 Files: clang/docs/ReleaseNotes.rst

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

paulaltin added a comment. Thanks for preparing this revision @salman-javed-nz! Do you think it could be worth adding a few more test cases to cover this? It turned out that this issue wasn't actually specific to multi-line macros (see this comment

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang now matches the gcc

[clang] 0b903ef - Re-add release notes for GCC ABI compatibility for non-POD in packed structs

Author: David Blaikie Date: 2022-05-22T01:15:34Z New Revision: 0b903ef6aa0976a60d3f448837f3c43adaf09cc1 URL: https://github.com/llvm/llvm-project/commit/0b903ef6aa0976a60d3f448837f3c43adaf09cc1 DIFF: https://github.com/llvm/llvm-project/commit/0b903ef6aa0976a60d3f448837f3c43adaf09cc1.diff

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:341 + MCInst TmpInst; + TmpInst.setOpcode(X86::INT3); + AsmPrinter::emitBasicBlockEnd(MBB); Why is TmpInst created unconditionally and not in the if? Repository: rG LLVM

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

craig.topper added a comment. What is #1633 in the description? Can you make a link? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/ https://reviews.llvm.org/D126137 ___ cfe-commits mailing

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz created this revision. salman-javed-nz added reviewers: nridge, paulaltin. salman-javed-nz added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. salman-javed-nz requested review of this revision. Herald added a

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

nridge added a comment. In D126138#3529820 , @paulaltin wrote: > It turned out that this issue wasn't actually specific to multi-line macros > (see this comment > ), Indeed,

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz added a comment. The pre-merge checks are failing on the clang-format check. Not sure why it's complaining about the formatting of the `lit` test files - those files have never complied with the project style and have not been checked for style for as long as I remember. Has