[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo marked an inline comment as done. dongjunduo added inline comments. Comment at: clang/test/Driver/check-time-trace.cpp:9 +// RUN: | FileCheck %s +// RUN: %clangxx -S -ftime-trace=%T -ftime-trace-granularity=0 -o %T/check-time-trace %s +// RUN: cat

[PATCH] D128489: [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ceb9c347f14: [ODRHash diagnostics] Move common code for calculating diag locations in… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2ceb9c3 - [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

Author: Volodymyr Sapsai Date: 2022-06-30T19:39:22-07:00 New Revision: 2ceb9c347f14e81a8c71d644724cefd10fce6eaf URL: https://github.com/llvm/llvm-project/commit/2ceb9c347f14e81a8c71d644724cefd10fce6eaf DIFF:

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

NoQ added a subscriber: usama54321. NoQ added a comment. Thanks, very nice! @usama54321 you recently fixed a similar problem in a clang-tidy check, do you know if it also requires a similar clause for polymorphic expressions inside `typeid`? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128489: [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

vsapsai added a comment. Thanks for the review! Comment at: clang/lib/Serialization/ASTReader.cpp:10020 +auto GetMismatchedDeclLoc = [](const NamedDecl *Container, + ODRMismatchDecl DiffType, const Decl *D) { + SourceLocation Loc;

[PATCH] D128953: chore: refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain. Changes are as follows: * Relocate the `ll

ckissane created this revision. Herald added subscribers: wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added

[PATCH] D128489: [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:10020 +auto GetMismatchedDeclLoc = [](const NamedDecl *Container, + ODRMismatchDecl DiffType, const Decl *D) { + SourceLocation Loc;

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ChuanqiXu added a reviewer: ChuanqiXu. ChuanqiXu added a comment. Thanks for filing that issue. I wanted to add that myself before. It should be better to change `isVisible` and `hasVisibleDefinition` to `isReachable` and `hasReachableDefinition`. The definition of reachability comes from C++20

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added a comment. In D126189#3617896 , @iains wrote: > In D126189#3617850 , @ChuanqiXu > wrote: > >> @iains may I ask what's the issue to not land this? It looks like you're >> waiting for the behavior

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3623059 , @nickdesaulniers wrote: > I see you modified the mir parser & printer; consider adding a .mir test. I added a .mir test for parsing the cfi-type. The machine instructions generated for the various

[PATCH] D128488: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

vsapsai added a comment. Thanks for the review, Chuanqi! Comment at: clang/lib/Serialization/ASTReader.cpp:9642 + // note_module_odr_violation_record + enum ODRCXXRecordDifference { StaticAssertCondition, ChuanqiXu wrote: > Is this specific to C++? That

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

ckissane updated this revision to Diff 441540. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' of github.com:ckissane/llvm-project into ckissane.refactor-compression.part-0 - Merge branch 'main' into ckissane.refactor-compression.part-0 Repository: rG LLVM

[PATCH] D128754: Refactor LLVM compression namespaces (Part 1: remove crc32)

ckissane updated this revision to Diff 441541. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' into ckissane.refactor-compression.part-1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb1d908e5cf7: Adds AST matcher for ObjCStringLiteral (authored by t-rasmud). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] eb1d908 - Adds AST matcher for ObjCStringLiteral

Author: Rashmi Mudduluru Date: 2022-06-30T15:20:10-07:00 New Revision: eb1d908e5cf7279b98b84d1587d4665d3cdecbe9 URL: https://github.com/llvm/llvm-project/commit/eb1d908e5cf7279b98b84d1587d4665d3cdecbe9 DIFF:

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi updated this revision to Diff 441551. akyrtzi added a comment. Use `Optional::value_or()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128947/new/ https://reviews.llvm.org/D128947 Files: clang/include/clang/Basic/SourceManager.h

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 updated this revision to Diff 441565. jyu2 added a comment. Thanks Alexey for the review. This patch to address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 Files:

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 441572. dongjunduo added a comment. [Clang] change test cases to different directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files:

[PATCH] D128048: Add a new clang option "-ftime-trace="

Whitney accepted this revision. Whitney added inline comments. Comment at: clang/tools/driver/cc1_main.cpp:265 + SmallString<128> TracePath(Clang->getFrontendOpts().TimeTracePath); + if (llvm::sys::fs::is_directory(TracePath)) { +

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson updated this revision to Diff 441529. tejohnson marked 3 inline comments as done. tejohnson added a comment. Rebase on top of D128854 which now includes the extracted Analysis utilities. I have not yet addressed the other comments on this patch.

[PATCH] D128754: Refactor LLVM compression namespaces (Part 1: remove crc32)

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Should probably add `[llvm]` to the subject also. Generally it's helpful for immediately knowing which subrepo you're touching. Repository: rG LLVM Github Monorepo CHANGES

[clang] 15cb180 - [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

Author: Volodymyr Sapsai Date: 2022-06-30T18:40:46-07:00 New Revision: 15cb180dcbf84701f3af47983e223d0beaac3c9b URL: https://github.com/llvm/llvm-project/commit/15cb180dcbf84701f3af47983e223d0beaac3c9b DIFF:

[PATCH] D128488: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15cb180dcbf8: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6bd53df - [clang][NFC][tests] dr208.c optional signext handling

Author: Hubert Tong Date: 2022-07-01T00:03:58-04:00 New Revision: 6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7 URL: https://github.com/llvm/llvm-project/commit/6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7 DIFF: https://github.com/llvm/llvm-project/commit/6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7.diff

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi updated this revision to Diff 441587. akyrtzi added a comment. Herald added a project: clang-tools-extra. Update `clang-tools-extra/test/pp-trace/pp-trace-include.cpp` to accomodate for `PrevFID` getting a value and preserve using `getFileEntryForID()` for the

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin added a comment. @philnik There seems to be an unrelated clang-format issue but otherwise the build looks fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844

[PATCH] D128952: [AMDGPU] Add WMMA clang builtins

piotr created this revision. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. piotr requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Add WMMA clang builtins and

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441537. ckissane added a comment. make part 1 after part 0 of refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: llvm/docs/ReleaseNotes.rst

[PATCH] D128952: [AMDGPU] Add WMMA clang builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128952/new/ https://reviews.llvm.org/D128952

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Herald added a reviewer: ributzka. I tried the ninja stage2-check-all on my local build with this patch applied and don't reproduce the issue. Is there any way someone could get me the preprocessed source that this crashed on off the servers or something?

[PATCH] D128844: Improve the formatting of static_assert messages

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM. (The clang-format if more of a suggestion than anything else currently) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for publicly visible classes

aeubanks created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Repository: rG LLVM Github

[PATCH] D128953: refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Should also probably add `[NFC]` to the start of the subject Comment at: lld/ELF/InputSection.cpp:77 +if (!compression::zlib::isAvailable()) +

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

benlangmuir added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1016 +return *Name; return StringRef(); } Just a suggestion: `value_or` can be a nice way to express simple cases like this: ```

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi updated this revision to Diff 441556. akyrtzi added a comment. Pass a value for `PrevFID` for `FileChanged()` callback as well, for `PPCallbacks::EnterFile` reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128947/new/

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:212 +}; +/// List of captuer fields +llvm::SmallVector ABataev wrote: > Captured? Fixed. Thanks. Comment at: clang/lib/Sema/TreeTransform.h:122 + /// the

[PATCH] D128844: Improve the formatting of static_assert messages

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda1609ad7354: Improve the formatting of static_assert messages (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] da1609a - Improve the formatting of static_assert messages

Author: Corentin Jabot Date: 2022-06-30T23:59:21+02:00 New Revision: da1609ad73540978f66111e96ea500b97ca9b39a URL: https://github.com/llvm/llvm-project/commit/da1609ad73540978f66111e96ea500b97ca9b39a DIFF:

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 441530. serge-sans-paille added a comment. Extra test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D128048: Add a new clang option "-ftime-trace="

dongjunduo updated this revision to Diff 441574. dongjunduo added a comment. [Clang] format the source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files: clang/include/clang/Driver/Options.td

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a preprocessor callback focused on the lexed file changing,

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1016 +return *Name; return StringRef(); } benlangmuir wrote: > Just a suggestion: `value_or` can be a nice way to express simple cases like > this: > > ``` >

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

sberg updated this revision to Diff 441313. sberg added a comment. Updated the prospective git commit message as follow: [test] Check for more -fsanitize=array-bounds behavior ...that had temporarily regressed with (since reverted)

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 441352. njames93 added a comment. Fix lit cfg typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 requested review of this revision. njames93 added a comment. Any issues with this now for getting correct version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 441320. kito-cheng added a comment. Changes: - Rebase - Address @khchen's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files:

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval requested changes to this revision. clementval added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"},

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. > Am I understanding correctly? @pengfei you are interested in the > -fexcess-precision=16 part of this right? @rjmccall what do yo think? I agree with @rjmccall , we just need to disable what we do here for `-fexcess-precision=16`. CHANGES SINCE LAST ACTION

[PATCH] D128434: [OpenCL] Remove half scalar vload/vstore builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d421e6e3b78: [OpenCL] Remove half scalar vload/vstore builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128434/new/

[clang] 1d421e6 - [OpenCL] Remove half scalar vload/vstore builtins

Author: Sven van Haastregt Date: 2022-06-30T11:01:19+01:00 New Revision: 1d421e6e3b789ede2f61756a72e2b27456f868e3 URL: https://github.com/llvm/llvm-project/commit/1d421e6e3b789ede2f61756a72e2b27456f868e3 DIFF:

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder updated this revision to Diff 441344. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/ https://reviews.llvm.org/D128248 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-array-init.cpp Index: clang/test/SemaCXX/constexpr-array-init.cpp

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev added a comment. In D128625#3621030 , @MaskRay wrote: > The description seems unclear to me. Is a `riscv64-unknown-linux-gnu` GCC > installation selected while the requested target triple is > `riscv64-unknown-elf`? Yes, exactly (see

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 441351. njames93 added a comment. Herald added subscribers: ormris, mgorny. Emit documentation links for the version of clangd built. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 441353. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst

[clang] abeeae5 - [X86] Support `_Float16` on SSE2 and up

Author: Phoebe Wang Date: 2022-06-30T17:21:37+08:00 New Revision: abeeae570efff38dceccf68f5352809c58ffdda2 URL: https://github.com/llvm/llvm-project/commit/abeeae570efff38dceccf68f5352809c58ffdda2 DIFF: https://github.com/llvm/llvm-project/commit/abeeae570efff38dceccf68f5352809c58ffdda2.diff

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabeeae570eff: [X86] Support `_Float16` on SSE2 and up (authored by pengfei). Changed prior to commit:

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, richard.barton.arm wrote: > clementval wrote: > >

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:199 UsesAllocatorsDecls; +/// Data is needed on creating capture fields for implicit +/// defualt first|private clause. Data required? Comment at:

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder added a comment. I added the `isArray()` check in both places now, but the first one is not necessary for the test case (at least). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/ https://reviews.llvm.org/D128248 ___

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

sunshaoce added a comment. Hello @Jim! We are developing the P extension, are you still maintaining this patch? Or would you mind co-development together? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Thank your for reviewing @clementval ! In D125788#3621585 , @clementval wrote: > Shouldn't we just wait until we can make the permanent renaming so we do not > add unnecessary cmake option? This was discussed in one of our

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

arichardson added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; This seems like the wrong place to add this workaround, shouldn't the change

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

richard.barton.arm added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, clementval wrote: > This is counter

[PATCH] D128855: [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

python3kgae updated this revision to Diff 441358. python3kgae added a comment. Rebase to fix test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128855/new/ https://reviews.llvm.org/D128855 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

ymandel added a comment. sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128774/new/ https://reviews.llvm.org/D128774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

aaron.ballman added a comment. FWIW, I'm also a tentative LG on these changes. I'm not certain if there's a reason why we did things this way in the first place, but I think the new output is more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 441368. dongjunduo added a comment. [Clang] change "-ftime-trace-path" to "-ftime-trace" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files:

[clang] cde1df4 - Correct -Winfinite-recursion warning on potentially-unevaluated operand

Author: Prathit Aswar Date: 2022-06-30T09:09:28-04:00 New Revision: cde1df4ca4f233f1069041ed1646779e9ff1ad7d URL: https://github.com/llvm/llvm-project/commit/cde1df4ca4f233f1069041ed1646779e9ff1ad7d DIFF: https://github.com/llvm/llvm-project/commit/cde1df4ca4f233f1069041ed1646779e9ff1ad7d.diff

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

This revision was automatically updated to reflect the committed changes. Closed by commit rGcde1df4ca4f2: Correct -Winfinite-recursion warning on potentially-unevaluated operand (authored by appmonster007, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

pscoro updated this revision to Diff 441374. pscoro added a comment. fixed XOR usage, added linux tests and other small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128652/new/ https://reviews.llvm.org/D128652 Files:

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added inline comments. Comment at: clang/include/clang/AST/Decl.h:1944-1948 + /// For non-templates this value will be NULL, unless this non-template + /// function declaration was declared directly inside of a function template, + /// in which case this will have

[clang] a591c7c - [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

Author: Xiang Li Date: 2022-06-30T06:16:51-07:00 New Revision: a591c7ca0d9fe47223127ee13df60689f36ba112 URL: https://github.com/llvm/llvm-project/commit/a591c7ca0d9fe47223127ee13df60689f36ba112 DIFF: https://github.com/llvm/llvm-project/commit/a591c7ca0d9fe47223127ee13df60689f36ba112.diff

[PATCH] D128855: [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

This revision was automatically updated to reflect the committed changes. Closed by commit rGa591c7ca0d9f: [HLSL] Change WaveActiveCountBits to wrapper of… (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128855/new/

[PATCH] D128844: Improve the formatting of static_assert messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I agree with the changes in principle, but it looks like the libc++ precommit CI builder is failing with a bunch of failures... but those failures look like the precommit CI

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added a comment. In D125788#3621744 , @awarzynski wrote: > We discussed this in our call on Monday and agreed to go ahead provided that > this change is technically sound. IIUC, this has now been confirmed: > >> Overall the patch looks ok

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall added a comment. In D128379#3622128 , @sammccall wrote: > Hmm, this version looks complicated to me. > And also fragile: downstream we have CLANG_VERSION_STRINGs that don't match > upstream, Apple has their own versioning scheme, linux distros

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne commandeered this revision. ldionne edited reviewers, added: egorzhdan; removed: ldionne. ldionne added a comment. Herald added a subscriber: MaskRay. Thanks a lot for the fixes @egorzhdan! I think this looks pretty good. Since LLVM 15 is coming up and we'd like to have this in its final

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the necessary changes required

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

erichkeane added subscribers: ChuanqiXu, iains. erichkeane added a comment. I don't see anything to be concerned about here, but I'd like a modules person to take a look. @ChuanqiXu any chance you can confirm here? (or @iains ?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

skc7 created this revision. skc7 added reviewers: arsenm, sameerds, cdevadas, ronlieb, yaxunl, b-sumner, bcahoon. Herald added subscribers: kosarev, mattd, asavonic, ThomasRaoux, jdoerfert, kerbowa, kbarton, jvesely, nemanjai. Herald added a project: All. skc7 requested review of this revision.

[PATCH] D128700: [AMDGPU][Clang] Skip adding noundef attribute to AMDGPU HIP device functions

skc7 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2309 + bool EnableNoundefAttrs = CodeGenOpts.EnableNoundefAttrs && +!(getLangOpts().HIP && getLangOpts().CUDAIsDevice); + arsenm wrote: > Shouldn't be limited to

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

lkail added a comment. Summary should be updated as @nemanjai has said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128652/new/ https://reviews.llvm.org/D128652 ___ cfe-commits mailing list

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, awarzynski wrote: > richard.barton.arm wrote: > >

[clang-tools-extra] 8b04c33 - [pseudo] Forest dump ascii art isn't broken by large indices

Author: Sam McCall Date: 2022-06-30T16:53:51+02:00 New Revision: 8b04c331b51811fc6ddcfc8207b1ccdcea02108e URL: https://github.com/llvm/llvm-project/commit/8b04c331b51811fc6ddcfc8207b1ccdcea02108e DIFF: https://github.com/llvm/llvm-project/commit/8b04c331b51811fc6ddcfc8207b1ccdcea02108e.diff

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov created this revision. ilya-biryukov added a reviewer: erichkeane. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Currently the C++20 concepts are only merged in `ASTReader`, i.e. when coming from different TU. This can

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

skc7 updated this revision to Diff 441409. skc7 added a comment. Add description for allowUninitializedFunctionsArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128907/new/ https://reviews.llvm.org/D128907 Files:

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Basically LGTM -- can you also add a release note about the assertion fix? Comment at: clang/test/SemaCXX/constexpr-array-init.cpp:1 + +// RUN: %clang_cc1

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall added a comment. Hmm, this version looks complicated to me. And also fragile: downstream we have CLANG_VERSION_STRINGs that don't match upstream, Apple has their own versioning scheme, linux distros tend to do things like `6.0.1~ubuntu3`... Let me sync with @kadircet Repository:

[clang] 0079343 - [libTooling][NFC] Add a comment about comment parsing to getAssociatedRange.

Author: Aaron Jacobs Date: 2022-06-30T12:46:57Z New Revision: 007934343c4c18102b2b3e4195d356dbcdf9a3fc URL: https://github.com/llvm/llvm-project/commit/007934343c4c18102b2b3e4195d356dbcdf9a3fc DIFF: https://github.com/llvm/llvm-project/commit/007934343c4c18102b2b3e4195d356dbcdf9a3fc.diff LOG:

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

This revision was automatically updated to reflect the committed changes. Closed by commit rG007934343c4c: [libTooling][NFC] Add a comment about comment parsing to getAssociatedRange. (authored by jacobsa, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; arichardson wrote: >

[PATCH] D128844: Improve the formatting of static_assert messages

philnik requested changes to this revision. philnik added a comment. This revision now requires changes to proceed. Sorry I missed that. You have to changes the libc++ tests to regex checks to allow both error-styles. This can then be removed once we drop support for LLVM 14 (so after the

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

shchenz added a comment. Please make sure the patch is able to compile first. I fixed two build failures, it still fails : ( Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:221 + def int_ppc_kill_canary + : GCCBuiltin<"__builtin_ppc_kill_canary">, +

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:76 + // `CONSTANT_OP` and `opName` remains "". + type = CONSTANT_OP; +} srishti-pm wrote: > Mogball wrote: > > Constant ops could be sorted by name as well.

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ee9a50a146c: [libc++] Implement P0618R0 (Deprecating codecvt) (authored by philnik). Changed prior to commit: https://reviews.llvm.org/D127313?vs=441353=441398#toc Repository: rG LLVM Github

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm marked 4 inline comments as done. srishti-pm added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:329-353 + assert(frontPosition >= 0 && frontPosition < bfsOfOperands.size() && + "`frontPosition` should be valid"); + unsigned

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo added a comment. Hi @jamieschmeiser @Whitney @MaskRay, I have changed "-ftime-trace-path" to "-ftime-trace". It is a well-spelling option name. The user can turn on the time-trace by: - specifying "**-ftime-trace**" only and output it to the default directory (the same as the "-o"

  1   2   >