[PATCH] D109977: LLVM Driver Multicall tool

beanz added a comment. In D109977#3652091 , @abrachet wrote: > In D109977#3611683 , @mgorny wrote: > >> This seems to have broken standalone builds for Gentoo. >> >> While building Clang, I get: >> >> CMake

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

tahonermann added a comment. > Sorry about this, I actually tried this but the patch showed a lot more than > what I've changed, not sure what I did wrong. You didn't do anything wrong; the `-U9` option will effectively include the entire file for each changed file. That is actually the

[PATCH] D129581: [Clang] Rework LTO argument handling in the linker wrapper

jhuber6 added a comment. On second thought I'm not sure if overloading `-plugin-opt` is a good idea because we could have situations where we'd want them to be mutually exclusive, although I'd like to reuse the logic to set the arguments. I could change it to emit `-offload-opt=` instead or

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:276 + +Enable unstable and experimental language and library features. + MaskRay wrote: > The doc is auto-generated by tablegen >

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444725. nickdesaulniers added a comment. - rebase on top of D129691 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/ https://reviews.llvm.org/D129709 Files:

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nathanchance added a comment. This cleans up the objtool warnings I initially reported and does not introduce any other regressions in my Linux kernel build and QEMU boot tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka updated this revision to Diff 444737. vitalybuka added a comment. simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129789/new/ https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c

[clang] a2e01bd - [test][CodeGen] Don't miss lifetime markers in lifetime tests

Author: Vitaly Buka Date: 2022-07-14T11:14:07-07:00 New Revision: a2e01bdcc21429d92cd785053f7cc9f72f1d212a URL: https://github.com/llvm/llvm-project/commit/a2e01bdcc21429d92cd785053f7cc9f72f1d212a DIFF: https://github.com/llvm/llvm-project/commit/a2e01bdcc21429d92cd785053f7cc9f72f1d212a.diff

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2e01bdcc214: [test][CodeGen] Dont miss lifetime markers in lifetime tests (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern -fprofile-arcs \

[PATCH] D129594: [InstrProf] Add options to profile function groups

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf58684f2720: [InstrProf] Add options to profile function groups (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129594/new/

[clang] af58684 - [InstrProf] Add options to profile function groups

Author: Ellis Hoag Date: 2022-07-14T11:41:30-07:00 New Revision: af58684f272046f293a9f469f03d23bd2b138349 URL: https://github.com/llvm/llvm-project/commit/af58684f272046f293a9f469f03d23bd2b138349 DIFF: https://github.com/llvm/llvm-project/commit/af58684f272046f293a9f469f03d23bd2b138349.diff

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. @aemerson can you let me know if https://reviews.llvm.org/D129786 works on MacOS? I am continuing work on that revision because this one has a lot of outdated unrelated history. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ https://reviews.llvm.org/D129714 ___ cfe-commits mailing list

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444765. usaxena95 added a comment. Removed changes from previous revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files:

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

martong added a comment. Very good! In D129498#3650595 , @NoQ wrote: > In D129498#3647348 , @ASDenysPetrov > wrote: > >> In D129498#3644222 , @NoQ wrote: >> >>> Maybe

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. @tapaswenipathak, ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added a comment. Just to move things forward here: I propose to continue and land this patch without mode 3 (there were only a couple comments left to address for that), and continue the discussion about whether to add mode 3 elsewhere. (I don't mind where, KSPP, gcc, or llvm issue

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

jdoerfert added a comment. @arsenm put this on the GPU working group agenda for tomorrow: https://docs.google.com/document/d/1m_oSe1HwtWdQ2JUmMRTAVHbUS7Dv4MRsqptiYcgK6iI/edit?usp=sharing Join in if you can! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129784: [HIP] Allow the new driver to compile HIP in non-RDC mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, JonChesterfield. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new driver primarily allows us to support

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. In D109977#3652091 , @abrachet wrote: > Could I have a cmake invocation or a bot link? The exact CMake invocation for clang is: cmake -C

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks updated this revision to Diff 444706. aeubanks added a comment. make sure not to regress windows by checking HasHiddenLTOVisibility() to decide whether to emit public.type.test vs type.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne updated this revision to Diff 444709. ldionne marked an inline comment as done. ldionne added a comment. Herald added subscribers: pmatos, asb, abrachet, atanasyan, jrtc27, aheejin, jgravelle-google, sbc100, sdardis, dschuff, emaste. - Rebase - Rename to -fexperimental-library - Add

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay added inline comments. Comment at: llvm/lib/IR/Function.cpp:357 } + if (M->getModuleFlag("fn_return_thunk_extern")) +B.addAttribute(Attribute::FnRetThunkExtern); How about "function_return_thunk_extern"? fn doesn't abbreviate much. Having the

[clang] 041d401 - Revert "Rewording "static_assert" diagnostics"

Author: Mitch Phillips Date: 2022-07-14T10:59:20-07:00 New Revision: 041d4012e4c0898bb4e31ffb75655d8163e3ee89 URL: https://github.com/llvm/llvm-project/commit/041d4012e4c0898bb4e31ffb75655d8163e3ee89 DIFF:

[PATCH] D129048: Rewording the "static_assert" to static assertion

hctim added a comment. Looks like unfortunately this breaks all lots of libcxx tests - which were picked up by our sanitizer buildbots: https://lab.llvm.org/buildbot/#/builders/85/builds/9157 Should be reproducible with just `cmake -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" && make check-cxx`.

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444742. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - rename md idententifier, sort langref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers added a comment. Thanks for the review! Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN: -mfunction-return=thunk-extern -fprofile-arcs \

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444755. usaxena95 added a comment. Addressed offline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

SebastianPerta added a comment. >>But can you add some test coverage for this? In clang\test\Headers\limits.cpp there is: _Static_assert(USHRT_MAX == (unsigned short)~0ULL, ""); However as I said this needs a 16 bits target. Looking at the RUN commands at the top of the file I think I can solve

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. Sorry for the delay! I rebased the patch onto latest and it mostly worked, with a few hitches. Comment at: clang/lib/Sema/SemaCast.cpp:2617-2619 + (Self.getLangOpts().OpenCL && + (DestPPointee->isFunctionType() || +

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

aaron.ballman added a comment. In D129689#3651965 , @SebastianPerta wrote: >>>But can you add some test coverage for this? > In clang\test\Headers\limits.cpp there is: > _Static_assert(USHRT_MAX == (unsigned short)~0ULL, ""); > However as I said this

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added inline comments. Comment at: clang/test/OpenMP/target_update_messages.cpp:17 -static int y; -#pragma omp declare target(y) - -void yyy() { -#pragma omp target update to(y) // expected-error {{the host cannot update a declare target variable that is not

[PATCH] D127270: [clang-format] Add space in placement new expression

curdeius accepted this revision. curdeius added inline comments. Comment at: clang/include/clang/Format/Format.h:3504 +enum AfterPlacementOperatorStyle : int8_t { + /// Removes space after ``new/delete`` operators and before ``(``. + /// \code We

[PATCH] D129691: [clang][test] fix typo in fn attr

nickdesaulniers updated this revision to Diff 444695. nickdesaulniers added a comment. - don't reset captured vars, that was a copy+paste mistake I made in the original patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129691/new/

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > https://github.com/llvm/llvm-project/issues/56514 > > Fixes #56514 Just use `Fixes https://github.com/llvm/llvm-project/issues/56514` or `Fixes #56514`. GitHub can close the issue

[PATCH] D129594: [InstrProf] Add options to profile function groups

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129594/new/ https://reviews.llvm.org/D129594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova marked an inline comment as done. cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/cxx_proto.proto:1 +//===-- cxx_proto.proto - Protobuf description of C++ -===// +// JDevlieghere wrote: >

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444761. cassanova edited the summary of this revision. cassanova added a comment. Removed the cxx_proto.proto file since we include the headers that it generates from the clang side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129377/new/

[clang] d2792e7 - [clang][test] fix typo in fn attr

Author: Nick Desaulniers Date: 2022-07-14T09:49:11-07:00 New Revision: d2792e7d37c4b454a6b052cd569ff13ed7f22159 URL: https://github.com/llvm/llvm-project/commit/d2792e7d37c4b454a6b052cd569ff13ed7f22159 DIFF:

[PATCH] D129691: [clang][test] fix typo in fn attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2792e7d37c4: [clang][test] fix typo in fn attr (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + // printing multiple diagnostic location and diag opts. + EmitResourceUsageRemark("KernelName", "Kernel Name", + MF.getFunction().getName());

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

MaskRay added a comment. Sound good to land the current form (we have sufficient tests for Sema and -fsanitize=array-bounds now) and have `=3` as a separate discussion. Comment at: clang/test/CodeGen/bounds-checking-fam.c:8 +// one-element array as the last emember of a

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + // printing multiple diagnostic location and diag opts. + EmitResourceUsageRemark("KernelName", "Kernel Name", + MF.getFunction().getName());

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + // printing multiple diagnostic location and diag opts. + EmitResourceUsageRemark("KernelName", "Kernel Name", + MF.getFunction().getName());

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(, 1); StephenFan wrote: > vitalybuka wrote: > > vitalybuka wrote: > > > Please check for lifetime markers, I assume case 2 will have a new one > > >

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3652679 , @hctim wrote: > Looks like unfortunately this breaks all lots of libcxx tests - which were > picked up by our sanitizer buildbots: Thanks for letting us know. Do you happen to know if there's any

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka updated this revision to Diff 444735. vitalybuka added a comment. remove debug changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129789/new/ https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(, 1); vitalybuka wrote: > StephenFan wrote: > > vitalybuka wrote: > > > vitalybuka wrote: > > > > Please check for lifetime markers, I assume case 2

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129789/new/ https://reviews.llvm.org/D129789

[PATCH] D129048: Rewording the "static_assert" to static assertion

hctim added a comment. In D129048#3652689 , @aaron.ballman wrote: > In D129048#3652679 , @hctim wrote: > >> Looks like unfortunately this breaks all lots of libcxx tests - which were >> picked up by our

[clang] 140bfdc - [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

Author: Nick Desaulniers Date: 2022-07-14T11:25:24-07:00 New Revision: 140bfdca60ae8b1b2ad115846379e3c9ca914bfb URL: https://github.com/llvm/llvm-project/commit/140bfdca60ae8b1b2ad115846379e3c9ca914bfb DIFF:

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG140bfdca60ae: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/CodeGen/attr-function-return.c:9 // RUN: --check-prefixes=CHECK,CHECK-EXTERN +// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \ +// RUN:

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. @aaron.ballman The culprit turned out to be the difference in release flags on the build server vs my environment. I had unfortunately run the configuration command once in `Debug` mode, and hadn't re-configured. Not a bright moment :) The `ASSERT_DEATH` tests that

[PATCH] D129678: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

ASDenysPetrov updated this revision to Diff 444752. ASDenysPetrov added a comment. Fixed a typo that caused `constraint_manager_negate.c` and `unary-sym-expr.c` tests crashes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129678/new/ https://reviews.llvm.org/D129678 Files:

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

jdoerfert added subscribers: RaviNarayanaswamy, Anastasia, tra, bader. jdoerfert added a comment. In D128907#3652077 , @arsenm wrote: > In D128907#3650750 , @jdoerfert > wrote: > >> That said, I doubt this is

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/cxx_proto.proto:1 +//===-- cxx_proto.proto - Protobuf description of C++ -===// +// Do we still need a copy of this for LLDB? CHANGES SINCE LAST

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov updated this revision to Diff 444689. ASDenysPetrov added a comment. Stick to name `clang_analyzer_value`. Change function name from `printRange` to `printValue`. Make description more precise in the documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129498/new/

[clang] e71fd54 - [NFC] Move check for isEqualityOp to CheckFloatComparisons

Author: Erich Keane Date: 2022-07-14T09:30:29-07:00 New Revision: e71fd547194591fbdfb617479e47b1b7cf6e9151 URL: https://github.com/llvm/llvm-project/commit/e71fd547194591fbdfb617479e47b1b7cf6e9151 DIFF: https://github.com/llvm/llvm-project/commit/e71fd547194591fbdfb617479e47b1b7cf6e9151.diff

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

MaskRay added a comment. `-r -pie` feels like an error to me. `gcc -dumpspecs` uses `%{static|shared|r:;!no-pie:-pie}`, which means `-r` overrides `-pie`. Either match the behavior if report an error. If reporting an error adds too much complexity, just match the behavior. We just shouldn't let

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c

[PATCH] D129591: Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

shafik updated this revision to Diff 444744. shafik added a comment. Adding release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129591/new/ https://reviews.llvm.org/D129591 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/DeclCXX.cpp

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/UsersManual.rst:853 + * ``no-compact-unwind`` - Only emit DWARF unwind when compact unwind encodings +aren't available. This is the

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: clang/include/clang/Driver/Options.td:1186 -defm unstable : BoolFOption<"unstable", - LangOpts<"Unstable">,

[clang] a629ec2 - [test] Fix D129789 for 32bit platforms

Author: Vitaly Buka Date: 2022-07-14T12:44:15-07:00 New Revision: a629ec2f47a64b1a5b33dbcedf1efc6989f97641 URL: https://github.com/llvm/llvm-project/commit/a629ec2f47a64b1a5b33dbcedf1efc6989f97641 DIFF: https://github.com/llvm/llvm-project/commit/a629ec2f47a64b1a5b33dbcedf1efc6989f97641.diff

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

arsenm added a comment. In D128907#3652140 , @jdoerfert wrote: > In D128907#3652077 , @arsenm wrote: > >> In D128907#3650750 , @jdoerfert >> wrote: >> >>> That said, I

[PATCH] D129678: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Took a while to accept that this is indeed an NFC, but looks good! And indeed the code is better structured this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

martong added a comment. In D104647#3643060 , @ASDenysPetrov wrote: > @vsavchenko Is this alive? I think, we could commit this and set Valery as the author (he is no longer working on CSA). Unless you find something wrong with the patch; in that case

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan updated this revision to Diff 444701. StephenFan added a comment. 1. Record bypassed lifetime start markers in codegenfunction class instead of lexicalscope. Since bypassed variables may be defined when lexicalscope is nullptr. This can also fix test fail of use-after-scope-goto.cpp.

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:42 +// O2: @llvm.lifetime.start.p0i8(i64 1 bar(, 1); +// O2: @llvm.lifetime.end.p0i8(i64 1 vitalybuka wrote: > It assume this will break Msan >

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3651025 , @aemerson wrote: > I just reverted this in 6e6be5f9504d > because > it seems to have broken macOS builds: > >

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay added a subscriber: urnathan. MaskRay added a comment. LGTM. It may be related, @urnathan wants to add `-std=c++{current,future}` to GCC and may have opinions on the option name. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5840 - if

[PATCH] D129772: [clang] Document -femit-compact-unwind flag in the User’s Manual

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:848 + + When to emit DWARF unwind (EH frame) info. This is a Mach-O-specific flag. + I think flag applies to these boolean options. This is an option, not a flag. Repository: rG LLVM

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3652739 , @hctim wrote: > In D129048#3652689 , @aaron.ballman > wrote: > >> In D129048#3652679 , @hctim wrote: >> >>> Looks

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

int3 updated this revision to Diff 444740. int3 retitled this revision from "[clang] Document -femit-compact-unwind flag in the User’s Manual" to "[clang] Document -femit-compact-unwind option in the User’s Manual". int3 added a comment. option Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444743. nickdesaulniers added a comment. - resort langref, oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/ https://reviews.llvm.org/D129709 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne updated this revision to Diff 444753. ldionne added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne marked an inline comment as done. ldionne added a comment. In D121141#3652616 , @MaskRay wrote: > LGTM. > > It may be related, @urnathan wants to add `-std=c++{current,future}` to GCC > and may have opinions on the option name. Interesting!

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 444759. vangthao added a comment. Change "Kernel Name" to "Function Name" and rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123878/new/ https://reviews.llvm.org/D123878 Files:

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 444764. vaibhav.y added a comment. Gate death tests on `NDEBUG` and available of `GTEST_HAS_DEATH_TEST` This should fix recent pre-merge failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1207 + auto EmitResourceUsageRemark = [&](StringRef RemarkName, + StringRef RemarkLabel, auto &) { +// Add an indent for every line besides the line

[clang] bfe63ab - Thread safety analysis: Support builtin pointer-to-member operators

Author: Aaron Puchert Date: 2022-07-14T13:36:14+02:00 New Revision: bfe63ab63e22b61bd5898c65425e8ebe43189913 URL: https://github.com/llvm/llvm-project/commit/bfe63ab63e22b61bd5898c65425e8ebe43189913 DIFF: https://github.com/llvm/llvm-project/commit/bfe63ab63e22b61bd5898c65425e8ebe43189913.diff

[clang] e0c66c6 - Thread safety analysis: Don't erase TIL_Opcode type (NFC)

Author: Aaron Puchert Date: 2022-07-14T13:36:35+02:00 New Revision: e0c66c699eb000f604e24b1c4e73b899b4d942d3 URL: https://github.com/llvm/llvm-project/commit/e0c66c699eb000f604e24b1c4e73b899b4d942d3 DIFF: https://github.com/llvm/llvm-project/commit/e0c66c699eb000f604e24b1c4e73b899b4d942d3.diff

[PATCH] D129514: Thread safety analysis: Support builtin pointer-to-member operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfe63ab63e22: Thread safety analysis: Support builtin pointer-to-member operators (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:74 +def FeatureFMV : SubtargetFeature<"fmv", "HasFMV", "true", + "Enable Function Multi Versioning support.">; echristo wrote: > What is this for? FMV is a target feature which is

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a reviewer: NoQ. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When support for copy

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129398/new/ https://reviews.llvm.org/D129398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:935 +// Same as constructors, but without tag types. (Requires C++17 copy elision.) +static MutexLocker Lock(Mutex *mu) ACQUIRE(mu) NO_THREAD_SAFETY_ANALYSIS { + return

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

jackhong12 added a comment. Good point! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3650749 , @glandium wrote: > FWIW, this change also broke this check in Firefox's clang plugin: >

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

jackhong12 added a comment. I think we cannot identify `struct`, `union`, `class` or `enum` by the right bracket. Clang-format will split the input into multiple lines. For instance `struct Tmp {} *tmp;` will be separated as `struct Tmp {` and `} *tmp;`. In annotating, we only handle the

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 444633. carlosgalvezp added a comment. - Rebase onto latest main. - Remove references to std::reference_wrapper as alternative suggestions, as per: https://github.com/isocpp/CppCoreGuidelines/issues/1919 Repository: rG LLVM Github Monorepo CHANGES

[clang] 32fe1a4 - [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

Author: Ella Ma Date: 2022-07-14T22:00:38+08:00 New Revision: 32fe1a4be95c90da9a24d63a097429ec7c3bbfba URL: https://github.com/llvm/llvm-project/commit/32fe1a4be95c90da9a24d63a097429ec7c3bbfba DIFF: https://github.com/llvm/llvm-project/commit/32fe1a4be95c90da9a24d63a097429ec7c3bbfba.diff LOG:

[PATCH] D129737: [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

This revision was automatically updated to reflect the committed changes. Closed by commit rG32fe1a4be95c: [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in… (authored by OikawaKirie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

cor3ntin added a comment. In D129689#3652010 , @aaron.ballman wrote: > In D129689#3651965 , > @SebastianPerta wrote: > But can you add some test coverage for this? >> In clang\test\Headers\limits.cpp there

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu added a comment. Or is it better to add a special option `-fno-preferred-name` to ignore it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129748/new/ https://reviews.llvm.org/D129748 ___

[PATCH] D129691: [clang][test] fix typo in fn attr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129691/new/ https://reviews.llvm.org/D129691

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaronpuchert added a comment. @efriedma, added you because this removes one of the `IgnoreParens` calls that you added in D76943 , and that I think should be dead code. (The one after `CXXBindTemporaryExpr`.) Repository: rG LLVM Github Monorepo CHANGES

  1   2   3   >