[PATCH] D130414: [pseudo] Reorganize CXX.h enums

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule { hokein wrote: > why there is a dummy namespace here? for each NT, we close the previous ns+enum and open

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 447246. njames93 added a comment. NL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 447248. SixWeining marked 5 inline comments as done. SixWeining added a comment. Continue to address @MaskRay's comments: LLVM_LIBRARY_VISIBILITY ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2226 + static const char *const LoongArch64LibDirs[] = {"/lib64", "/lib"}; + static const char *const LoongArch64Triples[] = { MaskRay wrote: > I don't know which of /lib64,

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/include/clang/Sema/Scope.h:213-215 + /// A single NRVO candidate variable in this scope, or nullptr if the + /// candidate is not available/allowed in this scope. + Optional NRVO; Now NRVO has three states,

[PATCH] D130460: [pseudo] Add recovery for declarations

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. - declaration recovery strategy: search for likely

[PATCH] D130460: [pseudo] Add recovery for declarations

sammccall added a comment. This may well need refinement & more testing, interested in initial thoughts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130460/new/ https://reviews.llvm.org/D130460 ___

[PATCH] D128695: [ODRHash diagnostics] Move `ODRDiagsEmitter` to libAST in separate files. NFC.

ChuanqiXu added a comment. I see. It looks like the tricks in `.git-blame-ignore-revs` doesn't work for this kind of move. I admit I don't look these changes in details. But as long as it is helpful for future changes, I think it should be good. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added a comment. @aaron.ballman do you mind give few more look on this patch, we would like gather LGTM from both RISC-V folks and clang folks, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/

[clang-tools-extra] 661e0b6 - [pseudo] Fix minor errors in module grammar

Author: Sam McCall Date: 2022-07-25T10:04:56+02:00 New Revision: 661e0b63f721832ab1015e32a4399470a625098f URL: https://github.com/llvm/llvm-project/commit/661e0b63f721832ab1015e32a4399470a625098f DIFF: https://github.com/llvm/llvm-project/commit/661e0b63f721832ab1015e32a4399470a625098f.diff

[clang] acd80a2 - [clang][ASTImporter] Improved handling of functions with auto return type.

Author: Balázs Kéri Date: 2022-07-25T10:28:01+02:00 New Revision: acd80a29ae7dcffabcb41e8579ebf4f371f0ddd7 URL: https://github.com/llvm/llvm-project/commit/acd80a29ae7dcffabcb41e8579ebf4f371f0ddd7 DIFF: https://github.com/llvm/llvm-project/commit/acd80a29ae7dcffabcb41e8579ebf4f371f0ddd7.diff

[PATCH] D129640: [clang][ASTImporter] Improved handling of functions with auto return type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacd80a29ae7d: [clang][ASTImporter] Improved handling of functions with auto return type. (authored by balazske). Repository: rG LLVM Github

[PATCH] D130338: [CMake] Copy folder without permissions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGefe1527e28ca: [CMake] Copy folder without permissions (authored by sebastian-ne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] efe1527 - [CMake] Copy folder without permissions

Author: Sebastian Neubauer Date: 2022-07-25T10:47:04+02:00 New Revision: efe1527e28ca45d2217d874364a1197de6ec156d URL: https://github.com/llvm/llvm-project/commit/efe1527e28ca45d2217d874364a1197de6ec156d DIFF:

[PATCH] D128667: [WIP] Add Zstd ELF support

MaskRay added inline comments. Comment at: llvm/tools/llvm-objcopy/ObjcopyOptions.cpp:1015 + } else { +if (Config.DecompressDebugSections && !compression::zstd::isAvailable()) + return createStringError( For --decompress-debug-sections, the zstd error

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

hokein added a comment. Thanks for exploring the idea, this looks like a good start to me. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule { why there is a dummy namespace here?

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

danielkiss added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4415-4430 -// Upgrade branch protection and return address signing module flags. The -// module flag behavior for these fields were Error and now they are Min. -if (ID->getString() ==

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 447236. njames93 added a comment. Add option `SplitConjunctions` to alter fix-it for `if` statements with `&&` in the condition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski added a comment. In D130078#3673288 , @MaskRay wrote: > In D130078#3669072 , @awarzynski > wrote: > >> In D130078#3667188 , @MaskRay >> wrote: >> >>>

[clang] 94ca2be - [clang][analyzer] Added partial wide character support to CStringChecker

Author: Balázs Kéri Date: 2022-07-25T09:23:14+02:00 New Revision: 94ca2beccc595c89c37eb3e5215ac97c3d930c8f URL: https://github.com/llvm/llvm-project/commit/94ca2beccc595c89c37eb3e5215ac97c3d930c8f DIFF: https://github.com/llvm/llvm-project/commit/94ca2beccc595c89c37eb3e5215ac97c3d930c8f.diff

[PATCH] D130091: [clang][analyzer] Added partial wide character support to CStringChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG94ca2beccc59: [clang][analyzer] Added partial wide character support to CStringChecker (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added a comment. @ChuanqiXu , could you take a look again? I've updated the original implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119792/new/ https://reviews.llvm.org/D119792

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

sstwcw added a comment. Are there any problems with this revision? The ones that depend on it are approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126845/new/ https://reviews.llvm.org/D126845

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

tejohnson added a subscriber: fhahn. tejohnson added a comment. In D128955#3674787 , @aeubanks wrote: > random question, if the old API is "legacy", are there any plans to remove it? @fhahn started to work on this at some point (see

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

xry111 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2226 + static const char *const LoongArch64LibDirs[] = {"/lib64", "/lib"}; + static const char *const LoongArch64Triples[] = { SixWeining wrote: > xry111 wrote: > > SixWeining

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

tstellar added a comment. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130337: [pseudo] Eliminate multiple-specified-types ambiguities using guards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2b993a6ae67: [pseudo] Eliminate multiple-specified-types ambiguities using guards (authored by sammccall). Changed prior to commit:

[clang-tools-extra] b2b993a - [pseudo] Eliminate multiple-specified-types ambiguities using guards

Author: Sam McCall Date: 2022-07-25T12:57:07+02:00 New Revision: b2b993a6ae675955b1112473c035ae6b4e3932a0 URL: https://github.com/llvm/llvm-project/commit/b2b993a6ae675955b1112473c035ae6b4e3932a0 DIFF: https://github.com/llvm/llvm-project/commit/b2b993a6ae675955b1112473c035ae6b4e3932a0.diff

[clang] 214a760 - Switch from XFAIL to UNSUPPORTED; NFC

Author: Aaron Ballman Date: 2022-07-25T07:21:19-04:00 New Revision: 214a760a211606d14b3b2b852bd9d9a21149317e URL: https://github.com/llvm/llvm-project/commit/214a760a211606d14b3b2b852bd9d9a21149317e DIFF: https://github.com/llvm/llvm-project/commit/214a760a211606d14b3b2b852bd9d9a21149317e.diff

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

usaxena95 added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54-62 +namespace dummy { +enum Rule { +//clang-format off +#define NONTERMINAL(NAME, ID) };} namespace NAME { enum Rule : RuleID { +#define RULE(LHS, RHS, ID) RHS = ID, #include

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

sammccall updated this revision to Diff 447286. sammccall added a comment. tweak formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130414/new/ https://reviews.llvm.org/D130414 Files: clang-tools-extra/pseudo/gen/Main.cpp

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59179d72b2e3: [Sema] Merge C++20 concept definitions from different modules in same TU (authored by ilya-biryukov). Changed prior to commit:

[clang] 59179d7 - [Sema] Merge C++20 concept definitions from different modules in same TU

Author: Ilya Biryukov Date: 2022-07-25T14:43:38+02:00 New Revision: 59179d72b2e3d3b99ebc342374c9c797d526ac5d URL: https://github.com/llvm/llvm-project/commit/59179d72b2e3d3b99ebc342374c9c797d526ac5d DIFF: https://github.com/llvm/llvm-project/commit/59179d72b2e3d3b99ebc342374c9c797d526ac5d.diff

[clang] 25558a1 - [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

Author: Iain Sandoe Date: 2022-07-25T14:28:59+01:00 New Revision: 25558a1bfd79e03bed74873ab83ccfc3650fb64f URL: https://github.com/llvm/llvm-project/commit/25558a1bfd79e03bed74873ab83ccfc3650fb64f DIFF: https://github.com/llvm/llvm-project/commit/25558a1bfd79e03bed74873ab83ccfc3650fb64f.diff

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25558a1bfd79: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1] (authored by iains). Changed prior to commit:

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:579 + else if (Args.hasArg(options::OPT_fno_data_sections)) +CmdArgs.push_back("-plugin-opt=-data-sections=0"); MaskRay wrote: > Is -plugin-opt=-data-sections=0 a problem

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

aaron.ballman added a comment. Also, this could use a release note. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130301/new/ https://reviews.llvm.org/D130301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

xry111 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2226 + static const char *const LoongArch64LibDirs[] = {"/lib64", "/lib"}; + static const char *const LoongArch64Triples[] = { SixWeining wrote: > MaskRay wrote: > > I don't know

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

sebastian-ne added a comment. In D101070#3675462 , @sebastian-ne wrote: > Hi, not sure if you saw D130256 , but I > needed to extend CMAKE_MODULE_PATH, otherwise the ExtendPath module was not > found when running

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, only minor nits found (feel free to ignore any that you disagree with). Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:346 +// RVVRequire should be sync with target features, but only

[PATCH] D130476: [NFC] Fix some C++20 warnings

Godin created this revision. Herald added a project: All. Godin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch when using CMAKE_CXX_STANDARD=20 Microsoft compiler produces following warnings

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 more question, otherwise this looks right to me. Comment at: compiler-rt/test/ubsan/TestCases/Misc/enum.cpp:27 + return ((int)e1 != -1) & ((int)e2 != -1) & +

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski updated this revision to Diff 447250. awarzynski added a comment. Change from CamelCase to camelCase in Flang.h so that the function names adhere to LLVM's coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130078/new/

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2226 + static const char *const LoongArch64LibDirs[] = {"/lib64", "/lib"}; + static const char *const LoongArch64Triples[] = { xry111 wrote: > SixWeining wrote: > > MaskRay

[clang] d351344 - [C++20] [Modules] Make the linkage consistent for class template and its

Author: Chuanqi Xu Date: 2022-07-25T17:57:02+08:00 New Revision: d35134485a6cd1b0e25b5dccd330678b9e57919d URL: https://github.com/llvm/llvm-project/commit/d35134485a6cd1b0e25b5dccd330678b9e57919d DIFF: https://github.com/llvm/llvm-project/commit/d35134485a6cd1b0e25b5dccd330678b9e57919d.diff

[clang] b826567 - [C++20][Modules] Add a testcase for [basic.link] p10 [NFC].

Author: Iain Sandoe Date: 2022-07-25T12:20:02+01:00 New Revision: b826567136e391095b7731d5121e2be2a8fdc9ee URL: https://github.com/llvm/llvm-project/commit/b826567136e391095b7731d5121e2be2a8fdc9ee DIFF: https://github.com/llvm/llvm-project/commit/b826567136e391095b7731d5121e2be2a8fdc9ee.diff

[PATCH] D117973: [cmake] Support custom package install paths

sebastian-ne added a comment. Two comments inline, apart from that it looks good to me. Comment at: cmake/Modules/FindPrefixFromConfig.cmake:30 + if(IS_ABSOLUTE "${path_to_leave}") +set(prefix_var + "# Installation prefix is fixed absolute path"

[PATCH] D49303: [CodeGen][ObjC] Treat non-escaping blocks as global blocks to make copy/dispose a no-op

jajadude added a comment. Herald added a project: All. @ahatanak @rjmccall What if a block is marked with `noescape` and captures some variables at the same time? Wouldn't that cause problem If the compiler continues to optimize it to `NSConcreteGlobal` type anyway? Repository: rL LLVM

[clang] 629903c - Reapply "[NFC] Add some additional features to MultiLevelTemplateArgumentList""

Author: Erich Keane Date: 2022-07-25T06:57:23-07:00 New Revision: 629903c8a4440095ecb98c7095f029783255db11 URL: https://github.com/llvm/llvm-project/commit/629903c8a4440095ecb98c7095f029783255db11 DIFF: https://github.com/llvm/llvm-project/commit/629903c8a4440095ecb98c7095f029783255db11.diff

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Requesting changes until we have an answer for the testing situation. Comment at: clang/lib/Sema/SemaDecl.cpp:18883-18884 + // If the enumerator

[PATCH] D130337: [pseudo] Eliminate multiple-specified-types ambiguities using guards

hokein added a comment. Feel free to land it. We have some number now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130337/new/ https://reviews.llvm.org/D130337 ___ cfe-commits mailing list

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3674585 , @Codesbyusman wrote: > In D129048#3674582 , @Mordante > wrote: > >> In D129048#3674500 , @Codesbyusman >> wrote: >>

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

sebastian-ne added a comment. Hi, not sure if you saw D130256 , but I needed to extend CMAKE_MODULE_PATH, otherwise the ExtendPath module was not found when running LLVMInstallSymlink.cmake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 447304. SixWeining added a comment. keep /lib64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Basic/CMakeLists.txt

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 447336. quinnp marked 3 inline comments as done. quinnp added a comment. Adressing review comments. Moving tests into `function-sections.c`, using `%s` instead of creating a new file with `touch`, and modifying some `CHECK` lines to simplify checks.

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added a comment. In D130306#3673120 , @xazax.hun wrote: > Thanks! I think this is a major design decision, and I'd love to see a > discussion about the alternatives considered before jumping to an > implementation. Specifically, I'd like to

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 marked 2 inline comments as done. Ericson2314 added inline comments. Comment at: cmake/Modules/FindPrefixFromConfig.cmake:30 + if(IS_ABSOLUTE "${path_to_leave}") +set(prefix_var + "# Installation prefix is fixed absolute path" sebastian-ne

[PATCH] D130446: [apinotes] Upstream changes to `APINotesYAMLCompiler.cpp`.

zoecarver added a comment. > Can you please add a round trip test as well? There is no testing infrastructure for this upstream. I have tests downstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130446/new/ https://reviews.llvm.org/D130446

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 updated this revision to Diff 447377. fsb4000 added a comment. drop the dummy file and update the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 Files:

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 updated this revision to Diff 447388. fsb4000 added a comment. Thanks. I already asked Mark de Wever. My name, email: Igor Zhukov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 Files:

[PATCH] D130419: Use `` with MSVC and C++

aaron.ballman added a comment. In D130419#3676736 , @Mordante wrote: > In D130419#3676654 , @aaron.ballman > wrote: > >> In D130419#3676643 , @fsb4000 >> wrote: >> >>>

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16379 +// UnsignedPointerDiffType avoid truncate. +AllocatorHT = Context.getUnsignedPointerDiffType(); + Allocator = PerformImplicitConversion(Allocator.get(), AllocatorHT, ABataev

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

alanphipps added a comment. Should there be an aarch64 guard on the test? There exist downstream Arm compilers that don't support Arm64 and fail. I know other tests explicitly state "REQUIRES: aarch64-registered-target" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

jdoerfert added a comment. > I'm still not seeing the issue fully. My understanding of the situation > (which may be wrong) is that Clang lowers to LLVM IR and adds noundef > markings at call sites that this patch attempts to let the user then undo. > However, why can Clang's CodeGen not

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. In D129973#3673094 , @SimplyDanny wrote: > Thank you for the review! Before I push the change into main I may add an > entry to `clang/docs/ReleaseNotes.rst`, right? > > And do you agree that the test failures are unrelated

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

Ericson2314 added a comment. @sebastian-ne Thanks yes I was worried that might happen. I think I will just move the `extend_path` to the caller then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

Ericson2314 updated this revision to Diff 447358. Ericson2314 added a comment. Rebase, make caller responsible for making paths absolute This avoids module resolution issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks marked an inline comment as done. aeubanks added a comment. In D128955#3676198 , @tejohnson wrote: > In D128955#3674787 , @aeubanks > wrote: > >> random question, if the old API is "legacy", are there

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 updated this revision to Diff 447372. jyu2 edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129872/new/ https://reviews.llvm.org/D129872 Files: clang/lib/Sema/SemaOpenMP.cpp

[clang] ba49d39 - Use `` with MSVC and C++

Author: Igor Zhukov Date: 2022-07-25T19:00:29+02:00 New Revision: ba49d39b20cc5358da28af2ac82bd336028780bc URL: https://github.com/llvm/llvm-project/commit/ba49d39b20cc5358da28af2ac82bd336028780bc DIFF: https://github.com/llvm/llvm-project/commit/ba49d39b20cc5358da28af2ac82bd336028780bc.diff

[PATCH] D130419: Use `` with MSVC and C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba49d39b20cc: Use `stdatomic.h` with MSVC and C++ (authored by fsb4000, committed by Mordante). Changed prior to commit:

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16379 +// UnsignedPointerDiffType avoid truncate. +AllocatorHT = Context.getUnsignedPointerDiffType(); + Allocator = PerformImplicitConversion(Allocator.get(), AllocatorHT, ABataev

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added a comment. In D130224#3668267 , @arsenm wrote: > In D130224#3668243 , @aaron.ballman > wrote: > >> In D130224#3668240 , @arsenm wrote: >> >>> In

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

shafik added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Misc/enum.cpp:27 + return ((int)e1 != -1) & ((int)e2 != -1) & + // CHECK: error: load of value , which is not a valid value for type 'enum EBool' + ((int)e3 != -1) & ((int)e4 == 1) &

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added a comment. @erichkeane @cor3ntin If you have time for review right now, I think it's reasonably ready and I would still like to merge it this week so it can land in Clang15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added a comment. In D130224#3677144 , @arsenm wrote: > In D130224#3668243 , @aaron.ballman > wrote: > >> I'm still not seeing the issue fully. My understanding of the situation >> (which may be

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The solution is to favor the longest possible nest-name-specifier, and drop

[PATCH] D130446: [apinotes] Upstream changes to `APINotesYAMLCompiler.cpp`.

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Can you please add a round trip test as well? Additionally, please add a proper commit message to describe the change here. Comment at:

[PATCH] D130419: Use `` with MSVC and C++

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM (be sure to drop the dummy file before landing), but please add a release note mentioning the fix as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks updated this revision to Diff 447359. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 Files: clang/lib/CodeGen/CGClass.cpp

[PATCH] D130493: Disable stack-sizes section by default for PS4.

MaggieYi created this revision. MaggieYi added reviewers: probinson, wristow. Herald added a project: All. MaggieYi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Change Clang's default so that -fstack-size-section is no longer

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

xazax.hun added a comment. Thanks! Knowing the context, I am much happier with the direction overall. Is the plan to analyze a mock of std::optional instead of the actual code in the STL? How will that mock be shipped? Would that be embedded in the binary? In D130306#3676475

[PATCH] D130510: updating the function for the tautological warnings for the unary operators

Codesbyusman created this revision. Codesbyusman added reviewers: aaron.ballman, erichkeane, xgupta. Herald added a reviewer: NoQ. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D101070: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs

sebastian-ne accepted this revision. sebastian-ne added a comment. This revision is now accepted and ready to land. No problem, thanks for the fixes! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070

[PATCH] D117973: [cmake] Support custom package install paths

sebastian-ne accepted this revision. sebastian-ne added a comment. This revision is now accepted and ready to land. Thank you, the comments make it clearer what’s happening. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/

[PATCH] D130419: Use `` with MSVC and C++

aaron.ballman added a comment. In D130419#3676643 , @fsb4000 wrote: > drop the dummy file and update the release notes. Thanks! I forgot to ask -- do you need someone to commit on your behalf? If so, what name and email address would you like used for

[PATCH] D130419: Use `` with MSVC and C++

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. In D130419#3676654 , @aaron.ballman wrote: > In D130419#3676643 , @fsb4000 wrote: > >> drop the dummy

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

MaskRay updated this revision to Diff 447387. MaskRay edited the summary of this revision. MaskRay added a comment. Keep AutoUpgrade.cpp code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130145/new/ https://reviews.llvm.org/D130145 Files:

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16379 +// UnsignedPointerDiffType avoid truncate. +AllocatorHT = Context.getUnsignedPointerDiffType(); + Allocator = PerformImplicitConversion(Allocator.get(), AllocatorHT, jyu2

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:48 + +constexpr int NoCompression = -5; +constexpr int BestSpeedCompression = 1; I missed the values here. Why is -5 picked for NoCompression? What does it mean? zstd.h says

[PATCH] D101070: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs

Ericson2314 added a comment. Also sorry, I had missed D130256 all along! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070 ___

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

arsenm added a comment. In D130224#3668243 , @aaron.ballman wrote: > I'm still not seeing the issue fully. My understanding of the situation > (which may be wrong) is that Clang lowers to LLVM IR and adds `noundef` > markings at call sites that this

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 447361. Ericson2314 added a comment. Fix bug, and add comments to both branches for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 Files:

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4415-4430 -// Upgrade branch protection and return address signing module flags. The -// module flag behavior for these fields were Error and now they are

[PATCH] D129570: Add new clang-tidy check to find implicit conversions from enum to integer.

artem.tamazov requested changes to this revision. artem.tamazov added a comment. This revision now requires changes to proceed. A typo in the doc, but otherwise LGTM. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/enum-to-int.rst:8 +integer. In C++11, enums can

[PATCH] D49303: [CodeGen][ObjC] Treat non-escaping blocks as global blocks to make copy/dispose a no-op

rjmccall added a comment. Blocks that don't capture anything have always been allocated globally. This optimization is using the global ISA for blocks that do capture locals but which are known statically (on penalty of UB) to not escape the original scope of the block literal. Using the

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16379 +// UnsignedPointerDiffType avoid truncate. +AllocatorHT = Context.getUnsignedPointerDiffType(); + Allocator = PerformImplicitConversion(Allocator.get(), AllocatorHT, It must

[clang] 2e80d2d - [Clang] Status of the C++23 papers approved by WG21 at the July plenary

Author: Corentin Jabot Date: 2022-07-25T19:43:06+02:00 New Revision: 2e80d2d7c3f4ed4433f747a5644817d095250df9 URL: https://github.com/llvm/llvm-project/commit/2e80d2d7c3f4ed4433f747a5644817d095250df9 DIFF:

  1   2   >