[PATCH] D119209: Implement -fctor_dtor_return_this ABI option.

scw updated this revision to Diff 464801. scw added a comment. Remove unnecessary curly braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119209/new/ https://reviews.llvm.org/D119209 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D119209: Implement -fctor_dtor_return_this ABI option.

MaskRay added a comment. > Implement -fctor_dtor_return_this ABI option. Typo in the subject. I'd use: `Add cc1 option -fctor-dtor-return-this` Comment at: clang/include/clang/Driver/Options.td:5608 +def fctor_dtor_return_this : Flag<["-"], "fctor-dtor-return-this">, +

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

shafik added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2999 + Self.Diag(SrcExpr.get()->getExprLoc(), diag::err_nullptr_cast) + << 0 /*nullptr to type*/ << DestType; + SrcExpr = ExprError(); Curious why put the comment after?

[PATCH] D135011: Add sin and cos llvm builtins

rjmccall added a comment. The titled of this patch should be something like "Add __builtin_elementwise_sin and __builtin_elementwise_cos". Can you explain why this uses a new builtin name instead of overloading the existing builtins to work on vectors? I can imagine reasons why, but I think

[PATCH] D134688: MSVC AArch64 ABI: Homogeneous aggregates

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134688/new/ https://reviews.llvm.org/D134688 ___

[clang] def48ca - [test] Clean up Driver/baremetal.cpp

Author: Fangrui Song Date: 2022-10-03T15:35:18-07:00 New Revision: def48cae45a5085b7759f2be71768e27718b901a URL: https://github.com/llvm/llvm-project/commit/def48cae45a5085b7759f2be71768e27718b901a DIFF: https://github.com/llvm/llvm-project/commit/def48cae45a5085b7759f2be71768e27718b901a.diff

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen updated this revision to Diff 464861. ychen added a comment. - add back `IsDependent` parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135088/new/ https://reviews.llvm.org/D135088 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D135011: Add sin and cos llvm intrinsics

bob80905 updated this revision to Diff 464730. bob80905 added a comment. run git clang-format on changes rather than whole document Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files:

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. In D135076#3830989 , @jhuber6 wrote: > In D135076#3830972 , @MaskRay wrote: > >> There are traditionally some single-dash long options (perhaps classical Mac >> OS style) which conflict

[PATCH] D135090: [Clang] fix -Wvoid-ptr-dereference for gnu89

nickdesaulniers created this revision. nickdesaulniers added reviewers: aaron.ballman, junaire. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow up to D134702

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 464738. ayzhao edited the summary of this revision. ayzhao added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. In D135076#3831347 , @jhuber6 wrote: > In D135076#3831340 , @MaskRay wrote: > >> In D135076#3831307 , @jhuber6 >> wrote: >> >>> In

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG939a3d22e21f: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl (authored by erichkeane). Herald added a project: clang. Changed

[PATCH] D135115: [clang-format] update --files help description

ychen created this revision. ychen added reviewers: MyDeveloperDay, probinson. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. correlates the option with reponse file concept. Repository: rG LLVM

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

mizvekov accepted this revision. mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5768-5769 if (!IsCanon) { if (DeducedType.isNull()) { - SmallVector CanonArgs; - bool AnyNonCanonArgs = - ::getCanonicalTemplateArguments(*this,

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14539 LangOptions LO = S.getLangOpts(); -if (LO.CPlusPlus || !(LO.C99 && IsAfterAmp)) +if (LO.CPlusPlus || !(LO.C99 && (IsAfterAmp || S.isUnevaluatedContext( S.Diag(OpLoc,

[PATCH] D135093: Revert D135076 "[Clang] Make offloading flags accept '-' and '--'"

MaskRay created this revision. MaskRay added reviewers: jhuber6, jdoerfert, JonChesterfield. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit

[clang] 939a3d2 - [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

Author: Erich Keane Date: 2022-10-03T12:44:21-07:00 New Revision: 939a3d22e21f80246fc6a417da7193c0b93a7a44 URL: https://github.com/llvm/llvm-project/commit/939a3d22e21f80246fc6a417da7193c0b93a7a44 DIFF: https://github.com/llvm/llvm-project/commit/939a3d22e21f80246fc6a417da7193c0b93a7a44.diff

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

ASDenysPetrov added a comment. @martong > So, the intersection should be empty in the above mentioned ambiguous case, > shouldn't' it? No. My current implementation doesn't contain this check in ConstraintAssignor in favor of the solution simplification. It'll be added in the next patches.

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

serge-sans-paille added a comment. @aaron.ballman : gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134791/new/ https://reviews.llvm.org/D134791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

vsapsai added a comment. How correct is it to access `isConst`, `isVolatile`, `isRestrict` for `FunctionNoProtoType`? Yes, we can provide some default value but I'm curious if accessing that default value is correct. For the record, I've tried to fix the same problem in

[PATCH] D119209: [clang] Add cc1 option -fctor-dtor-return-this

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3933c43d9008: [clang] Add cc1 option -fctor-dtor-return-this (authored by scw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic marked an inline comment as done. jpenix-quic added a comment. In D130513#3827108 , @jeanPerier wrote: > The lowering part looks good to me (I only have a minor comment inlined about > a header used in lowering). Thank you @jeanPerier for

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi created this revision. Herald added a subscriber: mgrang. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the context of caching clang invocations it is important to emit diagnostics in

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added subscribers: kosarev, Anastasia, mattd, gchakrabarti, asavonic, kerbowa, jvesely. Herald added a reviewer: aaron.ballman. Herald added a project: All. python3kgae requested review of this

[PATCH] D135027: [Clang][MinGW][cygwin] Fix __declspec with -fdeclspec enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rGd90633a74bef: [Clang][MinGW][cygwin] Fix __declspec with -fdeclspec enabled (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d90633a - [Clang][MinGW][cygwin] Fix __declspec with -fdeclspec enabled

Author: Alvin Wong Date: 2022-10-03T10:58:45+03:00 New Revision: d90633a74befa257f8617c4784d74a27fd287720 URL: https://github.com/llvm/llvm-project/commit/d90633a74befa257f8617c4784d74a27fd287720 DIFF: https://github.com/llvm/llvm-project/commit/d90633a74befa257f8617c4784d74a27fd287720.diff

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder updated this revision to Diff 464618. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/Interp/records.cpp Index:

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 464623. Purva-Chaudhari added a comment. fix test and clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 464628. Purva-Chaudhari added a comment. remove white space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 added a comment. @MaskRay and @nickdesaulniers Can you please work together to reach a consensus on what is the best path forward? I am ok either way, just need to know what the next steps are. :) Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 464640. domada marked an inline comment as done. domada retitled this revision from "[OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder" to "[OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder". domada added a

[PATCH] D135026: [clang-format] Handle C# interpolated verbatim string prefix @$

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135026/new/ https://reviews.llvm.org/D135026

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

mgorny created this revision. mgorny added reviewers: sammccall, kadircet, hokein, ilya-biryukov, kbobyrev, MaskRay, thesamesam. Herald added subscribers: StephenFan, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a project: clang-tools-extra. Add

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

bcl5980 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1384 + TC.getTriple().getSubArch() != llvm::Triple::AArch64SubArch_arm64ec) { +if (UArgs->hasArg(options::OPT__SLASH_arm64EC)) { + getDiags().Report(clang::diag::warn_target_override_arm64ec)

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

DavidSpickett added a comment. This looks fine as is, all comments addressed as far as I can see. Comment at: clang/lib/Driver/Driver.cpp:1384 + TC.getTriple().getSubArch() != llvm::Triple::AArch64SubArch_arm64ec) { +if (UArgs->hasArg(options::OPT__SLASH_arm64EC)) { +

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

martong accepted this revision. martong added a comment. In D133119#3827432 , @balazske wrote: > I added a simple detection of create a copy of `p` before `p = realloc(p, > ...)`. This can remove the warning at very obvious cases when a copy of `p` >

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

tomasz-kaminski-sonarsource updated this revision to Diff 464659. tomasz-kaminski-sonarsource added a comment. Included additional tests that corresponds to TODO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134947/new/

[PATCH] D134941: [analyzer][NFC] Add tests for D132236

martong added a comment. Thank you! Increasing coverage in tests is always great. Comment at: clang/test/Analysis/NewDeleteLeaks.cpp:196 + +namespace symbol_reaper_lifetime { +struct Nested { Could you please add some explanation for the test case? Thinking of

[PATCH] D134941: [analyzer][NFC] Add tests for D132236

tomasz-kaminski-sonarsource marked 2 inline comments as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/symbol-reaper-lambda.cpp:14 +escape(param, local_pre_lambda); +return ref_captured; // no-warning: The value is not garbage. +

[PATCH] D134941: [analyzer][NFC] Add tests for D132236

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the update! LGTM. Comment at: clang/test/Analysis/trivial-copy-struct.cpp:57 + + // Dead code should be unreachable + clang_analyzer_warnIfReached(); //

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0fff3db6ada: [ARM64EC][clang-cl] Add /arm64EC flag (authored by bcl5980). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134788/new/

[clang] b0fff3d - [ARM64EC][clang-cl] Add /arm64EC flag

Author: chenglin.bi Date: 2022-10-03T21:20:51+08:00 New Revision: b0fff3db6ada11e42a28389bb2b0c48181e2f719 URL: https://github.com/llvm/llvm-project/commit/b0fff3db6ada11e42a28389bb2b0c48181e2f719 DIFF: https://github.com/llvm/llvm-project/commit/b0fff3db6ada11e42a28389bb2b0c48181e2f719.diff

[PATCH] D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

domada updated this revision to Diff 464648. domada retitled this revision from "[OpenMP] Add support for order(concurrent) to OMPIRBuilder for SIMD directive" to "[OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive". domada added a comment. Herald added a

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 464649. Purva-Chaudhari added a comment. check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. I'm wondering whether classes like `TemplateArgumentLoc` could refer to the template head of the `TemplateArgument`, so the comparison of parameter mappings could be modified, and then the refered variable could be accepted. Comment at:

[PATCH] D134941: [analyzer][NFC] Add tests for D132236

tomasz-kaminski-sonarsource updated this revision to Diff 464657. tomasz-kaminski-sonarsource added a comment. Added requested comment for the example. Included additional false-positive test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

martong added a comment. I like the approach of this patch and I think this is somewhat aligned with @NoQ's ideas about > a list of explicitly-live compound values and > "weak region roots" that aren't necessarily live themselves but anything > derived from them ... is live Coupled with the

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

bcl5980 marked 4 inline comments as done. bcl5980 added a comment. Thanks for the detail explaination. I agree that if the cost is the same hasArg is better to move to the first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134788/new/ https://reviews.llvm.org/D134788

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

This revision was automatically updated to reflect the committed changes. Closed by commit rG11adae50892e: [Clang] Make offloading flags accept - and -- (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135076/new/

[clang] 11adae5 - [Clang] Make offloading flags accept '-' and '--'

Author: Joseph Huber Date: 2022-10-03T10:35:51-05:00 New Revision: 11adae50892e6e94f10ce41bc738a9823a6b3251 URL: https://github.com/llvm/llvm-project/commit/11adae50892e6e94f10ce41bc738a9823a6b3251 DIFF: https://github.com/llvm/llvm-project/commit/11adae50892e6e94f10ce41bc738a9823a6b3251.diff

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/test/CodeGen/amdgcn-link-control-constants.c:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-globals --include-generated-funcs --global-value-regex

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

MaskRay added a comment. Single-dash long options starting with `-o` conflict with the short option `-o` so I am unsure I like this direction. > This is similar to many other driver arguments beginning with -o. What options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134941: [analyzer][NFC] Add tests for D132236

This revision was automatically updated to reflect the committed changes. tomasz-kaminski-sonarsource marked an inline comment as done. Closed by commit rG73716baa30eb: [analyzer][NFC] Add tests for D132236 (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github Monorepo CHANGES

[clang] 73716ba - [analyzer][NFC] Add tests for D132236

Author: Tomasz Kamiński Date: 2022-10-03T15:42:38+02:00 New Revision: 73716baa30ebc75783d2902e12accea35dec193a URL: https://github.com/llvm/llvm-project/commit/73716baa30ebc75783d2902e12accea35dec193a DIFF:

[PATCH] D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

jdoerfert added a comment. I think the rest looks good. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:213 + enum class OMPOrderClauseValue { NotSpecified, Concurrent }; + I think this belongs into

[PATCH] D44604: Make stdarg.h compatible with FreeBSD

arichardson abandoned this revision. arichardson added a comment. Herald added a subscriber: jrtc27. Herald added a project: All. Hopefully no longer required. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44604/new/ https://reviews.llvm.org/D44604

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

tomasz-kaminski-sonarsource updated this revision to Diff 464673. tomasz-kaminski-sonarsource marked 3 inline comments as done. tomasz-kaminski-sonarsource added a comment. Applied review suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

tomasz-kaminski-sonarsource added a comment. Applied all review suggestions. Comment at: clang/lib/StaticAnalyzer/Core/SymbolManager.cpp:461 +bool SymbolReaper::isLazilyCopiedRegion(const MemRegion *MR) const { + // TODO: See comment in isLiveRegion. + return

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Like that a lot, good quality of life improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135076/new/

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

tomasz-kaminski-sonarsource updated this revision to Diff 464677. tomasz-kaminski-sonarsource added a comment. Herald added subscribers: openmp-commits, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, mravishankar, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

tomasz-kaminski-sonarsource updated this revision to Diff 464678. tomasz-kaminski-sonarsource added a comment. Fighting with arcanist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134947/new/ https://reviews.llvm.org/D134947 Files:

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 464683. qiongsiwu1 added a comment. Address a code review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the updates. I am okay with it now. LGTM. But please wait for NoQ's approval. So, this is a gentle ping for you @NoQ :) Comment at:

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2976 + const int DefaultAlignment = 16; + jdoerfert wrote: > domada wrote: > > jdoerfert wrote: > > > This doesn't work. Use the data layout for any default values please. > >

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

JonChesterfield added a comment. In D130096#3816149 , @arsenm wrote: > I'd prefer to avoid spreading special treatment of the device libraries into > the backend. The contract is poorly defined and spread around too much as it > is

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/test/CodeGen/amdgcn-link-control-constants.c:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-globals --include-generated-funcs --global-value-regex

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2976 + const int DefaultAlignment = 16; + domada wrote: > jdoerfert wrote: > > This doesn't work. Use the data layout for any default values please. > I have used pointer

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130096/new/ https://reviews.llvm.org/D130096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133499: [clang]: Add DeclContext::dumpAsDecl().

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Please see the two comments, otherwise this LGTM. Feel free to fix the below as a part of the commit process. Comment at: clang/lib/AST/ASTDumper.cpp:240 + // the

[PATCH] D134650: [runtimes] Remove all traces of the legacy testing configuration system

arichardson added a comment. In case anyone else runs into this: It appears this change somehow broke incremental builds with `-DLLVM_ENABLE_RUNTIMES=libunwind` (even after deleting CMakeCache.txt in the main build dir): -- Using libunwind testing configuration:

[PATCH] D133500: [clang] Correct handling of lambdas in lambda default arguments in dependent contexts.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm OK with it as-is, and the refactor to move the replicated code would be acceptable in an NFC followup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

uabelho added a comment. Herald added a project: All. I wrote https://github.com/llvm/llvm-project/issues/58123 about a crash that I bisected to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, tianshilei1992, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[clang] 4987ae8 - [ARM][AArch64] Dont use macros for half instrinsics in NeonEmitter

Author: David Green Date: 2022-10-03T15:27:23+01:00 New Revision: 4987ae84622b804e72c405aacbe297f0e5e247c7 URL: https://github.com/llvm/llvm-project/commit/4987ae84622b804e72c405aacbe297f0e5e247c7 DIFF: https://github.com/llvm/llvm-project/commit/4987ae84622b804e72c405aacbe297f0e5e247c7.diff

[PATCH] D131504: [ARM][AArch64] Dont use macros for half instrinsics in NeonEmitter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4987ae84622b: [ARM][AArch64] Dont use macros for half instrinsics in NeonEmitter (authored by dmgreen). Herald added a project: clang. Herald added

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/test/CodeGen/amdgcn-link-control-constants.c:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-globals --include-generated-funcs --global-value-regex

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

tomasz-kaminski-sonarsource updated this revision to Diff 464684. tomasz-kaminski-sonarsource added a comment. Applied suggested comment updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134947/new/ https://reviews.llvm.org/D134947 Files:

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/test/CodeGen/amdgcn-link-control-constants.c:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-globals --include-generated-funcs --global-value-regex

<    1   2