[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat marked 2 inline comments as done. wangleiat added a comment. Thanks. @SixWeining Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/ https://reviews.llvm.org/D135526 ___ cfe-commits

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat updated this revision to Diff 466349. wangleiat added a comment. Address @SixWeining's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/ https://reviews.llvm.org/D135526 Files: clang/lib/Basic/Targets/LoongArch.h

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

SixWeining accepted this revision. SixWeining added inline comments. Comment at: clang/test/CodeGen/LoongArch/atomics.c:2 +// RUN: %clang_cc1 -triple loongarch32 -O1 -emit-llvm %s -o - \ +// RUN: | FileCheck %s -check-prefix=LA32 +// RUN: %clang_cc1 -triple loongarch64 -O1

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

owenpan added a comment. Since this option doesn't work for empty functions yet, we should either add a note in the documentation or qualify the scope with "non-empty" as suggested in my comments. Comment at: clang/docs/ReleaseNotes.rst:528 +- Add

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat created this revision. wangleiat added reviewers: SixWeining, xen0n, xry111, gonglingqin, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. wangleiat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3844605 , @ChuanqiXu wrote: > In D134267#3815453 , @dblaikie > wrote: > >>> This also tries to fix the problem I raised a year ago: >>>

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. In D134267#3844605 , @ChuanqiXu wrote: > In D134267#3815453 , @dblaikie > wrote: > >>> This also tries to fix the problem I raised a year ago: >>>

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:1836 +// The index of the template parameter this substitution represents. +unsigned Index : 15; + erichkeane wrote: > Is it a problem for this to be a different number of bits

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 466318. cjdb retitled this revision from "[clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`" to "[clang] adds `__reference_constructs_from_temporary`". cjdb added a comment. discards work on

[PATCH] D135339: [clang] makes `__is_destructible` KEYALL instead of KEYMS

cjdb updated this revision to Diff 466316. cjdb retitled this revision from "[clang] makes `__is_destructible` KEYCXX instead of KEYMS" to "[clang] makes `__is_destructible` KEYALL instead of KEYMS". cjdb edited the summary of this revision. cjdb added a comment. applies feedback, rebases

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb updated this revision to Diff 466315. cjdb marked 5 inline comments as done. cjdb added a comment. applies feedback, rebases, adds documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/ https://reviews.llvm.org/D135177

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

cjdb updated this revision to Diff 466314. cjdb marked 4 inline comments as done. cjdb added a comment. applies requested changes, adds documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135175/new/ https://reviews.llvm.org/D135175

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. After 4 weeks' study, I think the comment didn't need to be changed, sorry to have bring your so much trouble. During this valuable process of studying, I grow up a lot. I learned to read the C++ standard, and compare the standard to its implementation. In my case,

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Thanks everybody! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b85e765000d: [PGO] Consider parent context when weighing branches with likelyhood. (authored by AntonBikineev). Changed prior to commit: https://reviews.llvm.org/D134456?vs=462250=466313#toc

[clang] 7b85e76 - [PGO] Consider parent context when weighing branches with likelyhood.

Author: Anton Bikineev Date: 2022-10-08T23:49:27+02:00 New Revision: 7b85e765000df36fcc6a5191dec9a28f444245ba URL: https://github.com/llvm/llvm-project/commit/7b85e765000df36fcc6a5191dec9a28f444245ba DIFF:

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added a comment. I've found a strange scenario. The following conversions are allowed double *a[2][3]; double const * const (*ap)[3] = a; // OK double * const (*ap1)[] = a; // OK since C++20 However if the same conversion is supposed to be performed in a `catch()`

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 466312. isuckatcs marked 2 inline comments as done. isuckatcs added a comment. Addressed comments and added support for multi-level pointers too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files:

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay added a comment. In D134454#3844627 , @zixuan-wu wrote: > It's fine for CSKY to use config file. I only have 2 points. Thanks. It'll be nice for CSKY to move away from changing `computeSysRoot`. > 1. I agree sysroot should be separated from GCC

[PATCH] D135519: [RISCV] Remove some vsetvli intrinsics under Zve32*.

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. Looks good to me. I think this should solve https://github.com/riscv/riscv-v-spec/issues/832. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131963: [libc++] Add custom clang-tidy checks

philnik added a comment. In D131963#3831786 , @smeenai wrote: > In D131963#3811811 , @ldionne wrote: > >> I'd be fine with this as-is if it works in the CI. >> >> IIUC, the current blocker for this is that the

[PATCH] D135519: [RISCV] Remove some vsetvli intrinsics under Zve32*.

craig.topper created this revision. craig.topper added reviewers: kito-cheng, eopXD, frasercrmck, rogfer01, reames. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

upsj created this revision. upsj added a reviewer: aaron.ballman. Herald added a project: All. upsj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. TextNodeDumper currently doesn't support printing the `TypeLoc` hierarchy, which makes

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

royjacobson added a comment. Should cxx_status.html be updated as well? It's listed there as a C++2b paper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 ___

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:169 +// For renaming, we're only interested in foo's declaration, so drop the other one +void

[PATCH] D135506: [clangd] FindTarget: UsingEnumDecl is not an alias

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb34cc462ff: [clangd] FindTarget: UsingEnumDecl is not an alias (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135506/new/

[clang-tools-extra] 2bb34cc - [clangd] FindTarget: UsingEnumDecl is not an alias

Author: Sam McCall Date: 2022-10-08T19:29:35+02:00 New Revision: 2bb34cc462ff857576a8145edc89ad2bdd1f4396 URL: https://github.com/llvm/llvm-project/commit/2bb34cc462ff857576a8145edc89ad2bdd1f4396 DIFF: https://github.com/llvm/llvm-project/commit/2bb34cc462ff857576a8145edc89ad2bdd1f4396.diff

[PATCH] D135506: [clangd] FindTarget: UsingEnumDecl is not an alias

sammccall added a comment. In D135506#3844919 , @tom-anders wrote: > lgtm, thanks! With this change in place, we could probably ajdust > `pickDeclToUse` in Hover.cpp (introduced in https://reviews.llvm.org/D133664) > to also check for `UsingDecl`

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3779 + return a>b?a:b;return a>b?a:b; +}; }; + owenpan wrote: > lahwaacz wrote: > > There is an

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

MyDeveloperDay updated this revision to Diff 466291. MyDeveloperDay marked 16 inline comments as done. MyDeveloperDay added a comment. - Switch to the looping method and remove the need to change parseBlock (phew!) thanks @owenpan for the guidance - Add tests for double `;;` - Change the name to

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

tom-anders updated this revision to Diff 466292. tom-anders added a comment. Add additional tests, only handle UsingDecl instead of BaseUsingDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135489/new/ https://reviews.llvm.org/D135489 Files:

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

tom-anders marked 4 inline comments as done. tom-anders added a comment. In D135489#3844426 , @sammccall wrote: > namespace ns { int foo(int); char foo(char); } > using ns::foo; > int x = foo(42); > char y = foo('x'); > > What should happen when

[PATCH] D135506: [clangd] FindTarget: UsingEnumDecl is not an alias

tom-anders accepted this revision. tom-anders added a comment. This revision is now accepted and ready to land. lgtm, thanks! With this change in place, we could probably ajdust `pickDeclToUse` in Hover.cpp (introduced in https://reviews.llvm.org/D133664) to also check for `UsingDecl` instead

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

MyDeveloperDay added a comment. In D135466#3844287 , @owenpan wrote: > @MyDeveloperDay Cool! > > In D135466#3843792 , > @HazardyKnusperkeks wrote: > >> Maybe even extend the option to other unnecessary

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson updated this revision to Diff 466285. royjacobson added a comment. Addrees CR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404 Files:

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson marked 2 inline comments as done. royjacobson added a comment. In D135404#3842156 , @njames93 wrote: > Why limit this to just the value type traits, makes sense to also support > type type traits. I'd love to, but I can't match against the

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

tbaeder updated this revision to Diff 466282. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135513/new/ https://reviews.llvm.org/D135513 Files: clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

tbaeder updated this revision to Diff 466281. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135513/new/ https://reviews.llvm.org/D135513 Files: clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

tbaeder updated this revision to Diff 466280. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135513/new/ https://reviews.llvm.org/D135513 Files: clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the double Call() implementation to reduce

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

Mordante added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:525 +TYPE_TRAIT_1(__is_scoped_enum, IsScopedEnum, KEYCXX) +TYPE_TRAIT_1(__is_referenceable, IsReferenceable, KEYCXX) TYPE_TRAIT_2(__reference_binds_to_temporary, ReferenceBindsToTemporary,

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:81 + isBaseOf(TPointeeUQTy, BPointeeUQTy)) && + (TCVR == 0 || (BCVR ^ TCVR) == 0 || (BCVR & TCVR) > BCVR)) { +TypesToDelete.push_back(T);

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

Vigilans accepted this revision. Vigilans added a comment. In D129443#3844805 , @HazardyKnusperkeks wrote: > In D129443#3844535 , @owenpan wrote: > >> In D129443#3842427

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

cpplearner added a comment. In D133853#3808674 , @aaron.ballman wrote: > Now I'm wondering why the attribute exists at all. If it's functionally > equivalent to `constexpr` as a keyword, what are the use cases for the > attribute? It appears that

[clang-tools-extra] a8fbd11 - [clang-tidy] Ignore concepts in `misc-redundant-expression`

Author: Evgeny Shulgin Date: 2022-10-08T10:37:16Z New Revision: a8fbd1157debfe5872d4a34babef3aab75732aa7 URL: https://github.com/llvm/llvm-project/commit/a8fbd1157debfe5872d4a34babef3aab75732aa7 DIFF: https://github.com/llvm/llvm-project/commit/a8fbd1157debfe5872d4a34babef3aab75732aa7.diff

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8fbd1157deb: [clang-tidy] Ignore concepts in `misc-redundant-expression` (authored by Izaron). Changed prior to commit: https://reviews.llvm.org/D122078?vs=466271=466273#toc Repository: rG LLVM

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a reviewer: Vigilans. HazardyKnusperkeks added a comment. In D129443#3844535 , @owenpan wrote: > In D129443#3842427 , > @HazardyKnusperkeks wrote: > >> We can //fix// that regression,

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

HazardyKnusperkeks added a comment. The clang-format tests are (mainly) in `clang/unittests/Format/FormatTest.cpp`, please put it there. You should have a Format-Tests (or similar) build target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 466271. Izaron added a comment. Removed redundant comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 Files:

[clang] 0c4f0bf - [C++20] [Modules] Only allow redeclarations in partitions if they are in the same module

Author: Chuanqi Xu Date: 2022-10-08T17:44:04+08:00 New Revision: 0c4f0bf40d17d516aff54f6cea79b69101085799 URL: https://github.com/llvm/llvm-project/commit/0c4f0bf40d17d516aff54f6cea79b69101085799 DIFF: https://github.com/llvm/llvm-project/commit/0c4f0bf40d17d516aff54f6cea79b69101085799.diff

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

BertalanD added a comment. Hi @erichkeane, This change broke compilation of this program (https://godbolt.org/z/KrWGvcf8h; reduced from https://github.com/SerenityOS/ladybird): template constexpr bool IsSame = false; template constexpr bool IsSame = true; template struct Foo

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 466269. isuckatcs marked an inline comment as done. isuckatcs added a comment. Addressed inline comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files:

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, just one small nit. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/redundant-expression-cxx20.cpp:3 + +// Note: this test expects no diagnostics, but

[clang] 9974ed8 - [C++20] [Modules] Remove assertion of current module when acting on import

Author: Chuanqi Xu Date: 2022-10-08T16:44:51+08:00 New Revision: 9974ed804995d2e34be69404e9904c7e03cfbda4 URL: https://github.com/llvm/llvm-project/commit/9974ed804995d2e34be69404e9904c7e03cfbda4 DIFF: https://github.com/llvm/llvm-project/commit/9974ed804995d2e34be69404e9904c7e03cfbda4.diff

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:963 nextToken(/*LevelDifference=*/-AddLevels); HandleVerilogBlockLabel(); lahwaacz wrote: > owenpan wrote: > > The `while` loop would address > >

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:446 + if (Optional T = classify(LitType)) { +APInt Val(getIntWidth(LitType), E->getValue()); +return this->emitConst(*T, 0, Val, E); aaron.ballman wrote: > Should this

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder updated this revision to Diff 466262. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135366/new/ https://reviews.llvm.org/D135366 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/arrays.cpp Index:

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

tbaeder updated this revision to Diff 466259. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135433/new/ https://reviews.llvm.org/D135433 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h clang/test/AST/Interp/loops.cpp Index:

[clang] 3b276a0 - [ARM64EC][clang-cl] Add arm64EC test; NFC

Author: chenglin.bi Date: 2022-10-08T14:47:50+08:00 New Revision: 3b276a0decea1adcb822d5110f25f7256a6ade6c URL: https://github.com/llvm/llvm-project/commit/3b276a0decea1adcb822d5110f25f7256a6ade6c DIFF: https://github.com/llvm/llvm-project/commit/3b276a0decea1adcb822d5110f25f7256a6ade6c.diff

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

tbaeder added inline comments. Comment at: clang/test/AST/Interp/loops.cpp:93 + } + static_assert(f4() == 5, ""); +}; aaron.ballman wrote: > Can you also add some tests that use nested loops with multiple levels of > `break` and `continue` use? > > Also, I

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

lahwaacz added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:963 nextToken(/*LevelDifference=*/-AddLevels); HandleVerilogBlockLabel(); owenpan wrote: > The `while` loop would address >