[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

nridge added a comment. The test added in the previous patch, `CompletionTest.Enums`, needs to be updated to reflect this change (`Scoped::Clangd3` now appears as a completion). Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2136 + if (llvm::isa(ND.getDeclContext()))

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

kadircet added a comment. Hi @Abpostelnicu, as @nridge pointed out. we're actively working on the library pieces of include-cleaner and applications of the library aren't the focus yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/

[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17939 Alignment); + // Ensure operators are not aligned if they're being called, not declared + verifyFormat("int main() {\n" Add a full stop.

[PATCH] D136957: [AArch64] Add support for the Cortex-A715 CPU

simpal01 updated this revision to Diff 472560. simpal01 marked 2 inline comments as done. simpal01 added a comment. Comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136957/new/ https://reviews.llvm.org/D136957 Files:

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test is just a copy of

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder updated this revision to Diff 472564. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/class-layout.cpp Index: clang/test/AST/Interp/class-layout.cpp

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think this is pretty uncommon so I was trying to

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder updated this revision to Diff 472526. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td clang/test/AST/Interp/arrays.cpp

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! I don't think we need this much detail in the commit message; I think after the first line it would be sufficient to say: Fixes https://github.com/clangd/clangd/issues/1082 See

[clang] c49db59 - [CLANG] XFAIL c-strings.c & volatile-1.c AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-11-02T12:32:21+04:00 New Revision: c49db597a131576160ab8d1e19575853afbc7077 URL: https://github.com/llvm/llvm-project/commit/c49db597a131576160ab8d1e19575853afbc7077 DIFF:

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder updated this revision to Diff 472562. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/class-layout.cpp Index: clang/test/AST/Interp/class-layout.cpp

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

This revision was automatically updated to reflect the committed changes. Closed by commit rG23c665371a98: [compiler-rt] Switch from llvm-config to find_package(LLVM) (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Thanks! Let's hope it works this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list

[PATCH] D136957: [AArch64] Add support for the Cortex-A715 CPU

vhscampos added inline comments. Comment at: clang/docs/ReleaseNotes.rst:699 + + * Arm cortex-A715 (cortex-a715). Please capitalise the first cortex-A715. It should be "Arm Cortex-A715". Comment at: llvm/docs/ReleaseNotes.rst:84 +* Added

[PATCH] D137239: [AArch64] Install arm_neon_sve_bridge.h

peterwaller-arm created this revision. peterwaller-arm added reviewers: MattDevereau, benmxwl-arm, c-rhodes. Herald added subscribers: ctetreau, kristof.beyls, tschuett. Herald added a project: All. peterwaller-arm requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

MaskRay updated this revision to Diff 472533. MaskRay retitled this revision from "[asan] Default to -fsanitize-address-use-odr-indicator" to "[asan] Default to -fsanitize-address-use-odr-indicator for non-Windows". MaskRay edited the summary of this revision. MaskRay added a comment. Herald

[PATCH] D137235: [clang][Interp] Fix ImplicitValueInitExprs for pointer types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This previously ran into an "unknown type"

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder updated this revision to Diff 472563. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/class-layout.cpp Index: clang/test/AST/Interp/class-layout.cpp

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:162 +// Init captures are always VarDecl. +auto *D = cast(LC.getCapturedVar()); +Invalid |= Visit(D->getInit()); Can you add a test case showing what happens with

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

Pierre-vh created this revision. Pierre-vh added reviewers: yaxunl, tra, aaron.ballman, rsmith. Herald added a subscriber: mattd. Herald added a project: All. Pierre-vh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D124866

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472567. vhscampos added a comment. Added AEK_FLAM to the list of features for Cortex-X3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files:

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM if there are not other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa68bcd81dcc9: [clangd] Index unscoped enums in class scope for code completion (authored by tom-anders). Repository: rG LLVM Github Monorepo

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

tom-anders updated this revision to Diff 472578. tom-anders marked an inline comment as done. tom-anders added a comment. Actually fix test... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137104/new/ https://reviews.llvm.org/D137104 Files:

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added a comment. (No changelog, this fixes an unreleased feature) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 ___ cfe-commits mailing list

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new method is a wrapper of

[PATCH] D137252: [include-cleaner] Testing helpers for ast walking

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a subscriber: mgrang. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Address comments around

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:162 +// Init captures are always VarDecl. +auto *D = cast(LC.getCapturedVar()); +Invalid |= Visit(D->getInit()); aaron.ballman wrote: > Can you add a test case showing

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 472581. cor3ntin added a comment. Forgot to clang-format! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/include/clang/AST/Decl.h

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472583. vhscampos added a comment. Added SSBS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/docs/ReleaseNotes.rst

[clang-tools-extra] a68bcd8 - [clangd] Index unscoped enums in class scope for code completion

Author: Tom Praschan Date: 2022-11-02T12:50:50+01:00 New Revision: a68bcd81dcc90fc7d6fbe4013569774a19097c4a URL: https://github.com/llvm/llvm-project/commit/a68bcd81dcc90fc7d6fbe4013569774a19097c4a DIFF: https://github.com/llvm/llvm-project/commit/a68bcd81dcc90fc7d6fbe4013569774a19097c4a.diff

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

tom-anders updated this revision to Diff 472568. tom-anders added a comment. Update `CompletionTest.Enums`, keep scope condition in isIndexedForCodeCompletion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137104/new/

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos marked an inline comment as done. vhscampos added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``.

[PATCH] D137209: [OPENMP]Initial support for error directive.

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:6229 +/// \endcode +class OMPErrorDirective : public OMPExecutableDirective { + friend class ASTStmtReader; final Comment at:

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

cor3ntin updated this revision to Diff 472601. cor3ntin added a comment. Properly handle structured bindings in init capture Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137172/new/ https://reviews.llvm.org/D137172 Files:

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

tom-anders added a comment. In D136925#3901509 , @nridge wrote: > Thanks! > > I don't think we need this much detail in the commit message; I think after > the first line it would be sufficient to say: > > Fixes

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

tom-anders marked an inline comment as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2136 + if (llvm::isa(ND.getDeclContext())) +return true; nridge wrote: > Why remove the `(InTopLevelScope(*EnumDecl) ||

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. vhscampos wrote: > tschuett wrote: > >

[PATCH] D137180: [LinkerWrapper] report on missing libraries

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278 + if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive) +continue; + jdoerfert wrote: > jhuber6 wrote: > > jdoerfert wrote: > >

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Structured bindings were not properly marked odr-used and therefore captured

[clang] d7d7436 - Reenable POSIX builtin library functions in gnu2x mode

Author: Aaron Ballman Date: 2022-11-02T08:00:25-04:00 New Revision: d7d743621a0d5d13ed54d358944857ccba598299 URL: https://github.com/llvm/llvm-project/commit/d7d743621a0d5d13ed54d358944857ccba598299 DIFF: https://github.com/llvm/llvm-project/commit/d7d743621a0d5d13ed54d358944857ccba598299.diff

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:107-111 +if (const auto *BD = dyn_cast(Decl)) + VD = dyn_cast_if_present(BD->getDecomposedDecl()); +else + VD = dyn_cast(Decl); +if (VD) { Note that

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

jsjodin added a comment. @jdoerfert do you have any other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136872/new/ https://reviews.llvm.org/D136872 ___ cfe-commits mailing list

[PATCH] D137259: [clang][modules][deps] WIP: In-memory module transfer

jansvoboda11 created this revision. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Let's not create PCM files in the dependency scanner. Repository: rG

[PATCH] D137209: [OPENMP]Initial support for error directive.

jyu2 updated this revision to Diff 472640. jyu2 added a comment. Thanks Alexey for the review. This is to address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137209/new/ https://reviews.llvm.org/D137209 Files:

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou updated this revision to Diff 472642. zhouyizhou added a comment. We should also consider the situation of erasing the size - 1th element CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263 Files:

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

cor3ntin added a comment. I think this is basically good to go, but I'll let other people give it a look too Comment at: clang/lib/AST/ExprConstant.cpp:9987-9990 +} else { + llvm_unreachable( + "Expression is neither an init list nor a C++ paren list"); +

[PATCH] D129298: Add denormal-fp-math attribute for f16

dcandler abandoned this revision. dcandler added a comment. Sorry for the quiet on this. I'm going to abandon this for the moment, as what I eventually found was that there was some ambiguity in the ARM ABI regarding half-floats which would be better to address first, so that the attributes can

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

paquette added a comment. maybe link back to the discourse thread in the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https://reviews.llvm.org/D137269 ___ cfe-commits

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

yaxunl added a comment. need a CodeGenCUDA test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137251/new/ https://reviews.llvm.org/D137251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Szelethus. Herald added subscribers: steakhal, manas, ASDenysPetrov, ributzka, dkrupp, donat.nagy, a.sidorin, mgrang, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. jansvoboda11 requested review of

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou created this revision. zhouyizhou added reviewers: chandlerc, aprantl, rsmith, rjmccall. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compile following code with clang (Debug

[PATCH] D137266: [RISCV] Move RVVBitsPerBlock to TargetParser.h so we can use it in clang. NFC

craig.topper created this revision. craig.topper added reviewers: reames, frasercrmck, rogfer01, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google abandoned this revision. luken-google added a comment. Abandoned in favor of Erich's patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 ___

[PATCH] D137267: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

zatrazz created this revision. zatrazz added reviewers: jfb, eli.friedman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. zatrazz requested review of this revision. Herald added a project: clang. It was reported by glibc conform test [1]. [1]

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz created this revision. zatrazz added reviewers: jfb, eli.friedman, MaskRay. Herald added subscribers: Enna1, StephenFan. Herald added a project: All. zatrazz requested review of this revision. Herald added projects: clang, Sanitizers. Herald added a subscriber: Sanitizers. The glibc uses

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#3902698 , @stella.stamenova wrote: > This caused some failures on the windows mlir buildbot: > https://lab.llvm.org/buildbot/#/builders/13/builds/27829 Thanks for the heads-up. Who would be the best person to

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7218-7219 + CmdArgs.push_back("-global-isel=1"); + CmdArgs.push_back("-mllvm"); + CmdArgs.push_back("-global-isel-abort=0"); +} Why abort=0? I can understand

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3902789 , @thakis wrote: > I noticed that when using `-fcrash-diagnostics=all` and the linker crashes, > clang creates both preprocessor and linker repros: > > clang: note: diagnostic msg: >

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

tra added a comment. LGTM in principle. Please wait for @rsmith's OK. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1297-1308 +while (true) { + if (Tok.is(tok::kw___attribute)) { +ParseGNUAttributes(Attr, nullptr, ); + } else if

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

cor3ntin updated this revision to Diff 472637. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137172/new/ https://reviews.llvm.org/D137172 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ben.boeckel added a comment. I tried applying this patch to your MyP1689 branch (fixing conflicts with attempts there), but it seems that something isn't being plumbed properly: clang-15: error: unknown argument:

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

This revision was automatically updated to reflect the committed changes. Closed by commit rG12d8e7c6ade5: [cmake][msvc] Enable standards-conforming preprocessor (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D135128?vs=465112=472651#toc Repository: rG LLVM

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson updated this revision to Diff 472660. royjacobson marked 4 inline comments as done. royjacobson added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404 Files:

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson added a comment. In D135404#3899904 , @njames93 wrote: > I'd also suggest using the `IgnoreUnlessSpelledInSource` traversal kind here. > Given that most of the time these will be instantiated we don't want to warn > and emit a fix for each

[PATCH] D136022: [clang] Add time profile for constant evaluation

Trass3r added a comment. Thanks for this! When I experimented with this for #42754 I also came across functions like Expr::isConstantInitializer

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

kstoimenov accepted this revision. kstoimenov added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Instrumentation/AddressSanitizer/global_with_comdat.ll:8 ; -; RUN: opt < %s -passes=asan -asan-globals-live-support=1 -S |

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Looks good, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137104/new/ https://reviews.llvm.org/D137104

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. Thanks, that sounds good. Reverting shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 ___ cfe-commits mailing list

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

thakis added a comment. > I didn't really make a conscious decision one way or the other. I guess > reproing all jobs leading to a crash somewhat makes sense, though it also > doesn't seem that helpful to get the preprocessed source file. I'll send out > a patch to fix this Great, thanks :)

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. It looks like precommit CI caught a relevant issue that should be addressed. Also, there's an in-progress patch that might be worth keeping an eye on in case it changes the behavior for clang-repl in bad ways: https://reviews.llvm.org/D137020 -- the patch causes

[PATCH] D137209: [OPENMP]Initial support for error directive.

jyu2 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:6229 +/// \endcode +class OMPErrorDirective : public OMPExecutableDirective { + friend class ASTStmtReader; ABataev wrote: > final Sorry, forget that. Changed.

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. Following is the back trace when the assertion fires before my fix: #6 0x77960e96 in __GI___assert_fail (assertion=0x656ed285 "Begin + idx < End", file=0x656ed240 "/tmp/llvm-test/llvm-project.save/clang/include/clang/AST/ASTVector.h", line=112,

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. This caused some failures on the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/27829 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128

[clang] c10a847 - [Assignment Tracking][2/*] Add flags to enable Assignment Tracking

Author: OCHyams Date: 2022-11-02T17:06:43Z New Revision: c10a8473f48bca32ef5e8ab78d30e3557e66d431 URL: https://github.com/llvm/llvm-project/commit/c10a8473f48bca32ef5e8ab78d30e3557e66d431 DIFF: https://github.com/llvm/llvm-project/commit/c10a8473f48bca32ef5e8ab78d30e3557e66d431.diff LOG:

[PATCH] D132221: [Assignment Tracking][2/*] Add flags to enable Assignment Tracking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Orlando marked an inline comment as done. Closed by commit rGc10a8473f48b: [Assignment Tracking][2/*] Add flags to enable Assignment Tracking (authored by Orlando).

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

aemerson created this revision. aemerson added reviewers: paquette, Gerolf, ab, t.p.northover, arsenm. aemerson added a project: LLVM. Herald added a subscriber: kristof.beyls. Herald added a project: All. aemerson requested review of this revision. Herald added subscribers: MaskRay, wdng. Herald

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:388 + options::OPT_fno_global_isel); +if (!A || !A->getOption().matches(options::OPT_fno_global_isel)) { CmdArgs.push_back("-mllvm"); Actually

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

thakis added a comment. I noticed that when using `-fcrash-diagnostics=all` and the linker crashes, clang creates both preprocessor and linker repros: clang: note: diagnostic msg: /var/folders/w6/wpbtszrs7jl9dc9l5qtdkvg0gn/T/main-241332.c clang: note: diagnostic msg:

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#3902772 , @jansvoboda11 wrote: > In D135128#3902698 , > @stella.stamenova wrote: > >> This caused some failures on the windows mlir buildbot: >>

[PATCH] D136811: WIP: RFC: NFC: C++ Buffer Hardening user documentation.

aaron.ballman added a comment. Thank you for getting a start on this documentation, this adds a lot of clarity to what was being proposed! I have some questions, and some minor things to fix. Comment at: clang/docs/SafeBuffers.rst:19 +guidelines, and it provides runtime

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe marked 10 inline comments as done. Febbe added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-copy-on-last-use.rst:6 + +Finds variables of non-trivially-copyable types, that are used in a copy construction on their last

[PATCH] D137209: [OPENMP]Initial support for error directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137209/new/ https://reviews.llvm.org/D137209

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

tschuett added a comment. A release note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https://reviews.llvm.org/D137269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3903161 , @owenpan wrote: > Can you fix the format of the summary? I see the misindentation of the After/Before hash examples. Will fix those for V2. Anything else? Repository: rG LLVM Github Monorepo

[PATCH] D137280: [RISCV] Prevent autovectorization using vscale with Zvl32b.

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM I'm fine with this, but I thought we didn't support zve32f during compilation at all right now? Is this the only issue which needs fixed. Repository: rG LLVM Github Monorepo

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as not done. v.g.vassilev added a comment. In D127284#3902487 , @aaron.ballman wrote: > It looks like precommit CI caught a relevant issue that should be addressed. Yes, I have a comment (starting with "The only

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ https://reviews.llvm.org/D137275

[PATCH] D137280: [RISCV] Prevent autovectorization using vscale with Zvl32b.

craig.topper added a comment. In D137280#3903292 , @reames wrote: > LGTM > > I'm fine with this, but I thought we didn't support zve32f during compilation > at all right now? Is this the only issue which needs fixed. I think zve32f works fine with

[PATCH] D137180: [LinkerWrapper] report on missing libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9ee2acc9c5c: [LinkerWrapper] report on missing libraries (authored by jhuber6). Changed prior to commit:

[clang] b9ee2ac - [LinkerWrapper] report on missing libraries

Author: Joseph Huber Date: 2022-11-02T15:28:09-05:00 New Revision: b9ee2acc9c5c129bce5503dd8d2ab4757e42c990 URL: https://github.com/llvm/llvm-project/commit/b9ee2acc9c5c129bce5503dd8d2ab4757e42c990 DIFF: https://github.com/llvm/llvm-project/commit/b9ee2acc9c5c129bce5503dd8d2ab4757e42c990.diff

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-copy-on-last-use.rst:6 + +Finds variables of non-trivially-copyable types, that are used in a copy construction on their last usage and suggest to wrap the usage

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 472698. Febbe added a comment. Applied feedback, Also added the documentation for the second option ``BlockedFunctions`` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

aaron.ballman added a comment. Can you also add a release note for the fix? Comment at: clang/lib/Parse/ParseExprCXX.cpp:1300 +ParseGNUAttributes(Attr, nullptr, ); + } else if (Tok.is(tok::kw___noinline__)) { +IdentifierInfo *AttrName =

[PATCH] D137266: [RISCV] Move RVVBitsPerBlock to TargetParser.h so we can use it in clang. NFC

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137266/new/ https://reviews.llvm.org/D137266

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

rsmith added a comment. In D137251#3902835 , @tra wrote: > LGTM in principle. Please wait for @rsmith's OK. I'm happy to defer to @aaron.ballman on this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137082: [clang][Interp] Fix dereferencing arrays with no offset applied

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:966-967 return false; - S.Stk.push(Ptr.deref()); + // When getting the first value of an array, we need to offset to the + // first element. + if (Ptr.inArray() && Ptr.isRoot())

  1   2   >