[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

2022-11-15 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:100 + /// Contains all non self-contained files during the parsing. + llvm::DenseSet NonSelfContainedFiles; s/during/detected during/

[PATCH] D138031: Add clang-tidy check for missing move constructors

2022-11-15 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/missing-move-constructor.rst:6 + +Warns when a class has a copy constructor but not move constructor. + Please synchronize this sentence with Release Notes.

[PATCH] D137851: [OPENMP]Initial support for at clause

2022-11-15 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 475490. jyu2 added a comment. Thanks Alexey for the review. This is address his comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

2022-11-15 Thread Ties Stuij via Phabricator via cfe-commits
stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM))

[PATCH] D137851: [OPENMP]Initial support for at clause

2022-11-15 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2168 +Actions.ActOnOpenMPErrorDirective(Clauses, StartLoc, SourceLocation(), + /*InExcontext = */ false); +break; ABataev wrote: > InExContext

[PATCH] D137992: [asan] -fsanitize-address-outline-instrumentation -> -asan-max-inline-poisoning-size=0

2022-11-15 Thread Roy Sundahl via Phabricator via cfe-commits
rsundahl updated this revision to Diff 475497. rsundahl added a comment. Removed extraneous blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137992/new/ https://reviews.llvm.org/D137992 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

2022-11-15 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. @vitalybuka @rjmccall thank you for taking a look! Since posting this, there has been a conversation in `#llvm` with @jyknight, where it was established that the situation is even worse than i though. Essentially, there are two situations: 1. exception escape out of

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

2022-11-15 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Mostly looks good. Is this expected to work with Clang modules at all? Comment at: clang/include/clang/Driver/Driver.h:240 + unsigned CCPrintHeadersJson : 1; + Please document this. Comment at:

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

2022-11-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if (!AtTopLevel && isa(JA) &&

[PATCH] D138031: Add clang-tidy check for missing move constructors

2022-11-15 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. What is the purpose of this check when we have cppcoreguidelines-special-member-functions . Granted that check won't emit replacements, however the replacements that this

[PATCH] D136354: [Driver] Enable nested configuration files

2022-11-15 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. > To solve such problems, the option --config is allowed inside ... `--config=` Comment at: clang/docs/UsersManual.rst:989 +``linux.opts`` is searched for in the directory ``~/.llvm/os``. Another way to +include a file

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParser

2022-11-15 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. I'm going to move this into the newly created `ARMTargetParserCommon` files which @tmatheson created in https://reviews.llvm.org/D137924 (which has landed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137835/new/

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

2022-11-15 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. IncludeFixer uses this BuildDir

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

2022-11-15 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd updated this revision to Diff 475530. compnerd added a comment. Add unsupported test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

2022-11-15 Thread Tom Praschan via Phabricator via cfe-commits
tom-anders added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:212 // Produce replacements to add the qualifiers. std::string Qualifier = printUsingNamespaceName(Ctx, *TargetDirective) + "::"; for (auto Loc :

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

2022-11-15 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx added a comment. Herald added a reviewer: njames93. @mizvekov , I'm willing/trying to assist in addressing the buildbot failures that caused you to revert this change. We are eager to see this fix land stably upstream as the crash it addresses is breaking a number of our

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Stella Laurenzo via Phabricator via cfe-commits
stellaraccident accepted this revision. stellaraccident added a comment. Thanks for this. Patch lgtm. Has a couple of format issues but probably ok as-is (this file is very inconsistently formatted and it looks like you overrode clang-format a bit for consistency with adjacent code).

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Reed Wanderman-Milne via Phabricator via cfe-commits
reedwm added a comment. In D137760#3928314 , @stellaraccident wrote: > Thanks for this. Patch lgtm. Has a couple of format issues but probably ok > as-is (this file is very inconsistently formatted and it looks like you > overrode clang-format a bit

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

2022-11-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 475544. ymandel marked 7 inline comments as done. ymandel added a comment. reshape widen to update in place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files:

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

2022-11-15 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:29 + /// Invoked when an unsafe operation over raw pointers is found. + virtual void handleUnsafeOperation(const Stmt *Operation) = 0; +}; What is the

[PATCH] D136176: Implement support for option 'fexcess-precision'.

2022-11-15 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. Can you update the clang user's manual to describe the behavior of this option? The excess precision issue is also mentioned in the clang language extensions document (https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point).

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Can we add a `Note` diagnostic when we emit a `-Wframe-larger-than=` that alludes to re-running with `-mllvm -print-stack-frame` to get additional info? We should update the release notes of clang to mention this feature, too. Repository: rG LLVM Github

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D135488#3928557 , @nickdesaulniers wrote: > Can we add a `Note` diagnostic when we emit a `-Wframe-larger-than=` that > alludes to re-running with `-mllvm -print-stack-frame` to get additional info? > > We should update the

[PATCH] D137826: [clang] Allow comparing pointers to string literals

2022-11-15 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12951-12954 + // ObjC's @encode() + if (isa(E->getLHS()->IgnoreParenImpCasts()) || + isa(E->getRHS()->IgnoreParenImpCasts())) return Error(E); A comment to

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

2022-11-15 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137823/new/ https://reviews.llvm.org/D137823 ___ cfe-commits mailing list

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

2022-11-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 475478. ymandel marked 2 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files:

[PATCH] D137851: [OPENMP]Initial support for at clause

2022-11-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 ___ cfe-commits mailing list

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-11-15 Thread Amir Ayupov via Phabricator via cfe-commits
Amir marked an inline comment as done. Amir added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:10 +# Optional arguments to pass to the build tool +macro(clang_Bootstrap_Add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP"

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

2022-11-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added inline comments. Comment at: clang/unittests/Tooling/SourceCodeTest.cpp:249-258 Visitor.runOverAnnotated(R"cpp( - #define ATTR __attribute__((deprecated("message"))) - $r[[ATTR + $r[[__attribute__((deprecated("message"))) int x;]])cpp");

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

2022-11-15 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added a comment. @rjmccall, could you please take a look at the updated changes? I think I've addressed the issues you raised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137760/new/ https://reviews.llvm.org/D137760

[PATCH] D137897: Extend the number of case Sema::CheckForIntOverflow covers

2022-11-15 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik updated this revision to Diff 475528. shafik added a comment. Add Release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137897/new/ https://reviews.llvm.org/D137897 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp

[PATCH] D137992: [asan] -fsanitize-address-outline-instrumentation -> -asan-max-inline-poisoning-size=0

2022-11-15 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a subscriber: kstoimenov. vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:1256 if (AsanOutlineInstrumentation) { CmdArgs.push_back("-mllvm"); CC @kstoimenov it's maybe not the best name for flag, but

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

2022-11-15 Thread Jan Korous via Phabricator via cfe-commits
jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. @aaron.ballman Do you have any objection to us landing this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137346/new/

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

2022-11-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 475548. ymandel marked an inline comment as done. ymandel added a comment. tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files:

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

2022-11-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:114 bool isEqualTypeErased(const TypeErasedLattice , const TypeErasedLattice ) final { const

[PATCH] D137897: Extend the number of case Sema::CheckForIntOverflow covers

2022-11-15 Thread Shafik Yaghmour via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9332ddfba69c: [Clang] Extend the number of case Sema::CheckForIntOverflow covers (authored by shafik). Herald added a project: clang. Changed prior to commit:

[clang] 9332ddf - [Clang] Extend the number of case Sema::CheckForIntOverflow covers

2022-11-15 Thread Shafik Yaghmour via cfe-commits
Author: Shafik Yaghmour Date: 2022-11-15T12:07:03-08:00 New Revision: 9332ddfba69c38f9ceef4175b042fba0bb8e67bb URL: https://github.com/llvm/llvm-project/commit/9332ddfba69c38f9ceef4175b042fba0bb8e67bb DIFF:

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

2022-11-15 Thread Ben Boeckel via Phabricator via cfe-commits
ben.boeckel added a comment. I'm not too concerned with the spelling of the flag myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 ___ cfe-commits

Re: How can Autoconf help with the transition to stricter compilation defaults?

2022-11-15 Thread Aaron Ballman via cfe-commits
On Tue, Nov 15, 2022 at 2:08 PM Paul Eggert wrote: > > On 2022-11-15 06:50, Jonathan Wakely wrote: > > Could you clarify what you mean, with a concrete example? Surely as > > long as errors are reported on stderr and the compiler exits with > > non-zero status, that's an acceptable way to report

[PATCH] D137488: [clang][Interp] Array initialization via string literal

2022-11-15 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->getLength(); +for (size_t I = 0; I != NumElems; ++I) { + uint32_t CodePoint = I < N ? SL->getCodeUnit(I) : 0; Aren't `N` and

[PATCH] D138058: [Sema] Use the value category of the base expression when creating an ExtVectorElementExpr

2022-11-15 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a bug where an lvalue `ExtVectorElementExpr` was created when the base expression was an ObjC property dot

[clang] ea5be25 - [AVR] Fix use-of-uninitialized-value after D137520

2022-11-15 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-11-15T11:06:18-08:00 New Revision: ea5be2571dc95edb8ee04d966addd6b58bfe7b85 URL: https://github.com/llvm/llvm-project/commit/ea5be2571dc95edb8ee04d966addd6b58bfe7b85 DIFF: https://github.com/llvm/llvm-project/commit/ea5be2571dc95edb8ee04d966addd6b58bfe7b85.diff

[PATCH] D137989: [clang][deps] Avoid leaking modulemap paths across unrelated imports

2022-11-15 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir updated this revision to Diff 475534. benlangmuir added a comment. - Removed outdated FIXME - Ran clang-format - Attempt to fix Windows test failure: the `StringSet` of paths was failing to match, so switch to `DenseSet`. Note: the path that ends up in the command-line is from a

[clang] 88eb3c6 - Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Benjamin Kramer via cfe-commits
Author: Reed Date: 2022-11-15T20:26:42+01:00 New Revision: 88eb3c62f25d820a80bc73af786002e1fc4a URL: https://github.com/llvm/llvm-project/commit/88eb3c62f25d820a80bc73af786002e1fc4a DIFF: https://github.com/llvm/llvm-project/commit/88eb3c62f25d820a80bc73af786002e1fc4a.diff LOG:

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

2022-11-15 Thread Benjamin Kramer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88eb3c62f25d: Add FP8 E4M3 support to APFloat. (authored by reedwm, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

2022-11-15 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 475538. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

Re: How can Autoconf help with the transition to stricter compilation defaults?

2022-11-15 Thread Jonathan Wakely via cfe-commits
On Tue, 15 Nov 2022 at 19:08, Paul Eggert wrote: > > On 2022-11-15 06:50, Jonathan Wakely wrote: > > Could you clarify what you mean, with a concrete example? Surely as > > long as errors are reported on stderr and the compiler exits with > > non-zero status, that's an acceptable way to report

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

2022-11-15 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:114 bool isEqualTypeErased(const TypeErasedLattice ,

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D135488#3928559 , @arsenm wrote: > In D135488#3928557 , > @nickdesaulniers wrote: > >> Can we add a `Note` diagnostic when we emit a `-Wframe-larger-than=` that >> alludes to

Re: How can Autoconf help with the transition to stricter compilation defaults?

2022-11-15 Thread Aaron Ballman via cfe-commits
On Tue, Nov 15, 2022 at 3:27 PM Paul Eggert wrote: > > On 2022-11-15 11:27, Jonathan Wakely wrote: > > Another perspective is that autoconf shouldn't get in the way of > > making the C and C++ toolchain more secure by default. > > Can you cite any examples of a real-world security flaw what would

Re: How can Autoconf help with the transition to stricter compilation defaults?

2022-11-15 Thread Paul Eggert via cfe-commits
On 2022-11-15 06:50, Jonathan Wakely wrote: Could you clarify what you mean, with a concrete example? Surely as long as errors are reported on stderr and the compiler exits with non-zero status, that's an acceptable way to report errors? Not if the "error" is harmless as far as Autoconf is

Re: How can Autoconf help with the transition to stricter compilation defaults?

2022-11-15 Thread Paul Eggert via cfe-commits
On 2022-11-15 11:27, Jonathan Wakely wrote: Another perspective is that autoconf shouldn't get in the way of making the C and C++ toolchain more secure by default. Can you cite any examples of a real-world security flaw what would be found by Clang erroring out because 'char foo(void);' is

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D135488#3928567 , @nickdesaulniers wrote: > In D135488#3928559 , @arsenm wrote: > >> In D135488#3928557 , >> @nickdesaulniers wrote:

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D135488#3928567 , @nickdesaulniers wrote: > In D135488#3928559 , @arsenm wrote: > >> In D135488#3928557 , >> @nickdesaulniers wrote: >> >>>

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

2022-11-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD added a comment. @mikerice @jyu2 May you accept the revision please if this patch looks good to you? Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

2022-11-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 475563. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570 Files: clang/lib/Sema/SemaStmtAttr.cpp Index:

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

2022-11-15 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea added a comment. IIUC compile time impact for adding another SROA (the one outside LTO) is negligible? Regarding the principle of adding another pass and where in the pipeline, we're still at a case by case basis. We had a discussion/round table at LLVM Dev on the documenting the

[clang] 05ec16d - [clang][deps] Avoid leaking modulemap paths across unrelated imports

2022-11-15 Thread Ben Langmuir via cfe-commits
Author: Ben Langmuir Date: 2022-11-15T13:59:26-08:00 New Revision: 05ec16d90deb747414c8534f98617d25d90bb714 URL: https://github.com/llvm/llvm-project/commit/05ec16d90deb747414c8534f98617d25d90bb714 DIFF: https://github.com/llvm/llvm-project/commit/05ec16d90deb747414c8534f98617d25d90bb714.diff

[PATCH] D137989: [clang][deps] Avoid leaking modulemap paths across unrelated imports

2022-11-15 Thread Ben Langmuir via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG05ec16d90deb: [clang][deps] Avoid leaking modulemap paths across unrelated imports (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

2022-11-15 Thread Louis Dionne via Phabricator via cfe-commits
ldionne created this revision. ldionne added reviewers: MaskRay, phosek, arphaman. Herald added subscribers: pmatos, asb, abrachet, StephenFan, jgravelle-google, sbc100, dschuff. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

2022-11-15 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D136806#3928663 , @asbirlea wrote: > IIUC compile time impact for adding another SROA (the one outside LTO) is > negligible? Yup. > Regarding the principle of adding another pass and where in the pipeline, > we're still

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth added a comment. Thanks for the feedback! I have a few questions I'm hoping you can answer. In D135488#3928559 , @arsenm wrote: > I don't think we should be pointing users to -mllvm flags. Plus, I don't > really think random dbgs() printing

[clang] dcfb250 - [clang][deps] Remove checks that were just for exhaustiveness

2022-11-15 Thread Ben Langmuir via cfe-commits
Author: Ben Langmuir Date: 2022-11-15T14:22:23-08:00 New Revision: dcfb25078c2629450b393e696b9760721a9f URL: https://github.com/llvm/llvm-project/commit/dcfb25078c2629450b393e696b9760721a9f DIFF: https://github.com/llvm/llvm-project/commit/dcfb25078c2629450b393e696b9760721a9f.diff

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

2022-11-15 Thread Haowei Wu via Phabricator via cfe-commits
haowei updated this revision to Diff 475591. haowei added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth added a comment. In D135488#3928831 , @dblaikie wrote: > Any chance we could squirrel the info away (I assume there's a reason we > can't compute the info where the warn-stack-size LLVM feature is implemented > in PrologEpilogInserter.cpp)

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth updated this revision to Diff 475602. paulkirth added a comment. Rebase and address comments - Replace magic comparison with `MFI.isDeadIbjectIndex()` - Small code improvement by using a constructor w/ `emplace_back` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137259: [clang][modules][deps] WIP: In-memory module transfer

2022-11-15 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 475613. jansvoboda11 added a comment. Fixed two tests: - modules-pch.c by always marking identifier info as not out-of-date when getting leaf module macros, - modules-module-map-order.m by updating the sorting logic for gathering `SortedFiles`.

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

2022-11-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:29 + /// Invoked when an unsafe operation over raw pointers is found. + virtual void handleUnsafeOperation(const Stmt *Operation) = 0; +}; xazax.hun wrote: > What

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

2022-11-15 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:112 + // double' mode. + static SmallDenseMap AIXLongDoubleBuiltins{ + {Builtin::BI__builtin_frexpl, "frexp"}, Please rename to "AIXLongDouble64Builtins".

[PATCH] D134921: [HLSL] add cos library function

2022-11-15 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 475633. bob80905 added a comment. - remove int overloads - remove double - update tests after new builtin landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

2022-11-15 Thread v1nh1shungry via Phabricator via cfe-commits
v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:212 // Produce replacements to add the qualifiers. std::string Qualifier = printUsingNamespaceName(Ctx, *TargetDirective) + "::"; for (auto Loc :

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

2022-11-15 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. Thanks for the feedback. Another significant portion of getting this workflow to work for Windows / COFF is parsing the linker arguments. I should be able to look at `lld-link` and add necessarily aliases to what `ld.lld` takes I assume? E.g. we use values like `-o`

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

2022-11-15 Thread Haowei Wu via Phabricator via cfe-commits
haowei marked 2 inline comments as done. haowei added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:1010 + std::error_code makeAbsolute(StringRef WorkingDir, + SmallVectorImpl ) const; bnbarham wrote:

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

2022-11-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

2022-11-15 Thread Florian Hahn via Phabricator via cfe-commits
fhahn commandeered this revision. fhahn added a reviewer: CJ-Johnson. fhahn added a comment. Commandeering after the recent updates to make review + follow-ups easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth added a comment. In D135488#3928975 , @dblaikie wrote: > Fair enough - could the warn-stack-size warning be moved to there, then, and > then the information included in the warning? It could have both a warning > and remark form, so folks

[PATCH] D138058: [Sema] Use the value category of the base expression when creating an ExtVectorElementExpr

2022-11-15 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138058/new/ https://reviews.llvm.org/D138058

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

2022-11-15 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd updated this revision to Diff 475570. compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

2022-11-15 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. This looks reasonable to me, overall. I didn't quite try to follow all the wall-of-text changes in the tests though, but overall fine. Just a couple comments and one case where I didn't find where code went in the refactoring. Comment at:

[PATCH] D137851: [OPENMP]Initial support for at clause

2022-11-15 Thread Jennifer Yu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG628fdc3f57ad: [OPENMP]Initial support for at clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/

[clang] 6dee239 - [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

2022-11-15 Thread via cfe-commits
Author: eopXD Date: 2022-11-15T14:37:27-08:00 New Revision: 6dee23919a36a30f3df7e9b20fba8b9edf65340c URL: https://github.com/llvm/llvm-project/commit/6dee23919a36a30f3df7e9b20fba8b9edf65340c DIFF: https://github.com/llvm/llvm-project/commit/6dee23919a36a30f3df7e9b20fba8b9edf65340c.diff LOG:

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

2022-11-15 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D137470#3928731 , @jhuber6 wrote: > Another significant portion of getting this workflow to work for Windows / > COFF is parsing the linker arguments. I should be able to look at `lld-link` > and add necessarily aliases to

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

2022-11-15 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6dee23919a36: [Clang][Sema] Refactor category declaration under… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/

[clang] 063a43b - [ObjC] Fix an assertion failure in EvaluateLValue

2022-11-15 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2022-11-15T14:41:28-08:00 New Revision: 063a43b4fd9f869d57c20145302eb41068bfb54e URL: https://github.com/llvm/llvm-project/commit/063a43b4fd9f869d57c20145302eb41068bfb54e DIFF:

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

2022-11-15 Thread Fabian Keßler via Phabricator via cfe-commits
Febbe updated this revision to Diff 475589. Febbe added a comment. fixed lamda detection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. > as a more general diagnostic output, like the other printing passes. As an aside: I don't think any "printing pass" is designed to be used beyond LLVM compiler engineers - they're implementation details of the compiler, even/much moreso than the optimization remarks

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D135488#3928963 , @paulkirth wrote: > In D135488#3928831 , @dblaikie > wrote: > >> Any chance we could squirrel the info away (I assume there's a reason we >> can't compute the info

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

2022-11-15 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919

[PATCH] D138073: [clang-doc] Move file layout to the generators.

2022-11-15 Thread Brett Wilson via Phabricator via cfe-commits
brettw added a comment. If you're curious, you can see the simplification the YAML output format change makes in the consuming code: https://fuchsia-review.git.corp.google.com/c/fuchsia/+/760570/2/tools/cppdocgen/clangdoc/clangdoc.go Since it allows us to remove some special-casing code for

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

2022-11-15 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added reviewers: void, jyknight, efriedma, craig.topper. Herald added subscribers: StephenFan, jdoerfert, pengfei, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

2022-11-15 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 475635. nickdesaulniers added a comment. - another typo in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138078/new/ https://reviews.llvm.org/D138078 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

2022-11-15 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcb0ffa529a0f: [lldb] Fix simple template names and template params with scope qualifiers (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

2022-11-15 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a reviewer: clang-vendors. ldionne added a comment. I'm not sure who else to add on this review. Since changing the behavior of user-facing flags can be breaking, I'm adding the vendors. Feel free to suggest more. Note that this was discovered when landing D136683

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

2022-11-15 Thread Haowei Wu via Phabricator via cfe-commits
haowei updated this revision to Diff 475574. haowei added a comment. I have to revert back to use process cwd instead of base fs cwd. There are a few tests relied the behavior of using process cwd that I need to take a closer look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 70dc3b8 - [AggressiveInstCombine] Remove legacy PM pass

2022-11-15 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2022-11-15T14:35:15-08:00 New Revision: 70dc3b811e4926fa2c88bd3b53b29c46fcba1a90 URL: https://github.com/llvm/llvm-project/commit/70dc3b811e4926fa2c88bd3b53b29c46fcba1a90 DIFF:

[PATCH] D137116: [AggressiveInstCombine] Remove legacy PM pass

2022-11-15 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70dc3b811e49: [AggressiveInstCombine] Remove legacy PM pass (authored by aeubanks). Changed prior to commit:

[PATCH] D135488: [codegen] Display stack layouts in console

2022-11-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Any chance we could squirrel the info away (I assume there's a reason we can't compute the info where the warn-stack-size LLVM feature is implemented in PrologEpilogInserter.cpp) somewhere, and emit it as part of the frame-larger-than/warn-stack-size diagnostic?

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

2022-11-15 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D137470#3928828 , @mstorsjo wrote: > Sorry, I'm not quite up to speed with exactly what is being done linker-wise > here - can you give a more detailed overview? Keep in mind that there's two > separate interfaces to lld for

[PATCH] D138073: [clang-doc] Move file layout to the generators.

2022-11-15 Thread Brett Wilson via Phabricator via cfe-commits
brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Previously file

  1   2   3   >