[clang] c8ecbaa - [clang] Fix assert message

Author: serge-sans-paille Date: 2022-11-18T10:10:42+01:00 New Revision: c8ecbaa2eba9de4338642bbfb6efd75b286878cb URL: https://github.com/llvm/llvm-project/commit/c8ecbaa2eba9de4338642bbfb6efd75b286878cb DIFF:

[PATCH] D137885: [modules] Support zstd in .pcm file

tschuett added a comment. Release note? Comment at: clang/lib/Serialization/ASTReader.cpp:1457 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Format::Zlib

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

ostannard added inline comments. Comment at: clang/docs/ReleaseNotes.rst:760 +- Strict floating point has been enabled for AArch64, which means that + ``-ftrapping-math``, ``-frounding-math``, ``-ffp-model=strict``, and + ``-ffp-exception-behaviour=`` are now accepted.

[clang-tools-extra] 68294af - [include-cleaner] Fix building with LLVM_LINK_LLVM_DYLIB=ON on mingw

Author: Martin Storsjö Date: 2022-11-18T10:30:26+02:00 New Revision: 68294afa0836bb62be921e2143d147cdfdc8ba70 URL: https://github.com/llvm/llvm-project/commit/68294afa0836bb62be921e2143d147cdfdc8ba70 DIFF:

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge-sans-paille added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3520-3521 +LexStart: + assert(!Result.needsCleaning() && "Result doesn't need cleaning"); + assert(!Result.hasPtrData() && "Result has been reset"); foad wrote: > Messages are

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:39 FileID FID = SM.getFileID(Loc.physical()); -const auto *FE = SM.getFileEntryForID(FID); +const auto *FE =

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

mstorsjo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/CMakeLists.txt:12 LINK_LIBS clangAST Note that this file changed a bit further in 68294afa0836bb62be921e2143d147cdfdc8ba70, so you may want to rebase again. (I tested

[PATCH] D138207: [clang][Parse][NFC] Remove unused CommaLocs parameters

tbaeder closed this revision. tbaeder added a comment. Dang, looks like I forgot to mention the review in https://github.com/llvm/llvm-project/commit/e78a43dacafb8b97fc377a52f8f206e37d94d5d6. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f102fe7 - Revert "Revert "[opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm""

Author: Alexander Shaposhnikov Date: 2022-11-18T08:58:31Z New Revision: f102fe73044062542f022182381c17172a999db2 URL: https://github.com/llvm/llvm-project/commit/f102fe73044062542f022182381c17172a999db2 DIFF:

[clang] 7f608a2 - Revert "[opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm"

Author: Mikhail Goncharov Date: 2022-11-18T09:25:45+01:00 New Revision: 7f608a2497c7578b9f3ca98014176ab95cffe3c0 URL: https://github.com/llvm/llvm-project/commit/7f608a2497c7578b9f3ca98014176ab95cffe3c0 DIFF:

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein updated this revision to Diff 476372. hokein marked 4 inline comments as done. hokein added a comment. rebase and update based on the offline discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137698/new/

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

alexander-shaposhnikov added a comment. Recommitted this diff in https://github.com/llvm/llvm-project/commit/f102fe73044062542f022182381c17172a999db2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137235: [clang][Interp] Fix ImplicitValueInitExprs for pointer types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137235/new/ https://reviews.llvm.org/D137235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

john.brawn added inline comments. Comment at: clang/docs/ReleaseNotes.rst:760 +- Strict floating point has been enabled for AArch64, which means that + ``-ftrapping-math``, ``-frounding-math``, ``-ffp-model=strict``, and + ``-ffp-exception-behaviour=`` are now accepted.

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:47 + } + void buildAST() { AST = std::make_unique(Inputs); } +

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

aaron.ballman added a reviewer: bader. aaron.ballman added a subscriber: bader. aaron.ballman added a comment. Adding @bader as SYCL code owner. The changes look reasonable to me, but codegen is not my area of expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein updated this revision to Diff 476410. hokein marked 2 inline comments as done. hokein added a comment. address comment: split tests, add a smoke test for PragmaInclude::isSelfContained. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138270: [clang][Sema] Skip checking int expressions for overflow in constexpr functions

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not 100% sure if this is crazy or not, but it doesn't even seem to break any existing

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair added a comment. @theraven Any chance you could glance over this and reassure us that it isn't going to break the GNU runtime if we do this? (We're adding an extra attribute in the property attribute string so that we can detect `@optional` properties in ObjC protocols at runtime.)

[clang] 326393a - [Driver] exclude recently added tests from Windows

Author: Matt Jacobson Date: 2022-11-18T05:30:42-05:00 New Revision: 326393ae653189023b251f05009d86215ad30caf URL: https://github.com/llvm/llvm-project/commit/326393ae653189023b251f05009d86215ad30caf DIFF: https://github.com/llvm/llvm-project/commit/326393ae653189023b251f05009d86215ad30caf.diff

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136920/new/ https://reviews.llvm.org/D136920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

arichardson created this revision. arichardson added reviewers: erichkeane, rjmccall, aaron.ballman. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Herald added a project: All. arichardson requested review of this revision. Herald added a project: clang. Herald added a subscriber:

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 11/17/22 13:35, Bruno Haible wrote: Clang will surely not acquire knowledge about "every library", right, only about the C library according to relevant standards (ISO C, POSIX)? I don't know the Clang developers' plans. But if I wanted Clang to be picky then yes, I'd have it know about

Re: How can Autoconf help with the transition to stricter compilation defaults?

Paul Eggert wrote: > > AC_CHECK_FUNC *should not* just probe for linkability of a symbol > > ... Autoconf cannot > be expected to know every signature of every function in every library. Clang will surely not acquire knowledge about "every library", right, only about the C library according to

[clang-tools-extra] 3cf14a7 - [Support] Add support for attaching payloads to points and ranges

Author: Tom Praschan Date: 2022-11-18T15:00:23+01:00 New Revision: 3cf14a7bdce08f8fe03d987a2d99c6ea47c58c03 URL: https://github.com/llvm/llvm-project/commit/3cf14a7bdce08f8fe03d987a2d99c6ea47c58c03 DIFF: https://github.com/llvm/llvm-project/commit/3cf14a7bdce08f8fe03d987a2d99c6ea47c58c03.diff

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

This revision was automatically updated to reflect the committed changes. tom-anders marked 6 inline comments as done. Closed by commit rG3cf14a7bdce0: [Support] Add support for attaching payloads to points and ranges (authored by tom-anders). Changed prior to commit:

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `MaybeTypeCast` here is not a variable, it's an enum member with value 1. I'm just not

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1939 int main() { - int $def[[foo]]; - [[^foo]] = 2; - int test1 = [[foo]]; + int $def(main)[[foo]]; + $(main)[[^foo]] = 2;

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

aaron.ballman added a comment. This code was introduced in https://github.com/llvm/llvm-project/commit/5a5319062300166a747807339349766341a2c2b2 and does not appear to have had precommit review (that I could find). It was resolving https://bugs.llvm.org/show_bug.cgi?id=23101, and the last

[PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. And another problem with this patch: there's another pattern (or multiple different patterns?) in the code, that result in around 3x clang memory usage increase after this patch. The result of `-print-stats` doesn't make it clear where the additional allocations come

[PATCH] D138274: Add version to all LLVM cmake package

thopre created this revision. thopre added reviewers: smeenai, arsenm, stella.stamenova, stellaraccident, Ericson2314, pmccormick, beanz. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov,

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This shows up when the interpretation is

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137392: [clang][Interp] Explicitly handle RVO Pointer

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137392/new/ https://reviews.llvm.org/D137392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:749-751 + const Descriptor::MetadataSize MDSize{sizeof(InlineDescriptor)}; + Descriptor *D = + P.createDescriptor(Src, Ty, MDSize, IsConst,

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

kadircet added a comment. thanks, mostly LG a bunch of suggestions for tests Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:74 + /// Returns true if the given file is a self-contained file. + bool isSelfContained(const FileEntry *File)

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair marked an inline comment as done. al45tair added inline comments. Comment at: clang/test/CodeGenObjC/objc-asm-attribute-test.m:20 +@class Message; + ahatanak wrote: > Do you need this change? No, I think this is left-over from an earlier revision.

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair updated this revision to Diff 476387. al45tair marked 2 inline comments as done. al45tair added a comment. Updated following comments from @ahatanak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135273/new/

[PATCH] D138270: [clang][Sema] Skip checking int expressions for overflow in constexpr functions

tbaeder updated this revision to Diff 476391. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138270/new/ https://reviews.llvm.org/D138270 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaChecking.cpp clang/unittests/Support/TimeProfilerTest.cpp

[PATCH] D138276: TableGen: require tablegen cl::opts to be registered explicitly

nhaehnle created this revision. Herald added subscribers: libc-commits, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136457/new/ https://reviews.llvm.org/D136457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein updated this revision to Diff 476425. hokein marked 3 inline comments as done. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137698/new/ https://reviews.llvm.org/D137698 Files:

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

kadircet created this revision. kadircet added reviewers: kito-cheng, ilya-biryukov. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kadircet added a comment. In D124730#3916786 , @kadircet wrote: > Hi @kito-cheng, can you please let us know if you're working on a fix here > (and whether it seems to be close)? otherwise i am planning to revert this > and consequent changes, as it's

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

tom-anders added a comment. Thanks again! Landed this with your suggestions incorporated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137909/new/ https://reviews.llvm.org/D137909 ___ cfe-commits

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

kwk requested changes to this revision. kwk added a comment. This revision now requires changes to proceed. As much as I would like this to be fixed. I vote against this patch because in `lld/CMakeLists.txt` there's an almost (if not entirely) identical piece of code

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

hokein added a comment. Thanks, I like the idea of marking missing-include refs. I haven't read the code yet, and below are all my findings when I played with the demo html (some of them are unrelated to the current patch, just want to dump all): 1. size_t shows duplicated entries, line 465

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:47 + } + void buildAST() { AST = std::make_unique(Inputs); } + kadircet wrote: > nit: i'd actually rename this to `astWithIncludes` and take in a set of

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders updated this revision to Diff 476438. tom-anders added a comment. tom-anders retitled this revision from "[clangd] Prototype for adding enclosing function in references results"

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a comment. In D126818#3935740 , @rjmccall wrote: > I'm too often slow to actually apply edits to the ABI document. There's been > plenty of time for feedback on this one; go ahead and act like it's accepted. Ah! I see! I thought last

[PATCH] D111566: [SYCL] Fix function pointer address space

arichardson added inline comments. Herald added a project: All. Comment at: clang/lib/AST/ASTContext.cpp:11579 +unsigned ASTContext::getTargetAddressSpace(QualType T) const { + return T->isFunctionType() ? getTargetInfo().getProgramAddressSpace() + :

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

nhaehnle created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini,

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/CMakeLists.txt:12 LINK_LIBS clangAST mstorsjo wrote: > Note that this file changed a bit further in > 68294afa0836bb62be921e2143d147cdfdc8ba70, so you may want to rebase

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:749-751 + const Descriptor::MetadataSize MDSize{sizeof(InlineDescriptor)}; + Descriptor *D = + P.createDescriptor(Src, Ty, MDSize, IsConst, Src.is()); tbaeder wrote:

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3936007 , @owenpan wrote: > I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, > then wouldn't it be better to do that? But the `r_brace` has no `MatchingParen`, and I didn't want

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cf888514454: [include-cleaner] Add self-contained file support for PragmaIncludes. (authored by hokein). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 0cf8885 - [include-cleaner] Add self-contained file support for PragmaIncludes.

Author: Haojian Wu Date: 2022-11-18T13:52:30+01:00 New Revision: 0cf888514454350cd97ab79cdb4a73e7f189eea0 URL: https://github.com/llvm/llvm-project/commit/0cf888514454350cd97ab79cdb4a73e7f189eea0 DIFF: https://github.com/llvm/llvm-project/commit/0cf888514454350cd97ab79cdb4a73e7f189eea0.diff

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

erichkeane added a comment. In D138284#3936830 , @aaron.ballman wrote: > Adding @bader as SYCL code owner. The changes look reasonable to me, but > codegen is not my area of expertise. Yeah, same to me. I wrote this originally, but I think the

[clang-tools-extra] 6527201 - [clang-tidy] Remove a duplicated if-branch in the unused-using-decl

Author: Haojian Wu Date: 2022-11-18T15:07:46+01:00 New Revision: 6527201414cf9479639594a7a1f80558ec09d106 URL: https://github.com/llvm/llvm-project/commit/6527201414cf9479639594a7a1f80558ec09d106 DIFF: https://github.com/llvm/llvm-project/commit/6527201414cf9479639594a7a1f80558ec09d106.diff

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

probinson added a comment. If this is specifically for C++17, I believe Sony doesn't officially support that yet although I am checking. It looks like this is only part of the fix for #58819? The original report also had a `static int n` with an internal-linkage name. Repository: rG LLVM

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

yaxunl updated this revision to Diff 476454. yaxunl added a comment. need to specify osabi for elf64_amdgpu CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138221/new/ https://reviews.llvm.org/D138221 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D138210: [clang] Require parameter pack to be last argument in concepts.

luken-google updated this revision to Diff 476462. luken-google added a comment. Adding release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138210/new/ https://reviews.llvm.org/D138210 Files: clang/docs/ReleaseNotes.rst

[PATCH] D138297: [Clang][OpenMP] Add default map type for target enter/exit data

doru1004 created this revision. doru1004 added reviewers: ABataev, jdoerfert, carlo.bertolli, ronl, dhruvachak, gregrodgers. doru1004 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald added

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

arichardson added a comment. In D138284#3936846 , @erichkeane wrote: > In D138284#3936830 , @aaron.ballman > wrote: > >> Adding @bader as SYCL code owner. The changes look reasonable to me, but >> codegen is

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1635 + Context.getTargetInfo().getConstantAddressSpace().value_or( + LangAS::Default)); llvm::Constant *GlobalConstStr = Builder.CreateGlobalStringPtr( arichardson

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1635 + Context.getTargetInfo().getConstantAddressSpace().value_or( + LangAS::Default)); llvm::Constant *GlobalConstStr = Builder.CreateGlobalStringPtr( arichardson

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry created this revision. v1nh1shungry added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

daltenty accepted this revision. daltenty added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137986/new/ https://reviews.llvm.org/D137986 ___ cfe-commits mailing list

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa7477eb87fd: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and… (authored by xingxue). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fa7477e - [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

Author: Xing Xue Date: 2022-11-18T11:36:56-05:00 New Revision: fa7477eb87fd262898e78db983c7b0951b87641c URL: https://github.com/llvm/llvm-project/commit/fa7477eb87fd262898e78db983c7b0951b87641c DIFF: https://github.com/llvm/llvm-project/commit/fa7477eb87fd262898e78db983c7b0951b87641c.diff

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added inline comments. Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:918 ":Core", +":IRPrinter", ":IRReader", Per the follow on fix to D137768, I guess this one was unnecessary. Can you check if there are any

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder updated this revision to Diff 476452. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138289/new/ https://reviews.llvm.org/D138289 Files: clang/lib/Parse/ParseExpr.cpp Index: clang/lib/Parse/ParseExpr.cpp === ---

[PATCH] D138249: [WebAssembly] Update relaxed-simd instruction names

maratyszcza added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 TARGET_BUILTIN(__builtin_wasm_relaxed_min_f64x2, "V2dV2dV2d", "nc", "relaxed-simd") -TARGET_BUILTIN(__builtin_wasm_relaxed_max_f64x2, "V2dV2dV2d", "nc", "relaxed-simd")

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

eandrews added subscribers: erichkeane, aaron.ballman. eandrews added a comment. Functionally this looks ok to me. However I am not sure if CodeGenTypes is the 'right' place for this function to live, considering that other functions with similar functionality are in ASTContext - including

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar added a comment. In D138258#3936260 , @kwk wrote: > As much as I would like this to be fixed. I vote against this patch because > in `lld/CMakeLists.txt` there's an almost (if not entirely) identical piece > of code >

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added projects: Flang, All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1635 + Context.getTargetInfo().getConstantAddressSpace().value_or( + LangAS::Default)); llvm::Constant *GlobalConstStr = Builder.CreateGlobalStringPtr( > This changes

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

arichardson updated this revision to Diff 476470. arichardson added a comment. Fix to use addrspace(1) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138284/new/ https://reviews.llvm.org/D138284 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138284/new/ https://reviews.llvm.org/D138284

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3936536 , @HazardyKnusperkeks wrote: > In D138263#3936007 , @owenpan wrote: > >> I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, >>

[PATCH] D138249: [WebAssembly] Update relaxed-simd instruction names

tlively updated this revision to Diff 476490. tlively added a comment. - Fix type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138249/new/ https://reviews.llvm.org/D138249 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen updated this revision to Diff 476491. samitolvanen added a comment. Dropped the unneeded constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135411/new/ https://reviews.llvm.org/D135411 Files:

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

arichardson added a comment. In D138296#3937224 , @eandrews wrote: > Functionally this looks ok to me. However I am not sure if CodeGenTypes is > the 'right' place for this function to live, considering that other functions > with similar functionality

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. In D138247#3936928 , @probinson wrote: > If this is specifically for C++17, I believe Sony doesn't officially support > that yet although I am checking. Cool, thanks! > It looks like this is only part of the fix for #58819?

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1457 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Format::Zlib tschuett

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

rjmccall added a comment. In D138296#3937486 , @arichardson wrote: > In D138296#3937224 , @eandrews > wrote: > >> Functionally this looks ok to me. However I am not sure if CodeGenTypes is >> the 'right' place

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. The crash is gone. The false positive with the `[m]` capture is still present with `-std=c++11`. Here's another false positive: #include void f(const std::string&); int main() { std::string s; f(s.empty() ? "<>" : s); } input.cpp:7:26:

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

arichardson created this revision. arichardson added reviewers: eandrews, dylanmckay, bader, rjmccall. Herald added subscribers: jrtc27, luismarques, s.egerton, Jim, PkmX, atanasyan, simoncook, kristof.beyls, sdardis. Herald added a project: All. arichardson requested review of this revision.

[clang] 096c033 - [clang][sema][NFC] Make some local variables const

Author: Timm Bäder Date: 2022-11-18T16:19:09+01:00 New Revision: 096c033634d230fdb5eae4a0c3777e629cce0d82 URL: https://github.com/llvm/llvm-project/commit/096c033634d230fdb5eae4a0c3777e629cce0d82 DIFF: https://github.com/llvm/llvm-project/commit/096c033634d230fdb5eae4a0c3777e629cce0d82.diff

[clang] 25bd9e1 - [clang][parse] Avoid creating StmtVectors every loop iteration

Author: Timm Bäder Date: 2022-11-18T16:19:09+01:00 New Revision: 25bd9e10098a91623b63952967b6561d77f43c15 URL: https://github.com/llvm/llvm-project/commit/25bd9e10098a91623b63952967b6561d77f43c15 DIFF: https://github.com/llvm/llvm-project/commit/25bd9e10098a91623b63952967b6561d77f43c15.diff

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry updated this revision to Diff 476485. v1nh1shungry added a comment. Apply the comment's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300 Files:

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar added inline comments. Comment at: clang/CMakeLists.txt:97 # Seek installed Lit. -find_program(LLVM_LIT - NAMES llvm-lit lit.py lit - PATHS "${LLVM_MAIN_SRC_DIR}/utils/lit" - DOC "Path to lit.py") +if (NOT

[PATCH] D138137: [CodeGen][ARM] Fix ARMABIInfo::EmitVAAarg crash with empty record type variadic arg

yronglin added a comment. Thank you so much for your review, @rjmccall , can you land this patch for me? Please use 'yronglin ' to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138137/new/ https://reviews.llvm.org/D138137

[PATCH] D138295: [clang][TargetInfo] Use LangAS for getPointer{Width,Align}()

arichardson created this revision. arichardson added a reviewer: clang. Herald added subscribers: steakhal, kosarev, mattd, gchakrabarti, asavonic, martong, kerbowa, atanasyan, jrtc27, jvesely, sdardis. Herald added a reviewer: aaron.ballman. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D138295: [clang][TargetInfo] Use LangAS for getPointer{Width,Align}()

arichardson updated this revision to Diff 476472. arichardson added a comment. clang-format I could also use {} instead of `LangAS::Default`, but the latter seems more obvious Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138295/new/

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

arichardson updated this revision to Diff 476473. arichardson added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138296/new/ https://reviews.llvm.org/D138296 Files: clang/include/clang/AST/ASTContext.h

  1   2   >