[clang] bd7f4c5 - [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

Author: Iain Sandoe Date: 2022-12-18T09:16:27Z New Revision: bd7f4c561f5e2385ebe5500a044efe0de30cccaa URL: https://github.com/llvm/llvm-project/commit/bd7f4c561f5e2385ebe5500a044efe0de30cccaa DIFF: https://github.com/llvm/llvm-project/commit/bd7f4c561f5e2385ebe5500a044efe0de30cccaa.diff LOG:

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd7f4c561f5e: [C++20][Modules] Elide unused guard variables in Itanium ABI module… (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. In D138179#4002068 , @nathanchance wrote: > For what it's worth, this breaks building the Linux kernel's `ARCH=mips > 32r1_defconfig` with clang and GNU as, with thousands of messages along the > line of: > >

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 483817. cor3ntin added a comment. revert WS only change, removed unused `DelayedCapture` type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files:

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin updated this revision to Diff 483813. cor3ntin added a comment. Update release notes and commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clang/docs/ReleaseNotes.rst

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. In D140226#4003788 , @tschuett wrote: > There are already SYCL specific attributes: https://reviews.llvm.org/D60455 We could potentially merge these all into some generic attribute since they all do the same thing on a

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 483815. lime added a comment. Rebase and ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index:

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 483816. cor3ntin added a comment. Remove unused variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. Pinging @njames93 to about the questions from the previous comment. Would love to see something like this PR get merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. In D140226#4003781 , @keryell wrote: > I wonder whether we could not factorize some code/attribute/logic with AMDGPU > or SYCL. > Is the use case to have for example CUDA+HIP+SYCL in the same TU and thus > there is a need for

[clang-tools-extra] 541ef3d - Include instead of "llvm/ADT/Optional.h"

Author: Kazu Hirata Date: 2022-12-18T00:28:54-08:00 New Revision: 541ef3d61e9341cd38420c0dbca9250c4d0ea04c URL: https://github.com/llvm/llvm-project/commit/541ef3d61e9341cd38420c0dbca9250c4d0ea04c DIFF: https://github.com/llvm/llvm-project/commit/541ef3d61e9341cd38420c0dbca9250c4d0ea04c.diff

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1642 +if (LHS.isUnsigned() ^ RHS.isUnsigned()) { + if (LHS.isUnsigned() && (LHS.getBitWidth() >= RHS.getBitWidth())) { + steakhal wrote: > manas wrote: > >

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

cor3ntin added a comment. In D137531#4003723 , @lime wrote: > Rebase and ping! I think looks good, but I want to make sure @erichkeane finds his comments resolved, and he is in vacation until January. CHANGES SINCE LAST ACTION

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

keryell added subscribers: bader, keryell. keryell added a comment. I wonder whether we could not factorize some code/attribute/logic with AMDGPU or SYCL. Is the use case to have for example CUDA+HIP+SYCL in the same TU and thus there is a need for different attributes Repository: rG LLVM

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 483820. cor3ntin added a comment. Remove the lookahead parsing code code which is no longer necessary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files:

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. https://reviews.llvm.org/D140270 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 ___ cfe-commits mailing list

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

tschuett added a comment. There are already SYCL specific attributes: https://reviews.llvm.org/D60455 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140226/new/ https://reviews.llvm.org/D140226 ___

[PATCH] D140267: [clang-format] Allow line break between template closer and right paren

HazardyKnusperkeks added a comment. Maybe do not limit to `JsTypeColon` but all colons? What about something like `f(some_template).method()`? I'd have to check where it breaks if there isn't a template in the argument, but I'd guess not before the paren. Comment at:

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin updated this revision to Diff 483812. cor3ntin added a comment. Handle late constraints checking and fully implement P2579 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

JonChesterfield added a comment. Calling convention is the right model here. Kernels are functions with a different calling convention to the 'normal' functions in a very literal sense. The calling convention modelling in clang is different to attribute handling and changing nvptx to it is

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

FreddyYe created this revision. Herald added a subscriber: pengfei. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. "__cmpccxadd_epi*" -> "_cmpccxadd_epi*" Repository: rG LLVM Github Monorepo

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

craig.topper added a comment. Please update the title Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139701/new/ https://reviews.llvm.org/D139701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos created this revision. tupos added reviewers: sammccall, njames93. tupos added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tupos requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead added a comment. In D112921#4003939 , @Romain-Geissler-1A wrote: > Hi, > > Is there any update about this ? Currently, no. If someone is interesting in this, please feel free to commandeer. :-) Repository: rG LLVM Github Monorepo

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. In D140226#4003826 , @tschuett wrote: > But then you are maybe mixing two concepts. `kernel` is source code or AST > feature. nvptx or AMDGPU are command line flags. > > CUDA, Sycl, nvtx, and AMDGPU are modes or calling

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

tschuett added a comment. In D140226#4003794 , @jhuber6 wrote: > In D140226#4003788 , @tschuett > wrote: > >> There are already SYCL specific attributes: https://reviews.llvm.org/D60455 > > We could potentially

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. I do not know but maybe it makes sence to make configurable the style of the comment, e.g instead of `@brief` use `\brief` and the same for `/*!` to `/**` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

MaskRay added a comment. I have a question why the option is needed. if (IBTSeal) { return F.hasAddressTaken(); } // if !IBTSeal, fall into default case. LLVM_FALLTHROUGH; // Address taken or externally linked functions may be reachable. default: return

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

MaskRay added a comment. (I substantially edited my previous comment.) It now says this: > If the link mixes bitcode files and ELF relocatable files, for a function in > a bitcode file, `F.hasAddressTaken()` doesn't indicate that its address is > not taken by an ELF relocatable file.

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. In D139986#4001180 , @Michael137 wrote: > Missed couple of test cases in libcxx > About to fix those There were more breakage due to this patch, which I fixed in D140272 . Next time please

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Romain-Geissler-1A added a comment. Herald added a subscriber: steakhal. Hi, Is there any update about this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921

[PATCH] D140274: [clangd] Tweak to fill struct with designated initializers

tupos created this revision. tupos added reviewers: sammccall, njames93. tupos added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tupos requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM generally. Comment at: clang/lib/Sema/SemaDecl.cpp:12957-12958 + // units. + if (getLangOpts().CPlusPlus20 && getLangOpts().CPlusPlusModules && +

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff added a comment. @sammccall @aaron.ballman I am thinking about another solution with tentative parsing as implemented for C++ in `Parser::isCXXSimpleDeclaration` (which is eventually called from `isDeclarationStatement()`). This approach works well for C++. So I want to update this

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139995/new/ https://reviews.llvm.org/D139995

[clang] a40ef65 - [Intrinsic] Rename flt.rounds intrinsic to get.rounding

Author: Qiu Chaofan Date: 2022-12-19T15:22:39+08:00 New Revision: a40ef656d812143d24c810c65ebf6b24646837f0 URL: https://github.com/llvm/llvm-project/commit/a40ef656d812143d24c810c65ebf6b24646837f0 DIFF: https://github.com/llvm/llvm-project/commit/a40ef656d812143d24c810c65ebf6b24646837f0.diff

[PATCH] D139507: [Intrinsic] Rename flt.rounds intrinsic to get.rounding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa40ef656d812: [Intrinsic] Rename flt.rounds intrinsic to get.rounding (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

LuoYuanke accepted this revision. LuoYuanke added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140281/new/ https://reviews.llvm.org/D140281 ___ cfe-commits mailing list

[PATCH] D139701: [Clang] Emit "min-legal-vector-width" attribute for X86 only

pengfei added a comment. In D139701#4004114 , @craig.topper wrote: > Please update the title Thanks for reminding! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139701/new/

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5545 +if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) + TempPath = FinalOutput->getValue(); +else + TempPath = BaseInput; + tahonermann wrote: >

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tschuett added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:24 +namespace clang { +namespace clangd { +namespace { You can merge this into `namespace clang::clangd`. Comment at: