[PATCH] D133574: [C2x] reject type definitions in offsetof

bkramer added a comment. GitHub finds around 1.9k instances of this pattern to compute `alignof`. There's a lot of duplicates and `#ifdefs` so the real number is going to be smaller, but it seems to be quite common. The annoying part is that there is no `_Alignof` in C99 so for many of those

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

beanz added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:2401 + +macro(setup_host_tool tool_name setting_name exe_var_name target_var_name) + cmake_parse_arguments(ARG "" "SCOPE" "" ${ARGN}) Please make this a `function` instead of a `macro`.

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein updated this revision to Diff 488985. hokein added a comment. Check for the ActOnTemplatedFriendTag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141580/new/ https://reviews.llvm.org/D141580 Files: clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. Note, I just did the revert of the workaround myself here: 498bf3424d011235d420e02e80e135fae646d537 I won't see the failure on https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/ until

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google added a comment. See: https://github.com/llvm/llvm-project/issues/53983 I can add a release note and some testing, but wanted feedback that this was the right approach. The problem is when generating code for the constructor for the `bar` element inside of `MyStruct`, `Dest` has

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

v1nh1shungry added a comment. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140838/new/ https://reviews.llvm.org/D140838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 18b0d2c - [analyzer] Fix a FIXME. NFCI

Author: Benjamin Kramer Date: 2023-01-13T16:15:16+01:00 New Revision: 18b0d2c5d9762070f7c579f2e7ecaa105db7 URL: https://github.com/llvm/llvm-project/commit/18b0d2c5d9762070f7c579f2e7ecaa105db7 DIFF:

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:3-35 +// NOLINTBEGIN +namespace std { +template +struct remove_reference; + +template +struct remove_reference {

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:3-35 +// NOLINTBEGIN +namespace std { +template +struct remove_reference; + +template +struct remove_reference {

[clang-tools-extra] f88c6b9 - Move definitions to prevent incomplete types.

Author: Jens Massberg Date: 2023-01-13T16:44:49+01:00 New Revision: f88c6b9166f885e7089cb15095e38868aaba04da URL: https://github.com/llvm/llvm-project/commit/f88c6b9166f885e7089cb15095e38868aaba04da DIFF: https://github.com/llvm/llvm-project/commit/f88c6b9166f885e7089cb15095e38868aaba04da.diff

[PATCH] D141671: Move definitions to prevent incomplete types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf88c6b9166f8: Move definitions to prevent incomplete types. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138792: [AArch64] Improve TargetParser API

danielkiss added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:532 getTargetDefinesARMV81A(Opts, Builder); -break; - case llvm::AArch64::ArchKind::ARMV8_2A: + if (*ArchInfo == llvm::AArch64::ARMV8_2A) getTargetDefinesARMV82A(Opts, Builder);

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

shafik added a comment. In D92733#4051123 , @faisalv wrote: > I'll try and look into it this weekend and have some sort of updated news > for you by monday? > Faisal Vali Awesome, feel free to add me as a reviewer. If we can get this fixed that would

[PATCH] D141698: doc: Rewrite opening paragraph of CFI Design Doc

1c3t3a created this revision. Herald added a project: All. 1c3t3a requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141698 Files: clang/docs/ControlFlowIntegrityDesign.rst

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 added a comment. That part of code is original add for is_device_address, so I just wonder, if the change could break is_device_address? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 489031. pmatos marked 2 inline comments as done. pmatos added a comment. Address a few comments, add new test for funcref keyword diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Marking this as needing changes so it doesn't look accepted to the new reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman reopened this revision. aaron.ballman added reviewers: clang-vendors, mgorny, thesamesam. aaron.ballman added a comment. This revision is now accepted and ready to land. In D133574#4051782 , @bkramer wrote: > GitHub finds around 1.9k

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140668/new/ https://reviews.llvm.org/D140668 ___ cfe-commits mailing list

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 489036. paulkirth added a comment. Fix test for Windows. I had missed one of the file paths in YAML. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files:

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM @aaron.ballman are you happy with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

doru1004 updated this revision to Diff 489035. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/nested_loop_codegen.cpp Index: clang/test/OpenMP/nested_loop_codegen.cpp

[PATCH] D133574: [C2x] reject type definitions in offsetof

tlively added a comment. FWIW I had to patch the musl used by Emscripten to work around this: https://github.com/emscripten-core/emscripten/pull/18510 The fix was simple and I don't have a strong opinion about the right way forward, but this change was slightly disruptive and I imagine other

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

Mordante added a comment. Should this also fix the issue where the scheduled build sometimes picks the "clang build"? For example https://buildkite.com/llvm-project/libcxx-ci/builds/17300 but I noticed to at other times too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:532 getTargetDefinesARMV81A(Opts, Builder); -break; - case llvm::AArch64::ArchKind::ARMV8_2A: + if (*ArchInfo == llvm::AArch64::ARMV8_2A) getTargetDefinesARMV82A(Opts, Builder);

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm created this revision. arsenm added reviewers: yaxunl, t-tye, b-sumner, rampitec, AMDGPU, Anastasia, JonChesterfield, jhuber6. Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2069-2078 +if (auto *TagDecl = Actions.ActOnTag( +getCurScope(), TagType, TUK, StartLoc, SS, Name, NameLoc, attrs, AS, +DS.getModulePrivateSpecLoc(), TParams, Owned,

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

shafik added inline comments. Comment at: clang/test/AST/Interp/cxx17.cpp:7 + +struct F { int a; int b;}; +constexpr F getF() { tbaeder wrote: > shafik wrote: > > It would also be good to test references, bit-fields, volatile and > > tuple-like types if

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:2401 + +macro(setup_host_tool tool_name setting_name exe_var_name target_var_name) + cmake_parse_arguments(ARG "" "SCOPE" "" ${ARGN}) beanz wrote: > Please make this a `function`

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

beanz added a comment. The convention that `find_program` uses is to cache the variables, which causes them to be defined at global scope. That also avoids needing to recompute filesystem lookups in incremental builds, which is desirable. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57 +ParamDescriptors.insert({ParamOffset, {Ty, Desc}}); +Params.insert({PD, ParamOffset}); +ParamOffset

[PATCH] D133574: [C2x] reject type definitions in offsetof

philnik added a comment. In D133574#4051899 , @aaron.ballman wrote: > In D133574#4051782 , @bkramer wrote: > >> GitHub finds around 1.9k instances of this pattern to compute `alignof`. >> There's a lot of

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and @erichkeane for the efforts saving @mizvekov work over the summer. I believe he has sporadic access to internet and soon he will be back to normal. Great example of team work here!!

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4052026 , @v.g.vassilev wrote: > Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and > @erichkeane for the efforts saving @mizvekov work over the summer. I believe > he has sporadic

[PATCH] D141644: [clang] Report the on-disk paths for inputs to module compiles

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Please add a comment to each place you're doing this since it's non-obvious why the filename would be different to people not familiar with the mapping code. Otherwise LGTM

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4051851 , @jyu2 wrote: > That part of code is original add for is_device_address, so I just wonder, if > the change could break is_device_address? Now I kinda think it is not right to mix `is_device_address`

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. New

[PATCH] D139949: [clang-scan-deps] Migrate to OptTable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c60ec699fc1: [clang-scan-deps] Migrate to OptTable (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo added a comment. In D131052#4051948 , @beanz wrote: > The convention that `find_program` uses is to cache the variables, which > causes them to be defined at global scope. Right, I guess that could work too. It would be less of a pure

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Precommit CI found failures that look relevant to the patch. > We may want to be able to mark certain regions as kernels even without being > in an accepted CUDA or OpenCL language mode. Can you explain this a bit more?

[PATCH] D139949: [clang-scan-deps] Migrate to OptTable

abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:2207 ":frontend", +":ScanDepsTableGen", ":tooling", GMNGeoffrey wrote: > MaskRay wrote: > > Move

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added a comment. In D140226#4052105 , @aaron.ballman wrote: > Precommit CI found failures that look relevant to the patch. > >> We may want to be able to mark certain regions as kernels even without being >> in an accepted CUDA or OpenCL

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google updated this revision to Diff 489057. luken-google added a comment. Adds test and release note, refactors to avoid possible null pointer deref. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141690/new/ https://reviews.llvm.org/D141690

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1338 + llvm::StructType *STy = dyn_cast(Val->getType()); + if (STy && STy->isLayoutIdentical(cast(Dest.getElementType( { for (unsigned i = 0, e = STy->getNumElements(); i != e; ++i) {

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google updated this revision to Diff 489058. luken-google added a comment. Add newline at end of test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141690/new/ https://reviews.llvm.org/D141690 Files: clang/docs/ReleaseNotes.rst

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:565 +def CompareFunctionPointers : DiagGroup<"compare-function-pointers">; def OrderedCompareFunctionPointers : DiagGroup<"ordered-compare-function-pointers">; def PackedNonPod :

[PATCH] D141708: [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool

jhuber6 created this revision. jhuber6 added reviewers: tianshilei1992, jdoerfert, tra. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, guansong, tpr, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1,

[PATCH] D141709: [clang][dataflow] Fix bug in joining bool values.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the code assumes that

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

jansvoboda11 added a comment. In D141450#4049049 , @dblaikie wrote: > Perhaps I've got things confused, but my understanding of LSV was that it > prevented other headers in the same modulemap from leaking into the > use/inclusion of one header in a

[PATCH] D141644: [clang] Report the on-disk paths for inputs to module compiles

jansvoboda11 updated this revision to Diff 489072. jansvoboda11 added a comment. Fix test on Windows(?), add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141644/new/ https://reviews.llvm.org/D141644 Files:

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

yaxunl added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:53-57 -__attribute__((target("s-memtime-inst"))) -void test_target_features_func(global int *i) { - queue_t default_queue; - unsigned flags = 0; - ndrange_t ndrange;

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

dblaikie added a comment. In D140423#4051262 , @aaron.ballman wrote: >> Add something like a bool IsDefaulted somewhere in Clang, e.g., in >> TemplateArgument and consult it from the TypePrinter. This would be much >> simpler but requires adding a

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:53-57 -__attribute__((target("s-memtime-inst"))) -void test_target_features_func(global int *i) { - queue_t default_queue; - unsigned flags = 0; - ndrange_t ndrange;

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

dblaikie added a comment. In D141450#4052210 , @jansvoboda11 wrote: > In D141450#4049049 , @dblaikie > wrote: > >> Perhaps I've got things confused, but my understanding of LSV was that it >> prevented other

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. Currently, we embed

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. It's slightly hard to test this because it involves making a huge diff of a git repo. If you're willing to jump through the hoops of cloning chromium (honestly, this is a pain in the ass. It's too much hard drive space and you've got to install depot_tools. If you

[PATCH] D139185: [clang][Interp] Use placement new to construct opcode args into vector

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139185/new/ https://reviews.llvm.org/D139185 ___ cfe-commits mailing

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 marked 4 inline comments as done. usaxena95 added a comment. I have deleted the test in https://github.com/llvm/llvm-project/commit/a3b632ab8772237ae23638f702bdceda028b2016. It is safe to delete as this is a brittle test trying to generate an invalid requirement using very deep

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D141654#4050852 , @rymiel wrote: > (This needs to run the updated dump script from D138446 > ) > > I'm not sure what the strict

[clang] 0a652c5 - [codegen] Add StackFrameLayoutAnalysisPass

Author: Paul Kirth Date: 2023-01-13T20:52:48Z New Revision: 0a652c540556a118bbd9386ed3ab7fd9e60a9754 URL: https://github.com/llvm/llvm-project/commit/0a652c540556a118bbd9386ed3ab7fd9e60a9754 DIFF: https://github.com/llvm/llvm-project/commit/0a652c540556a118bbd9386ed3ab7fd9e60a9754.diff LOG:

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a652c540556: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

tra added a comment. In D141717#4052587 , @jhuber6 wrote: > Well you'll get textual output for the host output, but the device code > embedded in the host module will be bitcode instead. So the final output from > the compiler is still textual IR. It

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. In D131306#4052782 , @tejohnson wrote: > In D131306#4037037 , @paulkirth > wrote: > >> @tejohnson @xur I kind of dropped the ball on these patches, but what are >> your thoughts on

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 489160. dzhidzhoev added a comment. Fixed crashes reported by @efriedma and @rupprecht. "Base subobject type" layout (e.g. type layout without suffix padding) is calculated for unions and final classes too here, in order to lay out fields with

[PATCH] D141744: [Clang] Add lifetimebound attribute to std::move/std::forward

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: rsmith, aaron.ballman, dblaikie. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

nhat-nguyen added a comment. In D141538#4050784 , @sebastian-ne wrote: > The debian pre-checkin test is unfortunately quite unstable. I see the same > failures in D141469 for example. > This looks good to go. Would

[clang] 6809af1 - Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend"

Author: Dominik Adamski Date: 2023-01-13T14:38:17-06:00 New Revision: 6809af1a232bc5ac71358e4b874759ddaae056a1 URL: https://github.com/llvm/llvm-project/commit/6809af1a232bc5ac71358e4b874759ddaae056a1 DIFF:

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4052753 , @tra wrote: > In D141717#4052587 , @jhuber6 wrote: > >> Well you'll get textual output for the host output, but the device code >> embedded in the host module will

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

owenpan updated this revision to Diff 489125. owenpan added a comment. Rebased and ran the latest `dump_format_style.py` to generate `ClangFormatStyleOptions.rst`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141654/new/ https://reviews.llvm.org/D141654 Files:

[PATCH] D141708: [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141708/new/ https://reviews.llvm.org/D141708

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

MaskRay added a comment. This will cause warnings for the common usage related to bitmask macros/enumerators. #include int main(void) { unsigned char other = 0x81; other &= ~STO_AARCH64_VARIANT_PCS; return other; } (enumerator)

[PATCH] D141741: Add some subdirectories to the list of Abseil paths.

suertreus created this revision. suertreus added a reviewer: ymandel. suertreus added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. suertreus requested review of this revision. Herald added a subscriber:

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mati865 added a comment. I cannot speak much about LLVM tests but the code looks good for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141206/new/ https://reviews.llvm.org/D141206 ___ cfe-commits

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi created this revision. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously clang AST prints the following declaration: int fun_var_unused() { int x

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb4aa6c7a5f2: [cmake] Fix path to LLVMConfig.cmake for multi-config builds (authored by nhat-nguyen, committed by sebastian-ne). Repository: rG

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Removing a `CMAKE_*_DEFAULT_*` makes me happy:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141723/new/ https://reviews.llvm.org/D141723

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:17 + +static const llvm::StringSet<> ValueTraits = { +"alignment_of", carlosgalvezp wrote: > I'm guessing this

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 489147. paulkirth added a comment. Use more flexible whitespace matching Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/docs/ReleaseNotes.rst

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 489176. paulkirth added a comment. Rebase. - fix test cases - improve code swaping branch weights in instruction.cpp - clean up some dead metadata types left over from an old version of this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4052323 , @abhinavgaba wrote: >> In target data we already put a and b in use_device_addr. That indicates all >> use of a and b will be the corresponding device addresses. Therefore, in >> target directive,

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 489084. seanptmaher added a comment. Fix bug in -j implementation where proper waiting wasn't happening Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files:

[PATCH] D141193: [clang][Interp] Implement __builtin_assume

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM; I verified that constant expression evaluation ignores failed assumptions: http://eel.is/c++draft/expr.const#5.8 so this is in line with the C++2b feature. Repository:

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

HazardyKnusperkeks added reviewers: owenpan, HazardyKnusperkeks. HazardyKnusperkeks added a comment. Looks ok for me. Comment at: clang/include/clang/Format/Format.h:3500 +/// \code +///using std::c; +///using std::b; You should use the

[clang] ed01de6 - [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-01-13T14:07:29-06:00 New Revision: ed01de67433174d3157e9d239d59dd465d52c6a5 URL: https://github.com/llvm/llvm-project/commit/ed01de67433174d3157e9d239d59dd465d52c6a5 DIFF:

[PATCH] D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed01de674331: [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend (authored by domada). Herald added projects: clang, LLDB.

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

akyrtzi accepted this revision. akyrtzi added a comment. This revision is now accepted and ready to land. Is it impractical to add a test for this? Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

vitalybuka added a comment. https://lab.llvm.org/buildbot/#/builders/37/builds/19499 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 ___ cfe-commits mailing

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

owenpan added a comment. In D141654#4050852 , @rymiel wrote: > I'm not sure what the strict //benefit// of squishing the two options > together is, but I support it See D108752 and the added table in the summary.

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 updated this revision to Diff 489148. njames93 marked 6 inline comments as done. njames93 added a comment. Add IgnoreMacros options. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth marked 3 inline comments as done. paulkirth added a comment. @chapuni Thanks for the suggestion. It didn't occur to me that it could break the lines like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/

[PATCH] D141738: [WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Work in progress. Initial work on

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4053164 , @tra wrote: >> So are you suggesting that we complete the whole pipeline? So -S -emit-llvm >> gives host IR, but the device will go all the way to object? > > That would match my expectations and would solve

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added subscribers: dreachem, kkwli0. abhinavgaba added a comment. > In target data we already put a and b in use_device_addr. That indicates all > use of a and b will be the corresponding device addresses. Therefore, in > target directive, we should use is_device_address instead of

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

tra added a comment. Textual output for "-S -emit-llvm" is the canonical behavior, so I would prefer it working that way in as many cases as possible and only override it when necessary. Would it be possible to enforce binary IR generation in cases you need it? Or to prove that this is

[clang] 2e2aa8b - [clang-format] Fix a bug in DerivePointerAlignment fallback

Author: Owen Pan Date: 2023-01-13T12:58:33-08:00 New Revision: 2e2aa8bb6dea365e972528ad330f575b6b6e254b URL: https://github.com/llvm/llvm-project/commit/2e2aa8bb6dea365e972528ad330f575b6b6e254b DIFF: https://github.com/llvm/llvm-project/commit/2e2aa8bb6dea365e972528ad330f575b6b6e254b.diff

[PATCH] D141563: [clang-format] Fix a bug in DerivePointerAlignment fallback

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e2aa8bb6dea: [clang-format] Fix a bug in DerivePointerAlignment fallback (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

tschuett added a comment. Up right you will find `Edit Related Revisions...`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141723/new/ https://reviews.llvm.org/D141723 ___ cfe-commits mailing list

[PATCH] D141708: [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG52b9a3974244: [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141708/new/

[PATCH] D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1f4bfd2a8b0: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option. (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[clang] 52b9a39 - [OpenMP] Make `-fopenmp-target=` use the `nvptx-arch` tool

Author: Joseph Huber Date: 2023-01-13T16:52:06-06:00 New Revision: 52b9a3974244183806ba862e161670d79885443a URL: https://github.com/llvm/llvm-project/commit/52b9a3974244183806ba862e161670d79885443a DIFF: https://github.com/llvm/llvm-project/commit/52b9a3974244183806ba862e161670d79885443a.diff

<    1   2   3   >