[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 489468. pmatos added a comment. Updating tests after some changes to previous diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files:

[clang] 15ad244 - Add test for an invalid requirement in requires expr.

Author: Utkarsh Saxena Date: 2023-01-16T12:28:49+01:00 New Revision: 15ad244670a9ef0bf93b7c8a598586d4a841b197 URL: https://github.com/llvm/llvm-project/commit/15ad244670a9ef0bf93b7c8a598586d4a841b197 DIFF:

[PATCH] D141818: Add test for an invalid requirement in requires expr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15ad244670a9: Add test for an invalid requirement in requires expr. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141818/new/

[PATCH] D141297: [OpenCL] Allow undefining header-only features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa60b8f468119: [OpenCL] Allow undefining header-only features (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. Hi, Could anyone please review this diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 1506839 - [NFC] Fixed a typo in clang help docs

Author: Jolanta Jensen Date: 2023-01-16T11:50:58Z New Revision: 15068394858e2e27bf6893bd2adb04c74b384290 URL: https://github.com/llvm/llvm-project/commit/15068394858e2e27bf6893bd2adb04c74b384290 DIFF: https://github.com/llvm/llvm-project/commit/15068394858e2e27bf6893bd2adb04c74b384290.diff

[PATCH] D141507: [NFC] Fixed a typo in clang help docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG15068394858e: [NFC] Fixed a typo in clang help docs (authored by jolanta.jensen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141507/new/

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

barannikov88 updated this revision to Diff 489499. barannikov88 added a comment. Use `auto` instead of `const auto &` Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141788/new/ https://reviews.llvm.org/D141788 Files:

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve updated this revision to Diff 489502. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141381/new/ https://reviews.llvm.org/D141381 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 489510. TIFitis added a comment. Removed use of VariadicOfVariadic. Added new I64ArrayAttr for map_types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131915/new/ https://reviews.llvm.org/D131915 Files:

[PATCH] D133574: [C2x] reject type definitions in offsetof

fhahn added a comment. In D133574#4053647 , @aaron.ballman wrote: > I'll take care of fixing this up on Tuesday (Mon is a holiday here), but if > anyone wants to get to it sooner, what I plan to do is: > > - Add a new `Extension` diagnostic about

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

jmmartinez added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12581 + Mod, HandleTy, + /*isConstant=*/true, llvm::GlobalValue::InternalLinkage, + /*Initializer=*/RuntimeHandleInitializer, RuntimeHandleName, Just a cosmetical

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch adds a `IsDefaulted` field

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 added a comment. In D140423#4052442 , @aaron.ballman wrote: > In D140423#4052271 , @dblaikie > wrote: > >> In D140423#4051262 , >> @aaron.ballman wrote: >>

[clang] a60b8f4 - [OpenCL] Allow undefining header-only features

Author: Sven van Haastregt Date: 2023-01-16T11:32:12Z New Revision: a60b8f468119065f8a6cb4a16598263cb00de0b5 URL: https://github.com/llvm/llvm-project/commit/a60b8f468119065f8a6cb4a16598263cb00de0b5 DIFF: https://github.com/llvm/llvm-project/commit/a60b8f468119065f8a6cb4a16598263cb00de0b5.diff

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

nlopes added a comment. The issue is the function call, not the stores. Stores are valid as long as they are to local memory (stack or allocated by the function). Because of the call, you can't tag it as `memory(none)`. But you may be able to tag it with inaccessiblemem if the call is also

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. @jdoerfert can you please clarify, do you believe we are fine as-is, or need to change attributes we emit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski added inline comments. Herald added a subscriber: sunshaoce. Comment at: clang/include/clang/Driver/Options.td:5056-5060 +def fstack_arrays : Flag<["-"], "fstack-arrays">, Group, + HelpText<"Attempt to allocate array temporaries on the stack, no matter their size">;

[PATCH] D141827: [WIP][clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch allows clients who can't

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a subscriber: mgorny. fpetrogalli added a comment. FWIW, the change in this patch solves the issue with standalone build of `clang` reported in https://reviews.llvm.org/rGac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf. (FYI, @mgorny ) Repository: rG LLVM Github Monorepo

[clang] 9a3f3a9 - [clang][Interp][NFC] Use range for loop

Author: Timm Bäder Date: 2023-01-16T10:39:13+01:00 New Revision: 9a3f3a9a08d8ee37e6bf7f6f418c4c64bccee3f3 URL: https://github.com/llvm/llvm-project/commit/9a3f3a9a08d8ee37e6bf7f6f418c4c64bccee3f3 DIFF: https://github.com/llvm/llvm-project/commit/9a3f3a9a08d8ee37e6bf7f6f418c4c64bccee3f3.diff

[PATCH] D141831: [clang][Interp] Fix double-printing InterpFrame::describe()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We add the pointer we want to print itself to the

[PATCH] D141838: [clang-tidy] fix a false positive of `cppcoreguidelines-avoid-non-const-global-variables`

v1nh1shungry created this revision. v1nh1shungry added reviewers: carlosgalvezp, gribozavr2. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project:

[PATCH] D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast

mgehre added a comment. In D24888#4025382 , @bam wrote: > I'm sorry, could we bring it to the finish line? > It's a pity the standard C++ Core Guidelines rule suppression syntax is still > not supported, as Clang-tidy is one of the main tools supporting

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 489520. pmatos marked 7 inline comments as done. pmatos added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files:

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. I feel like the latest patch addresses all concerns until now. What do you think? Comment at: clang/include/clang/Basic/WebAssemblyReferenceTypes.def:16 +// +// - Name is the name of the builtin type. MangledName is the mangled name. +//

[PATCH] D141056: [SVE][CGBuiltins] Remove need for instcombine from ACLE tests.

dmgreen added a comment. I removed -O1 from clang sve tests a while ago. The intent was always to remove instcombine and tailcallelim too, but I never got around to it. Feel free to remove -O1 from the other sve2 tests too, they ideally shouldn't test the entire pipeline from clang.

[PATCH] D141670: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

hokein updated this revision to Diff 489448. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141670/new/ https://reviews.llvm.org/D141670 Files:

[PATCH] D140377: [clang][Interp] Compound assign operators for FP values

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140377/new/ https://reviews.llvm.org/D140377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. This review belongs to a series of patches. I am planning to land it towards the end of next week, so that it's ready for the next release branching in February. If you have any more remarks, please let me know soon. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 489515. TIFitis added a comment. Minor indentation changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131915/new/ https://reviews.llvm.org/D131915 Files: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td

[PATCH] D141716: [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:792 + // fields are printed. + llvm::dbgs() << "DeclToLoc:\n"; + for (auto [D, L] : DeclToLoc) Shouldn't this be `OS`? Same for

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141654/new/ https://reviews.llvm.org/D141654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141698: doc: Rewrite opening paragraph of CFI Design Doc

1c3t3a added a comment. Hi @pcc and @sunshaoce, I picked you as reviewers since you recently committed to the file. Please feel free to re-route this patch to the correct reviewer :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141698/new/

[clang] 046a991 - Add Release Notes and Doc for -fmodule-output

Author: Chuanqi Xu Date: 2023-01-16T17:01:41+08:00 New Revision: 046a9910c31e6eeb04f54f59574c74773292d3f0 URL: https://github.com/llvm/llvm-project/commit/046a9910c31e6eeb04f54f59574c74773292d3f0 DIFF: https://github.com/llvm/llvm-project/commit/046a9910c31e6eeb04f54f59574c74773292d3f0.diff

[clang-tools-extra] f4a7448 - [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

Author: Haojian Wu Date: 2023-01-16T10:09:18+01:00 New Revision: f4a744865349ed3c5b069ce39b0abcb5f0130fd3 URL: https://github.com/llvm/llvm-project/commit/f4a744865349ed3c5b069ce39b0abcb5f0130fd3 DIFF: https://github.com/llvm/llvm-project/commit/f4a744865349ed3c5b069ce39b0abcb5f0130fd3.diff

[PATCH] D141670: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4a744865349: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers. (authored by hokein). Changed prior to commit:

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 489484. tblah marked 6 inline comments as done. tblah added a comment. Update to address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://reviews.llvm.org/D140972 Files:

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:159 inline void createDefaultFIROptimizerPassPipeline( -mlir::PassManager , llvm::OptimizationLevel optLevel = defaultOptLevel) { +mlir::PassManager , bool stackArrays = false,

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

barannikov88 added a comment. In D141788#4055263 , @MaskRay wrote: > non-reference `auto` shall work better in these cases. Not sure why? Won't Data be copied every iteration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite created this revision. Herald added a project: All. argentite added reviewers: v.g.vassilev, lhames, sgraenitz. argentite published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit adds the %lib command to load a dynamic

[PATCH] D141818: Add test for an invalid requirement in requires expr.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141818/new/ https://reviews.llvm.org/D141818

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { browneee wrote: > The `s_label` represents the taint label

[clang] 596f76a - Revert "[C2x] reject type definitions in offsetof"

Author: Yingchi Long Date: 2023-01-16T16:52:50+08:00 New Revision: 596f76a799c933927eec4d8ac8a83c44efff9854 URL: https://github.com/llvm/llvm-project/commit/596f76a799c933927eec4d8ac8a83c44efff9854 DIFF: https://github.com/llvm/llvm-project/commit/596f76a799c933927eec4d8ac8a83c44efff9854.diff

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a0e0c226018: [NFC] Use `llvm::enumerate` in llvm/unittests/Object (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 8a0e0c2 - [NFC] Use `llvm::enumerate` in llvm/unittests/Object

Author: Sergei Barannikov Date: 2023-01-16T15:59:31+03:00 New Revision: 8a0e0c226018a77ea148e128c97c2592e6f25416 URL: https://github.com/llvm/llvm-project/commit/8a0e0c226018a77ea148e128c97c2592e6f25416 DIFF:

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added a comment. On Mon, Jan 16, 2023 Roman Lebedev wrote: > Reminder to please always mention the reason for the revert/recommit in the > commit message. Thanks! This change needs to be fixed up (see comments above). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f2d301f - Revert "[codegen] Store address of indirect arguments on the stack"

Author: Felipe de Azevedo Piovezan Date: 2023-01-16T13:05:22-03:00 New Revision: f2d301fe82869f881b86b51da7b4752972c66707 URL: https://github.com/llvm/llvm-project/commit/f2d301fe82869f881b86b51da7b4752972c66707 DIFF:

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. @barannikov88 - Imam stuck with an incomplete explanation: The issue raised by @mgorny is about stand-alone builds. In this build configuration, clang is built separately from LLVM, which is first

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for making the changes and for your patience. Please wait a couple of days to give other reviewers a chance to have a look before submitting. Could you

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Yeah, otherwise I suppose there will be some errors when compiling OpenMP program when there is no CUDA installed. Comment at:

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:60 +// Checks if T1 is convertible to T2. +static bool isMultiLevelConvertiblePointer(QualType

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056612 , @barannikov88 wrote: > In D141581#4056503 , @fpetrogalli > wrote: > >> This is because the sources of clangBasic and clangDriver might be compiled >> before

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

Jake-Egan added a comment. Hi, this new test fails on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/6/logs/FAIL__Clang__module-output_cppm Could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/

[PATCH] D141432: Add two additional float8 types to MLIR and APFloat.

krzysz00 added a comment. Herald added a reviewer: ftynse. I think we have dueling patches that we should reconcile. I've put together https://reviews.llvm.org/D141863 to do the same thing. (it's just now posted because we were waiting to talk to y'all over at GraphCore to finalize naming,

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler added a comment. In D139926#4056585 , @kadircet wrote: > Especially as this comes as two different `HighlightingKind`s and they're > likely to get colored differently, and having your matching brackets in > different colors is quite annoying.

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056492 , @tschuett wrote: > I though Clang Basic is a leaf library and must not depend on anything. I wasn't aware of this requirement. As of https://reviews.llvm.org/D137517 it depends on some auto-generated

[PATCH] D141586: [include-mapping] Replace the stdlib symbol maps with the newest official version from https://en.cppreference.com/w/File:html_book_20190607.zip.

VitaNuo abandoned this revision. VitaNuo added a comment. Abandoning since we will eventually parse a newer version of the archive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141586/new/ https://reviews.llvm.org/D141586

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. In hindsight, this should have been obvious. While SROA will not touch this: define @foo(ptr %arg) { call void @llvm.dbg.declare(%arg, [...], metadata !DIExpression()) It completely destroys the debug information provided by: define @foo(ptr %arg) {

[PATCH] D141859: [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield, gregrodgers. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added

[PATCH] D141547: Fix format for `case` in .proto files

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaf393da1823: Fix format for `case` in .proto files (authored by fowles, committed by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/

[clang] 7e4447a - [codegen] Store address of indirect arguments on the stack

Author: Felipe de Azevedo Piovezan Date: 2023-01-16T11:14:55-03:00 New Revision: 7e4447a17db4a070f01c8f8a87505a4b2a1b0e3a URL: https://github.com/llvm/llvm-project/commit/7e4447a17db4a070f01c8f8a87505a4b2a1b0e3a DIFF:

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e4447a17db4: [codegen] Store address of indirect arguments on the stack (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES

Re: [clang] 596f76a - Revert "[C2x] reject type definitions in offsetof"

Reminder to please always mention the reason for the revert/recommit in the commit message. On Mon, Jan 16, 2023 at 11:53 AM Yingchi Long via cfe-commits wrote: > > > Author: Yingchi Long > Date: 2023-01-16T16:52:50+08:00 > New Revision: 596f76a799c933927eec4d8ac8a83c44efff9854 > > URL: >

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 489552. pmatos added a comment. Add new Attr Subject Function Pointer for __funcref attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files:

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056464 , @lebedev.ri wrote: > Why is it not sufficient to link to `RISCVTargetParserTableGen`, but is > sufficient to link to `LLVMTargetParser`? This is because the sources of clangBasic and clangDriver might

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

kadircet added a comment. > Note that we use this information to *animate* the matching tokens, i.e. when > the cursor is on one of them, both it and its counterpart get a special > highlighting. That's why it's so important that the language server > guarantees they always come in pairs. Oh

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141855 Files:

[PATCH] D136554: Implement CWG2631

cebowleratibm added a comment. I've reduced a regression on: commit ca619613801233ef2def8c3cc7d311d5ed0033cb (HEAD, refs/bisect/bad) Author: Corentin Jabot Date: Sun Oct 23 17:32:58 2022 +0200 template int f(T) {

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is now relevant because we generate pointers

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

lebedev.ri added a comment. Why is it not sufficient to link to `RISCVTargetParserTableGen`, but is sufficient to link to `LLVMTargetParser`? Does `RISCVTargetParserTableGen` itself not link to `LLVMTargetParser`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] caf393d - Fix format for `case` in .proto files

Author: Matt Kulukundis Date: 2023-01-16T17:43:50Z New Revision: caf393da1823d50852f51604b3793e8f4a23c140 URL: https://github.com/llvm/llvm-project/commit/caf393da1823d50852f51604b3793e8f4a23c140 DIFF: https://github.com/llvm/llvm-project/commit/caf393da1823d50852f51604b3793e8f4a23c140.diff

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. clangBasic and clangDriver already have a dependency on TargetParser (see LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not enough? Will it build if you just remove the additional dependency? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

xazax.hun added a comment. Also, could you open a bug report about the strange exception behavior on GitHub? Hopefully someone working on conformance can take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. I made the phases always go to `Assemble` but it didn't make a difference. We still get the textual IR here without the exception I added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141717/new/

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. There is a real regression in `lldb/test/API/functionalities/param_entry_vals/basic_entry_values/` when this is compiled with O2 : __attribute__((noinline)) void func15(StructPassedViaPointerToTemporaryCopy S) It seems

[clang] 0f42221 - [AArch64] Move default extensions from clang Driver to TargetParser

Author: David Green Date: 2023-01-16T16:58:18Z New Revision: 0f422215ac63da4cb610a21998a2d24c11703fbf URL: https://github.com/llvm/llvm-project/commit/0f422215ac63da4cb610a21998a2d24c11703fbf DIFF: https://github.com/llvm/llvm-project/commit/0f422215ac63da4cb610a21998a2d24c11703fbf.diff LOG:

[PATCH] D141518: [AArch64] Move default extensions from clang Driver to TargetParser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f422215ac63: [AArch64] Move default extensions from clang Driver to TargetParser (authored by dmgreen). Herald added a project: clang. Herald added

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jholewinski.

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu updated this revision to Diff 489587. steven_wu added a comment. Minor touch up on the test case. Also add some comments in test to explain what is being tested. I don't measure any performance regression from `-fsyntax-only` on Foundation.h but if there are some other performance

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. Actually, sorting in `numberAnonymousDeclsWithin` doesn't work for some reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/ https://reviews.llvm.org/D141625 ___

Re: [PATCH] D136554: Implement CWG2631

Yes please! However the warning looks correct to me in that case. A constructs x which constructs A etc. On Mon, Jan 16, 2023, 18:00 Chris Bowler via Phabricator < revi...@reviews.llvm.org> wrote: > cebowleratibm added a comment. > > I've reduced a regression on: > > commit

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 updated this revision to Diff 489554. jhuber6 added a comment. Updating. Used a different method to determine if we need to use `.cubin` or `.o`. It's a little ugly but I don't think there's a better way to do it. Also I just realized that if this goes through I could probably heavily

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

kadircet added a comment. Sorry for missing this one, apparently I've already started writing an answer but got context switching and forgot about it. > This is needed for clients that would like to visualize matching > opening and closing angle brackets, which can be valuable in non-trivial >

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} erichkeane wrote: > pmatos wrote: > > erichkeane wrote: > > > Note

Re: [clang] f2d301f - Revert "[codegen] Store address of indirect arguments on the stack"

Reminder to please always mention the reason for the revert/recommit in the commit message. On Mon, Jan 16, 2023 at 7:05 PM Felipe de Azevedo Piovezan via cfe-commits wrote: > > > Author: Felipe de Azevedo Piovezan > Date: 2023-01-16T13:05:22-03:00 > New Revision:

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. Windows failures happening in Flang's MLIR stage, likely unrelated to this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141381/new/ https://reviews.llvm.org/D141381 ___

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. @jrtc27, @thakis, @craig.topper - gentle ping, it would be great if I could unlock @mgorny with this patch for the issue they are seeing at https://reviews.llvm.org/rGac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf Francesco Repository: rG LLVM Github Monorepo

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tschuett added a comment. I though Clang Basic is a leaf library and must not depend on anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581 ___

[PATCH] D141547: Fix format for `case` in .proto files

krasimir accepted this revision. krasimir added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/ https://reviews.llvm.org/D141547 ___ cfe-commits mailing list

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. In D141581#4056503 , @fpetrogalli wrote: > This is because the sources of clangBasic and clangDriver might be compiled > before LLVMTargetParser is ready. ... > Therefore, if we say that clangDriver and clangBasic depend

[PATCH] D141838: [clang-tidy] fix a false positive of `cppcoreguidelines-avoid-non-const-global-variables`

njames93 added a comment. I'm not convinced this is the correct fix. The guildline states that tools should flag all variables declared at global or namespace scope. Therefore we shouldn't be

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

tbaeder updated this revision to Diff 489581. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141858/new/ https://reviews.llvm.org/D141858 Files: clang/lib/AST/Interp/Pointer.cpp Index: clang/lib/AST/Interp/Pointer.cpp

[PATCH] D141859: [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Yes, ok. Not thrilled about the copy from openmp but we can fix that as soon as we agree on a subdir to put code shared between llvm/clang/openmp and that has been tricky to

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

xingxue created this revision. xingxue added reviewers: daltenty, cebowleratibm, kkwli0. xingxue added a project: LLVM. Herald added subscribers: guansong, yaxunl. Herald added a project: All. xingxue requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay.

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. In D141581#4056671 , @fpetrogalli wrote: > @barannikov88 - I am stuck with an incomplete explanation: Ah, I see. The key point is that standalone build that depends on //installed// LLVM. RISCVTargetParser is a custom

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM from the libc++ side of things % nit. I think @aaron.ballman should take another look at the Clang changes. Comment at: libcxx/utils/generate_header_tests.py:22 +

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4056971 , @yaxunl wrote: > The intention of -emit-llvm -S is usually to get LLVM assembly for all > targets for inspection or modification. HIP emits a bundled LLVM assembly in > textual format in this case. Users

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa288d7f93770: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides (authored by jloser). Changed prior to commit:

  1   2   >