[clang] 435225c - [clang][Interp][NFC] Remove an unnecessary isArray() check

Author: Timm Bäder Date: 2023-01-27T09:00:51+01:00 New Revision: 435225c6e2f860ecc53fcd65e193f832569d090e URL: https://github.com/llvm/llvm-project/commit/435225c6e2f860ecc53fcd65e193f832569d090e DIFF: https://github.com/llvm/llvm-project/commit/435225c6e2f860ecc53fcd65e193f832569d090e.diff

[clang] f2f8c25 - [clang][Interp][NFC] Print parent class name of methods

Author: Timm Bäder Date: 2023-01-27T09:04:14+01:00 New Revision: f2f8c25540753a8be375fc90ad703d4101562342 URL: https://github.com/llvm/llvm-project/commit/f2f8c25540753a8be375fc90ad703d4101562342 DIFF: https://github.com/llvm/llvm-project/commit/f2f8c25540753a8be375fc90ad703d4101562342.diff

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4084801 , @nridge wrote: > Function calls are still missing some cases: > > I would have expected these to be handled by VisitDeclRefExpr(), but they aren't. Any idea? Repository: rG LLVM Github Monorepo

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 492670. ckandeler marked 3 inline comments as done. ckandeler added a comment. Handled more cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

bryanpkc updated this revision to Diff 492679. bryanpkc retitled this revision from "[Clang][AArch64] Add SME ldr and str intrinsic" to "[Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)". bryanpkc edited the summary of this revision. bryanpkc added a comment. Rebased and

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

awarzynski added a comment. Driver changes LGTM, thanks! I will defer to others for changes in other areas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___ cfe-commits mailing list

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

bryanpkc created this revision. bryanpkc added reviewers: sdesmalen, rsandifo-arm, david-arm. Herald added a subscriber: kristof.beyls. Herald added a project: All. bryanpkc requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. In D139926#4084854 , @ckandeler wrote: > I would have expected these to be handled by VisitDeclRefExpr(), but they > aren't. Any idea? There are two other expression types, `DependentScopeDeclRefExpr` and

[PATCH] D142697: [WIP][3/N][Clang][RISCV] Add `__riscv_` for overloaded intrinsics

eopXD created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:1026 +concept $Concept_decl[[C2]] = true; +template $Bracket[[<]]C2$Bracket[[<]]int$Bracket[[>]] $TemplateParameter_def[[A]]$Bracket[[>]] +

[PATCH] D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length

bryanpkc updated this revision to Diff 492681. bryanpkc retitled this revision from "[Clang][AArch64] Add SME svcntsb/h/w/d C intrinsics" to "[Clang][AArch64][SME] Add intrinsics for reading streaming vector length". bryanpkc edited the summary of this revision. bryanpkc added a comment.

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

tmatheson added a comment. This patch has made it considerably harder to understand what is going on in the TargetParser. If you get a chance, please could you add some clarifying comments and tidy-ups. I appreciate that a lot of this is following the lead of the pre-existing TargetParser

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra added a comment. Limit the description in the release notes to one sentence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/ https://reviews.llvm.org/D142592 ___ cfe-commits

[PATCH] D134681: [Clang][AArch64][SME] Add outer product intrinsics

bryanpkc updated this revision to Diff 492693. bryanpkc retitled this revision from "[Clang][AArch64] Add SME outer product intrinsics" to "[Clang][AArch64][SME] Add outer product intrinsics". bryanpkc edited the summary of this revision. bryanpkc added a comment. Rebased and cleaned up the

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 492665. junaire added a comment. Herald added a subscriber: ChuanqiXu. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra updated this revision to Diff 492661. sivachandra marked an inline comment as done. sivachandra added a comment. Limit the description in the release notes to one sentence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. I figured I might as well look through the AST API for classes with getLAngleLoc/getRAngleLoc methods. It looks like we've got almost all of them (including the ones mentioned in recent comments) except: - OverloadExpr - DependentTemplateSpecializationTypeLoc -

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. Two more cases I found: template concept C = true; template A> // <-- (inner pair) class B {}; This is a `TypeConstraint`, but RecursiveASTVisitor is lacking a Visit() method for it, so I think you'll need to override `TraverseTypeConstraint()` instead

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:641 + VisitClassTemplateSpecializationDecl(ClassTemplateSpecializationDecl *D) { +for (unsigned i = 0; i < D->getNumTemplateParameterLists(); ++i) { + if (auto *TPL =

[PATCH] D142644: [WIP][2/N][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics

eopXD updated this revision to Diff 492663. eopXD added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142644/new/ https://reviews.llvm.org/D142644 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4084868 , @nridge wrote: > I figured I might as well look through the AST API for classes with > getLAngleLoc/getRAngleLoc methods. > > It looks like we've got almost all of them (including the ones mentioned in >

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

bryanpkc updated this revision to Diff 492680. bryanpkc added a comment. Update patch with more context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files:

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 492684. paperchalice added a comment. Use `LLVM_LIBRARY_OUTPUT_INTDIR`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 Files:

[PATCH] D142694: [clang][Interp] Only generate disassembly in debug builds

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the current set of opcodes, this saves 3460

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. In D139926#4084856 , @nridge wrote: > In D139926#4084854 , @ckandeler > wrote: > >> I would have expected these to be handled by VisitDeclRefExpr(), but they >> aren't. Any idea? > >

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

bryanpkc updated this revision to Diff 492692. bryanpkc edited the summary of this revision. bryanpkc added a comment. Added `_m` suffix to the intrinsics as required by the amendment in https://github.com/ARM-software/acle/pull/218. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142607: [clang][ASTImporter] Handle UsingType in friend declarations.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142607/new/ https://reviews.llvm.org/D142607

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139454/new/ https://reviews.llvm.org/D139454

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. Function calls are still missing some cases: template void free(); template struct A { template void mem(); }; void foo() { A a; a.mem(); // <-- } template void bar() { free(); // <-- A a; a.mem(); // <--

[PATCH] D142316: [clang] Add test for CWG2396

Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } shafik wrote:

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

bryanpkc updated this revision to Diff 492682. bryanpkc retitled this revision from "[Clang][AArch64] Add SME svaddha and svaddva intrinsics" to "[Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile". bryanpkc edited the summary of this revision. bryanpkc added a comment.

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. I am not an expert in the frontend or ASTContext area, but I think that if a builtin declaration is created (`ASTContext::getBuiltinVaListDecl`) the identifier name for it should not be loaded from an external source (in function `IdentifierTable::get`). This load of

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein added a comment. I haven't read though all the change of `_ParseSymbolPage`, left some comments. I think we need to update proper tests in `include-mapping/test.py` as we has changed the parser. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:1162

[PATCH] D142717: [clang] Mark CWG2165 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : "CWG2165 is resolved by removing the

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4085681 , @aaron.ballman wrote: > In D133574#4085472 , @aaron.ballman > wrote: > >> In D133574#4085372 , >> @aaron.ballman

[clang] 7d4ce70 - [LinkerWrapper][NFC] Remove unused options

Author: Joseph Huber Date: 2023-01-27T10:49:31-06:00 New Revision: 7d4ce7050505baadd0d40c30d0726a136a64c717 URL: https://github.com/llvm/llvm-project/commit/7d4ce7050505baadd0d40c30d0726a136a64c717 DIFF: https://github.com/llvm/llvm-project/commit/7d4ce7050505baadd0d40c30d0726a136a64c717.diff

[PATCH] D142742: Generate ImplicitNullDerefEvent from CallAndMessageChecker

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this change, the following code

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware added a comment. In D142673#4086018 , @carlosgalvezp wrote: > Note: I do not have possibility to add code comments - is there some too > strict permissions set for this patch? It has not happened to other patches. I accidentally set

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} v1nh1shungry wrote: > kadircet wrote: > > v1nh1shungry

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

Michael137 updated this revision to Diff 492728. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142713/new/ https://reviews.llvm.org/D142713 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

Michael137 created this revision. Michael137 added reviewers: martong, aprantl. Herald added a subscriber: rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald

[PATCH] D142228: [clangd] Disable tests that are incompatible with Windows

kadircet added a comment. thanks this makes sense! we were filtering on `target_triple` before, which is not right, especially when host triple is not the default target. as a follow up i'll drop all the `target={{...}}` conditions as we should actually be able to run these tests even when

[PATCH] D142734: Updated CheckAddressOfOperand

chrisbazley created this revision. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The semantics of the unary & operator are modified so that if its operand has type "type" then its result has type

[PATCH] D141827: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 added a comment. This caused some LLDB test failures for the `import-std-module` setting. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ We construct `TemplateArgument`s manually in the `CxxModuleHandler`. Fix is in-flight. Repository: rG LLVM Github Monorepo

[PATCH] D142703: [ARM] Allow selecting hard-float ABI in integer-only MVE.

simon_tatham retitled this revision from "[ARM] Allow selecting the hard float ABI in integer-only MVE." to "[ARM] Allow selecting hard-float ABI in integer-only MVE.". simon_tatham edited the summary of this revision. simon_tatham updated this revision to Diff 492722. simon_tatham added a

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:205 SYMBOL(basic_syncbuf, std::, ) SYMBOL(begin, std::, ) SYMBOL(bernoulli_distribution, std::, ) i think we should have other providers here,

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:524 -void transferSwap(const StorageLocation , - const StorageLocation , -

[clang] 8d4b097 - Correct the link to the latest C DR status page for C11 and C17

Author: Aaron Ballman Date: 2023-01-27T11:19:12-05:00 New Revision: 8d4b0976d5fe92a51f43ccfea50d1f10c4c77e5d URL: https://github.com/llvm/llvm-project/commit/8d4b0976d5fe92a51f43ccfea50d1f10c4c77e5d DIFF: https://github.com/llvm/llvm-project/commit/8d4b0976d5fe92a51f43ccfea50d1f10c4c77e5d.diff

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492774. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. No new tests in this version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/

[PATCH] D142736: Add QualType::getNullability for _Optional

chrisbazley created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. chrisbazley requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. The purpose of this change is to ensure that a

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

carlosgalvezp added a comment. Note: I do not have possibility to add code comments - is there some too strict permissions set for this patch? It has not happened to other patches. Review comment: I think the design choice in clang-tidy is that checks from different modules should not depend

[PATCH] D142741: Fix ProgramState::isNull for non-region symbols

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This method was good at telling that a

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel created this revision. ymandel added reviewers: sgatev, gribozavr2, xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the interpretation of

[PATCH] D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, clang-language-wg, jyknight. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was a mistake from

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4085472 , @aaron.ballman wrote: > In D133574#4085372 , @aaron.ballman > wrote: > >> So by my understanding, my original changes removing the extension warning >> (in

[PATCH] D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG852bb68ddb2b: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser (authored by pratlucas). Repository: rG LLVM Github

[clang] 852bb68 - [NFC][AArch64] Get extension strings directly from ArchInfo in target parser

Author: Lucas Prates Date: 2023-01-27T15:17:21Z New Revision: 852bb68ddb2bf9c91421a6ce59a07a6f44d20641 URL: https://github.com/llvm/llvm-project/commit/852bb68ddb2bf9c91421a6ce59a07a6f44d20641 DIFF: https://github.com/llvm/llvm-project/commit/852bb68ddb2bf9c91421a6ce59a07a6f44d20641.diff LOG:

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

rmaz created this revision. Herald added a subscriber: arphaman. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor a Module's TopHeaders to use FileEntryRef. This will keep the paths serialized in a

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

iains planned changes to this revision. iains added a comment. this is necessary, but not sufficient (I need to make additions) .. no need to review yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142704/new/ https://reviews.llvm.org/D142704

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

carlosgalvezp added a comment. Also, in general the design choice is that checks should be independent and authors should not need to care about whether they conflict with other checks. In this particular case, if both checks are providing different results, users should choose one and disable

[PATCH] D142737: Updated getNullabilityAnnotation for checkers

chrisbazley created this revision. Herald added subscribers: steakhal, martong, JDevlieghere. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NullabilityChecker and

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. I have a fix for the AArch64 problems in test `ImportCorrectTemplatedDecl`, dcl-58-cpp, and the "Declaration not emitted!" assertion. I can not find at which tests the `error: reference to 'std' is ambiguous` appears. Probably the AArch64 (and Arm) tests could be run

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pratlucas marked an inline comment as done. Closed by commit rG9ea00fc74c3c: [NFC][AArch64] Use optional returns in target parser instead of invalid… (authored by

[clang] 9ea00fc - [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

Author: Lucas Prates Date: 2023-01-27T12:35:58Z New Revision: 9ea00fc74c3c0032ff2d9a6774e13449a30e4549 URL: https://github.com/llvm/llvm-project/commit/9ea00fc74c3c0032ff2d9a6774e13449a30e4549 DIFF: https://github.com/llvm/llvm-project/commit/9ea00fc74c3c0032ff2d9a6774e13449a30e4549.diff LOG:

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0753cf2caca7: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects (authored by pratlucas). Repository: rG LLVM Github

[clang] 0753cf2 - [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

Author: Lucas Prates Date: 2023-01-27T12:37:18Z New Revision: 0753cf2caca707e3957a70c9756b7f1d42fab2af URL: https://github.com/llvm/llvm-project/commit/0753cf2caca707e3957a70c9756b7f1d42fab2af DIFF: https://github.com/llvm/llvm-project/commit/0753cf2caca707e3957a70c9756b7f1d42fab2af.diff LOG:

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4085372 , @aaron.ballman wrote: > So by my understanding, my original changes removing the extension warning > (in D40267 ) were jumping the gun because > the committee never

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd194d817b0b2: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import (authored by Michael137). Repository: rG LLVM Github

[clang] d194d81 - [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

Author: Michael Buch Date: 2023-01-27T16:39:17Z New Revision: d194d817b0b29c6e244d01cf7b836b9e4bbe2794 URL: https://github.com/llvm/llvm-project/commit/d194d817b0b29c6e244d01cf7b836b9e4bbe2794 DIFF: https://github.com/llvm/llvm-project/commit/d194d817b0b29c6e244d01cf7b836b9e4bbe2794.diff LOG:

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492779. Mordante added a comment. Rebased and improve fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: clang/lib/run_the_clang_CI

[PATCH] D142740: [WIP] [WebAssembly] Enable MemorySanitizer for emscripten

sbc100 created this revision. Herald added subscribers: Enna1, pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, aheejin. Herald added

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

enh added a comment. In D137268#4069992 , @zatrazz wrote: > Could you check if this fixes your issue? yes, thanks... the person doing the llvm update tried it and reports that it works. here's the patch against our old copy of glibc:

[PATCH] D142006: [mlir][bufferization] Fix getAliasingOpOperand/OpResult for non-bufferizable ops

springerm updated this revision to Diff 492765. springerm added a comment. Herald added a subscriber: thopre. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142006/new/ https://reviews.llvm.org/D142006 Files:

[PATCH] D142733: Add _Optional as fast qualifier

chrisbazley created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! AFAICS I've addressed all of them. Re tests, thanks for the reminder @hokein! I've fixed them now, everything is green. Comment at:

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:524 -void transferSwap(const StorageLocation , - const StorageLocation , - LatticeTransferState ) { - auto *OptionalVal1 =

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492775. VitaNuo added a comment. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

iains created this revision. Herald added a project: All. iains added reviewers: dblaikie, ChuanqiXu. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. @dblaikie - I suspect that this would be useful on the

[clang] 0a51bc7 - Add clang_CXXMethod_isExplicit to libclang

Author: Luca Di Sera Date: 2023-01-27T13:23:41+01:00 New Revision: 0a51bc731bcc2c27e4fe97957a83642d93d989be URL: https://github.com/llvm/llvm-project/commit/0a51bc731bcc2c27e4fe97957a83642d93d989be DIFF: https://github.com/llvm/llvm-project/commit/0a51bc731bcc2c27e4fe97957a83642d93d989be.diff

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a51bc731bcc: Add clang_CXXMethod_isExplicit to libclang (authored by Luca Di Sera luca.dis...@qt.io). Changed prior to commit:

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4084215 , @stilor wrote: > In D133574#4083742 , @aaron.ballman > wrote: > >> In D133574#4083724 , @asbirlea >> wrote: >> >>>

[clang] 63d6b8b - Stop diagnosing member and array access in offsetof as an extension

Author: Aaron Ballman Date: 2023-01-27T11:01:58-05:00 New Revision: 63d6b8be6cf248a1a8800d85a11be469c6e2 URL: https://github.com/llvm/llvm-project/commit/63d6b8be6cf248a1a8800d85a11be469c6e2 DIFF: https://github.com/llvm/llvm-project/commit/63d6b8be6cf248a1a8800d85a11be469c6e2.diff

[PATCH] D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the quick review, I've landed this in 63d6b8be6cf248a1a8800d85a11be469c6e2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142738: Warn if _Optional used at top-level of decl

chrisbazley created this revision. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Parameter declarations using [] syntax can be written more naturally using an _Optional qualifier than using

[PATCH] D142739: Standalone checker for use of _Optional qualifier

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This checker tries to

[PATCH] D142565: [clang-tidy] Fix warning in portability-simd-intrinsics

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142565/new/ https://reviews.llvm.org/D142565

[PATCH] D142743: Fix nullability checking of top-level functions

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The existing nullability checker is so

[PATCH] D142744: Re-analyze functions as top-level

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a function with a _Nullable parameter

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

jansvoboda11 added inline comments. Comment at: clang/lib/Basic/Module.cpp:273 +void Module::addTopHeader(OptionalFileEntryRef File) { assert(File); + TopHeaders.insert(*File); If we assert that `File` is not empty right away, why take

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak updated this revision to Diff 492860. ahatanak added a comment. Fix a few typos that were causing compile errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/ https://reviews.llvm.org/D142584 Files:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4216 + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil && !Args.getLastArg(options::OPT_dxc_disable_validation)) { +// Only

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 marked 8 inline comments as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:637 -static Strategy -getNaiveStrategy(const llvm::SmallVectorImpl ) { NoQ wrote: > Hmm, did this need to be moved? I don't

[PATCH] D142757: [clang][driver] Do not warn about position of `/clang:-xc` in cl mode

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. In CL mode values of `/clang:` arguments end up at the end of arguments list which makes the warning always

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4086450 , @stilor wrote: >>> I posted https://reviews.llvm.org/D142723 to address this. >> >> and 63d6b8be6cf248a1a8800d85a11be469c6e2 >>

[PATCH] D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension

stilor added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2389 const int ext1 = __builtin_offsetof(struct U { int i; }, i); // C extension - const int ext2 = __builtin_offsetof(struct S, t.f[1]); // C & C++ extension + const int ext2 =

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492834. Mordante added a comment. Removes uninteded include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: libcxx/include/module.modulemap.in

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

rmaz marked an inline comment as done. rmaz added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:663 Result->IsInferred = true; - Result->addTopHeader(File); + Result->addTopHeader(File->getLastRef()); jansvoboda11 wrote: > How much

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

kadircet added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:196 + "std::remove$": "algorithm", + "std::atomic.*": "atomic", + there's no variant of "std::atomic.*" called "atomic", in

[libclc] 409f42b - libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm

Author: Tom Stellard Date: 2023-01-27T10:50:29-08:00 New Revision: 409f42b10ac6dc1c6a4e68d20ccd3adf6770e238 URL: https://github.com/llvm/llvm-project/commit/409f42b10ac6dc1c6a4e68d20ccd3adf6770e238 DIFF: https://github.com/llvm/llvm-project/commit/409f42b10ac6dc1c6a4e68d20ccd3adf6770e238.diff

[clang] 4266756 - Fix recursive error for constraints depending on itself incorrectly

Author: Erich Keane Date: 2023-01-27T11:11:53-08:00 New Revision: 42667563721e139a93ab886119ea2780ebc3fecc URL: https://github.com/llvm/llvm-project/commit/42667563721e139a93ab886119ea2780ebc3fecc DIFF: https://github.com/llvm/llvm-project/commit/42667563721e139a93ab886119ea2780ebc3fecc.diff

  1   2   >