[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-01-27 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 492775. VitaNuo added a comment. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-01-27 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 492774. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. No new tests in this version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

2023-01-27 Thread Michael Buch via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd194d817b0b2: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import (authored by Michael137). Repository: rG LLVM Github

[clang] d194d81 - [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

2023-01-27 Thread Michael Buch via cfe-commits
Author: Michael Buch Date: 2023-01-27T16:39:17Z New Revision: d194d817b0b29c6e244d01cf7b836b9e4bbe2794 URL: https://github.com/llvm/llvm-project/commit/d194d817b0b29c6e244d01cf7b836b9e4bbe2794 DIFF: https://github.com/llvm/llvm-project/commit/d194d817b0b29c6e244d01cf7b836b9e4bbe2794.diff LOG:

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

2023-01-27 Thread Iain Sandoe via Phabricator via cfe-commits
iains planned changes to this revision. iains added a comment. this is necessary, but not sufficient (I need to make additions) .. no need to review yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142704/new/ https://reviews.llvm.org/D142704

[clang] 8d4b097 - Correct the link to the latest C DR status page for C11 and C17

2023-01-27 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-01-27T11:19:12-05:00 New Revision: 8d4b0976d5fe92a51f43ccfea50d1f10c4c77e5d URL: https://github.com/llvm/llvm-project/commit/8d4b0976d5fe92a51f43ccfea50d1f10c4c77e5d DIFF: https://github.com/llvm/llvm-project/commit/8d4b0976d5fe92a51f43ccfea50d1f10c4c77e5d.diff

[PATCH] D142006: [mlir][bufferization] Fix getAliasingOpOperand/OpResult for non-bufferizable ops

2023-01-27 Thread Matthias Springer via Phabricator via cfe-commits
springerm updated this revision to Diff 492765. springerm added a comment. Herald added a subscriber: thopre. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142006/new/ https://reviews.llvm.org/D142006 Files:

[PATCH] D133574: [C2x] reject type definitions in offsetof

2023-01-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D133574#4085681 , @aaron.ballman wrote: > In D133574#4085472 , @aaron.ballman > wrote: > >> In D133574#4085372 , >> @aaron.ballman

[PATCH] D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension

2023-01-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the quick review, I've landed this in 63d6b8be6cf248a1a8800d85a11be469c6e2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 63d6b8b - Stop diagnosing member and array access in offsetof as an extension

2023-01-27 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-01-27T11:01:58-05:00 New Revision: 63d6b8be6cf248a1a8800d85a11be469c6e2 URL: https://github.com/llvm/llvm-project/commit/63d6b8be6cf248a1a8800d85a11be469c6e2 DIFF: https://github.com/llvm/llvm-project/commit/63d6b8be6cf248a1a8800d85a11be469c6e2.diff

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

2023-01-27 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:524 -void transferSwap(const StorageLocation , - const StorageLocation , -

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

2023-01-27 Thread Elliott Hughes via Phabricator via cfe-commits
enh added a comment. In D137268#4069992 , @zatrazz wrote: > Could you check if this fixes your issue? yes, thanks... the person doing the llvm update tried it and reports that it works. here's the patch against our old copy of glibc:

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

2023-01-27 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:524 -void transferSwap(const StorageLocation , - const StorageLocation , - LatticeTransferState ) { - auto *OptionalVal1 =

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

2023-01-27 Thread Richard Howell via Phabricator via cfe-commits
rmaz created this revision. Herald added a subscriber: arphaman. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor a Module's TopHeaders to use FileEntryRef. This will keep the paths serialized in a

[PATCH] D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser

2023-01-27 Thread Lucas Prates via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG852bb68ddb2b: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser (authored by pratlucas). Repository: rG LLVM Github

[clang] 852bb68 - [NFC][AArch64] Get extension strings directly from ArchInfo in target parser

2023-01-27 Thread Lucas Prates via cfe-commits
Author: Lucas Prates Date: 2023-01-27T15:17:21Z New Revision: 852bb68ddb2bf9c91421a6ce59a07a6f44d20641 URL: https://github.com/llvm/llvm-project/commit/852bb68ddb2bf9c91421a6ce59a07a6f44d20641 DIFF: https://github.com/llvm/llvm-project/commit/852bb68ddb2bf9c91421a6ce59a07a6f44d20641.diff LOG:

[PATCH] D133574: [C2x] reject type definitions in offsetof

2023-01-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D133574#4085472 , @aaron.ballman wrote: > In D133574#4085372 , @aaron.ballman > wrote: > >> So by my understanding, my original changes removing the extension warning >> (in

[PATCH] D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension

2023-01-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, clang-language-wg, jyknight. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was a mistake from

[PATCH] D142228: [clangd] Disable tests that are incompatible with Windows

2023-01-27 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. thanks this makes sense! we were filtering on `target_triple` before, which is not right, especially when host triple is not the default target. as a follow up i'll drop all the `target={{...}}` conditions as we should actually be able to run these tests even when

[PATCH] D142717: [clang] Mark CWG2165 as N/A

2023-01-27 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : "CWG2165 is resolved by removing the

[PATCH] D133574: [C2x] reject type definitions in offsetof

2023-01-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D133574#4085372 , @aaron.ballman wrote: > So by my understanding, my original changes removing the extension warning > (in D40267 ) were jumping the gun because > the committee never

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

2023-01-27 Thread Michael Buch via Phabricator via cfe-commits
Michael137 updated this revision to Diff 492728. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142713/new/ https://reviews.llvm.org/D142713 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

2023-01-27 Thread Michael Buch via Phabricator via cfe-commits
Michael137 created this revision. Michael137 added reviewers: martong, aprantl. Herald added a subscriber: rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald

[PATCH] D142703: [ARM] Allow selecting hard-float ABI in integer-only MVE.

2023-01-27 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham retitled this revision from "[ARM] Allow selecting the hard float ABI in integer-only MVE." to "[ARM] Allow selecting hard-float ABI in integer-only MVE.". simon_tatham edited the summary of this revision. simon_tatham updated this revision to Diff 492722. simon_tatham added a

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-01-27 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:205 SYMBOL(basic_syncbuf, std::, ) SYMBOL(begin, std::, ) SYMBOL(bernoulli_distribution, std::, ) i think we should have other providers here,

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

2023-01-27 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} v1nh1shungry wrote: > kadircet wrote: > > v1nh1shungry

[PATCH] D133574: [C2x] reject type definitions in offsetof

2023-01-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D133574#4084215 , @stilor wrote: > In D133574#4083742 , @aaron.ballman > wrote: > >> In D133574#4083724 , @asbirlea >> wrote: >> >>>

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

2023-01-27 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added reviewers: sgatev, gribozavr2, xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the interpretation of

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-01-27 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. I haven't read though all the change of `_ParseSymbolPage`, left some comments. I think we need to update proper tests in `include-mapping/test.py` as we has changed the parser. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:1162

[clang] 0753cf2 - [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

2023-01-27 Thread Lucas Prates via cfe-commits
Author: Lucas Prates Date: 2023-01-27T12:37:18Z New Revision: 0753cf2caca707e3957a70c9756b7f1d42fab2af URL: https://github.com/llvm/llvm-project/commit/0753cf2caca707e3957a70c9756b7f1d42fab2af DIFF: https://github.com/llvm/llvm-project/commit/0753cf2caca707e3957a70c9756b7f1d42fab2af.diff LOG:

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

2023-01-27 Thread Lucas Prates via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0753cf2caca7: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects (authored by pratlucas). Repository: rG LLVM Github

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

2023-01-27 Thread Lucas Prates via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pratlucas marked an inline comment as done. Closed by commit rG9ea00fc74c3c: [NFC][AArch64] Use optional returns in target parser instead of invalid… (authored by

[clang] 9ea00fc - [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

2023-01-27 Thread Lucas Prates via cfe-commits
Author: Lucas Prates Date: 2023-01-27T12:35:58Z New Revision: 9ea00fc74c3c0032ff2d9a6774e13449a30e4549 URL: https://github.com/llvm/llvm-project/commit/9ea00fc74c3c0032ff2d9a6774e13449a30e4549 DIFF: https://github.com/llvm/llvm-project/commit/9ea00fc74c3c0032ff2d9a6774e13449a30e4549.diff LOG:

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

2023-01-27 Thread Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a51bc731bcc: Add clang_CXXMethod_isExplicit to libclang (authored by Luca Di Sera luca.dis...@qt.io). Changed prior to commit:

[clang] 0a51bc7 - Add clang_CXXMethod_isExplicit to libclang

2023-01-27 Thread Luca Di Sera via cfe-commits
Author: Luca Di Sera Date: 2023-01-27T13:23:41+01:00 New Revision: 0a51bc731bcc2c27e4fe97957a83642d93d989be URL: https://github.com/llvm/llvm-project/commit/0a51bc731bcc2c27e4fe97957a83642d93d989be DIFF: https://github.com/llvm/llvm-project/commit/0a51bc731bcc2c27e4fe97957a83642d93d989be.diff

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

2023-01-27 Thread Iain Sandoe via Phabricator via cfe-commits
iains created this revision. Herald added a project: All. iains added reviewers: dblaikie, ChuanqiXu. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. @dblaikie - I suspect that this would be useful on the

[PATCH] D141827: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

2023-01-27 Thread Michael Buch via Phabricator via cfe-commits
Michael137 added a comment. This caused some LLDB test failures for the `import-std-module` setting. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ We construct `TemplateArgument`s manually in the `CxxModuleHandler`. Fix is in-flight. Repository: rG LLVM Github Monorepo

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

2023-01-27 Thread Tomas Matheson via Phabricator via cfe-commits
tmatheson added a comment. This patch has made it considerably harder to understand what is going on in the TargetParser. If you get a chance, please could you add some clarifying comments and tidy-ups. I appreciate that a lot of this is following the lead of the pre-existing TargetParser

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc created this revision. bryanpkc added reviewers: sdesmalen, rsandifo-arm, david-arm. Herald added a subscriber: kristof.beyls. Herald added a project: All. bryanpkc requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D134681: [Clang][AArch64][SME] Add outer product intrinsics

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492693. bryanpkc retitled this revision from "[Clang][AArch64] Add SME outer product intrinsics" to "[Clang][AArch64][SME] Add outer product intrinsics". bryanpkc edited the summary of this revision. bryanpkc added a comment. Rebased and cleaned up the

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492692. bryanpkc edited the summary of this revision. bryanpkc added a comment. Added `_m` suffix to the intrinsics as required by the amendment in https://github.com/ARM-software/acle/pull/218. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

2023-01-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. I am not an expert in the frontend or ASTContext area, but I think that if a builtin declaration is created (`ASTContext::getBuiltinVaListDecl`) the identifier name for it should not be loaded from an external source (in function `IdentifierTable::get`). This load of

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

2023-01-27 Thread LJC via Phabricator via cfe-commits
paperchalice updated this revision to Diff 492684. paperchalice added a comment. Use `LLVM_LIBRARY_OUTPUT_INTDIR`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 Files:

[PATCH] D142316: [clang] Add test for CWG2396

2023-01-27 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } shafik wrote:

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492682. bryanpkc retitled this revision from "[Clang][AArch64] Add SME svaddha and svaddva intrinsics" to "[Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile". bryanpkc edited the summary of this revision. bryanpkc added a comment.

[PATCH] D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492681. bryanpkc retitled this revision from "[Clang][AArch64] Add SME svcntsb/h/w/d C intrinsics" to "[Clang][AArch64][SME] Add intrinsics for reading streaming vector length". bryanpkc edited the summary of this revision. bryanpkc added a comment.

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492680. bryanpkc added a comment. Update patch with more context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492679. bryanpkc retitled this revision from "[Clang][AArch64] Add SME ldr and str intrinsic" to "[Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)". bryanpkc edited the summary of this revision. bryanpkc added a comment. Rebased and

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:1026 +concept $Concept_decl[[C2]] = true; +template $Bracket[[<]]C2$Bracket[[<]]int$Bracket[[>]] $TemplateParameter_def[[A]]$Bracket[[>]] +

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D139926#4084868 , @nridge wrote: > I figured I might as well look through the AST API for classes with > getLAngleLoc/getRAngleLoc methods. > > It looks like we've got almost all of them (including the ones mentioned in >

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 492670. ckandeler marked 3 inline comments as done. ckandeler added a comment. Handled more cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files:

[PATCH] D142697: [WIP][3/N][Clang][RISCV] Add `__riscv_` for overloaded intrinsics

2023-01-27 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

2023-01-27 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 492665. junaire added a comment. Herald added a subscriber: ChuanqiXu. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D142644: [WIP][2/N][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics

2023-01-27 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 492663. eopXD added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142644/new/ https://reviews.llvm.org/D142644 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

2023-01-27 Thread Siva Chandra via Phabricator via cfe-commits
sivachandra added a comment. Limit the description in the release notes to one sentence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/ https://reviews.llvm.org/D142592 ___ cfe-commits

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

2023-01-27 Thread Siva Chandra via Phabricator via cfe-commits
sivachandra updated this revision to Diff 492661. sivachandra marked an inline comment as done. sivachandra added a comment. Limit the description in the release notes to one sentence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. I figured I might as well look through the AST API for classes with getLAngleLoc/getRAngleLoc methods. It looks like we've got almost all of them (including the ones mentioned in recent comments) except: - OverloadExpr - DependentTemplateSpecializationTypeLoc -

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D139926#4084856 , @nridge wrote: > In D139926#4084854 , @ckandeler > wrote: > >> I would have expected these to be handled by VisitDeclRefExpr(), but they >> aren't. Any idea? > >

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D139926#4084854 , @ckandeler wrote: > I would have expected these to be handled by VisitDeclRefExpr(), but they > aren't. Any idea? There are two other expression types, `DependentScopeDeclRefExpr` and

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D139926#4084801 , @nridge wrote: > Function calls are still missing some cases: > > I would have expected these to be handled by VisitDeclRefExpr(), but they aren't. Any idea? Repository: rG LLVM Github Monorepo

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:641 + VisitClassTemplateSpecializationDecl(ClassTemplateSpecializationDecl *D) { +for (unsigned i = 0; i < D->getNumTemplateParameterLists(); ++i) { + if (auto *TPL =

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

2023-01-27 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Driver changes LGTM, thanks! I will defer to others for changes in other areas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___ cfe-commits mailing list

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Two more cases I found: template concept C = true; template A> // <-- (inner pair) class B {}; This is a `TypeConstraint`, but RecursiveASTVisitor is lacking a Visit() method for it, so I think you'll need to override `TraverseTypeConstraint()` instead

[clang] f2f8c25 - [clang][Interp][NFC] Print parent class name of methods

2023-01-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-27T09:04:14+01:00 New Revision: f2f8c25540753a8be375fc90ad703d4101562342 URL: https://github.com/llvm/llvm-project/commit/f2f8c25540753a8be375fc90ad703d4101562342 DIFF: https://github.com/llvm/llvm-project/commit/f2f8c25540753a8be375fc90ad703d4101562342.diff

[PATCH] D142694: [clang][Interp] Only generate disassembly in debug builds

2023-01-27 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the current set of opcodes, this saves 3460

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-27 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Function calls are still missing some cases: template void free(); template struct A { template void mem(); }; void foo() { A a; a.mem(); // <-- } template void bar() { free(); // <-- A a; a.mem(); // <--

[clang] 435225c - [clang][Interp][NFC] Remove an unnecessary isArray() check

2023-01-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-27T09:00:51+01:00 New Revision: 435225c6e2f860ecc53fcd65e193f832569d090e URL: https://github.com/llvm/llvm-project/commit/435225c6e2f860ecc53fcd65e193f832569d090e DIFF: https://github.com/llvm/llvm-project/commit/435225c6e2f860ecc53fcd65e193f832569d090e.diff

[PATCH] D142607: [clang][ASTImporter] Handle UsingType in friend declarations.

2023-01-27 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142607/new/ https://reviews.llvm.org/D142607

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

2023-01-27 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139454/new/ https://reviews.llvm.org/D139454

<    1   2