[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4148006 , @philnik wrote: > The emitted warnings from the libc++ CI look like a false-positive to me. > While the functions are never called, they are used in an unevaluated > context. I would expect `-Wunused`

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth updated this revision to Diff 499913. paulkirth retitled this revision from "[WIP][Do NOT review] LLD related changes for -ffat-lto-objects support" to "[clang][llvm][lld] FatLTO Prototype". paulkirth edited the summary of this revision. paulkirth added a comment. Rebase revision.

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. In D143524#4148344 , @v.g.vassilev wrote: > In D143524#4148271 , @philnik wrote: > >> It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. >> It warns that the

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

carlosgalvezp added a comment. In D143996#4147759 , @bjosv wrote: > @carlosgalvezp Sorry, I should have mentioned that I don't have push rights > and that this is my first contribution to llvm. > My GitHub user is: bjosv and email:

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b37e48f6f0: [clang] extend external_source_symbol attribute with USR clause (authored by arphaman). Herald added a project: clang. Changed prior

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang created this revision. Herald added subscribers: ChuanqiXu, hoy, wenlei. Herald added a project: All. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144680

[clang] 7c9b15f - Revert "[Tooling/Inclusion] Handle std::get symbol."

Author: Caroline Tice Date: 2023-02-23T15:18:17-08:00 New Revision: 7c9b15fbaeb2846ad25e797d55ffe1ccef9e1379 URL: https://github.com/llvm/llvm-project/commit/7c9b15fbaeb2846ad25e797d55ffe1ccef9e1379 DIFF: https://github.com/llvm/llvm-project/commit/7c9b15fbaeb2846ad25e797d55ffe1ccef9e1379.diff

[PATCH] D144683: [analyzer] Fix of the initialization list parsing.

earnol created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. earnol requested review of this revision.

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

rupprecht accepted this revision as: rupprecht. rupprecht added a comment. All the things that were broken before are no longer broken, so LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath marked an inline comment as done. mysterymath added inline comments. Comment at: clang/lib/Headers/limits.h:55 #define UCHAR_MAX (__SCHAR_MAX__*2 +1) -#define USHRT_MAX (__SHRT_MAX__ *2 +1) +#define USHRT_MAX (__SHRT_MAX__ * 2U + 1U) #define UINT_MAX

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added a comment. Thank you for reviewing this! In D144115#4147440 , @aaron.ballman wrote: > You should add test coverage for the changes, especially around things like > dependent expressions, ADL use, etc. Also, the changes need a release note

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 499922. mysterymath added a comment. Use #if to select between signed and unsigned USHRT_MAX. Add tests for the types of limit macros specified by the standard. Add tests that limit macros can be used in #if. Repository: rG LLVM Github Monorepo

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 499963. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

[clang] ab9b2fe - [Driver] Define BareMetal::HasNativeLLVMSupport to return true

Author: Fangrui Song Date: 2023-02-23T15:06:02-08:00 New Revision: ab9b2fe2a5f817f3bbca0d187a99aaae23e75d6a URL: https://github.com/llvm/llvm-project/commit/ab9b2fe2a5f817f3bbca0d187a99aaae23e75d6a DIFF: https://github.com/llvm/llvm-project/commit/ab9b2fe2a5f817f3bbca0d187a99aaae23e75d6a.diff

[PATCH] D144684: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

aeubanks created this revision. aeubanks added reviewers: hans, thakis. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. With recent MSVC releases, STL headers will add /INFERASANLIBS to the

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added inline comments. Comment at: lld/test/ELF/fatlto/Inputs/a-fatLTO.yaml:23 +AddressAlign:0x1 +Content:

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:548 +// '-mrelax' is default unless '-mno-relax' is specified. +if (Args.hasFlag(options::OPT_mrelax,

[clang-tools-extra] c21378f - [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

Author: Matthias Braun Date: 2023-02-23T11:26:41-08:00 New Revision: c21378f90a4442810adc4af924a83a9c222fdc51 URL: https://github.com/llvm/llvm-project/commit/c21378f90a4442810adc4af924a83a9c222fdc51 DIFF:

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. > Imaginate that such trivial type could be for example 200KB in size This should be passed by const ref then correct (listed under "Expensive to move (e.g. big BigPOD[]" in the parameter passing guidelines

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

stephenpeckham accepted this revision. stephenpeckham added a comment. This revision is now accepted and ready to land. I don't have issues with this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

NoQ added a comment. Yeah looks like I replied without properly reading the patch. `TaintBugReport` is brilliant and we already have a precedent for subclassing `BugReport` in another checker. However I'm somewhat worried that once we start doing more of this, we'll eventually end up with

[PATCH] D143697: [-Wunsafe-buffer-usage] Create Fix-Its only if they are emitted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf78c34346635: [-Wunsafe-buffer-usage] Create Fix-Its only if they are emitted (authored by ziqingluo-90). Herald added a project: clang. Herald

[clang] f78c343 - [-Wunsafe-buffer-usage] Create Fix-Its only if they are emitted

Author: Ziqing Luo Date: 2023-02-23T14:47:43-08:00 New Revision: f78c34346635e25919e2777b1b1cbb9627d5ad43 URL: https://github.com/llvm/llvm-project/commit/f78c34346635e25919e2777b1b1cbb9627d5ad43 DIFF: https://github.com/llvm/llvm-project/commit/f78c34346635e25919e2777b1b1cbb9627d5ad43.diff

[PATCH] D144136: Add a "remark" to report on array accesses

kees added a comment. This gets me all 6 reports. The details about the array and the index don't really matter for the basic metrics: diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/Diagnostic SemaKinds.td index ba831c026342..29d2167b504b 100644

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

bruno added a comment. Thanks for working on this Wei! Can you please add a testcase? Comment at: clang/lib/CodeGen/CodeGenFunction.h:336 std::unique_ptr Data; +bool InSuspendBlock = false; CGCoroInfo(); Should this live inside CGCoroData

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D143524#4148039 , @philnik wrote: > In D143524#4148024 , @v.g.vassilev > wrote: > >> In D143524#4148006

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

jdoerfert added a comment. We need tests. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7790 + for (const auto *C : S.getClausesOfKind()) { +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { style, also below. Repository:

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG2928746ac3f1: [clang-tidy][doc] Remove unused variable (authored by bjosv, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 2928746 - [clang-tidy][doc] Remove unused variable

Author: Björn Svensson Date: 2023-02-23T20:07:50Z New Revision: 2928746ac3f1aabbecbe8da1525127443ebec2cf URL: https://github.com/llvm/llvm-project/commit/2928746ac3f1aabbecbe8da1525127443ebec2cf DIFF: https://github.com/llvm/llvm-project/commit/2928746ac3f1aabbecbe8da1525127443ebec2cf.diff

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 499962. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files:

[clang] c8b37e4 - [clang] extend external_source_symbol attribute with USR clause

Author: Alex Lorenz Date: 2023-02-23T14:59:26-08:00 New Revision: c8b37e48f6f00bb2aa3882ca3cc26082f85ca999 URL: https://github.com/llvm/llvm-project/commit/c8b37e48f6f00bb2aa3882ca3cc26082f85ca999 DIFF: https://github.com/llvm/llvm-project/commit/c8b37e48f6f00bb2aa3882ca3cc26082f85ca999.diff

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 40. isuckatcs added a comment. fixed failing test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp

[clang] 21631b5 - [clang] fix intendation in newly added release note

Author: Alex Lorenz Date: 2023-02-23T15:53:07-08:00 New Revision: 21631b567e88b5a1146a74b0a25f7a20afef8afb URL: https://github.com/llvm/llvm-project/commit/21631b567e88b5a1146a74b0a25f7a20afef8afb DIFF: https://github.com/llvm/llvm-project/commit/21631b567e88b5a1146a74b0a25f7a20afef8afb.diff

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

ahatanak added a comment. I don't have a test case for this change because there is a bug that prevents using the maximum allowed alignment (see https://github.com/llvm/llvm-project/issues/60752). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. It warns that the deduction guide is unused, but the deduction guide is required suppress `-Wctad-maybe-unsupported`. https://godbolt.org/z/G8bMjYsbn Repository: rC Clang CHANGES SINCE LAST

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4148271 , @philnik wrote: > It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. > It warns that the deduction guide is unused, but the deduction guide is > required suppress

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 499953. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau added a comment. In D144431#4146524 , @carlosgalvezp wrote: > Alright, sounds good, thanks for the clarification! Then I misunderstood the > change in the tests and indeed it belonged together in this patch, sorry for > the confusion. I have

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rG91610433907e: [clang][driver] Handle -mrelax and -mno-relax for AVR (authored by benshi001). Changed prior to commit:

[clang] 9161043 - [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

Author: Ben Shi Date: 2023-02-24T07:16:31+08:00 New Revision: 91610433907ebc335576f0da286f0c8a7793e3a9 URL: https://github.com/llvm/llvm-project/commit/91610433907ebc335576f0da286f0c8a7793e3a9 DIFF: https://github.com/llvm/llvm-project/commit/91610433907ebc335576f0da286f0c8a7793e3a9.diff LOG:

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:548 +// '-mrelax' is default unless '-mno-relax' is specified. +if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) MaskRay wrote: > The comment just

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. In D143524#4148024 , @v.g.vassilev wrote: > In D143524#4148006 , @philnik wrote: > >> The emitted warnings from the libc++ CI look like a false-positive to me. >> While the functions

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -template static void f() {} +template static void f() {} // expected-warning {{unused function template}}

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc21378f90a44: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions (authored by MatzeB). Repository: rG LLVM Github Monorepo

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

This revision was automatically updated to reflect the committed changes. Closed by commit rG608ee703e530: [SCEV] Ensure SCEV does not replace aliases with their aliasees (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cd26529 - [-Wunsafe-buffer-usage] Fixits for assignments to array subscript expressions

Author: Ziqing Luo Date: 2023-02-23T15:02:46-08:00 New Revision: cd2652963b6b97c01329419f15c336e5560afa98 URL: https://github.com/llvm/llvm-project/commit/cd2652963b6b97c01329419f15c336e5560afa98 DIFF: https://github.com/llvm/llvm-project/commit/cd2652963b6b97c01329419f15c336e5560afa98.diff

[PATCH] D142794: [-Wunsafe-buffer-usage] Fixits for assignment to array subscript expr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2652963b6b: [-Wunsafe-buffer-usage] Fixits for assignments to array subscript expressions (authored by ziqingluo-90). Herald added a project:

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

ahatanak created this revision. ahatanak added reviewers: aeubanks, efriedma, rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a bug introduced in https://reviews.llvm.org/D142584. The patch reduced the number of bits

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

phosek added inline comments. Comment at: lld/test/ELF/fatlto/Inputs/a-fatLTO.yaml:23 +AddressAlign:0x1 +Content:

[clang-tools-extra] 5a623c2 - Revert "Revert "[Tooling/Inclusion] Handle std::get symbol.""

Author: Kadir Cetinkaya Date: 2023-02-24T01:24:53+01:00 New Revision: 5a623c2a082d007c1cc7a878b666b3581bb8f8dc URL: https://github.com/llvm/llvm-project/commit/5a623c2a082d007c1cc7a878b666b3581bb8f8dc DIFF:

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:28 -// We try to save some space by using 6 bits over two PointerIntPairs to store -// the alignment. However, some arches don't support 3 bits in a PointerIntPair -// so we fallback to storing the

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

vitalybuka added subscribers: kstoimenov, vitalybuka. vitalybuka added a comment. One of your patches likely introduced UB https://lab.llvm.org/buildbot/#/builders/85/builds/14558 Can you please take a look? FYI, @kstoimenov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[clang] 255b2d8 - Add test for issue 60486

Author: Chuanqi Xu Date: 2023-02-24T14:32:05+08:00 New Revision: 255b2d8162ead0ad444698506f97484572e574b1 URL: https://github.com/llvm/llvm-project/commit/255b2d8162ead0ad444698506f97484572e574b1 DIFF: https://github.com/llvm/llvm-project/commit/255b2d8162ead0ad444698506f97484572e574b1.diff

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 marked 2 inline comments as done. ym1813382441 added a comment. F26630797: Screenshot from 2023-02-24 15-54-21.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144696/new/

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

ChuanqiXu added a comment. The test should be required here. Comment at: clang/lib/CodeGen/CGExpr.cpp:544 // so that it's unconditional. Don't do this with sanitizers which need // more precise lifetime marks. ConditionalEvaluation *OldConditional =

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

shafik added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1301-1302 SourceLocation AttrNameLoc = ConsumeToken(); -Attr.addNew(AttrName, AttrNameLoc, nullptr, AttrNameLoc, nullptr, 0, -ParsedAttr::AS_Keyword); +

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added a comment. I want to use arrays to maintain the supported version number of each extension, this patch in using the `find` algorithm helps to simplify the code. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:24 + unsigned Minor; + bool

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

nridge created this revision. nridge added reviewers: kadircet, hokein. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

ChuanqiXu added a comment. Yeah, it looks better indeed to not store additional information. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144626/new/ https://reviews.llvm.org/D144626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:520 auto ExprStartLoc = SM.getTopMacroCallerLoc(E->getBeginLoc()); -auto Decomposed = SM.getDecomposedLoc(ExprStartLoc); +auto Decomposed = SM.getDecomposedExpansionLoc(ExprStartLoc);

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

carlosgalvezp added a comment. @amurzeau I'm having some trouble downloading the patch, would you mind trying out a rebase on top of latest master? Otherwise I'll try downloading the raw diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

eopXD added a comment. Thank you for the patch. May you explain how this would help support multi-versioning? Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:24 + unsigned Minor; + bool operator==(const RISCVExtensionVersion ) const { +return this->Major ==

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

rupprecht added a comment. This has already been reverted, but I found a breakage (not a crash) caused by this: #include class Base { protected: int member; }; template struct Subclass : public Parent { static_assert(std::is_base_of::value, "Parent

[clang-tools-extra] 87447be - [clang-tidy] Fix readability-identifer-naming Hungarian CString options

Author: Alexis Murzeau Date: 2023-02-24T07:15:19Z New Revision: 87447bedac341f023569f1b444f9b3b62bba5aa6 URL: https://github.com/llvm/llvm-project/commit/87447bedac341f023569f1b444f9b3b62bba5aa6 DIFF: https://github.com/llvm/llvm-project/commit/87447bedac341f023569f1b444f9b3b62bba5aa6.diff

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

This revision was automatically updated to reflect the committed changes. Closed by commit rG87447bedac34: [clang-tidy] Fix readability-identifer-naming Hungarian CString options (authored by amurzeau, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

shafik added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:537 +if (!CapturedPattern->isParameterPack()) { + ValueDecl *CapturedVar = + LambdaClass->getCapture(Instantiated)->getCapturedVar(); This is just duplicated across the

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19036 bool Sema::tryCaptureVariable( ValueDecl *Var, SourceLocation ExprLoc, TryCaptureKind Kind, We have a bunch of bugs that crash in the method and it would be good to rescreen

[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

ChuanqiXu updated this revision to Diff 500046. ChuanqiXu added a comment. Address comments: - Don't store the original trailing require clause. Trying to get the trailing require clause of the primary template function when ODR checking instead. CHANGES SINCE LAST ACTION

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

ChuanqiXu added a comment. BTW, what is the conclusion for the concern about sanitizers? Would change make sanitizers to perform false positive diagnostics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144680/new/

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

craig.topper added a comment. You outline your full plan and why you want to do this. We need to see the bigger picture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144696/new/ https://reviews.llvm.org/D144696

[clang-tools-extra] cbcb3ee - [Tooling/Inclusion] Handle std::get symbol.

Author: Haojian Wu Date: 2023-02-23T10:26:26+01:00 New Revision: cbcb3eef70def3509bdffd4fe1ebfb6422afeaa2 URL: https://github.com/llvm/llvm-project/commit/cbcb3eef70def3509bdffd4fe1ebfb6422afeaa2 DIFF: https://github.com/llvm/llvm-project/commit/cbcb3eef70def3509bdffd4fe1ebfb6422afeaa2.diff

[PATCH] D144484: [Tooling/Inclusion] Handle std::get symbol.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbcb3eef70de: [Tooling/Inclusion] Handle std::get symbol. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

kuganv added a comment. > if you don't mind me asking, are you deliberately building remote-index > components? i.e. do you have an internal remote-index server/deployment ? > Asking as it'd be great to know that we've adoption here, outside of > ourselves. > > OTOH, if you're not actually

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a comment. In D142914#4145224 , @TIFitis wrote: > In D142914#4144475 , > @kiranchandramohan wrote: > >> Please add tests for the MLIR portion. > > Can you please tell me where to add

[PATCH] D144627: [Clang] Fix a crash when taking the address of a consteval lambda

cor3ntin updated this revision to Diff 499773. cor3ntin added a comment. Release notes + formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144627/new/ https://reviews.llvm.org/D144627 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 499777. klimek added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/include/clang/Format/Format.h

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

sammccall added a comment. Thanks, this all looks good, at least as far as I understand it! The two-passes-over-the-whole-file approach is easier for me to follow, too. Mostly just comment nits, but I have one annoying question left about using macros with the wrong arity - I thought this was

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499799. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c clang/test/CodeGen/arm-abi-vector.c

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, indeed the protobuf version used by grpc-1.36.3 has these available,

[clang-tools-extra] 279b498 - [include-cleaner] Always treat constructor calls as implicit

Author: Kadir Cetinkaya Date: 2023-02-23T10:00:50+01:00 New Revision: 279b4985ed4f62eb8e9a71e79379c2adfa8d8b99 URL: https://github.com/llvm/llvm-project/commit/279b4985ed4f62eb8e9a71e79379c2adfa8d8b99 DIFF:

[clang-tools-extra] 48027f0 - [include-cleaner] Dont pass llvm::StringRef to gtest APIs

Author: Kadir Cetinkaya Date: 2023-02-23T10:04:03+01:00 New Revision: 48027f03f2d5fef884ebe118c42f800b90fae2f9 URL: https://github.com/llvm/llvm-project/commit/48027f03f2d5fef884ebe118c42f800b90fae2f9 DIFF:

[clang] 74565c3 - [Modules] Don't check [temp.friend]p9 in ASTContext::isSameEntity

Author: Chuanqi Xu Date: 2023-02-23T17:09:38+08:00 New Revision: 74565c3add6d683559618973863e78a5e6836e48 URL: https://github.com/llvm/llvm-project/commit/74565c3add6d683559618973863e78a5e6836e48 DIFF: https://github.com/llvm/llvm-project/commit/74565c3add6d683559618973863e78a5e6836e48.diff

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 499766. DmitryPolukhin added a comment. Failing tests seems to be just flacky, I was not able to reprocuce any issue with them locally in stress runs and under ASan and TSan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

ChuanqiXu created this revision. ChuanqiXu added reviewers: erichkeane, cor3ntin, royjacobson, clang-language-wg. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag

DavidSpickett accepted this revision. DavidSpickett added a comment. https://cmake.org/cmake/help/v3.18/module/CheckLinkerFlag.html Looks equivalent to me, good timing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143052/new/

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added a comment. bind(thread) is not working at present. I have uploaded this patch to obtain feedback mainly on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 499791. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. - Rename args to options as suggested by @phosek - Add more comments to hopefully make the difference between flags and options clearer. Repository: rG

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:41 + flag_set Flags; + arg_list PrintArgs; phosek wrote: > This is just a suggestion, but GCC documentation refers to these as either > "options" or "switches", not

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Thinking about this some more, the new `Pointer::toRValue()` is probably just the same thing we're already doing in `EvalEmitter::emtiRetValue()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 499771. klimek marked 9 inline comments as done. klimek added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files:

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:744 + // Align following lines within parenthesis / brackets if configured. + // For a line of macro parents, the commas that follow the opening parenthesis + // in the line come after the

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. @steakhal, @NoQ thanks for your reviews. Please note that I am not extending `TaintBugVisitor`. On the contrary I removed it. Instead I use NoteTag to generate the "Taint Originated here" text (see GenericTaintChecker.cpp:156). I can also add additional NoteTags for

[PATCH] D144627: [Clang] Fix a crash when taking the address of a consteval lambda

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `_invoke` function of lambdas was not respecting the constexpr/consteval specifier of the call operator, so it was

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops created this revision. koops added reviewers: soumitra, RitanyaB, dreachem, ABataev, jdoerfert, sandoval, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a project: All. koops requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. One more thing I noticed, this check can be in conflict with performance-move-const-arg. warning: std::move of the variable 'xyz' of the trivially-copyable type 'types::xyz' has no effect; remove std::move() [performance-move-const-arg] so would be nice to make

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499797. arsenm added a comment. Test updates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499798. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c clang/test/CodeGen/arm-abi-vector.c

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:549 +// '-mrelax' is default unless '-mno-relax' is specified. +if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) + CmdArgs.push_back("--relax"); If

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 499754. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clang/docs/ReleaseNotes.rst

  1   2   >