[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7673 +Info.FFDiag(Callee, diag::note_constexpr_null_callee) +<< const_cast(Callee); +return false; tbaeder wrote: > Is the `const_cast` really necessary? > Is

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added a comment. Please keep in mind that I don't have a lot of expertise in modules, but this sure seems like a module merging bug from what I can tell, and it might even relate to work happening in D145737 (CC @rsmith). That patch does not

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

yaxunl added a comment. The description needs fix. "ABI field" should be "environment component". Also, we need a clang-offload-bundler test which bundles with a non-canonical triple and unbundles with a canonical triple and vice versa. Comment at:

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet thank you for the review! Please take another look. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:199 + // use/change working directory, which ExpandResponseFiles doesn't). + FS = llvm::vfs::getRealFileSystem(); +}

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 504156. DmitryPolukhin marked 4 inline comments as done. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. So here's a potential idea for future development: It isn't uncommon/untypical for an attribute to want to return something other than '1', for 'version' (usually an integral value

[PATCH] D145769: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

wanders edited the summary of this revision. wanders updated this revision to Diff 504150. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145769/new/ https://reviews.llvm.org/D145769 Files: clang/include/clang/Basic/ParsedAttrInfo.h

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders updated this revision to Diff 504152. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144405/new/ https://reviews.llvm.org/D144405 Files: clang/docs/ReleaseNotes.rst clang/examples/Attribute/Attribute.cpp clang/lib/Basic/Attributes.cpp

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC)

wanders updated this revision to Diff 504151. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144404/new/ https://reviews.llvm.org/D144404 Files: clang/lib/Basic/Attributes.cpp Index: clang/lib/Basic/Attributes.cpp

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7673 +Info.FFDiag(Callee, diag::note_constexpr_null_callee) +<< const_cast(Callee); +return false; Is the `const_cast` really necessary? Repository: rG LLVM

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added subscribers: urnathan, iains. aaron.ballman added a comment. In D124351#4179510 , @cor3ntin wrote: > In D124351#4178334 , @sammccall > wrote: > >> Sorry for the delay, extracting the repro

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4183453 , @hoy wrote: > Wondering if we can come up with a way to tell the optimizer about that, > e.g., through a new module flag. When it comes to LTO, the selection of > linkonce_odr symbols should already been

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:271 + static_assert(d.B::a == 12); + static_assert(d.C::a == 0); }; These lines are added by https://reviews.llvm.org/D143480 now, but the

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder updated this revision to Diff 504146. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/ https://reviews.llvm.org/D143466 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Record.cpp clang/lib/AST/Interp/Record.h

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144878: __builtin_FILE_NAME()

cor3ntin added a comment. > In terms of the encoding question I was asking, that's information we'll have > to figure out (CC @tahonermann and @cor3ntin for text encoding question). My > guess (which needs verification) is that we convert the file name from the > system encoding to UTF-8

[PATCH] D145794: [clang-format] Recognize Verilog always blocks

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The small

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144402/new/ https://reviews.llvm.org/D144402

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

hazohelet created this revision. hazohelet added reviewers: tbaeder, cjdb, aaron.ballman. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch improves diagnostic for clang constexpr evaluator by adding a check for `nullptr` in

[PATCH] D142420: [Flang] Add support to use LTO specific pipelines

tblah added a comment. In D142420#4080619 , @mnadeem wrote: > We have tried full LTO on Aarch64 (without this patch) and have seen a few > 3-8% improvements in SPEC and a 100+% improvement in leslie3d. > There were a couple of additional failures in

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC)

wanders added a comment. In D144402#4184749 , @erichkeane wrote: > I want to wait for @aaron.ballman to answer, but i think this is generally > OK. Note the motivation is the ability to check this from > __has_cpp_attribute/__has_c_attribute/etc. I

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders added a comment. In D144405#4184726 , @erichkeane wrote: > Looks like this doesn't compile pre-commit, though no idea if that is a > patch-stack issue. Other than test, patch looks fine. Yeah, when uploading the new commit the stack was

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added subscribers: cor3ntin, tahonermann. aaron.ballman added a comment. In D144878#4183893 , @karapsinie wrote: > In D144878#4172639 , @aaron.ballman > wrote: > >> In D144878#4171234

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** vedgy wrote: > aaron.ballman wrote: > > vedgy wrote: > > > vedgy wrote: > > > > aaron.ballman wrote: > > > > > vedgy wrote: >

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC)

erichkeane added a comment. I want to wait for @aaron.ballman to answer, but i think this is generally OK. Note the motivation is the ability to check this from __has_cpp_attribute/__has_c_attribute/etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145783: Reserve unused bits in struct CXIndexOptions; NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa28e4821829e: Reserve unused bits in struct CXIndexOptions; NFC (authored by vedgy, committed by aaron.ballman). Changed prior to commit:

[clang] a28e482 - Reserve unused bits in struct CXIndexOptions; NFC

Author: Igor Kushnir Date: 2023-03-10T09:26:10-05:00 New Revision: a28e4821829e2d5c68fc652f1db5db6e02284c3d URL: https://github.com/llvm/llvm-project/commit/a28e4821829e2d5c68fc652f1db5db6e02284c3d DIFF: https://github.com/llvm/llvm-project/commit/a28e4821829e2d5c68fc652f1db5db6e02284c3d.diff

[PATCH] D145783: Reserve unused bits in struct CXIndexOptions; NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145783/new/ https://reviews.llvm.org/D145783

[PATCH] D145775: Improve documentation of CXIndexOptions; NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG00e52588f02e: Improve documentation of CXIndexOptions; NFC (authored by vedgy, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 00e5258 - Improve documentation of CXIndexOptions; NFC

Author: Igor Kushnir Date: 2023-03-10T09:22:09-05:00 New Revision: 00e52588f02e2d9c7fcd1cfb4703deaca1b32a8d URL: https://github.com/llvm/llvm-project/commit/00e52588f02e2d9c7fcd1cfb4703deaca1b32a8d DIFF: https://github.com/llvm/llvm-project/commit/00e52588f02e2d9c7fcd1cfb4703deaca1b32a8d.diff

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

erichkeane added a comment. Looks like this doesn't compile pre-commit, though no idea if that is a patch-stack issue. Other than test, patch looks fine. Comment at: clang/test/Frontend/plugin-attribute-pp.cpp:1 +// RUN: split-file %s %t +// RUN: %clang

[clang] ecf6508 - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-03-10T15:17:28+01:00 New Revision: ecf65087eee7529936c9c93d76e02b06816ba930 URL: https://github.com/llvm/llvm-project/commit/ecf65087eee7529936c9c93d76e02b06816ba930 DIFF: https://github.com/llvm/llvm-project/commit/ecf65087eee7529936c9c93d76e02b06816ba930.diff

[PATCH] D145769: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

tbaeder added inline comments. Comment at: clang/include/clang/Basic/ParsedAttrInfo.h:92 + /// Check if this attribute has specified spelling. + bool hasSpelling(AttributeCommonInfo::Syntax Syntax, StringRef Name) { +return llvm::any_of(Spellings, [&] (const Spelling ) {

[PATCH] D145769: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Looks like you have a clang-format fix to do (see pre-commit CI), else, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145769/new/

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

This revision was automatically updated to reflect the committed changes. Closed by commit rG17d403f66443: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG54178fc6161a: [clang-tidy] add check for capturing lambda coroutines (authored by dotnwat, committed by PiotrZSL).

[clang-tools-extra] 17d403f - [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

Author: Piotr Zegar Date: 2023-03-10T14:06:50Z New Revision: 17d403f6644337e3e099e6dcb7b057fce11e65a5 URL: https://github.com/llvm/llvm-project/commit/17d403f6644337e3e099e6dcb7b057fce11e65a5 DIFF: https://github.com/llvm/llvm-project/commit/17d403f6644337e3e099e6dcb7b057fce11e65a5.diff LOG:

[clang-tools-extra] 54178fc - [clang-tidy] add check for capturing lambda coroutines

Author: Noah Watkins Date: 2023-03-10T14:06:50Z New Revision: 54178fc6161a5856bea608dce0d726787a3b71c3 URL: https://github.com/llvm/llvm-project/commit/54178fc6161a5856bea608dce0d726787a3b71c3 DIFF: https://github.com/llvm/llvm-project/commit/54178fc6161a5856bea608dce0d726787a3b71c3.diff LOG:

[PATCH] D145730: [clang-tidy] Fix readability-redundant-string-cstr for smart pointer #576705

mikecrowe added a comment. Thanks, and sorry about the erroneous `[PATCH]` in the summary. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145730/new/ https://reviews.llvm.org/D145730 ___ cfe-commits

[PATCH] D145765: Add __builtin_set_flt_rounds

aaron.ballman added a comment. Thank you for this! You should also add a release note and some documentation for the new builtin. Comment at: clang/test/CodeGen/builtin_set_flt_rounds.c:1-4 +// RUN: %clang_cc1 -triple x86_64-gnu-linux %s -emit-llvm -o - | FileCheck %s +//

[clang-tools-extra] d4b45b9 - [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

Author: Florian Humblot Date: 2023-03-10T13:56:28Z New Revision: d4b45b93fa56622ee5f935c066f43b15b856f3b8 URL: https://github.com/llvm/llvm-project/commit/d4b45b93fa56622ee5f935c066f43b15b856f3b8 DIFF: https://github.com/llvm/llvm-project/commit/d4b45b93fa56622ee5f935c066f43b15b856f3b8.diff

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4b45b93fa56: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases. (authored by florianhumblot, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145730: [clang-tidy] Fix readability-redundant-string-cstr for smart pointer #576705

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c8bc090a0c2: [clang-tidy] Fix readability-redundant-string-cstr for smart pointer #576705 (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 9c8bc09 - [clang-tidy] Fix readability-redundant-string-cstr for smart pointer #576705

Author: Mike Crowe Date: 2023-03-10T13:52:49Z New Revision: 9c8bc090a0c291efb41cc4b5c51ea0c340961ad1 URL: https://github.com/llvm/llvm-project/commit/9c8bc090a0c291efb41cc4b5c51ea0c340961ad1 DIFF: https://github.com/llvm/llvm-project/commit/9c8bc090a0c291efb41cc4b5c51ea0c340961ad1.diff LOG:

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot added a comment. In D145778#4184611 , @PiotrZSL wrote: > What should I put as commit author ? > I'm asking because this is diff, and commit author looks to be attached to it. "Florian Humblot " should be good :) CHANGES SINCE LAST

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

PiotrZSL added a comment. What should I put as commit author ? I'm asking because this is diff, and commit author looks to be attached to it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145778/new/ https://reviews.llvm.org/D145778 ___

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

bjope added a comment. I have no objections about doing this revert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added a comment. In D145704#4184584 , @aaron.ballman wrote: > LGTM! If you don't hear otherwise from @kito-cheng, @bjope, @Wilco1 in the > next ~4 hours, feel free to land. Great! Thanks @aaron.ballman and @tstellar. CHANGES SINCE LAST

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143480/new/ https://reviews.llvm.org/D143480 ___ cfe-commits mailing

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! If you don't hear otherwise from @kito-cheng, @bjope, @Wilco1 in the next ~4 hours, feel free to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/

[PATCH] D145730: [PATCH] [clang-tidy] Fix readability-redundant-string-cstr for smart pointer #576705

mikecrowe added a comment. Thanks for the speedy re-review. I don't have commit permission, so please can you land this if you are happy to do so? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145730/new/ https://reviews.llvm.org/D145730

[PATCH] D130303: Fix include order in CXType.cpp

aaron.ballman added a comment. In D130303#4183081 , @collinbaker wrote: > All done. Again, I don't have commit access so someone else will need to land > this. I can do that for you -- what name and email address would you like me to use for patch

[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705

mikecrowe updated this revision to Diff 504108. mikecrowe marked an inline comment as done. mikecrowe added a comment. Fix comment in code as suggested by PiotrZSL. Improve lit check tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145730/new/

[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705

PiotrZSL added a comment. Code is correct, simply this check uses more manual string manipulation. In theory there could be some more issues if `operator ->` wouldn't return pointer, but a class with additional `operator ->`, but that's legacy independent issue. Repository: rG LLVM Github

[clang] 1e07091 - Revert "[Modules] Remove unnecessary check when generating name lookup table in ASTWriter"

Author: Krasimir Georgiev Date: 2023-03-10T14:14:55+01:00 New Revision: 1e0709167f5edd330889f51bb203c458bdb5e359 URL: https://github.com/llvm/llvm-project/commit/1e0709167f5edd330889f51bb203c458bdb5e359 DIFF:

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot added a comment. In D145778#4184530 , @PiotrZSL wrote: > LGTM Thanks for the reviews @PiotrZSL ! Is one review enough or does the second reviewer also need to approve these changes? If this one is enough, could I ask you (or someone

[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705

mikecrowe added a comment. In D145730#4182949 , @PiotrZSL wrote: > Also consider reducing commit message, instead just copying issue description. > Simple description about issue would be sufficient. TBH, I wasn't expecting this change to be accepted. I

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145778/new/ https://reviews.llvm.org/D145778 ___ cfe-commits mailing list

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot updated this revision to Diff 504097. florianhumblot marked 2 inline comments as done. florianhumblot added a comment. Generate diff with full context and updated the example to use the default settings of the readabiliy-magic-numbers checker CHANGES SINCE LAST ACTION

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

PiotrZSL added a comment. "Context not available." - use arcanist (just merge all local commits into one), or generate diff with full context (diff -U 999). Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/magic-numbers.rst:58 + + using containerType =

[PATCH] D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases

florianhumblot abandoned this revision. florianhumblot added a comment. Accidentally opened this one with arcanist. The changes have been moved to https://reviews.llvm.org/D145778 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145780/new/

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

jhenderson added a comment. Related to my inline comment, your changes will result in some tests being disabled on Windows that weren't before (at least one of the tests pass for me even on my machine where atime is disabled). I think we need to understand why these tests pass on Windows

[PATCH] D145782: [clangd] Don't ignore headers with IWYU export pragmas for unused-include analysis.

hokein planned changes to this revision. hokein added a comment. It appears that there is an issue with this patch, so please hold on for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145782/new/ https://reviews.llvm.org/D145782

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** aaron.ballman wrote: > vedgy wrote: > > vedgy wrote: > > > aaron.ballman wrote: > > > > vedgy wrote: > > > > > Assigning `true` to

[PATCH] D145783: Reserve unused bits in struct CXIndexOptions; NFC

vedgy created this revision. Herald added a subscriber: arphaman. Herald added a project: All. vedgy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145783 Files:

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot updated this revision to Diff 504089. florianhumblot edited the summary of this revision. florianhumblot added a comment. Made it so that the proposed change doesn't change the default behavior of the check. Introduce an option to allow enabling the exclusion. CHANGES SINCE LAST

[PATCH] D145782: [clangd] Don't ignore headers with IWYU export pragmas for unused-include analysis.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This check was introduced due

[PATCH] D145781: [AArch64] Don't #define __ARM_FP when there's no FPU.

simon_tatham created this revision. simon_tatham added reviewers: lenary, tmatheson, DavidSpickett, efriedma. Herald added a subscriber: kristof.beyls. Herald added a project: All. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:198 + magic numbers in type aliases such as ``using`` and ``typedef`` declarations if + the new ``IgnoreTypeAliases`` option is set to false. is set to `true`, not false.

[PATCH] D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases

PiotrZSL added a comment. Merge those commits under D145778 , no need for separate review. (git rebase -i HEAD~3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145780/new/ https://reviews.llvm.org/D145780

[PATCH] D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases

florianhumblot created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, jeroen.dobbelaere, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. florianhumblot requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary marked an inline comment as done. lenary added a comment. @jhenderson @int3 I think I have addressed your feedback - are you happy for me to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder updated this revision to Diff 504079. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/records.cpp Index:

[PATCH] D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG7ab16be4c030: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library… (authored by

[clang-tools-extra] 7ab16be - [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation.

Author: Haojian Wu Date: 2023-03-10T11:56:11+01:00 New Revision: 7ab16be4c0302f648f85dbf1fe3d1a5dde9b9600 URL: https://github.com/llvm/llvm-project/commit/7ab16be4c0302f648f85dbf1fe3d1a5dde9b9600 DIFF: https://github.com/llvm/llvm-project/commit/7ab16be4c0302f648f85dbf1fe3d1a5dde9b9600.diff

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. This is for issue: https://github.com/llvm/llvm-project/issues/61259 Reference it in commit message. Add config: "flag should be added i.e. IgnoreTypeAliases which will default

[PATCH] D145776: [clangd] Remove the classical clangd-own unsued-include implementation.

hokein abandoned this revision. hokein marked an inline comment as done. hokein added a comment. Merge the change in https://reviews.llvm.org/D145773 per the review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145776/new/

[PATCH] D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation.

hokein updated this revision to Diff 504073. hokein added a comment. Herald added a subscriber: mgrang. add the removal of the clangd-own implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145773/new/ https://reviews.llvm.org/D145773

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:40 + if (Node.get() || Node.get()) +return true; This should be configurable, someone else may don't want magic numbers in template arguments. So

[PATCH] D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:438 + .map("Experiment", +

[PATCH] D145776: [clangd] Remove the classical clangd-own unsued-include implementation.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. i'd still merge this with the previous patch, as all of this is dead code after config option deletion. so it'd be better to just revert a single patch if we want to restore the old

[PATCH] D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:438 + .map("Experiment", + Config::IncludesPolicy::Strict) // for backward + //

[PATCH] D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation.

hokein updated this revision to Diff 504069. hokein marked an inline comment as done. hokein added a comment. Add diagnostic for Experiment flag usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145773/new/ https://reviews.llvm.org/D145773

[PATCH] D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases.

florianhumblot created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, jeroen.dobbelaere, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. florianhumblot requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

RKSimon added a comment. It might be worth adding something to the release notes explaining that removal of the flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145715/new/ https://reviews.llvm.org/D145715

[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

spaits updated this revision to Diff 504062. spaits added a comment. As @Szelethus has mentioned in his reply I tried to improve on the comment. I hope now it describes correctly what the new visitor is good for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:189 + getLangOpts().CPlusPlus2b + ? hasAnyName("::std::print", "::std::format") +

[PATCH] D145311: [clang-tidy] Make abseil-redundant-strcat-calls checker use header

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. It's fine, absl::StrCat returns std::string. So those changes are correct. Here you can find source code https://github.com/abseil/abseil-cpp/blob/master/absl/strings/str_cat.h

[PATCH] D145776: [clangd] Remove the classical clangd-own unsued-include implementation.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, mgrang. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We have switch to use

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, this is anyway non functional change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145313/new/ https://reviews.llvm.org/D145313

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145312/new/ https://reviews.llvm.org/D145312 ___ cfe-commits mailing list

[PATCH] D145775: Improve documentation of CXIndexOptions; NFC

vedgy created this revision. Herald added a subscriber: arphaman. Herald added a project: All. vedgy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Document one more alternative way to initialize struct CXIndexOptions, which is used in

[PATCH] D145724: [clang-tidy] Provide default template arguments in

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145724/new/ https://reviews.llvm.org/D145724

[PATCH] D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:438 + .map("Experiment", + Config::IncludesPolicy::Strict) // for backward +

[PATCH] D145773: [clangd] UnusedIncludes: Strict config now uses the include-cleaner-library implementation.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is the first step to

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG421c098b32bd: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained… (authored by alexander-shaposhnikov). Repository: rG

[clang] 421c098 - [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

Author: Alexander Shaposhnikov Date: 2023-03-10T09:21:09Z New Revision: 421c098b32bd50122de8de03a71092c7f36994eb URL: https://github.com/llvm/llvm-project/commit/421c098b32bd50122de8de03a71092c7f36994eb DIFF:

[PATCH] D141194: [clang][Interp] Implement bitcasts

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this since it's superseded by https://reviews.llvm.org/D144943 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141194/new/ https://reviews.llvm.org/D141194

<    1   2   3   >