[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/ https://reviews.llvm.org/D141824 ___ cfe-commits mailing list

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 509017. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon updated this revision to Diff 509039. Fznamznon added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:91 /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_4;

[PATCH] D147068: Fix merging of member-like constrained friends across modules.

rsmith created this revision. rsmith added a reviewer: aaron.ballman. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a friend declaration has a requires-clause, and either it's a non-template

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. Yeah, that was the sort of thing I was worried about. The identifier thing is also a reasonable approach, and it'll be nice infrastructure for other, similar things. The ranges of special identifier we already call out on IdentifierInfo* are for builtin functions

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. In D145726#4228216 , @nickdesaulniers wrote: > @garvitgupta08 what's your email address so that I may attribute your > authorship correctly when committing on your behalf? quic_garvg...@quicinc.com. Thanks for

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ? Style.ContinuationIndentWidth + :

[PATCH] D146408: [clang][Interp] Start supporting complex types

aaron.ballman added a comment. I don't think the `_BitInt` test case should block this patch if that turns out to cause problems. Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:212-214 +}); +return false; + } else if (ElemTy->isFloatingType()) {

[PATCH] D147070: Improve requirement clause limitation on non templated function

erichkeane added inline comments. Comment at: clang/test/Parser/cxx2b-lambdas.cpp:21 auto L12 = [] consteval {}; -auto L13 = []() requires true {}; +auto L13 = []() requires true {}; // expected-error{{non-templated function cannot have a requires clause}} auto L14 = []

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509013. AMS21 added a comment. Implemented suggested fixes from reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D136103: OpenMP asynchronous memory copy support

jplehr updated this revision to Diff 509023. jplehr added a comment. Rebased and enabled tests for generic devices. Resulted in one test failure Failed Tests (3): libomptarget :: amdgcn-amd-amdhsa :: api/omp_target_memcpy_rect_async1.c libomptarget :: x86_64-pc-linux-gnu ::

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon added a comment. > Should OutputStream be made into a shared_ptr so we can clarify the memory > ownership instead of leaving it as a raw pointer? That should also address > the use-after-free. Well, I was thinking about that and wasn't sure about it either.

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

cjdb added a comment. In D146358#4204412 , @tbaeder wrote: > "subobject named 'foo'" sounds a bit weird to me, I'd expect just "subobject > 'foo'", but that's just a suggestion and I'll wait for a native spearker to > chime in on this. My expert brain

[PATCH] D146840: [AMDGPU] Replace target feature for global fadd32

gandhi21299 updated this revision to Diff 509066. gandhi21299 added a comment. - gfx908 does not support return version of the builtin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146840/new/ https://reviews.llvm.org/D146840 Files:

[PATCH] D147037: [Clang][ICE] Corrected invalid invalid parameter index on some attributes with invalid indices applied to varargs functions

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Thanks for working on this fix! A few things: - Please add a summary description to the patch, and be sure to include a reference to the github issue in the summary. - All functional changes (e.g., not typo fixes, fixes

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains updated this revision to Diff 509014. iains added a comment. rebased, retested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126959/new/ https://reviews.llvm.org/D126959 Files: clang/include/clang/Basic/Module.h

[clang] 256914b - [AIX] Update release notes regarding -mxcoff-build-id and the profile runtime

Author: Wael Yehia Date: 2023-03-28T14:53:12Z New Revision: 256914bf1c13a7f2dc1343b9761cae15b8b37e00 URL: https://github.com/llvm/llvm-project/commit/256914bf1c13a7f2dc1343b9761cae15b8b37e00 DIFF: https://github.com/llvm/llvm-project/commit/256914bf1c13a7f2dc1343b9761cae15b8b37e00.diff LOG:

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 509015. VitaNuo added a comment. Remove redundant code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1595 +return true; + } else if (const auto *CE = dyn_cast(Initializer)) { +if (!this->emitDupPtr(Initializer)) aaron.ballman wrote: > Member calls as well? Yes, and some

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added a comment. In D145726#4225082 , @garvitgupta08 wrote: > I do not have the commit access, can you commit on my behalf @nickdesaulniers Sure thing; I'll test it out with some Linux kernel builds, too. I'll try to get that done

[PATCH] D147030: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2924 + default: +if (getTriple().getVendor() == llvm::Triple::Myriad) + return false; `return getTriple().getVendor() != llvm::Triple::Myriad;` Repository: rG LLVM

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

aaron.ballman added a comment. In D146412#4227644 , @Fznamznon wrote: >> Should OutputStream be made into a shared_ptr so we can clarify the memory >> ownership instead of leaving it as a raw pointer? That should also address >> the use-after-free. > >

[PATCH] D146908: [clang][MinGW] Add asan DLL lib before other libs and objects

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM overall. I wondered if the modified test runs correctly on Windows (any test that touches paths is prone to break) but I see that it seems to have run successfully on both Windows

[clang-tools-extra] 655baae - [clangd] Show used symbols on #include line hover.

Author: Viktoriia Bakalova Date: 2023-03-28T14:05:34Z New Revision: 655baae2af0b805a1c3e6d6338a32de05e342357 URL: https://github.com/llvm/llvm-project/commit/655baae2af0b805a1c3e6d6338a32de05e342357 DIFF: https://github.com/llvm/llvm-project/commit/655baae2af0b805a1c3e6d6338a32de05e342357.diff

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG655baae2af0b: [clangd] Show used symbols on #include line hover. (authored by VitaNuo). Changed prior to commit:

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl *TargetVarDecl = cast(TargetDecl); +Expr *Ex =

[PATCH] D146995: [clang-format][NFC] Refactor unit tests for "LambdaBodyIndentation: OuterScope" option.

jp4a50 added a comment. If you guys are happy with this, could you please merge it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146995/new/ https://reviews.llvm.org/D146995 ___ cfe-commits

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509028. VitaNuo added a comment. Remove unneeded code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

carlosgalvezp updated this revision to Diff 509064. carlosgalvezp added a comment. Fix typo in doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147062/new/ https://reviews.llvm.org/D147062 Files:

[clang] 498e150 - [Fuchsia][CMake] Always use multiple distribution model.

Author: Daniel Thornburgh Date: 2023-03-28T10:31:22-07:00 New Revision: 498e1506981f42c32656150b9d8e0408d91f9f23 URL: https://github.com/llvm/llvm-project/commit/498e1506981f42c32656150b9d8e0408d91f9f23 DIFF:

[PATCH] D146995: [clang-format][NFC] Refactor unit tests for "LambdaBodyIndentation: OuterScope" option.

HazardyKnusperkeks added a comment. In D146995#4227532 , @jp4a50 wrote: > If you guys are happy with this, could you please merge it for me? You need to state a name and email for the commit. > Edit: Also could you please advise about the failing CI

[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:278 with io.open(filename, 'w', encoding='utf8', newline='\n') as f: -f.write("""// RUN: %%check_clang_tidy %%s %(check_name_dashes)s %%t +f.write("""// RUN:

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3272 +3 - toward negative infinity +4 - to nearest, ties away from zero +The effect of passing some other value to ``__builtin_flt_rounds`` is I suspect this won't end up being

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

aaron.ballman added a comment. In D146973#4227266 , @jhuber6 wrote: > In D146973#4227114 , @aaron.ballman > wrote: > >> Hmmm, I've had experience with SYCL as to how it goes when you have >> difference between

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Ruturaj4 updated this revision to Diff 509004. Ruturaj4 added a comment. 1. Updating D146385 : [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef # 2. Enter a brief description of the changes included in this update. 3.

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

aaron.ballman added a comment. In D146148#4227088 , @zahiraam wrote: > In D146148#4224862 , @rjmccall > wrote: > >> In D146148#4224094 , >> @aaron.ballman wrote: >> >>>

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. In D146973#4227433 , @aaron.ballman wrote: > I am not asking you to implement a library based off another implementation's > specification. I am relaying implementation experience with the design you've > chosen for your

[PATCH] D146885: [clang-tidy][NFC] add debug log when clean empty namespace

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. This shouldn't be delivered. Do such tests, locally, instead of committing them. This change impact clang, and all tools, not only clang-tidy, therfor [clang-tidy] prefix is

[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though the change should come with a release note. Suggestion you can take or leave as you see fit: should we turn the places where we removed the null pointer check into assertions that the pointer is nonnull? Or are we

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509010. VitaNuo added a comment. Use vscode command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:111 +llvm::codegenoptions::DebugInfoKind +DebugLevelToInfoKind(const llvm::opt::Arg ); + SBallantyne wrote: > awarzynski wrote: > > awarzynski wrote: > > > CamelCase or

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509057. qiongsiwu1 added a comment. Fixing LTO data sections error check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

aaron.ballman added a comment. In D146973#4227470 , @jhuber6 wrote: > In D146973#4227433 , @aaron.ballman > wrote: > >> I am not asking you to implement a library based off another >> implementation's

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 updated this revision to Diff 509090. jhuber6 added a comment. Changing to use the `gpu-none-llvm` subfolder name that @sivachandra recommended. Also adding a `--sysroot` argument to show that this include path shows up first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. I'm trying to add the test case from: https://github.com/llvm/llvm-project/issues/45481#issuecomment-981028897, but lit test fails in `` not found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB marked an inline comment as not done. RitanyaB added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:111 +llvm::codegenoptions::DebugInfoKind +DebugLevelToInfoKind(const llvm::opt::Arg ); + awarzynski wrote: > SBallantyne wrote: > > awarzynski wrote: > > > awarzynski wrote:

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145591/new/ https://reviews.llvm.org/D145591

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL added a comment. Try to move some code to separate file, some utilty/... Add tests with tyepdefs. Add tests with class derive from type that it gets from template. Probably this code will be used in few more checks in future. try implement some virtual base validation, add some cache so

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Try refactoring code a lite bit, check suggestions, add tests for typedefs, and inheritance from template type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

carlosgalvezp updated this revision to Diff 509061. carlosgalvezp added a comment. Clean up check suffix in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147062/new/ https://reviews.llvm.org/D147062 Files:

[PATCH] D146840: [AMDGPU] Replace target feature for global fadd32

gandhi21299 updated this revision to Diff 509067. gandhi21299 added a comment. - removed builtins-amdgcn-gfx908.cl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146840/new/ https://reviews.llvm.org/D146840 Files:

[PATCH] D147021: [Builtins] Add __builtin_implicit_object_fence.

davidtgoldblatt created this revision. Herald added subscribers: jeroen.dobbelaere, kosarev. Herald added a project: All. davidtgoldblatt updated this revision to Diff 509069. davidtgoldblatt added a comment. davidtgoldblatt added a reviewer: rsmith. davidtgoldblatt published this revision for

[PATCH] D147070: Improve requirement clause limitation on non templated function

erichkeane created this revision. erichkeane added reviewers: clang-language-wg, shafik. Herald added a project: All. erichkeane requested review of this revision. The current implementation 6da3d66f03f9162ef341cc67218be40e22fe9808

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509091. qiongsiwu1 added a comment. Simplify LTO data section error check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147070: Improve requirement clause limitation on non templated function

cor3ntin added a comment. LGTM except the arguably missing tests. Comment at: clang/lib/Sema/SemaDecl.cpp:11886-11887 + // - an enumerator for an enumeration that is a templated entity, or + // - the closure type of a lambda-expression ([expr.prim.lambda.closure]) +

[clang-tools-extra] 2fccca8 - [clangd] Fix build by replacing unsigned long with std::vector::size_type.

Author: Viktoriia Bakalova Date: 2023-03-28T14:16:50Z New Revision: 2fccca8d743613fac4d68f7b14799a672394f64b URL: https://github.com/llvm/llvm-project/commit/2fccca8d743613fac4d68f7b14799a672394f64b DIFF: https://github.com/llvm/llvm-project/commit/2fccca8d743613fac4d68f7b14799a672394f64b.diff

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

aaron.ballman added a comment. In D146412#4223272 , @Fznamznon wrote: > In D146412#4220021 , @kastiglione > wrote: > >> I understand the potential for a use after free, since `OutputStream` is a >> raw pointer,

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509019. VitaNuo added a comment. Remove unrelated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[clang] 481e202 - [clang][doc] Fix link to SYCL compiler design doc

Author: Paulo Matos Date: 2023-03-28T18:09:52+02:00 New Revision: 481e20252461e730f36fb221123a853eda27cafc URL: https://github.com/llvm/llvm-project/commit/481e20252461e730f36fb221123a853eda27cafc DIFF: https://github.com/llvm/llvm-project/commit/481e20252461e730f36fb221123a853eda27cafc.diff

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu created this revision. zequanwu added reviewers: hans, shafik, rsmith, MaggieYi, gulfem. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/issues/45481

[PATCH] D147070: Improve requirement clause limitation on non templated function

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11886-11887 + // - an enumerator for an enumeration that is a templated entity, or + // - the closure type of a lambda-expression ([expr.prim.lambda.closure]) + // appearing in the

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:406 Decoration = "* "; - if (Lines.size() == 1 && !FirstInLine) { + if ((Lines.size() == 1 && !FirstInLine) || !Style.DecorateReflowedComments) { // Comments for which FirstInLine

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

HazardyKnusperkeks added a comment. Looks good to me, not giving my formal approval since the ongoing discussion about the style guide. Comment at: clang/include/clang/Format/Format.h:823 + /// \endcode + /// \version 16.0 + bool AlwaysBreakBeforeFunctionParameters;

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 509098. zequanwu added a comment. - Handle invalid start location. - Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files:

[PATCH] D146908: [clang][MinGW] Add asan DLL lib before other libs and objects

alvinhochun updated this revision to Diff 509030. alvinhochun retitled this revision from "[clang][MinGW] Add asan link flags before other libs and objects" to "[clang][MinGW] Add asan DLL lib before other libs and objects". alvinhochun added a comment. Updated per comments. Repository: rG

[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D147030: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true

brad updated this revision to Diff 509084. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147030/new/ https://reviews.llvm.org/D147030 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/integrated-as.c Index:

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added a comment. @garvitgupta08 what's your email address so that I may attribute your authorship correctly when committing on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:209 + + return this->visitStmt(S); +} tbaeder wrote: > aaron.ballman wrote: > > It's a bit of a surprise that we visit the entire body of the compound > > statement

[PATCH] D147070: Improve requirement clause limitation on non templated function

erichkeane updated this revision to Diff 509101. erichkeane added a comment. Took Corentin's advice and tried to test the lambda condition. THIS made me discover that we didn't properly implement this for lambdas at all! So this patch NOW also implements the restriction for lambdas.

[PATCH] D146408: [clang][Interp] Start supporting complex types

tbaeder updated this revision to Diff 509021. tbaeder set the repository for this revision to rG LLVM Github Monorepo. tbaeder added a comment. Add support for integer complex types as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146408/new/

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 509029. SBallantyne added a comment. Update style to mach style guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146814/new/ https://reviews.llvm.org/D146814 Files:

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509041. VitaNuo added a comment. Replace the used symbol computation impl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files:

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added a comment. I'm OK with injecting the path *now* with an understanding that it's a short-term "happens to work" way to move forward while we're working on a better solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146973/new/

[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

PiotrZSL added a comment. No comments from me, looks ok. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147062/new/ https://reviews.llvm.org/D147062 ___ cfe-commits mailing list

[PATCH] D147070: Improve requirement clause limitation on non templated function

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11898 + // defined... in a templated entity + !(DeclIsDefn && NewFD->isTemplated()) && + // a member of a templated entity Note we're using `isTemplated` here as

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added a comment. In D146973#4228070 , @tra wrote: > I'm OK with injecting the path *now* with an understanding that it's a > short-term "happens to work" way to move forward while we're working on a > better solution. So, the proposed path

[PATCH] D147037: [Clang][ICE] Corrected invalid invalid parameter index on some attributes with invalid indices applied to varargs functions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3764-3767 if (!checkFunctionOrMethodParameterIndex(S, D, AL, 1, IdxExpr, Idx)) return; - + if (Idx.getASTIndex() >= getFunctionOrMethodNumParams(D)) +return; aaron.ballman

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. The new option is renamed to `-mxcoff-roptr` to avoid confusions if we are using it during a pure linking job on non-AIX platforms. The option name now implies that it applies to XCOFF only, so silently ignoring the option on other platforms is not that serious a

[PATCH] D146840: [AMDGPU] Replace target feature for global fadd32

b-sumner added a comment. No objection here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146840/new/ https://reviews.llvm.org/D146840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 509158. ayzhao added a comment. use ParenListExpr and fix getSubExprAsWritten(...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib/AST/Expr.cpp

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:317 + ``-fno-data-sections``. When ``-mxcoff-roptr`` is in effect at link time, + read-only data sections with relocatable address values that resolve to + imported symbols are made

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

hvdijk created this revision. hvdijk added a reviewer: bader. hvdijk added a project: clang. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Herald added a project: All. hvdijk requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers:

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

hvdijk added a comment. > That's a good question. I haven't looked into this issue deep enough, but I > think using -fexceptions requires using delayed diagnostics to avoid false > diagnostics during host code analysis. I am assuming you mean `-fno-exceptions` (or, in `clang -cc1`, the absence

[clang] d978730 - [clang-repl] Add a command to load dynamic libraries

Author: Anubhab Ghosh Date: 2023-03-29T08:04:50+05:30 New Revision: d978730d8e2c10c76867b83bec2f1143d895ee7d URL: https://github.com/llvm/llvm-project/commit/d978730d8e2c10c76867b83bec2f1143d895ee7d DIFF: https://github.com/llvm/llvm-project/commit/d978730d8e2c10c76867b83bec2f1143d895ee7d.diff

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGd978730d8e2c: [clang-repl] Add a command to load dynamic libraries (authored by argentite). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/

[clang] 279c7a2 - Revert "[C++20] [Modules] Don't load declaration eagerly for named modules"

Author: Chuanqi Xu Date: 2023-03-29T11:15:38+08:00 New Revision: 279c7a2f17937836ed13e359c3fb381bef7defaf URL: https://github.com/llvm/llvm-project/commit/279c7a2f17937836ed13e359c3fb381bef7defaf DIFF: https://github.com/llvm/llvm-project/commit/279c7a2f17937836ed13e359c3fb381bef7defaf.diff

[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

carlosgalvezp added a comment. In D147062#4228403 , @ccotter wrote: > If https://github.com/isocpp/CppCoreGuidelines/issues/2060 is accepted to > only consider `[=]`, then I assume we'd want to change the default value of >

[PATCH] D146908: [clang][MinGW] Add asan DLL lib before other libs and objects

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sanitizers.c:2 +// RUN: touch %t.a +// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address -lcomponent %/t.a 2>&1 | FileCheck --check-prefixes=ASAN-ALL,ASAN-I686 -DINPUT=%/t.a %s +// RUN: %clang

[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d4c0f973460: [clang-tidy] Add option to ignore capture default by reference in… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 4d4c0f9 - [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

Author: Carlos Galvez Date: 2023-03-28T20:36:34Z New Revision: 4d4c0f9734607bb0423593b060b8fa73c06fe3d3 URL: https://github.com/llvm/llvm-project/commit/4d4c0f9734607bb0423593b060b8fa73c06fe3d3 DIFF: https://github.com/llvm/llvm-project/commit/4d4c0f9734607bb0423593b060b8fa73c06fe3d3.diff

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. In D145803#4220124 , @wolfgangp wrote: > In D145803#4219894 , @probinson > wrote: > >> This is pretty different from the "always desugar to the canonical type" >> habit that has

[PATCH] D147081: [clang-tidy] Fix issues in bugprone-assert-side-effect

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:66 + + const auto *FuncDecl = CExpr->getDirectCallee(); + if (!FuncDecl || !FuncDecl->getDeclName().isIdentifier()) Please do not use `auto` if

[PATCH] D146887: [clang-tidy] Fix if-constexpr false-positive in readability-misleading-indentation

PiotrZSL updated this revision to Diff 509136. PiotrZSL added a comment. Move tests to new file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146887/new/ https://reviews.llvm.org/D146887 Files:

[PATCH] D147081: [clang-tidy] Fix issues in bugprone-assert-side-effect

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:66 + + const auto *FuncDecl = CExpr->getDirectCallee(); + if (!FuncDecl || !FuncDecl->getDeclName().isIdentifier()) PiotrZSL wrote: >

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ added a comment. So in a nutshell, this is the intended behavior: | code | diagnostic | EmitFixits && EmitSuggestions | !EmitFixits && EmitSuggestions | !EmitFixits && !EmitSuggestions | |

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:647 +def err_roptr_requires_data_sections: Error<"-mxcoff-roptr is supported only with -fdata-sections">; +def err_roptr_cannot_build_shared: Error<"-mxcoff-roptr is not

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

bader added a comment. @hvdijk, thanks a lot for fixing this. In D147097#4229121 , @hvdijk wrote: > Is the rationale I gave in the description correct, or would it be better for > SYCL device code to unconditionally build without `-fexceptions` and get

  1   2   3   >