[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

andrew.w.kaylor added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1340 + if (!IsEnabled) +NewFPFeatures.setDisallowFenvAccess(IsEnabled); FpPragmaStack.Act(Loc, PSK_Set, StringRef(), NewFPFeatures); Why is this only needed for "!IsEnabled"?

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

erichkeane added a comment. That sounds appropriate to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147791/new/ https://reviews.llvm.org/D147791 ___ cfe-commits mailing list

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

andrew.w.kaylor added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.c:239 +// CHECK-LABEL: @func_20 +// STRICT: call float @llvm.experimental.constrained.fadd.f32(float {{.*}}, float {{.*}}, metadata !"round.tonearest", metadata !"fpexcept.strict") +//

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. OK was able to create small(ish) repro main.h #include enum class Enums { ACCESS = 0, MAP = 1, }; template class DMap { public: template requires std::is_convertible_v void getOrCreate(TIDR v); }; template

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

erichkeane updated this revision to Diff 511753. erichkeane added a comment. Made changes as requested by Richard. "SkipForInstantiation" needed to be added when we added levels, but I think this is something that probably needs to be looked at and removed in the future. I also see the change

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

njames93 created this revision. njames93 added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void updated this revision to Diff 511772. void added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Fix compilation issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

njames93 updated this revision to Diff 511780. njames93 added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147802/new/ https://reviews.llvm.org/D147802 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

nickdesaulniers added a comment. In D146269#4239702 , @wzssyqa wrote: > ping @maskray is offline until Tuesday April 11. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

aaronpuchert added a comment. Herald added a project: All. In the meantime, this has apparently been addressed via D104478 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth created this revision. paulkirth added reviewers: phosek, MaskRay, enh, hiraditya, vit9696. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, asb, arichardson, inglorion. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers:

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

Manna added a comment. In D147791#4251497 , @erichkeane wrote: > I don't see much value in these changes. In the cases I know anything about, > the change in state (or out params) is the error checking that we need. The > casts add nothing but

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

haberman added a comment. > is a [[should_tail]] attribute sort of thing: a tail-hint where we do 'best > effort with no promises', and make no guarantees that we're going to tail it. I'm not sure I see the value in that. The compiler already optimizes tail calls when it can in a best-effort

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a comment. So to make some conclusion - there is a need for less strict version of musttail in LLVM, right? Ideally platform specific, like x86_musttail? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147714/new/ https://reviews.llvm.org/D147714

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

haberman added a comment. `[[nonportable_musttail]]` makes sense to me as a semantic. It indicates that the algorithm requires tail calls, but the author is willing to accept that the algorithm may be non-portable. "Non-portable" here can mean architecture-specific, but it can also mean

[clang] 2cbf512 - [Clang] Improve designated inits diagnostic location

Author: Bill Wendling Date: 2023-04-07T11:37:05-07:00 New Revision: 2cbf5127d58553fd6224a1ec809536bccc5b8510 URL: https://github.com/llvm/llvm-project/commit/2cbf5127d58553fd6224a1ec809536bccc5b8510 DIFF: https://github.com/llvm/llvm-project/commit/2cbf5127d58553fd6224a1ec809536bccc5b8510.diff

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cbf5127d585: [Clang] Improve designated inits diagnostic location (authored by void). Changed prior to commit:

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 511760. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index: clang/test/CodeGen/pragma-fenv_access.c

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

nickdesaulniers added a comment. This came up in https://lore.kernel.org/llvm/ebe3e940-b8ee-4682-a1f6-1ccf98eac...@flygoat.com/ (follow up thread, FWIW: https://lore.kernel.org/llvm/20230407102721.14814-1-jiaxun.y...@flygoat.com/) CHANGES SINCE LAST ACTION

[PATCH] D147815: [clang][deps] Print timing information

akyrtzi added a comment. Could you also add a `-terse` option, to avoid printing the full dependency info, if you mainly want to get the timing? Something like this: T.stopTimer(); if (PrintTiming) llvm::errs() << llvm::format( "clang-scan-deps timing: %0.2fs wall, %0.2fs

[clang] a046d18 - [-Wunsafe-buffer-usage] FixableGadget for handling stand alone pointers under UPC

Author: MalavikaSamak Date: 2023-04-07T15:32:19-07:00 New Revision: a046d187720137d944cece4aa4561f4bceb54e3c URL: https://github.com/llvm/llvm-project/commit/a046d187720137d944cece4aa4561f4bceb54e3c DIFF: https://github.com/llvm/llvm-project/commit/a046d187720137d944cece4aa4561f4bceb54e3c.diff

[PATCH] D143676: [-Wunsafe-buffer-usage] FixableGadget for handling stand alone pointers under UPC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa046d1877201: [-Wunsafe-buffer-usage] FixableGadget for handling stand alone pointers under… (authored by malavikasamak). Herald added a project:

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. There is a benefit to not having bitcast noise in the IR Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1962-1963 +// llvm.amdgcn.permlanex16.f32 +def

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

rsmith added a comment. What *should* happen here is that the lookup for `operator=` in `Inner::invokeAssign` should walk up the enclosing `Scope`s and `DeclContext`s, traversing both the results from the `IdResolver` and the results from `DeclContext` lookups. First, we should look in the

[PATCH] D147823: [clang-repl] Reduce dynamic-library.cpp test to only load shared library

v.g.vassilev added a comment. Could we use yaml2obj instead of uploading the binary? I see other tests using it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147823/new/ https://reviews.llvm.org/D147823

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. njames93 marked 2 inline comments as done. Closed by commit rG376168babb51: [clang-tidy] Add modernize-type-traits check (authored by

[clang-tools-extra] 376168b - [clang-tidy] Add modernize-type-traits check

Author: Nathan James Date: 2023-04-07T18:38:15+01:00 New Revision: 376168babb51aa08bc864d4797db4a6dbd53fdbc URL: https://github.com/llvm/llvm-project/commit/376168babb51aa08bc864d4797db4a6dbd53fdbc DIFF: https://github.com/llvm/llvm-project/commit/376168babb51aa08bc864d4797db4a6dbd53fdbc.diff

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

erichkeane added a comment. In D147714#4251690 , @haberman wrote: >> is a [[should_tail]] attribute sort of thing: a tail-hint where we do 'best >> effort with no promises', and make no guarantees that we're going to tail it. > > I'm not sure I see the

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4236 + +// Use the -march=help flag as the dummy input to cc1. +Actions.clear(); MaskRay wrote: > Why is the code needed? Can --print-supported-extensions reuse the approach >

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/forwarding-reference-param-not-forwarded.cpp:138 + +} // namespace negative_cases ccotter wrote: > PiotrZSL wrote: > > what about when someone uses std::move

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

erichkeane added a comment. I don't see much value in these changes. In the cases I know anything about, the change in state (or out params) is the error checking that we need. The casts add nothing but noise, so I don't think these are good changes. Repository: rG LLVM Github Monorepo

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:170 + +static constexpr char Bind[] = ""; + ccotter wrote: > NIT: should the bound node have some meaningful

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15660 case BO_Assign: +// Skip diagnose on compound assignment. +DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. In D147655#4251042 , @aaron.ballman wrote: > In D147655#4250922 , @royjacobson > wrote: > >> In D147655#4250056 , @rsmith wrote: >> >>> There

[clang] 33cf2a3 - [NFC][clang] Fix static analyzer tool remarks about large copies by values

Author: Manna, Soumi Date: 2023-04-07T16:38:07-04:00 New Revision: 33cf2a39cb11681068b1abaa20ffe1d4d732ae38 URL: https://github.com/llvm/llvm-project/commit/33cf2a39cb11681068b1abaa20ffe1d4d732ae38 DIFF: https://github.com/llvm/llvm-project/commit/33cf2a39cb11681068b1abaa20ffe1d4d732ae38.diff

[clang] 00ea679 - [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

Author: Ben Hamilton Date: 2023-04-07T16:10:52-06:00 New Revision: 00ea6798959d358aff9d7ef0907bbe241be7f7a4 URL: https://github.com/llvm/llvm-project/commit/00ea6798959d358aff9d7ef0907bbe241be7f7a4 DIFF: https://github.com/llvm/llvm-project/commit/00ea6798959d358aff9d7ef0907bbe241be7f7a4.diff

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00ea6798959d: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser (authored by benhamilton). Repository: rG LLVM Github Monorepo

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

benhamilton added a comment. Filed https://github.com/llvm/llvm-project/issues/62007 on the buildkite failure (despite it being in `git-clang-format`, I'm about 98% sure it's unrelated). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147577/new/

[clang] c530232 - [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

Author: Xiang Li Date: 2023-04-07T18:33:47-04:00 New Revision: c5302325b2a62d77cf13dd16cd5c19141862fed0 URL: https://github.com/llvm/llvm-project/commit/c5302325b2a62d77cf13dd16cd5c19141862fed0 DIFF: https://github.com/llvm/llvm-project/commit/c5302325b2a62d77cf13dd16cd5c19141862fed0.diff

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

rsmith added a comment. Ah, I see. In D147782#4251185 , @J-Camilleri wrote: > 2. Have the `IdResolver` declarations ordered by scope, going from most > nested to least nested. This is the intended behavior. But `Sema::PushOnScopeChains` doesn't

[clang] 231107a - Re-apply "[ORC] LLJIT updates: ExecutorNativePlatform, default ..." with fixes.

Author: Lang Hames Date: 2023-04-08T02:40:58Z New Revision: 231107a8b5be77d1c76975b0363976ba3211fa37 URL: https://github.com/llvm/llvm-project/commit/231107a8b5be77d1c76975b0363976ba3211fa37 DIFF: https://github.com/llvm/llvm-project/commit/231107a8b5be77d1c76975b0363976ba3211fa37.diff LOG:

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511709. Mordante added a comment. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511715. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1340 + if (!IsEnabled) +NewFPFeatures.setDisallowFenvAccess(IsEnabled); FpPragmaStack.Act(Loc, PSK_Set, StringRef(), NewFPFeatures); andrew.w.kaylor wrote: > Why is this only needed

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 511757. HerrCai0907 added a comment. Herald added a subscriber: ChuanqiXu. update according to comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/ https://reviews.llvm.org/D147194 Files:

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna added a comment. Thanks @erichkeane. I have committed the patch here: https://reviews.llvm.org/rG33cf2a39cb11 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 ___ cfe-commits mailing list

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

shafik added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1328 // namespace scope - SearchNamespaceScope = false; + SearchNamespaceScope = Name.getCXXOverloadedOperator() == OO_Equal; } Maybe we should also add

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

zhuhan0 added a comment. I've put up https://reviews.llvm.org/D147823. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/ https://reviews.llvm.org/D141824 ___ cfe-commits mailing list

[clang-tools-extra] 92910a5 - [clang-tidy] fix concat-nest-namespace fix hint remove the macro

Author: Congcong Cai Date: 2023-04-08T06:24:26+02:00 New Revision: 92910a51b9043550cec6c9e63a5b92a15d42c665 URL: https://github.com/llvm/llvm-project/commit/92910a51b9043550cec6c9e63a5b92a15d42c665 DIFF: https://github.com/llvm/llvm-project/commit/92910a51b9043550cec6c9e63a5b92a15d42c665.diff

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG92910a51b904: [clang-tidy] fix concat-nest-namespace fix hint remove the macro (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147839: [clang] Add test for CWG2007

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2007 is resolved by skipping unqualified

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 marked 2 inline comments as done. HerrCai0907 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:88 + StringRef TokText = getRawStringRef(TokRange, SM, LangOpts); + if (TokText != "// namespace " +

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf799901c06c0: [Clang][Sema] Add MultiLevelTemplateArgumentList::dump (authored by alexander-shaposhnikov). Changed prior to commit:

[clang] f799901 - [Clang][Sema] Add MultiLevelTemplateArgumentList::dump

Author: Alexander Shaposhnikov Date: 2023-04-07T19:36:59Z New Revision: f799901c06c015cc30cf123a8f0c01f8b107669e URL: https://github.com/llvm/llvm-project/commit/f799901c06c015cc30cf123a8f0c01f8b107669e DIFF:

[PATCH] D147815: [clang][deps] Print timing information

jansvoboda11 created this revision. jansvoboda11 added a reviewer: akyrtzi. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds new `-print-timing`

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

benhamilton added a subscriber: goncharov. benhamilton added a comment. In D147577#4252225 , @MyDeveloperDay wrote: > The build machines aren’t using a latest enough version of clang-format for > our local .clang-format file Thanks, that's what I

[PATCH] D147836: [clang] Add test for CWG1822

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1822 is resolved by specifying that the body

[PATCH] D147840: [clang][Interp] Handle DiscardResult for DeclRef- and ParenExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D147840: [clang][Interp] Handle DiscardResult for DeclRef- and ParenExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:240 +return this->emitPop(*T, PE); + } + Next time this pattern shows up, I need to add a convenience function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 511762. philnik marked 2 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files:

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4251076 , @aaron.ballman wrote: > One thing I can't quite determine is whether we expect to call this type > trait often or not. Are either of the uses in libc++ going to be instantiated > frequently? I'm trying to

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 511795. python3kgae added a comment. Update the comment done by rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 511847. ccotter added a comment. - Rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. The change makes more sense to me, thanks! Comment at: clang/test/CodeGen/pragma-fenv_access.c:239 +// CHECK-LABEL: @func_20 +// STRICT: call float

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

erichkeane added a comment. In D147714#4251752 , @xbolva00 wrote: > So to make some conclusion - there is a need for less strict version of > musttail in LLVM, right? Ideally platform specific, like x86_musttail? I'm not sure what the rules for the

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

void marked an inline comment as done. void added inline comments. Comment at: clang/test/SemaCXX/cxx2b-designated-initializers.cpp:13 + const S result { // expected-error {{field designator (null) does not refer to any field in type 'const S'}} +.a = x + };

[PATCH] D146240: [libc++][format] Use granularized charconv.

owenpan removed a reviewer: owenpan. Herald added a reviewer: owenpan. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC`

[clang] 13d44a8 - Revert "[Clang][Sema] Fix comparison of constraint expressions"

Author: Alexander Shaposhnikov Date: 2023-04-07T18:41:57Z New Revision: 13d44a8f5647819efd3ef57af384a3666f99d066 URL: https://github.com/llvm/llvm-project/commit/13d44a8f5647819efd3ef57af384a3666f99d066 DIFF:

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

void added a comment. In D147580#4250232 , @shafik wrote: > I guess I should have waited till I saw: https://reviews.llvm.org/D147673 Yeah, sorry about that. I realized that I still needed to add the testcase before continuing. :-) Repository: rG

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 511763. HerrCai0907 marked 4 inline comments as done. HerrCai0907 added a comment. reorder fixhint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/ https://reviews.llvm.org/D147194 Files:

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. I've debugged a bit what's going on in https://godbolt.org/z/7h3sPe85h we pass ForConstaintInstantiation=true and this causes us for the in-class FunctionTemplateDecl pick up the outer layer of template args (i.e. MLTAL will contain

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

MyDeveloperDay added a comment. The build machines aren’t using a latest enough version of clang-format for our local .clang-format file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147577/new/ https://reviews.llvm.org/D147577

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. In D147714#4249274 , @efriedma wrote: > Any thoughts on diagnostics here? If I'm not mistaken, with this patch, if > you

[PATCH] D147823: [clang-repl] Reduce dynamic-library.cpp test to only load shared library

zhuhan0 created this revision. Herald added subscribers: hoy, wenlei. Herald added a project: All. zhuhan0 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up to the discussion in https://reviews.llvm.org/D141824. Because the purpose

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 updated this revision to Diff 511702. njames93 added a comment. Rebased and sorted release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.org/D137302 Files:

[clang] d89c653 - [Clang] Fix filtering of inline namespaces for friend functions

Author: Shafik Yaghmour Date: 2023-04-07T08:58:39-07:00 New Revision: d89c6530fdb57da31f4750bf941a0e4a090c4474 URL: https://github.com/llvm/llvm-project/commit/d89c6530fdb57da31f4750bf941a0e4a090c4474 DIFF:

[PATCH] D147762: [Clang] Fix filtering of inline namespaces for friend functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd89c6530fdb5: [Clang] Fix filtering of inline namespaces for friend functions (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511704. paulkirth marked an inline comment as done. paulkirth added a comment. Remove unrelated whitespace changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added projects: All, clang, clang-format. Herald added reviewers:

[clang] f9b854b - [Clang] Fix buildbots after Fix filtering of inline namespaces for friend functions commit

Author: Shafik Yaghmour Date: 2023-04-07T09:18:15-07:00 New Revision: f9b854bc8f0bfe2a38b00fab401bb1982eb8e61e URL: https://github.com/llvm/llvm-project/commit/f9b854bc8f0bfe2a38b00fab401bb1982eb8e61e DIFF:

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511705. Mordante marked 2 inline comments as done. Mordante added a comment. Rebased, addresses review comment, and get a CI run. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante marked 4 inline comments as done. Mordante added a comment. Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Thanks for the review! Comment at:

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

yozhu added a comment. In D147764#4250636 , @chapuni wrote: > FYI it's netter to mention diff id like D145803 > rather than commit hash, as far as is is > based on the diff. Yes, will include diff ID in commit

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni added a comment. FYI it's netter to mention diff id like D145803 rather than commit hash, as far as is is based on the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

pengfei added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.c:239 +// CHECK-LABEL: @func_20 +// STRICT: call float @llvm.experimental.constrained.fadd.f32(float {{.*}}, float {{.*}}, metadata !"round.tonearest", metadata !"fpexcept.strict") +// DEFAULT:

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

pengfei added a comment. Remove the `fenv_04_06.patch` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni added a comment. This is an obvious fix and builds are still broken. Go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing

[PATCH] D147742: [python] Enable bindings tests on Windows

R2RT added a comment. According to CI logs, these tests are still not run on Windows builder. Line below, present in Debian's log, is missing. [9746/10613] cd /var/lib/buildkite-agent/builds/llvm-project/clang/bindings/python && /usr/bin/cmake -E env CLANG_NO_DEFAULT_CONFIG=1

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 511630. Krishna-13-cyber added a comment. Thanks a lot everyone for helping me out with my first patch. I have uploaded the patch again after rebase. Yes, It would be great if you could land it on my behalf. Name: Krishna Narayanan Email: Thanks

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet updated this revision to Diff 511634. courbet added a comment. Fix release note placement and phrase it more consistenly with other notes in that section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/

[PATCH] D147731: [3/N][POC][Clang] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 511635. eopXD added a comment. Change: Add overloaded name `vlseg2e32_tuple` for the tuple type variant to avoid naming collision to the existing non-tuple type overloaded intrinsics of `vlseg2e32`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D147774: [4/N][POC][Clang] Define tuple type variant of vsseg2e32

eopXD created this revision. eopXD added reviewers: craig.topper, rogfer01, frasercrmck, reames, kito-cheng, nikic. Herald added subscribers: luke, StephenFan, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27,

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

royjacobson added a comment. In D147655#4250056 , @rsmith wrote: > There has not been any stable ABI from any compiler targeting the Itanium C++ > ABI for constrained templates prior to this change. I don't think we need to > worry too much about

[clang] 53d8b59 - Fix the two gmoules-prefered-name-* tests

Author: YongKang Zhu Date: 2023-04-07T00:12:29-07:00 New Revision: 53d8b59307d4e1bbaa1632efbe762014c9f6575e URL: https://github.com/llvm/llvm-project/commit/53d8b59307d4e1bbaa1632efbe762014c9f6575e DIFF: https://github.com/llvm/llvm-project/commit/53d8b59307d4e1bbaa1632efbe762014c9f6575e.diff

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53d8b59307d4: Fix the two gmoules-prefered-name-* tests (authored by yozhu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f197521 - [Clang] Fix markup in cxx_status

Author: Corentin Jabot Date: 2023-04-07T09:42:54+02:00 New Revision: f1975216846ed69d608e669c37efa5ee0e16276e URL: https://github.com/llvm/llvm-project/commit/f1975216846ed69d608e669c37efa5ee0e16276e DIFF:

[PATCH] D146376: Update static_assert message for redundant cases

xbolva00 added a comment. So.. new diagnostic is: :4:1: error: static assertion failed due to requirement 'is_gitlab' static_assert(is_gitlab and is_weekend); ^ ~ Okay, a dev changes is_gitlab to true, compiles it again and boom, new error: static assertion failed due

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. doh, forgot to send Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:128 +*OS << "" << HTMLLogger_css << "\n"; +*OS << "" << HTMLLogger_js << "\n"; + gribozavr2 wrote: > Now that we have an HTML template file, you

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

Michael137 added a comment. Thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >