[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D150226#4332024 , @erichkeane wrote: > One of the buildbot failures is the test you modified (\dr1xx.c), so I > suspect it is related. > > I THINK this needs a notice on the 'breaking changes' mailing list as well. > >

[PATCH] D150116: clang-format: [JS] support import/export type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34b422bafbd9: clang-format: [JS] support import/export type (authored by jankuehle, committed by krasimir). Repository: rG LLVM Github Monorepo

[clang] 34b422b - clang-format: [JS] support import/export type

Author: Jan Kuhle Date: 2023-05-10T15:27:03+02:00 New Revision: 34b422bafbd934ee3c644fd7a8f0b6803976c818 URL: https://github.com/llvm/llvm-project/commit/34b422bafbd934ee3c644fd7a8f0b6803976c818 DIFF: https://github.com/llvm/llvm-project/commit/34b422bafbd934ee3c644fd7a8f0b6803976c818.diff

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. One of the buildbot failures is the test you modified (\dr1xx.c), so I suspect it is related. I THINK this needs a notice on the 'breaking changes' mailing list as well. For release notes, I'd put it in the 'Potentially Breaking Changes' section. CHANGES SINCE

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

thakis added a comment. This broke check-clang on windows: http://45.33.8.238/win/78359/step_7.txt (The Driver/split-debug.c failure is something else and since fixed, but the other two tests are due to this change.) Please take a look and revert for now if it takes a while to fix.

[clang] d526e2e - Add -no-canonical-prefixes to test that matches the binary name

Author: Benjamin Kramer Date: 2023-05-10T13:17:35+02:00 New Revision: d526e2ec957fc7bc31d7be3670cd1673c2b4389b URL: https://github.com/llvm/llvm-project/commit/d526e2ec957fc7bc31d7be3670cd1673c2b4389b DIFF:

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder updated this revision to Diff 520954. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews.llvm.org/D150209 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/shifts.cpp Index: clang/test/AST/Interp/shifts.cpp

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b240cc377b5: [tidy] Expose getID to tidy checks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150254/new/

[clang-tools-extra] 2b240cc - [tidy] Expose getID to tidy checks

Author: Kadir Cetinkaya Date: 2023-05-10T12:50:25+02:00 New Revision: 2b240cc377b5e4f41c05d68c9a513f7d08ab69c8 URL: https://github.com/llvm/llvm-project/commit/2b240cc377b5e4f41c05d68c9a513f7d08ab69c8 DIFF:

[PATCH] D150192: Allow clang to emit inrange metadata when generating code for array subscripts

shiva0217 added a comment. In D150192#4330199 , @efriedma wrote: > From what I recall, "inrange" is actually more restrictive than the normal > C/C++ array indexing rules. Specifically, the bits regarding comparisons. > "inrange" was designed to allow

[PATCH] D150257: [clangd] Initialize clang-tidy modules only once

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62a090f958ce: [clangd] Initialize clang-tidy modules only once (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 62a090f - [clangd] Initialize clang-tidy modules only once

Author: Kadir Cetinkaya Date: 2023-05-10T12:32:33+02:00 New Revision: 62a090f958ce02a8035e3c9424a05dbfe25859e1 URL: https://github.com/llvm/llvm-project/commit/62a090f958ce02a8035e3c9424a05dbfe25859e1 DIFF:

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet added a comment. In D150254#4331738 , @njames93 wrote: > In D150254#4331640 , @kadircet > wrote: > >> see >>

[PATCH] D150257: [clangd] Initialize clang-tidy modules only once

kadircet updated this revision to Diff 520948. kadircet marked 4 inline comments as done. kadircet added a comment. - Move ReplayPreambleTests to its own file and move registry to global scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 48bbc64 - [NFC] [C++20] [Modules] Code cleanups when checking modules in ADL

Author: Chuanqi Xu Date: 2023-05-10T17:53:47+08:00 New Revision: 48bbc64a8ff5e3777a76a02cffd94b3786b93203 URL: https://github.com/llvm/llvm-project/commit/48bbc64a8ff5e3777a76a02cffd94b3786b93203 DIFF: https://github.com/llvm/llvm-project/commit/48bbc64a8ff5e3777a76a02cffd94b3786b93203.diff

[clang] b6c7177 - [C++20] [Modules] Don't generate unused variables in other module units

Author: Chuanqi Xu Date: 2023-05-10T17:41:58+08:00 New Revision: b6c7177145bc439c712208bfbe041db212c5262d URL: https://github.com/llvm/llvm-project/commit/b6c7177145bc439c712208bfbe041db212c5262d DIFF: https://github.com/llvm/llvm-project/commit/b6c7177145bc439c712208bfbe041db212c5262d.diff

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

alejandro-alvarez-sonarsource created this revision. alejandro-alvarez-sonarsource added a reviewer: aaron.ballman. alejandro-alvarez-sonarsource added a project: clang. Herald added a subscriber: kadircet. Herald added a project: All. alejandro-alvarez-sonarsource requested review of this

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet updated this revision to Diff 520936. kadircet added a comment. - Expose getID to tidy-checks and use it instead of storing checkname Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150254/new/ https://reviews.llvm.org/D150254 Files:

[PATCH] D150257: [clangd] Initialize clang-tidy modules only once

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:478 trace::Span Tracer("ClangTidyInit"); -tidy::ClangTidyCheckFactories CTFactories; -for (const

[PATCH] D150126: [clang-tidy][WIP] Set traversal scope to prevent analysis in headers

njames93 created this revision. njames93 added reviewers: carlosgalvezp, PiotrZSL. Herald added a subscriber: xazax.hun. Herald added a project: All. njames93 updated this revision to Diff 520620. njames93 added a comment. njames93 updated this revision to Diff 520918. njames93 retitled this

[PATCH] D150257: [clangd] Initialize clang-tidy modules only once

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: carlosgalvezp, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

njames93 added a comment. In D150254#4331734 , @hokein wrote: > The fix looks good. > > We also have a `CheckName` field in the base class `ClangTidyCheck`, however > that's field is private, we can't not access, we could consider make it > protected

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

njames93 added a comment. In D150254#4331640 , @kadircet wrote: > see > https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidy.cpp#L638 > for such a pattern, clangd also initializes checks with a similar approach. In

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The fix looks good. We also have a `CheckName` field in the base class `ClangTidyCheck`, however that's field is private, we can't not access, we could consider make it protected (I think

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added a subscriber: sdesmalen. rsandifo-arm added a comment. Thanks for the review. Comment at: clang/include/clang/Basic/Attr.td:2427-2430 +def ArmStreaming : TypeAttr, TargetSpecificAttr { + let Spellings = [RegularKeyword<"__arm_streaming">]; + let

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

pcwang-thead accepted this revision. pcwang-thead added a comment. LGTM. Though I don't like the way that we need to loop `MxList` again when defining scheduling model, I think this can be a good practice to define RVV scheduling model in current TableGen's grammar. Comment

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

craig.topper added a comment. Don’t you need to make f16 vectors legal types in the backend? And you need to disable intrinsics for instructions that aren’t supported by Zfhmin. Like f16 vector fadd And you also need to make the backend only allow f16 vector operations that are supported with

[clang] f109b10 - [NFC] [C++20] [Modules] Refactor Sema::isModuleUnitOfCurrentTU into

Author: Chuanqi Xu Date: 2023-05-10T16:01:27+08:00 New Revision: f109b1016801e2b0dbee278f3c517057c0b1d441 URL: https://github.com/llvm/llvm-project/commit/f109b1016801e2b0dbee278f3c517057c0b1d441 DIFF: https://github.com/llvm/llvm-project/commit/f109b1016801e2b0dbee278f3c517057c0b1d441.diff

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Hi, could you please provide a code review again? Thanks. With best regards, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https://reviews.llvm.org/D140275 ___

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

sberg added a comment. In D148505#4302702 , @aaron.ballman wrote: > Thank you for poking on this! FWIW, I don't know that there's a way to > cross-post to Discourse (but if I'm wrong and there is, I'd love to know > how!). Ping, any further input

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

jmmartinez added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:524 + SIAtomicAddrSpace::NONE) + return enableSC0Bit(MI) | enableSC1Bit(MI); +return false; NIT: Is the use of the bitwise or " | " intended? I'd use the

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet added a comment. see https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidy.cpp#L638 for such a pattern, clangd also initializes checks with a similar approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet created this revision. kadircet added reviewers: hokein, PiotrZSL. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[clang] 99f933b - [test] Clean up Driver/check-time-trace*

Author: Fangrui Song Date: 2023-05-10T00:19:46-07:00 New Revision: 99f933b6346b0afcafa3c1ea0972136d7b441a86 URL: https://github.com/llvm/llvm-project/commit/99f933b6346b0afcafa3c1ea0972136d7b441a86 DIFF: https://github.com/llvm/llvm-project/commit/99f933b6346b0afcafa3c1ea0972136d7b441a86.diff

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

jhenderson added a comment. In D149119#4331207 , @ikudrin wrote: > In D149119#4329274 , @tmatheson > wrote: > >> LGTM, thank you for doing this. Please give it a couple of days in case >> others have comments.

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:136 +if (LHS.isNegative()) + S.CCEDiag(E, diag::note_constexpr_lshift_of_negative) << 12; +else if (LHS.toUnsigned().countLeadingZeros() < static_cast(RHS)) shafik wrote: > Do

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520914. junaire added a comment. Add some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520913. junaire added a comment. Remove unused code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520912. junaire added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

<    1   2