[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta updated this revision to Diff 540302. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 Files: clang/lib/Driver/Driver.cpp lld/COFF/Driver.cpp lld/COFF/Driver.h

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta updated this revision to Diff 540301. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 Files: clang/lib/Driver/Driver.cpp

[PATCH] D155217: [clang-tidy][include-cleaner] Don't warn for the same symbol twice

VitaNuo added a comment. Hi Alex, Thank you for the patch. We are aware that issuing one diagnostic per symbol reference might be overwhelming. However, we have decided to choose it over other options after considering the use cases that we'd like to cover. This check is intended to be used in

[PATCH] D155202: [clang][dataflow] Simplify implementation of `transferStdForwardCall()` in optional check.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:683 - StorageLocation *LocRet = State.Env.getStorageLocation(*E, SkipPast::None); - if (LocRet != nullptr) -

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta updated this revision to Diff 540304. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 Files: clang/lib/Driver/Driver.cpp lld/COFF/Driver.cpp lld/COFF/Driver.h

[PATCH] D154596: [RISCV] Fix required features checking with empty string

wangpc accepted this revision. wangpc added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154596/new/ https://reviews.llvm.org/D154596 ___ cfe-commits mailing list

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta marked 6 inline comments as done. thieta added a comment. - Split the relative patch to this diff https://reviews.llvm.org/D155268 - Added some comments in both Clang and LLD - Fixed some code style. - Removed stray changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 8fe0449 - [RISCV] Fix required features checking with empty string

Author: Jim Lin Date: 2023-07-14T16:09:11+08:00 New Revision: 8fe0449ac99087c74f785ddbdd4fbba65b396b3b URL: https://github.com/llvm/llvm-project/commit/8fe0449ac99087c74f785ddbdd4fbba65b396b3b DIFF: https://github.com/llvm/llvm-project/commit/8fe0449ac99087c74f785ddbdd4fbba65b396b3b.diff LOG:

[PATCH] D154596: [RISCV] Fix required features checking with empty string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe0449ac990: [RISCV] Fix required features checking with empty string (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155270: [clang][Interp] Basic support for bit fields

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 61e0822 - [llvm][clang] Remove uses of isOpaquePointerTy() (NFC)

Author: Nikita Popov Date: 2023-07-14T10:27:58+02:00 New Revision: 61e0822efab14dd922f9c3ee479a0a51952526d9 URL: https://github.com/llvm/llvm-project/commit/61e0822efab14dd922f9c3ee479a0a51952526d9 DIFF: https://github.com/llvm/llvm-project/commit/61e0822efab14dd922f9c3ee479a0a51952526d9.diff

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

phosek added inline comments. Comment at: flang-rt/CMakeLists.txt:17-23 +# Check if flang-rt is built as a standalone project. +if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR FLANG_RT_STANDALONE_BUILD) + project(FlangRT C CXX) + set(CMAKE_INCLUDE_CURRENT_DIR ON) +

[clang-tools-extra] 5649b24 - [clangd] Fix an assertion failure in NamedDecl::getName during the prepareRename

Author: Haojian Wu Date: 2023-07-14T09:17:46+02:00 New Revision: 5649b24c48ab3b48c1cb89155626a7f128c3f598 URL: https://github.com/llvm/llvm-project/commit/5649b24c48ab3b48c1cb89155626a7f128c3f598 DIFF: https://github.com/llvm/llvm-project/commit/5649b24c48ab3b48c1cb89155626a7f128c3f598.diff

[PATCH] D153617: [clangd] Fix an assertion failure in NamedDecl::getName during the prepareRename

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5649b24c48ab: [clangd] Fix an assertion failure in NamedDecl::getName during the prepareRename (authored by hokein). Repository: rG LLVM Github

[clang-tools-extra] 7a328cf - [include-cleaner] Bail out in the standalone tool for invalid ignore-headers

Author: Haojian Wu Date: 2023-07-14T10:05:22+02:00 New Revision: 7a328cf539b38484218a0eb902611c69cfba7981 URL: https://github.com/llvm/llvm-project/commit/7a328cf539b38484218a0eb902611c69cfba7981 DIFF: https://github.com/llvm/llvm-project/commit/7a328cf539b38484218a0eb902611c69cfba7981.diff

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro updated this revision to Diff 540413. pscoro added a comment. Decided to remove all the commented code related to the previous approach (wrapper library). The code that exists currently is for the object library approach and is functional. Currently, on phabricator there is a failing

[PATCH] D155217: [clang-tidy][include-cleaner] Don't warn for the same symbol twice

PiotrZSL added a comment. Check emits warnings per symbol/usage, but fixes header includes, won't it make duplicate includes ? Problem that I see is that multiple warnings for same symbol will generate lot of noise. And when dealing with diff why developer should be forced to fix legacy issues

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 540430. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/HIPSupport.rst Index: clang/docs/HIPSupport.rst

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske added a comment. About the "`fileno` with standard stream" problem: I do not see an always good solution for this case because these standard streams are global variables. If we want to be exact, we can not know much about these at analysis start unless it is the `main` function. The

[clang] 3c0a136 - [clang][Sema] Suggest static_cast in C++ code

Author: Alex Brachet Date: 2023-07-14T16:22:06Z New Revision: 3c0a136ce4b724221a7f75b656b9f7af3de6b64c URL: https://github.com/llvm/llvm-project/commit/3c0a136ce4b724221a7f75b656b9f7af3de6b64c DIFF: https://github.com/llvm/llvm-project/commit/3c0a136ce4b724221a7f75b656b9f7af3de6b64c.diff LOG:

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb updated this revision to Diff 540477. jaredgrubb added a comment. Rebased and added a line to Release Notes, no other changes. Have requested this to be merged if all builds are green (since this patch has been approved). CHANGES SINCE LAST ACTION

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // that are not referenced later. e.g.: if (int var = init()); + if (!T->isAggregateType()) +

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

scchan updated this revision to Diff 540481. scchan added a comment. added extra checks for not host, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

arsenm added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, Can we avoid adding yet another language flag for

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

asb added a reviewer: eopXD. asb added a comment. Adding eop as a reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125765/new/ https://reviews.llvm.org/D125765 ___ cfe-commits mailing list

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp:16 +// Sized deallocation was added in macOS 10.12 and aligned OSes. +// XFAIL: use_system_cxx_lib &&

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. In D146777#4499608 , @MaskRay wrote: > Thanks for the update. Can you add a comment for the `-funified-lto` > combination? It's unclear what it does... ugh, I had put comments above each compiler invocation, but forgot that

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet updated this revision to Diff 540479. hazohelet marked 6 inline comments as done. hazohelet added a comment. Address comments from Aaron and Corentin - Call `ConditionVar->setReferenced(false)` without any checks - Added some more tests CHANGES SINCE LAST ACTION

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 -xhip test.cpp -o test.o + arsenm wrote: > Aren't you supposed to use clang++? Also, could show that .hip is

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, arsenm wrote:

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

mstorsjo accepted this revision. mstorsjo added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 ___ cfe-commits mailing list

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo updated this revision to Diff 540321. VitaNuo added a comment. Re-use the logic from include cleaner in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 Files:

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87 + +// Returns the range starting at '#' and ending at EOL. Escaped newlines are not +// handled.

[clang] af744f0 - [LLD][COFF] Add LLVM toolchain library paths by default.

Author: Tobias Hieta Date: 2023-07-14T14:37:24+02:00 New Revision: af744f0b84e2b6410be65277068b9033124c73b2 URL: https://github.com/llvm/llvm-project/commit/af744f0b84e2b6410be65277068b9033124c73b2 DIFF: https://github.com/llvm/llvm-project/commit/af744f0b84e2b6410be65277068b9033124c73b2.diff

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf744f0b84e2: [LLD][COFF] Add LLVM toolchain library paths by default. (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96e50797d6ea: [clangd] Fix the range for include reference to itself. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 96e5079 - [clangd] Fix the range for include reference to itself.

Author: Viktoriia Bakalova Date: 2023-07-14T12:51:14Z New Revision: 96e50797d6ea39d561fc90511152fd30b77c1e62 URL: https://github.com/llvm/llvm-project/commit/96e50797d6ea39d561fc90511152fd30b77c1e62 DIFF: https://github.com/llvm/llvm-project/commit/96e50797d6ea39d561fc90511152fd30b77c1e62.diff

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

rnk added a comment. In D86310#4501170 , @hvdijk wrote: > For example, it would generally be better if long double were 8-byte-aligned, > but the x86 32-bit ABI specifies that it is 4-byte-aligned, and that is set > in stone. I would be against any

[clang] 563a23c - [clang][Sema] Add fixit for scoped enum format error

Author: Alex Brachet Date: 2023-07-14T16:23:22Z New Revision: 563a23c824db22da3ea378e8179fcc7072e897ec URL: https://github.com/llvm/llvm-project/commit/563a23c824db22da3ea378e8179fcc7072e897ec DIFF: https://github.com/llvm/llvm-project/commit/563a23c824db22da3ea378e8179fcc7072e897ec.diff LOG:

[PATCH] D153622: [clang][Sema] Suggest static_cast in C++ code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c0a136ce4b7: [clang][Sema] Suggest static_cast in C++ code (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG563a23c824db: [clang][Sema] Add fixit for scoped enum format error (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4733 + types::ID Output; + if (Args.hasArg(options::OPT_S)) +Output = types::TY_LTO_IR; MaskRay wrote: > This part is not tested. oh, feel free to disregard my Q about

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // that are not referenced later. e.g.: if (int var = init()); + if (!T->isAggregateType()) +

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

arsenm added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, scchan wrote: > arsenm wrote: > > Can we avoid adding

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

scchan added inline comments. Comment at: clang/include/clang/Driver/Options.td:1092 ShouldParseIf; +defm hip_uniform_block : BoolFOption<"hip-uniform-block", + LangOpts<"HIPUniformBlock">, DefaultTrue, arsenm wrote: > Can we avoid adding yet another

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:49 + +You can also use ``--offload-arch=native`` to let ``amdgpu-arch`` automatically detect the GPU architecture on your system: + arsenm wrote: >

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

hvdijk added a comment. @JohnReagan That is a valid concern, and I hope it reassures you that if things were working before, I would never be on board with this change. For example, it would generally be better if long double were 8-byte-aligned, but the x86 32-bit ABI specifies that it is

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

hvdijk added a comment. In D86310#4501240 , @rnk wrote: > In D86310#4501170 , @hvdijk wrote: > >> For example, it would generally be better if long double were >> 8-byte-aligned, but the x86 32-bit ABI specifies

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154647/new/ https://reviews.llvm.org/D154647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin added a comment. I found further issues with aggregates, I think not supporting aggregates for now would be fine, the high bit is to fix the regressions I did add some more info there https://github.com/cplusplus/CWG/issues/354#issuecomment-1636129255 Repository: rG LLVM Github

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb updated this revision to Diff 540492. jaredgrubb added a comment. Rebased (no other updates) to re-run build and hopefully get some eyes on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 Files:

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 ___ cfe-commits mailing list

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 540373. koops added a comment. Addressing Alexey's comments. The name matching in loop_bind_messages.cpp & generic_loop_codegen.cpp tests changed to take care of the failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 ___ cfe-commits

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin added a comment. In D155175#4498788 , @efriedma wrote: > Do we need CodeGen testcases here for full coverage? The testcases from the > issue passed with -fsyntax-only. > > > > With this patch, the following cases produce errors that

[PATCH] D155213: [HIP] Add `-fno-hip-uniform-block`

yaxunl updated this revision to Diff 540397. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155213/new/ https://reviews.llvm.org/D155213 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D155273: [clang-format] Add TypeNames option to disambiguate types/objects

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. If a non-keyword identifier is found in `TypeNames`, then a `*`,

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

hazohelet added a comment. > Do you have any numbers on how often this fires in practice, and what the > true positive rate is? (Build some large-ish open source project with this, > and see what it finds.) I built rui314/mold and saw no new warnings emitted from this change. I searched

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, davidxl, vsk, ellis. Herald added subscribers: wlei, Enna1, wenlei. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, MaskRay. Herald added projects:

[PATCH] D155273: [clang-format] Add TypeNames option to disambiguate types/objects

owenpan added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:284 + Style.TypeNames.push_back("Class"); + Tokens = annotate("if (Class *obj {getObj()})", Style); + ASSERT_EQ(Tokens.size(), 12u) << Tokens; This test case comes from

[PATCH] D155273: [clang-format] Add TypeNames option to disambiguate types/objects

thieta added a comment. Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155273/new/ https://reviews.llvm.org/D155273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta updated this revision to Diff 540344. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 Files: clang/lib/Driver/Driver.cpp lld/COFF/Driver.cpp lld/COFF/Driver.h lld/docs/ReleaseNotes.rst

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9837 +def err_omp_bind_required_on_loop : Error< + "expected 'bind' clause for loop construct without an enclosing OpenMP " + "construct">; Also, `'loop'`

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 540395. RIscRIpt added a comment. Addressed review comments. In D153914#4497696 , @aaron.ballman wrote: > Sema seems like the wrong place to perform such concatenations, but given > that adjacent string literals

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added inline comments. Comment at: clang/include/clang/Parse/Parser.h:578-582 + bool isTokenConcatenable() const { +return isTokenStringLiteral() || + getLangOpts().MicrosoftExt && + tok::isMSPredefinedMacro(Tok.getKind()); + }

[clang] 176981a - [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

Author: Takuya Shimizu Date: 2023-07-14T22:59:41+09:00 New Revision: 176981ac58d3e4beb02b9d110524e72be509375d URL: https://github.com/llvm/llvm-project/commit/176981ac58d3e4beb02b9d110524e72be509375d DIFF:

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG176981ac58d3: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes (authored by hazohelet). Changed prior to commit:

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:671 + // FIMXE: this is tricky + llvm::StringRef(LSPDiag.Message) + .starts_with_insensitive(Diag.Message)) this is tricky indeed and

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

JohnReagan added a comment. As a legacy OS provider on a platform that needs/requires ABI compatibility, I don't like the direction this is going. Like @rnk, I would having MORE control over struct layout is better than less. I'm adapting non-traditional languages to LLVM which allow very

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo updated this revision to Diff 540385. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

mstorsjo added a comment. Maybe add a release note for this too? It's rather significant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 ___ cfe-commits

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. Thank you! So I guess next time I submit a patch here (nothing planned at the moment), I should put the proposed commit message into the summary field and the backstory and start of discussion / open questions into a first comment. But maybe the point is moot as I

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao added a comment. Hmm… I don’t see why check-format keeps failing. I `git clang-format` thrice before uploading. https://buildkite.com/llvm-project/premerge-checks/builds/164452 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632

[PATCH] D155337: [CMake] Include riscv32-unknown-elf target in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. It would be a better summary to say "include ... runtimes ...". Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:10 set(_FUCHSIA_ENABLE_PROJECTS

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 540611. sstwcw edited the summary of this revision. sstwcw added a comment. - Add back the const qualifiers for methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 updated this revision to Diff 540627. strimo378 added a comment. Updated test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154186/new/ https://reviews.llvm.org/D154186 Files: clang/lib/AST/DeclPrinter.cpp

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this due to circular deps. `clangAnalysis` should not depend on `clangSema`. Comment at:

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

Joe created this revision. Joe added reviewers: michaelplatings, kito-cheng. Joe added a project: clang. Herald added subscribers: jobnoorman, luke, shiva0217, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, abidh, jocewei, PkmX, the_o,

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 540427. RIscRIpt added a comment. Rebased onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153914 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.verify.cpp:27 static_assert(!std::is_constant_evaluated(), ""); - // expected-warning@-1 0-1 {{'std::is_constant_evaluated' will always evaluate to 'true' in a

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:56 def BPFNoALU32 : Predicate<"!Subtarget->getHasAlu32()">; +def BPFHasCPUv4_ldsx : Predicate<"Subtarget->getCPUv4_ldsx()">; +def BPFHasCPUv4_movsx : Predicate<"Subtarget->getCPUv4_movsx()">;

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added inline comments. Comment at: clang/test/CodeGen/embed-fat-lto-objects.c:3 +// RUN: %clang -cc1 -triple x86_64-unknown-linux-gnu -flto=full -ffat-lto-objects -emit-llvm < %s | FileCheck %s --check-prefixes=FULL,SPLIT + +// RUN: %clang -cc1 -triple

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

craig.topper added a comment. > @craig.topper Just to make sure, are you okay with me 'commandeering' this > change and updating it? Yes. Thanks for taking it on. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/new/ https://reviews.llvm.org/D86310

[PATCH] D154616: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154616/new/ https://reviews.llvm.org/D154616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154123: [HIP] Start document HIP support by clang

arsenm added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 -xhip test.cpp -o test.o + Aren't you supposed to use clang++? Also, could show that .hip is recognized? CHANGES SINCE LAST ACTION

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

jaredgrubb marked 2 inline comments as done. jaredgrubb added inline comments. Herald added a subscriber: wangpc. Herald added a reviewer: rymiel. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1779-1782 nextToken(); +// Return types: pointers are ok too.

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 540485. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files:

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

jaredgrubb updated this revision to Diff 540488. jaredgrubb marked an inline comment as done. jaredgrubb added a comment. Address review comment and rebase to re-run tests. Intend to merge if everything is green! (If there are further comments, I will commit to address them!) CHANGES SINCE

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet updated this revision to Diff 540486. hazohelet added a comment. Uses `FunctionDecl::getNameForDiagnostic` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

cor3ntin added a comment. This looks reasonable to me now. I'll wait next week before approving it so other get a chance to look at it :) Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + //

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:87-93 +/// Return true if this token is a predefined macro +/// unexpandable by MSVC preprocessor. +inline bool isUnexpandableMsMacro(TokenKind K) { + return K == tok::kw___FUNCTION__ || K ==

[clang] 143e2c2 - [RISCV] Split clmul/clmulh/clmulr builtins into _32 and _64 versions.

Author: Craig Topper Date: 2023-07-14T19:09:15-07:00 New Revision: 143e2c2ac03cbcce290a9f14b0d667bf0f793280 URL: https://github.com/llvm/llvm-project/commit/143e2c2ac03cbcce290a9f14b0d667bf0f793280 DIFF: https://github.com/llvm/llvm-project/commit/143e2c2ac03cbcce290a9f14b0d667bf0f793280.diff

[clang] c915908 - Revert D150338, "[-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute"

Author: NAKAMURA Takumi Date: 2023-07-15T13:55:11+09:00 New Revision: c915908f6d6946151b17eae00c7f093e6f37c677 URL: https://github.com/llvm/llvm-project/commit/c915908f6d6946151b17eae00c7f093e6f37c677 DIFF:

[clang] ba7273b - Reformat

Author: NAKAMURA Takumi Date: 2023-07-15T13:55:11+09:00 New Revision: ba7273b02577236fbbca53554bafc6c22d7dd4c9 URL: https://github.com/llvm/llvm-project/commit/ba7273b02577236fbbca53554bafc6c22d7dd4c9 DIFF:

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

SuperSodaSea updated this revision to Diff 540621. SuperSodaSea retitled this revision from "Fix some typos in comments: evalute -> evaluate" to "Fix some typos in comments: evalute -> evaluate (NFC)". SuperSodaSea added a comment. Update patch CHANGES SINCE LAST ACTION

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. In D154130#4487292 , @jdenny wrote: > 3. Extend lit's own test suite to cover it. I submitted an update with your suggestions #1 and #2 but this #3 is much more difficult because of the nature of `%{t:real}`. I'm not sure I

[PATCH] D155335: This fixes an issue with 245d10b7a2c12ec25e7b5860a38c61991543a739, where on slightly older versions of clang, we get the below error and several others similar.

saugustine created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. saugustine requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In file included from .../clang/lib/AST/Interp/Source.h:17: In file included

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b012bf5ab5f: [-Wunsafe-buffer-usage] Improving insertion of the [[clang… (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo

  1   2   >