[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added inline comments. Comment at: llvm/utils/lit/lit/discovery.py:60 +cfgpath = util.abs_path_preserve_drive(cfgpath) +target = config_map.get(cfgpath) if target: RKSimon wrote: > RKSimon wrote: > > Found the problem

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

aaron.ballman accepted this revision. aaron.ballman added a subscriber: jcranmer-intel. aaron.ballman added a comment. This revision is now accepted and ready to land. > This does not handle the builtin functions yet, since I'm not sure if I > should check for all nans or only signaling ones

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

craig.topper added a comment. In D155145#4553922 , @anna wrote: > In D155145#4551621 , @craig.topper > wrote: > >> In D155145#4551526 , @anna wrote: >> >>> In

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b76b44e46ac: [clang][ExtractAPI] Add support for C++ classes (authored by evelez7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. > Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to > getX86CpuIDAndInfoEx that have 0x7 as the first argument? Maybe there's a bug > in CPUID on Sandy Bridge. Sure, on the original code before the patch you suggested right? The two calls are:

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

saiislam created this revision. saiislam added reviewers: jhuber6, yaxunl. Herald added subscribers: tpr, dstuttard, kzhuravl. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added a project: clang.

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. Hi, we are seeing a test error on `Clang :: ExtractAPI/constructor_destructor.cpp` after this patch was landed. Error message: Script: -- : 'RUN: at line 1'; rm -rf /b/s/w/ir/x/w/llvm_build/tools/clang/test/ExtractAPI/Output/constructor_destructor.cpp.tmp :

[PATCH] D156930: [Clang] Fix Offloading related tests after D156363

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! I guess `--rocm-path=` can be used in some places, but `-nogpulib -nogpuinc` is good as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156933: [HLSL] Add reversebits library function

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/bitreverse.hlsl:32 +// CHECK: call <4 x i16> @llvm.bitreverse.v4i16 +// NO_HALF: define noundef <4 x i16> @"?test_bitreverse_short4@@YAT?$__vector@F$03@__clang@@T12@@Z"( +// NO_HALF: call <4 x i16>

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

clementval added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +! HELP-NEXT:

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon updated this revision to Diff 546445. Fznamznon added a comment. Rebase, add more test cases, fix assertion on variadic functions inside of `haveSameParameterTypes` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156244/new/

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl updated this revision to Diff 546477. AntonRydahl added a comment. I was a bit too fast. I changed OpenMPSupport.rst to point to both the OpenMP 5.0 and OpenMP 5.1 implementation status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156900/new/ https://reviews.llvm.org/D156900

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

yaxunl added a comment. In D156363#4554435 , @jhuber6 wrote: > Clang :: Driver/amdgpu-hip-system-arch.c > Clang :: Driver/cuda-bad-arch.cu > Clang :: Driver/hip-autolink.hip > Clang :: Driver/hip-binding.hip > Clang :: Driver/hip-cuid-hash.hip

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. In D156363#4554687 , @yaxunl wrote: > In D156363#4554435 , @jhuber6 wrote: > >> Clang :: Driver/amdgpu-hip-system-arch.c >> Clang :: Driver/cuda-bad-arch.cu >> Clang ::

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

rnk added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->getType().isConstQualified()) { - if (HasConstInit) rsmith wrote: > efriedma wrote: > > rnk wrote: > > > I think this is not

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, efriedma, asl. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was unused since commit rGdd2362a8ba

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); }

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 546479. sdesmalen marked 19 inline comments as done. sdesmalen added a comment. - The attributes no longer require +sme to be passed. - Fixed IsInvalidSMECallConversion to consider the correct To/From types and added a corresponding test for the virtual

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen added a comment. Thanks both for the detailed review and latest round of comments, I've tried to address them all. Comment at: clang/include/clang/AST/Type.h:3987 /// [implimits] 8 bits would be enough here. -uint16_t NumExceptionType = 0; +uint16_t

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. In D156363#4554790 , @ro wrote: > In D156363#4553043 , @ro wrote: > >> It seems the latest commit of this patch has (re-)introduced two failures on >> the Solaris/amd64 buildbot >>

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. In D156363#4554913 , @yaxunl wrote: > Thanks. I will wait for your patch. You can leave the tricky ones to me if > you would like. e.g. the rocm-detect.hip You can go ahead and fix that one then. Repository: rG LLVM Github

[PATCH] D57896: Variable names rule

sbc100 added a comment. Herald added a project: All. Is there still appetite to land this change?We made the switch over in LLD a while back without any issues that I know of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57896/new/

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; tbaeder wrote: > probinson wrote: > > Would you

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl created this revision. AntonRydahl added a reviewer: jdoerfert. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. AntonRydahl requested review of this revision. Herald added

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

foad added a comment. Herald added a project: All. Hi @erik.pilkington, I see this got reverted: commit e26c24b849211f35a988d001753e0cd15e4a9d7b Author: Erik Pilkington Date: Wed Feb 12 12:02:58 2020 -0800 Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

v.g.vassilev added a comment. In D156537#4554052 , @Hahnfeld wrote: > @v.g.vassilev do we have a means to detect this case? In D156897 > , I'm refactoring all accesses to > `EmittedDeferredDecl` to go via

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156904/new/ https://reviews.llvm.org/D156904

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. Clang :: Driver/amdgpu-hip-system-arch.c Clang :: Driver/cuda-bad-arch.cu Clang :: Driver/hip-autolink.hip Clang :: Driver/hip-binding.hip Clang :: Driver/hip-cuid-hash.hip Clang :: Driver/hip-cuid.hip Clang :: Driver/hip-default-gpu-arch.hip Clang ::

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. Pretty sure most of this is `hip` returning an error if it can't find `ROCm`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://reviews.llvm.org/D156363 ___

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4553043 , @ro wrote: > It seems the latest commit of this patch has (re-)introduced two failures on > the Solaris/amd64 buildbot > : > > FAIL:

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

MaskRay added a comment. I think `assert((A == B || (A->getOverloadedOperator() == OO_EqualEqual && B->getOverloadedOperator() == OO_EqualEqual)) && ...);` would look better , but the current form is fine as well. > You will see 2 failures in >

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

yaxunl added a comment. In D156363#4554693 , @jhuber6 wrote: > In D156363#4554687 , @yaxunl wrote: > >> In D156363#4554435 , @jhuber6 >> wrote: >> >>> Clang ::

[PATCH] D156930: [Clang] Fix Offloading related tests after D156363

jhuber6 created this revision. jhuber6 added reviewers: MaskRay, yaxunl, JonChesterfield, tra, jdoerfert, ronlieb, jplehr. Herald added subscribers: mattd, asavonic, ormris, kerbowa, steven_wu, hiraditya, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Small wording suggestion for the comment, but feel free to commit with that change. Comment at: clang/lib/Parse/ParseObjc.cpp:742 -// Eat the identifier. +

[clang] bc08022 - [Clang] Fix Offloading related tests after D156363

Author: Joseph Huber Date: 2023-08-02T14:34:51-05:00 New Revision: bc080221b3a2c73739caa2bf0521dd3984d0a934 URL: https://github.com/llvm/llvm-project/commit/bc080221b3a2c73739caa2bf0521dd3984d0a934 DIFF: https://github.com/llvm/llvm-project/commit/bc080221b3a2c73739caa2bf0521dd3984d0a934.diff

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

svenvh added a comment. If we go with this approach, please also remove sqrt from `clang/lib/Sema/OpenCLBuiltins.td` (and ideally add a comment pointing out that sqrt is handled in `opencl-c-base.h`) Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld

[PATCH] D156896: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. @v.g.vassilev do we have a means to detect this case? In D156897 , I'm refactoring all accesses to `EmittedDeferredDecl` to go via `addEmittedDeferredDecl`, so we should just add an early return when not emitting for a REPL.

[PATCH] D152141: [Clang] Make __arm_streaming apply only to prototyped functions.

sdesmalen updated this revision to Diff 546465. sdesmalen added a comment. Remove changes that limited the attribute from being valid only when compiled with '+sme'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152141/new/

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 ___

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4554812 , @jhuber6 wrote: > In D156363#4554790 , @ro wrote: > >> In D156363#4553043 , @ro wrote: >> >>> It seems the latest commit of

[clang] f4de606 - fix use-after-free introduced in 8b76b44e46ac

Author: Augie Fackler Date: 2023-08-02T14:38:08-04:00 New Revision: f4de606ef271fe362f03d30c53a850f9877ec238 URL: https://github.com/llvm/llvm-project/commit/f4de606ef271fe362f03d30c53a850f9877ec238 DIFF: https://github.com/llvm/llvm-project/commit/f4de606ef271fe362f03d30c53a850f9877ec238.diff

[PATCH] D156930: [Clang] Fix Offloading related tests after D156363

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc080221b3a2: [Clang] Fix Offloading related tests after D156363 (authored by jhuber6). Changed prior to commit:

[PATCH] D156890: [clang] Remove outdated INSTALL.txt

stephanlachnit created this revision. Herald added a project: All. stephanlachnit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Information in this file is outdated, and instead the information from clang/README.txt should be taken

[PATCH] D156027: [clang][Interp] Rework how initializers work

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:545-547 + // TODO(perf): For int and bool types, we can probably just skip this + // since we memset our Block*s to 0 and so we have the desired value + // without this.

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. In D155145#4551621 , @craig.topper wrote: > In D155145#4551526 , @anna wrote: > >> In D155145#4544068 , @pengfei >> wrote: >> >>> In

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:155 +def offload_Group : OptionGroup<"">, Group, + DocName<"Common Offloading flags">; + The existing `flags` uses are misnomer

[PATCH] D156910: [clang] Add pragma force_vectorize

kitaisreal created this revision. kitaisreal added a reviewer: aaron.ballman. kitaisreal added projects: All, LLVM. Herald added a subscriber: hiraditya. kitaisreal requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wangpc. Herald added a project: clang. Add

[PATCH] D156911: [clang][CodeGen] Drop some typed pointer bitcasts

bjope created this revision. Herald added a subscriber: nlopes. Herald added a project: All. bjope requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156911 Files:

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. In D76096#4540442 , @nickdesaulniers wrote: > Consider the following code: > > long x [] = {1, 2, 3, 4, 5 + 4}; > > Even with some of my recent

[PATCH] D156925: [Driver] Don't try to spell check unsupported options

bogner created this revision. bogner added reviewers: Bigcheese, MaskRay. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. bogner requested review of this revision. Herald added subscribers:

[clang] 2e65a42 - [Driver][test] Ensure --target= for -flto commands

Author: Fangrui Song Date: 2023-08-02T11:57:02-07:00 New Revision: 2e65a423e277b40a885b9de8a2cbf60f2f812cd6 URL: https://github.com/llvm/llvm-project/commit/2e65a423e277b40a885b9de8a2cbf60f2f812cd6 DIFF: https://github.com/llvm/llvm-project/commit/2e65a423e277b40a885b9de8a2cbf60f2f812cd6.diff

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4554884 , @MaskRay wrote: > In D156363#4554812 , @jhuber6 wrote: > >> >> Probably because we're not specifying the `--target=` I'll add that in my >> fix for AMDGPU I'm working

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

goldstein.w.n accepted this revision. goldstein.w.n added a comment. This revision is now accepted and ready to land. In D156556#4555036 , @kitaisreal wrote: > In D156556#4554436 , @goldstein.w.n > wrote: > >>

[PATCH] D156509: [clang][Interp] Diagnose unknown parameter values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156509/new/ https://reviews.llvm.org/D156509 ___ cfe-commits mailing

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; probinson wrote: > Would you mind changing this cast from

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

tianshilei1992 added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +!

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4496 +static bool CheckInValidEGW(const TargetInfo , CallExpr *TheCall, Sema , +QualType Type, int EGW) { InValid -> Invalid Comment

[PATCH] D156933: [HLSL] Add bitreverse library function

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156933 Files:

[PATCH] D156205: wasm: link crt1 even in case of -shared

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:80 - const char *Crt1 = "crt1.o"; + bool isCommand = true; + const char *Crt1; LLCM coding

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 546444. DiggerLin marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +! HELP-NEXT:

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

MaskRay added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:74 + << " -U- Use actual timestamps and uids/gids\n" + << " -X{32|64|32_64|any} - Specifies which archive symbol tables " + "should be generated if they do not

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

xazax.hun added a comment. In D156658#4552965 , @mboehme wrote: > I've investigated this in more detail. Unfortunately, it turns out that it's > not quite as simple as just implementing widening on `ExprToLoc`. > > One of the reasons for this is that we

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:488 + bool IsFromExternalModule = true; + for (const auto : API.getObjCInterfaces()) { +if (InterfaceDecl->getName() == Interface.second.get()->Name) { I think this

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please give other active reviewers a bit of time to chime in before landing. Note, @erichkeane is out on sabbatical at the moment, so there's no need to wait for

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt updated this revision to Diff 546525. yamt added a comment. isCommand -> IsCommand Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:80 - const char *Crt1 = "crt1.o"; + bool isCommand = true; + const char *Crt1; sbc100 wrote: > LLCM coding style is `IsCommand` (at last for now: >

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->getType().isConstQualified()) { - if (HasConstInit) efriedma wrote: > rnk wrote: > > I think this is not compatible with

[clang] 11b7ce2 - [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

Author: Blue Gaston Date: 2023-08-02T11:30:29-07:00 New Revision: 11b7ce26f2a22ca147feaaf1cfd2d21b85fc3d83 URL: https://github.com/llvm/llvm-project/commit/11b7ce26f2a22ca147feaaf1cfd2d21b85fc3d83 DIFF: https://github.com/llvm/llvm-project/commit/11b7ce26f2a22ca147feaaf1cfd2d21b85fc3d83.diff

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG11b7ce26f2a2: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled (authored by Blue Gaston bgast...@apple.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

kitaisreal added a comment. In D156556#4554436 , @goldstein.w.n wrote: > Can you mark the title as NFC? It seems that title of revision is "[AggressiveInstCombine][NFC] Fix typo". Do you mean to put NFC at the beginning ? Repository: rG LLVM

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:90 +COV_Default = 400, +COV_MAX = 500 }; Typically we just put a `COV_LAST` to indicate that it's over the accepted enumerations. Comment at:

[PATCH] D156930: [Clang] Fix Offloading related tests after D156363

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156930/new/ https://reviews.llvm.org/D156930 ___ cfe-commits mailing list

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

tianshilei1992 added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +!

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added inline comments. Comment at: llvm/utils/lit/lit/discovery.py:60 +cfgpath = util.abs_path_preserve_drive(cfgpath) +target = config_map.get(cfgpath) if target: RKSimon wrote: > Found the problem - you have moved

[PATCH] D156856: [clang][dataflow] In `equivalentTo()`, ignore expression locations that are unlikely to matter.

mboehme updated this revision to Diff 546456. mboehme added a comment. Add a FIXME noting that this is a temporary solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156856/new/ https://reviews.llvm.org/D156856 Files:

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, v.g.vassilev, junaire. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `GlobalDecl`s should only be added to `EmittedDeferredDecl` if

[PATCH] D57896: Variable names rule

michaelplatings added a comment. Hi Sam, I won't be able to take this forward but you have my encouragement. To facilitate this change I got as far as changing Git [1], and GitHub has been updated accordingly [2], but I ran out of steam before getting to the change itself. I'd be happy to let

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

goldstein.w.n added a comment. Can you mark the title as NFC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156556/new/ https://reviews.llvm.org/D156556 ___ cfe-commits mailing list

[PATCH] D156910: [clang] Add pragma force_vectorize

kitaisreal added a comment. It seems that maybe it is better to specify pragma like this, without `(enable)`. #pragma clang loop force_vectorize for (size_t i = 0; i < size; ++i) { sum += data[i]; } But maybe ability to enable or disable `force_vectorize` can be helpful if we will

[PATCH] D152141: [Clang] Make __arm_streaming apply only to prototyped functions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152141/new/ https://reviews.llvm.org/D152141

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

arsenm added a comment. missing tests Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1066 +if (!IsCC1As) { + std::string CodeObjVerStr = (CodeObjVer ? Twine(CodeObjVer) : "none").str(); CmdArgs.insert(CmdArgs.begin() + 1, don't need to go

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

yaxunl added a comment. `-mcode-object-version=none` was intentionally designed to work with `clang -cc1` only, since it does not work with clang driver if users link with device library. Device library can still use it by using it with `-Xclang`. Repository: rG LLVM Github Monorepo

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

jhuber6 added a comment. In D156928#4555121 , @yaxunl wrote: > `-mcode-object-version=none` was intentionally designed to work with `clang > -cc1` only, since it does not work with clang driver if users link with > device library. Device library can

[PATCH] D156933: [HLSL] Add bitreverse library function

bob80905 updated this revision to Diff 546576. bob80905 added a comment. - change builtin name to reversebits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/ https://reviews.llvm.org/D156933 Files:

[clang] 590d7e2 - [HIP] Fix test rocm-detect.hip

Author: Yaxun (Sam) Liu Date: 2023-08-02T16:12:54-04:00 New Revision: 590d7e2664260d5ceef77be03cdc3564e0f57f72 URL: https://github.com/llvm/llvm-project/commit/590d7e2664260d5ceef77be03cdc3564e0f57f72 DIFF:

[PATCH] D156935: [HIP] Fix test rocm-detect.hip

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG590d7e266426: [HIP] Fix test rocm-detect.hip (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156936: [Clang] Increase default architecture from sm_35 to sm_52

jhuber6 created this revision. jhuber6 added reviewers: tra, jdoerfert, yaxunl, jlebar. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We previously defaulted to `sm_35` for the purpose of unspecified

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. Thanks for reverting. I wasn't doing any changes to this when you were asking though, but looking at build log, it looks like the assertion error disappeared after f4de606ef271fe362f03d30c53a850f9877ec238

[clang] 610ec95 - [clang] allow const structs/unions/arrays to be constant expressions for C

Author: Nick Desaulniers Date: 2023-08-02T15:32:37-07:00 New Revision: 610ec954e1f81c0e8fcadedcd25afe643f5a094e URL: https://github.com/llvm/llvm-project/commit/610ec954e1f81c0e8fcadedcd25afe643f5a094e DIFF:

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG610ec954e1f8: [clang] allow const structs/unions/arrays to be constant expressions for C (authored by nickdesaulniers). Repository: rG LLVM

[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1366 + llvm::Constant *VisitUnaryOperator(UnaryOperator *U, QualType T) { +switch (U->getOpcode()) { StmtVisitor supports defining a function "VisitUnaryMinus", so you don't

[PATCH] D156441: [clangd]Fix addUsing tweak doesn't traverse same-level anon namespaces

chouzz added a comment. @kadircet Could you please take a look this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156441/new/ https://reviews.llvm.org/D156441 ___ cfe-commits mailing list

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546677. 4vtomat added a comment. Update missing comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. thank you @craig.topper and @pengfei . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145 ___ cfe-commits mailing list

[clang] 7ef1718 - [Driver] Don't try to spell check unsupported options

Author: Justin Bogner Date: 2023-08-02T14:23:14-07:00 New Revision: 7ef1718c4d4ecd99f3ba48236f7fd4fd9ffb540c URL: https://github.com/llvm/llvm-project/commit/7ef1718c4d4ecd99f3ba48236f7fd4fd9ffb540c DIFF: https://github.com/llvm/llvm-project/commit/7ef1718c4d4ecd99f3ba48236f7fd4fd9ffb540c.diff

  1   2   3   >