[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

tbaeder added a comment. You're missing tests. Comment at: clang/lib/Sema/SemaExpr.cpp:16696-16697 + + IdentifierInfo *II = RD->getIdentifier(); + if (II == OC.U.IdentInfo && OC.isQualifier) +continue; Repository: rG LLVM Github Monorepo

[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:31 + // Match function with 2 arguments, both are non-const references to same type + // and return void void swap(Type&, Type&) + auto FunctionMatcher = allOf(

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 created this revision. Herald added a project: All. yichi170 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157201 Files: clang/include/clang/Sema/Sema.h

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

cor3ntin added a comment. Thanks a lot for working on this. Can you add tests (to `clang/test/SemaCXX/offsetof.cpp`)? The change will also need an entry in `clang/docs/ReleaseNotes.rst` , in the "C++ Language Changes" section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157188: [clang-tidy] Add bugprone-allocation-bool-conversion

PiotrZSL updated this revision to Diff 547587. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Formating + fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157188/new/ https://reviews.llvm.org/D157188 Files:

[PATCH] D157188: [clang-tidy] Add bugprone-allocation-bool-conversion

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AllocationBoolConversionCheck.cpp:25 + "malloc;calloc;realloc;strdup;fopen;fdopen;freopen;" + "opendir;fdopendir;popen;mmap;allocate"))) {} +

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks @Krishna-13-cyber for the prompt changes. @v.g.vassilev If no further changes are required by @junaire , then this should be ready to merge Repository: rG LLVM Github

[PATCH] D57896: Variable names rule

lattner added a comment. I would also love to see this conceptually, but think it will be pretty polarizing in the community. It is worth another RFC thread before investing much time in it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bd0ed0a - [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

Author: Takuya Shimizu Date: 2023-08-06T16:24:09+09:00 New Revision: bd0ed0abc31fa5a49e87eeca7aa872e7f6e4d1e7 URL: https://github.com/llvm/llvm-project/commit/bd0ed0abc31fa5a49e87eeca7aa872e7f6e4d1e7 DIFF:

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd0ed0abc31f: [Clang][SemaCXX] Add unused warning for variables declared in condition… (authored by hazohelet). Changed prior to commit:

[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap

PiotrZSL updated this revision to Diff 547528. PiotrZSL added a comment. Remove space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157185/new/ https://reviews.llvm.org/D157185 Files:

[PATCH] D157208: [clang] Fix typos in comments

Eymay created this revision. Herald added a project: All. Eymay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157208 Files:

[PATCH] D156605: [CodeComplete] Mark 'Derived().Base::foo()' CanBeCall

zyounan updated this revision to Diff 547566. zyounan added a comment. Merge changes with function templates from D155370 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547573. ccotter marked 5 inline comments as done. ccotter added a comment. - Add tests, do not inspect instantiations, add option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/

[PATCH] D155769: [Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx marked an inline comment as done. AlexVlx added inline comments. Comment at: clang/docs/StdParSupport.rst:366-367 + + Note that this is a temporary, unsafe workaround for a deficiency in the C++ + Standard. + keryell wrote: > Another way could be to

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp:27 + namesType(templateSpecializationType(hasDeclaration(namedDecl( + hasAnyName(utils::options::parseStringList(LockGuards))); +

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547585. ccotter added a comment. - Use matchesAnyListedName and fix windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057 Files:

[PATCH] D157188: [clang-tidy] Add bugprone-allocation-bool-conversion

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AllocationBoolConversionCheck.cpp:25 + "malloc;calloc;realloc;strdup;fopen;fdopen;freopen;" + "opendir;fdopendir;popen;mmap;allocate"))) {} +

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 547589. bolshakov-a added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D157237: [clang][ASTMatcher] Add Matcher 'dependentSizedExtVectorType'

danix800 created this revision. danix800 added a project: clang. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. Add Matcher `dependentSizedExtVectorType` for type `DependentSizedExtVectorType`. Repository: rG LLVM Github

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

danix800 created this revision. danix800 added reviewers: Aar454on, balazske. danix800 added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision. Herald

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

tbaeder added a comment. The fuzzer timeouts fail all the time; I usually just assume it's unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 ___

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547529. Krishna-13-cyber added a comment. - Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D157205: [clangd] Add hexadecimal member offsets and sizes to hover popup

tetraxile created this revision. tetraxile added a reviewer: sammccall. tetraxile added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tetraxile requested review of this revision. Herald added subscribers: cfe-commits, MaskRay,

[clang-tools-extra] 2111577 - [clang-tidy] Fixed false-negative in readability-identifier-naming

Author: Piotr Zegar Date: 2023-08-06T09:22:31Z New Revision: 2111577d4dfc1d48b4e2221f84597fa4f54b8cfd URL: https://github.com/llvm/llvm-project/commit/2111577d4dfc1d48b4e2221f84597fa4f54b8cfd DIFF: https://github.com/llvm/llvm-project/commit/2111577d4dfc1d48b4e2221f84597fa4f54b8cfd.diff LOG:

[clang-tools-extra] 2553e24 - [clang-tidy] Fix false-positives in performanc-noexcept-swap

Author: Piotr Zegar Date: 2023-08-06T09:23:21Z New Revision: 2553e2403a33824bea7ca280c9328b0b0acf2836 URL: https://github.com/llvm/llvm-project/commit/2553e2403a33824bea7ca280c9328b0b0acf2836 DIFF: https://github.com/llvm/llvm-project/commit/2553e2403a33824bea7ca280c9328b0b0acf2836.diff LOG:

[PATCH] D157190: [clang-tidy] Fixed false-negative in readability-identifier-naming

This revision was automatically updated to reflect the committed changes. Closed by commit rG2111577d4dfc: [clang-tidy] Fixed false-negative in readability-identifier-naming (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157190?vs=547503=547536#toc Repository: rG

[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap

This revision was automatically updated to reflect the committed changes. Closed by commit rG2553e2403a33: [clang-tidy] Fix false-positives in performanc-noexcept-swap (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157185?vs=547528=547537#toc Repository: rG LLVM

[PATCH] D157205: [clangd] Add hexadecimal member offsets and sizes to hover popup

SR_team added a comment. Until a 10, we don't have difference between DEC and HEX, may be print only DEC in these cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157205/new/ https://reviews.llvm.org/D157205

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547574. Krishna-13-cyber added a comment. - Update section of Execution Results Handling in Clang-REPL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858

[PATCH] D157229: Fix edge case in declare target initializer expression

RitanyaB created this revision. RitanyaB added reviewers: soumitra, sandeepkosuri, koops, ABataev. Herald added a project: All. RitanyaB requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang.

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. Sorry for the late reply. I tried to investigate the memory impact of creating these additional materializations by build the whole llvm-project and compare the number of `MaterializedTemporaryExpr` created during parsing. Steps: 1. Add a public member `uint64_t

[PATCH] D157188: [clang-tidy] Add bugprone-allocation-bool-conversion

PiotrZSL updated this revision to Diff 547523. PiotrZSL retitled this revision from "[clang-tidy] Add bugprone-new-bool-conversion" to "[clang-tidy] Add bugprone-allocation-bool-conversion". PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Change check anme, add

[clang] 18b6f6e - Revert "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions"

Author: Takuya Shimizu Date: 2023-08-06T17:02:01+09:00 New Revision: 18b6f6e0c7d0b492e90738d684aeb731754aeaac URL: https://github.com/llvm/llvm-project/commit/18b6f6e0c7d0b492e90738d684aeb731754aeaac DIFF:

[clang-tools-extra] b3700c3 - [clang-tidy] Re-add cppcoreguidelines-macro-to-enum alias

Author: Piotr Zegar Date: 2023-08-06T08:09:57Z New Revision: b3700c34aa712fb4034fb2c31b0767993b1a6b7f URL: https://github.com/llvm/llvm-project/commit/b3700c34aa712fb4034fb2c31b0767993b1a6b7f DIFF: https://github.com/llvm/llvm-project/commit/b3700c34aa712fb4034fb2c31b0767993b1a6b7f.diff LOG:

[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap

PiotrZSL updated this revision to Diff 547526. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Fix comments + add test with friend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157185/new/ https://reviews.llvm.org/D157185

[PATCH] D157181: [clang-tidy] Re-add cppcoreguidelines-macro-to-enum alias

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3700c34aa71: [clang-tidy] Re-add cppcoreguidelines-macro-to-enum alias (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157181/new/

[clang-tools-extra] 16f6f19 - [clang-tidy][NFC] Update release notes

Author: Piotr Zegar Date: 2023-08-06T09:36:20Z New Revision: 16f6f1938be6dc582bbfb976603b4e5adfa2302a URL: https://github.com/llvm/llvm-project/commit/16f6f1938be6dc582bbfb976603b4e5adfa2302a DIFF: https://github.com/llvm/llvm-project/commit/16f6f1938be6dc582bbfb976603b4e5adfa2302a.diff LOG:

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 updated this revision to Diff 547542. yichi170 added a comment. [Clang] Support qualified name as member designator in offsetof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157201/new/ https://reviews.llvm.org/D157201 Files:

[PATCH] D155769: [Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 547572. AlexVlx added a comment. Remove confusing guidance around mGPU. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 Files: clang/docs/StdParSupport.rst clang/docs/index.rst Index:

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added a comment. I reverted this change because it broke sanitizer buildbots. https://lab.llvm.org/buildbot/#/builders/19/builds/18369 The cause of the errors here are relatively clear and I can speculatively replace `if (std::error_code EC = makeCanonical(Path))` with `if

[PATCH] D157207: [clangd] Fix typo in comment

Eymay created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. Eymay requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:16696-16697 + + IdentifierInfo *II = RD->getIdentifier(); + if (II == OC.U.IdentInfo && OC.isQualifier) +continue; tbaeder wrote: > I'll fix it along with the

[PATCH] D157227: [Clang] Don't add `undef` for `operator new` under -fno-exceptions.

DianQK created this revision. Herald added subscribers: atanasyan, jrtc27. Herald added a reviewer: aaron.ballman. Herald added a project: All. DianQK requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. The current implementation of

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 547569. zyounan added a comment. Trigger the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan abandoned this revision. zyounan added a comment. Closing this in favor of D156605 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/ https://reviews.llvm.org/D155370

[PATCH] D155775: [Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 547570. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp:56 +using CF = ComplexFloat<1.0f + 3.0fi>; +using CF = ComplexFloat<3.0fi + 1.0f>; bolshakov-a wrote: > aaron.ballman wrote: > > bolshakov-a wrote: > > > shafik

[PATCH] D157244: [clang-format] Correctly count annoated lines in a namespace body

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Fixes https://github.com/llvm/llvm-project/issues/63882.

[PATCH] D157244: [clang-format] Correctly count annoated lines in a namespace body

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.h:95 + size_t size() const { +int Size = 1; +for (const auto *Child : Children) Will fix it before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157237: [clang][ASTMatcher] Add Matcher 'dependentSizedExtVectorType'

danix800 updated this revision to Diff 547614. danix800 added a comment. Add missing Matcher registration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157237/new/ https://reviews.llvm.org/D157237 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D157237: [clang][ASTMatcher] Add Matcher 'dependentSizedExtVectorType'

danix800 added a comment. In D157237#4564148 , @PiotrZSL wrote: > Matcher registration is missing, verify if it's visible in clang-query. Fixed. Thanks for reminding! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

danix800 updated this revision to Diff 547615. danix800 added a comment. Apply git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157238/new/ https://reviews.llvm.org/D157238 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D157245: [clang/cxx-interop] Teach clang to ignore availability errors that come from CF_OPTIONS

thakis created this revision. thakis added a reviewer: hans. Herald added a project: All. thakis requested review of this revision. This cherry-picks https://github.com/apple/llvm-project/pull/6431 since without it, macOS 14 SDK headers don't compile when targeting catalyst. Fixes #64438.

[PATCH] D157246: [clang-tidy] Update tests to include C++23 and C++26

avogelsgesang created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. avogelsgesang requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This commit changes the

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 547619. sstwcw added a comment. Add support for breaking strings with + in C# and others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files:

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In D154093#4544496 , @owenpan wrote: > In D154093#4542339 , @sstwcw wrote: > >> @owenpan What do you think about this revision especially the replacement >> part? > > See D154093#4544495

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. @MyDeveloperDay Can you take a look at the last test in FormatTestCSharp.Attributes? I tried to enable breaking string literals by default. The long string got broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c0abd38 - [clang-tidy] Remove 'const' qualifiers on return types that do nothing

Author: Dmitri Gribenko Date: 2023-08-07T02:55:03+02:00 New Revision: c0abd3814564a568dfc607c216e6407eaa314f46 URL: https://github.com/llvm/llvm-project/commit/c0abd3814564a568dfc607c216e6407eaa314f46 DIFF:

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944 Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri added a comment. In D152054#4560353 , @tianshilei1992 wrote: > Is this patch to support `thread_limit` on `target` directive on the host? Yes @tianshilei1992 , It is for host only Repository: rG LLVM Github Monorepo CHANGES SINCE

Re: [clang] 3b34d69 - Revert "For #64088: mark vtable as used if we might emit a reference to it."

Ping on this - please always include details on the reason for a revert. On Tue, Aug 1, 2023 at 10:09 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revert reintroduces a wrong-code bug, can you explain what the > purpose of the revert is? > > On Fri, 28 Jul 2023 at

[PATCH] D157248: [clang][ASTMatcher] Add Matcher 'convertVectorExpr'

danix800 created this revision. danix800 added reviewers: PiotrZSL, aaron.ballman. danix800 added a project: clang. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. Add Matcher `convertVectorExpr`. Repository: rG LLVM Github

[PATCH] D157248: [clang][ASTMatcher] Add Matcher 'convertVectorExpr'

danix800 updated this revision to Diff 547625. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157248/new/ https://reviews.llvm.org/D157248 Files: clang/docs/LibASTMatchersReference.html clang/docs/ReleaseNotes.rst

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. @sammccall gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157249: [clang][ASTImporter] Add import of 'ConvertVectorExpr'

danix800 created this revision. danix800 added reviewers: balazske, aaron.ballman. danix800 added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision.

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

yubing created this revision. Herald added a project: All. yubing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp Index:

[PATCH] D157188: [clang-tidy] Add bugprone-allocation-bool-conversion

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Fix CI, Add support for allocators that return 'integer', hardcode most of functions, change config into AdditionalAllocationFunctions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157237: [clang][ASTMatcher] Add Matcher 'dependentSizedExtVectorType'

PiotrZSL added a comment. Matcher registration is missing, verify if it's visible in clang-query. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157237/new/ https://reviews.llvm.org/D157237 ___

[clang] a0b1c23 - [clang-format] Currectly handle PCIS_CurrentLine with no column limit

Author: Owen Pan Date: 2023-08-06T12:14:23-07:00 New Revision: a0b1c235afab4743cf31e4ac4509120d3c156e60 URL: https://github.com/llvm/llvm-project/commit/a0b1c235afab4743cf31e4ac4509120d3c156e60 DIFF: https://github.com/llvm/llvm-project/commit/a0b1c235afab4743cf31e4ac4509120d3c156e60.diff

[PATCH] D157179: [clang-format] Currectly handle PCIS_CurrentLine with no column limit

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0b1c235afab: [clang-format] Currectly handle PCIS_CurrentLine with no column limit (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectEnableIfCheck.cpp:57 + + const SourceManager = Result.Context->getSourceManager(); + SourceLocation RAngleLoc = Result got source manager

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectEnableIfCheck.cpp:67 + diag(EnableIf->getBeginLoc(), "incorrect std::enable_if usage detected; use " +"'typename std::enable_if<...>::type'") + <<

[PATCH] D157011: [Clang][Tooling] Accept preprocessed input files

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157011/new/ https://reviews.llvm.org/D157011

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/incorrect-enable-if.rst:6 + +Detects incorrect usages of std::enable_if that don't name the nested 'type' +type. Please synchronize with statement in Release

[PATCH] D157205: [clangd] Add hexadecimal member offsets and sizes to hover popup

tetraxile updated this revision to Diff 547595. tetraxile added a comment. Thanks for the suggestion SR_team, I've just added that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157205/new/ https://reviews.llvm.org/D157205 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter updated this revision to Diff 547599. ccotter added a comment. - Edited wrong file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239 Files:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 547603. bolshakov-a added a comment. Fixes after review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. Btw, formatting of unrelated lines has leaked into `TemplateBase.h`. Sorry. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1624-1626 + return const_cast( + V.getLValueBase().dyn_cast()); +} aaron.ballman wrote: > Does this

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

carlosgalvezp added a comment. Do you have plans to also detect the bugprone scenario described in the `Notes` here? https://en.cppreference.com/w/cpp/types/enable_if No need to have it in this patch, but would be good to keep it in mind if we want to add it in the future (preferably) or

[PATCH] D157242: [clang-tidy] Exclude delegate constructors in cppcoreguidelines-prefer-member-initializer

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, ccotter. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D157243: [HIP] Make test rocm-detect.hip more stable

yaxunl created this revision. yaxunl added reviewers: MaskRay, jhuber6. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. some downstream clang is configured to add -rpath to HIP runtime for ld. Also clang may use code object

[clang] ef888bc - [HIP] Make test rocm-detect.hip more stable

Author: Yaxun (Sam) Liu Date: 2023-08-06T18:08:09-04:00 New Revision: ef888bc67c726deb8c74ea32e7c8c9ace756b667 URL: https://github.com/llvm/llvm-project/commit/ef888bc67c726deb8c74ea32e7c8c9ace756b667 DIFF:

[PATCH] D157243: [HIP] Make test rocm-detect.hip more stable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef888bc67c72: [HIP] Make test rocm-detect.hip more stable (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github